yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] dk_zero-cool:
Well I do see the problem, just not the reason.

Android has two places where keys are handled. The first is mostly configurations after which the keys are sent to be handled in a second place. A few keys are handled by Android in the first place, Power being one of them, while buttons like volume is handled in the second place. Xposed Additions overtakes both these places. And Unlike Android, Xposed Additions uses consistency by keeping all configuration in the first place and all actions in the second.

For some reason Xposed Additions fails to overtake the second place on your device, but it does overtake the first place just fine. This means that Android handles the second part and Xposed Additions only handles the first part. But since all Xposed Additions actions is done in the second part, you do not get any actions from it. And since Android handles Power in the first place, which Xposed Additions has overtaken, your Power button will have no action at all.

You seam to be quite good at collecting logcat output. What I need to begin with, is a log from the time your device is turned on and until the boot animation is gone. There must be some kind of error during boot since it fails to hook this particular method.
[Xposed Framework Modules] ayoubij:
[MENTION=3147360]dk_zero-cool[/MENTION] i have version 3.5.2

I noticed a major bug, i didnt know it was this module causing it until today

When my screen is off and playing music, and i press volume down key to lower my volume, it would like get 'stuck' and keep lowering until no sound. And only i can increase volume if i turn on screen because pressing vol up when screen is off will not do anything.

I dont have any assignments in the volume buttons in the app btw.

is it a known issue and can be fixed hopefully? Thanks
[Xposed Framework Modules] TwinAdk:
What phone and ROM? I have never had this issue, M7_UL on AICP lollipop ROM.

I think a logcat would be greatly appreciated too! :)

Kind Regards

TwinAdk
[Xposed Framework Modules] ayoubij:
Its on 4.4.4 touchwiz rom on i9300

In the newer version, that was broken and removed i didnt have this problem btw. For now i disabled the module and volume buttons are working properly
[Xposed Framework Modules] Kiristiba:
Hi

I have tried to get the boot log for you >>klick<<

its not exactly from beginning to end of bootanimation.

If you miss something, just tell me and i will try once more :)

greetings and big thx

Kristin
[Xposed Framework Modules] sirs2k:
It would be freaken perfect of it can be a tasker plugin!!!

I want to run buttons differently in the car fur example!

But still a great app, Thank you!
[Xposed Framework Modules] Dj Telo:
In the meantime you can launch actions with an if-then structure inside. I do it all the time, but I agree that your feature request is cool!
[Xposed Framework Modules] dk_zero-cool:
I will look at it when I get some of the other issues fixed

It seams to have what I need, will look at this tomorrow. Logcat is not deleted right away, it keeps a large cache (depending on the device memory). So even though you might not have initiated logcat right away, you still get the beginning, which is the case here it would seam.

Yes this would be a cool feature. But the module is not built to manipulate configurations from outside the app. This needs a complete redesign of the whole configuration part of the module, which is not a small task. And then there is the time needed to figure out how plugins work in Tasker along with designing and building it. I simply do not have time for that at the moment.
[Xposed Framework Modules] sirs2k:
Why does it restore to default and reset all my settings randomly?
[Xposed Framework Modules] TwinAdk:
Allow external controls in the module. It requires donation, but according to people using the feature, it's great :)

Kind Regards

TwinAdk
[Xposed Framework Modules] Liefen75:
I see others have the same bug as me, configuration disappearing after reboot. I'm using cm11 android 4.4.4 On a samsung galaxy s4
[Xposed Framework Modules] dk_zero-cool:
Just use the same solution as the others. Switch version 3.5.3 with version 3.5.2. The 3.5.3 was a failed fix for Lollipop, makes no difference on Kitkat.
[Xposed Framework Modules] ayoubij:
But in 3.5.3 i dont have volume button bug when screen is off that i described earlier. On 3.5.2 i have this bug. Even only if i activate the module without assigning any button
[Xposed Framework Modules] dk_zero-cool:
The only difference between those two versions, is how they save the settings when the phone is turned off. There is nothing in the module that has been changed. Everything controlling the buttons is placed in different files and have not been touched in any way between those versions.
[Xposed Framework Modules] ayoubij:
Well thats weird. Is ur module known to conflict with any other module?

I dont have many but i have wanam xposed and volumesteps+ which are related to volune. But its only when i activate your module that volume button go directly to zero when pressing vol down when screen is off
[Xposed Framework Modules] robertogl:
This is Wanam, for the zero volume problem, I had that time ago.
[Xposed Framework Modules] dk_zero-cool:
It is possible for two modules to conflict yes, If they try to do the same task in different ways. It's like having to people try to steer a car in different directions at once.
[Xposed Framework Modules] ayoubij:
But with your module im not even touching volume buttons. Even if i clear data from your app, just only its activated in xposed and it causes this problem [emoji14]
[Xposed Framework Modules] robertogl:
Disable volume button options on Wanam and use Xposed Additions to do the same things. It will work.
[Xposed Framework Modules] gerhardo:
This module intercepts all buttons, regardless if a condition matches or if they are configured. Normally, it is not an issue more than adding a delay. (I have submitted patches to not handle keys where no condition matches, not yet accepted.)

If several modules intercepts keys, it depends on the priority (this module uses default, other with same prio depends on load order) what the result is. For keys, the handling is both in queing and dispatching, it may be that one module controls and the other dispatching...
[Xposed Framework Modules] ayoubij:
Thanks. That did it.

Btw do you know what the action headset hook means?
[Xposed Framework Modules] Dj Telo:
It's the button some headsets have. The reason I can't live without this module. :P
[Xposed Framework Modules] guap:
I have to report a little bug (?) On my xperia z1c (latest official firmware) activating this module results in no vibration from softkeys, even with no actions defined. Any hint?

Thank you btw, this module is REALLY useful on my tablet in car dash system, finally i can map hw button to player/music and drive A LOT safely :good::cool:
[Xposed Framework Modules] gerhardo:
This module is primary designed to work with AOSP ROMs, as the internal changes made by other manufacturers are unknown. You may need to have access to a ROM to support it. So problems like this are not uncommon.

If you take a logcat, it may be possible to find a workaround (dk_zero-cool has implemented workaroundsfor Samsung).

Note that this modules intercepts all buttons regardless if there is a condition matching or even configuration for a key. I have submitted patches, not merged.
[Xposed Framework Modules] guap:
here is logcat, hope it will be useful to address some workaround

xperia z1c, android 4.4.4 rom 14.4.A.108
[Xposed Framework Modules] Kiristiba:
Hi, do you already have a clue how you can fix the bug I'm experiencing?
[Xposed Framework Modules] gerhardo:
Nothing in the log. Did you enable debug and reboot first?
[Xposed Framework Modules] dk_zero-cool:
I had a look at this log, but it seams to have been taken to late after all. If there is some kind of crash during boot (which I hope, makes it so much easier to locate), it will be right after Xposed Framework instantiates the module. This is done very early in the boot process, which does not appear to be included in your log. You need to get this log using ADB from a terminal, which needs to be running the second your device has been turned on. If you are already at the end of the boot animation, it is too late.
[Xposed Framework Modules] dk_zero-cool:
I already know what is causing your issue. Your issue is caused by a fix added for newer Samsung devices, and I am not sure yet if I can fix it without re-producing the Samsung issue. I will look at it once I get the more pressing issues sorted out, like the loss of settings during reboot or devices with broken re-map functions.
[Xposed Framework Modules] stephendt0:
Like others. I'm having issues with settings being lost on reboot. I assume this is due to SELinux being in Enforcing mode. Am I better off waiting for a fix or should I try to disable SELinux?

Edit: Setting SELinux to permissive makes no difference
[Xposed Framework Modules] D200P13:
so is there no hope? i neeed this mod! running cm12 lollipop on note 4. i even tried titanium backup which did not help.
[Xposed Framework Modules] dk_zero-cool:
This issue is being looked into, but like mentioned in a lot of previous threads, disable selinux and downgrade the module to 3.5.2 for now.
[Xposed Framework Modules] D200P13:
module is 3.5.2 and selinux is disabled. still doesnt work using note 4 with cm12 rom lollipop xposed 3.x
[Xposed Framework Modules] dk_zero-cool:
In that case I am guessing that you are using an app to disable SELinux. Those apps disables SELinux after boot, but Xposed Modules are loaded before that. But it does not mater, I am releasing a working version within a day or two.
[Xposed Framework Modules] tovarish:
I have this problem too and I am on kitkat 4.4.2
[Xposed Framework Modules] D200P13:
i was using cm and its set to permissive mode by default. i was going to switch roms but ill just wait for the new update.
[Xposed Framework Modules] belluz:
Also the same problem on Note 4 with KK 4.4.4

Inviato dal mio SM-N910F utilizzando Tapatalk
[Xposed Framework Modules] stephendt0:
Awesome news, I will be ready to test and provide feedback when its available :good:
[Xposed Framework Modules] lukair1983:
Hi

First of all, amazing mod. Will deffinetly purchase pro version soon to support the dev.

I got the following question for now. Can I somehow remap all the headset volume buttons to do nothing? I was able to map the main headset button to do nothing and it works, but the volume keys are still registered. Any way I can achieve that?

Lucas
[Xposed Framework Modules] egingell:
They're probably tied to the phone's volume buttons.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] dk_zero-cool:
If they are registered, then you should be able to add them to the app and disable them. If not, then I don't know. I do not have headset with more than one button. But like mentioned above, they are properly redirected as volume keys, which means that you would most likely disable your normal volume keys as well. If you try to add the buttons in the app, what do they get registered as? I am looking for the key numbers.
[Xposed Framework Modules] egingell:
I just tried on my S2. They are the same buttons as the volume buttons - changing one changes the other.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] robertogl:
Same for S4 (touchwiz or cyanogen).
[Xposed Framework Modules] lukair1983:
Thanks guys

I will be home today and I will check that right away!

During my research though I did find something else. Anybody have any knoledge about mapping files residing in keylayouts folder? Those volume buttons have to be mapped somehow and they must be distinguished from the phone volume buttons as they are different entities (although mapped to the exactly same thing). If I could remap those headset buttons to do absolutely nothing I would be home...
[Xposed Framework Modules] robertogl:
The phone sees volume buttons and headset buttons exactly as if they were the same thing.
[Xposed Framework Modules] lukair1983:
Damn it :/

Well, then maybe you guys know how I could disable "headset with buttons" mode or force a simple headset with 2 channels? My jack port started acting crazy and after research I found this is something very common. I already tried apps like phone about or those headset disablers but none worked flawlessly so I thought maybe xposed to the rescue :/
[Xposed Framework Modules] egingell:
Get some headphones with no buttons.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Ranomez:
If you go in the remap settings of a button all the settings are grayed out and disabled till you select to remap, except for this one, this one is actually normal, you can select what the double click will do, but no effect till you enable remapping, also thank you for the reply on my previous post, no problem for me.
[Xposed Framework Modules] dk_zero-cool:
Oh yes that, I know. But I am rebuilding that section anyways, so it will be fixed in next release.
[Xposed Framework Modules] shinpil:
I found two bug

1. If I change long pressing home button to none, I can't use screenshot feature by long pressing home button and power button together.

2. If I change short pressing menu button to recent app and long pressing menu button to menu, long pressing menu button operate odd on some apps like dolphin browser and boat browser.

I hope you fix these bugs on next version:laugh:
[Xposed Framework Modules] dk_zero-cool:
There is no fix. If you enable Re-map on a button, then the module handles that button, ALL of the button, clicks, double clicks and long press. Android has no way to inject long press, so I cannot fix that.
[Xposed Framework Modules] shinpil:
Hmm...

I think you can add the code which contains screenshot feature by long pressing home button and power button together if re-map the home button or power button.

Then I can use screenshot feature whether I re-map the button or not.
[Xposed Framework Modules] dk_zero-cool:
Okay new release is out.

I have removed all buttons from the Re-map list. You can now add whatever button you would like instead of having to look an buttons that your device might not even have. I have added a button capture feature. You just select "Add Button" and press the button you would like to add. This will also allow you to capture different buttons that your headsets might have available. Any key you add, will also be added to the Re-map action list, allowing you to assign other keys to handle that event.

I was also able to (Never thought that would become possible) allow default long press action to be sent to the dispatcher. This means that long press actions on Re-mapped buttons that is set to default, will work on applications. And yes, it also allows you to change the volume by holding down the key, even if you Re-mapped click and double click events.

Haptic Feedback is added as well. So if you have this enabled on your device, it will now work on Re-mapped buttons as well.

The UI has changed. Sleep and Awake options has been merged into one screen, only displaying one at a time. You can select which option to change from a list view within the Re-map settings.

And last I have added a request of my own. I always keep orientation disabled, because I hate to have to be careful how I hold a device to avoid rotation. But I also hate having to enable/re-disable every time I want to change orientation. So I have added orientation actions to the Re-map options, allowing you to assign key actions to rotate the screen to the left and to the right. Note however that this is not available in Gingerbread. You will need ICS and above as Gingerbread does not seam aboard locking orientation to anything other than Portrait. If anyone knows how, then let me know.

And do remember to reboot after updating, before you try to add buttons. The old module does not support key capturing, so you will not be able to capture anything before the new module is active.
[Xposed Framework Modules] spätzlemitsoß:
Thanks for the new release, but i cant add any button to remap??

First it did not recognize the buttons and after reboot app crashes on remap screen?

using S4 with stock rom.
[Xposed Framework Modules] dk_zero-cool:
I need a log from the crash
[Xposed Framework Modules] spätzlemitsoß:
Got it working now by uninstalling, rebooting, reinstalling and rebooting.

Installed before you posted instructions and tried to remap without rebooting before. After this the app always crashed...

All fine now! The new key capture/add button feature is awesome!

btw: will "launch app" or "close foreground app" for remap make it to next release? really missing that feature.
[Xposed Framework Modules] dbesoli:
Hello,

I have installed this module 'cos i'm interested in the usb control.

I have samsung galaxy s2 with stock rom I9100XWLSZ and XPosed 4.2 with Xposedbridge.jar 36

Other modules: Disable clear defaults dialog, disable location consent, disablebatteryfullalert, enablecallrecording, smart alarm icon and Zoopa clock

The issue is that i can't avoid the screen awake when I plug/unplug usb. I've tried all this modul options with no success. but i want "wake on plug/unplug" NEVER.

Is there some issue with galaxy s2? any other user have this setup working on this devices?

thanks
[Xposed Framework Modules] dk_zero-cool:
Well Samsung could have changed something, hard to know with closed source garbage. If you get a logcat during boot, it may have something to say about it.
[Xposed Framework Modules] gladson1976:
Was eager to try the button capture feature to see if it capture the button on my bluetooth headset. No luck :(

Was able to get the button on the wired headset.

If only it could get that bluetooth button...

Sent from my SK17i
[Xposed Framework Modules] alirezaafkar:
Open Application is not implemented ?
[Xposed Framework Modules] xXYoshiXx:
The new release breaks the function of LMT launcher's back, menu and search button.
[Xposed Framework Modules] dk_zero-cool:
No surprice there. Bluetooth properly has it's own query function like screen touches do.

In 3 days along with what I have just added and changed? I work fast, but I still have limitations. I am kind of human you know ;)

I don't know LMT launcher, so you will have to tell me what you mean by breaking? And how did you setup the Re-map?
[Xposed Framework Modules] xXYoshiXx:
Never mind, after upgrading, the buttons of LMT (kind of custom version of pie control) weren't working even I didn't re-map a thing. After clearing data for XPosed additions it started working, maybe an upgrade problem.
[Xposed Framework Modules] dk_zero-cool:
Did you reboot after upgrading? The config names has changed, so changing the new configs would not change the old if still running.

Anyways, this means that it works for you then?

And if so, what exactly is working? How did you set it up and what is the launchers features?
[Xposed Framework Modules] xXYoshiXx:
Yes I rebooted the device after updating, but it works fine now, so I think it was something wrong while upgrading, had an similar issue with another module the last days which I solved by clearing data.

Thanks
[Xposed Framework Modules] Saeedblack:
thanks of you r job

version 2.1 fully working on my device

but unfortunately version 2.2 have FC

my device is sony xperia s JB
[Xposed Framework Modules] dk_zero-cool:
A log from you can fix that
[Xposed Framework Modules] lukair1983:
Thanks for the tip :p

Ok, to clarify I have one pair of shure headphones (without any buttons on them) which I use constantly and original samsung headphones(with buttons) that I got with my galaxy s4. The problem is my headphone port started to register my shure headphones as a set with buttons resulting in sending volume up/down, music stop/skip etc to the phone. I was able to disable one part of the problem by disabling that headset button with xposed additions. The other part which is disabling the volume signals is what I'm currently working for.
[Xposed Framework Modules] egingell:
I see how that might be a problem. You can disable the buttons and still be able to control the volume, just not with the hard-keys.

Have you tried a Bluetooth adapter? You plug the headset into the Bluetooth thing instead of the phone. You can get one from Amazon for about $20 with Prime. Plus, you can pocket your phone more easily.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] lukair1983:
Thanks for the suggestion but no adapters please.
[Xposed Framework Modules] egingell:
Suit yourself. I don't like them much, either. It's just one more thing I have to keep charged and it's not as loud and it doesn't sound as good. But we're starting to get off-topic here.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] francwalter:
Hallo

I use the Additions on my Samsung Galaxy S4 with CyanogenMod 12 (nitely from yesterday) and I flashed the Xposed 3.0-alpha2.

I have CM12 just since some days and noticed that the settings of my Keyboard Shortcut won't survive a reboot.

I have defined a double click to make a screenshot. This works but after reboot this keyboard condition is deleted.

The version 3.5.4 from today doesnt change it unfortunately, despite it is written in the changelog.

The only thing which is saved is the Double click and Long press delay but not the key conditions.

frank
[Xposed Framework Modules] Dj Telo:
I have just updated the module from the play store. I have configured everything and I am going to reboot now. I cross my fingers.

---------- Post added at 04:11 PM ---------- Previous post was at 04:04 PM ----------

And my settings are gone... :(

Edit: a soft reboot to make the se linux permissive did the trick. Works!
[Xposed Framework Modules] dk_zero-cool:
Makes no sense. Settings are now written by the app itself and not the module. SElinux should have no impact. One question though. Did you configure before rebooting after updating the app? The updated part of the module is not activated until a reboot. So the changes that fixed the problem does not work until next boot.
[Xposed Framework Modules] Dj Telo:
I am pretty sure that I did a reboot after updating, then I configured, rebooted again and the settings were gone. Before rebooting for the second time, I had made a backup of the app which I restored to recover my settings...

I must be missing something in my explanation. Anyway, do not take what I say seriously, the module now works perfectly!

One request, would it be too hard to make the configuration of a key be the same in several states (on, off, lock)? Maybe a copy paste feature of a key mapping?

Thanks for your hard work, these last weeks without your module I felt like something was missing on my phone.
[Xposed Framework Modules] robertogl:
Don't restore the backup, try to setup again the module.
[Xposed Framework Modules] dk_zero-cool:
I have already been thinking about something like that and more. But at the moment I don't have time for such large changes. It would require a lot of changes and I am pretty swamped at the moment. But at some point I will make a lot of changes to this module to make it more dynamic, but this will not be before after the summer.
[Xposed Framework Modules] egingell:
For the record: Previously, the module (the part loaded by Xposed during boot) wrote the preferences and now the app (the part loaded by Android long after boot - aka the GUI) writes the preferences. A change such as this would change the owner of the preferences file effectively making the old one read-only. Android may even delete it because of the owner mismatch.

Module owner = system or root... or the target hooked app.

App owner = Xposed Additions (ID assigned when installed).

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] gerhardo:
Not exactly that but similar functionality: My mod of this module adds the possibility to use Screen On for unconfigured keys. So other conditions are like an overlay.

The implementation is therefore very simple, not limiting functionality too much IMO.

(It is in the public build and mt github clone, not in the current pull request).