yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] dk_zero-cool:
Among Torch apps, there is a standard for Intents that says <package>.TOGGLE_FLASHLIGHT, for an example com.my.package.TOGGLE_FLASHLIGHT.

The module looks for packages with this support during boot (which means that you of cause has to reboot after installing a Torch app), and uses the first one that is located. The reason why it looks at boot only, is because Google have not added any way to get a list of available Intents. So the module has to loop through each installed application and test if a supported Intent is available. With a couple of hundred apps installed, this can take time, so we don't want to do this on each package change.

And the reason why I am not adding native support for flashlight is this. Most of these flashes on devices (Except a few newer Sony devices), are not meant to be on constantly. They could actually break when used as a constant light source. For this reason, there has been no reason to add any separate control to them. The only way to get this flash to constantly light, is to create hidden activities with services running hidden camera previews and a bunch of other hacky stuff. This module is a key-remap module, which means that it was intended to make one button act as another. Still there has been added a few additional actions, but since it is not the purpose of it, I do not want fill it up with this type of crap code (and believe me, it is crap. Brilliant by whomever came up with the idea, but it is not pretty). I know that for someone who does not read code, a small light might seam simple enough. But there is actually more going on behind the curtains with even the smallest things. Especially if those things is not actually supported by the API of the OS to begin with.

And since I forgot to mention this is earlier posts, let me repeat the above. You need to reboot after installing a Flash Light App.
[Xposed Framework Modules] b2rdetor:
Tested. Isnt work with additions (((.

I understand why you are not implemented torch code. But my custom rom hasnt flash. I ddont know noone custom based on android 4.4.2 with build in torch... so its a problem for me.

Yes - i can instal other xposed module with torch on volume keys, but i ddont want too many xposed modules in my ssystem. And also that module can give a wakelock after using torch...

So i will try cyans torch after i got it
[Xposed Framework Modules] b2rdetor:
Tryed torch from cm - its crashing... isnt work...
[Xposed Framework Modules] diigibio:
Sorry if it has already been mentioned but is anyone on a Samsung Galaxy S5 ((International lte)G900F) having the following issue?

When I have this module active it interferes with the recents hardware button (that used to be menu on older device's) I haven't even added that as a button and it causes it to act just like the menu button. I believe the new standard behaviour for this button is single press for recents and long press for menu. I have tried to add the button and configure the same behavior (like when having to set up the home button in additions in order to have the home button wake the device. But no joy. I have purchased the full product. Here is the email address I used diigimatrix@googlemail.com . Any support would be great, I would really love to continue to use this module as it is really handy and makes others jealous they can't do that. Thanks
[Xposed Framework Modules] gerhardo:
The module intercepts all buttons (adds a delay) and forwards the original button when click/long-press is confirmed.

However, all flags (possible extradata) is not forwarded.

I have submitted a patch for this handling, both forward unconfigured buttons directly and to include flags for default handlng for handled buttons (that also may handle the Home wakeup) that is not yet accepted.

A test build is available on page 131 though.
[Xposed Framework Modules] dk_zero-cool:
Of the 3 patches that you have provided on github, which one contains that part? Also nice catch, have actually not thought about the additional data. Most ROM's does not use much more than the key code, but it would be a possibility that some Samsung and HTC ROM's uses some additional info for the Recent key. It would explain this issue.

The problem however would be custom keys. As he said, the problem did not go away when adding matching custom setup to the key. And without the original key code, it would be impossible to figure out what kind of info a specific ROM would need to work properly. Especially if this differs to much depending on manufacturer.
[Xposed Framework Modules] diigibio:
Thank you. I downloaded and installed your modification .apk and this seems to resolve my issue with the recents button on the S5. I mapped the recents key the way it's been setup by Samsung and it has so far been behaving. Will report back if I experience anything over the upcoming days.

Separate issue. In an old version of the additions module when you triggered say a long press on the home button to launch say Facebook whilst on lockscreen it would unlock the phone and launch Facebook. Now it launches Facebook behind the lockscreen (swipe only) and I still need to unlock. Is there any chance that there could be an option say per key or per action that could be ticked to bypass this and have it auto unlock and launch said application. This would give those people who don't want to accidentally unlock their phones in their pocket what they want but also allow others to use it in a controlled manner. I would like to launch the remote control app so one double tap of volume up would launch it from the lockscreen.

Doesn't matter if not but I personally would find that very useful.

Thanks for all your help and support.

Phil
[Xposed Framework Modules] dk_zero-cool:
Yes I did have it unlock the device at one point, but this also affected pattern and pin locks. I can re-add something for swipe locks only.
[Xposed Framework Modules] diigibio:
That would be amazing if you could. Thank you for taking time out to listen to me and take on board suggestions. It's obviously your app module and your hard work. Please note that I appreciate your help, support and willingness. :)
[Xposed Framework Modules] gerhardo:
What about App shortcuts here?

Then the user could unlock with Tasker or Llama or something.

(App shortcuts is not easy, but could extend this module a lot.)
[Xposed Framework Modules] dk_zero-cool:
App Shortcuts is already on the Todo. But as you said, they are not easy and not very documented by Google either. So I will work on that once I get the rest of the ongoing stuff done. Things like adding control to Samsungs Haptic replacement method (Which would fix double haptic and also remove the need for forced haptic), fixing some of the minor bugs and having a look at what you have provided on github.
[Xposed Framework Modules] Hypocritus:
Problems using USB controller in 3.x.x

I am a purchaser of the Pro addition. I really enjoy the "apps mapping" of the versions above 2.3.8

However, with any version above 2.3.8, I cannot use my USB game controller. I have to disable Xposed Additions, then reboot to use the USB controller. After I am finished, I then have to re-enable Xposed Additions and reboot to be able to use app mapping.

Specifically, the USB buttons do not function in my game app when using XA 3.x.x, whereas they do in 2.3.8 or below. I do not have the buttons remapped to anything. The analog stick continues to work fine in any version.

This issue persists in the latest version, 3.2.2

What can I do to avoid this (besides not using the controller)?

I'm using ICS, on a rooted EVO 3D.
[Xposed Framework Modules] dk_zero-cool:
The module should not affect external controllers, keyboards etc. as long as you do not enable external devices in the settings. Did you check/enable the external checkbox in the remap settings?
[Xposed Framework Modules] Hypocritus:
I did that and the result is the same, either way. Another piece of info that might be helpful: when using 2.3.8, in the game app, the controller buttons register as solid in the button mapper utility when I hold them down. With 3.x.x, as I hold the button, the game button mapper flashes once for like 1/20th of a second and then registers as not being pushed, no matter how long or short I hold it.
[Xposed Framework Modules] gerhardo:
There were changes to default button handling in 3.x. Buttons do not set the same flags when the default handling is executed.

I have tried to handle that (as well as eliminating delay for non configured buttons) in the patches I have submitted to dk_zero-cool.

There is a link to a test build on page 131.
[Xposed Framework Modules] mkdr:
Aehem... what? I said... that this one, the rc, was the LAST which WORKED. After that one, you broke your own app. So, wheres the update? It's still just 3.2.2 out, which is broken (since months). Issues were explained in this thread, with logs (2 month ago). I have bought your pro version btw, which I cannot use. I want this damn app out of my market so I can use auto update again and not manually tapping 20 apps per day.
[Xposed Framework Modules] dk_zero-cool:
Well the RC might have worked for your specific issue, but it did not for many others. Just like the newer broke something on your device, but not for many others.

There is a lot of devices in the world, and even more different Android versions. So when doing things that is normally not meant to be done, like hacking the core with XposedBridge, you may run into difficulty getting all devices to respond the same. Especially since I cannot test every device myself.

Now I have worked hard and spend a lot of time on this, and I will spend even more. However I do also have other things in my life besides this module, like work, family etc. And you may have bought the pro (which I do thank you for), but the payment is only symbolic. Those few $ does not pay the bills, they do not make up for the time spent on this and they also do not provide enough reason for me to abandon my family. I am only one man, not a company. I will work on this when I have the time for it, even if you have to wait a month or two for an update.
[Xposed Framework Modules] gerhardo:
You could try my mod. Take a backup first and it is easy to go back if there are other changes you do not like.

This specific change should be fixed in dk_cool-zero's next update, the change is simple - but it has to be coordinated.
[Xposed Framework Modules] siavash2death:
[MENTION=3147360]dk_zero-cool[/MENTION]. Hello. Could you please add something to your mod? Ability to take pictures. I want to set power button for taking pictures when I press it in a camera app.is it possible?
[Xposed Framework Modules] ImpheOtus:
It's already possible if you buy the app.
[Xposed Framework Modules] gerhardo:
You need an Camera app that has an external interface to take pictures. Most stock Camera do not have that interface, some 3rd part support the Camera button. (If App Shortcuts are supported there may be some other options using intents but that is definitely for advanced users only.)

The Free version allows general remapping, you could use volume for instance.

You need the Pro version to remap Power to Camera in the Camera app only.
[Xposed Framework Modules] siavash2death:
Could you please explain to me how you do that?
[Xposed Framework Modules] dk_zero-cool:
Without Pro:

With Pro
[Xposed Framework Modules] mnz007:
Torch is not working ! :(

Sent from my Galaxy S2
[Xposed Framework Modules] dk_zero-cool:
Not if you are missing a Torch App it don't. Install one and reboot...
[Xposed Framework Modules] mnz007:
I'm using a "Flashlight" app. I will try this one :)

Edit: Torch App not working. .

Sent from my Galaxy S2
[Xposed Framework Modules] dk_zero-cool:
The torch app might not support intent calls, not all of them do. However, check the log before trying others to see if there is an error. You can access the log from the settings part of the.
[Xposed Framework Modules] churrolakra:
Hello OP.. I found a bug...

While I am listening to music with the screen turned off... if I press the volume down button to decrease volume one step, the sound gets muted..

The sameway happens when I am listening music and press volume UP.. then the volume goes to maximum instead of increasing only one step..

when I deactivate xposed additions module in the framework, this bug is not present anymore.. only when the module is active..

Is this happening to anyone else?
[Xposed Framework Modules] cottino:
Yes, same problem for me too with Galaxy S5 G900F :(
[Xposed Framework Modules] dk_zero-cool:
Just uploaded a Beta version to the Xposed Repo. Try installing it and see if these bugs goes away. I have never seen anyone having problems with volume skipping like that, maybe another module is interfering. However, I have added a specific fix to try an fix the Recent Button issue. So the beta should at least fix one of these issues. But I do suggest [MENTION=5315766]churrolakra[/MENTION] that you try disabling all other modules before reporting this again, it might not be the module itself, but rather a combination.

And to everyone else as well, a beta has been uploaded to the Xposed Repo.
[Xposed Framework Modules] t61p:
Thanks for beta version.

It seems that the reboot issue caused by Previous Application action has gone.

HTC Recent App button issue still exists on HTC J(stock 4.0.4) which is a variant of HTC One S.

If Xposed Additions is installed, the app switch button at bottom-right loses its default action even without any assignment to the button. Well, it is possible to detect App Switch button by Add new key and also possible to assign new actions there. However nothing happens.
[Xposed Framework Modules] PunchUp:
The latest beta gives me a black screen. Nothing appears in the Xposed log though
[Xposed Framework Modules] fenchai:
Hi guys, I am right now on 2.3.8 stable, everything works... by everything I mean everything.! :D

I am on GALAXY s5 and I have no idea why the latest version will not work, not even changing a simple recent button into a menu button...

Please, anyone have any idea?

I'm on G900H
[Xposed Framework Modules] a.fontenele:
Dear [MENTION=3147360]dk_zero-cool[/MENTION],

First of all thanks for still providing updates for this module which makes my humble S3 rock...

Do you have any idea of what could be causing my phone to soft reboot over and over again when testing the latest beta you provided? I tried to get a log, but the only thing I can do is disable the module to prevent further rebooting...
[Xposed Framework Modules] PunchUp:
Sounds like the same problem that I'm facing.
[Xposed Framework Modules] Thorkle:
Can anyone confirm if this works on a Verizon variant galaxy s5? I've heard people breaking their buttons trying to use scripts, hoping this will work because I miss having a dedicated menu button!
[Xposed Framework Modules] dk_zero-cool:
I need a log during boot along with a bit more information in what you mean by blank screen?

No I can't know without a log. However, seen as you have the SGS3 (Like me), I'm maybe able to test this myself if you provide a link to the ROM that you are using.

Not working does not help. Could you describe the problem with a bit more details? Also check the log from the app.
[Xposed Framework Modules] dk_zero-cool:
So the settings part detects the recent app button? No custom actions work? And by custom actions I mean the Custom Headline in the actions list, not remapping to another key. What about default actions, what happens if you don't assign anything?
[Xposed Framework Modules] PunchUp:
Black screen thing is probably just a problem with my ROM. It fails to reboot and gives me an unresponsive black screen. But apart from that, I think it's the same issue mentioned by [MENTION=1240079]a.fontenele[/MENTION] Constant reboots

I'll try to grab the log using DDMS
[Xposed Framework Modules] Getodacul:
Bootloop

3.3.0b give me a bootloop. I use HTC One M8 with stock Android 4.4.2 GPE rooted. I have the lastest Xposed Framework. I disabled temporarly Xposed Framework and reinstalled Xposed Additions 3.2.2 and bootloop dissapear.

I write here after uninstall/reinstall, sorry, when Xposed was disabled i forgot to save the error logs.
[Xposed Framework Modules] limestone:
Hi dk_zero-cool	:

I'm on LG G pro, running kitkat 4.4.2.. on your latest 3.3.0b now. Comparing to 3.2.2, it has brought back my power button function, but I have lost my camera button function ever since 3.xx. (in your app, it is identified as info button). Is there a way to delink the camera button from additions? cos I don't want to remap that button.

Thanks many many times in advance!
[Xposed Framework Modules] dk_zero-cool:
It is not my app that identifies it as Info Button. The information is coming from Android itself, which means that this is the key identifier that LG is using for it. They are defined in custom idc files in /system/usr/.

But I might be able to create some sort of blacklist to exclude specific keys. But at the moment, this is still beta. Which means that the issue might be gone once I dig deeper into these issues, as I suspect that the problem is similar to the HTC/Samsung Recent App button issue.
[Xposed Framework Modules] fenchai:
OK I'll try to check on the logs, I will send it to you later, right now I am fine with 2.3.8, but the new features can't hurt.

by not working anything I mean, I try to set recent apps button to menu(not only recent button, also home, volume up down etc.. ) , it simply denies any action, any button set to a custom action will make the button unresponsive or not activate, or have no function at all.

This happens on all versions higher than 2.3.8 :(
[Xposed Framework Modules] t61p:
Yes. The button is detected as 'App Switch' through Buttons > Add new key.

I'm not sure if I get the point of the question, but...

After 'App Switch' is detected, it is possible to proceed App Switch > Add new Condition > Screen On > Click, and also possible to remap it to 'Home' for example, or another key. However click 'App Switch' button doesn't act as 'Home' button.

The default actions are simply lost and nothing happens by tapping the button if xposed additions is just installed.
[Xposed Framework Modules] dk_zero-cool:
Does remapping recent button work in 2.3.8?

I mean that if you set the button to a custom action (Not a key code), something like power menu, recent apps, rotation etc. does this work?

What does it act as? Regular recent apps or no action?
[Xposed Framework Modules] limestone:
I have another feedback on 3.3.0b: it crashes my OS everytime I try to uninstall an app. And it will not let me complete any new app installation on Google Play.
[Xposed Framework Modules] t61p:
I understood. I set the button to Power Menu, Recent Apps, Orientation Right and confirmed they don't work.

I mean no action.
[Xposed Framework Modules] dk_zero-cool:
Does not help. I need a log of this

It sounds like it's not getting dispatched for some reason. What ROM are you using?
[Xposed Framework Modules] t61p:
safer aponet

I use HTC stock ROM android 4.0.4.

By the way, I also tried with gerhardo's 3.2.2.7 version and it works as expected.
[Xposed Framework Modules] limestone:
ok, adb logcat coming your way! I hope I captured it correctly..
[Xposed Framework Modules] dk_zero-cool:
Strange. He's suggestion was to use the default flags, which I have already added to the beta. So default behaviour and custom actions work on that one?
[Xposed Framework Modules] PunchUp:
This should be enough I guess?

07-02 14:37:52.827: E/AndroidRuntime(4250): *** FATAL EXCEPTION IN SYSTEM PROCESS: main
07-02 14:37:52.827: E/AndroidRuntime(4250): java.lang.RuntimeException: Error receiving broadcast Intent { act=android.intent.action.PACKAGE_CHANGED dat=package:com.sonyericsson.music flg=0x4000010 (has extras) } in com.spazedog.xposed.additionsgb.backend.pwm.Mediator$4$1@426502d8
07-02 14:37:52.827: E/AndroidRuntime(4250):	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:776)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at android.os.Handler.handleCallback(Handler.java:733)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at android.os.Handler.dispatchMessage(Handler.java:95)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at android.os.Looper.loop(Looper.java:136)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.android.server.ServerThread.initAndLoop(SystemServer.java:1245)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at de.robv.android.xposed.XposedBridge.invokeOriginalMethodNative(Native Method)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:631)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.android.server.ServerThread.initAndLoop(Native Method)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.android.server.SystemServer.main(SystemServer.java:1342)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at java.lang.reflect.Method.invokeNative(Native Method)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at java.lang.reflect.Method.invoke(Method.java:515)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:611)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at dalvik.system.NativeStart.main(Native Method)
07-02 14:37:52.827: E/AndroidRuntime(4250): Caused by: java.lang.NullPointerException
07-02 14:37:52.827: E/AndroidRuntime(4250):	at com.spazedog.xposed.additionsgb.backend.pwm.Mediator$4$1.onReceive(Mediator.java:450)
07-02 14:37:52.827: E/AndroidRuntime(4250):	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:766)
07-02 14:37:52.827: E/AndroidRuntime(4250):	... 14 more
[Xposed Framework Modules] t61p:
That's right. Both default and costom actions work.
[Xposed Framework Modules] dk_zero-cool:
Ohh yes, that should do it all right. Thanks.

Not sure why, but it does help knowing that it at least can be working. Thanks for this input, it should help a bit more. Especially since I don't have such a device to debug myself.
[Xposed Framework Modules] a.fontenele:
Thanks dk_zero-cool... Here it is:

It is a stock Jelly Bean 4.3

PDA: I9300UBUGMK6
[Xposed Framework Modules] t61p:
Good to hear that. If you need more test, tell me :)
[Xposed Framework Modules] CynoMan:
Scree off setting still doesn't work on my Samsung Galaxy S™ Duos 2, running JB 4.2.2
[Xposed Framework Modules] dk_zero-cool:
I have not fixed anything screen off related. What is not working?
[Xposed Framework Modules] CynoMan:
No problem, you continue developing this awesome app at your own pace [emoji4]

Long press to play/pause media isn't working when paired with screen off setting.
[Xposed Framework Modules] dk_zero-cool:
Have you tried a different player? Working fine for me with Player Pro
[Xposed Framework Modules] dk_zero-cool:
Well it seams that gerhardo is adding policyFlags to the KeyEvent flags. Since these are two separate things, not sure why this would work, but it is the only thing that makes up the difference. Also Stock ROM's do have their small strange behavior, so it would not surprise me at all.

I will try adding this in the next beta. Right now I want to have these damn Shortcuts added to the App Launch Action, but it is quite clear that Google did not create these for others to use. Bad implementation and even worse documented.
[Xposed Framework Modules] cottino:
Now seems ok, but unfortunately I still can't reconfigure Recent Button
[Xposed Framework Modules] fenchai:
Yes sir, remapping recent buttons work on 2.3.8 perfectly.
[Xposed Framework Modules] CynoMan:
Ok. Will try it out with other players and including Player Pro (currently on PowerAmp) and report back here.