yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] dk_zero-cool:
I don't know what you mean by sound seedback. I build this against Google's original source, and there is nothing in there about sound feedback, so if Samsung has something extra in the code, then that is not something that will be "fixed". At least not unless they at some point decides to release their sources.

Haptic however is a problem, possibly caused the Samsung's kernel. Samsug never have learned how to make proper kernels, so there is not much surprise there. The best option would properly be to have some kernel dev at a kernel thread have a look into that.

No, custom or not, it's still the same base that creates the vibrations. I have no problem controlling the intensity on any of the devices I use for testing.

What ROM and Device is this, more TouchWiz?
[Xposed Framework Modules] shinpil:
I'm using galaxy s4 with 4.2.2.

The haptic feedback became too strong on 2.3.8.

And I cannot adjust the intensity.

The wanam xposed has the option to kill apps by long pressing back button. And it get haptic and sound feedback normally.

Asking his codes would be helpful.
[Xposed Framework Modules] churrolakra:
Working perfect for me on S3 omegarom.. only thing I ve noticed is that when something is remapped to double tap or long press capacitive buttons (menu, back), then when you touch the capacitive button there backlight doesnt light up, but the haptic feedback works and the function too..

this module is getting awesome.. just bought the pro version.. (y)
[Xposed Framework Modules] dk_zero-cool:
Yep, no surprise there :)

He's module is targeted your device and rom specifically. Mine is general and fallows the original Android source. I will not add TouchWiz only code and break every other ROM's, just because Samsung always makes Software that low price supermarket's would not even sell.

Getting Haptic Feedback also is not the problem here. The problem is that the Software on the SGS4 registers some of the buttons wrong. Now, someone who makes a module for this device specifically can disregard this and just have it behave as he wants. I on the other hand, also have to take other devices into account. I cannot just say, let's just treat the back and menu button as capacitive and be done with it. That would cause issues to devices that actually have real Hardware buttons for back and menu.

Now, I can ask him about the sound and see what reaction that will get me, cause it does not seam as he shares the code anywhere. That however will not fix the haptic issue. And I can't see what would, mostly because this is not a "Fix Samsung issues" module, it would become to big if I started with that road.
[Xposed Framework Modules] dk_zero-cool:
Does on mine. Hmm, might just be a question of kicking the current activity. Will see about that.
[Xposed Framework Modules] My1xT:
well, maybe it's time for Plan B, asking Wanam about putting sth. like this in his mod...
[Xposed Framework Modules] dk_zero-cool:
He he, you know, under any other circumstance, I would tell you to..., well something unpleasant. Properly because I would consider that as some kind of threat, and I have never been very good with those. But seen as you are far from the only SGS4 user struggling with these issues, I will just disregard it and tell myself that you may have had a bad day at work ;)

Now, I have written a PM to Wanam, nothing more than to wait and see if I get a response.
[Xposed Framework Modules] My1xT:
I am not an S4 bt a Note 3 user but in terms of this they should be similar...
[Xposed Framework Modules] dk_zero-cool:
Well, this is the response I got so far from Wanam

Now I might have an idea, so if, instead of the threats, you may want to test some thing out on your Note3, then we might be able to get this sorted out a little faster?
[Xposed Framework Modules] My1xT:
no problem, as long as it's not dangerous...

you can PM or hangout me at (almost) any time when I am awake...

-> https://plus.google.com/108827025738341485009/posts

PS.: and also I was NOT threatening you. I just wanted to suggest to ask someone who i knowledgable about Samsung Devices to create something for Samsung Devices.
[Xposed Framework Modules] dk_zero-cool:
Nope, just to test some more changes, but this time make sure that it actually works before releasing it. But first I will revert the custom vibrate class, no need for that if it did not fix anything. The problem is detecting the damn capasitive buttons. Now, after some research, I found another way to detect them. It might give the same identification as the other, but it might also work. That's what I want to find out.
[Xposed Framework Modules] My1xT:
ok no problem post me what I need to test and I'll do this as soon as I can...
[Xposed Framework Modules] dk_zero-cool:
Okay, I have attached the app below. I removed the custom Haptic Class and reverted to using the original and I added another way to test the key type. Hopefully this will catch the capacitive types.
[Xposed Framework Modules] My1xT:
well I notice that the feedback issue is still there, but I tried to set both on default (remap option still active and honestly the first for the short tap comes delayed, but the long tap feedback comes on time (at least for the menu button)...
[Xposed Framework Modules] dk_zero-cool:
Okay, I have updated the above attachment with another possible solution. Try that and see.
[Xposed Framework Modules] My1xT:
no problem but honestly it would be nice if users would stop quoting posts directly above them for mobile users it takes space and for PC users it's annoying.

Instaling right now.

but what's that permission???

anyway still delayed feedback for short tap...

but can you also take a look on the "wake on plug" feature?

I dont want that my device wakes up when plugging it in (therefore set to never) but it STILL wakes up...

also we now have haptic feedback on the vol buttons, I partially like but but on the other hand not so really...
[Xposed Framework Modules] dk_zero-cool:
So now volume buttons is registered as virtual?

I will look into the Plug/UnPlug issue, but as to the feedback, that TouchWiz version has some serious issues. Not sure how much more that I can do. Apparently it does not act accordingly to how Android should.
[Xposed Framework Modules] My1xT:
Just forgot to mention power button has this too...
[Xposed Framework Modules] dk_zero-cool:
Yes, which just confirms that something is wrong with the ROM. This is an Samsung issue. The biggest problem is that this issue is either in the kernel or in the native input handler, neither of which can be fixed using Xposed.

However, the last thing I added to the module (Which now makes it include hardware buttons), is a standard Android Application tool. This means that it will also affect normal Applications the same way. So at some point it would be in their best interest to get it fixed.
[Xposed Framework Modules] My1xT:
But could you add some features from screen on to screen of, most noteworthy being call end???

also here's the kernel source for the Note 3 line.

http://opensource.samsung.com/reception/receptionSub.do?method=search&searchValue=SM-N900

I have the N9005...
[Xposed Framework Modules] alirezaafkar:
Your github has not been updated ?
[Xposed Framework Modules] testrider:
Thank you so much. That's exactly what I was looking for!!!!!!!
[Xposed Framework Modules] dk_zero-cool:
Sure, I was also thinking about changing the two call options. I would like to have just one, and then make it change depending on the phone state. Like, Call End if you are currently talking to someone and Call if the phone is ringing. It makes more sense.

Will do me no good. I am not a kernel developer, so I would not know what to look for. Also, even if I was able to find the issue in it, it would make difference as I have no way to add it to the module. Like I said, Xposed cannot change kernel code, or any other native code for that mater. It can only be used with Java.
[Xposed Framework Modules] dk_zero-cool:
It will be
[Xposed Framework Modules] coolkaas:
dk_zero-cool, thanks for your mod for 2.3 android!

can u add two actions?

send any intent and run shell string? so if intent is difficult, run shell string will enough))

this will very helpful! tnx!
[Xposed Framework Modules] wilflare:
my bad :/

that's a bummer.

shall look forward to the App Launching option then ^^
[Xposed Framework Modules] My1xT:
also I noticed something kinda annoying.

I have set:

Display Off->

(Button Short/Long Action)

Power Disabled/Play-Pause

Vol+ Default/Next track

Vol- Default/Prev track

everytime I hol down Vol+ for Skipping I kill my silent status, can you do womething about that?, weirdly the volume WONT increase or deacrease in any other condition I have yet seen...
[Xposed Framework Modules] ahrion:
Waiting to buy pro version till app launcher
[Xposed Framework Modules] dk_zero-cool:
Sry but you need to elaborate. What is the problem, I dont quite get it?
[Xposed Framework Modules] My1xT:
as you see I have set that long press Vol+ and - while screen off whill give Media Next and Prev track respectively.

the problem is when I press and hold Vol+ while screen off and Silent it works, BUT it also kills the silent status...
[Xposed Framework Modules] dk_zero-cool:
It might not be the module, it can be the player. Try setting long press to something else and see if it still happens. My player turns on the screen when I long press to pause, but that is the player that triggers the screen on pause, not much to do about that other than swiching player.
[Xposed Framework Modules] My1xT:
just tested Samsung Music Player and no problem,, looks like it's Poweramp after all...

maybe there's a gap where the action on Vol+ can kill the silence...

I go asking there for advice...
[Xposed Framework Modules] dk_zero-cool:
No, Poweramp is properly just configured to remove silence when you start a track (I guess to make sure that you can hear the music), like the player I use is configured to trigger the screen when I pause.
[Xposed Framework Modules] My1xT:
but to remove silence wont make sense. since it runs at the media stream anyway...

I will ask there since it's annoying...
[Xposed Framework Modules] dk_zero-cool:
I know, the question would be, does the developer of the app? It could also have been added to fix an issue with a specific ROM or Device. Send the developer an Email and ask :)
[Xposed Framework Modules] My1xT:
they have a large forum, Poweramp isnt a micro app, it's one of the best Players ever. I am just waiting for activation and test this issue with real headset keys later when I am Home...
[Xposed Framework Modules] dk_zero-cool:
Well it is a mater of opinion. I tried it, did not like it. Player Pro is my favorite.
[Xposed Framework Modules] My1xT:
I did try Player Pro but the EQ was not as nice as in Poweramp. I had noise here and there...

and I dont use library features, just the plain old folders...
[Xposed Framework Modules] dk_zero-cool:
Well I use the addition EQ plugin, sounds great. And I to hate all the fancy Meta Tag sorting, which is why I choose Player Pro instead of so many other at that time. Most Players don't have folder views.
[Xposed Framework Modules] My1xT:
indeed, but what I also like is that you can see the folders not only as a Hierarchy but also as complete list and you can sort it by either folder name or by path.

I also used the additional EQ back then in Nov2012 but it was not that great back then. also the Best is that Poweramp got even better over the time e.g. having extremely customizable widgets and you can even re-customize them without having to make everything new...
[Xposed Framework Modules] alirezaafkar:
Camera is not working for Slll

It doesn't open it
[Xposed Framework Modules] dk_zero-cool:
It is not a module problem. The camera button is Re-mapped. Whether or not the camera should open, is up to the installed applications, and the SGS3 default camera app is not build to open on camera button. It is build to take pictures with the camera button. So direct this complaint to Samsung.
[Xposed Framework Modules] spätzlemitsoß:
hi dk_zero-cool,

Is it possible to add a screen off / lock phone action in next release? would be a nice addition.
[Xposed Framework Modules] dk_zero-cool:
Not sure what you mean?
[Xposed Framework Modules] spätzlemitsoß:
sorry, skip it :) power already toggles screen on/off...

Never used it before and was searching for Power Off..
[Xposed Framework Modules] dn06se:
option to remove vibration when charging

Can OP add option to remove the vibration when choosing not to turn the screen on during plugging (charging) and unplugging. It is a bit of annoying and waste battery (my facing condition: during charging, my phone will keeps on vibrate briefly in certain time interval untill the phone is unplug.).

However, others function as intended. :fingers-crossed: :good:

Remark:

xposed additions v2.3.8

xposed framework v2.3.1

note 2 internation stock touchwiz 4.1.2 with root.

:p
[Xposed Framework Modules] shinpil:
Maybe I found the reason of haptic bug

I'm using galaxy s4.

I found that I cannot adjust the intensity of long press haptic on 2.3.8.

You said I should be able to adjust it, but I could not.

Today, I found that I can adjust the intensity of haptic by adjusting the intensity of notification vibration, not the intensity of haptic vibration.

I think that samsung made haptic vibration which there is not on normal android, because samsung is the only one who use both touch keys and physical key.
[Xposed Framework Modules] My1xT:
Maybe the S4 Play Edition (or its ROM) can help solving a bit here since it uses AOSP...
[Xposed Framework Modules] dk_zero-cool:
I will not remove it, it was requested to indicate that the phone registers the Plug. I will however fix your interval issue. Don't know why Samsung keeps calling the Plug method when you don't touch the cable, but I will look at it.

Already know, and it will be fixed soon.
[Xposed Framework Modules] My1xT:
about the vibration, why not an option???

also when talking about the feedback why not an option for all buttons. truly I dont want a haptic feedback on home button but while screen off the option to have haptic on Power or vol+/- for my media control is not bad...
[Xposed Framework Modules] dk_zero-cool:
Haptic Feedback is once again an Android function and it is Android that decides when this is enbled or disabled, either through settings or while in lockscreen or screen off. And I am not gonna touch that as the buttons should work the same whether they are re-mapped or not, which is what I am also trying to get working on the damn SGS4/Note3 TouchWiz ROM.

And the vibration on Plug is not worth making settings for. No one will die because there is a little vibration when you Plug-in the USB while having the screen not turn on. Considering the amount of people requesting it, most seam on board with it and it is to small for anyone to consider it a hassle. Seriously, it's only two small vibrations on Plug.
[Xposed Framework Modules] My1xT:
I like the vibrations too and honestly I dont why why it annoys them so much, but options are a nice thing...
[Xposed Framework Modules] starkilling:
Galaxy S4 Google Play edition here. Sorry if this has been mentioned before, but haptic feedback doesn't work for remapped soft touch buttons (menu and back).
[Xposed Framework Modules] dk_zero-cool:
I know, the SGS4 and Note3 TouchWiz ROM has an issue that I am currently trying to find a solution for.

B.t.w of topic. I have wondered by this for some time, but not really looked into it. What the h*** is a Play Store Edition? You can buy phones on the Store? Maybe it is because I am from Denmark, but I have never seen that option anywhere.
[Xposed Framework Modules] coolkaas:
dk_zero-cool,

https://play.google.com/store/devices/details/Samsung_Galaxy_S_4?id=samsung_galaxy_s4

:)

reviews by verge, cnet
[Xposed Framework Modules] starkilling:
The GS4 and HTC One have a "Google Play edition". You can get them from the play store and they come with AOSP, or at least very close to it. Not with Sense or Touchwiz. These official Google ROMs are updated almost on par with Nexus devices, but the ROM itself is not open source, unfortunately.

https://www.youtube.com/watch?v=mXPWylUU-qg
[Xposed Framework Modules] dk_zero-cool:
No TouchWiz you say? And this is the kind that you have, with no TouchWiz? In that case it would confirm a kernel issue and not a TouchWiz issue with the Capacitive button identification.

No need for OpenSource. If they are updated regularly, it still means new binaries to be used with Custom ROM's and thereby less half working hack jobs.
[Xposed Framework Modules] starkilling:
No TouchWiz. They're basically exactly the same as AOSP. Anyone with a GS4 i9505 or HTC One M7 can get the google play edition ROM and flash it and it'll work perfectly since it's the same hardware. Even the IR blaster works on the S4. I have a normal, european S4, buying devices from Google Play isn't even available in my country, yet I have that ROM.

Thank god for XDA.
[Xposed Framework Modules] ashut0sh:
Not Working

Hi, the Button Re-map option has no response when I press any button.

I have have a Samsung SCH-i589 (Galxy Ace Duos - CDMA) running on android v2.3.6

I do have root privileges.

I have installed Xposed framework,

Enabled the module.

Rebooted my phone after that.

No Custom Recovery though, couldn't find any.

Using Stock ROM.

Thank you in advance.
[Xposed Framework Modules] testrider:
Hi,

I have a Note 2. I just rooted with CF AUtoroot.

Now, do I just installed 'Xposed Framework' (from XDA. Why it's not on Google Play?), then installed 'Xposed Additions' from Google Play Store?

The file referred to in #1 XposedBridgeApi*.jar was only for developer and I don't need it, correct?

Thank you.
[Xposed Framework Modules] My1xT:
indeed.

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] dk_zero-cool:
Try clearing the Modules Cache/data from Android Settings and reboot.

You download and install XposedInstaller. That is an app from where you can install XposedBridge. And I am not the developer of the XposedBridge Framework, so I can't say why it is not on Play Store, that question is better asked in the XposedBridge thread.

After installing the Framework part (From the XposedInstaller app), then you just install this module, enable it it XposedInstaller and reboot.
[Xposed Framework Modules] testrider:
Thank you so much! i appreciate your help.
[Xposed Framework Modules] testrider:
Thank you. I just installed your free version and I like what I see. Will buy the paid version.
[Xposed Framework Modules] testrider:
Oh, I assume that using key remapping won't increase any battery consumption? I don't use

power key, just remap the MENU and BACK (the softkeys).

Thanks.
[Xposed Framework Modules] dk_zero-cool:
It will not affect battery. This module is quite light weight despite of the features it offers.
[Xposed Framework Modules] Weetbix:
I've found my phone rebooting itself numerous times in the car due to it bumping around and the power button getting bumped. This module sounds brilliant! However, it's had the unforseen side effect of seemingly causing touchwake in my kernel to not work.

I'm on an N7100, with a sammy based 4.1.2 rom and a customer kernel with touchwake enabled. When I enabled this Xposed module touchwake stops working, if I disable this module then touchwake starts working again. I have tried this with 2 different kernels with touchwake baked in.

I've had a search of this thread, and while touchwake isn't mentioned anywhere - the concept is.

What I take from those posts is that touches are not supported, and the kernel hack is needed for the display to work. Yet this module being enabled seems to disable the kernel hack. Am I missing something obvious (in which case, feel free to laugh), or is there someway for this module to not effect the kernel hack I have for touchwake?
[Xposed Framework Modules] testrider:
Thanks. Just bought the pro version. Love it.
[Xposed Framework Modules] dk_zero-cool:
You kernel hack is not disabled, it is just badly implemented. Your kernel hack properly uses key injection to inject a power press simulation on touch, so if you disable the power button, this will be disabled as well.

And it is funny that they have made it that way. Jellybean actually has a build-in touch dispatcher that can be used to wake the system on touch. This dispatcher has nothing to do with key codes and will not be affected by this module at all. So I think that it is strange that your kernel dev has chosen the old key injection hack for a JB rom.
[Xposed Framework Modules] Weetbix:
Thanks for the info :)

I'm going to bring this post to his attention to see if it's possible to get the kernel updated....
[Xposed Framework Modules] dk_zero-cool:
In that case, he should have a look at PhoneWindowManager.interceptMotionBeforeQueueingWhenScreenOff()
[Xposed Framework Modules] testrider:
I set up my Note 2's soft MENU key when double click it does 'HOME'. However, it's not always 100% reliable.

I mean, I may miss 2 or 3 times out of 10. I already set the double click delay to 'long'. (set it to 'short' or 'normal'

seemed to make it worse = more miss). Did I do anything wrong?

Also, what's is this 2nd key when remap a key?

I bought the pro version.

Thanks.
[Xposed Framework Modules] dk_zero-cool:
Double click needs to be fast, like on your PC mouse. Otherwise you would get problem with normal clicks.

2nd key allows you to add secondary keys. So if you Re-map Home and add Menu as a secondary, then you can also add actions for when you press Home + Menu Click, Double Click or Long Press.

Like this

Home Click = Action 1

Home Double = Action 2

Home Long = Action 3

Home + Menu Click = Action 4

Home + Menu Double = Action 5

Home + Menu Long = Action 6

And you can use both these keys the other way around as well.

Menu Click = Action 7

Menu Double = Action 8

Menu Long = Action 9

Menu + Home Click = Action 10

Menu + Home Double = Action 11

Menu + Home Long = Action 12
[Xposed Framework Modules] testrider:
Thank you so much! Excellent. Will give it a try. Appreciate your help!
[Xposed Framework Modules] Tabtoub:
[MENTION=3147360]dk_zero-cool[/MENTION] Just to mention that this mod didn't work with kitkat android 4.4 roms, it doesnt intercept the button when trying to remap..

Can't wait for the new version,

Thank you for your work mate

Cheers
[Xposed Framework Modules] My1xT:
The whole xposed framework does not work with 4.4...

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] dk_zero-cool:
I have already looked some of the code over in KitKat, and there does not seam to be any changes regarding the things used by this module. But XposedBridge does not work on KitKat, so it would be strange if got my module working with it.
[Xposed Framework Modules] AaronCompNetSys:
Please forgive me if I've missed it while searching, but has anyone figured out how to remap down volume while retaining the screenshot hotkey of Vol Down + Power? I saw that OP was working on it but figured someone might have a temp work around. Purchasing Pro is something I'm willing to do as well :)

I would also like to have Vol Down mapped to show volume panel and not actually change the volume.
[Xposed Framework Modules] egingell:
The "kill foreground app" function this mod provides is smoother than any other I've used and with no toast notification, it's that much better. :thumbup:

Sent from my SGS4.
[Xposed Framework Modules] Ranomez:
Just updated xposed additions and bought the pro version (was on the old version that had double tap enabled without pro) and on the old version I could remap capacitive buttons and the haptic feedback was still there, but on the new version once again if I remap a button the haptic feedback gets disabled like it did on an even older version than the last one I was on.
[Xposed Framework Modules] dk_zero-cool:
The Haptic issues is a Samsung issue. I am working on a work-around for these Samsung devices
[Xposed Framework Modules] Ranomez:
My phone is a HTC, lol, and it was working on an older version?