yashsingh1/xdaforums huggingface dataset:
[HTC One S] Phil3759:
Well, implementing MTD into recovery is a big work afaik

read this, and follow some of the links there: http://xdaforums.com/showthread.php?t=2212672

Well, reading there it seems that Dees_Troy will be working on it maybe once :eek: That guy is a genius

However, I doubt cwm will ever add it

Since I do not plan any soon to work on kernels, it will never be ported to cwm by me personally.

So, for now, there is probably only one person in the business really having it in his dream list: Dees_Troy

By the way, I am working on a next release with many bug fixes. So, will update all devices and yours in the next couple of days
[HTC One S] mdmower:
I'm surprised sdcard shows up as a mount point in the Mount menu. Maybe I can figure out a commit to disable its appearance if the datamedia fstype is specified.

Also, I'm not sure why cache won't mount. Are you able to wipe it in recovery?
[HTC One S] Phil3759:
I think it is important to keep it as it is

It is the real mount point in cwm since you can access it using /sdcard

Now, I have added a log to show it is /data/media(/0) while mounting and accessing it

Also, you can still see it is handled as /data/media in logs
[HTC One S] mdmower:
I agree that it is used just fine via a symlink, the problem is that it should not appear in the Mount menu as something you can mount/unmount. You can mount/unmount /data, but not a folder within... unless by (un)mount you mean erase/generate a symlink.
[HTC One S] Phil3759:
Ah, I got what you mean

In fact, sdcard shows always unmounted in Mounts and Storage menu

It is easy to make it no to show there
[HTC One S] Sneakyghost:
Guys, this all seems way too much hassle. Just drop the matter. I am already amazed at what you can do. I am very happy with what i have learned. Thank you both so much!

Regarding the question for a wipe: no i didn't yet try as i always only had a few minutes with the phone. I can maybe some other day if it is still important.
[HTC One S] mdmower:
Per device yes, would be nice to not have to hack it in.

Actually, this matter extends beyond the villeplus to all datamedia devices in CWM. So, don't feel like I'm doing you a personal favor.

I just want to make sure cache partition can be accessed (may require wipe first) before submitting the device tree to koush. Did you ever try to wipe cache in TWRP? If you can test both, I can submit the trees for official builds.
[HTC One S] Phil3759:
Well it would need some more bigger editing in code to make a clean fix and removing it from cwm mountable volumes list. I have no time to open more debugging on that side right now. These I leave to Koush as I already modified it too match

The worst part is that main code is not mine, so when ever cm team decides of some changes, they will never take into account what I do, and I have to rewrite parts of my code to merge things easily

Else, to hide it completely from showing in Mounts and Storage you need to edit only the void show_partition_menu() in extendedcommands.c

Otherwise, I see the log from cwm posted above, with v6.0.3.2 showing the fstab entries correctly

Did you include this commit

https://github.com/CyanogenMod/andr...mmit/abc56ea91d926d80e15146e561f4414d207d22ee

when you compiled it?

That commit broke the fstab entries display in log. I have to remove the stderr Koush added to fix it. That will be on my next commits
[HTC One S] mdmower:
I'm actually building with the cm-10.1-staging branch right now which does not include that commit.
[HTC One S] Phil3759:
I see

I really do not get it why that commit

It still did not fix nandroid commands from console (they still hang)

It added printf to stderr in roots.c when writing partition table to log.

It ends up like this:

“e“e“e“e“e“e“e“e“e“e“e“e“e“e“eW:Unable to get recovery.fstab info for /datadata during fstab generation!
W:Unable to get recovery.fstab info for /emmc during fstab generation!

Instead of displaying the table

Removing stderr fixes it
[HTC One S] Phil3759:
Also, since you're on it, can you gerrit this fix (I do not go with gerrit)

int nandroid_restore_partition_extended(const char* backup_path, const char* mount_point, int umount_when_finished) {
struct stat file_info;
if (0 != (ret = statfs(tmp, &file_info))) {

declaring struct stat file_info and using statfs through all that function...
[HTC One S] mdmower:
I could use a second set of eyes before testing/committing-for-review. Replace lines 871-874 in extendedcommands.c with:

if (strcmp("datamedia", v->fs_type) != 0) {
sprintf(&mount_menu[mountable_volumes].mount, "mount %s", v->mount_point);
sprintf(&mount_menu[mountable_volumes].unmount, "unmount %s", v->mount_point);
mount_menu[mountable_volumes].v = &device_volumes[i];
++mountable_volumes;
}

This should remove the mount option but leave the format option visible.

EDIT: Amended code May 24: submitted for review.

Can you give me a better description of what this fixes and be explicit about the line numbers that should be removed/edited?
[HTC One S] Phil3759:
Your edits for the menu look good. They should be enough as num_volumes is not used further in the code. I cannot compile it right now and i would need to make a special repack as my phone is not natively datamedia. But at first sight, i see no issues

About stat / statfs, this line:

https://github.com/CyanogenMod/android_bootable_recovery/blob/cm-10.1/nandroid.c#L593

i am far from being a C master, but looking at manpage, they have completely different structure. Also, you will get warnings doing so. I recently discovered that i misused it inadvertently when i made a lot of changes to the nandroid code. It caused a memory overflow that only showed on some devices in logs. The overflow was caused by calling stat on a statfs structure. It took me a while to debug it until i noticed that mistake. I went through all code and found some orphan struct left and also this misuse in stock cwm.

I think it is definitely a mistype or inadvertent error.
[HTC One S] mdmower:
[MENTION=4666971]Phil3759[/MENTION]

1. Fix recovery filesystem table output to log - has already been merged

2. Remove (un)mount option for datamedia partitions - will be tested by utkanos and/or gweedo767

3. Fix use of stat and statfs in nandroid.c - not yet put up for review, waiting for feedback from you.
[HTC One S] Phil3759:
Really fast and great

I reviewed your commit 3, and it is ok. I looked all the nandroid.c file and there are no other confusions between stat and statfs

He could stat a device without side effects, but calling stat when statfs was declared is wrong

int main() {
struct stat st;
int n=statfs("/root/Desktop", &st);
printf("n=%d\n", n);
return 0;
}

compile output:

test_code.c: In function ‘main’:
test_code.c:30:5: warning: passing argument 2 of ‘statfs’ from incompatible pointer type [enabled by default]
/usr/include/x86_64-linux-gnu/sys/statfs.h:32:12: note: expected ‘struct statfs *’ but argument is of type ‘struct stat *’

It will be accepted and runs, but you can overflow easily

Have no fear to commit it :)

By the way, what do you think about this?

https://github.com/CyanogenMod/android_bootable_recovery/pulls

I know, they never consider pull requests made outside gerrit, but I couldn't set it up for cyanogenmod. Always certificate fails
[HTC One S] mdmower:
Yikes, 36 commits? They probably ignored it since the commit of interest wasn't re-based before pull request. I assume you were only trying to include really fix fs_type2 -see previous commented commit? Have you tested this typical scenario with your commit in place?

I can see that pre-patch, fstype2 takes precedence. If fstype2=auto, this makes sense. If a partition is currently formatted as ext4, it should be re-formatted as ext4 and not converted to vfat (which your patch would cause I believe). The better fix in my opinion is to fix the device trees to use fstype2=auto instead of specifying a particular filesystem type.

I would suggest closing all of your pull requests to CyanogenMod/android_bootable_recovery. They aren't going anywhere. I submitted your compiler warning for review: Fix compiler warning: redefinition in extendedcommands.c
[HTC One S] Phil3759:
You are true in this aspect. In fact:

My commit was after entropy512 pushing fstype=ext4 on external_sd for many devices

Since most of my users were on exFAT, this was a bit ennoying as format external_sd would always force it to ext4

But, you are right that after my patch, fstype will take precedence and force a format type too for people that prefer ext4

Your idea in device tree seems the best

I will revert my changes for PhilZ Touch and edit my device trees too :good:
[HTC One S] Phil3759:
5.05.0 (26.05.2013)

One S:

http://d-h.st/users/philz_touch/?fld_id=16059#files

One S - Special Edition:

http://d-h.st/users/philz_touch/?fld_id=17207#files

Most changes are in nandroid backup operations and external storage mounting

Please test this and report any bugs with a log

To get a log:
[HTC One S] Sneakyghost:
Villeplus Special Edition SE Philz Recovery test

Hello Philz,

managed to get the device from my wife briefly.

- E:can't open /cache/recovery/last_log

- Mount USB does not work (expected, right?)

- Mount SD doesn't work

- set storage to data/media toggle is not clear to me. What does it do? Change it for recovery or for the main system?

- Install Zip browser accesses SD correctly.

Log: http://pastebin.com/4tjxY5aa

Hope it helps.

Notice: i am changing to the ONE and selling my Ville. The Wife will probably follow soon after. My interest in this matter is now fading away slowly. It's already reduced to the desire to see a "Proof of concept", make sure its possible to get it all right. :D

Thanks a lot mate.
[HTC One S] Phil3759:
I am so dumb, sorry

I repacked with old recovery binary, see the version! 5.0.7 not last one

Sorry, I will repack :p
[HTC One S] Gavin01:
ive flashed it twice and it doesnt seem to be installed?I dont get any error messages and it says "done""reboot recovery"

any ideas??

Thanks
[HTC One S] Sneakyghost:
Philz just to give you some heads-up:

After having serious ROM issues again for the past 4 days due to mad flashing errors with TWRP ( i spent a million hours trying to get the viper META-INF structure to run well with TWRP) i finally gave up and ran the standard META-INF from Viper on your recovery and it was just such a major relief to see the phone boot up butter smooth, no issues at all and everything as its supposed to be.

I really like your work as it is a safe fall-back option in case TWRP fails.

I have to say though that my updater-script modifications and binary experiments do work well for some testers on the ViperOneS thread, its just and only my phone that acts up.

The problem seems to be in some minor differences in execution of extraction and write commands and its just very hard to track down without the required know-how, so i just concluded that the CWM methods are much more robust as they work on good and picky phones alike, while TWRP is only working on good phones. Well, thats my half-educated guess anyway.

Thanks.
[HTC One S] Phil3759:
Could be also related to the kernel used, the ramdisk changes...

I did not forget you by the way. A bit busy. I am pushing, I hope a final bug fix v5.06.0

The weekend I am away, so will be pushing for a few devices only to debug it, but I do not expect major issues as all these recent builds are more bug fixes and small enhancements already

Hopefully, next week, I release a proper thing for you. Sorry for the bad repack I did last time. Silly that I mixed the binaries :p

Repacking during late night is not a good catch for me, but it's the only moments I can really take some time
[HTC One S] Sneakyghost:
Man don't worry too much about it, i am off the HTC One S on monday anyway. I will then be enjoying the ONE for a while.

And regarding the OneS: i just think its such a shame that no one sat down and fixed the broken things because this is such a wonderful phone.

It is one of the really outstanding design examples from 2012 and no other phone was able to keep up. The tech side was quite ok too, if not leading edge.

The binary problems (issues with executing wipes and extracts and setting permissions) are all just minor stuff needing the lead developers to look into their code for a while. But neither Dees_troy nor Koush nor Amarullz wanted or could work out the "real" problem so now there's a bunch of people trying to work around failing extract_dir and set_perm commands and Amarullz trying to (at last!!) fix the colorspace but basically the three of them keep blaming each other for what is going wrong ("no that has to be fixed in Aroma!"; "no, i am rather sure TWRP needs re-doing") Et Cetera..

So, the OneS community is left with a mess.

Thank god, CWM does work most of the times, although its gotten an old fashioned interface and many people, including me, prefer some nice skinnable UI these days (like TWRP has). Amarullz is dreaming of his own self made recovery too lol. That'd be graphically "intense" i suspect haha...
[HTC One S] Phil3759:
Recovery partition is small, so, we must be modest to fit things in it and keep it autonomous. There is no room to fit aroma file manager as it is on most recoveries

Lunching and compiling for the ville is a mess. Even by default, the cm-10.1 tree seems to hate ville. There are redefines breaking building many other devices until you remove ville from device tree folder, or fix the redefines

Seems like cm-10.1 team even forgot this device exists, LoL
[HTC One S] LibertyMonger:
I been having this issue where the phone won't power off from recovery, it kicks back on in recovery after powering off. Other than that everything else is great. My Niece is now having major battery drain since I flashed this and BlackBean 9. Not sure what is causing that, I will see her tomorrow and find out I hope. I am running the same as her as is my mom and we are not having this issue. Her battery literally drains all the way down, I hope it isn't a hardware/battery issue. I can't find anyone who has had this issue.
[HTC One S] the4biddendonut:
I can't help with the battery drain, but I'd try reflashing or try another rom.

My one s does the same thing, reboots back into recovery when it's plugged into the charger. I'm pretty sure that's the only time it does it for me, I'm gonna start paying better attention.

Sent from my HTC One S using Xparent Cyan Tapatalk 2
[HTC One S] Phil3759:
If you power off while in recovery and have an usb cable plugged in, it will poweron into recovery. That's the bootloader, not cwm

Battery drain issues should go in general section. This is a recovery not a ROM :rolleyes:
[HTC One S] Darknites:
No CWM had this bug when turning the phone off even with nothing connected but TWRP don't have this issue.
[HTC One S] Phil3759:
Well, it was reported to be not the case with this, right?
[HTC One S] Darknites:
I not used your recovery so can't say on that.
[HTC One S] LibertyMonger:
No USB cable connected and since there is a power issue I posted all of my issues I have had since setting up my Nieces phone. Sorry I am not politically correct. I knew the response I would get everyone gets so offensive when posting anything negative no matter where i post. It really makes any of these threads useless. I apologize but it gets quite aggravating. I stick my phone in my bag after powering down while using my GNex then pull it out later and it is either powered on or back in recovery.
[HTC One S] Phil3759:
Sorry, did not get what you mean :confused:

Maybe just answer my question to make things clear (and do not forget, I do not own the phone to test, so I only can get what you say/report)
[HTC One S] Phil3759:
v5.06.1

5.05.0 --> 5.06.1

One S

http://d-h.st/users/philz_touch/?fld_id=16059#files

One S Special Edition

http://d-h.st/users/philz_touch/?fld_id=17207#files

Hope this now will work for ville_u (One S Special Edition)
[HTC One S] desmolab:
Just to give a little positive feedback, on 5.06.1 i've flashed almost 3 roms, backuped and restored another one plus flashing various zip and it worked really good. In twrp 2.3.3 i'd got several problem on restore backup.

I like the option in wipe data/factory reset to wipe for a clean rom install!
[HTC One S] _kevn_:
i agree, working nicely so far! just switched over from twrp 2.4.1.0 I've been having various things going on lately, one of them being twrp asking for a password when restoring a nandroid, when there was no password protection. weird.

anyways, I'm liking it at the moment.

Thank you!
[HTC One S] Mr.Nigma...:
I noticed something. i dont know if it is posted before but, usb mount isnt working :( great recovery except this

EDIT:Mounting ok in ubuntu!

GREAT ****IN RECOVERYY ! GOOD JOB PHILZ
[HTC One S] qazsxdcfv:
hey anyone knows how to fix that "cant open /cache/recovery/recovery.log"

i have cleaned that with fastboot ,..

umm, PhilZ can you help me , i was searchin about 3 pages back , and none of information ,.. :(:(

thanks
[HTC One S] Phil3759:
Need a log for such issues
[HTC One S] qazsxdcfv:
Log ? The recovery cant open the log , and discover it ?

Ahh man , why this happens:(:(

Sent from my hTC One S powered Trickdroid by Torxx™
[General Questions and Answers] alyceochoa:
Hey, guys...

I have a Huawei U8860 ICS. When I tried to update it into Jelly Bean from this site

waitandroid.com/update-huawei-u8860-honor-to-android-4-2-1-jelly-bean-miniz-custom-rom

Then my phone shows :

E:signature verification failed

E:update fail and delete temp files

Formatting /cache…

Installation aborted.

Can you help me please?

I tried to find how to solve it on the net, but it still doesn't work...
[General Questions and Answers] surajkala:
M not sure about minz rom.. but incase if u want to install Slimbean from (4.2.2) than 1st u need to revert back to B919 stock ICS

Download slimbean rom and copy into sd card

and than install CWM via replacing recovery.img

and than go to CWM recovery and flash the SLIMBEAN rom
[General Questions and Answers] pshay8:
ive been trying to flash my new phone x18i a chinese smartphone who comes with android adn has mtk7653

but when i did its screen became pink and not letting me boot up the phone

when i tried a diffrent rom he told me this :

View attachment 1918683

please anyone know what i should do? i stuck in this since yesterday

thanks!
[General Questions and Answers] pshay8:
i also noticed that the driver is connected then disconnect after a few seconds and the phone is up and wired but shows purple stripes

View attachment 1919451
[General Questions and Answers] pshay8:
no one lnows?? im desppred
[Galaxy S 4 General] mateenf:
I ran quadrant on my new s4. The result looks very promising.
[Galaxy S 4 General] JayceOoi:
Mine better a bit. :D

Samsung Galaxy S4 GT-I9500 Benchmarks
[Galaxy S 4 General] I Am Marino:
Geekbench updated as well.

http://browser.primatelabs.com/android-benchmarks

3500 score, just wow.
[Galaxy S 4 General] mateenf:
Good too see this...
[Galaxy S 4 General] czar22:
my score

STOCK ROM

SG S4 - i9505
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] bobfrantic:
Using the firmware DDULP8 and when I have the choice between two apps, I get this

View attachment 1918685

Anyone know why it doesn't say One Time and Always? Just weird imho.. and most puzzling LOL :eek:
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
I'm getting correctly. Yours is really weird LOL

View attachment 1918721

अपने Samsung Galaxy S Advance से पोस्ट किया है ये मैने :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] jineshpatel30:
:eek::what:
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] revoxis:
Are you using stock or custom rom? :eek:
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] bobfrantic:
pure stock deodexed. LOL
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] areeb47:
LOL that is funny. :D

Seems like translation gone wrong, which language have you selected.
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] panda00:
LOOOL
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] sandrin0:
Lol that made me laugh. No idea what it could be either haha. Maybe changing language a few times or a full wipe will solve it.

Very funny bug haha :D
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] bobfrantic:
All I can do is go WTF LOL, did a full wipe of cache, dalvik cache, and System restore, still same thing haha oh well, not major issue but...
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
Why don't u try flashing it again?

अपने Samsung Galaxy S Advance से पोस्ट किया है ये मैने :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] bobfrantic:
I was going to but with the new german firmware, will wait for a deodexed version then try that see if it works better :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
Till the deodex comes, use odexed!

I have an excellent battery on indian unrooted. 2d 1h 15m n 8% left :D

अपने Samsung Galaxy S Advance से पोस्ट किया है ये मैने :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] bobfrantic:
the battery performance has for sure been improved. :D
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
Yeah. From 12 hours to 2 days. LOL. Yes, it has :p

अपने Samsung Galaxy S Advance से पोस्ट किया है ये मैने :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] sarabjit singh:
backup

if i will make a backup of sgs through kies and after that will flash indian firmware. so is it possible for me to reverse back all my data on indian firmware
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
Maybe yes,maybe no. I don't know exactly.I don't use kies. I don't have kies. I never used kies. LOL

View attachment 1921886

अपने Samsung Galaxy S Advance से पोस्ट किया है ये मैने :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] virajmalia:
You 'lol' too much!!:D

Btw if he wants contact backup, he can Just export to usb storage or sdcard.

Other backups can b done using usb cable and mtp connection.

From where other than Galaxy S Advance!
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] szzlgupta:
:p hahah

and, yeah. or use some backup app for contacts sms and call logs :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] Chirag_Galani:
Use app backup and restore... It's freely available on the playstore. It backups only the app not the data though.... But its easy and user friendly. And if u moved to a new firmware or custom ROM you just need to reinstall app backup and restore again and then from the archived section you can restore all your apps... :)
[Galaxy S Advance I9070 Q&A, Help & Troubleshooting] yugant003:
is our indian firmware smooth enough ?? has anyone tried CM 10 on it ?? my apn Internet settings dnt get save in it ....has anyone tried
[General Questions and Answers] pramodb:
Hey guys , I recently upgraded to jb 4.2.2 , didn't like it very much so I was wondering if I could get the stock ROM for my gt-p5100xxld7 3G+Wi-Fi , I.e ICS 4.0.3
[General Questions and Answers] immortalneo:
www.sammobile.com/firmwares/2

"To err is human, to forgive is divine"

Sent from my SGS II
[Galaxy S III Themes and Apps] Kimi Raikkonen:
Hi guys tell me the change to do to get the address book with the picture icon to google that?

http://imageshack.us/photo/my-images/854/screenshot2013042813040.png/

I currently there is the way:

http://imageshack.us/photo/my-images/855/screenshot2013042813013.png/

My phone Galaxy s3

Firmware XXEMC3
[Galaxy S III Themes and Apps] Galactus:
Whatever rom your using has added the quick call button, removing the google icon.
[Galaxy S III Themes and Apps] Davidoffxda:
You need to modify /system/csc/feature.xml

Remove the lines: <!-- Contacts -->

<CscFeature_Contact_SetLinkCountMaxAs>999</CscFeature_Contact_SetLinkCountMaxAs>

<CscFeature_Contact_EnableCallButtonInList>true</CscFeature_Contact_EnableCallButtonInList>

Flash it again via recovery, unless you have right to edit the file.
[Galaxy S III Themes and Apps] Kimi Raikkonen:
Davidoff thanks work