yashsingh1/xdaforums huggingface dataset:
[Android Software/Hacking General [Developers Only]] Aguys:
Nexus Media bootanimation doesn't work on AICP 13+Magisk 16.3. It's only work once after installation, but when I reboot phone, bootanimation back to default. I checked cache partition, there's no magisk mount. It just me or???

Was working fine on magisk 16.2.
[Android Software/Hacking General [Developers Only]] osm0sis:
Pretty clearly sounds like you wiped cache by mistake. Reinstall.
[Android Software/Hacking General [Developers Only]] osm0sis:
These are likely the last releases I'll make on xda before I remove all of my uploads from xda/BasketBuild and switch to a subscription model for my services. More information on my own branded subscription service, "Patreosm", in the coming weeks. Enjoy the final freebies!

I work on these projects in my limited time off, so if you like the progress I'm making, or enjoy anything else I've done on xda, please do hit the donate link from my profile. Thanks for your support!

UPDATE-Busybox.Installer.v1.28.2-ALL-signed.zip:

- improve cleanup and fix subsequent installations with Magisk Manager

- update to latest busybox stable official source

See the related commits here: https://github.com/osm0sis/android-busybox-ndk

UPDATE-Fla****.Installer.v3.3-signed.zip:

- update busybox binary (1.28.2) with the latest patches and fixes from my repo

- fix fla**** --uninstall/--restore on Magisk 16.3+

UPDATE-nano.Terminal.Editor.v2.9.5-signed.zip:

- update to latest nano official source

UPDATE-Nexus.Media.Installer-signed.zip:

- fix cleanup script for Magisk 16.3+

Oh yeah, Fla**** is a reupload with the latest busybox, because numbers are meaningless constructs, and time is a flat circle.

Edit: Quite obviously April Fool's, in case anyone didn't gather that! :p
[Android Software/Hacking General [Developers Only]] ale5000:
Hi,

I see the link at the sources but I don't see where it is specified the specific commit (for example 7d7686da33334de9b5eb6cf319269b7d0790bbf6 or another) where the sources are compiled from.

Just to map the current binary to specific sources in case they change in the future.
[Android Software/Hacking General [Developers Only]] OldMid:
Not gonna lie, you got me:p
[Android Software/Hacking General [Developers Only]] marcdw:
LOL. Same. The only April Fool's joke to get me this year.

ZTE Axon 7 A2017U, AospExtended v4.6 ROM, microG (NoGapps), Multiboot, Tapatalk 4.9.5
[Android Software/Hacking General [Developers Only]] osm0sis:
Ahh you're totally right. I had forgotten about the cleanup script using the /magisk location which is now gone in Magisk 16.3+. I've updated the Magisk repo and zip, and added it to yesterday's release post. Sorry about that!

I've also reuploaded Fla**** v3.3 again with fla**** --uninstall/--restore fixes for the same issue and added it as well. :silly:

They're from master HEAD of the Magisk repo at the time of uploading.

Other than a reorganization of the Magisk repo there haven't been any changes to those sources since January 26th.

From the present and working back you can track it if you like:

https://github.com/topjohnwu/Magisk/commits/master/utils

https://github.com/topjohnwu/Magisk/commits/master/crypto

https://github.com/topjohnwu/Magisk...0f15/src/main/java/com/topjohnwu/magisk/utils

https://github.com/topjohnwu/MagiskManager/commits/master/crypto

That all said, I'm sure [MENTION=4470081]topjohnwu[/MENTION] didn't version it to not bother updating it; if the source changes, then I'm sure it won't be ZipSigner v2.1 anymore. ;)
[Android Software/Hacking General [Developers Only]] alphazo:
I installed "BusyBox for Andoid NDK" 1.28.2 via Magisk v16.0 on a Huawei Mate10 PRO and didn't get any error. When I rebooted and tried to use an app that makes use of Busybox or a a simple Busybox checker tool it didn't detect Busybox. Did I miss a step?

Thanks
[Android Software/Hacking General [Developers Only]] osm0sis:
Download the Terminal Emulator app and type `which busybox` and `busybox`
[Android Software/Hacking General [Developers Only]] nextheart:
It happens due to busybox could be installed at wrong place.

Use an app which can install busybox, try different places and check on reboot.
[Android Software/Hacking General [Developers Only]] oreo27:
Does the adb + fastboot Installer zip work with newer versions of Magisk? I noticed the format is on v14.
[Android Software/Hacking General [Developers Only]] alphazo:
'which busybox' doesn't returns anything and 'busybox' returns

/system/bin/sh: busybox: not found
[Android Software/Hacking General [Developers Only]] alphazo:
I solved my problem by installing Magisk Beta 16.3 and then re-installing the Busybox module ;)
[Android Software/Hacking General [Developers Only]] osm0sis:
1400 is the minimum accepted in 16.3, and since my installer supports all versions of Magisk I keep it at the minimum for the broadest compatibility.
[Android Software/Hacking General [Developers Only]] oreo27:
Sounds great! I've installed this on my other device but I couldn't get it to work. My guess is that the Magisk install on that device has been corrupted and I need to reflash it. Perhaps when I have time. Thanks for all your contributions, legend! :)
[Android Software/Hacking General [Developers Only]] RobotPhone:
Damn! I thought I made it through April fools unscathed and I just read your edit. Good one, you got me ?
[Android Software/Hacking General [Developers Only]] erayrafet:
Hi [MENTION=1143630]osmosis[/MENTION]!

I want to confirm that on my Huawei P8 with Android 6.0, without an xbin folder in /system, Busybox 1.28.2 works, but the nslookup applet is missing from /system/bin, even if it's listed under the supported functions. I'm using Magisk 16.3, btw.
[Android Software/Hacking General [Developers Only]] ChenZ86:
Hey osm0sis

I have a BLOD Nexus 5X.

I have installed the 7.1 EXkernel from the xda thread from XCnathan32 und the 7.1 TWRP.

Now I think it's time to go up on Oreo 8.1

That's where I found your zip. Is that zip qorking with 4 cores or only 1?

What's the step-by-step things I have to do now?

-Installing 8.1

-flashing TWRP

-apply your zip

For Exkernel ther is a Update shown. Is it possible to update the Kernel and then your zip?

-updating EXKernel

-apply your zip

Thanks for your answers in advance.

ChenZ
[Android Software/Hacking General [Developers Only]] osm0sis:
What's in /sbin/.core/img/busybox-ndk/system/bin and what's in /system/bin ? nslookup in either place? The install to /system/bin filters out applets that conflict with existing system ones, to avoid issues.

Yes to all of that. It makes it 4cores, as all of my documentation suggests.
[Android Software/Hacking General [Developers Only]] erayrafet:
In /sbin/.core/img/busybox-ndk/system/bin there is only one file named busybox and in /system/bin there are many applets, but nslookup is missing.
[Android Software/Hacking General [Developers Only]] osm0sis:
Try uninstalling, reboot and installing again.
[Android Software/Hacking General [Developers Only]] erayrafet:
It's working now. Very strange. Thank you very much!
[Android Software/Hacking General [Developers Only]] maybeme2:
Excuse me for being dumb but where do I download the FlashAfterUpdate addon.d script and how do I run it.

Thanks
[Android Software/Hacking General [Developers Only]] olivercervera:
I have the same issue on Xiaomi Mi5 - LOS 15.1 - Android 8.1 - Magisk v16.0.

I have already tried to uninstall - reboot - reinstall - reboot.

In /sbin/.core/img/busybox-ndk/system/xbin i have nslookup, but in /system/bin is missing.
[Android Software/Hacking General [Developers Only]] osm0sis:
The /system/addon.d location you just quoted in your post.

Then your device has /system/xbin and you don't need it in bin.
[Android Software/Hacking General [Developers Only]] olivercervera:
Yes but I can't call it. Termux says is not installed...
[Android Software/Hacking General [Developers Only]] osm0sis:
You using the latest version? What're the contents of /system/xbin with it installed?
[Android Software/Hacking General [Developers Only]] olivercervera:
1.27.2 according to the command "busybox". I've installed it from the Magisk Repo.

In /system/xbin there are few files but looks nothing related to busybox.
[Android Software/Hacking General [Developers Only]] osm0sis:
And in /sbin/.core/img/busybox-ndk/system/xbin?
[Android Software/Hacking General [Developers Only]] olivercervera:
Lots of stuff there, including nslookup.

When I call the busybox command I get a list of tools, which seems complete, but lacks nslookup.
[Android Software/Hacking General [Developers Only]] osm0sis:
If it's in /sbin/.core/img/busybox-ndk/system/xbin but not in your live /system/xbin then there's something wrong with your Magisk installation; it's as though it's in Core Only mode. Maybe try upgrading to 16.3.
[Android Software/Hacking General [Developers Only]] remarkablecow913:
I have used it with 16.0 and have it installed on another device running the 16.3 beta, although haven't tried to use it. But install through manager said it was a good install
[Android Software/Hacking General [Developers Only]] VincentJoshuaET:
Hi. Is it possible to have a flashable zip that patches these into the kernel?

https://github.com/flar2/android_ke...mmit/9cf4e3fbb439e46833b2d2e7965b8283b02d93c8

https://github.com/flar2/android_ke...mmit/d24887e71c8c99288239438943e7195f652a9ec0

Basically, a custom kernel that only removes the SafetyNet checks so that LineageOS users can still use the stock kernel with a small modification. Thanks.
[Android Software/Hacking General [Developers Only]] osm0sis:
No, it's a complex patch that needs to be compiled from source. Lineage kernel source is open, clone it, pick those commits and compile. There are lots of guides on xda to help you with that. :good:

You could then use your new compiled zImage/Image.gz to make an AnyKernel2 zip to install your fixes, but that's much different from trying to patch compiled code in an existing kernel.
[Android Software/Hacking General [Developers Only]] bkkzak:
I'm fearful I'll get bashed for asking an obvious question, but I can't seem to get the adb + fastboot to work.

My intended use

: run adb commands from my phone to my Hwatch 2 (WEAR OS).

Why I think it's not working

: I connected my watch to my phone, enabled all adb options, opened terminal, typed

adb devices

and it said adb not running. I then tried

su
adb devices

(ran it as root) and the command worked but no devices at all were listed.

Is it only supposed to be run as root? Is there anything that I'm obviously doing wrong?

Device: Pixel Xl 8.1, crDroid, Magisk 16.3
[Android Software/Hacking General [Developers Only]] osm0sis:
See here: https://github.com/Magisk-Modules-Repo/adb-Installer/issues/2

Could have a lot to do with the cord you try to use with it. It matters which end of the cord is plugged into which of my microUSB to A + A to microUSB adaptor on devices I've tested with. USB-C cords are so varied in quality and features I imagine this would only be further complicated on C devices.
[Android Software/Hacking General [Developers Only]] pkgnex:
Magisk Busybox Update Issue

[MENTION=4544860]osm0sis[/MENTION],

I had the same issue again with the 1.28.3 busybox update on my Pixel 2 XL (latest stock ROM, Magisk 16.3, stock-ish kernel are only mods)... but this time I was able to get some better forensics for you, I think:

1. I updated through Magisk, and the install splash screen all looked fine, but after reboot, fstrim didn't work. "which busysbox" pointed to /system/bin/busybox, "which fstrim" returned nothing. See pictures 1a-1c for ls -alZ /system/bin output.

2. I deleted the module through Magisk and rebooted. Of course, after reboot, fstrim didn't work. "which busysbox" pointed to /system/bin/busybox, "which fstrim" returned nothing. See pictures 2a-2c for ls -alZ /system/bin output.

3. I installed 1.28.3 fresh through Magisk, and the install splash screen all looked fine, but this time after reboot, fstrim did work. "which busysbox" pointed to /system/bin/busybox, "which fstrim" returned "/system/bin/fstrim". See pictures 3a-3c for ls -alZ /system/bin output.

From all the references to "toybox" and fstrim not being there in picture sets 1 and 2, it looks like it was either stock busybox (if there is such a thing) or Magisk's internal one. It appears that on an update, the script isn't working through Magisk install or is being overwitten during the reboot, but your module works after an uninstall and re-install.

This has only happened on the last 2 updates - 1.27.2 to 1.28.1 worked fine as a direct Magisk update, but I had to uninstall / reinstall to update from 1.28.1 to 1.28.2 and from 1.28.2 to 1.28.3. Of course, it could be Magisk related because I've been updating that as time has gone by as well.

Hope this helps. If you need anything else, PM me and I might be able to do some stuff this evening.
[Android Software/Hacking General [Developers Only]] osm0sis:
It's probably the bit of script I had to migrate people from /su/bin installs to /su/xbin installs triggering by mistake (since /su/xbin wasn't originally in SuperSU's first few releases with su.img). I can probably remove it now since that SuperSU version's well outdated. Thanks for the detailed report! I'll look into it more. :good:
[Android Software/Hacking General [Developers Only]] pkgnex:
No problem - glad to help where I can!

If there's anything you want me to test, just let me know - the Pixel 2 can be a little finicky.

In the mean time, I've double-confirmed the work-around now so it's not a big deal.
[Android Software/Hacking General [Developers Only]] osm0sis:
So the weird thing is it's not super complicated, and is being triggered from this:

if [ -d "$mnt$magisk/xbin" -o "$magisk" -a -d "$root/system/xbin" ]; then
target=$mnt$magisk/xbin;
else
target=$mnt$magisk/bin;
fi;

So maybe you've got another Magisk module making /system/xbin?

Edit: Re-reading your report, this is pretty concerning:

It suggests that even uninstalled there is a busybox file in your legit /system/bin, which there shouldn't be. My installer isn't even capable of putting one there. Maybe reflash your system partition and see if you can reproduce the issue?

When you flash from Magisk Manager, tap Save log for a broken install and for a working install and upload both please. Lastly, instead of screenshots please upload the text output of `su; ls -alZR /system/bin /system/xbin /sbin/.core/img/busybox-ndk/system > /sdcard/output.log;`
[Android Software/Hacking General [Developers Only]] pkgnex:
I don't have any other Magisk modules at all, so that theory is out....

I believe Magisk has a built-in low-content busy-box, or at least it used to. Maybe that's what's showing up there? All I ever do is flash the factory image every month, followed by TWRP, followed by a custom kernel, followed by Magisk. That's it.

If I have time to wipe and re-start I will, but honestly with what I have going on right now it may have to wait until May 7 (next factory image release). At that time, I'll delete the busybox module and reboot before starting the fastboot flash dance (grabbing the ls -alZR output just in case). Then I will fastboot flash the factory image and boot to twrp, and flash twrp, kernel, and magisk. I'll grab the ls -alzR at first system boot-up, then I'll install your module, grab the log, reboot and grab ls -alZR again. If it installed right, I'll try to install it again to see if I can get a failure, grabbing the log and ls -alZR along the way.

If I'm missing any steps you think would help, let me know. Thanks for looking into this further!
[Android Software/Hacking General [Developers Only]] osm0sis:
Magisk hasn't had its busybox exposed in the path since Magisk v12 or something, and even when it did it wasn't via /system/bin, so that's all just weird. Maybe delete /data/adb/magisk.img and start fresh if you've been using Magisk since the early days.
[Android Software/Hacking General [Developers Only]] pkgnex:
[MENTION=4544860]osm0sis[/MENTION],

I just upgraded with your new busybox 1.28.3 magisk module today. Everything seemed to work and my busybox is working as before (so this is the first time in the last 3 that I haven't had to uninstall the current module before installing the new one).

I saved the installation log (attached) per your request, even though the install worked this time. There appear to be numerous mounting errors, but I'm not sure if that's abnormal.
[Android Software/Hacking General [Developers Only]] osm0sis:
It's normal - Pixels use the fallback method to mount. Thanks [MENTION=6842057]nathanchance[/MENTION] for supplying installation logs, and testing the fix on his Pixel! :highfive::good::)
[Android Software/Hacking General [Developers Only]] starcms:
[MENTION=1143630]osmosis[/MENTION]

This is very odd, but the very latest version of the BusyBox Magisk mofule (1.28.3) breaks VoWiFi. The calls can't connect. Also, if you go into the hidden Phone Info menu (the one that has the switches for VoLTE provisioning, etc) and hit Run Ping Test, it fails the Ping Hostname (www.google.com) IPv4 test. The previous version works fine. And it is definitely the latest version of Busybox from Magisk causing this. I spent all day going crazy trying to figure out why my VoWiFi wasn't working.

Edit:. Literally spent all day. I need a cigarette and a beer...and lunch and dinner lol.
[Android Software/Hacking General [Developers Only]] jcmm11:
Interesting. I'll have to play with this tomorrow. I've been wondering why my Voice over WiFi isn't working. There were a few possibilities I was going to play with - this wasn't even on my radar. I'll try to confirm this tomorrow.
[Android Software/Hacking General [Developers Only]] osm0sis:
What was the last version that worked for you? What device? Installation log? Contents of the target directory before and after installation? Does VoWiFi work with the module disabled/uninstalled?

The only thing that changed in the latest module update a couple days ago was the fix for dirty flashing devices without xbin via Magisk Manager.
[Android Software/Hacking General [Developers Only]] starcms:
1.28.2 works fine. So did every previous version. With 1.28.3, VoWiFi doesn't work with the module enabled. It does work with it installed but disabled.

I have a Essential PH-1, but I also confirmed this on my old Nexus 6.

That's all I can provide right now. Been messing with this thing all day trying to figure out why it wasn't working but it did on my week old nandroid backup.

Even if you don't have VoWiFi, like I had said, on the "secret" Phone Info screen, with 1.28.3, the IPv4 ping test fails as well (but using ping in a command prompt app works fine).

I have no idea why this is happening. Too tired to troubleshoot it any further.

Edit:. Don't know if it matters, but my PH-1 doesn't have an xbin directory.
[Android Software/Hacking General [Developers Only]] osm0sis:
IPv4 ping test works fine for me on my OP5T with 1.28.3 via *#*#4636#*#* so there's nothing I can do until you provide me the answers to the questions in my previous post so I have a proper bug report to work from. I can figure it out, I just can't do it blind. ;):)
[Android Software/Hacking General [Developers Only]] starcms:
I'll try to provide more info tonorrow. But I did just notice my PH-1 doesn't have an xbin directory. I only mention that because of what you said changed in 1.28.3.
[Android Software/Hacking General [Developers Only]] osm0sis:
Yup that's the only thing that changed. Nexus 6 should have an xbin though, so that part's extra weird. Are you sure 1.28.2 works there?

https://github.com/Magisk-Modules-Repo/Busybox-Installer/commits/master

For your PH-1, I'll definitely need the output (from a su prompt) of `ls -alZ /system/bin` with the module uninstalled (after a reboot), and with it installed (after a reboot).
[Android Software/Hacking General [Developers Only]] starcms:
My mistake. 1.28.3 and VoWiFi does work on my N6...was rushing when I tested it through first time. So does 1.28.2.
[Android Software/Hacking General [Developers Only]] ale5000:
[MENTION=4544860]osm0sis[/MENTION]

listing_function | while IFS='|' read MY_VAR_1 MY_VAR_2; do
some_code
done

Hi,

does someone know if IFS is widely supported on all android versions and recoveries including stock ones?
[Android Software/Hacking General [Developers Only]] jcmm11:
Not really tested by me but it should be. IFS should be supported by all Bourne shell derivatives (which is pretty much all modern shells). Default shell in Android is mksh (MirBSD Korn shell)

Busybox default shell is ash (Almquist shell), basically a Bourne shell. This is what custom recoveries use. (hush is also available in busybox (depending on compile options) but would have to be explicitly requested. sh gives you ash)
[Android Software/Hacking General [Developers Only]] osm0sis:
[MENTION=2557531]starcms[/MENTION], I've got a bit of time this evening if you can get those outputs and an installation log to me in the next while. :good:
[Android Software/Hacking General [Developers Only]] starcms:
With 1.28.3, I can't even run ls -alZ /system/bin, it says the Z flag is unsupported, so I ran it with only the other parameters. So not sure how helpful this will be. The output from 1.28.2, 1.28.3, and no module installed are all in this txt file. Pardon the formatting, did this all on my phone. Where would I find the install logs?

Edit:. I just did a clean install of 1.28.3 (didn't install/upgrade on top of 1.28.2) and everything works (including ls -Z) So the problem is definitely in the update process.
[Android Software/Hacking General [Developers Only]] osm0sis:
You tap Save Log after you install from Magisk.

That said, it's pretty clear it replaced the system utilities, which it shouldn't. I'd still like to see an install log from 1.28.3, but I'll look into it. Thanks.

[MENTION=2557531]starcms[/MENTION] Hmm, and if you dirty flash 1.28.3 on top of itself? Make sure it's the latest 1.28.3 from the Magisk repo. I have a growing hunch you were using the original 1.28.3 upload from April 10, not my fixed version from April 22.
[Android Software/Hacking General [Developers Only]] starcms:
Ok, here are the install logs, but they don't make any sense to me. 1.28.2 clean and 1.28.3 dirty look the same. 1.28.3 clean has errors. (No, I didn't mix them up:) But as I said, the problem is with 1.28.3 dirty and 1.28.3 clean works fine. The problems occurs when installing 1.28.3 on top of 1.28.2 BEFORE even rebooting (including the lack of ls -Z). How strange is that?! Hopefully you can make sense of this.
[Android Software/Hacking General [Developers Only]] starcms:
No, I don't have the original 1.28.3 saved, only 1.28.2. Everytime I install 1.28.3 it's being downloaded from Magisk.
[Android Software/Hacking General [Developers Only]] osm0sis:
And 1.28.3 dirty over top of 1.28.3 clean? From the logs they all install to busybox-ndk/system/bin which should be fine, and as long as it's the latest 1.28.3 zip it should recreate the symlinks correctly.

Edit: Next up, what version of Magisk are you using? The log showing /sbin/.core/img/busybox-ndk/system/bin not existing shouldn't be possible in any recent version.
[Android Software/Hacking General [Developers Only]] crawlingcity:
impatiently waiting for the bootunlocker zip, i really need it !