yashsingh1/xdaforums huggingface dataset:
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] alvin551:
Thanks mate will look later after work..I was looking for something like that but missed it. Tired last couple of nights. Thanks
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] xxScoobxx:
SecSettings

I'm confused with this :confused:

"Now you're going to need to get some ids!!! Compile and then decompile.

Open /smali/com/loser/colorpicker/ColorPickerDialog.smali

There should be a total of 6 id's you need to get. Make sure you're looking at the type as there's a layout and string with the same name.

Look for them in /res/values/public.xml. You should now be good to go."

What exactly am I suppose to do here? Do I get he id's from colorPickerDialog or public.xml? And what do I do with the id's?

sorry if this is a noobish question

thanks in advance

Edit: Sorry I think you answered my question with the post before mine.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
At that point you have to compile and then decompile so the ids can be generated.

Then as he stated "look for them in /res/values/public.xml" :)

He actually explained that part really well step by step in post # 53 just two posts above yours.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] xxScoobxx:
Yeah I realized that and edited my post.

thanks
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] alvin551:
sorry guys me again. Ive spent hours looking at this and started it from scratch 3 times lol ive got the color picker working on the status bar so all is fine with that, but everytime i change clock position, am/pm or color the settings FC please can someone take a look. I bet its something really really small and im missing it thanks a lot

SecSettings.apk : https://www.box.com/s/s9kt9ixbhbv8367b8zrt
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Awesome MOD...

The only 3 questions I have are..

The color picker for clock FCs when you apply the color...logcat showed it was coming from date_time_settings under onpreference change method..in looking at it all the coding matches up..any thoughts

I thought I read in the post to delete the old transparency arrays from Didact...is this correct?

If phone goes to sleep for awhile it looses the status bar and wallpaper. It will come back on by itself after a minute or two....

Thanks again for an awesome mod....
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
In the onpreferencechange method change the first line to .registers 4 and make sure v3 didn't change to p0.

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] upndwn4par:
So I started working on this again. Instead of doing it all at once I am doing the left clock first, then the color changer. I have made the changes to get the left clock working, but I have a couple of questions.

1) Is the center clock not properly centered, or is it just me? If you look at the attached screen shot you will see Clock Mod 2.0 vs. Clock Mod 3.0. For 3.0, the clock is not centered until I choose the no battery icon option.

2) Does this mod group more than two notifications in to the icon you see in the screen shot with the "+" on it? The png is named "stat_sys_more", so I assume it can be used to group multiple notification. Was that your solution to the center clock notification issue?

I am doing this mod on 4.1.2, but there was hardly any difference from 4.1.1.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Changing the register worked and I can now change the clock color...Thanks

The other issues are the transparency doesn't seem to work..should I delete to older arrays from didacts mod???

If my phone goes into sleep, when I turn it on I have no statusbar or wall paper...after a minute of being back on the status bar re-appears along with the wallpaper..any thoughs

I attached a logcat..
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
I am also on 4.1.2 and It is not just you for number 1. Depending on the notifications or the items you have in the status bar the clock will move. For instance if I turn on bluetooth my center clock moves slightly to the left, actually with WiFi off, Bluetooth on, and no notifications my clock is perfectly center :D

loserskater is aware of the issues and I believe is working on a way for us to have our cake and eat it too :good:. As is we can either have the clock move slightly or change our code back to have the overlap. Yeah the + icon seems to come up just as you stated and for that reason.

I think in the meantime I will add an Aroma option for my users to either have them deal with the overlap or have the clock move since I thing the positives of the mod outweigh the negatives :)
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Are you using the alpha slider on the color picker? The background behind the status bar is usually black so it won't seem like transparency worked. Use a bright wallpaper and see if there's any y difference on the home screen.

I'll look at your logcat in a few.

Short answer:

I've fixed the problem and will post a how to soon (probably today).

Long answer:

Having the center clock centered with layouts on both sides that add icons is a pain. Especially when working with linear layouts. I have fixed the problem but it's almost another mod in itself as you have to convert the parent linear layout into a relative layout. It's very minor code changes but there's a lot of them.

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] upndwn4par:
FYI - regarding transparency settings.

http://xdaforums.com/showpost.php?p=40547240&postcount=12
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
The arrays aren't harming anything. You can remove them if you want.

I looked at your logcat and I'm unsure of what the issue is, can you send me your SystemUI?
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
here you go...http://www.mediafire.com/?p0uvicnlubx2pny

I'm going back through everything to make sure I didn't miss anything...

Thanks
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
So after some testing it seems I only have issues when I have the clock in the center position. When its located in the center my statusbar and wallpaper will shut down. Statusbar goes away and wallpaper goes black. After a minute or two it restores itself, but it will keep doing this as you turn the phone off and on...thoughts??
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
That does sound like the behavior experienced when you have the center_clock ID wrong. Check that part of the Clock Mod 2.0 tutorial, and make sure it matches what you have in your SystemUI's public.xml.

If you can upload the SystemUI.apk I can take a look at it when I get off work or maybe someone else can before. Please upload the full apk not decompiled.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Makes sense...the one thing I have not checked. I will check it out later..I uploaded my system.ui a few posts back...
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
I get an error when I compile..

[207,7] no viable alternative at input ':'

any suggestions..

got it to compile....stupid on my part!!!
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
That looks like a syntax error at line 207 column 7. Need to see more of your log to be sure though.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] upndwn4par:
Many thanks.

Feel free to ask a mod to replace post #3 with this if you want.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Thanks but I'm going to add it to the 2nd post. Just didn't have time to redo it

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
Thank you for looking into this and figuring out a solution for us. I am getting SystemUI FC on boot, but once the UI comes back I can see that the fix works. Center Clock stays put. I used the invisible version
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
If it happens again send me a logcat. I may have missed something

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Same here..I can see that its fixed but my ui crashes...
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
Just double checked and I definitely did everything right everything was pretty straightforward for this fix. Hoping you see something in my logcat :)

Here ya go:

https://dl.dropboxusercontent.com/u/16494575/logcat.txt
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
I forgot, you need to change mIcons in PhoneStatusBar$MyTicker.smali as well. Thanks for the logcat and I'll update my post when I get home

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
Made the changes to PhoneStatusBar$MyTicker.smali and so far so good. No FC's. Great work man. :good:
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Made the changes as well and all is working in regards to the centering. Awsome job on mod...Thanks

I am still having the same issue with the center clock. If I set the clock to the center position I will loose the wall paper and status bar when the phone goes to sleep. When it wakes up everything will come back, but the status bar resets itself back to a solid black bar. Loosing any color or transparency I had added. I checked everything from the 2.0 mod and this one and cant see anyissues.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
Did you double check on that center_clock id? Check out my last post from the clock mod 2.0 thread. It shows where that center_clock id should be and instructions on where to get the correct ID.

http://xdaforums.com/showpost.php?p=40436752&postcount=70

If you have done that you may need to post a log.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Not sure if I ever looked at that one. But I had the 2.0 mod working with no issues when I originally installed it.

I will have to check it out after work

I attached my ui....

http://www.mediafire.com/?7dz2qthp0cbt578
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
O ok 2.0 was working well can you post your PhoneStatusBar.smali I just got to work.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Thanks for taking the time to look at the smali...

I did have to replace the id's but that still didn't help. The only other thing that is different from my original didact 2.0 mod was the removal of .field mCenterClockLayout:Landroid/widget/LinearLayout; and everything else that goes with it as well as the new method for showclock...I can't see anything else that I could have overlooked.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] evolutioncsr:
Can you pull a logcat using this command please on boot or when the error occurs.

adb logcat -v long > logcat.txt
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
Here you go..

I even rebuilt it from the beginning and its still does it...

http://www.mediafire.com/view/?upty88xtl2v6xlj
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Didact74:
Here is a fix for the color changes not holding in settings when you leave and return. the colors stay but the settings show it going back to default.

Download new color picker and layout files and place them in accordance with loser's guide. My color picker files are named didact (obviously :) ) so if you want to change the name to loser or knight rider, or whatever go ahead.

add a few new strings and Ids....see below

strings

<string name="arrow_right">→</string>
<string name="arrow_down">↓</string>
<string name="hex">Hex:</string>
<string name="hex_hint">\#FF000000</string>
<string name="set">Set</string>
<string name="ics_color">Holo</string>

Ids

<item type="id" name="hex">false</item>
<item type="id" name="enter">false</item>
<item type="id" name="ics_color">false</item>

replace the color line in date_settings with the following:

<com.didact.colorpicker.ColorPickerPreference android:title="@string/clock_color_title" android:key="clock_color" android:summary="@string/clock_color_summary" android:defaultValue="@*android:color/holo_blue_light" alphaSlider="true" />

again, change the didact reference to whatever folder your files are in...

replace the color line in display settings with the following

<com.didact.colorpicker.ColorPickerPreference android:title="@string/statusbar_color_title" android:key="statusbar_color" android:summary="@string/statusbar_color_summary" android:defaultValue="@*android:color/holo_blue_light" alphaSlider="true" />

Remember to change all reference to didact in all these files to whatever you need. probably "loser" if you used his guide.

once you add the new strings and IDs you will need to compile and decompile to generate the IDs. Then follow losers guide on where the new IDs are placed.

Here are the ids in order in which they are found in ColorPickerDialog.smali

<public type="layout" name="dialog_color_picker" id="0x7f040128" />
<public type="string" name="dialog_color_picker" id="0x7f090e58" />
<public type="id" name="color_picker_view" id="0x7f0b03f5" />
<public type="id" name="old_color_panel" id="0x7f0b03f6" />
<public type="id" name="new_color_panel" id="0x7f0b03f7" />
<public type="id" name="hex" id="0x7f0b03f8" />
<public type="id" name="enter" id="0x7f0b03f9" />
<public type="id" name="ics_color" id="0x7f0b03fa" />
<public type="id" name="new_color_panel" id="0x7f0b03f7" />

compile and enjoy! All selections will now stick and will NOT revert back to default.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
So for ha ha's i changed the construct in clock_left to reflect clock_center and vice-a-versa....

iget v0, p0, Lcom/android/systemui/statusbar/policy/ClockCenter;->mClockStyle:I

const/4 v1, 0x3 and change it to 0x2 in clock_left

So if I select clock_center the time will show to the left....when selected the status bar shuts and wall paper goes away like before.

If I select clock_left the time will show in the center and all is good.....

What is it about "clock center" that is causing this...is their anything in secsettings that could cause this..
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
I got this working with the colorpickerpreference already included. Need to change a few things though. I'll upload everything when I wake up.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] BigDogPooh:
So I replaced the showclock method in the phone status bar with didact's original method and it works. I no longer have crashes when my clock is centered. Everything works left,center,and right. I added the centering fix, but need to figure out the second part of it so my notifications don't cross the whole screen.(they do cross the whole screen. I tested it)

So does anyone have any thoughts as to why the showclock method from the 3.0 clock mode doesn't work for me, but seems to work for everyone else...

At least for now I'm getting somewhere and my clock works in all 3 positions...so much for the S3 off to get the S4 tomorrow...Yay!!!
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Biftor:
Hi loser thanks for this great mod iam working on it for s2.

Please check your pm you have pm from me...

Thanks

Goodluck

Armin.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] upndwn4par:
I tried the fix this morning using both gone and invisible and got systemui FCs for both. Tried to squeeze this in before work so I didn't run a logcat or anything. Will look at it again when I get home. Just wanted to give you a heads up....

Edit:

I got it working. I didn't notice that you removed the linear layout around the center clock.

I still get the grouped notifications (which I like). Not sure if that is a 4.1.2 thing.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Kamy:
delete
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Mr0lala:
Hello!!!

I like this mod, thanks loserskater for great guide

I try to do for my phone: S2HD. I follow didact's guide first, everythings is ok except when I have notification, my systemUI has been FC. So i can't move to your guide. Here my logcat any one can check it?
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Sounds like an issue with PhoneStatusBar$MyTicker.smali

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Mr0lala:
Sure, somethings wrong with PhoneStatusBar$MyTicker.smali :(. Here my original PhoneStatusBar$MyTicker.smali can you check it?
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Mr0lala:
I know ....., I will try to fix it =.=!, I use 23 toggles mod from wanam so it will show E/Wanam: PackageManager(15808): Skip signature check.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
6-01-13

Updated ColorPicker so it keeps your color instead of reverting it when you leave and come back to the menu.

Moved all clock stuff to Display Settings to make it easier to change clock and statusbar color together.

You can revert your date_time_prefs.xml and DateTimeSettings.smali

Fixed issues with center/left clock causing the device/SystemUI to freeze when screen is turned off.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] MattBooth:
Just a niggle. But when I reboot the status bar is black again and I have to touch it for it to change colour. Is that something I've done or is it like that for all?

I don't think this works well with [MENTION=2910757]Didact74[/MENTION] 's battery bar too :(
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
I'll have to mess with the battery bar mod and see how it behaves

Sent from my SAMSUNG-SGH-I747
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] upndwn4par:
The battery bar mod works perfect for me.

My status bar does revert to black after reboot, but then changes to the selected color in a few seconds.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] MattBooth:
Indeed. On mine it's black until it's touched :/

I'll have another go at redoing the mod this evening.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Oops! Fixed the center_clock in the OP. Was having issues with id's and forgot to revert it.

Verify Errors are the WORST! It doesn't necessarily have anything to do with the layout. It could be that one of your variables was cast as a string and now you're trying to use it as an int. It could also be something like move-result instead of move-result-object. They are the most difficult errors to fix. I'd double check all of your variables (v10, v11, etc.) and make sure you're using the correct ones.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] MattBooth:
Ok, cheers :) I'll have another go at redoing it all tomorrow....

Currently, I'm not using the left or center clock by yourself, you see. I use the statusbar colour and transparency from your stuff but kept didact's older clock because the new left clock was giving me errors and FC's.

I'll go through again tomorrow and me extra careful :D
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
I updated the showClock method which I believe to cause the clock issues. So left and center clock should work perfect now.
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] Josehg:
Hi,

I´m trying to figure out how to do it, but the ColorPickerDialog.smali, I´ve just downloaded doesn´t show any hash tags whith the ID´s to look for. :confused:.:confused:

This is a fragment of the ColorPickerDialog code:

.line 67
.local v1, layout:Landroid/view/View;
invoke-virtual {p0, v1}, Lcom/loser/colorpicker/ColorPickerDialog;->setContentView(Landroid/view/View;)V

.line 69
const v2, 0x7f090e96

invoke-virtual {p0, v2}, Lcom/loser/colorpicker/ColorPickerDialog;->setTitle(I)V

.line 71
const v2, 0x7f0b03f7

invoke-virtual {v1, v2}, Landroid/view/View;->findViewById(I)Landroid/view/View;

move-result-object v2

check-cast v2, Lcom/loser/colorpicker/ColorPickerView;

iput-object v2, p0, Lcom/loser/colorpicker/ColorPickerDialog;->mColorPicker:Lcom/loser/colorpicker/ColorPickerView;

.line 72
const v2, 0x7f0b03f8

invoke-virtual {v1, v2}, Landroid/view/View;->findViewById(I)Landroid/view/View;

move-result-object v2

check-cast v2, Lcom/loser/colorpicker/ColorPickerPanelView;

iput-object v2, p0, Lcom/loser/colorpicker/ColorPickerDialog;->mOldColor:Lcom/loser/colorpicker/ColorPickerPanelView;

.line 73
const v2, 0x7f0b03f9

invoke-virtual {v1, v2}, Landroid/view/View;->findViewById(I)Landroid/view/View;

As they are just 6 ID´s, will you please make a quick list of the missings lines with their values?. :crying:

Thanks in advance
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] MattBooth:
Tried again. Very meticulously did the edits... still FC's and gives the same error :/
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Sorry, uploaded a new zip with the commented ColorPickerDialog.smali.

Download the new zip.

Post your PhoneStatusBar.smali
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] MattBooth:
There you go :)

Can you see if there's anything that means I have to touch the status bar first before it will set the transparency? (on first boot, once).
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] hednik:
When opened before passing the # comments are there but when I compiled the went away. So I just compared the one not compiled with the one compiled and just went in order and it works with the color picker perfectly.

IIRC the hastags mean to delete something when its compiled
[AT&T, Rogers, Bell, Telus Samsung Galaxy S III] loserskater:
Hashtags are used to comment. So anything after them doesn't get compiled.

Sent from my SAMSUNG-SGH-I747