yashsingh1/xdaforums huggingface dataset:
[Android Software Development] Phil3759:
recoveryzip option is to provide a flashable non persistent recovery UI

Basically, it is loaded in memory instead of flashed to partition

There is no way to provide zip installers

I use complex home made scripts to deal with that. They handle many device exceptions (recovery partition path, neon, loki, mtd...)

Also, all is in same builder: compile, repack when ever needed, export the img and zip installer if needed, export tar.md5 for odin if needed...

So, it is not easy to share them as they are really very custom and written for my automation tasks

If you provide an img with correct file name for goo.im is more than enough. Imagine if I have to upload files for all...

If many contributers, I will create a dropbox or a google drive to share things and make ulpload to goo easier
[Android Software Development] Phil3759:
6.19.3

Uploading second batch:
[Android Software Development] Phil3759:
6.19.2 ---> 6.19.3

A few devices got a file name and zip installer showing 6.19.3 while after flashing you find it is a 6.19.2

Sorry as the export and zip installer were done later after I compiled them under 6.19.2 and meanwhile I updated sources to 6.19.3

Just ignore it. 6.19.3 is to fix compiling for a couple of devices: celoxhd, hlte, hammerhead and galaxysmtd

So, irrelevant to most of you
[Android Software Development] jrkruse:
Flashing loki problem

I get this error when recovery is apply loki patch after I installed philz_touch_6.19.3-jflte.zip.It was working fine on previuos versions. I flashed back to older version and now it does the same thing. I can however flash a loki patch zip and that will patch fine but the recovery will not auto patch a kernel. I have odin back to stock and tried again same result. I am using this on Verizon S4 with mdk bootloader

[+] loki_patch v2.1

E: [-] Failed to map aboot.

E: Error loki-ifying the boot image
[Android Software Development] cooldudezach:
Awesome, I was going to mention this because I ran into building issues using a prebuilt kernel for my builds. (all qcom devices lol) I ended up just commenting out the offending lines.

---------- Post added at 04:27 PM ---------- Previous post was at 04:23 PM ----------

Woah, calm down there cowboy. I did say this is all new to me, so I'm learning as I go, and that's also why I asked if I did anything wrong. I'm used to writing in Java and PHP, so C is a whole new ballpark for me.

Thanks. I have an idea to simplify it, so I'll get to work on doing that. In the meantime, should I go ahead and redo the philz builds I just posted since they all have this added?
[Android Software Development] HippoMan:
I didn't mean to come across "cowboy-like". In answer to your question about strdup, I gave you a summary of that routine and a high-level explanation of how it should work. After that, I added a friendly warning not to use it and other memory allocation routines unless you're more familiar with how they function.

I apologize for not writing my warning in as friendly a manner as I intended it.

.​
[Android Software Development] sonasam300:
Thanks [MENTION=4666971]Phil3759[/MENTION] for this great recovery! I would like to know if i can post this thread/link in cricketusers.com? Giving you all the much deserved credit no doubt. How would one go about doing this. Thanks again.

information...is my drug...
[Android Software Development] cooldudezach:
Yeah, I apologize myself, wasn't a very good day today. I did appreciate the help.
[Android Software Development] Phil3759:
sure :good:
[Android Software Development] neophyte1983:
Phil3759 witch version you recommend for flashing roms?

Gesendet von meinem GT-I9505 mit Tapatalk
[Android Software Development] Bhargav97:
Always use the latest available. :)
[Android Software Development] HippoMan:
Thanks, and I'm glad to help ... and no problem. We all have bad days. :)

.​
[Android Software Development] Phil3759:
I will upload last batch for missing devices this night. They are already compiled
[Android Software Development] Phil3759:
Done updating all devices to 6.19.2 / 6.19.3

104 devices updated

All updates were compiled using exact source from my github, with last libtouch_gui 1.01

All device/vendor tree is there too under a same folder

I will update post 2 with links to changes to kernel, minivold... to use some advanced features

So, probably no more such massive updates, at least do not expect it frequently

I will only maintain selected devices, provide full support to developers to port and solve their bugs while porting and mainly, enhance and maintain recovery source updates + keep in sync to cm upstream

To sum it: project is not dead (stop throwing such bull**** everywhere), it is consolidated to live longer, as long as there is interested developers for your device to compile it. You can also compile your self, no need to know anything in programming for that
[Android Software Development] BadUsername:
I was personally very surprised you kept it going like you were for so long. Must be a ton of work for practically no payoff. I personally appreciate all the work you're constantly doing.

Thanks for everything, and just to clarify, since we're now on the d2lte version, do we need to get someone to compile the entire thing for all the d2 variants then post it somewhere? Either way it's much better than worrying about each variant individually.
[Android Software Development] Phil3759:
d2lte will probably be updated regularly. It has exiting new updates (the unified device tree), a solid cm team behind it and a huge community providing excellent support for debugging

Those are vital criteria for a developer to improve his product ;)
[Android Software Development] hypnz:
Thanks for your recovery my friend but a hample request if I can call it. Please before slow things down can you fix the Loki think? Thanks.
[Android Software Development] Phil3759:
Yes, it is on my todo list

I have no idea yet why loki fails when started from within recovery autoloki thing

I have some logs though to dig into it
[Android Software Development] hachamacha:
For some reason I have this in my head (not really being so familiar with cm11): Were you planning to integrate all the applicable {xt}{xxxx} builds (like xt926/5) into a 'unified' sort of build labeled either moto_msm8960 or like it appears in the lunch menu of stock cm11?

If I build new ones from here on in for xt926 (which I just use the cm_moto_msm8960 label to build), do you want them submitted as the 'group' named msm8960?

If this is an insane question, let it go ;)

And I'm using the last one I build , same as your released one just now and it is terrific. Many thanks.

edit1: Just installed aroma and tested a bit:

aroma notes: There's really no bit of it I see that doesn't work at all but I noted that when you press on say /storage/sdcard1 (which I have on my msm*) then it looks as if it might do a mount-on-demand? I think there is a switch to mount all detected devices in aroma so will try that next time. Anyway, what it does is get caught in a breakable loop (endless progress bar) while it is supposedly filling the directory, but it's actually already filled it, and is working fine. It does the same when I look at /sdcard/ (internal ./0). It all works, but appears not to until you give the screen another touch or two.

custom_res image notes: Actually I just wanted to compliment you. I think recovery is about as sophisticated as the ROM now. I've got some Nexus Galaxy image I chopped to 720x1280 on there, thing looks great.

You interface for the gui_lib is very cool and all of it seems to work fine (that I sampled. )

edit2: Forgot to mention this: Not that this is any different than CWM stock, but of course I tested a backup and recovery on min compression while I was messing around, which I found to work at about the same speed as CWM aside from the md5sum (which for all I know may be the same code as CWM). MD5 takes nearly as long as any long part of the backup (/system or /data) and "appears" to happen at the end in it's entirety. Is there any reason (if that's true) why it couldn't happen during the backup as the .gz (or whatever format is used) files are created and then just written to the correct spot afterward? I figure there must be a good reason, but I seem to recall in earlier CWM and TWRP's that the MD5sum wasn't such a big deal timewise.

I'll look at the code and see if I can figure out how the md5sum is done so I can understand that bit of it.
[Android Software Development] Phil3759:
md5 generation is stock cwm

aroma is not my sources. Sadly, it is rarely updated by his author
[Android Software Development] cooldudezach:
I've rewritten the code for the sdcard menu labels. I think I did a better job at preventing memory leaks :) I also implemented it as a recovery setting. Currently it's still set in the boardconfig, but if there is a way to do character input in the recovery, it can easily be switched to that by reimplementing the setup_display_labels function. :) I've also written it so that it handles just about every possible situation for input via the boardconfig option, so you can set just the internal storage, external, etc. I've got to finish the changes up when I get home from school, and then I'll push them to my github.
[Android Software Development] Phil3759:
Let me know when done

I will review and see if i pull them

Just busy working on loki fix
[Android Software Development] cooldudezach:
Ok, I will. It didn't go exactly as planned, since I was rushing a bit to get to school, so I had to backtrack just a bit. I also realized some of the code needs a minor rewrite as well to properly implement the labels, so I'm working on that as well.
[Android Software Development] cooldudezach:
OK, it's finally done. :)

https://github.com/cooldudezach/philz_touch_cwm6

As last time, it's the latest commit. Let me know if I screwed it up this time lol. Anywhere there is a menu that has options for vold devices, so /sdcard etc, it can replace /sdcard with whatever is predefined as the label.

The only exceptions are the menus in libtouch_gui:

"Backup and Restore --> Clone ROM to update.zip --> Create from Current ROM/Previous Backup"

"PhilZ Settings --> GUI Preferences --> Change Background"

Edit: Actually I did find a small bug I'm attempting to fix, but a look at the code would be nice. :) Thanks.

Edit2: The bug is this: If a label is not defined for a storage volume, empty or otherwise, then it doesn't set the label properly. I think I know the issue, but I'm tired and have work in a few hours.

Edit3: Fixed it. It was a silly logic error that I hadn't accounted for when dealing with more than 1 extra storage device. The repo is now ready to be dissected. Sleep time.

Edit4: oops, had to remove my debugging code! Now it's all good.
[Android Software Development] invisiblek:
Feature request:

After choosing a zip, on the screen where it shows the options:

- No

- Yes - install blahblah.zip

- No

- Return or whatever

Have it generate the md5sum of the chosen zip down below. Maybe something there like "Determining md5sum..." and have it so you don't actually have to wait for it, but if it generates before you choose yes, have it display.

Just a thought....

Unrelated - I reverted the auto-loki on jflte for now, until the official cwm patch gets applied. It's trying to use loki on non-loki devices (jfltetmo, jfltecan, whatever)
[Android Software Development] Phil3759:
Please do not take it personally, but your code is really, really buggy and is causing memory leak and corruption

An advice: use small snippets, compile them on a linux box, fix all your warnings and read carefully manpage for every function you use

Also, before using strdup, get used to malloc and such

Finally, just drop strsep from your habits

I added the idea to my todo list and will look at it once

Hope you do get me

md5: to avoid waiting, the way the cwm gui is done will need to add that to a separate pthread probably. Will look at it, but not sure the way I would do it

also, zip has crc32 check. Is it really vital to add md5?

About jflte: I have no idea why they do not merge that code in CWM

By the way, you could just revert the flag define. The ro.loki_enabled has no effect alone
[Android Software Development] sdeft:
Hi Phil3759

I tried this recovery on Xperia SP and there is a problem with the reboot command in updater-script files. In most of my scripts I have as last line

run_program("/sbin/reboot");

but in this recovery after updater-script finishes the phone is not rebooted.

In plain CWM it works fine. Why is this ?

Also 6.19.3 version will not be available for SP ?
[Android Software Development] Phil3759:
sony devices are now maintained by developers owning the phone

They are porting it

In new updates, I merged this commit:

https://github.com/CyanogenMod/andr...mmit/66d63f719802760f4704718a5d2665dc8b6f8d84

which was causing the trouble
[Android Software Development] sdeft:
ok thanks. Is there a git for sony devices in case I want to try and build one ? (following your build guide in this thread).
[Android Software Development] Phil3759:
I use stock cm device tree

However, you need to repack with stock kernels

There are many guides in sony forums

It is also already updated I think by [MENTION=4675598]shoey63[/MENTION]
[Android Software Development] mohaxs:
Hi [MENTION=4666971]Phil3759[/MENTION] , thanks for your great work. But I'm facing problem on my S2 I9100, when i flashed philz_touch_6.12.8-i9100.zip my IMEI is gone. But if I flash again with other kernel my IMEI is come back. Please help.

Sent from my GT-I9100
[Android Software Development] OKAstro:
How do I get it to backup to my ClockworkMod folder on my external sd? It goes to mnt/shell/emulated/clockworkmod as default
[Android Software Development] cooldudezach:
I'm taking all advice here to heart. It's a new venture for me, and memory management is something I'm not familiar with, so I will do a bunch more research then!

I will look into strdup, malloc some more for sure. I did go through the code in extendedcommands and advanced_commands, and I thought that I had strdup setup the same, but I'm not the expert here ;)

I'm curious as to why strsep is so bad. In my google searches so far, it seems to be a somewhat unanimous agreement that strtok is bad, since it is not thread friendly, and that strtok_r is a better alternative. Again from my searching, I was under the impression that strsep functions the same as strtok_r except that it returns a string for every delimeter, whereas strtok/strtok_r do not.

side question: and how do I check for memory leak and corruption?

edit: I was also thinking, my code doesn't output any warnings except for 1, which is complaining that i didnt use brackets. No further warnings are generated after adding the brackets.
[Android Software Development] HippoMan:
strsep isn't bad, per se. However, it isn't a POSIX routine, and hence, isn't portable. Therefore it's not found in all C environments.

Also, with strsep, you need to understand that you might get empty strings returned to you if you're parsing a string which contains multiple consecutive token separators. strtok and strtok_r do not return those empty strings.

As you know, strtok_r routine is much better than strtok because the former is thread-safe. Furthermore, strtok also can be problematic, even if you aren't using threads. If you have parsed some, but not all of the substrings of a string using strtok, and if you call strtok again on a different string, you will get surprising results if you later go back and make another call to strtok to get the next token from your original string. This is because strtok makes use of a static buffer to hold its intermediate results. strtok_r is preferred, because it doesn't make use of such a static buffer.

In a Stackoverflow discussion concerning this topic (http://stackoverflow.com/questions/7218625/what-are-the-differences-between-strtok-and-strsep-in-c), note the following quote by Jonathan Leffler:

.​
[Android Software Development] Phil3759:
Will look closer at your code. Thought you forgot to malloc pointer to pointer array but i see you defined it as static and fixed size

Could be a good go
[Android Software Development] OKAstro:
Never mind - I was using ROM toolbox Pro which was saving it to that location. Using the recovery's GUI, it goes to the right place.
[Android Software Development] kunal1540:
Hey Phil

I an using your recovery 6.00.8 fit gt i9300

yesterday I got into a problem when I couldn't restore a backup from my internal SD card which I backed up earlier...

First I thought that it got wiped so I restored another backup which was saved in extsdcard... and when it noted up I saw that the backup I was trying to restore was there in the SD card...

Any help on that???

Thanks

Sent from my GT-I9300
[Android Software Development] sdeft:
got another question Phil

Is there a way of changing the touch buttons without building recovery ? Any config file in the cpio ? Or is it embedded in the recovery binary ? Would prefer up to be on left and down on right.

Managed to solve the reboot problem with the fix you provided. Just unpacked the cpio file. Thanks!
[Android Software Development] Phil3759:
no

button position is hard coded in recovery sources
[Android Software Development] Phil3759:
6.19.6

These devices will be updated to fix above issues:
[Android Software Development] erickwill:
My man, u r a machine! :) Thanks for so awesome work you are doing here! :)
[Android Software Development] andrew.mackew:
Sorry about my newbie question.... but is there any need to update t0lte besides those phones you mentioned? Thank you very much Phil3759.
[Android Software Development] Pundy:
Hey everybody.

Has anyone an idea how to get the USB mass storage in recovery with Windows 8.1 to run?

I've tried to use different drivers including the latest HTC driver but nothing helped.

I'm using HTC one X with the latest Philz recovery.
[Android Software Development] Bhargav97:
Hi phil3759,

I get this warning while compiling:

external/llvm/lib/IR/DataLayout.cpp:193:10:warning: 'Result' maybe used uninitialized in this function [-Wmaybe-uninitialized]

What is it regarding?

Can it be the cause of a black screen?!

We've tried many a things now. Still the same black screen! And...our androidarmv6 source has no recent changes in graphics.c file.

This is really mysterious! What is the cause of a black screen?!

We're just left to test adb, will do that asap.

A compile log will help you?

Any idea left with you?

Thanks...
[Android Software Development] odeccacccp:
Is hlte folder now the folder for all variants of Note3? Or I shpuld just wait for hltecan new version and so on?
[Android Software Development] Phil3759:
That is not the error

It is probably some line above that

Read the whole log to find the ERROR causing a stop
[Android Software Development] underskyzx:
Can I just fastboot flash recovery the image instead of flashing the zip?

Or I need a recovery installed already to flash this??
[Android Software Development] hachamacha:
That's how I installed the latest philz image I made for my phone. I already had a recovery (an older stock CWM) but did an 'adb reboot-bootloader' then fastboot flash recovery {recovery.img-name}. Worked fine. Also installed aroma after that and a couple of .png files for background.
[Android Software Development] Bhargav97:
No...It's not actually causing a stop, compile is still successfull. It's just a warning, and I'm asking that does this warning points towards the reason of a black screen?

Thanks...
[Android Software Development] Phil3759:
Ah, no, I do not think
[Android Software Development] neophyte1983:
Bobcat aka Apachi recommend f9r flashing bobcatrom the 6.07.9 version.

Gesendet von meinem GT-I9505 mit Tapatalk
[Android Software Development] danarama:
This isnt the HTC one X thread. Please ask questions about your device there.

I know nothing about your phone but if it doesn't have a removable sdcard or it does have a fused file system then mass storage mode won't work
[Android Software Development] yasirmujtaba:
Need Help Philz

Dear Guruji :D

I have gionee elife e7

And a ported CWM based recovery but unfortunately its in chinese............:(

Any clue to translate it to english,,,,,,,,,,,,,,,,,,,:silly:

please help.................:rolleyes:

cwm- https://drive.google.com/file/d/0B1O1TYKveWuvREgxM3l1ckZHbEE/edit?usp=sharing

stock recovery- https://drive.google.com/file/d/0B1O1TYKveWuvTlZMV2RMTXdpcG8/edit?usp=sharing
[Android Software Development] shoxxy:
Hi Phil

First BIG THX for your work. RESPECT !!!!

i try to build your actual recovery for my Huawei Ascend G510 and getting this Error:

target StaticExecutable: recovery (/home/cm/cm11/out/target/product/u8951/obj/EXECUTABLES/recovery_intermediates/LINKED/recovery)

bootable/recovery/advanced_functions.c:3332: error: undefined reference to 'print_libtouch_version'

external/busybox/debianutils/mktemp.c:96: warning: warning: mktemp() possibly used unsafely; consider using mkstemp()

collect2: error: ld returned 1 exit status

make: *** [/home/cm/cm11/out/target/product/u8951/obj/EXECUTABLES/recovery_intermediates/LINKED/recovery] Error 1

cm@cm-ThinkPad:~/cm11$

with search i could not find a solution. Could you Help me.... ???

THX a lot. Have a nice Day

Regards

Shoxx

Edit: After resync cm-11 repo, and some changes in my device tree, i could succuesfull build you recovery with libtouch gui. now i had to do some little changes (smaller font , boardconfig) then everything works.

THX Again for that masterpiece !!!!!
[Android Software Development] PhazeDelta1:
Liking this recovery so far. Thanks.
[Android Software Development] ali.filth:
Galaxy Core GT-I8262

hai philz,.new device is come.. samsung Galaxy Core Duos GT-I8262 ( Philz Touch 6.19.6 )

link :

http://d-h.st/R7P (img)

http://d-h.st/Rju (flashable zip)

http://d-h.st/1tb (odin)
[Android Software Development] rrowe1980:
The only problem I have with this recovery is, is that it doesn't have a noob-friendly restore nandroid option. When I tried to restore a twrp(nandroid), and yes, i checked twrp mode, it only gives me the option to restore one element of the nandroid, and not the whole folder. I humoured it, and picked a file within it to restore, and it asks me explicitly which partition to restore the element to. Confusing, and because of that, risky. Im sticking with twrp 2.6.3.1att, never had a problem. Its a pity cause I really liked the customizable gui options with philz.
[Android Software Development] cooldudezach:
I seem to be running into these issues on multiple devices using the latest philz, and I'm hoping somebody can shed some light on it.

1) If I format /cache, it refuses to mount until after booting into android and then back into recovery.

2) On occasion (so not all the time), attempting to "format /data" will cause the device to restart, without doing anything. However, "format /data and /data/media" works fine. Presumably this is because /data is unable to mount due to some unknown reason, and then recovery tries to mount it to perform "rm -rf" for "format /data"
[Android Software Development] Phil3759:
Will upload, thanks

But if you can upload your device tree and recovery changes to github would be nice

Probably a kernel missing some options to properly format in ext4

Try to get it working with the prebuilt formatting tool. We had same issues on some early galaxy s4 kernels
[Android Software Development] Phil3759:
No, custom mode lets you see backup contents. What ever file you select it is not going to rely on your skills to decide where to restore it