yashsingh1/xdaforums huggingface dataset:
[Android Software Development] donalgodon:
[MENTION=4666971]Phil3759[/MENTION]

Sorry...

Maybe I violated your no PM rule?

Here are the LG Optimus G Pro images we discussed. I didn't know where else to post them, since I couldn't PM you:

Boot.img. http://www.mediafire.com/view/?n79dl5698t19b7i

Texfat.ko http://www.mediafire.com/?xgtf2mtm446uadr
[Android Software Development] argel08:
Hi

Can I flash latest Philz Touch on my galaxy s4 I9505 using TWRP? currently im on TWRP..
[Android Software Development] danarama:
Wrong thread. This is not the i9505 thread

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] Phil3759:
- Galaxy Note 8.0 (N51xxx) - Unofficial port by [MENTION=3986004]civato[/MENTION]
[Android Software Development] Phil3759:
Let me know when you update tree to use exfat Samsung modules

However, it is normal you won't be able to mount exfat as you need to edit vold device tree for that. That I will do

No, it's not you, your request was ok as device is new and has a cm-10.2 tree :good:
[Android Software Development] geokilla:
Can you add in support for the Optimus G E971? You only support E973 right now.
[Android Software Development] tamirda:
[MENTION=4666971]Phil3759[/MENTION]

Any news about the size flash limit?

Thanks mate.
[Android Software Development] Phil3759:
I have no near plans to look at it
[Android Software Development] titanic_fanatic:
Hey Phil3759,

I have updated my device repo with the necessary changes to build with the pre-built stock Samsung kernel. I learned alot in this process and want to thank you for the "nudge" to learn more about the recovery part of android. I am also curious of the changes that are required to make this work with vold, if possible, can you provide a link to the commits?

I have built this recovery using my modified device repo and all testing has been successful. Recovery boots and works as it should, system also boots and still works as it should. I think were ready to go ;)

The new manifest should look like this:

<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<project name="CyanogenMod/android_device_samsung_celox-common" path="device/samsung/celox-common" remote="github" revision="cm-10.2" />
<project name="CyanogenMod/android_device_samsung_qcom-common" path="device/samsung/qcom-common" remote="github" revision="cm-10.2" />
<project name="titanic-fanatic/android_device_samsung_celoxhd" path="device/samsung/celoxhd" remote="github" revision="cm-10.2" />
<project name="titanic-fanatic/android_vendor_samsung_celoxhd" path="vendor/samsung/celoxhd" remote="github" revision="cm-10.2" />
<!-- The kernel source is not needed for building Philz Recovery since it will build with a pre-built stock kernel found in the device tree -->
<!--<project name="titanic-fanatic/android_kernel_samsung_msm8660-common" path="kernel/samsung/msm8660-common" remote="github" revision="cm-10.2" />-->
<project name="titanic-fanatic/android_device_samsung_msm8660-common" path="device/samsung/msm8660-common" remote="github" revision="cm-10.2" />
<project name="titanic-fanatic/philz_touch_cwm6" path="bootable/recovery" remote="github" revision="cm-10.2" />
</manifest>

On my device, the recovery partition can be found at:

/dev/block/mmcblk0p22

and the boot partition can be found at

/dev/block/mmcblk0p8

Is there anything else you need from me?

---------- Post added at 02:31 PM ---------- Previous post was at 02:07 PM ----------

@Phil3759 I forgot to change the branch in my manifest... change the device repo branch to philz-recovery-cm-10.2 ;)

Thanks
[Android Software Development] Phil3759:
Thank you,

Will look at it

vold changes can be found here:

https://gist.github.com/PhilZ-cwm6/6856758

I added the same for ntfs.cpp for phones with ntfs.ko module

credits to [MENTION=3084245]Chenglu[/MENTION]
[Android Software Development] donalgodon:
[MENTION=4666971]Phil3759[/MENTION]

Following up on the LG Optimus G Pro boot image, this is the Loki thread with github

http://xdaforums.com/showthread.php?t=2358871

It's also applicable to the LG G2 as well, I think.
[Android Software Development] captain_nemo:
Philz Touch Recovery 5.18.9 port to Micromax A110

Hello	@Phil3759, I have ported Philz Touch Recovery 5.18.9, CWM 6.0.4.4 based, into Micromax A110. Please check the below thread.

http://xdaforums.com/showthread.php?p=47143598#post47143598

Thanks for your wonderful work.
[Android Software Development] danarama:
No. Read post 2. If you don't have the development skills to do what is in post 2, find someone in your device forum that has. This is the ONLY way to get support for a device. This is all in post 2.
[Android Software Development] captain_nemo:
Hello [MENTION=643734]Philz[/MENTION] and friends, I am getting below error during taking backup.

It's showing mismatching of path. Other things are working properly.

This my thread: http://xdaforums.com/showthread.php?t=2513107

Please show me a path to solve it.
[Android Software Development] :
Brother,

Don't feel bad cause I too ported it a month back and Phillz has denied to work on new device for now. He will do that but in his free time. He already has told me and icoolguy. If you want to try then try compiling it from sources. Or else there I'd no option to make it work.
[Android Software Development] DerTeufel1980:
[MENTION=4666971]Phil3759[/MENTION]

I am not able to format the external sdcard to vfat by using your source neither on cm cwm.

Do you have any idea about this.

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] captain_nemo:
This is the test result.

Everything is working perfect.....

backup is working (but have to use custom backup means without boot.IMG and recovery)

restore is working....

restore cwm backup also working

I checked it and same got confirmed from @khan_frd2002
[Android Software Development] :
Yes that's right brother,

If anyone is on 4.2 and want to use this recovery can use it. Other than backup and restore of boot and recovery, everything will work good without any problem. Don't worry your work is great and it doesn't have any problem i personally tested it.
[Android Software Development] Phil3759:
I answered many times that part. CWM doesn't support MTK chips. I will add support later, when I have time. It is on my todo list

If you want something good, port your device tree to cm-10.2 and commit to github. Post a link here when you are able to compile open source part. Look at my repo as I uploaded a good formatted device tree for an Axx device

After that, post link here. I will build it when I add MTK chips support

It works for me. N71xx is still under cm-10.1 though, so not using new minivold service

I had no issues to format to fat under cm-10.1

Is you card a 64Gb one? In that case, it could be the cause
[Android Software Development] DerTeufel1980:
What do you mean by "is still under cm10.1"

I compiled both recoveries by using CM10.2 branches, also for device tree.

I commented out the part, where it checks for being voldmanaged, but it still fails.

Do I need to modify recovery.fstab for this to work properly?

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] Phil3759:
Ah, I thought you were talking about the official version, not a compiled version by you

Can you be more precise? What happens when you format /storage/sdcard1 in vfat? It should offer you a menu to select format type.

What device tree are you using because recovery.fstab should not exist under cm-10.2. It is generated on compile time from main fstab file for device

Finally, what is your card? 16Gb, 32Gb or 64Gb? I suspect busybox still have issues to format in fat32 for big cards
[Android Software Development] CYBERFANT:
Hi Phil, why you Block my PM to Support the Asus Padfone2?
[Android Software Development] danarama:
Probably because you're not following the process in post 2

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] jgruberman:
I have this recovery flashed and I went to install a new ROM from my external SD card, bu got the following error when I tried to load a zip from external SD:

/storage/sdcard1: Checking

/storage/sdcard1: Idle-Unmounted

E:Can't mount /storage/sdcard1

Then I tried to mount it manually from the mount screen and got this error:

/storage/sdcard1: Checking

/storage/sdcard1: Idle-Unmounted

Error mounting /storage/sdcard1!

If I try and mount USB storage, I can see the files on the external SD card just fine on my computer. I'm dead in the water until I can either A) Get my ROM onto my internal SD card since I can access that still or B) Get my recovery to be able to see my External SD card.

Any thoughts? Help! :eek:
[Android Software Development] nfribeiro:
PhilZ, please check this from [MENTION=631273]Chainfire[/MENTION].
[Android Software Development] danarama:
Yes, post in your device thread

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] jgruberman:
I don't understand how that would help me when the issue I have is with this recovery.
[Android Software Development] danarama:
This is the GENERAL DEVELOPMENT thread for Philz recovery. All supported devices have their own DEDICATED DEVICE thread for Philz recovery. These are linked in post 1 and that is where your problems should be posted. This thread is for development problems not user problems.

95% of the people in this thread don't have your device. In the device specific threads, 95% of people DO

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] DerTeufel1980:
yes, it offers the menu to select the format type, then after i chosse "default" or "vfat", i get:

Could not format storage/sdcard1 (vfat)

i am using the cm device tree for smdk_4412-common and t0lte. i know there is no recovery.fstab, but i was just wondering bcause yours is looking differently from mine.

yours:

cat recovery.fstab
# mount point fstype device
/efs ext4 /dev/block/mmcblk0p3
/boot emmc /dev/block/mmcblk0p8
/recovery emmc /dev/block/mmcblk0p9
/cache ext4 /dev/block/mmcblk0p12
/system ext4 /dev/block/mmcblk0p13
/data ext4 /dev/block/mmcblk0p16 length=-16384
/preload ext4 /dev/block/mmcblk0p14
/modem emmc /dev/block/mmcblk0p10

/sdcard datamedia /dev/null
/external_sd auto /dev/block/mmcblk1p1
/sd-ext ext4 /dev/block/mmcblk1p2

and mine (copied from out/[device]/recovery/root/etc):

# Android fstab file.
#<src> <mnt_point> <type> <mnt_flags and options> <fs_mgr_flags>
# The filesystem that contains the filesystem checker binary (typically /system) cannot
# specify MF_CHECK, and must come before any filesystems that do specify MF_CHECK
# data partition must be located at the bottom for supporting device encryption
/dev/block/mmcblk0p13 /system ext4 ro wait
/dev/block/mmcblk0p3 /efs ext4 noatime,nosuid,nodev,journal_async_commit,errors=panic wait,check
/dev/block/mmcblk0p12 /cache ext4 noatime,nosuid,nodev,journal_async_commit,errors=panic wait,check
/dev/block/mmcblk0p11 /tombstones ext4 noatime,nosuid,nodev,journal_async_commit,errors=panic wait,check
/dev/block/mmcblk0p10 /firmware vfat ro,shortname=lower,fmask=0133,dmask=0022,context=u:object_r:radio_efs_file:s0 wait
/dev/block/mmcblk0p16 /data ext4 noatime,nosuid,nodev,discard,noauto_da_alloc,journal_async_commit,errors=panic wait,check,encryptable=footer

# vold-managed volumes ("block device" is actually a sysfs devpath)
/devices/platform/s3c-sdhci.2/mmc_host/mmc1 /storage/sdcard1 auto defaults voldmanaged=sdcard1:auto
/devices/platform/s5p-ehci /storage/usbdisk0 auto defaults voldmanaged=usbdisk0:auto

# recovery
/dev/block/mmcblk0p8 /boot emmc defaults recoveryonly
/dev/block/mmcblk0p9 /recovery emmc defaults recoveryonly
/dev/block/mmcblk0p10 /modem emmc defaults recoveryonly
[Android Software Development] Phil3759:
As I said, last PhilZ Touch I built for N71xx is cm-10.1, so with recovery.fstab v1 you quoted

New cm-10.2 based recoveries use fstab v2

PhilZ Touch recoveries I release should work perfectly when formatting to vfat or any other format

CWM stock ones cannot partition sdcard or format it to ext2/ext3

I use extra.fstab for that, but shouldn't affect format to vfat fstype
[Android Software Development] DerTeufel1980:
Got the fstab thing now.

However why does it fail for me, if i build your recovery or cm from sources?

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] Phil3759:
First, try my last official PhilZ Touch for your phone. Does it properly format to vfat? It uses a custom built mkdosfs from sources instead of busybox

Next, what is the size of your sdcard? I suspect busybox is still messing vfat formatting on sdcards bigger than 16Gb. I have no big sdcard to test currently. CM-10.2 uses minivold which is calling busybox binaries

Please post a feedback on these as I am interested to fix cm sources if needed
[Android Software Development] DerTeufel1980:
I'll try your last official in a bit.

My card is only 8gb, sorry had forgotten to write it.

I'll report back

Gesendet von meinem GT-N7105 mit Tapatalk 2

edit: working fine with yours.

i just did delete the recovery sources and cloned them again (yours).

then compiling failed, and i got an idea.

i am compiling with latest linaro gcc 4.8.2 toolchain, and had to comment out the -Werror in the android.mk of voldclient, in order to make it compile.

Athough it was just a warning, treated as error, do you think the toolchain could be cauing it?

this was the rror/warning:

bootable/recovery/voldclient/dispatcher.c: In function 'vold_dispatch':
bootable/recovery/voldclient/dispatcher.c:201:48: error: unused parameter 'len' [-Werror=unused-parameter]
int vold_dispatch(int code, char** tokens, int len) {
^
cc1: all warnings being treated as errors
[Android Software Development] Phil3759:
You should ignore that error, just a non used function argument. Maybe there for later enhancements...

On 8Gb card, you shouldn't get any issues. Maybe it is your toolchain bricking minivold or ramdisk generation

Try to compile under cm tree using cm official tools
[Android Software Development] DerTeufel1980:
Thanks. I'll try stock toolchain and report back soon

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] core720:
please update for mako (nexus 4)
[Android Software Development] danarama:
Asking for updates or eta of updates is against the rules

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] machhho:
why is the latest vesion is not supported by the Galaxy S4 GT-I9500 !

thanks
[Android Software Development] danarama:
Come ON you guys! Why must we repeat ourselves constantly?

Not every update is relevant to every device. Devices also cannot all be updated at once. Updates come when they come

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] Phil3759:
I am crazily amazed by your patience and perseveration :angel:
[Android Software Development] danarama:
Me too :)

I feel it has to be done though and there's a distant hope someday it will sink in ;)

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] core720:
????????? I did not know that comment is against the rules
[Android Software Development] danarama:
ETA asking is a general rule about development in general. Never ask for ETA's. It's rude and annoying:

http://www.androidheadlines.com/2013/07/jbq-from-aosp-talks-about-etas-dont-ask.html

XDA moderator posts seem to be a bit hit and miss (inconsistant) however, read number 5 here:

http://xdaforums.com/showthread.php?p=46847787
[Android Software Development] DerTeufel1980:
ive did a 'make clean' now, after reverting the toolchain back.

unfortunately format still fails with the same error. all the same, your unmodified, built from sources of today, as well the one built from cm sources.

any advice where to add some debugging code?
[Android Software Development] Phil3759:
FIRST: unmount external storage in recovery (Mounts and Storage menu)

In adb shell, as root, run below command and replace XXX with external storage value

/sbin/newfs_msdos -F 32 -O android -c 8 /dev/block/mmcblkXXX

Check if it works or any error returned

That's the command used by new vold code
[Android Software Development] DerTeufel1980:
this command is working properly, but then i have to come back to the fstab file.

in the autogenerated fstab, there is not the path to the blockdevice, but only this:

/devices/platform/s3c-sdhci.2/mmc_host/mmc1

and if i change the above code, to use the path from fstab, it fails

random question: is fstype2 no longer used in the new fstab? or what would be the correct syntax, to add it?
[Android Software Development] xSpeced:
Since 5.18 on the i9300, you can flash stuff from external sd card at all anymore :(

Any help?
[Android Software Development] danarama:
This is not the i9300 thread. Post in the i9300 thread please

-----------------------

Sent via tapatalk.

I do NOT reply to support queries over PM. Please keep support queries to the Q&A section, so that others may benefit
[Android Software Development] Phil3759:
You have to know these about new cm-10.2 and fstab v2:

- you cannot use voldmanaged device path to mount/format/...

- voldmanaged volumes will not figure in recovery.fstab, so you cannot mount by only invoking mount points

- minivold service is behind this

- fs_mgr is now used to parse recovery.fstab and it doesn't support blk_device2/fs_type2/fs_options2 for now

Look at these 2 commits:

https://github.com/PhilZ-cwm6/philz_touch_cwm6/commit/92a34c373ba42b2a8bb74b889be51f80cd3733bb

and updated here

https://github.com/PhilZ-cwm6/philz_touch_cwm6/commit/310dda4acddf81da669a09da8f42935500c3ce3d

They enable it so that you can call them

Look at my i9300 latest release to see how recovery.fstab and extra.fstab must be
[Android Software Development] DerTeufel1980:
I am going to take a look at the i9300 release. I already saw the extra.fstab in your source, but I think my syntax was wrong.

OK, what could I do regarding the format error? Fstab is fine, as vold has to deal with it, right?

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] Phil3759:
Here's where format sdcard happens:

https://github.com/PhilZ-cwm6/philz_touch_cwm6/blob/cm-10.2/extendedcommands.c#L1318

Maybe add some logging there to see what happens

Could be your fstab file is bad which will fail the "if (fs_mgr_is_voldmanaged(v))" check. You then drop to blk_device use which obviously won't work on fstab v2 files

You shouldn't need my extra.fstab for that. Just look carefully at my i9300 and also i9505 versions, unpack them and see how recovery.fstab should be. Many cm-10.2 device maintainers are f***ing it hard the bad way. I fix most my device trees to get some thing working. That's why I couldn't migrate all devices so quickly. Most are broken because fstab v2 use is not well documented as it should
[Android Software Development] DerTeufel1980:
the only difference between your and mine fstab is here:

voldmanaged=sdcard:auto (yours)

voldmanaged=sdcard1:auto (mine)

i am currently trying your workaround for my sdcard now.

if voldmanaged, but blk device2 != then

use blk device 2, without invoking vold

edit: this way it is working now :)

edit2: thank you very much again. with s similar workaround i am now also able to bind mount some stuff again. great!

this is my case4 now:

{
int blk2 = 0;
const char *device = NULL;
if (fs_mgr_is_voldmanaged(v)) {
device = v->blk_device2;
if (device == NULL)
device = v->blk_device;
else
blk2 = 1;
} else {
device = v->blk_device;
}

if (fs_mgr_is_voldmanaged(v) && blk2 == 0) {
ret = vold_custom_format_volume(v->mount_point, list[chosen_item], 1) == CommandOkay ? 0 : -1;
} else if (strcmp(list[chosen_item], "vfat") == 0) {
sprintf(cmd, "/sbin/newfs_msdos -F 32 -O android -c 8 %s", device);
ret = __system(cmd);
} else if (strcmp(list[chosen_item], "exfat") == 0) {
sprintf(cmd, "/sbin/mkfs.exfat %s", device);
ret = __system(cmd);
} else if (strcmp(list[chosen_item], "ntfs") == 0) {
sprintf(cmd, "/sbin/mkntfs -f %s", device);
ret = __system(cmd);
} else if (strcmp(list[chosen_item], "ext4") == 0) {
ret = make_ext4fs(device, v->length, volume, sehandle);
}
break;
}

i just don't understand why vold is refusing to format my sdcard :p
[Android Software Development] Phil3759:
Use

voldmanaged=sdcard:auto

and let me know please :good:
[Android Software Development] DerTeufel1980:
changing it, didn't work either. sorry.

anything else i can try to debug it for you?
[Android Software Development] Phil3759:
Sorry, I cannot reproduce your issue

I just formatted my 16Gb sdcard to exfat and vfat without any issue (except waste time backing it up and restore to be sure it is not a cwm issue ;) )

I also formatted an USB 32Gb key to both exfat and vfat, again no issues

You have probably an issue with your device tree or your non correctly in sync repo

Can you post a link to your device tree?

Also, maybe try to repo sync and use << mka recoveryimage >> on a clean cm tree
[Android Software Development] tyvar1:
Hi Phil! :D sorry to disturb but when will the latest version come to SGN2?

Kind regards,

Tyvar1
[Android Software Development] danarama:
http://xdaforums.com/showpost.php?p=47161119&postcount=1510
[Android Software Development] tokenpoke:
Is there a way to set flash order in multiflash tool?
[Android Software Development] vivelafrance:
Anyone has managed to install this on a Samsung Galaxy Note 10.1 (N8010) by any chance?

I can install, but stock recovery is reinstalled after reboot.

I have done the little trick mentioned in the install notes (see below), but after next reboot, it reinstalls the stock recovery on top of this one. I actually didn't get any message saying "disable flash recovery", I had only the one saying "root the device?", which I replied NO cause I don't want to root my tablet due to work apps that I need such as "Good Application" to get my work emails (doesn't work on rooted devices).

"If it reboots into main system and your recovery remains stock, repeat above steps and untick "autoreboot" in odin. Once flash is done, keep pressing the 3 buttons combo to for a reboot into recovery.You should see the new CWM

when in recovery, if you choose option "reboot system now" and you get "yes - disable flash recovery", select that option to avoid stock recovery overwriting cwm"
[Android Software Development] Striatum_bdr:
Change name, files are sorted alphabetically.
[Android Software Development] DerTeufel1980:
Strange. I am going to try with a clean device tree at the weekend. For now I am just using the workaround.

Gesendet von meinem GT-N7105 mit Tapatalk 2
[Android Software Development] tyvar1:
? I don't understand :(
[Android Software Development] danarama:
Do not ask for ETA. It is rude and against the rules.
[Android Software Development] tyvar1:
Ah, ok sorry! :(
[Android Software Development] tokenpoke:
that's his way of saying "developers do this in their free tine, for no pay. They take time away from friends and family to learn this and build stuff for you. As they are essentially working for free and unscheduled its uncouth to demand an estimated time of arrival for roms, kernals, recoveries or other mods."