yashsingh1/xdaforums huggingface dataset:
[Android Software/Hacking General [Developers Only]] Phantasm4489:
Just to let you know GFE issued a DMCA takedown request to get xda to remove the patched gfe apk

https://github.com/xda/Notices/blob/master/2014/Good-2014-10-13.md

so beware of reposting any links to the modified apk that i made. They don't seem to care about the numerous links to the older versions being posted however.
[Android Software/Hacking General [Developers Only]] jeevanreddy58:
We better msg the links.
[Android Software/Hacking General [Developers Only]] blitzed47:
Hi boys and girls...having some trouble here. hoping someone can provide some direction...check it...

I have used GFE successfully on a rooted Samsung Galaxy S3 running Kit Kat with xposed module 1.0 and gfe 2.4. I just switched to a S5, rooted and running MOAR rom. I am running the xposed installer 2.6.1 with frameworks 58/54. I have tried gfe xposed modules 3.1, 1.0, 3.3 (in that order) all with gfe 2.4. Getting force closes immediately at launch (not even a peek at the red GFE screen)

I've friggin read in detail all posts since the xposed module was brought up (post #679 or something) and someone mentioned the xposed framework 58/54 is causing trouble but I see no resolution to that in the subsequent posts. My ask is if anyone has hit this and resolved OR if I can somehow downgrade the xposed .jars I am running. I am somewhat a tech guy (although I haven't truly coded in ~15 years) and I'm not sure how to downgrade the xposed framework if that is my workaround...

Any help is much appreciated!!!

EDIT: I just tried GFE 2.7 with xposed 3.3 module and still force crashing. I'll upload a stack trace in a bit
[Android Software/Hacking General [Developers Only]] Phantasm4489:
I'm not sure exactly whats wrong here to be honest but I think gfe 2.4 is definitely your best bet.

gfe 2.5 onwards all have routines in them which are designed to detect the presence of the xposed framework and this code can't be bypassed using xposed (at least i haven't found any way to do it so far).

Have you tried running gfe 2.4 without xposed on your S5 just to see if it works correctly (obviously it will detect root but at least you might be able to narrow down where the problem lies if it doesn't work)
[Android Software/Hacking General [Developers Only]] 78Staff:
Got 2.4 working with xposed 2.6.1 and patcher 3.1 & CM11 (10/22), no desire to upgrade Good as it works fine for me :good:

Nice to have Good again after so long without it, I had all the custom rules and filters to forward mail and it was a pain.

Thanks punched!

Now, I read back a ways, but just wanted to double check - what about CM nighties - any issues there. I though I saw something about uninstalling Good/Reinstalling so there is no chance of root check firing off if xposed module isn't running after updating rom, or something like that - although I might be confusing two different issues. I'll go back and read through again ;).
[Android Software/Hacking General [Developers Only]] Phantasm4489:
Any time you flash a new Rom, exposed will need to be re-enabled manually and in the time it takes to boot up and re-enable xposed the good application will have detected root and locked you out. Best thing is to backup the app with titanium and then you should be able to restore from the backup and continue using good or disable (freeze) the app during the Rom flashing and re-enable (unfreeze) after xposed is re-installed.

This applies to all roms and all versions of the good client
[Android Software/Hacking General [Developers Only]] blitzed47:
I clean installed moat ROM again this time picking stock kernel (I was on ktoonez) did the rx'd install of 3.3 and 2.4 and was fine. Thinking it was the kernel.

Ummmm..yay. I guess... Get to read work email more :\
[Android Software/Hacking General [Developers Only]] ZipLipZ:
Did you get the secure browser working? I'm still looking for an older version that works with 2.4.
[Android Software/Hacking General [Developers Only]] 78Staff:
Yep this worked like a charm on recent update from .23 - Froze Good, did updates, unfroze, everything worked great :good: :D
[Android Software/Hacking General [Developers Only]] anoraknophobia:
Hi everyone,

if someone having troubles wit ha crashing GOOD App. Change the kernel.

I was using the InsertCoin (4.4.4) Rom on my HTC One M8 with the stock kernel.

GOOD crashed everytime when it tried to receiving channel settings.

Today i installed the updated Customkernel ElementalX which has been updated to the 4.4.4 source and GOOD is running again normally with the Xposed Plugin.

Too bad i don't know what the ElementalX developer adds to make Good working.

Currently using GFE2.7 for the play store and the 3.3 xposed module without any problems.
[Android Software/Hacking General [Developers Only]] goksar:
have you installed GFE 2.7 with the 3.3 xposed module? i tried GFE 4.4 with the 3.3 modul but GFE detects that my M8 (running viper) is rooted :/
[Android Software/Hacking General [Developers Only]] anoraknophobia:
Yes. GFE 2.7 from Playstore and Module 3.3 from Xposed repo.

Working with ElementalX Kernel for 4.4.4
[Android Software/Hacking General [Developers Only]] spider623:
Did you guys tried using cyandelta?
[Android Software/Hacking General [Developers Only]] goksar:
just to be sure - which version of xposed are you running? i have xposed 2.6.1 with frameworks 58/54. Good is basically running, my only problem is the root detection :/
[Android Software/Hacking General [Developers Only]] anoraknophobia:
I am running 58/54 with Xposedmodule 3.3 from the Xposed Downloadsection (not a beta/alpha from XDA) and GFE 2.7 from Play Store.
[Android Software/Hacking General [Developers Only]] goksar:
which xposed version are you running - 2.7 or 2.6.1?

Gesendet von meinem HTC One_M8 mit Tapatalk 2
[Android Software/Hacking General [Developers Only]] anoraknophobia:
I am using 2.6.1
[Android Software/Hacking General [Developers Only]] goksar:
hmm, i can only find version 3.1 of the GFE module in the Xposed Downloadsection...??
[Android Software/Hacking General [Developers Only]] anoraknophobia:
Ok maybe i had a brainlag. I'll attach the Version i am using. I am sorry but it was really posted in this thread here.
[Android Software/Hacking General [Developers Only]] Phantasm4489:
i never pushed the later versions as they didn't work 100% for everyone with anything later than gfe 2.4 (which the older version works with anyhow).

Now i have a new version of the Xposed module for you all to test with GFE client 2.7

it will ask for root access one time (although the request will come from the good client not the Xposed module) the first time you load the good client application (it will only ask again if you update or reinstall the good client). I suggest not allowing the root access permanently just to be sure.

Let me know how you all get on
[Android Software/Hacking General [Developers Only]] dabrowsk:
Just to be sure: this version whould work with version 2.7 not patched by you?
[Android Software/Hacking General [Developers Only]] Phantasm4489:
correct. it should work with 2.7 straight from the play store
[Android Software/Hacking General [Developers Only]] akarol:
Love you!
[Android Software/Hacking General [Developers Only]] 78Staff:
OK for CM11, or do we still need to stay with 2.4 good client on CM?
[Android Software/Hacking General [Developers Only]] Phantasm4489:
should be good for everyone
[Android Software/Hacking General [Developers Only]] 78Staff:
well I got curious... something about a cat comes to mind :(. I might have the updating process down wrong, though.

froze Goood 2.4

updated module to 3.4

checked that it was enabled

rebooted

unfroze good,

launched good, and got the compliance error

(still with 2.4, didn't get a chance to upgrade to 2.7 - maybe I should have updated to 2.7 before starting). Also running Xposed 2.6.1 if that makes a difference.

I reverted everything back, ie Good 2.4, module 3.1, and all seems to be fine again.
[Android Software/Hacking General [Developers Only]] vivelafrance:
could someone pls PM me the link to download 3.3? Can't find it in the Xposed Modules Repository. thnx
[Android Software/Hacking General [Developers Only]] dabrowsk:
For me it doesn't work. I got compliance error.

Procedure was

Bacckup gfe

Uninstall patched gfe

Install new xposed module

Reboot

Install new gfe

Restore data for gfe

And running gfe -> compliance error
[Android Software/Hacking General [Developers Only]] Phantasm4489:
If it fails when you try it please send over your xposed logs so I can investigate the problem
[Android Software/Hacking General [Developers Only]] thehobit:
My phone has root check disabled by admin, so the value of the result is mainly to check compatibility with Xposed.

•	New GFE patch 3.4

•	Playstore GFE application 2.7

Works perfectly. Well done Phantasm4489, you seem to workaround the Xposed framework compatibility issue.

One thing which is weird with the Good - Xposed compatibility, provided that Good decided to target and detect the Xposed framework itself , how come some phones with ASOP ROM (no custom) have no issues, while custom ROM’s do? If it was by design, I would expect Good to check it first on ASOP ROM’s..
[Android Software/Hacking General [Developers Only]] Phantasm4489:
There's nothing in the code that detects xposed that specifically excludes stock Roms from being checked as far as I can see. I'm assuming the checks fail for some unknown reason
[Android Software/Hacking General [Developers Only]] 78Staff:
Well I re-did the process again tonight, but with different results...

CM11 10.30 nightly, Xposed 2.6.1, Module 3.4, Good 2.7.x from playstore

Backed up Good (2.4 playstore)

Uninstalled good

Uninstalled module 3.1

rebooted

installed module 3.4, activated

rebooted

Installed current Good from Playstore

Restored Good Data Only

Started Good, Allowed Root, so far so good - no compliance error.

But, I will get an unknown session error in Good. I see existing emails, etc, but no new emails and can not send or receive.

IIRC (before my company instituted the root check) that has more to do with restoring Good data vs running through the initial setup with a new pin, thus not having the Good "Account" existing in Settings - not a issue due the module itself. Sometimes it resolves itself after a bit, sometimes not. So will wait and see. If it' doesn't sort itself out I will get another pin tomorrow and clear the app and do a fresh setup and report back.

I also attached log file in case it might be useful...
[Android Software/Hacking General [Developers Only]] 78Staff:
Actually my pin was still valid for a few more days, so I went ahead and cleared data and re-did setup on Good 2.7, and all appears to be working fine now... :good::good:
[Android Software/Hacking General [Developers Only]] dabrowsk:
Finally it's working :) I had to reinitialize with new pin.

Great

Thank you.
[Android Software/Hacking General [Developers Only]] jeevanreddy58:
Can I update the xposed framework? Will it detect root while it is updating ?

Thanks
[Android Software/Hacking General [Developers Only]] sean.trinidade:
From recollection, it's never made any difference for me, but always best to freeze the app first (and make a backup) before messing with xposed!
[Android Software/Hacking General [Developers Only]] strictlyrude27:
I get immediate force closes when using GFE Security Patcher 3.4 against a brand new install of GFE 2.7 from the Play Store, regardless if I accept or deny root access to Good.

Additionally, root gets detected with GFE 2.4+patcher 3.4. I'm reverting to 3.1 for now to try to reinstall GFE 2.4. The last time I attempted to restore GFE 2.4 from backup, emails never came through...

On a Verizon GS4, Android 4.4.2

EDIT: Using Xposed 2.6.1
[Android Software/Hacking General [Developers Only]] 78Staff:
Re restoring and emails never coming through, when you restore vs. installing fresh (with a pin) you no longer have the Good Account configured in settings (see screenshots a few posts back). I used to run into this all the time when updating nightlies before my company enabled root checking. There are a couple things you can try - Sometimes restoring data twice will get it working, sometimes if you do a manual send and receive, or generate an email from the app itself, it can get things working again. But sometimes not, and when that happens you pretty much have to get a new pin from your company's Good Support folks.

For the new patcher version and Good 2.7 issue, post your xposed log, otherwise the dev can't really offer any help... From what I've seen, and from the posts so far, it seems for the new patcher to work with 2.7, a fresh install may be required. Both myself and dabrowsk, upgrading an existing install of Good didn't work, but as soon as we did a fresh install, everything worked fine.
[Android Software/Hacking General [Developers Only]] jjc5891:
FYI, latest update on 11/5 detects root on Nexus 5 with version 3.4 of the module
[Android Software/Hacking General [Developers Only]] dabrowsk:
+1 :( nexus 5 as well.
[Android Software/Hacking General [Developers Only]] jonsharky:
GFE still works with Latest update 11/5 ! Whew !
[Android Software/Hacking General [Developers Only]] Phantasm4489:
Not according to the previous two posts it doesn't. Strange inconsistencies
[Android Software/Hacking General [Developers Only]] 78Staff:
What do the logs say?
[Android Software/Hacking General [Developers Only]] Zenith24:
I can only confirm that GFE 2.7.0.383 works with V. 3.4 of Phantasms module. I recommend to stick with that combination and dont' download GFE 2.7.1.

Maybe some unchallenged programmer/application developer at Good Technology reads this thread and ups a new version everytime Phantasm does an update. :cyclops:

<waving at Good Technology> ---> Put some more effort in your app instead, maybe then you get some better reviews in the play store......
[Android Software/Hacking General [Developers Only]] thehobit:
I have root check disabled by admin. New version still crashes, most likely due to xposed.
[Android Software/Hacking General [Developers Only]] Phantasm4489:
here's a new updated xposed module which should work with 2.7.1 (and older versions) - as with the last one it may ask you for root access the first time you run it (or after an upgrade of the gfe app). This is needed to disable the native checks.

in response to Zenith24's comment about them reading this and updating the app. Its expected that each new version will require some changes to the xposed module due to the way the obfuscation works in the app. For the most part its not due to changes in the way the security works.
[Android Software/Hacking General [Developers Only]] dabrowsk:
Thanks a lot. It works :)
[Android Software/Hacking General [Developers Only]] El Ha$on:
I can also confirm latest patch and fresh install from play store (2.7.1) is working for me. Thank you.

Sent from my LG-VS980
[Android Software/Hacking General [Developers Only]] dkoon1987:
I can confirm also that your new module works with Good version 2.7.1.(390). Thanks!!!! :good:
[Android Software/Hacking General [Developers Only]] 78Staff:
Are you guys doing an in place upgrade of Good from the play store after enabling the new module, or uninstalling and installing fresh (thus requiring a new pin, at least for me)..
[Android Software/Hacking General [Developers Only]] El Ha$on:
I did a completely fresh install requiring a new pin. I did not have gfe installed previously.

Sent from my LG-VS980
[Android Software/Hacking General [Developers Only]] jeevanreddy58:
Hi , it is not working. I was using 2.4 gfe , 3.1 patcher. It was working.

Later I downloaded the patch. Installed. Soft reboot.

Now the patch version in xposed is 3.5

Opened good. Boom. Contact ur administration. Uninstalled the xposed. Logs r gone.

Please let me know if I have to provide any other details.

Thanks,

Jeevan
[Android Software/Hacking General [Developers Only]] dabrowsk:
Me, I updated good after installing new xposed module version (and rebooting of course) .
[Android Software/Hacking General [Developers Only]] Phantasm4489:
Did you disable/freeze/uninstall the good client while doing the module upgrade? If not then it probably detected root during the upgrade process.
[Android Software/Hacking General [Developers Only]] jeevanreddy58:
Didn't freeze it. Might be that was the issue.

Anyhow I got new key and validity is 10 days. I will install it after I update os to cm 11 m12(comes on tomorrow).

Thanks. Keep doing the good work.
[Android Software/Hacking General [Developers Only]] royal_eagle:
Using this methode and it works for me as well

Envoyé de mon SM-G900F en utilisant Tapatalk
[Android Software/Hacking General [Developers Only]] masterhuh:
3.5 & gfe 2.7.1.390

When I do a fresh install of GFE after enabling the new 3.5 I am seeing the application crash. Before it crashes GFE is asking SuperSU for root access (which I deny).

Is something broken? Or am I missing something.

Galaxy S5: SM-G900P

Android: 4.4.2

Thanks!
[Android Software/Hacking General [Developers Only]] Phantasm4489:
you need to allow the root access. This is actually my module asking for root access to be able to bypass the security checks. It will only do it once the first time you run a version of the good client (eg. once after install and once again after an update).
[Android Software/Hacking General [Developers Only]] cruise350:
Installed the 3.5 module and now Good just force closes with the unfortunately Good has stopped. Both on 2.6 and 2.7.1. Had to go back to the 3.3 module and install GFE 2.6 to get it to work with out force closing.
[Android Software/Hacking General [Developers Only]] masterhuh:
thanks. it is working perfectly now!
[Android Software/Hacking General [Developers Only]] Phantasm4489:
Please send over your xposed logs
[Android Software/Hacking General [Developers Only]] jonsharky:
I reverted back to 3.1. 3.5 causes Good to crash. 3.1 is working fine for me.
[Android Software/Hacking General [Developers Only]] 78Staff:
re the crashing with 2.7.1 and 3.5 - mine did the same thing the first time I started it... Well, actually if just kinda black screened and hung. I killed the app and tried again, but same result. So I went in and cleared it from SuperSU, and killed the task completely. I figured I would capture some logs, so cleared Xposed logs and fired up catlog, and started Good. And lo and behold it worked fine. Not sure if clearing/re-accepting root perms, or the aggressive task killing did it, but it's working fine now.
[Android Software/Hacking General [Developers Only]] sean.trinidade:
Working fine here

Thanks to the OP - everything's working fine here. For those of you yet to upgrade, I did the following:

1) Backed up existing version of GFE

2) Freeze GFE

3) Upgraded Xposed module to 3.5

4) Rebooted

5) Unfroze GFE + logged in (everything working fine at this point)

6) Upgraded via the Playstore

7) Logged into GFE again and everything still working fine

:)
[Android Software/Hacking General [Developers Only]] Surfinette:
These instructions worked great for me (coming from GFE 2.7.0 and the xposed patch v3.3)

@OP

May I suggest that you include the latest patch in the OP and that each time you release a new patch it is renamed with its version and the latest version of GFE it's been developped for. This would be more convenient, notably for users who don't follow this great thread on a daily basis...

In any cases, many many thanks for this great module: very useful for a workaholic (like me :( )
[Android Software/Hacking General [Developers Only]] pamulli:
I'm getting forced closes as well.

Coming from GFE 2.5.1.363 with the 3.1 Xposed Module I froze the app in TTB, updated the Xposed module, rebooted, defrosted GFE and then granted root and it immediately crashes. I tried clearing root from SuperSU and updated to the current GFE in the Play Store and it still just force closes. Getting a new PIN is a very painful process that takes about a week so any suggestions?

This is on an S4 running Stock 4.2

Thanks
[Android Software/Hacking General [Developers Only]] Surfinette:
Have you tried updating through the playstore despite the freeze?

Envoyé de mon Nexus 5 en utilisant Tapatalk
[Android Software/Hacking General [Developers Only]] 78Staff:
I get occasional FC's on the latest Good & patcher, but if I restart the app it works fine. I'll pull a log for the dev next time it happens...
[Android Software/Hacking General [Developers Only]] pamulli:
Yes as I noted in my post, I updated to the latest version through the play store and it still force closes. I also wasn't able to go back to my originally backed up version because for some reason it would not accept my password even though I'm 100% certain I'm entering it correctly. On the bright side, I can finally test out some other ROMs since GFE is now broken and I have no choice but to request a new pin which is what was keeping me from switching ROMs. I really hate this app.

Thanks
[Android Software/Hacking General [Developers Only]] crewzta:
Works as advertised, A++++ would download install again.
[Android Software/Hacking General [Developers Only]] El Ha$on:
Just as an FYI. Not sure if anyone else is affected by this although it doesn't affect functionality of gfe. Sometimes I realize the app is constantly restarting itself. For example it doesn't stay consistently connected even tho I have persistent mode checked off in preferences.

Only reason I noticed that is because I have gfe installed on a non rooted device and I never get that toast notification when I unlock gfe. Like I said doesn't bother me at all. Just figured I share...

Thanks for all the hardwork

Sent from my LG-VS980
[Android Software/Hacking General [Developers Only]] cruise350:
Still getting a force closed on good when trying 3.5. I stayed on good 2.6 and didn't update yet. Here is the log:

Loaded app: com.good.android.gfe

class found : g.ahp$aX

probable decryption method found : aK

installed hook for com.good.common.util.i->a method

installed hook for com.good.android.gfe.service.syncengine.jni.JNISyncEngine->a method

installed hook for com.good.android.security.malwaretest.d->c method

installed hook for com.good.android.security.malwaretest.d->toString method

installed hook for LogImpl->a method

installed hook for LogImpl->c method

installed hook for LogImpl->d method

installed hook for LogImpl->e method

installed hook for LogImpl->e (throwable) method

class found : com.good.android.compliance.ComplianceManagerPolicy

copylib returned true - proceeding with hooking

mapLibraryName hook installed

method call LogImpl->c intercepted null onCreate

method call LogImpl->e intercepted renamePrefsFiles rename failed due to perrmision access

method call LogImpl->e intercepted renamePrefsFiles rename failed due to perrmision access

method call LogImpl->e intercepted renamePrefsFiles rename failed due to perrmision access

mapLibraryName intercept gtgfendk

mapLibraryName intercept FipsCrypto

mapLibraryName intercept syncengineradio-lib
[Android Software/Hacking General [Developers Only]] jeevanreddy58:
It worked with fresh installation.

Installed latest xposed patch from xposed framework. Installed gfe 2.7 from play store.

Thanks,

Jeevan
[Android Software/Hacking General [Developers Only]] buda5767:
Run GFE 2.4.0.315 with 3.1 and CM11 ->ok

After update 3.5, root dedections. -> Nok (for update, i freeze GFE, no handling problem)

Back to 3.1 running without problems. ->OK

Never touch running system, please not update from 3.1 to 3.5 else have same installation.
[Android Software/Hacking General [Developers Only]] Zirillian:
Android 5.0

Anyone figured out a game-plan for updating to Android 5.0 but still keeping root AND GFE? Given 5.0 is on ART, making Xposed impossible (?), it sort of seems our days of root access + GFE have come to an end, if we want to update to it (I do!).