yashsingh1/xdaforums huggingface dataset:
[Sony Xperia T, TL, TX, V] ArdinCani:
Same here too

The landscape mode doesn't work anywhere... Even the camera app crashes :(
[Sony Xperia T, TL, TX, V] ArdinCani:
Now I experience and some random crashes from the wake and even XDA FC's but it is a very fluent ROM though

:/
[Sony Xperia T, TL, TX, V] casis86:
Which one did u use? I know this thing happend a few updates back. But in 241 it seems to be fixed. Iam still on it know. Just had a random crash got a bluescreen amd softreboot. Also few min after again a short time blue flash on the screen
[Sony Xperia T, TL, TX, V] casis86:
*update. My screen problems comes from widescreen also :D I recommand .235 its the most stable version yet. Whistle is the only problem there. So get this and wait for cm10.2 to get stable.
[Sony Xperia T, TL, TX, V] Imprezzion:
Well, since I never ever use speaker for calling anyway and AFAIK the whistle is only in-call right?

Its not when playing normal audio from say, a flash stream in MX Player?
[Sony Xperia T, TL, TX, V] casis86:
Yeah its just on calls, it happend since they pushed the volume level. Youtube, mx ect. Works fine. Just dont fastforward music to fast in apollo it crashes the mobile too :D
[Sony Xperia T, TL, TX, V] zilboris:
Hi, does anyone happen to have a proper copy of this ROM they can share? I've never cooked a ROM and am afraid of simply creating a zip that will brick my phone. Thanks.
[Sony Xperia T, TL, TX, V] jerpelea:
HAPPY NEW YEAR !

We are entering in 4-th year of FreeXperiaProject existence and from now build number will be FXP3XX

3 indicates year (we started from 0)

XX week﻿

FXP301 released!
[Sony Xperia T, TL, TX, V] jerpelea:
Our new website is up on http://freexperiaproject.net/

new FXP305 released

enjoy
[Sony Xperia T, TL, TX, V] Astralogic:
Could someone give me some slightly more verbose install steps please? The steps in the OP are brief to the point of being cryptic.
[Sony Xperia T, TL, TX, V] Astralogic:
Are these the same steps as posted here?
[Sony Xperia T, TL, TX, V] dyfk3l:
Exactly.
[Sony Xperia T, TL, TX, V] cmajetic:
AW: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

there is something wrong with nfc, you can turn it on (don't know if it works, have no other phone with nfc) but then it stays grayed out and you can't turn it off again, reboot doesn't help.

Some nightlies ago it worked so did I do something wrong? it was a clean install with a full wipe. can someone confirm this bug?

EDIT: sorry wrong thread, this happens with cm10

Gesendet von meinem Xperia T mit Tapatalk 2
[Sony Xperia T, TL, TX, V] Entropy512:
What was the last firmware you flashed before CM?

Looks like another PN544 upgrade/downgrade mess...
[Sony Xperia T, TL, TX, V] cmajetic:
AW: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

had some problems with a nightly, because of that I wanted to restore a backup of another cm10 nightly (but it failed, did not boot, seems that backup has also problems) I wiped and did a clean/new cm10 install.

seems that I have to revert to stock, full wipe and another cm10 install causes problems. and this is very annoying because we have to wipe internal storage every time too. so a clean cm10 install when coming from cm10 takes about an hour and needs pc?

Gesendet von meinem Xperia T mit Tapatalk 2
[Sony Xperia T, TL, TX, V] tilal6991:
Re: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

I can't enable NFC on mine either.
[Sony Xperia T, TL, TX, V] Melankolia:
When we can expect a full working camera?
[Sony Xperia T, TL, TX, V] kur41:
Re: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

That sounds like asking for ETA...
[Sony Xperia T, TL, TX, V] RagingHarry:
Hiya,

I saw yesterday that the SD card fixes and some other important stuff are merged on review.cyanogenmod.org and made myself a kang to see how it works, and it runs rather nice.

But when i wanted to access the interwebz this morning at work it failed on it :rolleyes: and when home i went looking on the KPN.com website what the APN settings should be to be able to connect to H+.

Name: KPN (kpn site says "Mobile Internet" but KPN works fine)

APN: was internet, must be portalmmm.nl

proxy: leave empty

port: leave emtpy

Username: must be empty and is not atm.

password: also must be emtpy but is set atm

Server: empty

MMSC: emtpy

MMS proxy: emtpy

MMS port: emtpy

MMC: 204

MNC: 08

Auth type: was emtpy, must be pap

APN type: default,supl (left it unchanged while kpn says default only)

rest also remains unchanged

http://www.kpn.com/prive/service/Mo...y/lt30p-xperia-t/internet/handmatig-instellen
[Sony Xperia T, TL, TX, V] Arcano:
Re: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

Pardon my question but ¿what is a "kang"?.

--

Enviado desde mi móvil.
[Sony Xperia T, TL, TX, V] RagingHarry:
Home build CM from the official repo's, so it includes the last updates/patches.
[Sony Xperia T, TL, TX, V] Arcano:
Re: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

Thank you, never heard of it, aside of in AOKP.

--

Enviado desde mi móvil.
[Sony Xperia T, TL, TX, V] Entropy512:
Might want to submit that to gerrit. :)

I'm not sure if it should be submitted as a change to the existing settings in apns-conf or as a new settings option...

Look at the mess for MCC/MNC 310/410 (AT&T) for example - due to various AT&T MVNOs and AT&T themselves having AT LEAST three valid APN configurations - there are 5-6 different APN settings options for AT&T...
[Sony Xperia T, TL, TX, V] matze1810:
I installed FXP205 yesterday and FXP206 today (incl. kernel and data wipes etc.) and on both roms my wlan mac address changes on every reboot. Is this a known behaviour? Is there a way to force the kernel to use the (real) mac address from wlan adapter?

Thanks in advance!

Mat
[Sony Xperia T, TL, TX, V] Dekudan:
Loads of good looking stuff has gone into review recently or has been merged. Are the problems slowly being figured out, Tilal?
[Sony Xperia T, TL, TX, V] schaggo:
AW: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

TiMiN8R has a fix for stock and/or stock-based ROMs. Dunno if it also works on AOSP/CM. It's a symlink which needs fixing to make the WLAN adaptor stick to the actual HW mac address.
[Sony Xperia T, TL, TX, V] tilal6991:
Basically. A lot of stuff has been fixed but RIL is broken. The cause of this is being investigated.
[Sony Xperia T, TL, TX, V] Entropy512:
Yeah, unfortunately this has been a crazy week for me so I won't be able to pitch in until the weekend. :(

Plus over on my old devices (galaxys2 family) we just did a major merge that broke a bunch of stuff so I have a bunch of stuff to fix over there too.
[Sony Xperia T, TL, TX, V] waleed794:
Can i install it on locked.bootloader ? Sorry if its a dumb ques cuz im new to xperia t
[Sony Xperia T, TL, TX, V] schaggo:
AW: {T}[DEVELOPMENT] - CM10.1 - FreeXperia Project

No.
[Sony Xperia T, TL, TX, V] Geo2160:
Before anybody starts asking, no, RIL hasn't been fixed yet. Also, the camera and internal audio output don't seem to work either. Don't know about the external output since I don't have any headphones handy.
[Sony Xperia T, TL, TX, V] tilal6991:
Sound should work - internal and external. RIL does not work as mentioned. Camera also doesn't work but significant progress has been made.
[Sony Xperia T, TL, TX, V] Vaizen:
OMG there's a surpriese in the changelog XD What is it, what is it?
[Sony Xperia T, TL, TX, V] jerpelea:
flash and see
[Sony Xperia T, TL, TX, V] Geo2160:
It's just a new boot animation. Also i think wi-fi has been partially fixed. It can now detect every wi-fi connection around except mine. I also have some weird crashes when I try to play anything through apollo.
[Sony Xperia T, TL, TX, V] DentTette:
Is the official CM repo on par with the fxp releases ?
[Sony Xperia T, TL, TX, V] championswimmer:
yes my friend

FXP team is the official maintainers of Xperias on CyanogenMod and they build out of the official trees only :)
[Sony Xperia T, TL, TX, V] DentTette:
Alright, they I can compile and have a look at the broken stuff on my own
[Sony Xperia T, TL, TX, V] Dekudan:
As a lazy person I ask...What's still broken?

(I assume camera)
[Sony Xperia T, TL, TX, V] lunarjetman1:
Is the discussion thread in the general section broken? ;)

Hit thanks if helped.

Cheers,

Lunar.

sent from my T.
[Sony Xperia T, TL, TX, V] DentTette:
My initial build is not booting, issues between FXP screen en CM loading screen.

Hopefully the next attempts will be better :)
[Sony Xperia T, TL, TX, V] Dekudan:
Oh, I went looking for it and couldn't find it. I've always found this thread more approachable....

But then again, found it instantly this time. Fun.
[Sony Xperia T, TL, TX, V] DentTette:
Yet again my home build fails to boot, helas it is at a place without debugging possibilities.

Stuck between the new FXP screen and the CM loading screen.

Anyone any hints ?
[Sony Xperia T, TL, TX, V] waynekirby:
Flash a stock FTF with flashtool :)
[Sony Xperia T, TL, TX, V] schaggo:
AW: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

Yeah, he sure needed that help... Not really, no. He is trying to get his kang booting.
[Sony Xperia T, TL, TX, V] Miustone:
Too high Volume

The Speaker Volume is Sh**! :( Simply wrong audio values?

Hoper for a fix in next FXP/CM Release...

Back to Stock 4.1.2 :/

Edit: its an reported issue...

Issue 1545 https://code.google.com/p/freexperia/issues/detail?can=2&start=0&num=100&q=&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary&groupby=&sort=&id=1545
[Sony Xperia T, TL, TX, V] DentTette:
Yes indeed; Problem is, I took all the blobs from FXP209 and RMP.bin from theMuppets repo. Then a did a clean build but it has the same reaction.

I'm really more of a radio guy (did some work on the LG P990 radio). So the sony is new to me so getting stuck there is a bit of a problem.
[Sony Xperia T, TL, TX, V] championswimmer:
is the radio broken on the latest build ??
[Sony Xperia T, TL, TX, V] DentTette:
On my device I get 'baseband unknown' since FXP208 (the ones with the new kernel)

That's why I wanted do build on my own
[Sony Xperia T, TL, TX, V] imugur:
Was RIL fixed?

Thanks,

Mugur

http://mugur-ionescu.ro/tag/xperia
[Sony Xperia T, TL, TX, V] tilal6991:
No.
[Sony Xperia T, TL, TX, V] Entropy512:
Still busted. From talking to both you and Kali, it sounds like it works on V but not on T, which is WEIRD.

I took some looks at it over the weekend - blob rild appears to crash (with no errors output to any log, but the radio logcat implies rild died and went away). Opensource rild (the current setup in the source tree) doesn't crash, but the RIL just keeps on going without detecting a SIM, and eventually just sitting with "RADIO_UNAVAILABLE". No obvious errors anywhere I can see that indicate *why*... THAT is the hard part that makes it difficult to narrow down the failure - I can't find the relevant errors.
[Sony Xperia T, TL, TX, V] DentTette:
Gotten my own kang to work at home and I saw the same thing. Still getting into the code and logs but it seems that it is indeed a tough nut to crack.

What would be the best road to go down blob or the opensource one ?
[Sony Xperia T, TL, TX, V] championswimmer:
and once you solve that you'll hit another roadblock that i face which is alsa cannot open device 'hw:0,2'

in effect that means no audio during call.

this though wont be such a tough nut to crack. have to check the AlsaDevice.cpp code again,

Kali- has a audio-caf tree in his github which is in line with a more recent caf branch, and though it makes audio playback better, it still does not solve this issue yet.

----------

EDIT:

regarding the ril issue again

btw compile the kernel at these commits

cb6f0bb624fb5bcb65c6dbe3f04e48b4c99a6aab

317390c0bb88dba055c8de81a88551ca7c6a29f6

and check once

the ril broke after one of these commits if what users say are true.

please have a check

(keep using opensource RILD)
[Sony Xperia T, TL, TX, V] DentTette:
Only had limited time this evening, this is where I found the first real error when comparing build FXP206 vs my own build:

FXP206 (last one with working RIL/MAKO kernel)

D/RILB ( 920): registerForRilConnected h=Handler (com.android.internal.telephony.PhoneProxy) {41b30da8} w=4

D/RILB ( 920): Notifying: ril connected mRilVersion=6

My build:

D/RILB ( 807): registerForRilConnected h=Handler (com.android.internal.telephony.PhoneProxy) {41067b68} w=4

D/RILB ( 807): Notifying mRilVersion is missing -1

where registerForRilConnected is from BaseCommands.java

(second message was put there by me, original fails without notification)
[Sony Xperia T, TL, TX, V] Entropy512:
That second commit isn't even in the cm-10.1 branch (looks like that's from the old mako kernel?)
[Sony Xperia T, TL, TX, V] championswimmer:
yep that's from the old mako kernel.

i had them noted down somewhere according to FXP releases.

btw DentTette's comment above is interesting to read. RIL version is missing. Is that something you already checked ??
[Sony Xperia T, TL, TX, V] DentTette:
It's not the RIL version that is missing (the error message was something I wrote to verify). It is the function that fails to register the RIL, it takes 3 arguments and the last one is an object and I think the object is empty.

It is the first actual error I found and i'm going to try to backtrack the issue from there.
[Sony Xperia T, TL, TX, V] championswimmer:
let's just get down to see if the problem is in kernel or userspace ...

the switch from mako kernel to sony kernel involved changes in kernel source, changes in props and changes in device configs too.

keeping the userspace config untouched we need to use the older kernel and check if RIL is ok, then we might narrow down the problem to kernel,
[Sony Xperia T, TL, TX, V] tilal6991:
Its interesting. Theres only a thin layer of radio stuff in the kernel. However, a dmesg shows errors to do with snd which are suspicious. Props are an obvious answer but tsubasa works. Same with device side. Unless there is a difference in the blobs.
[Sony Xperia T, TL, TX, V] tilal6991:
There's an issue with your suggestion - each of the changes is dependant on the change. I already tried what you suggested and it messed the system up. I suppose it could be worth another shot.
[Sony Xperia T, TL, TX, V] Melankolia:
somebody use this ROM for daily use? is it stable?
[Sony Xperia T, TL, TX, V] cmajetic:
AW: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

no, without ril you can't even phone someone or receive a call. unusable right now!

Gesendet von meinem LT30p mit Tapatalk 2
[Sony Xperia T, TL, TX, V] Entropy512:
That's the strangest thing, tsubasa working but mint not working... I have yet to see any obvious differences.

There were some differences in SMUX configuration in the defconfig, but I tried pulling those in and nothing changed. (I bet they could even be disabled on tsubasa with no ill effect - would be an interesting experiment.)
[Sony Xperia T, TL, TX, V] championswimmer:
will do that on monday

have the chemistry and quantum physics to cope with till then :)

is this present on mint build.prop

persist.radio.apm_sim_not_pwdn=1
[Sony Xperia T, TL, TX, V] Entropy512:
That's set in the blue-common repo. :(
[Sony Xperia T, TL, TX, V] championswimmer:
works fine on tsubasa without the SMUX defines :)

so no that is not it.

it's something else.
[Sony Xperia T, TL, TX, V] Entropy512:
I've spent most of the weekend digging in to this.

I used http://review.cyanogenmod.org/#/c/33982/ to crank up the debugging level.

After the modem boots, it opens up an RPCRPY_CNTL smd channel.

On CM10 and stock JB, and I am assuming also on tsubasa, as soon as this smd channel is opened up, there's a 52 byte packet ready for the apps processor. This appears to be a HELLO message for the IPC router stuff (ipc_router.c and such).

On CM10.1 on mint - the channel is opened up and nothing happens. It just sits there and does nothing. All of the other channels such as DATA5_CNTL are created as a result of comms on the RPCRPY_CNTL channel as far as I can tell.

dmesg logs are attached: CM10, 10.1, and a stock JB log taken by cdesai (it has less data since it's an earlier version of the "crank up the debug" patch)
[Sony Xperia T, TL, TX, V] championswimmer:
here's from the tsubasa (without the debug patch, so not much data, applying the debug patch and uploading in some time)

EDIT

I see there is a log already posted by a tsubasa user on the gerrit
[Sony Xperia T, TL, TX, V] codeworkx:
AW: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

pffff. i'm no "user", i'm cody!!!
[Sony Xperia T, TL, TX, V] schaggo:
AW: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

sorry, but :D :D :D

Gesendet von meinem C6603
[Sony Xperia T, TL, TX, V] Entropy512:
Finally made progress yesterday after rolling back the kernel to just after merging Sony .489 - at that point the modem worked but graphics (of course) didn't due to missing all of the graphics-related kernel patches for 4.2.

After doing a manual equivalent of git bisect, I finally found the patches responsible:

https://github.com/CyanogenMod/andr...mmit/5a318e64f41be7b08965817916a35b6edf4f23e2

and

https://github.com/CyanogenMod/andr...mmit/f106e38769dc1a7213a81c88dab37fa949e0e03f

which force-enabled it on our devices.

I reverted the second patch, modem on mint is now working, and it appears to not have negatively affected graphics. The first patch is still in, just not enabled in defconfig so if we need it we can investigate it again with more ease.

This is one of those bugs that is just NASTY to track down and is why ETAs are never given by CM... In many cases the root cause of a problem is NOT obvious.

Call audio is still broken on mint, I've heard it may be also broken on tsubasa (confirmation of this would be good), but at least data is working now.

GPS is busted, it needs to be de-makoified, I'll probably work on that this weekend.

Camera also needs to be de-makoified... After all of the rebasing camera is a total cluster****, but just doing some cleanup might fix it.
[Sony Xperia T, TL, TX, V] funiewski:
Sv: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

Call audio is indeed broken on tsubasa latest cm10.1, btw fxp206cm10.1 is working with fxp210 kernel(not tested with 211), call audio is broken since 207
[Sony Xperia T, TL, TX, V] Entropy512:
Unfortunately, the change of base from mako-base to .489 base has really screwed up a lot of things... once the churn settles down, things should be a bit better. :)
[Sony Xperia T, TL, TX, V] championswimmer:
though never expected to look into GPU to un-break modem, I knew going back stepwise on the commits in the kernel tree was the only way to get this done...

anyways time to do the happy dance because we have unbroken modem

audio remains

btw just swapping blob audio hal didn't do any good though.
[Sony Xperia T, TL, TX, V] tilal6991:
@Entropy

Wow. Amazing work. I'd given up hope that the problem would be solved in the near future. Awesome work.

That means I'm back onto CM10.1 as a daily. My holidays are almost here so I'll see if the audio issues can be solved.
[Sony Xperia T, TL, TX, V] Miustone:
Nice too see that so many Dev's/Cody's are involved:highfive: The Audio issue is the biggest bug for me :( I am a total music lover but the Speaker sound is a way too much for my ears :eek:

so why not on the T? :/

anyway thanks to all for your Great work!:o
[Sony Xperia T, TL, TX, V] r-l:
is this still a work in progress or is it finally a daily rom ??

What is broken en what works on cm10.1 ?
[Sony Xperia T, TL, TX, V] tilal6991:
Everything except in call audio, HDMI out and camera basically works now. GPS is on Gerrit for fixing but is a WIP. Also I've observed freezes ocassionally in super hexagon. That's about it I think. I'm using it as a daily now since i don't call very much.
[Sony Xperia T, TL, TX, V] r-l:
Still to much broken :( i gonna wait a little bit longer then because i need a 100% working phone for work :)
[Sony Xperia T, TL, TX, V] codeworkx:
AW: {T}[DEVELOPMENT] - CM10.1 - Android 4.2.2 - FreeXperia Project

can you tell me about all audio bugs you're having? might have a look at it this week.
[Sony Xperia T, TL, TX, V] Miustone:
UUUUH *-* :victory: Alright...

First Soundtest, after flashing cm10.1 with Ringtones... @Full Volume Speaker is a lot too loud,and the sound is not clean,very aggressive and sounds as if he would killing the speaker:silly:

Second Soundtest,i play my music from my internal sd,i start play the musik,push volume to maximum and again dirty,very to loud speaker:(

i have this issues on all 4.1.2 AOSP/CM/FXPCM/AOKP/PA/Jelly Bam and 4.2.2 Roms :crying:

@Stock ICS,JB from Sony is the sound AWESOME... No Problems @Maximum loudness:good:

Again the Changelog:

i think its still here not fixed on the Xperia T...

Sorry for my English:silly:

hopefully it's enough:laugh:

:D :D :D :D hahaha
[Sony Xperia T, TL, TX, V] DentTette:
The most important audio problem is the lack of in call audio; This is present on the blue platform.

For the rest there is too much loudness as mentioned in the post above, and headphones are not detected/working.
[Sony Xperia T, TL, TX, V] Entropy512:
I believe Kali merged blob GPS last night (edit: nope). Longterm goal is of course opensource GPS, but for the time being the blobs are working.

I had a LOT of stability issues last night, but could be something weird with just my device or build setup.

I think it's that one of the volumes appears to be running a little too high, leading to distortion. Not sure if it's the speaker being overdriven, or something earlier in the signal chain clipping.

There's of course the call audio thing.
[Sony Xperia T, TL, TX, V] tilal6991:
I just got a kernel panic due to the slub allocator. I think that may be the root of quite a few stability issues. Is slab a better choice?
[Sony Xperia T, TL, TX, V] Miustone:
any progress btw. Audio?

and another question:

Is it inculded in FXP213 ?:silly: (have tested it on my One X with PA3+) its Perfect for Devices like Nexus/Xperia:highfive:

cheers:cowboy:
[Sony Xperia T, TL, TX, V] tilal6991:
No real progress made. All the devs are pretty busy atm i think.

I don't think PIE is included although it will deffo be in the next release.
[Sony Xperia T, TL, TX, V] Miustone:
hmm all right:crying: thanks for your answer:highfive:

Cheers:cowboy:
[Sony Xperia T, TL, TX, V] Alex Slane:
Can't wait till this becomes a daily looking forward to 4.2 goodness !
[Sony Xperia T, TL, TX, V] Miustone:
:highfive::fingers-crossed::good:Very nice! i come back to CM with FXP214:D

Thanks:cowboy:
[Sony Xperia T, TL, TX, V] tilal6991:
Just submitted patches to fix in call audio.

This is the device one.

http://review.cyanogenmod.org/34867

Hopefully will be submitted in time for the next FXP build.
[Sony Xperia T, TL, TX, V] funiewski:
Thx for your work, does it means headphone jack is fixed too?
[Sony Xperia T, TL, TX, V] tilal6991:
Nope but I'm testing a fix for that as well. Hopefully my test will work and I can isolate and push a patch for that as well.

Edit: It fixes all audio. And it fixes the freeezes I've been experiencing as well. So isolation of the fix and pushing to gerrit to go.

Basically only 2 things left to fix - HDMI out and camera.
[Sony Xperia T, TL, TX, V] waleed794:
Pardon me. Can anyone give me a brief note on what is working and what is not working. I know you guys hate this question but I don't have enough time to read all pages of this thread
[Sony Xperia T, TL, TX, V] tilal6991:
Ummm. Try the post above you?
[Sony Xperia T, TL, TX, V] waleed794:
es camera , wifi, Bluetooth etc works? Can i recieve msgs and, calls.
[Sony Xperia T, TL, TX, V] Geo2160:
The amount of spam here is unbelievable for a development thread.
[Sony Xperia T, TL, TX, V] gregbradley:
I have told you in other threads to read the changlog. google it. its not hard to find. and its daft post like yours (and my repsponse to it) that make it hard fo others to find the changelog...please read, please search, please use PM, please use common sense, please stop spamming
[Sony Xperia T, TL, TX, V] Miustone:
Sorry for OT but.... AWESOME:highfive: you'r the best:D that changes everything for me:fingers-crossed:

you're my man!!!!

Last OT from me! really!:good: