yashsingh1/xdaforums huggingface dataset:
[Galaxy S II General] tryptophane:
Hey, I have some progress to report :) After having set up eclipse for cm development, I applied yout latest 2 patches (v5 and the flash patch). Good news! The EXIF isn't corrupted anymore, so you've done right by changing the data types :cool:

GPS-data seems not to be recorded correctly though. Here is the output of the linux command exiv2 for the GPS tags (sorry my locale is german):

Exif.Image.GPSTag Long 1 574

Exif.GPSInfo.GPSVersionID Byte 4 2.2.0.0

Exif.GPSInfo.GPSLatitudeRef Ascii 2 Norden

Exif.GPSInfo.GPSLatitude Rational 3 48deg

Exif.GPSInfo.GPSLongitudeRef Ascii 2 Osten

Exif.GPSInfo.GPSLongitude Rational 3 7deg

Exif.GPSInfo.GPSAltitudeRef Byte 1 Unter dem Meeresspiegel

Exif.GPSInfo.GPSAltitude Rational 1 0 m

Exif.GPSInfo.GPSTimeStamp Rational 3 13:06:53

Exif.GPSInfo.GPSDateStamp Ascii 11 2013:05:04

As you can see, the latitude and longitude values miss the decimal places. On older picures, before the exif became corrupted, coordninates looked like that (this was in Malaysia, wish I could still be there ;) ):

Exif.GPSInfo.GPSLatitude Rational 3 2.1930212deg

Exif.GPSInfo.GPSLongitude Rational 3 102.2544545deg

other good news : Flash usage is correctly recorded, even in automatic mode :)

For the other values like iso, I can't say for sure, but seems to be ok.

Many thanks for your work!

---------- Post added at 03:47 PM ---------- Previous post was at 03:44 PM ----------

Thank you codeworkx, I will have a look at it.
[Galaxy S II General] ghepeu:
Thank you, I'll look at that as soon as the patches work as expected.

Good, that's something at least, i'll check how the shutter/exposure/GPS values are generated.

I fixed a couple of minor issues (I wasn't using the most up-to-date repository for exynos_camera) and another possible issue with the "Orientation" tag, now I'm compiling cyanogen so I'll be able to do some tests here and speed up things a bit. I'll attach the latest versions of the patches as soon as possible.

I think those files are shared with other samsung devices, we should probably test with those too.
[Galaxy S II General] seannn43:
Can I get a small user feedback on the latest nightly?

-How smooth?

-A few issues that are annoying/hard to live with.

Thank You :)
[Galaxy S II General] tryptophane:
The files are in the galaxys2-common folder, so I don't think they are shared with other devices... Maybe I'm wrong here...

I'm also having a look at the way the GPS values are generated, I think the problem is in the function exynos_exif_attributes_create_gps()
[Galaxy S II General] jackryder:
i have just rooted with Jeboo Kernel v1.2 does that mean
[Galaxy S II General] ghepeu:
Yeah, it's rounding to degrees and dropping decimals. Can you try the attached patch (still building cyanogen here :()?

Also, if you have old pictures can you see if the Exposure Time and Shutter Speed values were different from what you're getting now? Thanks!
[Galaxy S II General] tryptophane:
You are the king! It works now, you only forgot one 0 in:

exif_attributes->gps_latitude[0].den = 10000000;

and

exif_attributes->gps_longitude[0].den = 10000000;

Perfect. I was almost trying the same thing, but I didn't understand what was expected for the .den values. How did you find it out? I couldn't find where exif_attribute_t is implemented...

I looked for Exposure Time and Shutter Speed values in an old picture and it seems there's still an error:

old:

Exif.Photo.ExposureTime Rational 1 1/204 s

Exif.Photo.ShutterSpeedValue SRational 1 1/204 s

new:

Exif.Photo.ExposureTime Rational 1 1/0 s

Exif.Photo.ShutterSpeedValue SRational 1 1 s

I'm shure you will fix it too ;)

Oh yes, I forgot to mention that you had a typo in your first patch: LOGE instead of ALOGE.

I will leave to a friends birthday-party in one hour, so I will not be able to help you further today...
[Galaxy S II General] twped:
When I click on the change log in cm for latest build 0504 it says something like:

"This is the first cyanogen mod build of this type for i9100"

What does that mean.some kind of special build?
[Galaxy S II General] szymko1995:
Where do you see it?
[Galaxy S II General] Hasi Popasi:
I think that means that there was no change at all in this build...

Gesendet von meinem Nexus 10 mit Tapatalk 2
[Galaxy S II General] killar_aka_arabu:
settings-about-cm update-refresh- tap on 20130505-cm.......
[Galaxy S II General] szymko1995:
I'm using neat rom, so can't check.

I'll wait for codeworkx to confirm.

Wysłane z mojego GT-I9100
[Galaxy S II General] ghepeu:
Took it most of the day to compile but when I got home my self-compiled cyanogenmod was ready so i did some tests. I submitted to gerrit (http://review.cyanogenmod.org/36978) the patches that works already (fields size, flash, gps) because having those in would be a nice improvement by itself.

ShutterSpeed and ExposureTime don't work though, and I can't see anything wrong in the code, it seems the value we're getting from the camera is not good. I'll look at it tomorrow, if i have some time.

PS. The EXIF defines are in hardware/samsung/exynos4/hal/include/Exif.h, the camera defines are in /hardware/samsung/exynos4/hal/include/videodev2_exynos_camera.h
[Galaxy S II General] 70x7:
Same message here in last nightly. Other nightlies has normal changelog.
[Galaxy S II General] bland.life:
Anyone tried Google Goggles on the latest nightly?

I got this for any picture I take with Goggles:

http://i.imgur.com/d6nrVkl.png

Other camera apps like Barcode Scanner, CameraZoom FX and stock Camera all work fine though.
[Galaxy S II General] Skully☺:
Disable the unwanted launchers using System Tweaks.

I can connect to the 5GHz band, but connection strength is weak, since the modem is not close by. The 2,4GHz band has a much more stable connection and therefore a higher data rate in my house.

Use WiFi analyzer to check the signal.

The S4 octa is the Exynos version. It has two quad cores that don't operate simultaneously. See http://en.wikipedia.org/wiki/Samsung_Galaxy_S4.
[Galaxy S II General] ycode:
Yeah Goggles seems to be the problem. It got updated recently, so it is likely an issue of Goggles.
[Galaxy S II General] kokesh:
I also have broken image in Goggles.
[Galaxy S II General] HjasToneC:
What kernel would go well with this rom?? I'm all about battery life.
[Galaxy S II General] meviox:
Stock CM kernel.
[Galaxy S II General] tryptophane:
Yes it takes very long the first time, subsequent builds (for example after a repo sync) are much faster, as only modified sources are compiled and all the java stuff.

After working on the sources, you only need to do a mm in the respective source folder to build the modified module. After this you can push the library to your device with adb. But for sure you knew this already...

I didn't manage to push the lib into /system/lib/hw directly with adb, even after remounting /system with rw permissions and doing adb root, it always said "no permission". I have to push it to Main Storage and copy it into /system/lib/hw with the file manager. Maybe someone can give me a hint what I'm doing false?

Weather's too good today here in south germany for hacking ;)

Thank you very much, I missed this!
[Galaxy S II General] tmrasdf:
guys i'm having strange issue no music or picture is showing in gallery media scanner is hogging cpu eating too much battery and my phone heating like hell it happened on april 22 april 30 may 4 nightly everytime i install nightly i use romnuke script but no change but it's okay on stock based rom i've searched and wasn't able to find the solution how to fix this ? sorry for my english

Sent from my GT-I9100
[Galaxy S II General] Karpfenhai:
Try to push it while in recovery, should work then.

Tapatalked from my Galaxy SII
[Galaxy S II General] raphaellmattozo:
You can also see the changelog at http://mobile.10.1.cmxlog.com/?device=i9100#cm-10.1-20130423-NIGHTLY-i9100.zip
[Galaxy S II General] Icewind:
Change the governor in Settings - Performance from "ondemand" which is very powerful to "conservative" or even "powersave" which is really slow but you can run on battery like 3 days :) I used to use dorinmax kernel but last versions are not working properly with last CM builds. However in the old days it was very battery friendly.
[Galaxy S II General] amifiq:
What I realized in this ROM, when we set a custom ringtone, it won't repeat. It rings once, and just that. Anyone facing these?
[Galaxy S II General] FredC94:
http://xdaforums.com/showthread.php?t=731978

Not sent from an iOS#!t device
[Galaxy S II General] pimser:
non of you facing this?
[Galaxy S II General] snalfio:
I'm facing this. but i don't think that is a rom related problem
[Galaxy S II General] Pradeep:
I am unable to edit photos taken through camera using apps such as Snapseed.

Is this related to the camera EXIF data bug??
[Galaxy S II General] Darius_bd:
yes
[Galaxy S II General] ghepeu:
My patch was merged yesterday, it should be in the next nightly. Not everything works but the EXIF data shouldn't be malformed anymore.
[Galaxy S II General] tryptophane:
Hi Ghepeu, for me this lines in the function exynos_exif_attributes_create_params() look false:

exif_attributes->shutter_speed.num = 1;

exif_attributes->shutter_speed.den = shutter_speed;

and

exif_attributes->exposure_time.num = 1;

exif_attributes->exposure_time.den = exposure_time;

I would guess that the .num and .den values are inverted, don't you think so? I will have a closer look at it this evening, being at work now... Or did you already debug to see what values are stored in the variables shutter_speed and exposure_time?
[Galaxy S II General] Pradeep:
Thank you, waiting for the next nightly :D
[Galaxy S II General] ghepeu:
I'm getting 0 from the camera for both requests, but I'm not sure of which version of camera.smdk4210.so I'm using right now. I'm at work too so I can't check, this evening I hope I'll have some free time to install the latest version of the file.

The .num and .den values could be right or wrong, it depends on what the camera gives back when we ask for V4L2_CID_CAMERA_EXIF_TV and V4L2_CID_CAMERA_EXIF_EXPTIME, but until we get a useful value (that is, no '0') we can't tell.. :/
[Galaxy S II General] thachphongphong:
i had a issue with build 0422 and still happened on 0503.
[Galaxy S II General] Karpfenhai:
Just clear cache and data from keyboard and dictionary...

Tapatalked from my Galaxy SII
[Galaxy S II General] thachphongphong:
I did that many times but still happening
[Galaxy S II General] nikola87:
Hi are there any news on the Real Racing 3?
[Galaxy S II General] tryptophane:
Maybe a noob question, but still learning about basic cm concepts: how do updated proprietary blobs come to our devices? I know they are not in the GIT repo, because we have to pull them from our device after downloading the git sources. But they get updated from time to time, we can see it in the changelogs. How does this work?

For the two missing exif values: if the camera does not give back the correct values, then we have no chance at all. Damn Samsung! But I guess that most users don't care about these (I don't...), it would only be nice for the sake of completeness...
[Galaxy S II General] Pradeep:
Try doing a clean install...... wipe data/factory reset first and then install the latest nightly!!
[Galaxy S II General] dredremon:
anyone recommended replacing camera for this one??
[Galaxy S II General] Karpfenhai:
Q: the patched camera can be extracted and replaced from next nightly to work (the apk) or do I need to flash the whole Rom?

Thx for answering.

Tapatalked from my Galaxy SII
[Galaxy S II General] stone_ship:
I'm pretty sure it would NOT work. If it were the Camera only, then the changes would be in packages/apps/Camera. I think this is getting built into camera.smdk4210.so, but I'm not really sure. I would flash the whole ROM.
[Galaxy S II General] ghepeu:
Replacing the old /system/lib/hw/camera.smdk4210.so with the one from the new nightly and rebooting the phone should be enough.
[Galaxy S II General] readon1:
Do other also have problems with the gps? I can't get a lock on..
[Galaxy S II General] lerkin:
No, works great on latest nightly.
[Galaxy S II General] Debadatta:
Use FasterFix app from Play Store.
[Galaxy S II General] asturnauta:
What apps are you removing?

I want to remove unneeded apps (like apollo.apk, emayl2.apk....) but i would like to know what apk's i can safely remove.

Thanks.
[Galaxy S II General] Kc_Nirvana:
There is gonna be a nightly today?
[Galaxy S II General] Verna KDM:
I put an mp3 file in ringtones folder (sdcard0/ringtones) and went to settings/sound and selected media storage option, all my previous ringtones was there but not the new one.

I rebooted the phone but still media scaner doesnt catch it.

This happens only with ringtones, alarms and notifications.

With pictures media scanner works fine.

Im on 4may nightly.

Is this normal?
[Galaxy S II General] gazdajezda:
Hopefully it will :) Now, it is great rom, snappy fast ndrozilla :) Just one more feature to be merged (external gps) and 16:9 camera glitch to be patched and this is IT :) Also there is no more problems with sensors (orientation), best rom ever for me for S2 ;)
[Galaxy S II General] nextrow:
Like the battery a lot!

Verstuurd van mijn GT-I9100 met Tapatalk
[Galaxy S II General] gar_nould:
What CWM release for CM10.1 (night build) / 4.2.2 / GT-i9100[p]

Hello to everyone,

I just installed a CM10.1 (10.1-20130504-NIGHTLY-i9100) on my Galaxy S2 (GT-i9100P) which runs absolutely perfectly.

After the full wipe, CWM (previously installed for a 4.0.3) disappeared. After reading a lot of forums and posts, I was unable to find what release of CWM I should install now to backup current version and install future nighlty builds of CM 10.1?

I do not enjoy the idea of installing ROM Manager because it requires "Google Account access". Would you know what CWM I should install ?

__Huge__ thanks to all of you that make possible to leave operators ROMs !!!!

Regards,

G.
[Galaxy S II General] Bryanvdst:
-Removed-
[Galaxy S II General] Muchoaliento:
Dude, extweaks is for Siyah kernel or similar, custom, ask in its appropiate forum
[Galaxy S II General] SimboXXX:
You don't have to install anything, you have it already. Boot into cwm using Power Menu or with hardware keys combo.
[Galaxy S II General] tofrost:
i had the 03.05 nightly for the last days running and my S2 crahsed regulary into "kernel panic" mode. Also, sometimes the screen just went black and the phone was running hot... with the nighly from a few days earlier, i had no problems at all.

I am going to flash the latest, hopefully that removes these crashes...
[Galaxy S II General] szymgio:
I want to use SwiftKey but I can't because after short time AOSP keyboard sets itself like default. Is it because of nightly 0504?
[Galaxy S II General] SimboXXX:
Set it as default in Language & input, and if that doesn't stay default then freeze the AOSP keyboard with Titanium.
[Galaxy S II General] sl1p1990:
Has anyone seen this? :D CM team surely has sense of humour ;D
[Galaxy S II General] Fusionalex:
I got a really big problem! After some time without internet my phone starts to get really hot and laggy and only turning on internet helps! How can I find out whats causing this? PLEASE help me!!

EDIT: I'm using Apex Launcher btw but it also happened with Holo :/
[Galaxy S II General] szymgio:
I'm afraid it doesn't work, after freeze AOSP keyboard in TB i can't choose any input method.
[Galaxy S II General] Bryanvdst:
And just disabling the AOSP keyboard in the keyboard selection menu? Or am I just thinking too simple?

I've been using Swiftkey without any issues, so it's not because of nightly 0504..
[Galaxy S II General] szymko1995:
What is this? http://review.cyanogenmod.org/#/c/36994/
[Galaxy S II General] Fusionalex:
Hellpp pleaase
[Galaxy S II General] szymgio:
Of course, I disabled AOSP keyboard, enabled SwiftKey and after freezing AOSP, I can't see keyboard icon on statusbar...
[Galaxy S II General] superlik:
Voice typing show force close.. anything related to voice

Samsung galaxy s2 I9100, Cyanogenmod 10.1 latest nightly, stock kernel, crystal 2 theme
[Galaxy S II General] SimboXXX:
Do you have the selector notification enabled in Language settings? Or maybe use the Quick panel ime tile to access keyboard input.

---------- Post added at 11:35 PM ---------- Previous post was at 11:33 PM ----------

Don't post twice in half an hour.

What have you done to try and fix? A reboot yet?
[Galaxy S II General] szymgio:
Try to update google apps by Play store.

---------- Post added at 11:40 PM ---------- Previous post was at 11:35 PM ----------

I'm not as stupid as you think :P Reebot, clear cache, dalvik, enabled selector, everything. Ok, thanks, I will fix it somehow.
[Galaxy S II General] 70x7:
Take it easy, cowboy! Try disable media scanner https://play.google.com/store/apps/details?id=com.addz.mediascannerroot or flash previous nightly. You can also wipe cache partition, dalvik cache and fix permissions in recovery.

If you want support, please, give more information about your settings.
[Galaxy S II General] SimboXXX:
Didn't say you were stupid, but how is anyone supposed to guess what action you've already taken?
[Galaxy S II General] superlik:
Ignore this

Samsung galaxy s2 I9100, Cyanogenmod 10.1 latest nightly, stock kernel, crystal 2 theme
[Galaxy S II General] thachphongphong:
just do that. and everything is ok. thanks
[Galaxy S II General] Fusionalex:
Sorryyy

I obviously rebooted already and it didn't work. Also I had this problem for some time already but I really think it's a problem with an app cause with internet its gone immediatly! So is there a way to look what is using so much cpu?
[Galaxy S II General] lerkin:
Do you use legally bought version from market, cause I use that keyboard without any issues.
[Galaxy S II General] albertoeskape81:
It's been the same for me here with the same nightly, and I'm really dissapointed because I don't know what to do, nothing works.
[Galaxy S II General] snalfio:
reboot your phone
[Galaxy S II General] szymgio:
Sorry it wasn't seriously. Thanks for your answers. :thumbup:
[Galaxy S II General] snalfio:
voice shutter continues to not work :(
[Galaxy S II General] beggar23:
Happens with 04.05 as well. Quite annoying.
[Galaxy S II General] Bryanvdst:
Have to say that for me the 0504 nightly has been running great, very smooth and nothing out of the ordinary.
[Galaxy S II General] galaxyII:
+1 & batter seems to be really great
[Galaxy S II General] jun1662:
Latest nightly 0504 has been running smooth no issues whatsoever for a few days now. Also noticed that the Baseband version has been changed, now XXMS2, and am not sure but seems the kernel has been updated too.
[Galaxy S II General] traketto:
Are you sure? In 0504 nightly I still have XXLS8 baseband.
[Galaxy S II General] Panayiotis:
Give us link please
[Galaxy S II General] SimboXXX:
There are no modems included in the cm zips. He probably flashed a stock-based rom before and didn't realise the baseband had changed.
[Galaxy S II General] tryptophane:
Spent a few hours yesterday trying to resolve this issue, but didn't really succed. For the exposure time, I always get 0, tracked it down till kernel level and ioctl commands, nothing seems to be wrong on the way. For shutter speed, I get values like 405, 505..., with increasing values with more light. But I don't know what to do with this values. Tried some operations on them like in the file SecCamera.cpp, but could not get reasonable values. I don't have more ideas...

This is what is written in the EXIF Specs for shutter speed:

0x9201	ShutterSpeedValue	signed rational	1	Shutter speed. To convert this value to ordinary 'Shutter Speed'; calculate this value's power of 2, then reciprocal. For example, if value is '4', shutter speed is 1/(2^4)=1/16 second.

Can't put it in relation to values like 505...
[Galaxy S II General] Kc_Nirvana:
Hi...

No nightly today either?

There are very good changes for the next nightly...

:D
[Galaxy S II General] beggar23:
Could be, that it's only the first character that is important. Like

4

05 is shutter speed 1/16 and

5

05 is 1/32. No idea what suffix 05 is then.
[Galaxy S II General] tryptophane:
My example values where maybe not well chosen, I also get 564 for example... But the idea was good ;)
[Galaxy S II General] ghepeu:
I replaced camera.smdk4210.so on my phone and i'm getting different values too. That's good, we just need to know how to use them now!

If anyone here has photos taken with the old camera, can you see what values you had on that field and post some here? We need to know what are the sane values to figure out how to generate them.

---------- Post added at 01:21 PM ---------- Previous post was at 01:16 PM ----------

Yeah, for example taking a picture under my desk, one pointing toward the light fixtures and another one toward a window I just got 405, 505 and 893.

PS. how long will i be a "new user"? the 5 minutes restriction is slightly annoying
[Galaxy S II General] beggar23:
Haha, cheers mate! :cool:
[Galaxy S II General] lecteur:
Jenkins is working..22 Minutes left :D
[Galaxy S II General] Coirpre:
If I remember correctly, its something like 50 or 60 posts? I would ask a Mod to see if he can do anyting about that... BTW, Thanks for the hard work, it is interesting to see the work process and progress of you two...
[Galaxy S II General] stone_ship:
I'd like to help and am still running CM10 with proprietary camera. How to get the values you are looking at? Just tell me what commands...
[Galaxy S II General] beggar23:
Let me stick with it for a while. Seriously, lets take the first character as shutter speed value, it fits well with the formula. But which purpose might the other numbers have? Can someone have a look which other numbers occur, do they appear like random numbers or rather have re-occurring values?
[Galaxy S II General] Fusionalex:
What keyboard?!
[Galaxy S II General] lerkin:
Swiftkey
[Galaxy S II General] beggar23:
bump. (sorry!)
[Galaxy S II General] Coirpre:
I don't think 10 min is an acceptable timeframe to expect a forum response...

[MENTION=5038583]tryptophane[/MENTION], [MENTION=5247306]ghepeu[/MENTION] [MENTION=2734517]beggar23[/MENTION]: would a dev thread be a good idea, seeing that everyone including me interrupts your discussions?
[Galaxy S II General] beggar23:
Agreed. I was just afraid that this specific discussion would be kinda interrupted by the page change.

Sure.
[Galaxy S II General] tryptophane:
Difficult to spend all my time in the forum while at work if I want to keep my job ;)

I agree, and this technical stuff is maybe not interesting for everyone who follows this thread. I started a new thread here in the Galaxy S II General forum with title [DEV] CM 10.1 EXIF bug discussion Thread
[Galaxy S II General] rockambole:
is there a default modem? or it depends on country/carrier/model?
[Galaxy S II General] tryptophane:
danke Karpfenhai, but I found out the easiest solution yesterday: if I build my changes with mmp instead of mm, then the newly build module gets automagically pushed into the right folder onto my device, don't even need to remount my /system partition. I should have read the wiki more carefully at first :)
[Galaxy S II General] Fusionalex:
But i didnt talk bout a keyboard
[Galaxy S II General] Bryanvdst:
I think he intended to reply to Szymgio's question about Swiftkey but quoted you instead...
[Galaxy S II General] SimboXXX:
Exactly.
[Galaxy S II General] MorpheousMarty:
default? Not really, but LS8 is pretty standard, and the latest official rom modem is always worth a shot. However, your specific carrier/country may work best with another modem. We should all have the same model here, the GT-I9100. The SGSII is one of the most common devices in the world, if you google something like i9100 [your carrier] [your city or a nearby major city] best modem, you might find some good suggestions on what will work for you.

Oh, and of course, the modem in the latest official ROM for your carrier is definitely one of the first you should try.