yashsingh1/xdaforums huggingface dataset:
[Galaxy Tab 2 Q&A, Help & Troubleshooting] ahmadhefny:
i upgrade my gt p5100 to jelly bean 4.1.2 >>>>>but i found aproblem with mobile data connection that's not working yet.....can i find any help or solve for this trip.....thnx alot
[Galaxy S II Android Development] geekynoob:
Another awwsome mod by Mirko.!! Always grt to hv you arnd mate :) :good:
[Galaxy S II Android Development] tdunham:
Hi Mirko.

In your file you have this code. In the stock file I am comparing to and the PhoneWindowManager$KillConcept.smali file does not exist either. Is this part new code and new file?:

.line 3674
new-instance v0, Lcom/android/internal/policy/impl/PhoneWindowManager$KillConcept;

invoke-direct {v0, p0}, Lcom/android/internal/policy/impl/PhoneWindowManager$KillConcept;-><init>(Lcom/android/internal/policy/impl/PhoneWindowManager;)V

iput-object v0, p0, Lcom/android/internal/policy/impl/PhoneWindowManager;->mBackLongPress:Ljava/lang/Runnable;
[Galaxy S II Android Development] Mirko ddd:
i don t understand, are we talking about backto kill or volume rocker?
[Galaxy S II Android Development] tdunham:
This is for Volume Rocker. I do not have those lines or (Killconcept file) in my code. I also download this: i9100_XWLPX_Deodexed_signed.zip hoping to have stock android.policy.jar for comparison and is does not exist there either. So I thought I would ask. :)

Edit: I feel foolish, you put code on Github that included code for back to kill mod. I should have noticed. You may want to remove that code to prevent confusion. ;)
[Galaxy S II Android Development] Mirko ddd:
mate.. kill concept smali has nothing to do with volume rocker
[Galaxy S II Android Development] tdunham:
Yes, no problem. I found out as soon as I posted. Thanks.
[Galaxy S II Android Development] Mirko ddd:
lol :silly:
[Galaxy S II Android Development] ICS_XD:
MirkO You Are Really Great :)
[Galaxy S II Android Development] Mirko ddd:
updated to LSJ
[Galaxy S II Android Development] Mirko ddd:
reupdated
[Galaxy S II Android Development] LegendK95:
Nice work :)

One thing tho, a fast look and seems like you have a field missing:

.field mVolumeDownPress:Ljava/lang/Runnable;
[Galaxy S II Android Development] Mirko ddd:
lol is there, but it s not highlighted well, damn txt editor!
[Galaxy S II Android Development] mysterio619:
can u make it for odexed one please thanks :)
[Galaxy S II Android Development] MyLifeRocks10:
Thanks mate for the guide, gonna try it tomorrow.
[Galaxy S II Android Development] Mirko ddd:
yoshi :D it s easy to implement, later this week i ll try to improve it.
[Galaxy S II Android Development] MySeLfPT:
I am sorry for my ignorance. But what is this supposed to do?
[Galaxy S II Android Development] Mirko ddd:
Mmh, in OP there s a zip to flash on LSJ jelly bean deodexed rom to get skip songs while screen is off.

And there s a tutorial too to help rom developers to include this feature into their own roms.

Hope u understand now :D
[Galaxy S II Android Development] fusionjack:
Mirko, during screen-off single press skips the song instead changing the volume, what did I wrong? :eek:

Btw, I think the "goto_6" doesn't need to be changed to "goto_c".
[Galaxy S II Android Development] Mirko ddd:
Nothing wrong mate, for the moment i implemented only the skip songs when screen is off.

I ll be updating the code cuz in this 4.1.2 didn t work the past code.

If u look for 4.0.4 code check out my github
[Galaxy S II Android Development] Ciervo_anonimo:
Mirko can you fix it?

This mod can be disabled?. Thx
[Galaxy S II Android Development] Mirko ddd:
Ooops i forgot to update this thread. In my rom is fixed, tomorrow i ll update it. Thanks for reminding

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] Mirko ddd:
updated code to LSJ, fixed :D
[Galaxy S II Android Development] Ciervo_anonimo:
Thx Crack ;)
[Galaxy S II Android Development] Mirko ddd:
Lol so htcmania friends won t point the finger at me because of their broken volume rocker mod xD say them to come give some thanks now :)

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] Ciervo_anonimo:
Ja ja ja jaja you're always welcome there. You know ;)
[Galaxy S II Android Development] prabu33:
hi everyone. how to use the volume rocker?? until now I am still confused to use it and how. thanks everyone told me :)
[Galaxy S II Android Development] mtxx1:
Dear Mirko, how do i use this mod?

i downloaded the .rar file you have, its not a flashable zip?

can you make a flashable zip for it? or make explain how to use your mod?

i'm not a programmer, i dont understand the codes you write in the first page

many thanks
[Galaxy S II Android Development] Mirko ddd:
Lol .rar archive contain 2subclasses needed to finish the mod. Thread is to help developer do it for their roms.

I didn t make a zip because the mod involves android.policy.jar and would erase other mods related to it, so people will ask for backups or other mods.. and i m not santa klaus. Ask to your rom developer to implement or flash my rom ;)

Cheers

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] mtxx1:
oh i see, thank you so much for your explanation :) now i understand

i am actually halfway download your rom, called disaster rom right? (weird name, but oh well, its the content that counts)

but the speed so slow, already one hour +, about 70% complete only, i'm used to downloading aosp rom that are 150MB+, man samsung roms are big, lol...just talking nonsense here.

thanks again.
[Galaxy S II Android Development] Mirko ddd:
Yup disaster :) it s a long story..

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] fusionjack:
@Mirko: Thanks for the update! :)

I'm trying to implemented your mod into MIUI ICS, so the line number and the var number are definitely not matched. :D

Could you point me to which var is the v5 in the code below?

:cond_mir
if-nez v5, :cond_ko

Perhaps you have this mod for ICS? If yes, let me know your github also. :D

Thanks!

Btw, just wanna share another tips for timeout: I'm using a hardcoded timeout because I'm planning to make it configurable per app. Following is an example of a hardcoded timeout:

.field private static final LONG_PRESS_TIMEOUT:I = 0x12c
sget v2, Lcom/android/internal/policy/impl/PhoneWindowManager;->LONG_PRESS_TIMEOUT:I
int-to-long v2, v2
invoke-virtual {v1, v0, v2, v3}, Landroid/os/Handler;->postDelayed(Ljava/lang/Runnable;J)Z
[Galaxy S II Android Development] Mirko ddd:
github.com/Mirkoddd

And 0x12c is same as globalaction time out lol

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] fusionjack:
hmmm...now single press when screen is off does nothing. Am I missing something? :confused:
[Galaxy S II Android Development] Mirko ddd:
tell me what s your rom, so i can give a try
[Galaxy S II Android Development] fusionjack:
you can get it here: http://files.miuiandroid.com/2.11.23/miuiandroid_GT-I9100_ics-2.11.23.zip
[Galaxy S II Android Development] Mirko ddd:
nice, i m dwnling it.
[Galaxy S II Android Development] fusionjack:
So far by debugging single press of volume button when screen is off with my limited know-how of this mod:

As I can see in logcat, it landed in the controlMusicVolume() of PhoneWindowManager$SamsungVolumeControlThread which calls the handleVolumeKey() of PhoneWindowManager. So if it does nothing, then the mIsVolumeBlocking is still 1 which means skipping volume adjusting.

I could be wrong and talk rubbish here. :p
[Galaxy S II Android Development] Mirko ddd:
why don t u take off that stupid first two lines on updaterscript, made me abort the installations -.- i took it off and now i installed
[Galaxy S II Android Development] mtxx1:
strange, regardless i press volume up or down,

what it does is skip to the previous song, it doesnt skip to the next song,

i tried kugou, and ttpod, both behave the same.

i made a playlist, i tried press volume button while screen lock, it keep going to the previous song. :(
[Galaxy S II Android Development] Mirko ddd:
i see i wrote bad, check out op again.
[Galaxy S II Android Development] fusionjack:
I don't build that rom, i'm just using it. :angel:
[Galaxy S II Android Development] Mirko ddd:
ok i just began :D , no home button lag anymore (i hated it!). now i go with volume rocker mod.
[Galaxy S II Android Development] fusionjack:
great! i'm excited with the outcome. :D
[Galaxy S II Android Development] Mirko ddd:
jack, pass me ur code to debug. probably u missed a cond ;)

most is done, ontinue your work along this.

home button lag is disabled, and need very few work to get volume rocker mod. u can do it :D
[Galaxy S II Android Development] fusionjack:
do you still want my code changes to debug?

what should still be done for volume mod?

Edit: ok, only 2 condition blocks are missing, the rest is the same. do you get single press working on your phone?
[Galaxy S II Android Development] shoman94:
Hey bud... I tried this:

and it gave me a boot loop
[Galaxy S II Android Development] Mirko ddd:
let me see your smali mate
[Galaxy S II Android Development] shoman94:
I mean thats a real simple one liner change. It works before I change that.

https://dl.dropbox.com/u/28351722/PhoneWindowManager.rar
[Galaxy S II Android Development] Mirko ddd:
my fault, i ll delete it :)

i put a custom timeout, is set to 500 millisec, feel free to change it ;) (500=0x1f4)

that s yours

https://rapidshare.com/files/1625041842/PhoneWindowManager.smali

and sorry for bootloops lol
[Galaxy S II Android Development] shoman94:
It says you public traffic is exhausted.

Feel free to email it to: shoman94 at gmail dot com
[Galaxy S II Android Development] Mirko ddd:
sent :)
[Galaxy S II Android Development] ICS_XD:
Hie mirko i cant add your mod with pre installed tourch on lockscreen code :( ( i took a fresh phonewindowmanager.smali n added tourch sources but cant add your volume rocker sources now )

Both sources use some same codes in phonewindowmanager.smali
[Galaxy S II Android Development] mythtrandyr:
PhoneWindowManager.smali - include Volume Rocker, back long press kill app & Torch on home button in lock....see attach
[Galaxy S II Android Development] tdunham:
Hello friend. ;)

This part of the code:

.line 5838
:cond_388
:goto_388
if-eqz v5, :cond_mir
[COLOR="Red"]if-eqz v5, :cond_4f3[/COLOR]

Is difficult for me to find because of difference in values. Can you give me a little more surrounding code too please (so I may find it)? Thanks - TD

Edit: Nevermind, I found it. I always find, but I have to I ask first. LOL
[Galaxy S II Android Development] Mirko ddd:
Super lol u make roll on the floor :) it s not the 1st u do this

Inviato dal mio GT-I9100 con Tapatalk 2
[Galaxy S II Android Development] tdunham:
LOL, I'm glad you enjoy this. I have one more try. ;)

I have the mod working fine except for Volume Down does not skip to previous song just beginning of the current song.
[Galaxy S II Android Development] ICS_XD:
Super thanks to you mate :D
[Galaxy S II Android Development] tdunham:
I believe the volume down does not work the way I think it should. Here is one users' commentary so it looks like it is working perfect:

"It works just like an ipod for me, if you press the back button while a song is playing on an ipod, the song is going to repeat, but if you press it again right away, it will play the previous song,

It works the same for this music mod, except with the screen off and holding the bottom volume rocker while the song is playing"
[Galaxy S II Android Development] Mirko ddd:
here is working perfectly mate, maybe u need the whole smali to check :cond?
[Galaxy S II Android Development] tdunham:
You misunderstood. I said that it is working. But volume down does not work exactly the same way as the volume up long press. So I posted what the other user said so other users can see how it really works. :)
[Galaxy S II Android Development] Mirko ddd:
lol sorry i see.

well it works like a cd player, so if u press prev u ll get the start of the song, press again and will go to prev song :D

it s normal
[Galaxy S II Android Development] majdinj:
Thank you Mirko for your great mod.. but I think you have a bug in volume up button functionality, it will not skip to next song (it skips to previous song!!) and also it decreases the volume in continuous pressing (instead of increasing the volume!!)..

I see this bug was also there in couple of pages back, that might be you didn't noticed mate ;)

hope you will fix it soon...
[Galaxy S II Android Development] Mirko ddd:
Hello :)

Nope it s fixed, are u sure u implemented well?

Let me see the code ;)
[Galaxy S II Android Development] shoman94:
Nope...it doesn't work like that.
[Galaxy S II Android Development] majdinj:
Here is my smali file

https://github.com/majdinj/vol-to-skip/blob/master/PhoneWindowManager.smali
[Galaxy S II Android Development] Mirko ddd:
commit looks empty, on what rom are applying this? LSJ 4.1.2?
[Galaxy S II Android Development] majdinj:
I just wanted to import your mod to galaxy note GT-N7000 Leaked JellyBean LSC 4.1.2.. I followed your instructions in OP but that was what I got
[Galaxy S II Android Development] Mirko ddd:
An advice for future: if u follow specific guides for a specific phone model don say simply "don t work" but say where u r applying a mod.

I have a beta tester for GT-N7000 and i reserve my time to port it over on note.

Surely u messed some cond ;) but soon i ll post a tutorial on it.
[Galaxy S II Android Development] majdinj:
Thank you man for responce.. and sorry man for giving some of your time..
[Galaxy S II Android Development] Mirko ddd:
already sent files to my Note betaster, waiting for response
[Galaxy S II Android Development] majdinj:
cool.. and also waiting for your tut about cond in smali :good:
[Galaxy S II Android Development] Ofeliax:
Hi

Did you received my pm?

P.s

I noticed some missed conditions into your smali file.. check-it out

Inviato dal mio GT-N7000 con Tapatalk 2
[Galaxy S II Android Development] majdinj:
Sorry man, just now noticed... yes saw it and will plan to port this mod to N7000 as well in near future :o (perhaps with different method!!)
[Galaxy S II Android Development] Ofeliax:
No problem man

We are all busy....

I'm the Mirko's betatester, nice to meet you

I already ported the aosp lock screen mod to gt-7000, also by replace the msaycommand method as Mirko explained;)

But let's me understand, about your volume rocker mod ..

Does it work on Note LSC (now I'm on LS4, so I can't test it)?

Fully?

Partially?

Can you explain more accurate at your best please?

So we can try to fix the wrong codes

Cheers

Inviato dal mio GT-N7000 con Tapatalk 2
[Galaxy S II Android Development] majdinj:
PM sent dude
[Galaxy S II Android Development] 1982Strand:
Hi :)

You mention this code edit in the op:

.line 5838
:cond_388
:goto_388
if-eqz v5, :cond_mir
if-eqz v5, :cond_4f3

I have different values of .cond and .goto in my jar (and no ".line xxx" entries, they're removed for better compatibility)

Could you show some more lines before and after this code, so i can easier locate them? Thanks :)

(Using MIUI 2.12.14 from Miuiandroid.com - for Sammy GS3 - i9300)
[Galaxy S II Android Development] Mirko ddd:
Are u on what rom?
[Galaxy S II Android Development] 1982Strand:
MIUI 2.12.14 - Miuiandroid.com for m0 (International Galaxy S3 - i9300)

Attached my unedited PhoneWindowManager.smali (With .line xx removed) :) -Just zipped it up ;)
[Galaxy S II Android Development] Mirko ddd:
Check out s3 forums, there d be a volume rocker mod thread.

I cannot code anything without a debug phone, i have not an s3 ;)
[Galaxy S II Android Development] Ofeliax:
Maybe i can help you

Try to search the next block code (there is a cond_mir too)

Your missing cond_XXX is stored into the part of code that you'd must be replace

My was cond_577

Inviato dal mio GT-N7000 con Tapatalk 2
[Galaxy S II Android Development] 1982Strand:
I have searched, but not found one (Only one with a ready made jar which won't work on my phone - and a diff that gives all rejects..)

Anyways, i can fix it myself, i just need a little more lines before and after the code, to pinpoint the right place to edit. That small amount of code contains variables used all over the smali, making it hard to find the right spot ;)

Not exactly sure what you mean here, but of course i tried searching other parts of the code. Thing is, there are so many similar codes in the smali, so selecting the right one is hard and would be more or less a guess.. (Especially for a non-programmer like me, he)
[Galaxy S II Android Development] Ofeliax:
move/from16 v0, v29

move-object/from16 v1, p0

iput-boolean v0, v1, Lcom/android/internal/policy/impl/PhoneWindowManager;->mVolumeDownKeyConsumedByScreenshotChord:Z

invoke-direct/range {p0 .. p0}, Lcom/android/internal/policy/impl/PhoneWindowManager;->interceptScreenshotChord()V

:cond_417

:goto_417

if-eqz v6, :cond_57c

invoke-static {}, Lcom/android/internal/policy/impl/PhoneWindowManager;->getTelephonyService()Lcom/android/internal/telephony/ITelephony;

move-result-object v27

invoke-static {}, Lcom/android/internal/policy/impl/PhoneWindowManager;->getVoIPInterfaceService()Landroid/os/IVoIPInterface;

move-result-object v28

if-eqz v27, :cond_529

:try_start_423

invoke-interface/range {v27 .. v27}, Lcom/android/internal/telephony/ITelephony;->isRinging()Z

Sorry my english is ugly

i added some code

The red lines mark cond_mir

hope this help
[Galaxy S II Android Development] mani1999:
Does this work for XWLS8?
[Galaxy S II Android Development] JoFury:
Only works on non-stock player

Problem here , the mod only works on non-stock music player if installed :(
[Galaxy S II Android Development] tdunham:
On/off Toggle

Hi Mirko.

Is it possible to add guide to OP to have toggle to turn this mod on/off for users having issues with their favorite music player? Tnx - TD
[Galaxy S II Android Development] bombaybadboy:
Sorry to ask but im still learning, i was trying to see if its possible to use this guide on MS1 NeatRom 4.4 lite. I decompiled android.policy and started to edit PhoneWindowManager.smali

https://www.dropbox.com/s/jvj8csxbffxakus/PhoneWindowManager.smali

I was finding lines and adding new lines untill I came to adding

.line 8130 new-instance v0, Lcom/android/internal/policy/...........

Lines in ms1 PhoneWindowManager.smali are not the same. So this .line 8130 will be directed to the wrong line unless im wrong.

If im correct could someone post there modified android.policy jar or edited PhoneWindowManager.smali if you still have it. Im hoping I can identify these lines and edit lines on MS1

.line ****

Can anyone plz upload so I have a base to work with.
[Galaxy S II Android Development] tdunham:
.line xxxx is unimportant. You can give xxxx any line number you want for your code.

I know what you are going through. Here are my modified and stock files for you to compare. I use Winmerge for comparison.

This code is from different phone for comparison only. Values and variables may be different and need to be changed when porting mod to your version of smali.
[Galaxy S II Android Development] bombaybadboy:
Thankyou for that, now I see that this guide is a really good guide but its beyond my skills to adapt for ms1. Lines are so incompatible so I will try to find another guide. Thanks also for the smali zip :)
[Galaxy S II Android Development] ehmjay:
can someone help me to do this on miui v5 3.5.17
[Galaxy S II Android Development] davidwilson83:
Hi Mirko,

Will this work on any music player other than the stock Samsung music player? I use Google Play Music and was wondering if it will work with that player or not? After previously using AllianceMod I would be playing a song with Google Play Music, then press the volume up button with the screen off and it would open the stock Samsung music player. I kind of wanted to avoid that if I could. Any help/advice would be great.

Thanks in advance,

Dave
[Galaxy S II Android Development] shoman94:
This only works on the stock Samsung player.
[Galaxy S II Android Development] davidwilson83:
Thanks mate

Sent from my AOSP Blue SGSII
[Galaxy S II Android Development] pilgrim011:
Nevermind...
[Galaxy S II Android Development] mjz2cool:
that's impossible, you need to deodex in order to get to the smali files easily
[Galaxy S II Android Development] Sesme:
awesome thanks i put in last I9100XWMS3_I9100FOPLS6_FOP for S2
[Nexus 4 General] shadyshaun:
Hi Guys,

I picked up my Nexus 4 from O2 here in the UK this morning, for what it's worth here are my initial thoughts.

I'm coming from a Galaxy Nexus.

As per all the professional reviews, it does seem like a well made piece of kit. The glass back while being another fingerprint magnet is

a nice touch. When moving the phone suddenly or shaking the phone it does rattle. I took it back to O2 and they all the Nexus 4's they had in stock did it. It's loud enough to be noticeable, but not so loud i wanted my money back. The stores explanation was the accelerometer. I'm sure others will shed more light on this in time.

While the screen is crisp it is not as striking as some reviews would have me believe on auto brightness it is pretty dark (Much darker than my gnex on auto)

The sound is excellent but it does suffer from a muffled almost inaudible speaker when the phone is on the side face up on my desk. This has been a gripe of mine on previous phones.

Swipe style typing works really well, as does the new camera software. The pictures are a huge leap up from the Gnex

Battery needs further testing but so far has performed well. Wi Fi also has a FAR better range than the Gnex

My closing thoughts would be if coming from the Galaxy Nexus it may not be a huge leap up for you. If money is an issue i would wait....

But if you are an early adopter i'm sure you will love it.

I'm sorry it's a brief review, i'm no Shakespeare. If anyone has any specific questions though i would be happy to answer.

Shaun
[Nexus 4 General] PoisonWolf:
Is the rim made out of pure rubber? I'm just curious about folks with latex allergies, etc.
[Nexus 4 General] jonnyg1097:
This will seem like an odd question but are you able to feel the speckle pattern on the back? Like is it bumpy or is the pattern just under neath the glass?
[Nexus 4 General] PoisonWolf:
It's underneath the glass.
[Nexus 4 General] shadyshaun:
Yes it is.

If you are curious about people with latex allergies this is a good starting point

h**p://en.wikipedia.org/wiki/Latex_allergy :eek:
[Nexus 4 General] Vangelis13:
Must be underneath?
[Nexus 4 General] bustem:
its under the glass
[Nexus 4 General] shadyshaun:
As per what was said above, it's underneath the glass. I was worried about it looking tacky. But it works well. Hold the phone one way and the back is pure black, then you tilt it and you get the speckle effect. Muck like a hologram on a bank card.
[Nexus 4 General] Venekor:
The rattling isn't fine, something is loose or not fit right.
[Nexus 4 General] DarkShadowAy:
That's worrying, care to elaborate on that? Are you going to exchange it?
[Nexus 4 General] borich:
could you try "spirit Fm" http://xdaforums.com/showthread.php?t=1059296&page=480 and\or contact mike in order to know if it has hidden fm radio?

thanks in advance;)
[Nexus 4 General] hippieschuh:
Sony NEX-5N all over again^^
[Nexus 4 General] shadyshaun:
I took it back to the store, they had 5 in stock. All 5 rattled (As crazy as it sounds i wanted to test all of them)

For anyone familiar with the problems on the Sony NEX 5N camera 'Clicking' it's a bit like that.

I have 28 days if it is deemed 'faulty' but until more info comes out on it i'm going to hold on to the phone.

If 5 out of 5 do it i would presume a huge number if not all will, that said i'm surprised it wasn't picked up in any of the reviews.

As google begin to deliver time will tell.
[Nexus 4 General] shadyshaun:
Ha! Beat me to it, that's exactly how i would sum it up....
[Nexus 4 General] lombardo8:
Can you post some pics?

Is it unlocked?

Which O2 shop?
[Nexus 4 General] 0.0:
the rattling is a concern...when i get mine, i will test it out. could be the camera.

i shook my mytouch 4g and i heard some rattling as well. maybe its a normal thing?