yashsingh1/xdaforums huggingface dataset:
[Nexus S General] deani77:
I have WiFi problem with CM9 while using this kernel

Sent from CM9+T132 Kernel on NXS
[Nexus S General] jalyn02:
Wow! And this isn't even on a full charge, unbelievable! Great, great kernel dude. Keep up the great work.
[Nexus S General] apatal:
I'm sorry to hear that, mate. CM9 has been implementing a lot of mods that deviate from stock AOSP. (Remember how they caused all sorts of trouble with the wifi module path?) I'm not saying it is the reason but it may just be a factor. This kernel partners well with stock-ish ROMs like rascream and bugless beast, but I never really encountered any troubles with it when I used it on AOKP, so I'm not really sure what could be causing your Wi-Fi issues.

Sent from my Nexus S
[Nexus S General] apatal:
I'll make sure to make _thalamus know. Thanks! :)

Sent from my Nexus S
[Nexus S General] :
Yeah, what I say is entirely accurate though. Most of the stuff he commits is just utter garbage.

He really just slaps random patches together without a clue about what they do, what they affect, what the implications of them are or even if Android uses that functionality. It's a complete mess.

I wouldn't recommend that kernel to anyone. I'd recommend anyone thinking about using it to steer well clear.

CK (long time kernel developer and developer/maintainer of BFS) said in his IRC chat a few months ago that he used to come on XDA and it horrified him with all the slapping together of random kernel patches with no regard for what they do or the implications of them, which is exactly what Air Kernel does. I agree with that entirely. It's scary.
[Nexus S General] rasengan82:
Awesome good to know. Besides Jelly BELLY and stock, do you have a recommendation for a good ROM?
[Nexus S General] :
Nah, not really, if you want custom go for JellyBelly, otherwise stock, or alternatively if you want a feature wank list and bloat use CM.

I use a rooted stock with a modified ramdisk to enable insecure and debuggable, it does what I need, I don't require custom ROM features really and I prefer testing kernels on stock as it rules out custom ROM issues and ensures compatibility. :)
[Nexus S General] leap_ahead:
with this rom at my signature i dont have any problem !
[Nexus S General] polobunny:
Problem being that nobody seems to be maintaining a kernel with features people would like to use.

If you did a kernel with Voodoo colors & sounds and BLN, I'd use it. To others, fast charge is actually nice to trick their car charger.

BLX, BLD and all that is just little addons, but I don't believe people need it for more than the "I can do that" factor. Nevertheless, down the road, users have to satisfy with a kernel that does the simplest but is deemed stable or choose one with more features with absolutely hectic code.

It's cool of Con Kolivas to go like "whoa, it's ****!" and be all surprised most of XDA is patches on patches, but nearly nobody's bringing anything to the table in terms of ease of use. Those who do don't do it cleanly, and those who don't shun it like it's the plague instead of improving it.

Didn't you even have to do a bunch of commits (like 20ish IIRC) to fix the warnings for the JB source?
[Nexus S General] :
Yeah, this isn't a 'which ROM is best' thread...someone asked *my* opinion and I answered.

---------- Post added at 08:05 PM ---------- Previous post was at 07:57 PM ----------

BLN isn't stable. Someone on the JellyBelly thread had a kp caused by it, and having a quick look at it, it looks like it tried to add a timer which already existed. This is why I won't add buggy junk like that. Voodoo sound is already in, because it adds a serious lot of value and the code is rather elegant.

Fast charge I know nothing about. Is there a patch to look at?

Yeah, applying patches is fine, if you know what the implications are and understand what it does. Applying random crap from all over the internet to have a big feature list is not good. CK is a respected kernel developer. If he thinks something is ****, then it most likely is.

Yeah, I did about 20 odd commits to fix warnings. Nowhere near as many as I had to do for the Nexus 7 kernel though.
[Nexus S General] rasengan82:
I wonder why Google doesn't bother fixing all the warnings.
[Nexus S General] :
No idea. Because they are just 'warnings', not errors. Although thats a crappy excuse not to do a good job.
[Nexus S General] rasengan82:
Man latest test release is solid... no issues.
[Nexus S General] :
Yeah, I'm still streaming with Xiialive over wifi. Battery was at 7% at 18:45, it's now 20:15. Not sure what it's running on lol.
[Nexus S General] Maximilian Mary:
Here is the fast charge patch: http://xdaforums.com/showthread.php?t=1564973

I would be curious to know whether you think BLD is stable. If you'd like to look at it, here is the code for that:

http://xdaforums.com/showthread.php?t=1141233
[Nexus S General] polobunny:
Voodoo color is a serious value for some, which is what I was saying. I wish I had many crespo devices on hand to compare, but sometimes I'm doubting people are seeing the same thing I am on their screens. QC had to be pretty biased to accept super blue ones and super yellow ones and call it a deal.

I'm surprised about the kernel panic with BLN. Neldar's implementation or CMLed, or are they code wise nearly the same? I never bothered to check myself.

Agreed on CK. That's not really the point though. It's fun pointing fingers at crappy work, but who's gonna fix it in the end? Nobody's gonna fix it, so the situation doesn't improve at all. Not saying all devs should patch all other devs work, but a bit of help fixing hectic code would be rewarding for everyone in the end. Different ideology I imagine.
[Nexus S General] :
Hmmm. That fast charge patch looks excessive for what it does. I might have a look at implementing something similar though.

As for BLD, wow, that is a lot of code...
[Nexus S General] polobunny:
I was looking at fast charge and it did seem excessive code-wise. There's surely a cheaper way to do the same thing.
[Nexus S General] :
Yeah, but the point is, most people just merge random patches. They don't contribute anything, they don't fix anything, they don't write any code, they just take other peoples work, slap a bunch of extra garbage on it and release it. The vast majority of the kernels on XDA are exactly that.

That is *not* development, and it is not good for XDA and it's not good for the Android development community, because the real development gets lost in the noise of all the crap and we all end up looking like idiots who just slap patches together, when a few of us actually don't do that.

The patch happy idiots are the people that should be pointed at and laughed at.

Code which has been written by someone but is buggy I don't mind and I will even try to fix it. At least they have tried to do something useful. They have actually done some development, unlike most of the so called developers on here.

If anyone has wondered why I don't have a recognised developer title, I did have one, but I told them I didn't want it anymore after seeing the morons they were handing it out to.

This was the PM I sent requesting it to be removed back in October last year:

---------- Post added at 08:57 PM ---------- Previous post was at 08:56 PM ----------

Yeah, it could be implemented without all that sysfs stuff. A simple module_param would do. I may have a look into it.

---------- Post added at 08:58 PM ---------- Previous post was at 08:57 PM ----------

Oh, and the BLN fix is here. It was just a checking oversight.
[Nexus S General] polobunny:
Understood. Your work is always appreciated though, I'm sure you know, recognized dev or not. :P

Unrelated although it seems like it's related, but I'm interested in kernel dev myself. What would the "prerequisites" be to prepare myself to this? What have you went through to one day end up in kernel dev? It's a freaking huge beast to tackle when you look at that from the outside, but I was doing BASIC when I turned 10 so I'm not too scared to learn the intricate things of a language... If you prefer you can PM me or I can PM you about that instead of littering the thread with random stuff.
[Nexus S General] rasengan82:
Man I have to agree with Thalamus. I was a fan of a ROM here and then decided to check github. Lo and behold... zero development from the actual developer... everything... everything cherry pick from CM and AOKP...
[Nexus S General] Imppy:
Ahh I'm using nstools...and when I choose 800 MHz my phone reboots...this is using the default interactive settings in nstools
[Nexus S General] :
Don't use nstools. That steaming pile of crap is causing the reboots, not the kernel.
[Nexus S General] sdhanjal15:
Beautiful !

Sent from my Nexus S
[Nexus S General] Imppy:
Should I use setcpu?
[Nexus S General] :
SetCPU works but sometimes displays incorrect frequency values. But if you check, it is actually setting the frequency to the selected value, it's just not displaying it correctly. For example, it displays 250 & 500MHz, which don't even exist in the CPU frequency table and it still displays 1000 after you have set it to 800, but it has actually set it to 800.

That app used to be good, now it's a bit...meh.
[Nexus S General] Imppy:
So which app you prefer?
[Nexus S General] :
None. I don't use them. No point.
[Nexus S General] Imppy:
How do I set it without app?
[Nexus S General] :
You don't. It doesn't need to be set. Leave it alone lol.

This isn't an app thread btw.
[Nexus S General] Imppy:
Lol...going to listen to the wise man
[Nexus S General] atl4ntis:
missing a ')' and wrong usage of modtimer

int mod_timer (	struct timer_list *	timer,
unsigned long	expires);

edit:

this will do it better:

if (timer_pending(&blink_timer))
mod_timer(&blink_timer, jiffies + msecs_to_jiffies(blink_interval) );
else
add_timer(&blink_timer);
[Nexus S General] Imppy:
Awaiting for your next test release with this implemented!
[Nexus S General] colonia27:
Yeah, and I'm awaiting for people to read the thread and finally_and_once_and_for_all get the message that BLN won't come.

This is _thalamus' personal kernel and he adds/adds not what he wants. BLN is smth he wont add, simply 'cause of pure uselessnes.

If you want it check out AdamG's JellyBelly ROM which has _thals kernel +BLN.

Btw: you would have known all this if you had cared to read the last 3-4 pages.
[Nexus S General] Imppy:
I already know that...but it seems like he is helping with the bln for Adam's ROM I supposed or hypothalamus
[Nexus S General] stojshic:
Ok, just my opinion on BLN. I use it since I found out how it works, and I can't see myself using my phone without it. But (there's always but), I always had problems with blinking BLN. It would randomly restart on every other missed call, so it's definitely bad coded. But I never had any problems with it if I don't enable blinking. Now, what I want to say (as I know something about coding, but nearly enough to fix any bad coded addon here), is if someone could look into code, fix blinking, or better yet, remove blinking entirely, and that *should* possibly fix any instability. BLN could be useful feature, IMO, but blinking is pointless and requires more battery, so, just remove that part of code and it's win-win. Users that want it, would get BLN, I don't think anyone would miss blinking that much, as it's pointless, code will be shortened, and maybe thalamus would consider adding it afterwards... Of course, if anyone is willing to remove that part of the code....
[Nexus S General] nexusphone:
deleted
[Nexus S General] rstrube:
Hi thalamus,

I just installed your latest test kernel (24) which was posted on your blog. I'm running it on a i9020T with the stock JB OTA update. I am truly astonished at how much more responsive phone feels compared to the stock kernel. Thank you so much for creating a minimalist kernel. I look forward to your future releases.
[Nexus S General] ivlis:
Thumbs up for BLN wo blinking!
[Nexus S General] :
Thats what happens when you don't compile / test the code you write. Ah well. Cheers. ;)

Fixed: https://github.com/jellybelly-rom/a...mmit/ad682d3b02077d29fc672da48246c764669392f9

---------- Post added at 09:28 AM ---------- Previous post was at 08:42 AM ----------

There is going to be no BLN at all in this kernel. The BLN fix is for JellyBelly.
[Nexus S General] benoit2600:
Hi _thalamus

I have in my home the two model of nexus S, the i9020t and the i9023. The i9020t is mine, and the 9023 is to my father. I took some photos to compare the quality of each screen. Those photos aren't modified, I've just resize them.

The i9020T is on the left ( with the red protection) and the 9023 on the right.

Here is the configuration :

I9020t : JellyBelly 1.5.1 (with default kernel)

I9023 : Stock JellyBean (maj from ICS)

There are both put at low brightness, and I think the picture speak by themself, Amoled screen is greenish.

In higher brightness the difference beetwin both is less visible but present.

The question is : Is your screen looks like mine with low brightness ? thank you in advance.
[Nexus S General] chronophase1:
Bro, your screen is effed if it seriously looks like that. Mine looks like the one on the right. Lol.
[Nexus S General] d_phekt:
I also have an i9020T and no matter what kernel/rom combo I use I get the same yellow tint. I've tried to flash a few "cold/blue" colored kernels and they all look the same yellow. No bright whites as expected.
[Nexus S General] :
As does mine. Nice and white. :) I'll post a pic later.
[Nexus S General] madd0g:
Try flashing SimpleKernel, which is basically stock, to check out if the colour is still messed up like that on JellyBelly.
[Nexus S General] :
Did you really need to full quote all those pics? Good way to clutter the thread...

Maybe your screen is knackered.
[Nexus S General] chronophase1:
Maybe this is a side effect from adjusting the gamma values too much?
[Nexus S General] :
I would suggest flashing the stock factory images which have now been released. If it's still the same with stock, it's a hardware issue.

---------- Post added at 03:18 PM ---------- Previous post was at 03:17 PM ----------

Quite possible. AMOLED screens have a finite life.
[Nexus S General] d_phekt:
But wouldn't it look the same yellow while in CWM if the screen was messed up? It looks normal in touch recovery.
[Nexus S General] :
Yes. Why don't you try flashing stock? I use a rooted stock ROM and my latest kernel and don't have this issue.
[Nexus S General] madd0g:
Yeah I agree, anything back to stock would exclude possible ROM/kernel issue.
[Nexus S General] benoit2600:
I've flash the boot.img from the google official archive (found here The "soju" for JB one) and the color is perfect ! no more greenish white, even with low brightness ! So I guess the problem might came from your kernel.

Another thing I found : when the phone boot, we see the google logo then he diseappear briefly and reapper and then come the bootanimation.

with your kernel, the first google logo is white, and then he becomes yellow.

with stock kernel, the first google logo is white and the second is white too.
[Nexus S General] :
Interesting. I do have an idea. I'll do a test build when I get back. I suspect only some people see the issue because more than one panel is used by Samsung.
[Nexus S General] deltatux:
I can confirm this as well, but I wouldn't really call it "yellow" it's more like a slight tinge of yellow. If benoit2600 didn't post that, I wouldn't have seen the difference is how small the yellowish tint the Google logo became with the latest 3.0.38-24 test kernel.

deltatux
[Nexus S General] :
Can anyone pinpoint in which release it first occurred? I'm pretty sure I know what caused it although not the exact commit, but it would be good to have an idea where exactly to look. :)
[Nexus S General] d_phekt:
Personally I've had the yellow tint issue with a few different kernels, not just yours. I first noticed it about 6 months ago on ICS using Trinity... oddly the latest Trinity JB test kernel is the only one besides stock not giving me the yellow now. Mine's definitely not as yellow as the pic posted a page back, but it isn't as white as I know it should be.
[Nexus S General] atl4ntis:
Hello _thalamus,

feel free to trash this post since it's related to a fork of your jelly belly kernel made for myself with few additions but i think it maybe could be usefull if the bug it's related to your source.

Basically had a SoD after a phone call, my currently repo is synched to your last commit.

Last_kmsg attached.

Thank you.
[Nexus S General] :
Anyone available to test a kernel for this yellow issue? Please come into #thalamus-hacking IRC channel on freenode (webchat link in my sig) or PM me. IRC would be better though.
[Nexus S General] d_phekt:
Thalamus built a test kernel for the yellow screen issue and authorized me to post a link to it here. I tested it and can confirm it worked perfectly for me. Enjoy

http://thalamus.ineige.org/kernels/...8-24JB_test-1-gb6acfe8-JB-20120728-190827.zip
[Nexus S General] Imppy:
Is this for yellow tint on white too? Or for the obvious hello screen?
[Nexus S General] :
I've no idea, I don't have the issue, it only affects you if you have a either a hitachi or hydis panel on your Nexus S. I'm not sure which panel is affected because I reverted both changes which were to fix a warning.

Why not simply try it instead of asking, it would save you asking daft questions to get a daft answer, now wouldn't it?
[Nexus S General] deltatux:
No difference here. Unfortunately since the Nexus S is my only phone, I don't want to tear my phone apart just to figure out which screen I'm using...

I can say that my phone is the Nexus S (I9020T).

deltatux
[Nexus S General] :
Does yours look like this?
[Nexus S General] deltatux:
Somewhere in the middle, it's just a slight yellow tinge. It's definitely not as yellow as the one on the left but it's not as white as the screen on the right either.

deltatux
[Nexus S General] :
Mine looks like this:
[Nexus S General] deltatux:
Man, broken link. I can't see the photo you posted.

Thanks,

deltatux
[Nexus S General] :
Odd, it's displaying here.

Try this: http://sdrv.ms/O9nP0D
[Nexus S General] d_phekt:
Mine is obviously better than it was, but definitely not that white LOL
[Nexus S General] :
Yeah, must be a different panel, that does explain the oddities between different peoples devices.
[Nexus S General] deltatux:
Is your phone the I9020T or I9023?

deltatux
[Nexus S General] :
i9020T of course, the i9023 is SLCD (yuk).
[Nexus S General] benoit2600:
The test kernel posted the previous page doesn't change anything for me :(
[Nexus S General] :
That doesn't make sense. Are you sure it successfully flashed?
[Nexus S General] Ron Overdrive:
If that's the case maybe Voodoo Color has some value to it after all. If anything you won't have to make separate kernels for each panel. Just noticed when comparing mine to yours that mine has a yellow tint to it so I'm going to try the test kernel. I'll let you know if it gets fixed.

EDIT: Yup, fixed.
[Nexus S General] apatal:
OP updated! Cheers!

Sent from my Nexus S
[Nexus S General] rasengan82:
Wait I have test 24... no issues. Should I flash.test 25?
[Nexus S General] jad3675:
I posted about it here. It was the 7/26 test kernel.

http://xdaforums.com/showpost.php?p=29351098&postcount=501

Also, the new test kernel does not fix the issue for me. Auto brightness and anything below 25% are a bit yellow.

John
[Nexus S General] apatal:
Yes, 25 has the fix for the ANR issue, and then latest implementation of idle2. :)

Sent from my Nexus S
[Nexus S General] Imppy:
There are so many versions which one I download? Lol I have 1920a
[Nexus S General] d_phekt:
Although the test kernel to fix the yellowing did seem to make mine a little better, it is not 100%. It actually now has a slight pinkISH tone to it at lower brightness.
[Nexus S General] :
I have no idea which one the "7/26 kernel" is. I increment the version numbers each time for a reason lol.

I'm guessing you mean 3.0.38-23?

Anyway, with the assistance of benoit2600 (and I thank him sincerely for his patience and apologise for his melted NAND), I managed to find *another* bug which was causing this on his device.

A working kernel is available here.
[Nexus S General] deltatux:
What does this test 2 kernel fix?

deltatux
[Nexus S General] :
This.
[Nexus S General] d_phekt:
The test kernel above actually turned my screen back to yellow. I've tried every kernel possible with a few different roms and all seem to get the same results. I think its time I get rid of this phone. I can confirm what someone mentioned before... the google logo at boot flashes twice before bootscreen. The first one is nice and bright white, but the second is the dull yellow.
[Nexus S General] :
Very odd. I wonder if something is borked in the panel initialisation code, because the first Google logo is from the bootloader. Once the kernel initialises the panel, you get the flash and then the kernel takes over the display.

Does it work ok with the stock kernel though? If so, I would probably lean towards the toolchain being at fault, which is a possibility.
[Nexus S General] leerapalot:
The test 2 kernel has definitely fixed my yellow screen problem.

Sent from my Nexus S.
[Nexus S General] :
This is frustrating. I think we have 2 separate issues causing screen tints. I don't think either of my attempted fixes have actually fixed anything though, I think they have just allowed the symptoms of the problem to go in some situations, but the problem is still there.

Maybe both issues have the same cause, I'm not sure.

I'm definitely suspecting the panel initialisation code is flakey and doesn't do the job correctly under certain conditions.

I'm also suspecting the toolchain. I'll do a 3.0.38-25 build with the stock android toolchain in a sec, and anyone affected can try that and see if it fixes it, if you wouldn't mind.

---------- Post added at 01:14 AM ---------- Previous post was at 01:06 AM ----------

3.0.38-25 built with stock android toolchain.

http://thalamus.ineige.org/kernels/...8-25JB_test-1-g7b8bb8d-JB-20120729-010900.zip
[Nexus S General] jad3675:
"3.0.38-25 built with stock android toolchain" fixed it on my phone. No more yellow-ish tint at any brightness level. Thanks again.

John
[Nexus S General] :
Nice. That is good to know. Would appreciate it if anyone else with this issue could test this also.
[Nexus S General] leerapalot:
This test kernel has turned my screen back to a yellow tint.

Re-flashed test 2 and its gone again.
[Nexus S General] :
*groan* Definitely two separate issues then. Oh well.

Still want feedback for the kernel with the stock toolchain though. It may fix the issue for some.
[Nexus S General] d_phekt:
Damn... The test with stock toolchain got rid of the yellow but back to pinkISH. WTF?
[Nexus S General] :
How does it compare to the actual stock kernel? If its the same, it resolve the issue.
[Nexus S General] mixtapes08:
Lol :)

Sent from my Nexus S™
[Nexus S General] d_phekt:
When I get home I'm going to fastboot the stock JB image and see what I get.
[Nexus S General] d_phekt:
fastbooted factory image and it is YELLOW! Also, After the last update I had a chance to tinker around a little bit with the brightness and whatnot. I was getting the pink tones at low brightness, but when I raised brightness it did get a little yellow. Obviously the issue is not kernel related. I have no idea how long this has actually been an issue with my phone. I have used kernels with voodoo color since day one... which is more than likely my problem. Probably got eff'd up at some point. Sucks. I wanted to use either this or Matr1x, but neither use voodoo, so I'm pretty much screwed for now since I pretty much need it to get decent color. And NO... I won't use air LOL. Again thalamus... thank you for all of your efforts. Your work here is VERY much appreciated.