yashsingh1/xdaforums huggingface dataset:
[AT&T Samsung Galaxy Note I717] Really now:
I've been mostly running Carbon for a month or so now using TWRP 2.6.1.0 and haven't had any problems flashing/booting updates and other 4.3 roms. I usually do a clean Carbon install every third update I flash and always when I flash a new rom.
[AT&T Samsung Galaxy Note I717] Truetek:
Well, i've been having some issues with foreground programs closing, (like playing vlc while surfing with chrome, vlc will be closed down, then I press home and my launcher was killed and start reloading... switched players, browsers and launchers, eventually it happens...) so I always do a clean install every time... I mean, really clean, i go into advanced, clean out everything except for sd card (the external one).

Today, I tried flashing Carbon 18th oct. nightly, with gapps. Used all the versions I mentioned above, same result... even switched gapps package to another one (SPEC-GAPPS-JBv2.0-4.3.zip & Banks one too), no avail...

I'm not even at the point where I flash Uber... once I reboot, that's that...even with a battery pull :(
[AT&T Samsung Galaxy Note I717] bigbiff:
Are the 4.3 roms using selinux?
[AT&T Samsung Galaxy Note I717] Really now:
Yes they are.

---------- Post added at 05:54 AM ---------- Previous post was at 05:30 AM ----------

Ok, you and I have the same definition of a clean wipe and yet it doesn't work for you. Have you tried flashing using a recovery other than TWRP? Like I said before I'm not having any trouble with TWRP but I've read in other threads that quite a few people are on the 4.3 roms. We do know that there are differences in our phones. Samsung gets parts from different manufacturers or just different lots that have slightly different electrical characteristics and sometimes this causes problem for us. If you haven't already check out BlownFuzes AOKP 4.3 thread. A couple weeks ago he came up with something to help those having problems flashing. Good luck! :good:
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you post the link to the thread post?
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
I have the same issues with 2.6.3 but using 2.6.1 they aren't as bad. Twrp 2.5 or Cwm seems to be working the best with CM10.2 and twrp 2.5 is the recommended for most. I have tried 2.6.3 with Pac-Rom, BeanStalk, & my Pac builds getting errors with every one using twrp2.6.3. I have not gotten any logs due to needing my phone as my DD.
[AT&T Samsung Galaxy Note I717] Really now:
BlownFuze's suggestion for a work around is in the OP of his 4.3 AOKP thread in the development section.

Ok, home from work now so I can edit the above a bit. The OP is http://xdaforums.com/showpost.php?p=46007610&postcount=1

And the first post talking about what he was doing to try and get rid of the errors when flashing is here: http://xdaforums.com/showpost.php?p=46180855&postcount=138

He has made a couple of versions of the recovery but the latest version link is in the OP.
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you see if the following attached recovery boots?
[AT&T Samsung Galaxy Note I717] BlownFuze:
This is a new one, with selinux enabled?
[AT&T Samsung Galaxy Note I717] bigbiff:
I compiled the CM kernel with selinux.
[AT&T Samsung Galaxy Note I717] BlownFuze:
Downloading now... I'll flash it, then do a fresh wipe and flash of my ROM. The test, is to wipe all partitions with the recovery, flash ROM, and then try rebooting a few times.

I'll post back here with how this works out, in a little bit.

:thumbup:

---------- Post added at 09:38 PM ---------- Previous post was at 08:58 PM ----------

No good - doesn't boot. Will have to odin back to a working phone. Lol.
[AT&T Samsung Galaxy Note I717] bigbiff:
Did you get /proc/last_kmsg?
[AT&T Samsung Galaxy Note I717] BlownFuze:
No.

The other thing I noticed, is the img file size... normally recovery.img is around 7mb every build (4.2 and 4.3).
[AT&T Samsung Galaxy Note I717] bigbiff:
Yeah, the kernel I compiled from quincyatt cyanogenmod repository came out to be around 8 MB itself and it's already gzipped. From what I have found the note1 doesn't like lzma kernels, only seems to like booting gzipped kernels. Can you describe exactly what you see when it tries to boot?
[AT&T Samsung Galaxy Note I717] BlownFuze:
I'll give you the step by step. :good:

- put image in flashable zip

- rebooted into recovery (cwm) and flashed zip

- no error: script pushed recovery.img to /temp, flashed recovery partition (block 22), and deleted /temp

- from recovery, selected reboot recovery

- after samsung logo, my bootanimation came up ( it was yellow instead of green though? Lol )

- waited, then pulled battery

- replace battery and tried to manually boot into recovery (hold vol+ $ vol-) - tried this a few times.

- same yellow boot animation, so pulled battery and booted to download mode.

- rebooted lappy to win partition (was in Linux at the time working on ROM :D Lol )

- odin flash twrp 2.5

- rebooted recovery and found empty sdcard - arrrg

So, it wouldn't boot into recovery and it wiped my sdcard somehow. I've odin flashed recovery dozens of times without it affecting anything else - so I'm pretty sure the odin to twrp 2.5 didn't mess up the sdcard.
[AT&T Samsung Galaxy Note I717] bigbiff:
- after samsung logo, my bootanimation came up ( it was yellow instead of green though? Lol )

When you say that, it was the bootanimation for the rom?
[AT&T Samsung Galaxy Note I717] BlownFuze:
Yes.
[AT&T Samsung Galaxy Note I717] bigbiff:
Hmm, it's like it's not trying to boot into recovery, or if it is trying, gives up and reboots to stock.

So, the ROM will not boot up into the launcher?
[AT&T Samsung Galaxy Note I717] BlownFuze:
No, it didn't up into launcher or recovery. To be fair, I only waited about 5 minutes though (I figured that was long enough, considering I hadn't wiped anything). My only success, was booting into download mode.
[AT&T Samsung Galaxy Note I717] bigbiff:
Here is a fresh build with CM's configs with TWRP stuff added. Please let me know if it boots.
[AT&T Samsung Galaxy Note I717] hfam95:
So is it still not safe to update to 2630?
[AT&T Samsung Galaxy Note I717] bigbiff:
I have not heard of any issues besides installing 4.3 roms.
[AT&T Samsung Galaxy Note I717] hfam95:
Ok. That would include me since I'm on a 4.3.x ROM. Will stay on 2601
[AT&T Samsung Galaxy Note I717] BlownFuze:
I will try this in the morning - been a hectic evening, and I'm headed to bed. Lol

I would recommend no one else try these images, until we get this sorted out - it's not for the faint of heart. :highfive:

Installing 2.6.3.0 is safe, some people might have issues with 4.3 ROMs though.

Agreed.

If 2.6.0.1 works without issue - then stick with it for now. :good:
[AT&T Samsung Galaxy Note I717] BlownFuze:
Ok, this one booted - just couldn't see any partions, including sdcards (int or ext).

Here is the last_kmsg.
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you pull /tmp/recovery.log and see the gui?
[AT&T Samsung Galaxy Note I717] BlownFuze:
Pulled the recovery log for you.

Yes, I can see the gui - it looks normal and all the buttons seem to work as usual.
[AT&T Samsung Galaxy Note I717] bigbiff:
Ok, here is one with a fixed up recovery.fstab: http://goo.im/devs/bigbiff/quincyatt.img
[AT&T Samsung Galaxy Note I717] BlownFuze:
Grabbing it now - will report back shortly with the results. :good:
[AT&T Samsung Galaxy Note I717] BlownFuze:
Now it sees all partitions, except internal storage. Attached recovery log.
[AT&T Samsung Galaxy Note I717] bigbiff:
Same link, I uploaded one with /emmc as internal storage. Thanks for testing.
[AT&T Samsung Galaxy Note I717] BlownFuze:
Grabbing now...

No problem on testing - I'll be happy to be back on TWRP. :highfive:
[AT&T Samsung Galaxy Note I717] BlownFuze:
I can now browse both internal and external storage, but I cannot mount either of them for usb storage. Everything else looks good, as far as I can tell.
[AT&T Samsung Galaxy Note I717] bigbiff:
What happens when you try to mount USB? Also can you tell me if backing up and restoring 4.3 roms as well as installing works?
[AT&T Samsung Galaxy Note I717] BlownFuze:
When I try to mount, the screen changes to the "unmount" button - but the drives are not visible on my pc. I had to click the unmount button a few times, to get the screen back to the mount screen - almost as if the touchscreen was unresponsive.

I will test backing up, restoring, and installing a little later - I actually have a new AOKP build finishing up, to test all this with later today.
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you upload a recovery.log with you testing the mount usb feature?
[AT&T Samsung Galaxy Note I717] BlownFuze:
That's what I posted a few posts back - that recovery3.txt is the log from after trying to mount a few times.
[AT&T Samsung Galaxy Note I717] bigbiff:
OK, guess we aren't logging anything relevant. I will need to check the kernel to see if usb mass storage is still enabled.
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you try this image: http://techerrata.com/bigbiff/quincyatt-twrp.img and see if USB Mass Storage is working?
[AT&T Samsung Galaxy Note I717] BlownFuze:
USB Mass Storage still isn't working with that image either.
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you pull /tmp/recovery.log and dmesg after you try to mount?
[AT&T Samsung Galaxy Note I717] BlownFuze:
Here is both.
[AT&T Samsung Galaxy Note I717] bigbiff:
Looks like dmesg was pulled from your ubuntu. Please pull it from TWRP.
[AT&T Samsung Galaxy Note I717] BlownFuze:
Lol - sorry man, doing too many things at one time. Here is dmesg from recovery.
[AT&T Samsung Galaxy Note I717] bigbiff:
<6>[ 2.113494] Initializing USB Mass Storage driver...
<6>[ 2.113677] usbcore: registered new interface driver usb-storage
<6>[ 2.113800] USB Mass Storage support registered.
<6>[ 2.113891] usbcore: registered new interface driver ums-alauda
<6>[ 2.114044] usbcore: registered new interface driver ums-cypress
<6>[ 2.114227] usbcore: registered new interface driver ums-datafab
<6>[ 2.114349] usbcore: registered new interface driver ums-freecom
<6>[ 2.114532] usbcore: registered new interface driver ums-isd200
<6>[ 2.114654] usbcore: registered new interface driver ums-jumpshot
<6>[ 2.114837] usbcore: registered new interface driver ums-karma
<6>[ 2.114959] usbcore: registered new interface driver ums-onetouch
<6>[ 2.115142] usbcore: registered new interface driver ums-sddr09
<6>[ 2.115264] usbcore: registered new interface driver ums-sddr55
<6>[ 2.115447] usbcore: registered new interface driver ums-usbat
<6>[ 2.115661] usbcore: registered new interface driver usb_ehset_test
<6>[ 2.116058] peripheral driver registered w/ tranceiver
<4>[ 2.116180] msm_otg_sm_work 1798 id=0 OTG_STATE_UNDEFINED
<6>[ 2.118530] android_usb gadget: Mass Storage Function, version: 2009/09/11
<6>[ 2.118652] android_usb gadget: Number of LUNs=2
<6>[ 2.118804] lun0: LUN: removable file: (no medium)
<6>[ 2.118896] lun1: LUN: removable file: (no medium)

Can you look and see if the lun files have anything in them? Can you paste the contents of

/sys/devices/platform/msm_hsusb/gadget/lun0/file
/sys/devices/platform/msm_hsusb/gadget/lun1/file
[AT&T Samsung Galaxy Note I717] BlownFuze:
lun0/file has just one line:

/dev/block/mmcblk0p28

lun1/file has just one line:

/dev/block/mmcblk1
[AT&T Samsung Galaxy Note I717] bigbiff:
So, TWRP is doing it's thing but the kernel isn't presenting them. What OS are you using?
[AT&T Samsung Galaxy Note I717] BlownFuze:
On my laptop, xubuntu 13.04.
[AT&T Samsung Galaxy Note I717] bigbiff:
I am not exactly sure why USB mass storage is not working.
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
Could you guys mirror the last version (2.6.3.0) because the goo.im links don't works!!

I want to root my device, but i could not download the recovery!
[AT&T Samsung Galaxy Note I717] Really now:
Go to the TWRP website and you can download it from there. :good:
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
goo.im links don't works (the download page don't response after the countdown)!

techerrata links downloads to 99% and froze! it's just don't complete downloading!!

tried 3 browsers and idm to download the file, but couldn't :/

I need the Odin one BTW!
[AT&T Samsung Galaxy Note I717] armyboy11b:
Where do I download this at??? The galaxy note i717 isn't listed on their website :/

---------- Post added at 09:42 PM ---------- Previous post was at 09:37 PM ----------

Nvm found it but its not downloading :/
[AT&T Samsung Galaxy Note I717] bigbiff:
Use the mirror: http://www.techerrata.com/browse/twrp2/sgh-i717

I have reported the issue to Goo.
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
Download success! and Root Done!

but...

I couldn't mount my sd card! and I couldn't check sdcard option on Mount screen!! Also, it shows that sdcard 0GB!

---------- Post added at 10:58 AM ---------- Previous post was at 10:58 AM ----------

Download success! and Root Done!

but...

I couldn't mount my sd card! and I couldn't check sdcard option on Mount screen!! Also, it shows that sdcard 0GB!
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you post recovery.log as an attachment?
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
here is it http://tinyw.in/6dnA
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you verify that you only have one primary partition on the sdcard?
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
Yes, only one!!
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you give me the output of fdisk -l /dev/block/mmcblk1
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
where should I write this command?!

I opened a terminal app on the device and it was like this:

u0_a219@android:/ $

fdisk -I /dev/block/mmcblk1

/system/bin/sh: fdisk: not found

127|u0_a219@android:/ $

I'm I doing it write?!

the phone is not connecting to the laptop, by the way.
[AT&T Samsung Galaxy Note I717] bigbiff:
You can do it in twrp terminal emulator.
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
the output:

unknown option -- I

BusyBox v1.20.2-jb bionic (2012-10-25 21:29 +0100) mu

Usage: fdisk [ul] [-C CYLINDERS] [-H HEAD] [-S SECTORS]

Change partition table

-uStart and End are in sectors (instead of cylinders)

-lShow partition table for each DISK, then exit

-b 2048(for certain MO disks) use 2048-byte sectors

-C CYLINERSSet number of cylinders/heads/sectors

-H HEADS

-S SECTORS
[AT&T Samsung Galaxy Note I717] bigbiff:
Did youuse one dash?
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
What do you mean by one dash?
[AT&T Samsung Galaxy Note I717] bigbiff:
-l Show partition table for each DISK, then exit

that option
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
There is no output!!

I tried "fdisk -l" and "parted /dev/sda print" but both didn't work!!

there is # before the command, which mean i'm using root now.

what should be the sdcard formating to? FAT32, NTFS, EXT4...etc

give me the commands I need and I'll post the output.

-------------

I tried these commands, but I couldn't get an output!! [Got it from this thread Link]

adb shell
parted /dev/block/mmcblk0
unit
^This will ask for another input. Type "B" and hit Enter
print

the first code gives me

sh:

adb: not found

the second one

GNU Parted 1.8.8.1.179-aef3

Using /dev/block/mmcblk0

Welcome to GNU Parted! Type 'help' to view a list of ...(can't see the rest!)

the third/forth one "unit" and "print"

/ # parted /dev/block/mmcblk0 unit

/ # parted /dev/block/mmcblk0 print

NOTHING HAPPENS!!
[AT&T Samsung Galaxy Note I717] bigbiff:
You need to use /dev/block/mmcblk1. Mmcblk0 is the internal emmc.
[AT&T Samsung Galaxy Note I717] a.2mjed.a:
I did format my SD card to FAT32 and it is worked :)

I did install CM 10.1 Nightly (4.2.2) and everything is great

Q/ there are some folders in the internal disk from the previous Rom and app, what is the perfect way to delete them without harming the system?

Thanks for you help, I appreciate it ;)
[AT&T Samsung Galaxy Note I717] sidgallup:
TWRP 6.0.1 sends this error "unable to open zip file" tried redownloading the rom 4 times already, also i can open it on my computer with no problems... any ideas?
[AT&T Samsung Galaxy Note I717] MechaGen:
What ROM? TWRP doesn't work with 4.4 KitKat ROM'S.
[AT&T Samsung Galaxy Note I717] bigbiff:
Did you test the one I made a while back?
[AT&T Samsung Galaxy Note I717] bigbiff:
Can you upload /tmp/recovery.log?
[AT&T Samsung Galaxy Note I717] sidgallup:
ohh sorry, posted that in the wrong thread, it was the Padawan ROM, had enough of it and just flashed another ROM, working perfectly so far.
[AT&T Samsung Galaxy Note I717] hairypork:
Just wondering why it says note 2 in the op just wanted to double check before I flash this and see if it works yet for kitkat roms.
[AT&T Samsung Galaxy Note I717] bigbiff:
My bad, trying to update topic through a script.
[AT&T Samsung Galaxy Note I717] hairypork:
All good thank you for your response.
[AT&T Samsung Galaxy Note I717] :
Does TWRP 2.7.0.0 finally work with Kit Kat? :confused:

The new TWRP 2.7.0.0 'flashable zip' doesn't actually flash. You'll need to copy recovery.img into a 2.6.0.0 TWRP flashable ZIP.
[AT&T Samsung Galaxy Note I717] bigbiff:
I will rebuild the zip tonight. Thanks for the report. I am waiting for people to test everything. Please test functionality so others can benefit.
[AT&T Samsung Galaxy Note I717] :
USB mounting still works fine, but Kit Kat support doesn't seem to be in yet (tried flashing blaine's CM11)
[AT&T Samsung Galaxy Note I717] bigbiff:
OK, I will need to look at the kernel. I would love to see /tmp/recovery.log after flashing CM11.
[AT&T Samsung Galaxy Note I717] :
Where do I find recovery.log?
[AT&T Samsung Galaxy Note I717] bigbiff:
Install adb, then adb pull /tmp/recovery.log and paste it to http://paste.tinyw.in and give the link here.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
Here ya go.

I get the same errors when I compile for this device.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
I have finally got this to mount the sd card & flash kitkat roms. I still have a couple bugs and can't mount the internal storage yet.
[AT&T Samsung Galaxy Note I717] bigbiff:
I need to get around to compiling a selinux kernel. What steps have you done so far?
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
The main thing is compiling with an selinux kernel. I worked on my fstab.qcom a little bit but haven't gotten the internal to mount. Other than that it works great! Very responsive. I'll upload my device files tomorrow & link it here for you to checkout.

EDIT: Here is the recovery log from mine if you wish to check it out. I haven't uploaded my device files yet but I still plan on it. Recovery.log
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
If you have this device you can check out my version here. It's named 6.7 but that's my mistake. http://www.androidfilehost.com/?fid=23329332407579429 and here are my device files. The only thing we need to get straight is the internal storage mounting. I appreciate any help and just use the cm-11 kernel to compile. My device files. https://github.com/gimmeitorilltell...mmit/4df14cf50747a438edc63cbca5349d5562915253

Edit: I think I posted the recovery log from my recovery in the link just before this one.
[AT&T Samsung Galaxy Note I717] bigbiff:
Does CM11 use some form of /data/media? Older versions were using a direct partition for internal storage.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
Ya know my github shows /storage/sdcard0 but I believe to get the build I have that works I had it set to /data/media & data/media. I'll check againg & rebuild so you're on the same page as I am.
[AT&T Samsung Galaxy Note I717] disconnecktie:
So you're saying the sd card is ACTUALLY being considered an internal sd card? I've been trying to help him but I don't really understand the partition layout of this device.
[AT&T Samsung Galaxy Note I717] bigbiff:
Built http://techerrata.com/bigbiff/openrecovery-twrp-2.7.0.0-quincyatt.img.tar

Can you test it?
[AT&T Samsung Galaxy Note I717] CalcProgrammer1:
Sure, I'll test it.

Edit...no. It doesn't even display TWRP screen, just the glowy Samsung logo like the stock ROM has when it's booting then boot loops. I flashed by putting the recovery.img in an old version's zip file.
[AT&T Samsung Galaxy Note I717] bigbiff:
Uploaded a new one same link. Thanks for testing.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
I have updated my device files a bit more but I'm not sure if it's 100% buildable from my source yet. I have changed around so many things while working on this project but I'm gonna build again to see where my source stands. I will let you know when it's ready to be replicated Sir. Meantime I posted my build for users but I do want to get this official from here on out. I'm sure you are more familiar with twrp than myself but after working on this, it seems I have learned alot. My latest recovery.log..... Let me know what you think of the log & could you tell me what "memory mount" is, does, or means?
[AT&T Samsung Galaxy Note I717] bigbiff:
I still haven't seen anyone provide me with a source that cm11 on quincyatt is using /data/media.

Can you try the build I posted just before?
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
That build just bootloops showing the samsung logo in blue. It's over 10MB, why such a big file? Did you compile using my latest source? I just built & it is 9MB. I can't test it yet, gotta boot up windows to Odin a recovery back. The phone doesn't boot into the sytem or recovery, just download mode.
[AT&T Samsung Galaxy Note I717] bigbiff:
I was just trying my own device configs. What I will do since you have the phone, is fork your device configuration files and post them up at our github. But first I will wait for your test of your new image.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
The new recovery is just not mounting usb currently. I'll have this fixed up soon enough tho and post. I mean currently anyone can compile a working twrp from my source. It just isn't 100% functioning at this very moment, aside from the usb mounting, all is well. If you want to wait until it is 100% then I'll let you know when it's ready. I only have one extra mount point that I have no idea where it is coming from. Would you like a screenshot?
[AT&T Samsung Galaxy Note I717] bigbiff:
Does the cm kernel have ums enabled? Also I can look at your screenshot.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
I'm not really sure if it has ums enabled or not but usb mounts fine in my earlier builds. Do you know what this extra "Internal Storage " on the top line would be by looking at my device files?
[AT&T Samsung Galaxy Note I717] bigbiff:
I would take out https://github.com/gimmeitorilltell...msm8660-common/blob/ck44/BoardConfigCommon.mk

the RECOVERY_SDCARD_ON_DATA := true

or remove Internal Storage from twrp.fstab

Looks like it's pointing to the same place because of the size? What does df look like in TWRP?
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
That sounds logical to me. I'll give it a try. Actually the size has changed as that was an older pic now that I look at it. At any rate I'll make clean & compile again to post the results. I appreciate your help so we can get things properly working. USB mounting path is not described in my twrp.fstab but it is in the fstab.qcom. I assume that it needs to be in the twrp.fstab as well? I really have no idea how to set that, would you have any indications on how to set it? It seems like the fstab.qcom is useless once recovery finds it & renames it to use the twrp.fstab.
[AT&T Samsung Galaxy Note I717] bigbiff:
UMS is specified in BoardConfig or BoardConfigCommon.mk in your case:

I think you need something like 129 in https://github.com/agrabren/android_device_htc_shooteru/blob/master/BoardConfig.mk

I can't figure out why it's not in my device config at github.
[AT&T Samsung Galaxy Note I717] gimmeitorilltell:
It's in my boardconfigcommon.mk file listed under #Vold. Maybe I need to place it with the #Twrp settings, is this what you're thinking? Line 69 in the boardconfigcommon.mk
[AT&T Samsung Galaxy Note I717] bigbiff:
Guess I missed it in your github. Does twrp modify the files properly for the devices?