yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Tab Plus] Itaintrite:
With WiFi working perfectly, I think it's time to flash CM9 onto my tablet. Don't need Bluetooth.
[Samsung Galaxy Tab Plus] bwtl1000r:
Any chance for a 6210 build? I haven't been quite so excited about my tab in a while.
[Samsung Galaxy Tab Plus] DebauchedSloth:
6210 build...please!
[Samsung Galaxy Tab Plus] prmax:
Another P6210 pretty please with Cinnamon sugar on top :fingers-crossed:
[Samsung Galaxy Tab Plus] fefopumper:
This last build will be compatible with the p6210, for now is wait for this build.
[Samsung Galaxy Tab Plus] aorth:
Yeah, the P6200 build uploaded a few hours ago, but I accidentally deleted it. I'm sending it again now (on my crappy Internet connection) :)

Cool, it would be nice to have help. :)

Yes. I ALWAYS upload P6210 builds. Especially now that wifi is working. :)

Yep. :)

Yep. :)

It always was compatible, wifi just didn't work. ;)
[Samsung Galaxy Tab Plus] fefopumper:
Thanks for this man...You're great....
[Samsung Galaxy Tab Plus] DebauchedSloth:
Thanks! Can't wait! :)
[Samsung Galaxy Tab Plus] fefopumper:
This new build have 84.3MB...Is Correct aorth??

Thanks again man.
[Samsung Galaxy Tab Plus] BRG:
6210 wifi not working?
[Samsung Galaxy Tab Plus] ColMustard:
Because he hasn't uploaded it yet, your probably using July 13th build, correct?
[Samsung Galaxy Tab Plus] BRG:
Yes...

thanks i will wait
[Samsung Galaxy Tab Plus] fefopumper:
I think the upload is broken again xD
[Samsung Galaxy Tab Plus] aorth:
Yeah, wait till I say "go" ;). I'm rsyncing to the download server... it's going slowly because I have crappy net at my house. The final size will be ~128 megabytes, like it always is.

If you are impatient (or I go to sleep), make sure the md5 is:

[aorth@ndechu: ~]$ md5sum cm-9-20120715-UNOFFICIAL-p6200.zip
b7c9d70df09ecc480775290a91021b18 cm-9-20120715-UNOFFICIAL-p6200.zip

edit: Download link for P6200 (wifi working): http://goo.im/devs/aorth/roms/p6200/cm-9-20120715-UNOFFICIAL-p6200.zip

Wipe before, and check the hash after downloading!!! P6210 now on the way... give it a few hours. :) I'll do a proper post once they both get there, and maybe after I wake up. :)

edit 2: regarding wifi, it works, but it's a bit iffy. Give it a minute or so to turn itself on and off, it will connect. Don't worry. ;)
[Samsung Galaxy Tab Plus] gingerboy92:
i see, you guys fixed the wireless problem! congrats and good work! too bad i already got tired of waiting, i gave the tab to my lil sis and bought a nokia x1. it rocks! good job guys!
[Samsung Galaxy Tab Plus] Rozao21:
I'm trying to use the Heimdall, but I can not, I do not have the file PIT.

Can anyone teach me how to use? I have to enable the Partitions?
[Samsung Galaxy Tab Plus] cdrom1028:
It would probably be best if we all cool our jets and let aorth update the OP when he is ready. All of us GT-P6210 owners are in the same boat. Finally now we are seeing it come to port. Be sure to say thanks to aorth, moblix and all the other devs who have gotten us here. Very soon we get our tasty ICS too!!
[Samsung Galaxy Tab Plus] gingerboy92:
you can sort of 'download' the pit file from the tablet from the "Utilities" tab. click detect, then click save as, save it with the name that you want, and then click download.
[Samsung Galaxy Tab Plus] Rozao21:
I try this, and:

Initialising connection...

Detecting device...

ERROR: Failed to access device. libusb error: -12

What should I do? :(
[Samsung Galaxy Tab Plus] aorth:
You don't need a pit to flash if you use the command line one. Heimdall downloads it on the fly :)

Try restarting Download Mode and replugging your device. If Heimdall attaches and detaches the device won't work in download mode again until you restart it.
[Samsung Galaxy Tab Plus] gingerboy92:
did you installed the driver first, inside the Heimdall suite folder, there's one folder named Drivers, open it, and launch zadig.exe. Select "Options" and check list all devices. From the drop down menu, select the right device, there should be 2 of them, both with the same name, look at the driver name, select the one that doesn't have the word modem in it. then select WinUSB (v6.1.7600.16385) in the box that the green arrow is pointing to.

sorry for my bad english. ;p

true, the easiest way is to use the command line but on windows, we still need to install another driver to use heimdall, it's a messy task!
[Samsung Galaxy Tab Plus] Rozao21:
same error :crying:

How do flashing using a command line?
[Samsung Galaxy Tab Plus] mobilx:
@aorth @loccera There is an old wpa_supplicant in new builds! Replaced with the samsungs one and wifi/dhcpcd works well.
[Samsung Galaxy Tab Plus] k_t_b:
For the time being, could you please attach the new wpa_supplicant to a post so others can replace it in the new builds? (It can be simply swapped out, right?)

Thanks!
[Samsung Galaxy Tab Plus] fefopumper:
The wifi still broken for me...Somebody have the issue too?
[Samsung Galaxy Tab Plus] mobilx:
Its file from the ICS stock;)

View attachment wpa_supplicant.rar

unrar

adb push wpa_supplicant /system/bin/wpa_supplicant

chmod 755 /system/bin/wpa_supplicant

or just use root explorer.
[Samsung Galaxy Tab Plus] aorth:
It's not old... it's from CyanogenMod. :)

But wow, DHCP works immediately if you swap out the CM one for the one from XXLQ1. That means Samsung did something special... unfortunately we can't hack that into the CM build system!!
[Samsung Galaxy Tab Plus] Rozao21:
aorth, I installed the CWM garyd9, version 5.0.2.7. I get flashing with this version?
[Samsung Galaxy Tab Plus] aorth:
Yes, that one will work. :)
[Samsung Galaxy Tab Plus] Rozao21:
aorth, the image of the cyanogenMod should be flash by Heimdall, or can I use CWM> apply update from external storage?
[Samsung Galaxy Tab Plus] aorth:
P6210 build with wifi

Ok, last post before bed: P6210 build is on its way to the server... it should be available here in an hour or two: http://goo-inside.me/devs/aorth/roms/p6210

... and have the following hash and file size:

[aorth@ndechu: ~]$ md5sum cm-9-20120715-UNOFFICIAL-p6210.zip
9b2bfe1de2f05cd37088bd154990c877 cm-9-20120715-UNOFFICIAL-p6210.zip
[aorth@ndechu: ~]$ ls -lh cm-9-20120715-UNOFFICIAL-p6210.zip
-rw-r--r-- 1 aorth aorth 126M Jul 15 22:22 cm-9-20120715-UNOFFICIAL-p6210.zip

If those are not the case, then the ROM is NOT finished uploading. I'm sleeping now, so there's nothing I can do until I wake up. :) Be patient, and enjoy!
[Samsung Galaxy Tab Plus] Rozao21:
guys, how do I install the CyanogenMod images? Should I put the sd-card and install by cwm?
[Samsung Galaxy Tab Plus] KazeOne:
I have read the last 8 pages and its awesome to see CM9 coming to the P6210, so everything is now working and its a fully functional rom? does this include the IR Blaster? as that is why I bought the P6210. Thanks for your hard work, thank you everyone that has helped in this port.
[Samsung Galaxy Tab Plus] locerra:
Everyone, please see this post about wifi.

No, everything is not working: Bluetooth and auto-brightness are a no go.

IR Blaster won't really work until there is some ASOP app for it -- Samsung's app won't work because it relies on their Touchwiz framework, which is not included in CM9 (and is also the reason why stock ends up being so laggy despite the power of the hardware). I also don't think the kernel driver is enabled -- there were some issues with it on the old kernel, but it may work better with the new kernel, haven't tried yet.
[Samsung Galaxy Tab Plus] KazeOne:
okay so Im better off waiting for the ICS update from Samsung then that hopefully we should be seeing some time next week. Bummer but hey good work just the same.
[Samsung Galaxy Tab Plus] fefopumper:
This hotfix for p6800 wifi works on p6200 too?
[Samsung Galaxy Tab Plus] locerra:
Yes.
[Samsung Galaxy Tab Plus] Rozao21:
locerra, help me!

How to flash image? CWM or Heimdall?
[Samsung Galaxy Tab Plus] Rottgrub:
Looks like the wpa_supplicant from P6800 differs from what mobilx posted for the P62x0. It may not make a difference, but I used the update.zip from Iocerra, and swapped in the wpa_supplicant from Mobilx.

Iocerra MD5: 423af61dd6846899dd9fa9444f5b3bd3

Mobilx MD5: 2df5dd222430fd653a2ecdfb0d0820ad

Attached in case it's useful for anyone.
[Samsung Galaxy Tab Plus] Rozao21:
I installed new build and the file attached, and it worked!

CyanogenMod P6210 with wifi working!

:p:D:D:D
[Samsung Galaxy Tab Plus] KazeOne:
guys hes uploading a p6210 build that has working wifi, I would check back tomorrow for that build.
[Samsung Galaxy Tab Plus] k_t_b:
It's working great on my GT-P6210 also.

My nipples are so hard right now. :)
[Samsung Galaxy Tab Plus] DebauchedSloth:
Same here, all around.

Got it, installed it, this thing simply rocks. So much smoother and faster, there is just no comparison. WOW!

:laugh:
[Samsung Galaxy Tab Plus] morfini:
I am stack on screen with cyanogen logo and 3d animation on p6211 for about 10 minutes now. I guess something went wrong
[Samsung Galaxy Tab Plus] fefopumper:
this hotfix works for me too...Thanks Guys...xD
[Samsung Galaxy Tab Plus] DebauchedSloth:
I was stuck here until I remembered to wipe data.

Also forgot to apply google apps, but that didn't stop me from booting...
[Samsung Galaxy Tab Plus] soopermarkus:
Just installed the working wifi build. I don't think changing the home screen grid dimensions is working. Soooooo much snappier than stock ROM.

Sent from my GT-P6210 running CM9 7/15 build.
[Samsung Galaxy Tab Plus] Rozao21:
Where's the icon of my files?
[Samsung Galaxy Tab Plus] hlb3:
Working perfect on my 6210! So happy to finally have CM9 working on there, and to finally be able to use Apex as my launcher.
[Samsung Galaxy Tab Plus] k_t_b:
Here is a mirror for the latest P6210/P6210L/P6211 build (20120715)

cm-9-20120715-UNOFFICIAL-p6210.zip

http://www.freefilehosting.net/cm-9-20120715-unofficial-p6210

And here is a mirror for the latest P6200/P6200L/P6201 build (20120715)

cm-9-20120715-UNOFFICIAL-p6200.zip

http://www.freefilehosting.net/cm-9-20120715-unofficial-p6200

I've never used this hosting site before, so the speed/reliability might not be great. It uploaded quickly.
[Samsung Galaxy Tab Plus] morfini:
I have a boot loop on p6211. I did a data-factory reset, so i guess is the cwm version i have. Can someone provide me cwm recovery 5.5.0.4 zip or tell me how to flash the 5.5.0.4 img i downloaded?

Edit: Never mind, everything works fine now.
[Samsung Galaxy Tab Plus] Rozao21:
Where's the icon of my files????? I can not take the shortcut!!!
[Samsung Galaxy Tab Plus] Macros617:
This has the wifi fix built in?
[Samsung Galaxy Tab Plus] k_t_b:
Sort of... You still need to replace the wpa_supplicant with the one that has recently been posted.
[Samsung Galaxy Tab Plus] Macros617:
Got it all installed. I'm amazed at how this breathed new life into my tablet. I was almost considering buying a Nexus 7. Thank's so much aorth. :good:
[Samsung Galaxy Tab Plus] morfini:
The from is very smooth and the speed is incredible. One problem though, how can I install play store?
[Samsung Galaxy Tab Plus] eddiecsilva:
awesome!

I'm using build 20120715 for P6210 and no need to install any fix.

Wifi is working perfectly, GPS, cameras, sound, everything seems to work.

I noticed that the Cyanogen could not make sync of my apps - and AppBrain is also not able to install apps automatically.

The overall performance is great, but have not had time to test any heavier app or a game.

I noticed that when I leave the light on the automatic setting, the screen tends to get very dark - I'm using with manual adjustment.

The "H" for hours on the clock seems to be disproportionate to the rest of the numbers.

So far the only FC was with Chrome.

Time to go to bed.

P.s.: not tested bluethoot
[Samsung Galaxy Tab Plus] Macros617:
Did you install the GAPPS package? It's on the first page.
[Samsung Galaxy Tab Plus] blinksilver:
so the dpi is set to 160 instead of 170? is there a reason for this?
[Samsung Galaxy Tab Plus] k_t_b:
160 is the default for this device.
[Samsung Galaxy Tab Plus] jbzcar:
Amazing work! Just loaded the wifi build onto my 6210 and am up and running. Pretty smooth, not quite as snappy as it was with Gary's kernel, but I will take CM9 over Honeycomb any day.

Any word on overclock kernels for CM9?
[Samsung Galaxy Tab Plus] aorth:
I just changed my grid from 4x4 to 5x5. Are you sure you did it right? Settings -> Launcher -> Homescreen?

Download one from the Market, like SolidExplorer or Open Intents File Manager. CyanogenMod doesn't come with one.

Flash the "gapps" zip linked from the first post.

Yeah, wifi works without the "fix", but the "fixed" one just works better. Regarding bluetooth, it doesn't work in this build, so no use testing. Auto brightness doesn't work. I said that already. ;)

There's no overclock kernel because you didn't make one yet. You're welcome to volunteer though ;)
[Samsung Galaxy Tab Plus] blinksilver:
1024x600@7 inches is 169.XX off the top of my head. That's so weird of samsung to choose 160. Perhaps it has to do with the phone/tablet auto "context" shift?

In an unrelated turn of events, I copied all the bluetooth related stuff from the offical ICS over see if it some help the bluetooth situation, it didn't. But it might have fixed the ambient light sensor? It was probably working the whole time, just the configuration is off or something? Hold device up to light bulb and bam the screen gets brigher.
[Samsung Galaxy Tab Plus] Justinhopaolo:
Hi I've read in the last 5 pages that this rom has a working wifi now, I'm using a stock p6200. I'm not new to loading new roms in a device, I would just like to ask if it is possible for me to just load this rom from stock baseband, kernel etc.?

PS your replies would be great to help out others who have the same questions :-)

Also I can't wait to have a confirmation from you guys, I want this rom :-)
[Samsung Galaxy Tab Plus] mobilx:
The ambient light sensor works but it reads only three values 12, 120, 1200 lux. Im not sure thats enough to work properly. Someone on stock should read those values with i.e. Androsensor apk so we can adjust ours.

Sent from my GT-P6200
[Samsung Galaxy Tab Plus] miksumortti:
Stock measures 12, 120, 1200 and 12000 lux. Just tested with androsensor and flashlight. For 12000 lux the flashlight needs to be very close.

Sent from my GT-P6210
[Samsung Galaxy Tab Plus] bdds13:
So besides the partitions, what else would be needed to get this to boot on the p6210?

I'm also interested in helping. I had been trying to use the samsung galaxy tab 7.7 cyanogenmod device tree, but I kept getting lots of errors while compiling. I got the whole android ndk set up, sdk and I can pull the p6210 proprietary files. I'm new to the whole rom compiling stuff, but I'm pretty confident that I am able to do what is needed with just a little guidance
[Samsung Galaxy Tab Plus] locerra:
I've quickly thrown together a p6210 device tree:

http://github.com/ohanar/android_device_samsung_p6210

Can't really test though since I don't have the device (just have my Tab 7.7), but I figured I would get it started for anybody interested in working on it.
[Samsung Galaxy Tab Plus] k_t_b:
Awesome, Thank you.
[Samsung Galaxy Tab Plus] Ceelos09:
Very much appreciated sir! Might have to dig my hands in it soon :D
[Samsung Galaxy Tab Plus] kmmxracer:
NICE, I will have a go at this today for sure
[Samsung Galaxy Tab Plus] aorth:
Did anyone have a go at building/flashing this for the GT-P6210? If you get it running and want to start an XDA thread, just let me know. I'll give you my formatting if you want (it's a pain in the ass to write BBCode). hahhaah
[Samsung Galaxy Tab Plus] Ceelos09:
I'm actually getting my build environment and git set up at the moment. CyanogenMod's ~6gb repo is what will set me back a bit since it a descent sized download. I'll let u know if/when I get this sucker booting :)
[Samsung Galaxy Tab Plus] kmmxracer:
Mine is building right now. So far so good, no errors. Hope it will boot when it's bakedb:D

I'm on the CM boot animation..... don't know if its gonna boot???

edit:

Not Booting

logcat says:

W/IMediaDeathNotifier( 3376): Media player service not published, waiting...

W/AudioSystem( 3376): AudioPolicyService not published, waiting...

I/ServiceManager( 3376): Waiting for service media.player...

I/ServiceManager( 3376): Waiting for service media.audio_policy...

I/ServiceManager( 3376): Waiting for service media.player...

I/ServiceManager( 3376): Waiting for service media.audio_policy...

I/ServiceManager( 3376): Waiting for service media.player...

I/ServiceManager( 3376): Waiting for service media.audio_policy...

I/ServiceManager( 3376): Waiting for service media.player...

I/ServiceManager( 3376): Waiting for service media.audio_policy...

I/ServiceManager( 3376): Waiting for service media.player...

I/ServiceManager( 3376): Waiting for service media.audio_policy...
[Samsung Galaxy Tab Plus] PandaHandz:
Awesome! Glad to see we dont have to wait for ol'Sammy to bring us our ICS!
[Samsung Galaxy Tab Plus] Ceelos09:
Dang...bummer :\

I'm still a bit far from actually getting completely set up but this not booting is a def disheartening :(
[Samsung Galaxy Tab Plus] kmmxracer:
Well its a good start for sure, non-boots + logcat just means more to learn about the device and more to learn about building.

I'm pretty sure we won't get to far with out some good kernel support from Samsung, but o well.
[Samsung Galaxy Tab Plus] locerra:
To get it to boot you need to add the fixes I added at github.com/ohanar/android_frameworks_base (this doesn't fix audio, only fixes it enough to boot). Specifically, you need this change.
[Samsung Galaxy Tab Plus] kmmxracer:
Do i clone this in, & where or what should i do with it
[Samsung Galaxy Tab Plus] locerra:
I just uploaded to cm code review, so to add fixes do (in the root of the cm source tree)

cd frameworks/base && git fetch http://review.cyanogenmod.com/p/CyanogenMod/android_frameworks_base refs/changes/44/14544/1 && git checkout FETCH_HEAD && cd ../..
[Samsung Galaxy Tab Plus] kmmxracer:
Just got home. I'll try this out. Thanks

edit:

ok, just started another build
[Samsung Galaxy Tab Plus] kmmxracer:
OK got it booted!!!!! :D:D:D

Big THANKS to:

-bdds13

-locerra

-aorth

@aorth I'm gonna PM you so we can get this up on it own thread for the GT-P6210
[Samsung Galaxy Tab Plus] aorth:
I just added a comment on gerrit. Teamhacksung gave me a similar fix last week: https://gist.github.com/2318183

For shizzle. How do you feel to be the first person in the world to have ICS on a P6210? I guess Samsung probably does too, but you know... hahaha. Checking PM nowwwww.
[Samsung Galaxy Tab Plus] cbuy:
P6200L ?

Hey aorth ! Great job !! Thank you for that, I was starting to feel lonely with GB in my GTP. Just two questions:

1) Mine is P6200L. Will this work ?

2) How do I flash the recovery ? Will this recovery work on the P6200L ?

Keep your great effort !!
[Samsung Galaxy Tab Plus] aorth:
I think it should work. Can you get me the output of `adb shell mount`? We need to see if the partitions are the same for /system, /data, etc...
[Samsung Galaxy Tab Plus] cbuy:
Ok

Ok, I'll get to that ASAP. Please answer question (2) about recovery. I want to flash CWM to backup original ROM...
[Samsung Galaxy Tab Plus] locerra:
This is because of the crappy sensors hal that Samsung wrote. The exynos based phones suffered from this same issue until very recently when some devs finished up an open source hal. Almost all our sensors are different from the exynos phones, so we still are stuck with the crappy hal for now -- means autobrightness won't ever be great, but we hopefully will get something better than what we have currently.
[Samsung Galaxy Tab Plus] Justinhopaolo:
Hi can i flash this rom from stock p6200? With stock baseband kernel etc
[Samsung Galaxy Tab Plus] aorth:
Stock actually measures up to 16000, but you have to be standing on Venus (or somewhere closer to the Sun!). Also, the 12, 120, 1200, 12000 measurements come from the Honeycomb sensors library; the ICS XXLQ1 sensors report 7, 70, 700, 7000, 16000. I've decompiled the stock framework and copied the autobrightness settings to CM, and I think the results are decent.

See this commit I made yesterday: https://github.com/alanorth/android...mmit/67d17e8c546c95283eec91c5309c365c3d1410c7
[Samsung Galaxy Tab Plus] cdrom1028:
WoW, Great start! Finally I get to put my GT-6210 through its paces on this ROM here are some findings:

WiFi, Yes it does work however, I tested 7 diff routers/APs and many WiFi encryption profiles (this is my real day time Job) and the tab would not connect to most of them, However the Patch worked perfect in almost all situations.

I get FC closes with Chrome when going into settings.. every time.

Very Limited Battery life.. 4 hours ..

We still have the deal where the sdcard is mapped to emmc is there any work around for this?

Overall this is really awesome! fast, smooth, mostly stable, really great! I can wait a little while for BT and IR, with the OEM version to be out any day, and source soon to follow I think we are in a really good place! Thanks for all the effort!

Update: I spent 12 hours at work today with no charger, I had 31% bat when I got home. I can live with that.. :-)
[Samsung Galaxy Tab Plus] Rozao21:
Task manager too?
[Samsung Galaxy Tab Plus] robyr:
Why are you even looking at AOSP ROMs in the first place if you want everything the OEM distribution offers? Just stay stock man.
[Samsung Galaxy Tab Plus] MrNo:
After installing the wi-fi fix, I can report that the wireless connection has been working great. Before the fix, i could only connect to one out of tree routers. As cdrom1028 said, Chrome FC's as soon as you try to open the settings. Other then that the ROM is super quick. It boots at least 2-3 times faster then on honeycomb. Great work, Thank you
[Samsung Galaxy Tab Plus] Giogts:
alan thanks for all!!!

I have a u8150 ideos with your cm7...

and now i take a p6200!

official ics work great, so can you build a cm10 tree?

sure samsung don't make a jelly bean release for our tablet!
[Samsung Galaxy Tab Plus] prmax:
Anyone has another link since the one posted on page one is not connecting. Thanks.
[Samsung Galaxy Tab Plus] Rozao21:
Dude, do not happen to not get roms, I'm just taking my questions.
[Samsung Galaxy Tab Plus] blinksilver:
Not that these are really killer in any meaningful way, but its worth mentioning for postarity:

1)The notification drawer "LED flashlight" toggle does not work.

2)The "Edit other settings" in the Display>"Automatic backlight" drill down causes an FC.

And in courterpoint to what other's have been saying hereto, chrome works just fine for me.

Also, this rom is magic.

EDIT:the LED flashlight may not be broken, I realized I accidently removed the torch app.
[Samsung Galaxy Tab Plus] pintunoor:
ICS at last for GT P6210

Samsung start Android 4.0.4 updates Galaxy Tab 7.0 Plus WIFI

http://www.sammobile.com/2012/07/16/...7-0-plus-wifi/
[Samsung Galaxy Tab Plus] jbzcar:
That is, unfortunately, outside of my skill-set, lol. The best I can do is some mean 7-zip work. :p
[Samsung Galaxy Tab Plus] aorth:
P6211?

Has anyone successfully booted this on a P6211? I have at least one report that it doesn't work... so if I get more reports of that I'll remove the support until we can figure it out properly.

Regarding the download links (for the ROM as well as gapps), goo-inside.me had an issue in their data center for about 12 hours yesterday/today. It's back now.
[Samsung Galaxy Tab Plus] KazeOne:
With ICS now out for the P6210 does that mean you will be able to get the IR Blaster to work now in CM9? If not no worries I will just stick with Sammy ICS rom.
[Samsung Galaxy Tab Plus] aorth:
Hahah probably not. First, it relies on kernel stuff I'm sure, as well as a user-space application which we don't have. Second, my P6200 didn't come with one, so I have no idea how it works. :)

Sounds like a "no" to be honest... unless you start devving :)
[Samsung Galaxy Tab Plus] KazeOne:
I would love to dev but I dont know where to even begin to start learning ^^;; any pointers would be welcomed :)