yashsingh1/xdaforums huggingface dataset:
[LG Optimus 2x] tonyp:
PDroid only blocks privacy relevant permissions.

This is the complete list of permissions PDroid accesses:

Device ID (IMEI/MEID/ESN)

Subscriber ID (IMSI)

SIM serial (ICCID)

Phone and mailbox number

Incoming call number

Outgoing call number

GPS location

Network location

List of accounts (including your google e-mail address)

Account auth tokens

Contacts

Call logs

Calendar

SMS

MMS

Browser bookmarks and history

System logs

SIM info (operator, country)

Network info (operator, country)

If you compare that for example to the list of permissions to the app you mentioned, you'll see that the only privacy relevant permissions are SIM & Network info.
[LG Optimus 2x] pastime1971:
a brief explanation at http://xdaforums.com/showpost.php?p=31525268&postcount=662
[LG Optimus 2x] tftd:
It seems I've sinstalled the patch in a wrong way. When I used auto_patcher the first time (for some reason) it didn't create update.zip and restore.zip so I thought I had to install the cm-10-20120919-NIGHTLY-i9100.zip file again. Anyway after patching it again and installing the update.zip everything worked like a charm.

Thanks for the help! :)
[LG Optimus 2x] curtisf08:
Hi anychance you could share your pdroid.zip for cm10 i9100 pls
[LG Optimus 2x] jpeg725:
Won't compile on cm10 for ZTE blade

KonstaT's ROM for the ZTE blade does not indicate ro.telephony.ril_class= in build.prop

I guess it must just be using RIL.java alone.

The CPU is a Qualcomm device so QualcommSharedRIL.java might be needed too. Anyone know anything about that?

EDIT: I deleted all RILs except the two mentioned above and the telephony seems to work. I'm guessing that the telephony RIL stuff deals with calling and sending/receiving SMS's. Am I wrong?
[LG Optimus 2x] jpeg725:
System messages

The pdroid patches seem to mess with some system messages. At least it does in CM10 with French(France) as the system language.

When plain CM10 boots it says "Carte SIM vérrouillé" (or something sensible like that). Then I flash my self compiled pdroid framework bits, it says "La carte SIM est vérrouillé par clé PUK." So I put in my normal PIN code and everything is fine. The message is wrong.

When it rebuilds the dalvik cache it says "L'application %1$s (du processus %2$s) a enfreint..."

Other than some message mistakes everything seems to work absolutely fine. Does the same happen in english?

Just for info.

I am running KonstaT's cm10 built specially for the ZTE blade, build 2012-09-15.

I downloaded the cm10 source, applied the ZTE patches and the pdroid patches - no conflicts there apparently.

I deleted all the RILs except the two I mentioned in my previous post

I did a make framework core services framework2

Then I flashed all the files that got built into /system/framework/

Those files are: core.jar framework.jar framework2.jar framework-res.apk services.jar

It seemed better to me just to copy the lot, though it probably isn't necessary.

And finally I rebooted.

The pdroid app is happy and everything seems to be going fine apart from the mixed up messages.
[LG Optimus 2x] switchgott:
Is it realy so??

+ for (int i = GET_COMMAND_WAIT_MS; (proc = freader.readLine()) == null && i >= 0; i-= GET_COMMAND_WAIT_STEP) {

After i do this, the build never work :(
[LG Optimus 2x] organophosphate:
Am I the only one experiencing issues with the PDroid apk on Jelly Bean? I obtained the relevant PDroid apk from the official PDroid thread, but when launched it displayed a dialog informing me that it only supported Gingerbread (and then terminated).

After searching for quite some time I concluded that there wasn't any updated version available that did not exhibit this issue on my device. Therefore, it seemed like modifying the apk was the only solution; I changed the version check in the disassembled apk smali and deployed it.

Everything seems to be working fine now--both the apk and the PDroid patch on AOKP JB build 3--but if there is a more "official" JB apk available I would prefer to use that.

Perhaps there is something obvious that I am doing incorrectly to deviate from the expected result. It seems unlikely that I would be the first to notice something overt like this if it were the typical behavior of the apk.
[LG Optimus 2x] pastime1971:
it sounds like framework-res.apk is not matching.

have you tried to build the whole rom, not just those 4 ?
[LG Optimus 2x] pastime1971:
great work on the apk.

however, the original apk works fine on ICS and JB if PDroid is working correctly.

therefore, i suspect that PDroid is not really working on your rom.

can you block some permission and see if you get the expected result ?

for example, i used to block location permission for G+ app, and check nearby.

be aware that google map is a tricky one, and will find your location at any possible way. so not a good test.
[LG Optimus 2x] wbedard:
This is a question for all the DIY types using PDroid with bleeding-edge ROMs.

For background, I recently compiled the JRO03R branch of AOSP and assembled it into my first home-brewed ROM. I patched it for PDroid using v2.1.1 of the autopatcher and have been running it for nearly a week on my Nexus7. Surprisingly, everything seems to be running great with no functionality bugs detected at all.

My question has to do with a subtle change I have observed with the PDroid app. I would like some advise on how to determine if this is caused by some aspect of how I built the ROM or by perhaps some change in that branch of AOSP.

While PDroid appears to operate correctly in every other respect, it is not displaying the "System Logs" permission in those apps that use it. For an app that does use this permission, if I block everything that PDroid displays, the "stoplight" color for that app will be yellow and it will have the "Custom" label displayed beside the app name.

Feel free to request any other details that I may have left out or to suggest any thoughts about tests I could perform to help narrow down the cause. Thanks in advance!
[LG Optimus 2x] pastime1971:
mateorod had raised similar point before.

it may be possible that "system log" capability of pdroid could be buggy.

i have not investigated this myself thoroughly though.
[LG Optimus 2x] wbedard:
Hi pastime71!

Just for my clarification, are you saying that the bug is possibly in the PDroid app, rather then in the patches applied to AOSP?
[LG Optimus 2x] pastime1971:
possibly in the patch, i tihnk...
[LG Optimus 2x] wbedard:
Hmmm, interesting. Maybe this is the excuse I need to look at your patches against the changes in the AOSP branches. It'll be slow going for sure so please do pipe up if you uncover anything related to this issue. Thanks for the quick replies!
[LG Optimus 2x] pastime1971:
sure.

btw, what do you mean by "changes in AOSP branches" ?
[LG Optimus 2x] pastime1971:
it makes more sense, and it seems to work fine on ICS.

otherwise, i = -GET_COMMAND_WAIT_STEP will make i negative and exits the loop after the first iteration (assuming GET_COMMAND_WAIT_STEP is a positive number)
[LG Optimus 2x] organophosphate:
Thanks for your reply. As for the original APK working fine, I suspected as much given the distinct lack of complaints from others.

After several cycles of applying the PDroid patch, testing with the official apk, uninstalling, then installing/testing my modified version, unapplying the patch, testing again, etc. I'm reasonably confident that I know what happened.

Firstly, the warning in the PDroid apk about it only supporting Gingerbread appears to be a surrogate error for the PDroid patch not being found. However, despite this, there is another, explicit "PDroid patch is missing" warning that will pop up if the first dialog warning is suppressed (ie. even in the version of the apk that I modified).

So, I believe the PDroid patch that I installed wasn't actually correctly/fully applied. I hesitate to make allegations, but this wouldn't be the first time I had a flashable zip installation go awry in TWRP. Perhaps it was my error when I applied the PDroid patch in TWRP originally, but I'm pretty good about checking for success/failure messages before proceeding.

Anyway, the patch is applied correctly now. Both my modified APK and the official APK work correctly when testing with apps (unsurprising, given the one-line change). So, I uninstalled my version and am just using the official one.

Thanks again.
[LG Optimus 2x] wbedard:
Oh...I just meant the various changes in the AOSP source code from release to release (i.e. JRO03C to JRO03D, for instance...). Calling them "branches" was probably using the wrong term.
[LG Optimus 2x] jpeg725:
I suppose I ought not to have flashed framework-res.apk along with the rest.

Can I check I have understood properly?

The framework patch modifies only stuff that ends up in framework.jar,

framework2.jar contains nothing useful to pdroid.

So the only things that need flashing are : framework.jar, services.jar, core.jar

Might it be a good idea to flash framework2.jar just to be sure that there isn't some overlap between them?
[LG Optimus 2x] pastime1971:
correct.

you can flash framework2.jar. but i compared decompiled framework2.jar w/ and w/o pdroid and there is no change at all.
[LG Optimus 2x] Kiwyxda:
Hello it's sush a great work you do,

I'm using autopatcher to patch pdroid on cm10 on my xperia pro mk16i, but when I want to limit acces to localisation to browser or google maps it just doesn't work at all.

I'll post it also this in the autopatcher thread as I don't from where it come from.

btw you do such a great job please continue that way
[LG Optimus 2x] pastime1971:
thanks.

i haven't tested web browser myself, but i do know that google map is stubborn, and it will find your location at any cost.

g+ or news&weather behaves as expected though.
[LG Optimus 2x] alroger:
Sniff sniff, same here, CM10 for the SGT7 (p1). :crying:
[LG Optimus 2x] romracer:
I think the proper fix is:

Replace the return line in the ContextImpl.java hunk that fails (using the new Context provided instead of getOuterContext):

return new PrivacyLocationManager(service, ctx);

Replace the super call in PrivacyLocationManager.java:

super(context, service);

This at least compiles. Not fully tested since my compile is not quite finished.
[LG Optimus 2x] mateorod:
I hadn't seen this or I would have tried it, thanks romracer. I was sent a fix by CollegeDev this morning. A user greenblue also posted the edits for ContextImpl.

I have it working, I will send pastime1971 the new patches once I put them all together and he can update the OP.
[LG Optimus 2x] cliff03:
just trying to make patch for ReVolt 2.5 where do i need to paste this download # Jellybean

Download : PDroid source code patch v1.32 for ICS AOSP 4.1.x, http://www.mediafire.com/?cxe43zko42io4d6 (needs to split framework.jar into two files)

Thanks
[LG Optimus 2x] xtrezpasor:
Anyone help me patch http://xdaforums.com/showthread.php?t=1748818 freegs3 rom? Id love to get pdroid to work but I feel like a total noob...

Thank You
[LG Optimus 2x] mateorod:
Hey, I meant to post this forever ago, so tonyp, alroger, anyone who has been struggling with broken patches- my bad.

If it is any consolation, I actually didn't make working patches until pretty recently myself, and was manually checking in changes, like a dummy.

Anyway, these work for 4.1.2 in all of it's various flavors, tested on AOSP, AOKP, Cyanogen and ParanoidAndroid by me personally.

@poncik

-The person posting above me quoted the entire first post, so I won't reiterate it, since it is still very valid. The thing to check is does Evervolv have a framework2.jar when built? If not, we have to apply some extra patches. If it already has them, then all you need are the three patches listed above.

Patch them just like it says:

cd ~/android/system/build; git checkout -b pdroid; patch -p2 < build.diff

That code presupposes that you kept the patches in the same directory as your source, but you can keep them anywhere. If they were in a folder called 'patches' on your desktop, you would change the command to:

cd ~/android/system/build; git checkout -b pdroid; patch -p2 < ~/patches/build.diff

See? If you have already have a framework2.jar, you will only need the three main patches, libcore, build and frameworks. If you don't, post and let us know and I will give detailed instructions.

Note: The patches say AOSP, but they work on all romtypes, so you're fine no matter the source, generally. If hunks fail, report back and I will probably be able to walk you through that. But that is unlikely.
[LG Optimus 2x] tonyp:
Oh sorry, I fixed the patches for CM10 myself a while ago - but totally forgot to upload them here.

I'm only on the N7 at the moment, but I will post them here tomorrow.

Just in case mateorods version isn't working on CM10.
[LG Optimus 2x] mateorod:
Unless you find an issue with the ones I got up, maybe its best to just have the one set. They're working for all the rom types (confirmed, the auto-patcher patches were built with them) and there is no point confusing people...

Unless you find a mistake I don't know about, that is...I was in the same boat as you. Made working patches and didn't remember until today I never got around to sharing.

But these are made from the same patches I sent you, just with the bugs ironed out. We almost certainly have identical patches, but run a diff if you want to be sure.

Edit: That link to the porn at the end of your sig is broken. I have been meaning to tell you...
[LG Optimus 2x] tonyp:
Sure, good thinking. Will do a diff.

I didn't use your patches because I thought they might produce problems as they're for aosp and not cm. I didn't knew they don't differ.

So I just took the solutions posted either here or in the auto patcher thread.

Anyways, doesn't matter. Gonna check if your patch work for me as well which it probably will.

Thanks!

P.S.: hehe that link got 2248 clicks at the moment :D
[LG Optimus 2x] poncik:
evervolv have framework2.jar but i got new project on my work, need to focus on this now.

thanks for informations, i will let you know when i apply patches and make build.
[LG Optimus 2x] poncik:
applied patches and made build succesfully, pdroid is working without any problem so far. what should i give to you for adding support to autopatcher?

btw, for pd2.0, just apply patches from its own thread and build, right?

thanks for your support.
[LG Optimus 2x] alroger:
SGT7 CM10 working again

Back in business. Thank you.

Patches working on CM10 4.1.2 for SGT7 (p1).

Download link in my sig for anyone interested.
[LG Optimus 2x] ukanth:
Could you publish the files for users ?
[LG Optimus 2x] mateorod:
Shoot, missed this somehow. This was for evervolv, right? Great work, this is a lot to learn.

What we need for patches is fairly easy. Once you make a patched build, back out of the patches (look on pastime's OP, there are easy removal directions) and then build an unpatched build (before you next repo sync.)

Then zip up the frameworks of each (core, services and framework.jar) and post them here or pm me. I will make patches and add you to the contributor list.

Whenever Android makes a big update (for instance, when 4.2 comes out) it is likely that the current patches we make will break, so we will need to audit our build patches, make sure they still work, and then get new patched/unpatched builds. After you have learned how to build the patched rom, the commitment as a maintainer is something on the order of an hour a month. Nothing too strenuous.

As for pd2.0, I am glad you will help us with that as well. I would hate to offer an incomplete rom type. On the Pdroid 2.0 thread, look at my post. I have updated CollegeDev's patches (his had some errors/ redundancies in them) as well as given directions that are more like the ones you used here, and are easier to back out of to make an unpatched build.

If you don't repo sync in-between building your stock (unpatched) build and building for pd2.0, then I will only need the one stock build.

Any questions, you can ask here. Thanks man! Good to have you on-board.
[LG Optimus 2x] poncik:
here it is but i can't guarantee this will work for you because i made build from latest sources. make nandroid before flash.

i tried collegedev's patches, build failed and didnt find a way to remove. tonight or tomorrow i will reset repo then;

1- make unpatched build

2- apply pdroid patches and make build

3- remove pdroid patches, apply your pd2 patches and make build

4- send framework files of this 3 builds to you

thats all, right?
[LG Optimus 2x] mateorod:
Yep. That would be great. The post I linked to has removal instructions for the pdroid2.0 patches as well. If you already applied CollegeDev's posted patches ( i am not quite sure why he hasn't updated the post yet, many people are having the same trouble you are) you may want to try and use the git clean -dx in those projects, just to get rid of the files completely.

Good luck, and thanks!
[LG Optimus 2x] :
*deleted*
[LG Optimus 2x] poncik:
i made builds but pd2 patches gave hunk failed message and i got bootloop after flashed rom.

uploaded all the framework files and console output of patching process, here is the link

http://www.mediafire.com/?yue3j4bzxa4e73n
[LG Optimus 2x] mateorod:
Try replacing the original SMSDispatcher with the attached. Should fix you up. The rebuild won't take very long.

Although I just had my first report of failed Cyanogen patches today. We are due for the 4.2 rollout any minute, which will almost certainly require build from all of our maintainers.

Edit: The report of failed patching for 11/2 was deleted before I got a look at the log, I am guessing user error.

But once you do it once, it is easy to rebuild. Thanks for the pdroid files, I will check them out and make a patch tonight while we eyeball the latest CM merges...
[LG Optimus 2x] poncik:
thanks for fix, pd2 is working now.

waiting for 4.2 and nexus 4 =)
[LG Optimus 2x] fezzawinkle:
Pdroid with ICS stock

Is it possible for someone to make a Pdroid version of the new fixed 0.98 ICS Stock Rom.

I would really like to try it, but the autopatcher wouldn't work would it?

And I am too much of a noob to work how to compile it from scratch.
[LG Optimus 2x] fezzawinkle:
Can someone say whether this is even possible ?
[LG Optimus 2x] mateorod:
You have to build it. Follow the instructions or I guess look for custom rom. But it is possible.
[LG Optimus 2x] fezzawinkle:
I am not sure what instructions you are referring to. It seems that a port was developed for various ics roms but i dont know if there are instructions on how to do it for a new rom ? As this seems to be the onlt reasonable ics rom at the moment it would be great if it could be done. Its beyond me without a lot of pointers. ..
[LG Optimus 2x] mateorod:
The first post in this very thread provide step-by-step instructions to add patches to source code for any ics or jb rom. You will have to find the source code and general instructions on how to build. Once you successfully build, come back here and follow the very clear instructions on the OP here. If you have trouble with the patching process, we can help with that.
[LG Optimus 2x] fezzawinkle:
Thanks. That was what i meant in the first place. I am not even a cook.
[LG Optimus 2x] pastime1971:
PDroid needs a change/addition in framework.jar, etc.

Without an access to a source code, it is very difficult.

This thread is about patching the source code. (for cooks)

There is a thread by mateorod on binary smali patching, but PDroid support is mostly for CM-compatible or AOSP-compatible roms, because PDroid needs a significant change.

i do not know much about NOVA rom that you are using, but the dev should be able to include PDroid if it is based on CM or AOSP (not LG stock unfortunately)

I am P990 user myself, and i am happily using PDroid/CM10 on P990.
[LG Optimus 2x] fezzawinkle:
Thanks, my signature was wrong. I was actually thinking about the stock leaks. When the source code is available for P990, my understanding of what you are saying is that someone might take on patching the source?

Fezz
[LG Optimus 2x] pastime1971:
only if the source is available...
[LG Optimus 2x] tonyp:
LG won't release the source of their framework.

They are only releasing the kernel source, which is of no use in regards of PDroid.

The release of the kernel source is required by the GPL it is licensed with - most other android parts unfortunately are licensed with the Apache license which does not require any source code release.

So no, it's unlikely that we see PDroid on a Stock ROM.
[LG Optimus 2x] alroger:
CM10.1 for the SGT7 p1/p1n/p1l/p1c

Hey guys! Really quiet here after the autopatcher and everything stable.

So, time for CM10.1 (Android 4.2.1). I started building my "unofficial" but as you must know pdroid patches aren't working.

Anyone need any logs or anything? Can't live without PDroid!
[LG Optimus 2x] mateorod:
Several of us who work on and around Pdroid and Pdroid2.0 and Pdroid Manager are beginning to gather our resources and get to work on the port to 4.2. Let me get this in some sort of collaborative shape and I will post again.

I have the 4.1x patches on github, but I don't know if that in and of itself is going to be enough for people to contribute to.

For instance, these are some of the current build errors when sucessfully applying the 4.1 patches to 4.2 source.

When I can think of a way for those interested to contribute, I will post again. We have had contributions from people like romracer make the difference in the past, so I will update this as soon as I decide on the best method. The goal will be to update the Pdroid Core patches as well as Pdroid classic.
[LG Optimus 2x] alroger:
@mateorod, I see that autopatcher supports 4.2.1 now... does that mean you got some patch files for us?
[LG Optimus 2x] JordanRulz:
will this work with new BL?
[LG Optimus 2x] mateorod:
Jeez...my bad guys. I forgot to update this thread. I have build patches for Android 4.1.2 and 4.2.1 on my github page, continuing the work started here by pastime1971. The patches for 4.1.2 work with the original PDroid application. The 4.2.1 patches mark the release of an open-source project called OpenPdroid, contributed to by various people involved with keeping Pdroid available, like CollegeDev, FFu5y, me and some others.

To use the 4.2.1 patches, you will need to by upgrade to Pdroid Manager or Pdroid2.0. All of this info is available at the OpenPDroid thread.

As for the original PDroid app, as time goes on, we needed to add functions to the PDroid core that we couldn't mirror in the app, as it remained closed source. And since the PDroid app is restricted to Gingerbread from the Play Store, people kept thinking it was dead, which was frustrating considering the amount of time I have spent on this.

These build patches are available to be applied to already built ROMs through the Auto-patcher as well.

Big thanks to syvat for all he created and pastime for keeping it alive.
[LG Optimus 2x] devm2024:
My network location is not working after I applied the patch. Everything else is working including Pdroid.

Somebody have any idea how to resolve this issue?
[LG Optimus 2x] wbedard:
Might I suggest that you head over to the OpenPDroid thread and state your question there? All of the PDroid development and support is over in that project now and it does have the backing of several developers and many users.

When you post your question, be sure to include what ROM you are using (include a link to it if you can...). Also be a bit more descriptive about the problem with your Network Location.

We'll get you fixed up!

R/

wbedard
[LG Optimus 2x] devm2024:
Yes sure, can u give the link of open pdroid thread.?
[LG Optimus 2x] wbedard:
http://xdaforums.com/showthread.php?t=2098156

R/

wbedard