yashsingh1/xdaforums huggingface dataset:
[LG Optimus 2x] mateorod:
Yeah, as far as svyat's methods go, I saw some major differences, some of which I wonder why he went that way. I bet there's a reason, though.

As far as our patch goes, I don't think that adding CM7 and AOKP would be too hard, though. In the script, we could just check the android version. Kind of like that code snippet I posted awhile back with the getprop. I could make the patches without too much trouble.

But I definitely agree that ICS should remain our main concern. I will make and test some CM7 and AOKP patches when and if I have time. If they work, we can throw them in there.

The value it will give for us is a wider net of potential users, which would help in widening the exposure to the ICS users we would really like to reach.

Let's put it on the back burner for now as we try and bang these AOSP patches into shape. I'll play around with the gingerbread patches as I have time, and we'll think about it more then. I have automated the patch process to a large degree, so even that shouldn't take too long.

I have an older machine (maybe 2006?) that is just sitting around. My wife has some stuff on it that she'll want protected, but if we struggle to find AOSP builds, I may just install a 64 bit distro on it and see if AOSP can be built on that. 3 gigs of ram on a 32 bit machine, though...i don't know...

---------- Post added at 01:11 AM ---------- Previous post was at 01:07 AM ----------

pastime- I just saw your post about the patch breaks. alroger had pm'd me about how to fiv it, and that's kinda what I figured happened.

Do our patches still work is the question. Have you tried on a new build? I am building an unpatched clobber right now, but haven't checked.

It would be something if our patcher broke on the second day of release, huh?

I am building for cm9, but could you check the patcher on an AOKP build once something gets posted?

Gotta love building software for nightlies. goddam moving target...grumble

edit: Looking a little more closely at the change, we may be okay. Hopefully. Let's test anyway.
[LG Optimus 2x] pastime1971:
it is only one more "import"

should be ok, but i will download AOKP nightly build and test it.
[LG Optimus 2x] alroger:
Thank you, that made it work.
[LG Optimus 2x] mateorod:
well, maybe I have discovered why I had such a hard time patching JoeSyr's ROMs. Our auto-patcher patches fails on the ServerThread with the latest cm9 encore builds just like everything I tried with his ROMs.

It looked like most everything else was okay, although there were several instances where the patcher detected a 'reversed patch'.

pastime, did you check AOKP?

I am going to rebuild Pdroid for CM9 right now and update the patch. What are the odds? These patches work for 2 months of nightlies and break the first full day it's out.

Edit: Just going off the way I couldn't patch any of JoeSyr's roms, I bet all the patches are broken, so if anyone is building for AOKP or AOSP, please go ahead and post the jar/build.prop packs (system, core, framework).

on the plus side, maybe this is why we had such a hard time with AOSP. It might just be we were testing patches that had just gone out of date. It would be nice if this had a plus side to it.

update-pastime- I uploaded new cm9 patches to the dropbox in a folder called cm9-5-08.

I have to go do some things, but if I see that someone posts an AOKP build, I will update the patcher and post it here, for you to add to the fourth post. We can leave both patchers up so users can select the correct one for their build date.
[LG Optimus 2x] mnjm9b:
Are you having issues with the source patch also...or just the smali auto-patcher?
[LG Optimus 2x] mateorod:
The source patches are up to date. The autopatcher works on all cm9/aokp builds before 5/06.

The new patcher should be out soon, though.
[LG Optimus 2x] mnjm9b:
figures.... I just tried it yesterday...lol

to be honest I prefer to source patch anyway...

auto-patchers make me lazy...lol
[LG Optimus 2x] pastime1971:
patcher (alpha) has been updated with new patches by mateorod in the first page, http://www.mediafire.com/?q2kw6h8ldxzdi96

added checking for successful smali process. (patching error is ignored for now)

added overwriting ROM type : run pdroid_patcher ROMZIP [ROMTYPE] where ROMTYPE can be cm9 or aokp

older CM9 nightly p930 fails for services.jar

latest CM9 nightly p930 succeeds w/ the following ignorable hiccup (as before).

patching file smali/android/net/wifi/WifiConfigStore.smali
Reversed (or previously applied) patch detected! Assume -R? [n] [B]<--- PRESS n[/B]
Apply anyway? [n] [B]<--- PRESS n[/B]
Skipping patch.
36 out of 36 hunks ignored -- saving rejects to file smali/android/net/wifi/WifiConfigStore.smali.rej

older CM9 nightly p990 fails for services.jar

latest CM9 nightly p990 : needs to be built first

older AOKP vibrantmtd succeeds

latest AOKP vibrantmtd : needs to be built first

older AOSP maguro : fails patching smali/android/app/Fragment.smali smali/android/app/LoaderManagerImpl$LoaderInfo.smali

latest AOSP : can't build due to my pending commit to gerrit... :(

edit: AOKP build for vibrantmtd fails for the moment due to the following error

target R.java/Manifest.java: Camera (out/target/common/obj/APPS/Camera_intermediates/src/R.stamp)
device/samsung/aries-common/overlay/packages/apps/Camera/res/values/config.xml:25: error: Resource at wantsFocusModes appears in overlay but not in the base package; use <add-resource> to add.
make: *** [out/target/common/obj/APPS/Camera_intermediates/src/R.stamp] Error 1
[LG Optimus 2x] mateorod:
Wait, is that aokp vibranttmd build failing due to patch?

I don't see it here (overlay problem, i guess?) but that doesn't mean much. Do the hunks apply successfully?

Also, when testing, I added the -N option to the patch command, it will ignore the hiccup like you're having with the wifi file. I have it illustrated in the original script layout. After the -p stripping.

Once we get some aosp builds going, I actually am hoping our aosp patches might work. The continued failing in ServerThread has me wondering if it isn't just the repo change that was frustrating us.
[LG Optimus 2x] pastime1971:
hunks do apply successfully.

you are right. we can safely ignore it with -N. i just wondered why it happened. :D
[LG Optimus 2x] closedcircuit:
VibrantMTD & Botbrew

Does anyone know if there are any plans to support AOKP vibrantmtd devices in botbrew to install Pdroid?
[LG Optimus 2x] mateorod:
All patchable roms are available in Botbrew by request, so sure. We will have to have a new build of aokp so I can support the newest builds, though. Our aokp patch is temporarily broken. Hopefully we will have a new aokp build soon.

But if you want I can add a package in Botbrew for the builds up to5/05 or so. Just let me know if you want me to add it now or wait until the new patches get made.

Even with the auto-patcher, I believe package management is the best and most efficient way to get these types of system mods to end-users. It I is a minority opinion at the moment, but as package management becomes more common and more familiar, I believe more people will share that opinion.
[LG Optimus 2x] pastime1971:
AOKP fixed Camera overly issue for vibrantmtd.

will post them once pdroid build is finished.
[LG Optimus 2x] closedcircuit:
If you have the time to add a package in botbrew for AOKP vibrantmtd up till 5/05 I'll waste no time trying it out.
[LG Optimus 2x] cashmundy:
I've got Botbrew + mateorod repo installed on cm7 vibrant, will switch to aokp whenever a Botbrew patch is available, if that is the way to get ICS+PDroid.
[LG Optimus 2x] c-pimp:
I have working builds of akop and gummy.. I'll check later for a new build and post what I got as well
[LG Optimus 2x] pastime1971:
here is

AOKP vibrantmtd

builds as of yesterday,

AOKP : http://www.mediafire.com/?v40p3ajt63ra9s3

PDroid + AOKP : http://www.mediafire.com/?3lc5oc1lkjigx4i

@ mateorod, when you get a chance, could you make patch files for the updated AOKP ?

@ cashmundy, please test the above to make sure PDroid is working.

edit: @ mateorod, do you want me to upload ROMs to the shared dropbox instead ?
[LG Optimus 2x] c-pimp:
Bahh pasttime always beats me to it.... Hehe thanks bro :-)
[LG Optimus 2x] pastime1971:
@ c-pimp, sorry... i wasn't trying to... you know... :D
[LG Optimus 2x] mateorod:
Hey, thanks. And no, there's really no need to upload whole ROMS at any point. I have an empty update.zip that I use to test the patcher so all I need is the system.jars and build.prop (to keep everything straight!).

I'll put a copy of the update.zip template in the box for you, too. That way you can test the patcher on any system.jars you want. Just treat it like a whole rom, you know?

I'll upload the the patcher you updated yesterday with the new patches in a little while. You can just put it on the front page when you have time. The new patches, the update.zip template and the new patcher will all be there in a folder with today's date.

cashmundy, I will update this post when the Botbrew package for your device is up, covering the latest nightlies ONLY. Shouldn't be too long. That will take care of you when you want to update from the rom pastime just uploaded.
[LG Optimus 2x] c-pimp:
Hehe yeah I know, don't be sorry, I was at work all day and just got home... your stuff is probably more recent than mine :-) thanks again for all the work you do :-)
[LG Optimus 2x] mateorod:
Update:

pastime- the new aokp patches are in the dropbox (folder 5-10) along with an update.zip template and an updated version of the patcher. I would like to suggest we establish a different naming convention for the patcher, now that we know it can go out of date with the repo. For now I have it named pp0508-v0.2.

We the date can be the build date that begin the included patches and the version for updated scripts. For instance, if we manage to sort out the AOSP patches now that the repo change seems to be settled, it would be pp508-v0.3 but if the repo changes next month at this time and nothing in the script change it can be pp0608v0.2 Sound good? or improve it, of course...

We should probably offer the old patcher as well, for people running older builds. This can help keep it straight for everyone and let them know when to update.

cashmundy- I made a package for the vibrant

(SGH-T959 ONLY!)

. We have previously had a problem with Botbrew recognizing the architecture of this phone, for some reason.

Would you try and

install package repository-mateorod,

refresh packages at top right

see if android-framework-pdroid is in the package list?

If so, go ahead and install it, you should be fine.

If not, try this package here.

If that still doesn't work, there may be something about your phone that gives Botbrew trouble. I will consult with inportb (a serious android guru, as well as Botbrew's dev) and see what we can do.
[LG Optimus 2x] closedcircuit:
Botbrew after installing repository-mateorod does not see android-framework-pdroid. When installing android-framework-pdroid_1.3.2-7_SGH-T959.opk with astro file manager I get an error in botbrew as follows shown in screenshot. Please note that I am running subzero kernel build 80 on top of AOKP Milestone 5.
[LG Optimus 2x] mateorod:
Just so I am not chasing my tail on this, please rename your build.prop to a txt file and upload it for me. Botbrew gets checks the architecture against values in the prop file and blocks installs of packages that don't match to avoid broken installs. For some unknown reason, the SGH-T959 is giving me trouble. Thanks for testing, I'll keep working in it.
[LG Optimus 2x] closedcircuit:
Here is the build.prop
[LG Optimus 2x] cashmundy:
PDroid seems to be working, but aokp is not quite usable for me: I'm not using an sdcard, and despite trying tricks with a symlink or a mount -bind, I cannot convince apps to accept the internal "sdcard" (emmc). So, no pictures with camera, no bookmarks restore with boat browser.

Thanks for the build, works great other than that little problem.

PDroid seems pretty good. I think I would like to use it in addition to CM permission management, as opposed to instead of PM.

---------- Post added at 09:50 PM ---------- Previous post was at 09:29 PM ----------

Botbrew installed, but with a lot of error chatter. I'm not seeing android-framework, but I think that means little because of the defective emmc access. I tried to download the patch, but can't

even do that with boat browser ("no sdcard"). I'll try with stock browser.

No luck with that either. Unless someone has an idea of how to get this aokp rom to deal correctly with the lack of an external sdcard, I need to ditch aokp. Really hating the aokp/ics keyboard, too...
[LG Optimus 2x] pastime1971:
@ cashmundy

I am not sure but CM has an option to use internal sd as /sdcard and i am guessing AOKP too.

Try system settings > storage > menu key > storage configuration > use internal ?
[LG Optimus 2x] cashmundy:
I looked as you suggested, but found no option. It, I think, happened automatically with cm7 and various ics builds I've tried. Amusingly enough, in the storage settings, it shows an sdcard, with correct amounts for audio use, etc.

What other roms are targeted for Botbrew and PDroid support? I can just switch to one of those. CM9 worked fine when I tried it, and Onecosmic's icssgs was pretty solid way back in December.
[LG Optimus 2x] c-pimp:
I got pdroid builds at home, at work again but if you like I'll post pdroid and removal zips for specific builds

That way you can at least have it until botbrew can work with our vibrants
[LG Optimus 2x] pastime1971:
@ mateorod,

as ROM variants and build dates stack up, it may be a good idea to allow user to force which patch to be applied, i think. initially i let them choose ROM, but maybe something like

./pp/pdroid_patcher ROM.zip [COLOR="Gray"]# automatic ROM type check & default (up to date) patches[/COLOR]
./pp/pdroid_patcher ROM.zip cm9 [COLOR="Gray"]# force ROM=CM9, patch=default (up to date)[/COLOR]
./pp/pdroid_patcher ROM.zip cm9_20120505 [COLOR="Gray"]# force ROM=CM9, patch=20120505[/COLOR]

what do you think ?

if you agree, it may be also beneficial to re-orgranize patches under folders.

i see that your update-template.zip utilizes /sbin/busybox for mounting /system.

1. does /sbin get mounted automatically on CWM ?

2. what if the ROM doesn't have busybox ? AOSP doesn't. i recall that vorkKernel packaged standalone busybox with its kernel installer. should we do the same ?
[LG Optimus 2x] mateorod:
Okay, potential Botbrew users of SGH-T959, thanks for being patient. I hadn't forgotten about you.

Will someone who has that phone AND botbrew installed please cut and paste the contents of the /botbrew/etc/opkg/arch.conf file?

We have one of two bugs in Botbrew. It is translating the getprop into lowercase letters or it is having trouble with the hyphen. Either way, I have a solution at hand now. So post that for me and we will be on our way.

When we have the bug pinpointed, it will be scheduled for removal in the soon to be released Botbrew +1 (a full debian installation INSIDE android, with access to it's 20,000 package library. Chew on that for a second.)

Thanks for helping me find these problems to report back!

---------- Post added at 12:08 PM ---------- Previous post was at 11:59 AM ----------

Ohsnap, didn't see your post pastime. That update zip wasn't made by me, I just use it so if someone needs something patched, or I have to test the patched, I can just throw in the system.jars and build.prop without having to download the whole ROM. Sorry for the confusion, I just figured we'd save ourselves and XDA the server activity.

Jeeez, AOKP doesn't have busy box? That's positively wild. I actually upgrade the CM version to the one in Botbrew to get access to more applets, I can't imagine android w/o it.

I agree with the user interaction, 100%. Think we could make this thing a real nice little program, a step at a time. I like your command functions. I think we could add a function that checks the build date and then chooses the patches from that, with the above commands acting as an override or force.

Look good.

C-pimp- when you next build aosp, would you pop out a Pdroid patched one as well? I'd Ike another crack at making those patches now that we know the CM repo had a major role in the initial failure.
[LG Optimus 2x] cashmundy:
@mateorod: here it is, from CM7 install:

arch	all	10

arch	any	20

arch	noarch	30

arch	armeabi	100

arch	armeabi-v7a	110

arch	vibrantmtd	120
[LG Optimus 2x] closedcircuit:
The line I think you're interested in is:

arch	sgh-t959	120

I modified it to be all uppercase "arch	SGH-T959	120"

and botbrew detects everything correctly, and pdroid installs without a single hitch.
[LG Optimus 2x] mateorod:
Thanks-

I just uploaded a new package that SHOULD work for your device. Now I haven't made the package rom specific, so anyone using it at the moment should know the vibrantmtd package is for AOKP ICS only! Use it on a nightly from yesterday, for now, since that is where the files came from.

The CM9 repo had ANOTHER major update last night, not enough to break the patcher again, thank gawd, but enough to break my CM9 Botbrew packages.

So for testing purposes, I would appreciate it if someone would test the package that is in the Botbrew repo for AOKP ICS. It is for

ro.aokp.version=aokp_vibrantmtd_build-35

ONLY!

I figure once we get the install process fixed for your phone, then we can start working on which rom you prefer, and how many options make sense.

Thanks for getting back so quickly!

pastime Maybe I don't understand, but there is a busybox in the builds you posted yesterday...at root level. I haven't looked at it though, I just don't see why a root-enabled rom could function without one. But still, you know better than I, we only have CM9, where I come from...

But maybe we could think about packaging in a busybox, as well, anyway. At least look at providing some applets. There are some other little thoughts in my head as well, let me think on them, and I'll get back to you about them.

---------- Post added at 02:27 PM ---------- Previous post was at 02:15 PM ----------

Okay, so yes, that was what I was looking for, and yes I am glad you have it working, for sure.

You posted while I was typing my last post, though.

That is so weird

. So on cm7 the architecture reads as vibranttmd, and on AOKP it is sgh-t959?

Would you please attach your cm7 build.prop to your last post, cashmundy?

I added an additional package to the repo reflecting the lowercase issue.

So the AOKP build 35 should be covered. Please note the architecture setting on the android-framework-pdroid (remember to install repository-mateorod and refresh first) and report back which package shows up.

If by some additional weirdness they both show, try installing one, uninstalling and installing the other. They both contain the same files, so it won't be an issue for your phone.

Thanks for the reports, guys.
[LG Optimus 2x] cashmundy:
@mateorod,

I confirm that the patch package is now visible in BotBrew.

I'm going to hold off on testing, because AOKP isn't working for me (and apparently others at present also). As soon as you want a test on any CM* variant or any ICS, I'll give it a try, as long as I don't already know the rom doesn't quite work.

Here are the relevant parts of build.prop, FWIW:

ro.product.model=SGH-T959

ro.product.brand=samsung

ro.product.name=soju

ro.product.device=vibrantmtd

ro.product.board=aries

ro.product.cpu.abi=armeabi-v7a

ro.product.cpu.abi2=armeabi

ro.product.manufacturer=Samsung

I threw the above in on spec, good to see you wanted it.

PS: between ro.product model and ro.modversion, assuming all roms treat these consistently,

you might get a reliable fix on both hardware and software:

ro.modversion=CyanogenMod-7.2.0-RC1-vibrantmtd-UNOFFICIAL

.. no such luck, looked inside the AOKP rom and it does not havea modversion field.

Some standardization would be helpful here.

Here are the other relevant AOKP bits. Maybe "model" is reliable across roms:

ro.product.model=SGH-T959

ro.product.brand=samsung

ro.product.name=SGH-T959

ro.product.device=SGH-T959

ro.product.board=aries

ro.product.cpu.abi=armeabi-v7a

ro.product.cpu.abi2=armeabi

I decided to pull down CM9. It is the same as AOKP

as far as the device:

ro.product.model=SGH-T959

ro.product.brand=samsung

ro.product.name=SGH-T959

ro.product.device=SGH-T959

ro.product.board=aries

ro.product.cpu.abi=armeabi-v7a

ro.product.cpu.abi2=armeabi

But identifies itself as:

ro.cm.version=9-20120510-NIGHTLY-vibrantmtd

ro.modversion=9-20120510-NIGHTLY-vibrantmtd
[LG Optimus 2x] closedcircuit:
Botbrew shows the "ONLY FOR SGH-T959!" android-framework-pdroid 1.3.2-8 for me. AOKP M5. This is after reverting to the all lowercase sgh-t959 in the arch.conf. Interestingly enough botbrew doesn't show that I currently have any android-framework-pdroid installed after reverting to the lowercase values in arch.conf.

EDIT: 5-13

After restoring a nandroid backup and reinstalling pdroid via botbrew without fudging the arch.conf. FC's don't happen anymore.
[LG Optimus 2x] pastime1971:
@ mateorod,

AOKP does have busybox. :D

AOSP doesn't. :mad:
[LG Optimus 2x] closedcircuit:
Anyone getting random FC's when opening up Google Maps? PDroid and Google feedback agent FC when Maps is left on and GPS locks. T959 AOKP Milestone 5
[LG Optimus 2x] mateorod:
That is odd. I don't see why that is the case, but I also haven't had to trick Botbrew into installing a package either :D Good work with that! The warning was something I added to the description for an earlier test when I made the architecture: all, trying to pinpoint the install problem we just fixed.

As far as the build.props go, we'll either eliminate the case-issue bug, or just work with it as a known issue as far as Botbrew is concerned. The non-standard device.name for the device is more worrisome, if I am being honest. But I think we'll let it lie as we keep our eyes open for other devices with the same problem.

Thanks a bunch for working with me to get that hammered out. Stuff like this makes Botbrew become a better app, and inportb passes his thanks along.

cashmundy, so what rom would be the best for you? I can jigger the package to accomodate a couple different roms. remember though, at the moment we only have reliable patches for AOKP and CM9, although we will probably be able to do those Team Gummy AOSP builds for your device, whenever c-pimp puts his files up. Just let me know, I'll try and get a package together for it soon after.
[LG Optimus 2x] c-pimp:
Sorry, it was a late night... I'll post files first thing when I wake

For vibrant I have working cm9 via patcher and gummy via source build and source patch and same for aokp milestone 5
[LG Optimus 2x] cashmundy:
@mateorod, I've got that CM9 nightly I pulled down yesterday to look at the build.props in. That or anything that I don't already know doesn't work would be fine.
[LG Optimus 2x] pastime1971:
updated the first page with pp20120510v02.zip

i packaged update-template.zip and use it if ROM.zip is missing update-binary (which will be rare). it wouldn't hurt.

i looked into vork kernel installer, and oddly enough they first use /sbin/busybox to mount /system, and a standalone busybox to do other stuff. i could try and test it further, but decided to look into AOSP first. i will make ota.zip for AOSP and see what it does.
[LG Optimus 2x] c-pimp:
here is the gummy files I already posted... do you need anything else to add to botbrew?

http://xdaforums.com/showpost.php?p=25801100&postcount=308