yashsingh1/xdaforums huggingface dataset:
[LG Optimus 2x] mateorod:
Yeah, the shift to private sections of code seems less than optimal. We can't live in fear of the kangers, or they win, you know?

I had to build the kernel separately turns out. But it gave me time to refine my makefiles. It is building now. I should have cm10 jellybean patches tomorrow.

I also updated our smali binaries. I also ftp'd our last package onto techerrata. I think. It said uploading, anyway. When I try and sign in to the goo.im dev portal it gives me a login error.

I'll figure out what that is about tomorrow as well. But all of these things should go up at the same time.

Later guys.

Edit: I am going to see if or how well android is using smp through htop. Although I dont know what we can do about it if either way. We can also think about writing the script to run in recovery after mounting system. We'll have to see if the reduced pull on the resources helps any, though.

Edit2: ohsnap. Here it is. I hope my adhoc solution to getting your name in there is acceptable. We should think about what we want to do with the hosting. We can experiment and then talk about goo manager.
[LG Optimus 2x] mateorod:
Well, the build patches died on me. I did use the only JB patches I have, which were aosp411. Do you have CM9 CM10 patches?

Pertinent log snips:

E/AndroidRuntime( 391): *** FATAL EXCEPTION IN SYSTEM PROCESS: ActivityManager
E/AndroidRuntime( 391): java.lang.NullPointerException
E/AndroidRuntime( 391):	at android.privacy.surrogate.PrivacyActivityManagerService.enforcePrivacyPermission(PrivacyActivityManagerService.java:49)
E/AndroidRuntime( 391):	at com.android.server.am.BroadcastQueue.enforcePrivacyPermission(BroadcastQueue.java:828)
E/AndroidRuntime( 391):	at com.android.server.am.BroadcastQueue.processNextBroadcast(BroadcastQueue.java:641)
E/AndroidRuntime( 391):	at com.android.server.am.BroadcastQueue$1.handleMessage(BroadcastQueue.java:132)
E/AndroidRuntime( 391):	at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 391):	at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime( 391):	at com.android.server.am.ActivityManagerService$AThread.run(ActivityManagerService.java:1431)
W/AudioFlinger( 139): power manager service died !!!
I/ServiceManager( 131): service 'vibrator' died
I/ServiceManager( 131): service 'bluetooth' died

and

141): Fatal signal 13 (SIGPIPE) at 0x0000008d (code=0), thread 141 (installd)
[LG Optimus 2x] pastime1971:
unfortunately no. build.diff, libcore.diff, framework.diff are identical between aosp411 and cm10.

i haven't been able to boot my phone with cm10 yet, so i haven't been able to debug it yet.

edit: but ActivityManager is where i had to make a change from ics, which i guess isn't working. i will take a look again tonight.

edit: try this one, http://www.mediafire.com/?2uwh9z837g7v7xo i added a null check
[LG Optimus 2x] perikolisan:
How do I have to proceed to send this files? =)

THanks, your job is amazing, i love my privacy:highfive:

PPD: How do you make the magic?
[LG Optimus 2x] mateorod:
It is even easier now. You can make a flashable zip for yourself on any Mac or PC. Just follow the link in my sig.
[LG Optimus 2x] perikolisan:
Autopatcher don't work for me v.v I tried all dates of CM9 and AOPK. If I apply diff patch (to java source code) i'll help you?
[LG Optimus 2x] 10cheesecakes:
So, I have a rooted SGS3, model SGH-T999V running Stock ICS. Can I use this to install pDroid on my phone.. or no???
[LG Optimus 2x] perikolisan:
Please, how i have to proceed to apply patch directy to source and compile? =) thanks
[LG Optimus 2x] karamelos:
No read the op , just cm9 aosp etc.....
[LG Optimus 2x] SilentEYE:
Hello I want to report a BUG,

Pdroid by using in combination with droidwall causes slow Network performance on wifi and 3G.

Used latest autopatcher on CM9 for Sony Xperia S.

As far as I understand this Pdroid Version does not block Internet connections. Right?

Ups wrong Post....
[LG Optimus 2x] mateorod:
Yo, I just saw you updated the patches! I go by email alerts, this edit slipped past me! I will try it tonight

Look at the very first post of this thread.
[LG Optimus 2x] mateorod:
I tried combining my Nook and Grouper CM10 trees. SInce then I haven't had a bootable build. I can't help but think that is related (:silly:) even though it sure looks like it could and should be possible.

Anyway, so I am building a grouper right now with the new patches applied. If it doesn't work, I'll grab a whole new tree and start from scratch. The good news is that they are not booting in a remarkably noticable fashion. The first build patches you posted were oh so close to working, so I will make sure that the trouble isn't my tree.

As for build patches for AOSP, krylon360 advised that we need to add the framework2 to the boot classpath, which completely matches up with what I saw in the logcat.

He knows the two patches we have been using to split the framework and saw the log, although I can't say how long he looked at either...but he's pretty good. He said this:

Sometime in the next 24 hours I will try AOSP with your newest patches and this addition.
[LG Optimus 2x] mateorod:
I have been trying to let you be, I know you've been busy at work; little did I kkw you'd solved it last week.

Preliminary testing shows that it is working just as it does in ICS. When you block Google apps from all permissions, it automatically tried to get me to send them a bug report, which I don't remember.

I am running a clean build now, should have a test patcher this afternoon.
[LG Optimus 2x] pastime1971:
i will look into cm10 and see how it handles framework2...
[LG Optimus 2x] pastime1971:
i just saw your post.

so, we are very close to a working pdroid on JB, right ?

please keep us posted, mateo.
[LG Optimus 2x] CollegeDev:
Just nice to see that it is goin on to JB. If there is more freetime, I will have a look to it. Can you explain which classes affected changings from ICS to JB, so that I can look more closer to it? You can write me pm if you want:o Nice work, guys
[LG Optimus 2x] mateorod:
Ah, yes my friend. We now have CM10 support. And I think we can begin to find out about AOSP soon as well. I have a pretty firm feeling the boot classpath was the missing step for our AOSP issues.

It has been ftp'd up to the techerrata server...I am going to update the post while I wait for it to appear.

You have a link in your inbox pastime, let me know if you see anything drastic if you have the time...
[LG Optimus 2x] pastime1971:
yeah, there were only a few changes.

i will pm you later.
[LG Optimus 2x] mateorod:
hey, I have updated the init.patch from the AOSP package I sent you...this can be run for you (i think) as...

cd ~/android; git checkout -b pdroid; patch -p2 < ~/init.patch

Either way, this patch was made from the PWD of your build tree. This will replace the one in the AOSP build patches I sent you.

Edit: changed the patch command, the file to be patched is in PWD/system/core/rootdir
[LG Optimus 2x] jshinn1:
Hey guys Im having an issue I get the "missing diff tools" error message but Im using cygwin for windows and the solutions I saw earlier in the thread were for linux distros any help???
[LG Optimus 2x] mateorod:
You have to install patch tools when you set up cygwin. Just run the setup.exe again.

There is a screenshot at kobik77's cygwin guide here.
[LG Optimus 2x] jshinn1:
Thanks I just got it working

Sent from my SAMSUNG-SGH-I717 using Xparent SkyBlue Tapatalk 2
[LG Optimus 2x] samarium:
I recently tried pdroid on my CM9 N0814 Galaxy Note. Most things seemed fine.

However, Google Listen seems to be misbehaving. Looks like the associated "Listen Service" isn't running, and as such the UI doesn't see the downloaded podcasts, and can't play them.

So far I've only verified that flashing the restore zip works to restore "Google Listen" to normal operation.

I patched ROM using autopatcher20120809v1.6.0.zip.

I noticed an issue back in 2011/Dec with google listen, however that seemed to be fixed in 1.26 vis: http://xdaforums.com/showpost.php?p=20511885&postcount=326 and maybe 2012/Apr from http://xdaforums.com/showpost.php?p=24666124&postcount=1192, which is maybe >= 1.32, however no response on the issue that I could see.

I was wondering if anyone else had seen this behaviour, and had a solution, before I go chasing thru logcats etc?
[LG Optimus 2x] pastime1971:
i don't have google listen, so never noticed the problem.

i would appreciate if you can capture logcat and pinpoint where it causes issues.
[LG Optimus 2x] pastime1971:
@ samarium,

could you post a link to "google listen" on the market ?

i can't seem to find it.

did it change the name ?

i wonder why it needs a phone permission... :confused:

edit: well, it looks like i will have to find "google listen" and do some debugging to fix the issue. i will try to get to it this weekend... if i find the app from the market
[LG Optimus 2x] karamelos:
Great work fine on this rom

[ROM][JB Port][ICS][MOD][AOKP] --> HALF-ILLUSION v2 (ICS) & JB in House now <--

Thread rom http://xdaforums.com/showthread.php?t=1768024

Patch & log post http://xdaforums.com/showpost.php?p=30284610&postcount=553
[LG Optimus 2x] CollegeDev:
Hey pastime,

search in xda for this app, it is no longer available on market. I think I have fixed it, but not tested it.
[LG Optimus 2x] samarium:
Thanks. Check your PM.

Maybe phone permission is so it can stop playing podcasts when the phone rings?

---------- Post added at 05:17 PM ---------- Previous post was at 05:09 PM ----------

If you are after another test case ...
[LG Optimus 2x] gongoscho:
Can anybody make a Patch for DHD Virtuous Infinity v1.33.0? ICS 4.0.3
[LG Optimus 2x] pastime1971:
great.

if you can share how you fixed it here, samarium can test it, i'm sure.
[LG Optimus 2x] Lonely_Boz:
how can i download pdroid from market? It says that isn't compatible with my phone. I'm using Jelly Bean at the moment, and i I have HTC Desire GSM.
[LG Optimus 2x] pastime1971:
with JB, you can no longer get the app from the market.

you can visit svyat's original thread and directly download the app from there (post #1)

there is a link to svyat's thread in the post #1 in here.
[LG Optimus 2x] karamelos:
one more

patcher work's FIIIIIIIIINE on this rom

[ROM][JB 4.1.1] PARANOIDANDROID v1.4 [TABLET/HYBRID][CM10][17/08]

patch post
[LG Optimus 2x] SuperSkill:
You find answers in first post ;)
[LG Optimus 2x] CollegeDev:
I'm now in vacation for 1,5 weeks. After that I will post it, ok? But if you have time, feel free to update it.:)
[LG Optimus 2x] jago25_98:
I'm currently using Permissions Pro as it's the only option I know for JB. Having to click through manually each permission for every app takes about 10 secs for each click and then you sometimes have to lock permissions & reboot.

That said, this approach is lighter and seemingly more thourgher than LBE Privacy Manager. LBE is really easy to use as it prompts you to set permissions but it doesn't seem to cover them all and isn't working for JB yet.

I hope PDroid can be included in some ROMS, to me it's an essential piece of kit. So many (essential?) apps make use of extensive permissions, even FOSS like and security conscious apps like Serval merh networking. Permissions is the main reason I stick with Android over iphone.

Hope this helps clear up the main choices for permission control on Android:

- LBE for ICS

- Pdroid for ICS & GB, but takes work to get running

- Permissions Pro for JB (at the time of writing this)

edit: The Chinese full version of LBE works with JB but... it needs so many permissions I'm pretty sure it's spying on you!
[LG Optimus 2x] samarium:
Since google listen was going to be unsupported in the furture I went looking for other podcatchers, and am currently using doggcatcher, which is working fine with pdroid. It is nice to get into the car, and have doggcatcher automatically start when the A2DP connects, and properly halt on disconnect. So don't go chasing google listen fixes for my sake.. Thanks.
[LG Optimus 2x] pastime1971:
thanks for an update, samarium.

sorry that i couldn't fix it in time.

i am spending most of my time to bring cm10 to p990 for the moment.
[LG Optimus 2x] samarium:
No problem. I understand you must prioitorise your time, otherwise you won't have any left to do what you want.
[LG Optimus 2x] jpeg725:
ZTE Blade with cm10

I have been trying out KonstaT's lovely JB rom for the ZTE Blade. http://www.modaco.com/topic/355903-devrom19-cyanogenmod-10-android-411/

It is based on cm10, but the autopatcher refuses to patch it, it gets stuck on the frameworks patch.

So I am trying to build it myself. The patches can be applied to KonstaT's cm10 code patched for the blade just fine, and the compile went smoothly (took ages though :cowboy:).

Will let you know if it works.

If it does work, what can I do to help you fix the autopatcher?
[LG Optimus 2x] pastime1971:
you can make smali diff files and send them to us.

if not, send us framework.jar, core.jar, services.jar w/ and w/o pdroid compiled, and we can make diff using those 6 files.
[LG Optimus 2x] mateorod:
Hey cool! We are going to add user submitted patches for auto-patcher 2.0 which will hopefully have a test release in the next week.

BEFORE doing another repo sync, go through the build patch removal process you'll find here on the first post. There are five commands.

Then zip up the framework from both the new stock build as well as your pdroid build. We will need core, services, framework.jar and build.prop.

That will be enough to make patches that cover your rom for awhile. They do need updating to keep current, maybe once every three weeks. But it will make pdroid available to all the users of your ROM, it would be pretty neat.

Thanks!
[LG Optimus 2x] alroger:
PDroid for SGT7-P1000[*] CM10

I just patched CM10 (sgt7 repo, unofficial) for the Samsung Galaxy Tab 7" P1000/N/L/CDMA.

Patch went fine, no errors.

PDroid working on my CM10!

Thank you guys for this! PDroid is a must!

Here's my CM10 build thread if anyone interested:

http://xdaforums.com/showthread.php?p=31105222

Works with latest @humberos and nightly builds of CM10 with new partition layout.

Cheers!
[LG Optimus 2x] mateorod:
Pastime, I think I am going to try and move the patch fix conversation here, I think it could get lost in the noise of the auto-patcher thread.

Although that conversation is about to get dominated by the same thing, as the CM (and most likely AOKP) build/smali patches have ceased to work as of yesterday.

If you haven't seen the conversation, you can check out maybe the last several posts on the auto-patcher thread by me and horquai and tonyp.

Basically, they have filled up the methods on CM now too. Tonyp has some ril files he thinks can get moved, so we can see how much room that gets us. He says that users will have to do that themselves before the patching though. Which seems like maybe we could automate that, unless by moving he means deleting, and each user has to decide for themselves which rils they need and don't need...

I had seen that it was possible to probably move the server subclasses as well, but it turns out they have since been added to framework2.jar already, So I am going to hunt for some classes that we could maybe move.

This is going to be a hassle...
[LG Optimus 2x] pastime1971:
it is "deleting".

tony and i discussed about it before.

also, which RIL can be deleted depends on the device. on P990, we can delete vendor-specific RIL except LGEStarRIL.java. on other device, it has to be accordingly.
[LG Optimus 2x] mateorod:
Okay, we may have that life-line after all. I need version control for everything, I couldn't tell my own additions from the original patch.

In the thread where I originally found the framework.jar split patches, it is suggested that the android.server classes can also be moved. I will look into gathering up those classes and putting them in frameworks2.jar. If I can get it to compile, then we can worry about testing.

https://groups.google.com/forum/?fromgroups=#!topic/android-platform/sR6I2ldCxwU
[LG Optimus 2x] jpeg725:
Building only the three jar files

Anyone know the right command to just build the frameworks part, or even better just the three jar files that get modified?

Compiling the whole lot just to use those three bits with someone else's ROM does take quite a while.

EDIT: Stupid question, see here in the first post.

EDIT2: Only builds core.jar

Here are the errors.

Any ideas?
[LG Optimus 2x] pastime1971:
needs translation ...

but i can tell you this much.

in order to build those necessary only: . build/envsetup.sh and then make framework core services

do not follow svyat's instruction: it requires that you already built the rom first in order to use mm or whatever that was.

the source has been fixed such that you can build the rom or module with pdroid in a regular way.

edit: edited the first post about module build.
[LG Optimus 2x] jpeg725:
Thanks. Super duper. Helps a lot.

The make otapackage doesn't seem necessary. I tried without and it made the three jars.
[LG Optimus 2x] mateorod:
pastime, I successfully moved some more methods and was able to build a pdroid patched build. I haven't flashed it to test though.

The framework2.jar grows about 20kb in size from 98.x to 120kb.

tonyp, you are not currently able to build using the patches? I actually took horqaui at his word that cm10 didn't patch. I guess I will test PA tonight with the new patches.

Update1 Jesus. That is what I get for believing the user base. CM10 still patches. I was under the impression that tonyp had confirmed that it no longer worked for him. I guess I misunderstood, or heard only what I expected to hear.

I am almost done making the unpatched framework, so I will go ahead and check the new patches on PA anyway. Realistically, I still might submit the change to CM, simply because I think it was most likely an oversight that the classes I moved weren't included originally. And obviously, space is starting to get tight.

Eventually, from what I can tell, they are either going to have to really split framework in a sensible manner from AOSP down or provide a whole new library. Or, probably most effectively, fix the core problem.

It is a bug in dx, and they have had people complain about it since 2010. They kept hinting at upcoming tools before renegging and then just ragging on people to "be radical and write more efficient/responsible code!"

I wish they had taken their own advice, this is big time irritating. I have even more irritating resolution issues on PA I could be futzing with.
[LG Optimus 2x] pastime1971:
right. it is for building the whole rom (either brunch or make otapackage)
[LG Optimus 2x] FFU5y:
Just FYI: CM10 patched doesn't build for Acer Iconia a500, nor for Motorola Defy (mb525). Neither of these are integrated into the main CM10 repos yet (other developers have the vendor and device parts in their personal github accounts).

In both cases, problem is hitting the dex 65535 function limit.

I'm happy to test efforts to move stuff to framework2.

Edit: Just saw that there are patches for AOSP JB to use framework2 - will look (hopefully soon) at what you've done re: can it be likewise applied to CM10 without you doing all the work.

Cheers.
[LG Optimus 2x] tonyp:
I had the same problem. You can't use the AOSP patches, they will _generate_ the framework2 file - but this does already exist in CM.

What I'm doing is that I just delete a couple RIL files I don't need at "android_frameworks_base\telephony\java\com\android\internal\telephony".

Just delete the Samsung, HTC and Sony ones and you should be able to enable PDroid.

The CM team should really try to move a couple more methods into the framework2 - I will ask arcee about that the next time I'll talk to him.

(Although they could just say that they optimize it for CM and not for kangers).
[LG Optimus 2x] alroger:
65536 method limit in framework.jar

Thanks... same problem here compiling for CM10 Samsung Galaxy Tab 7" (p1, p1n, p1l, p1c). It's getting to 65565 with the patches.

I just deleted 2 files: SonyQualcommRIL.java HTCQualcommRIL.java

In hopes that I'm on a Samsung and won't be needing them.

Compiled latest nightly fine with that.
[LG Optimus 2x] FFU5y:
Yeah, I had noticed CM10 already had a framework2. I was thinking that if there were things moved into framework2 in the aosp patch that hadn't already been moved in CM10 I could shift them across too.

I'm still getting my head around what the implications are of moving things into framework2, and thus what can and can't be moved.

Edit: I see that the things moved in the AOSP patch are exactly the same as the things already moved in CM10.
[LG Optimus 2x] pastime1971:
your build.prop should show which RIL to use.

for example, on p990 it says

ro.telephony.ril_class=LGEStarRIL

then, it is using framework/base/telephony/java/com/android/internal/telephony/LGEStarRIL.java as well as RIL.java

in framework/base/telephony/java/com/android/internal/telephony/PhoneFactory.java

//reads the system properties and makes commandsinterface
String sRILClassname = [B]SystemProperties.get("ro.telephony.ril_class", "RIL")[/B];
Log.i(LOG_TAG, "RILClassname is " + sRILClassname);

// Use reflection to construct the RIL class (defaults to RIL)
try {
[B]Class<?> classDefinition = Class.forName("com.android.internal.telephony." + sRILClassname);[/B]
Constructor<?> constructor = classDefinition.getConstructor(new Class[] {Context.class, int.class, int.class});
sCommandsInterface = (RIL) constructor.newInstance(new Object[] {context, networkMode, cdmaSubscription});
} catch (Exception e) {
// 6 different types of exceptions are thrown here that it's
// easier to just catch Exception as our "error handling" is the same.
Log.wtf(LOG_TAG, "Unable to construct command interface", e);
throw new RuntimeException(e);
}

executes that particular vendor-specific-RIL java.

the rest can be safely removed, i think

HTCQualcommRIL.java

LGEQualcommRIL.java

LGEQualcommUiccRIL.java

LGEStarRIL.java <--- p990 needs it

MotoWrigley3GRIL.java

QualcommSharedRIL.java

SamsungCDMAQualcommRIL.java

SamsungCDMAv6RIL.java

SamsungHCRIL.java

SamsungQualcommD2RIL.java

SamsungQualcommUiccRIL.java

SamsungRIL.java

SemcRIL.java

Smdk4210RIL.java

SonyQualcommRIL.java

edit: on official cm10, you won't see LGEStarRIL.java, because it is a hacky workaround to make CM10 to work on p990.
[LG Optimus 2x] soccermonster5:
I was scanning over the patch and noticed a small bug in it.

libcore.diff, line 92:

+ for (int i = GET_COMMAND_WAIT_MS; (proc = freader.readLine()) == null && i >= 0; i[COLOR="Red"][B]=-[/B][/COLOR] GET_COMMAND_WAIT_STEP) {

Should clearly be:

+ for (int i = GET_COMMAND_WAIT_MS; (proc = freader.readLine()) == null && i >= 0; i[COLOR="Red"][B]-=[/B][/COLOR] GET_COMMAND_WAIT_STEP) {

(note the '=-' should be '-=')

Thanks for all the hard work guys!
[LG Optimus 2x] pastime1971:
good catch !
[LG Optimus 2x] tftd:
I guess I'm missing something. I've patched the latest cm10 nightly build and installed it. Afterwords I've installed the pdroid apk but it says my rom isn't supported?
[LG Optimus 2x] pastime1971:
it should work.

however, you will probably get too many methods in framework error if you didn't remove unnecessary RILs.

did you remove other vendor specific RILs in telephony ?
[LG Optimus 2x] tftd:
I've used the auto_patcher app to patch the cm-10-20120919-NIGHTLY-i9100.zip build.

Everything ran ok according to what I saw in the cygwin terminal.

I'm sorry for my ignorance but I've got no idea what "RILs" are and during the process there weren't any prompts asking for that...

So I guess I haven't removed anything.
[LG Optimus 2x] Sandpapers:
I searched a little bit and couldn't find anything. Been using pdroid on GB and ICS for some time now, but never noticed this before. When you download an app and it lists all the permissions, sometimes all of the permissions do not show up in Pdroid for blocking. Anyone know the reason for that?

Advanced download manager pro is one for me. Showed a ton of permissions when I installed it, but then only network info and sim info show up on pdroid. Is that app accessing everything it said or just what Pdroid has listed?

Thanks