yashsingh1/xdaforums huggingface dataset:
[Android Apps and Games] osm0sis:
But weird that FX works just fine with SMBv1 fully disabled or enabled in Windows, and that Google's client does fine in all cases with just HOMEBASE. :confused:

There's gotta be a clue for the hostname resolution or connection or something in their example code.

Edit: [MENTION=2954544]tliebeck[/MENTION], if you want to test the use case on your side with Windows 10 (should also work on Windows 7+), you need SMBv1 enabled in Programs and Features, and then here's the magic.

smb1-disable-server-enable-client.reg:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\LanmanServer\Parameters]
"SMB1"=dword:00000000

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\LanmanWorkstation]
"DependOnService"=hex(7):42,00,6f,00,77,00,73,00,65,00,72,00,00,00,4d,00,52,00,\
78,00,53,00,6d,00,62,00,31,00,30,00,00,00,4d,00,52,00,78,00,53,00,6d,00,62,\
00,32,00,30,00,00,00,4e,00,53,00,49,00,00,00,00,00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\mrxsmb10]
"Start"=dword:00000002

Then reboot.
[Android Apps and Games] tliebeck:
FX 6.0.1.0 Released (Beta channel)

Moved to production

A quick update to 6.0, this release simply adds a better error dialog when an SMB2 connection fails outright, prompting the user that they might need to specify SMB1 if they are connecting to an older device.

Also there's a bugfix or two for Google Play reported crashes that literally affected 1 or 2 people.

Direct Download: http://android.nextapp.com/fx/r6007/FX_r6007.apk

Beta Testing G+ Community: https://plus.google.com/communities/101301040394875566704 (join community, then go to https://play.google.com/apps/testing/nextapp.fx )
[Android Apps and Games] mbc07:
I have two feature requests: First one is, can we have a quick settings tile to enable/disable FX WebSharing when running on Nougat? And second, can you extend the app icon overlay that show on the folders when browsing /sdcard/Android/data, /data/app and /data/data to also work when browsing the system partition, more specifically, /system/app and /system/priv-app?
[Android Apps and Games] GeTex:
So uhhh

Idk how I made this happen

Actual file was only 950mb moved

Only occurs when doing OTG transfers on large files, not Everytime.
[Android Apps and Games] tliebeck:
Does it transfer completely? Do checksums match?

Are there any pauses during the transfer? Are there any errors/recoveries shown in the "completed tasks" dialog?

I've seen this before due to block sizes (e.g., the source reports a bunch of tiny files are actually 4k because that's the minimum block size). But with two files that's not going to be a problem.
[Android Apps and Games] thedicemaster:
i think the issue with malformed icons needs to be fixed first.

FX still slows down a lot whenever the icon of certain apps/games, like galaxy on fire 2, is visible.

i think i had this issue with the samsung galaxy note 2, K Zoom, note 4, and S8.
[Android Apps and Games] tliebeck:
I'd love to do a tile, not sure I can....at least not integrated into the main FX APK, because we'd have to target SDK 24.

<rant>We're currently held on SDK 23 to allow opening apps via file:/// URIs. If we go to SDK 24 we lose that capability, and everything has to be opened via content:/// URIs. FX already has a content provider that will do this, and it even supports write operations. But so much functionality/flexibility is lost. you can't do a "Save As" in the target application, and most applications don't implement the ability to write to the sent file. Like all things file management, Google didn't think this one through at all. The content URI design is a good idea, it just doesn't provide a sufficient replacement for file:/// URIs in all cases, and contrary to the docs it provides no real security over passing a file URI.</rant>

I was going to write an explanation about how it's too difficult to implement icon support for /system/app because the package name is not in the folder name. But that explanation proved too difficult to write so instead the code was implemented and it will be in the next version.
[Android Apps and Games] tliebeck:
Did finally see issue with transparent background on S7 Edge. This will be fixed in the next release too. Just discovered they're using a 4096x4096 icon. Setting a limit and downscaling.

Edit: and may be a Samsung specific problem. Note3 on Lineage 14.1 doesn't suffer it all. Snapdragon 800 vs 820. :) Still glad to have it fixed, it was burning a ton of memory.
[Android Apps and Games] thedicemaster:
the issue has become smaller as devices have become better able to use brute processing power to overcome it, but it's good to finally see it fixed.

now that you mention "save as", i found a little inconvenience in it.

if i use it from Atlas(default download manager sometimes fails, but save as works fine) and it uses the page title instead of the file name as file name.

so if i use it to save "wallpaper.jpg" the name it tries to save it as will be something like "wallpaper.jpg (1920x1080).html"
[Android Apps and Games] GeTex:
[MENTION=2954544]tliebeck[/MENTION]

The first file is 1200mb, the second is 1800, file one will succeed and 2 will stop transferring after 800-1200mb then the counter keeps going up but nothing is being moved, kept "moving" for hours and the progress marker soon became 10gb/3gb, after looking into it I think the target(sd card) was out of space.

Does FX have the ability to do a precheck of size of source and free target space
[Android Apps and Games] tliebeck:
Looks like the underlying problem is the transfer manager's auto-retry feature isn't recognizing the disk full error as a permanent issue. It was incorrectly throwing it as a read error rather than a write error. The "progress" is total nonsense in this case. Fixed for next version with immediate (and correct) error.

Don't have a precheck actually, overdue to be added.
[Android Apps and Games] GeTex:
Glad to help
[Android Apps and Games] tliebeck:
FX 6.0.2.0 Released (Beta Channel)

This is an update with a few fixes and a few items that didn't previously make the cut for 6.0.

Rounded corners for image icons and album covers.

Improved "Details" screen for images and album covers. Improved presentation of image EXIF data.

App icons for folders in /system/app.

Failing properly when storage is full. Other I/O error messages improved.

General bugfixes based on Google Play Console crash reports.

Direct Download: http://android.nextapp.com/fx/r6009/FX_r6009.apk

Beta Testing G+ Community: https://plus.google.com/communities/101301040394875566704 (join community, then go to https://play.google.com/apps/testing/nextapp.fx )
[Android Apps and Games] thedicemaster:
/android/data has never scrolled this smoothly before.

your fix works, galaxy on fire's icon no longer causes problems.
[Android Apps and Games] mbc07:
Thanks! It works flawlessly here, but, I'm not seeing the icons when browsing /system/priv-app. Am I missing something or it's not implemented? Could you extend the icon overlay to /system/priv-app too?
[Android Apps and Games] osm0sis:
[MENTION=2954544]tliebeck[/MENTION], any progress using the Google hostname lookup example code on the SMB issue I reported? Were you able to replicate the issue using the .reg I posted? Let me know if there's anything else I can provide to help.
[Android Apps and Games] tliebeck:
Sorry for delay, working constantly trying to get more 6.0.x stuff done.

I just tried the .reg, can't reproduce unfortunately. On my network I can still look the host up using DNS though. I'm using Virtualbox to test Win10/8 so they're very clean installs.

Delving into Google's code and comparing it to the SMBJ library being used by FX is going to be more than a challenge. I've had to fix some stuff in their already and while I think the authors have done a good job, it's a very complex library with a pretty steep learning curve (I'm not knowledgeable about the low-level workings of SMB protocols).
[Android Apps and Games] tliebeck:
Could someone with LineageOS 14.1 (or derivative) and a phone with an SD Card test something for me? It needs to have an SD card slot (i.e., USB-OTG won't cut it).

Copy an image (from anywhere) to a directory on the SD card using FX. Then long-press on the image and view details. Select the "Image" tab. Does the image have a "DATABASE ID" (as shown in last line of screenshot)?

I'm seeing an issue with the media scanner not scanning created files. Trying to figure out if it's specific to my LineageOS ROM on a Note3 or if it's a general LineageOS issue.
[Android Apps and Games] osm0sis:
Did you have SMBv1 enabled in Programs & Features before running the .reg? It needs to be enabled there, then reboot, then SMBv1 server-only disabled via the .reg, then reboot again for effect. FX is the only SMB client that seems to be having issues with the setup, so hopefully we can figure it out.. again, please let me know if there's anything else I can provide to help.

I've also noticed your implementation seems to report file sizes to the nearest 4kb, but I think that's a regression as I seem to recall it being more accurate before the revamp.
[Android Apps and Games] tliebeck:
Did not verify. Can I put this back to stock by simply deleting those registry keys and try again?

Toggling on and off SMB1 doesn't seem to work now (it does apply, but FX can't connect on SMB1, and it used to be able to, SMB2 still works fine.).
[Android Apps and Games] osm0sis:
You would delete the key that disables the v1 server, the others are just defaults. I set them with the sc commands myself but they just make the registry changes as far as I know. I'll dig up the original commands in case.

That sounds kinda like the desired effect actually. SMBv1 client in Windows should still work (to connect to legacy devices that can't support v2), but the SMBv1 server in Windows is disabled, forcing network clients to connect to any shares on that Windows machine with v2.

Edit: SMBv1 must be enabled in Programs and Features, then reboot, then this:

https://www.reddit.com/r/sysadmin/comments/5um61l/disable_smbv1_via_group_policy/dhi1ms4/

Then reboot (I think), then this:

https://www.reddit.com/r/sysadmin/comments/5um61l/disable_smbv1_via_group_policy/ddvz8fb/

Then reboot again.

Just to refresh, my issue is that once this Windows configuration is made FX can't connect using the hostname anymore, where other clients can, e.g. I need to use "192.168.0.6" in FX instead of "Homebase" or it won't see it as online, so seemingly a resolving issue only in FX's implementation and only triggered by this setup.
[Android Apps and Games] Ultramanoid:
Latest Lineage build on a couple of hTC ( M9, A9 ) devices with an ext4 SD card in the slot, copying an image as requested, no database ID.

Edit : Same on a SONY Z5.
[Android Apps and Games] MrWasdennnoch:
Resurrection Remix 4.8.3 (Android 7.1.2), no database ID, neither when copying nor than moving from internal storage to SD card.
[Android Apps and Games] tliebeck:
I think I'm going to remove the "Lock" button from the Image Viewer. It's a nice feature in my opinion, as it enables you to lock the device and show a single photo to someone without worry that they'll flick through your other photos or do other things with your phone. But alas, Android requires that it use a "Device Administrator" permission to work, because an app can't otherwise request to lock the screen.

I'm not removing the feature entirely, in that it'll still work if you press the lock button on the device. But the lock button will be going away (or turning into a help item).

Received this nastygram from Google:

The Play Store listing was updated within 15 minutes of receipt, but I don't like 7-day warning notices of app removal from robots.

Screenshots show how the feature worked after pressing the "Lock" button for the first time.
[Android Apps and Games] mbc07:
Well, since Android Lollipop and newer we have "Screen Pinning" feature which achieves basically the same thing of the lock button from FX's Image Viewer, so unless I'm missing something (or if you're still on KitKat or earlier), this feature is redundant anyways and I personally don't think asking Device Admin permission just for this is worth. I'm not totally sure but I think there's also a native Android API (if you're on Lollipop or newer) that allows apps to "pin" the screen at will, also without requiring Device Admin permission...
[Android Apps and Games] BobboVilla:
It's not the same functionality. I didn't use the image pinning in FX, but when I tried the screen pinning it allowed me to use the app fully.
[Android Apps and Games] tliebeck:
Screen pinning might be useful in this case, but it might take a lot of work to adapt it for use by a single activity (haven't tried).

The "pinned" mode in the image viewer still works, we just can't have lock the screen programmatically without the admin permission. You have to press the power button. When this mode is enabled, the screen immediately turns back on (in the locked state). If the user backs out of the image viewer, you are returned to the Android lock screen.
[Android Apps and Games] tliebeck:
FX 6.0.2.2 Released (Beta Channel)

A few more changes to kick off 6.x development:

Icon and layout adjustments. Most icons are now closer to a 1:1 to make text/icon proportions appear more uniform. (Makes icon layout look cleaner.) see screenshot

Fixed bug in video player causing videos to stop.

Fixed bug in video player showing empty action bar after rotation.

Removed "lock" privacy button from image manager as it required granting of an administrative permission that Google has deemed scary. (Privacy lock feature is still available by pressing power button on device while viewing an image.)

Improvements to Web Access:

Fixed audio player bug where tracks would stop on Chrome when using HTML5 playback.

Set HTML5 audio (instead of Flash) to be the preferred playback mechanism.

Fixed unexpected and irrelevant authentication popup bug on some browsers.

Fixed "broken image icon" bug when videos have no thumbnail.

Direct Download: http://android.nextapp.com/fx/r6011/FX_r6011.apk

Beta Testing G+ Community: https://plus.google.com/communities/101301040394875566704 (join community, then go to https://play.google.com/apps/testing/nextapp.fx )
[Android Apps and Games] mbc07:
App icon overlay still don't appear when browsing /system/priv-app...
[Android Apps and Games] tliebeck:
Thanks, will be in next release (likely in a couple of hours).
[Android Apps and Games] tliebeck:
FX 6.0.2.3 Released (Beta Channel)

Very minor changes relative to 6.0.2.2:

Slight icon and spacing tweaks.

Icons for apps in /system/priv-app.

Added support for open files by sending "content URIs" instead of "file URIs". This is the way you're supposed to in Android 7, but it doesn't work as well as sending file URIs for 90% of applications. The blame here is on both Google for a crappy API and on the application developers for paying zero attention to it. Support is improved though for apps that do it right. Setting is disabled-by-default. The hope is that someday apps will actually support it correctly, as it will likely be the only option by the time we're on Android 10 (wild guess).

Removed a defunct setting regarding USB OTG. It has long been inert and shouldn't have been in previous releases.

Thanks for testing and the annoying amount of releases this week. This one should go to production barring any significant issues.

Direct Download: http://android.nextapp.com/fx/r6012/FX_r6012.apk

Beta Testing G+ Community: https://plus.google.com/communities/101301040394875566704 (join community, then go to https://play.google.com/apps/testing/nextapp.fx )
[Android Apps and Games] fz798:
Any plans for implementing a FAB (Floating Action Button, or Floating Action Bar) that would appear on certain operations? Example:. Selecting multiple files, we currently have to tap the menu for a choice of action, but, logically, if you're selecting files, you're obviously going to perform some action upon them (copy, move, delete, share, etc), so it would make sense to pop up a FAB automatically.

AquaMail is a nice example of this.

I can attach a screenshot if needed.

Thanks
[Android Apps and Games] tliebeck:
Please don't take this the wrong way as I have a lot of opinions here, and you have a a valid suggestion. I've thought a lot about FABs over the course of FX's UI evolution...

I do like the FAB design when:

There's one clearly outstanding / important action.

It's not overlaying important content (e.g. when the content toward the bottom of the screen is less important).

Accidentally pressing the FAB isn't dangerous.

I thus like the idea of FABs in certain areas of UI, but strongly dislike them in others. A FAB is, by definition, "floating" over content. And by "floating", it's also obscuring the content behind it. I've seen various implementations of file managers (and other apps) where the FAB dissolves as you scroll down, and you can recall it by scrolling back up a tiny bit or with other gestures. Aesthetically they're very nice, but there's not much other benefit. The cool aesthetic comes at a high cost to usability.

For general browsing, I don't want a FAB present on the screen. In the same regard that I don't want one present in a web browser app. When you're reading/inspecting content, FABs need to not be in the way. They otherwise effectively reduce a 5" screen to a 4" screen.

There's also the "there can be only one" problem. A lot of apps work around this by turning the FAB into a menu that expands out, which is a design I've never cared for. At that point the app just has two menus, with some "important" options in the FAB menu and others in the action bar overflow menu.

When items are selected in FX, we replace the main action bar with an "action mode". I could see having a "cut" or "copy" FAB here but the problem is that we have five action options: cut, copy, delete, share, and archive. I couldn't choose between cut or copy for the FAB, and the other menu would be odd without one of those options (so we'd probably have to have both in the menu, and then the FAB would be redundant). With the present design all menu options are neatly tucked away in one place.

Another area where a FAB might make sense would be pasting clipboard content. I don't like the idea of using it to directly fire the "paste" action. Initiating a move or copy in the wrong place can be quite annoying to deal with (and FABs are easy to hit accidentally when scrolling). I wouldn't want to use it for "Paste" directly, but I have thought about turning the clipboard into a FAB, so that tapping it simply opens the clipboard drawer with "Paste" and "Clear" options. May have to try implementing this, but I do also like the clipboard design as-is.
[Android Apps and Games] fz798:
Excellent points, thanks for taking the time to be so thorough in your recommendation.

Carry on, and in the immortal words of Emily Litella, "never mind"

---------- Post added at 05:12 AM ---------- Previous post was at 05:11 AM ----------

Explanation, not recommendation, blasted autocorrect.
[Android Apps and Games] simonbellu:
[MENTION=2954544]tliebeck[/MENTION]

Trying to copy a video file from my device to Dropbox through fx cloud storage and the copy percentage progress is wrong. File was more than 320 mb. I am on marshmallow 6.0.1 and the last beta build of fx. See picture attached
[Android Apps and Games] GeTex:
You are showing the same kind of bug as me, is there enough room in the target destination?

[MENTION=2954544]tliebeck[/MENTION]

The privacy guard feature I used almost religiously at work :(
[Android Apps and Games] simonbellu:
Yes. Of course
[Android Apps and Games] peterbonge:
2 days ago I had the same problem with a 30 MB file and Google Drive on my Nexus 5X with Android O (Beta 4). As the app exceeded the final size the circle even started to go backwards. At 36 MB I stopped the transfer and looked at Google Drive and the file was successfully transferred.
[Android Apps and Games] tliebeck:
Thanks for reporting....what's the actual size of the file? Did the copy complete successfully?

Edit: also, when you click "transfers" and then on the completed transfer (in the left slide-out), do you see a "Transfer Fault" message, i.e., "Transfer interrupted and automatically resumed N times."?
[Android Apps and Games] simonbellu:
The size was 321.30 mb and I stopped the copy action after seeing the issue. The file was not copied in the Dropbox target folder...

Thank you for your answer!
[Android Apps and Games] peterbonge:
About the internal text viewer/editor:

- If I double tap a text in the editor (to select it) the toolbar gets hidden. That is extremely annoying.

- Why doesn't the editor have an option for line numbers like the viewer?

- Why doesn't the viewer have an option for line breaks like the editor?
[Android Apps and Games] mbc07:
Hey [MENTION=2954544]tliebeck[/MENTION], I recently purchased Tasker and noticed that it provides Quick Settings Tiles even through the APK is targeted to SDK 21 (!)

So, um, when possible, could you consider investigating the viability of a Quick Settings Tile, or at least discover how Tasker can provide tiles even through it's targeting Lollipop SDK? I think it would be a very nice addition to FX...
[Android Apps and Games] GeTex:
[MENTION=2954544]tliebeck[/MENTION] text editor could use fast scrolling
[Android Apps and Games] tliebeck:
Looks like it's possible, attempting to implement.

And by attempting, I do mean attempting. So far this API is just plain not good. Really want the icon to be grayed out when the service isn't running, and solid when it is. And would like it not to require that FX is running in the background to even display the state. Theoretically there's a way to get all of this done with the API. Docs are crap/nonexistent of course. So far the only way I've been able to achieve the desired behavior is to provide a forcibly dimmed icon for the "off" state, which doesn't look perfect on touchwiz (but does on stock).
[Android Apps and Games] tliebeck:
Fast scrolling isn't supported by Android's EditText component, which is what the text editor is based upon.

I'd have to write something myself, and interface with the mess that is the Android EditText code. The EditText code is scary. I once tried to fork the EditText code to fix a bug in it, but there were so many dependencies in it to hidden APIs deep in Android that I gave up. It might be possible to do, but it's a ridiculous amount of work.
[Android Apps and Games] tliebeck:
Thanks for reporting!

Selection issue appears to be vestigial and is being removed for next release. And agree on the annoying.

The reason for the two "why" items is the underlying Android APIs. Both are solvable, but the amount of work and pain involved in getting there is pretty high, to the point where other stuff has been prioritized in front of it.

I'm not sure if line numbers are possible while using a stock Android EditText component. I don't want to break away from the stock one and add a ton of code to FX in doing so. The whole Android TextView/EditText API is a giant dependency nightmare.

With a good API, it would be trivially simple for me to just ask the EditText "hey, what lines are you displaying, and what are their baseline coordinates, and notify me when that changes". And then I can write my own "line number" view that sits next to it and keeps in sync.

Line wrapping (or rather non-wrapping) in the text viewer is possibly more straightforward, but still likely a couple of days work.

I realize this sounds insane, but Android is one of the most difficult APIs I've ever worked with. They did not spend much time or effort thinking about designing components to be used outside of their basic purposes. And they did not spend ANY time documenting it.
[Android Apps and Games] GeTex:
Retracting previous statement
[Android Apps and Games] tliebeck:
No need to retract the statement, you're absolutely right that it needs fast scrolling, and if I can find a way to add it without rewriting EditText, it'll be added!