yashsingh1/xdaforums huggingface dataset:
[Optimus One, P500 Android Development] Martin "skunk" Rotter:
Hi i have to say that i saw source code for this recovery and i saw some difficulties in it. I gotta say that i am C/C++ developer and i would like to help make that code slimmer.

For example that code in bootloader.c. I mean those get_bootloader_message_block (set_bootloader_message_block) functions. They are pretty similar -> only differ in ONE line. SO why to type two functions if they are doing pretty the almost same thing? This could be (quite elegantly) solved by one more parameter. Perhaps..

static int operate_bootloader_message_block(struct bootloader_message *out,
const Volume* v, int getP) {
FILE* f = fopen(v->device, "rb");
if (f == NULL) {
LOGE("Can't open %s\n(%s)\n", v->device, strerror(errno));
return -1;
}
struct bootloader_message temp;
int count = fread(&temp, sizeof(temp), 1, f);
if (count != 1) {
LOGE("Failed operating %s\n(%s)\n", v->device, strerror(errno));
return -1;
}
if (fclose(f) != 0) {
LOGE("Failed closing %s\n(%s)\n", v->device, strerror(errno));
return -1;
}
if (getP == 1)
memcpy(out, &temp, sizeof(temp));
return 0;
}

And then simply call this function with int getP = 1 -> get_bootloader_message... and with 0 -> set_bootloader_message...

I see tons of this redundant code there.
[Optimus One, P500 Android Development] franciscofranco:
Good suggestion. It makes the code more elegant, slimmer and easier to read as well, just like you pointed out.
[Optimus One, P500 Android Development] kbzona:
Yeah thnks for pointing that :) ... there are still some minor things that i want to change, and then i'll start cleaning (also you're welcome if you want to help me @Martin)
[Optimus One, P500 Android Development] Martin "skunk" Rotter:
OK.

I will tak a closer look in that code later. I am glad to help.

:)
[Optimus One, P500 Android Development] kbzona:
A minor update again...

2011-08-21 v1.0.3.7

- Google backup now doesnt create 0kb files and works correctly

- Cleaned some unused portions of code

Download:

---------------------

TWRP-ThunderG-v1.0.3.7.zip
[Optimus One, P500 Android Development] kly91:
I found a problem while using the .35 version on p500..I used "wiped all" or the factory reset and flashed a new rom..after reboot i went to root directory and found out that my ext was not actually wiped i still have the apps there that i have before wiping..was that normal or was it really supposed to be untouched because with CWM i ussually have a clean ext after doing a full wipe there..
[Optimus One, P500 Android Development] kbzona:
Is intended to be that way so it wont screw cachesd features in a2sd scripts...

Prefer format menu --> format Sd-ext to delete absolutely everything contained in sd-ext (just like CWM :cool:)
[Optimus One, P500 Android Development] kly91:
oh. I see..;)
[Optimus One, P500 Android Development] lerkin:
have same md5 errors with ext4 second partition.

may it be because of link2sd incompatibility?
[Optimus One, P500 Android Development] dr.notor:
Yeah, all good now, LOL. :D
[Optimus One, P500 Android Development] Omnichron:
Can it be flashed over CWM?:confused:
[Optimus One, P500 Android Development] sweetnsour:
http://xdaforums.com/showpost.php?p=16663434&postcount=3
[Optimus One, P500 Android Development] dr.notor:
@kbzona: There really is something very broken with /data backup. I cannot back it up no matter what. All other partitions work just fine, /data always crashes on md5 creation and goes back to menu.

...Generating data md5...
sh: cd: line 1: can't cd to 08101EDF16C4E65D895AB45144A0E4D41.xml
....Done.
...Verifying data md5...
sh: cd: line 1: can't cd to 08101EDF16C4E65D895AB45144A0E4D41.xml
....MD5 Error: cd 08101EDF16C4E65D895AB45144A0E4D41.xml && md5sum -c data.win.md5
Starting recovery on Wed Aug 24 18:12:25 2011
framebuffer: fd 4 (320 x 480)
recovery filesystem table
=========================
0 /tmp ramdisk (null) (null)
1 /boot mtd boot (null)
2 /cache yaffs2 cache (null)
3 /data yaffs2 userdata (null)
4 /misc mtd misc (null)
5 /recovery mtd recovery (null)
6 /sdcard vfat /dev/block/mmcblk0p1 /dev/block/mmcblk0
7 /sd-ext ext4 /dev/block/mmcblk0p2 (null)
8 /system yaffs2 system (null)

I:Set boot command "boot-recovery"
Command: "/sbin/recovery"

...Generating data md5...
sh: cd: line 1: can't cd to 08101EDF16C4E65D895AB45144A0E4D41.xml
....Done.
...Verifying data md5...
sh: cd: line 1: can't cd to 08101EDF16C4E65D895AB45144A0E4D41.xml
....MD5 Error: cd 08101EDF16C4E65D895AB45144A0E4D41.xml && md5sum -c data.win.md5
Starting recovery on Wed Aug 24 18:23:28 2011
framebuffer: fd 4 (320 x 480)
recovery filesystem table
=========================
0 /tmp ramdisk (null) (null)
1 /boot mtd boot (null)
2 /cache yaffs2 cache (null)
3 /data yaffs2 userdata (null)
4 /misc mtd misc (null)
5 /recovery mtd recovery (null)
6 /sdcard vfat /dev/block/mmcblk0p1 /dev/block/mmcblk0
7 /sd-ext ext4 /dev/block/mmcblk0p2 (null)
8 /system yaffs2 system (null)

I:Set boot command "boot-recovery"
Command: "/sbin/recovery"

:(

There was no such problem in previous versions (my last backup is 4 days old, worked without problems.
[Optimus One, P500 Android Development] Omnichron:
Thanx! Being the adventurous type I went ahead and flashed it over the old rec. Works perfect!:D
[Optimus One, P500 Android Development] Omnichron:
How do I theme it? dl link for themes?:confused:
[Optimus One, P500 Android Development] dr.notor:
You choose a theme in settings menu. Do not download anything.
[Optimus One, P500 Android Development] kbzona:
Mmm, im having the same problem, tried to install an old version and even v1.0.3.1 cant backup anymore :confused:LOL....

This is very weird, maybe v1.0.3.7 screwed something that we are not seeing :(

Tried every version i've compiled and no go...

Well i'll need to investigate more thoroughly as soon as possible :(

ps: could you confirm that you have the same behaviour even in this older version
[Optimus One, P500 Android Development] jobankler:
will it work on the LG phoenix too?
[Optimus One, P500 Android Development] dr.notor:
Tested with 1.0.3.5 and 1.0.3.2 - no dice. (Also, someone above reported the same with .android_secure). :mad:

I do not really understand WTH does it try to cd to some whackynonexistent.xml folder when doing md5sum?!

EDIT: I flashed AmonRa - no issue with /data backup, CWM 4.0.1.5 - also no issue with that. Also, the backup made via TWRP actually looks OK and complete, if you create the md5 manually, you can restore it just fine. WTF.
[Optimus One, P500 Android Development] kbzona:
Well problem solved, BTW, CWM and AmonRA handles md5 a little bit differently and ( perhaps in a more inefficient way) that why ti works... Anyway now its working it was a matter of a too long string thing...

*Download updated on the first page*
[Optimus One, P500 Android Development] ghost_141:
I installed TWRP-ThunderG-v1.0.3.8.zip, but the recovery menu appears TWRP-ThunderG-v1.0.3.7. :(
[Optimus One, P500 Android Development] DaXmax:
Receive ur pm earlier... Btw, actually i have no probs with dat... An again, u forgot to change the version number..

Sent from LGE Secret phone using tapatalk app... >DA×<
[Optimus One, P500 Android Development] dr.notor:
Yeah, works now. :cool:
[Optimus One, P500 Android Development] kbzona:
Ooops yeah sry forgot that, i'll change it as soon as i get home :D
[Optimus One, P500 Android Development] kbzona:
There you go! :D

2011-08-25 v1.0.3.8

- Now md5 generates correctly (no more backup md5 errors, specially for "data" backups!)

- More code cleaning

- changed version string to v1.0.3.8 :)

Download:

---------------------

TWRP-ThunderG-v1.0.3.8.zip
[Optimus One, P500 Android Development] Jaani:
@kbzona

thanxxx for the porting..:)I just replaced CMW with this..its looking nice..the only thing i wish from this is that it do not screw the DT a2sd script when updating kernel(usually get hang on red LG logo) & sometimes when rebooted normally..can u add option am/pm in clock???
[Optimus One, P500 Android Development] dr.notor:
I am afraid that has nothing do with kernel flashing or this recovery and everything to do with using the reboot recovery option in power menu resulting in unclean reboot and subsequent fsck. Simply do not use that.
[Optimus One, P500 Android Development] Bec de Xorbin:
Very nice, but seems quite slow compared to AmonRa.
[Optimus One, P500 Android Development] jobankler:
i asked about 3 times already! but everyone ignores my question! will this work for LG P505? (LG Phoenix)
[Optimus One, P500 Android Development] Bec de Xorbin:
Both are basically the same phone? If so, I don't see why it shouldn't work.
[Optimus One, P500 Android Development] kbzona:
What is slow?

If the ones posted here do work, then this will work too...
[Optimus One, P500 Android Development] Bec de Xorbin:
Opening wipe menu for the first time for example. But that's not too bad, just saying.
[Optimus One, P500 Android Development] kbzona:
Ohh i see, thats because of batt and clock update features... :P
[Optimus One, P500 Android Development] fernando1sg:
how do i go back to amon_ra ( because i cant perform a nand back up ) i tried with sdcard/nandroid folder and TWRP/BACKUPS/placed it here but it doesn't work soo, how do i go back to amon_ra or can you tell me why it isn't working?
[Optimus One, P500 Android Development] kbzona:
Please post recovery log (in TWRP --> Advanced menu --> copy recovery log)....

Without this i cant really tell you whats happening....

PS: if you want amon_ra, simply flash it over TWRP... thats all
[Optimus One, P500 Android Development] dr.notor:
Well, nah... I guess what he means is that he took the TWRP backups and is trying to subvert them to AmonRa or similar whacky stuff. Well, lulz. :D
[Optimus One, P500 Android Development] samcad:
I will try latest one soon after getting home :)

Sent from LG O¹ • miks cyanogen7.1 with latest testing release kernel v1.1 and v19.3♦• using tapatalk
[Optimus One, P500 Android Development] shhbz:
Congrats on this great recovery project . Loved it swift and fast peform evrything great just need to check backup rom stuff
[Optimus One, P500 Android Development] dr.notor:
OK... back again to the signature verification stuff. Has it ever worked properly? Cause I have quite a bunch of edify ZIPs signed with the testing key and it never works. :confused:
[Optimus One, P500 Android Development] fernando1sg:
what is the file called exactly cuz i tried with windows search on the drive with the keyword "log" but i got many from other apps so what is the log called?
[Optimus One, P500 Android Development] shhbz:
well a great recovery all together but hoping if anything can done to lessened the backup process in complete compressed mode it took 18 minutes.

apart from it truly great stuff
[Optimus One, P500 Android Development] kly91:
Hi sir..i did a format sd ext but the old files were still there after rebooting..and i had a problem with the backup and recovery too..i have checked all the parts to be backed up in nandroid..the lines on the recovery indicated that all those checked were successfully backed up but after rebooting back to system i went to check on the backup folder of the recovery but all i found was the md5 file and the system backup..nothing on the others..
[Optimus One, P500 Android Development] kbzona:
Zip signature verify ****... FIXED

2011-08-27 v1.0.3.9

- Fixed zip signature verification

Download:

---------------------

TWRP-ThunderG-v1.0.3.9.zip
[Optimus One, P500 Android Development] signumized:
Thank you for your great recovery. Its great that you pay attention to suggestions brought by users. This way I have a suggestion too. Could you please list the selected zip file name wrapped (at least after it has been selected for flashing) ? This way the user could easier know what file will flash. This happens with long file names, such as releases from mik, where the ROM version is put last in the file name. Currently only the first part of there name is shown.( of course the file could be renamed before flashing)

I hope I was clear enough with the suggestion. Thank you.
[Optimus One, P500 Android Development] cupliz:
Lol, dr.notor has gone (again) so i think update will slower than yesterday... cuz he always give his critics for your work... than, we wait, maybe he comeback (again)...

Sorry for off topic...

Sent from my LG-P500
[Optimus One, P500 Android Development] leolawliet:
Sorry if this is a noob question, but I was wondering does this recovery works on Optimus V?
[Optimus One, P500 Android Development] sweetnsour:
nope. optimus one stuff will not work on the optimus v
[Optimus One, P500 Android Development] leolawliet:
Alright thanks for the immediate response.
[Optimus One, P500 Android Development] Abhiroxx:
anyone facing problems with gapps with this recovery??
[Optimus One, P500 Android Development] Abhiroxx:
problem solved after flashing gapps again :)
[Optimus One, P500 Android Development] kbzona:
For further recovery development:

Mod Edit: External link removed, per forum rules.
[Optimus One, P500 Android Development] ElevateMusic:
What the hell crawled up this guys ass? lol we ain't bad people right?
[Optimus One, P500 Android Development] kbzona:
WTF??? I'm not saying that there are bad ppl here.... at least for me is a matter on how the things should be managed here, and that mods wont do anything to fix problems here, and they knew what we were asking and we were left unheard. And of course the nazi way to do their stuff (banning ppl without a valid reason)...

To summarize, mods in XDA sux and thats why i myself decided to move on to place that is XDA mods free :cool:..... If you like it or not, i do not really care...
[Optimus One, P500 Android Development] DaXmax:
Wad password u use? I cant sign up... :(

Sent from LGE XDA phone wit CM7 6.6.1
[Optimus One, P500 Android Development] lekhwani:
Your password should compulsorily be a mix of these 3:

Capital letters

Small letters

Numerals

Example

Hary56238

At least one capital letter is required.
[Optimus One, P500 Android Development] kbzona:
}letters and numbers and must have mixed case
[Optimus One, P500 Android Development] DaXmax:
@ lekhawni and kbzona,

Yea, tmrw morning im registering it...

Sent from LGE XDA phone wit CM7 6.6.1
[Samsung Infuse 4G] Guti1977:
To be honest, I haven't try one yet but I was hoping that someone already did. :-)
[Android Themes] carlospr21:
Share your carrier logos here

You Need to have Extended Settings For This to work

if you don't have Extended Setting you can grab it HERE by: Andy Thomson

Latest Versions

Thanks to XAviierG for the instructions on how to apply

Go to system < app and copy systemui to any file on your SD card. Then rename it to systemui.zip and extract it. Find a picture you want to use and name it carrier_logo.png and drop it into drawable-hdpi and overwrite the old one. Then zip back up the folder and drop it back in system app and when you overwrite it you will get continuous fc. Just reboot. When you reboot you'll have no status bar just go back into system<app and change the properties and reboot and it should be all good! If its all blurry and big its either two reasons. The picture is too big or go to settings < system < date and time settings < carrier name settings < and make sure custom carrier text is check and in the box its blank.

or

like how i did it with miui 1.8.12 and will work on newer miui if u have extended settings

if u have a theme just put the carrier_logo.png in com.android.systemui\res\drawable-hdpi

and apply it in theme manager

and if u have a custom name on your carrier erase name and leave it in blank

post screen shot to see if it work

here is the carrier logo mtz for u to test

how to apply: theme manager/edit theme/status bar

carrier logo mtz test

here is a blank .mtz for those that need it all u need to do is open it and drag every thing u want in it a put it in ur sdcard

dont worry about converting cuz theme manager will do it automatically for u

blank.mtz here

more logo @macthemes [Theme] Carrier Logos

credit for logos the ppl over @ macthemes
[Android Themes] carlospr21:
icon by: rmg2

Brand Car Logo Pack1 by: rmg2

Brand Car Logo's Full Pack OVER 200 Brands by: rmg2

Gucci By: rmg2

DOPE logo

adidas logos

icons by: Raadius

Nissans cars by: DuckySpud

T-Mo Logos by: 3Shirts
[Android Themes] XAviierG:
Nice icons! :)
[Android Themes] SignalX:
thanks carlospr!! how can i use them?

really nice :)

cheers,

SX
[Android Themes] carlospr21:
need extended settings

Go to system < app and copy systemui to any file on your SD card. Then rename it to systemui.zip and extract it. Find a picture you want to use and name it carrier_logo.png and drop it into drawable-hdpi and overwrite the old one. Then zip back up the folder and drop it back in system app and when you overwrite it you will get continuous fc. Just reboot. When you reboot you'll have no status bar just go back into system<app and change the properties and reboot and it should be all good!
[Android Themes] amf3:
how do you get extended setting?
[Android Themes] carlospr21:
here u go

[MOD] Extended Settings Menu Options
[Android Themes] XAviierG:
Get the center clock one. To be safe.
[Android Themes] amf3:
Thank you sir! :D
[Android Themes] carlospr21:
just added some more icons
[Android Themes] SubyWill:
Can anyone here make me two custom ones? :D
[Android Themes] o0k00l:
Can have HUTCH logo ??.. Thanks in advance .
[Android Themes] Th3_Ghost:
i am not quite good in english so you'll have to excuse my bad english, i just have an idea don't know if it's possible to do . But i'am a noob with my galaxy but can somebody make an mtz with only the carrier logo inside ????
[Android Themes] andyjjc:
thanks :
[Android Themes] lost_man10002:
awesome dude thanks for sharing !!
[Android Themes] baxadfrukt:
this is just.. wonderful!

Thank you

Edit: I didn't get it to work. It's just blank :)

"go to settings < system < date and time settings < carrier name settings < and make sure custom carrier text is check and in the box its blank." <- Check!
[Android Themes] dieselletwo:
Hey guy's i m on miui 1.8.5 and i have install advanced settings and now i have a bootloop :( An idea ?
[Android Themes] fireymint:
How do i add in the new carrier logo into systemui? WinRAR doesnt allow me to
[Android Themes] fenricketts:
I fillers the instructions but I am at the point where you have to reset the setting I have no status bar. Can someone walk me through please.
[Android Themes] HarlanPepper0010:
Yeah, tried both... Oh well back to the drawing board...

Do the chickens have large talons??
[Android Themes] danielrod:
I think missed calls is in the framework-res/res/drawable.hdpi of themes. Should be stat_notify_missed calls or something
[Android Themes] danielrod:
You could send me a copy of the theme and the icon you want to replace it with and I'll see if I can figure it out?
[Android Themes] HarlanPepper0010:
I may pm you in a bit Tia...

Do the chickens have large talons??
[Android Themes] chill145:
yep tried that and nothing has changed

edit: just tried ninjamorph and in the past i would always cleanup projects with no problems, didn't cleanup this time and voila. magic

taken from another thread and the steps i've followed in the past and worked. this phone was the only one ever to cause me problems. the joy i feel at the moment is kind of scary

http://www.droidxforums.com/forum/d...ninjamorph-change-notification-bar-icons.html

the 3rd post, Faster way to modify pngs using Ninjamorph
[Android Themes] HarlanPepper0010:
Success!

Do the chickens have large talons??
[Android Themes] SoCalSpecialist:
i say we all posts our newly created MTZ's. some of these have come out really sick.
[Android Themes] djnoicatse:
Wondering if anyone can make one with the Rogers logo?

Thanks in advance

Sent from my Google Nexus S
[Android Themes] WormDoes:
There are a number of rogers icons in the thread from mac themes linked in the OP
[Android Themes] Lex_407:
Can I have that mtz sir.
[Android Themes] WormDoes:
Love this! Was wondering is there anyway you could make it in white? Thanks in advance
[Android Themes] 151jcolon:
I will try to release it tomorrow ....:-)
[Android Themes] GingaB:
Dude what font are you using?
[Android Themes] carlospr21:
sorry for the delay been busy bro but here u go enjoy

com.android.systemui\res\raw

Battery Request Granted
[Android Themes] danielrod:
Thank you so much dude, they look great!
[Android Themes] carlospr21:
no problem
[Android Themes] hailtothethief83:
Hi all!! Wondering if after I install the extended settings mod can this all be done on the phone its self or does it have to be done with a computer? Still not fully understanding how to complete this mod...

Also wondering if anyone can make this a carrier logo as well... picture attatched but the writing in white not black. Thanks in advance for the help!!
[Android Themes] chill145:
Finally switched things around

Yada Yada
[Android Themes] carlospr21:
Afther u added the extended mod center u will get a google carrier logo how change it u change by mtz look at op for more info

And as for the logo u requested as soon as i get on a pc ill mod it for u
[Android Themes] carlospr21:
I dont know if i have that bear can u upload it
[Android Themes] chill145:
yeah no problem
[Android Themes] vibrant808:
hi, when I try to apply the theme i get the message that it doesnt have the appropriate resources. Anyone know whats up? What I did was get an .mtz, extract it, then I extracted the systemui and put the png in there. I zipped the systemui back and replaced the original file with that one, then zipped the mtz back.
[Android Themes] XAviierG:
Does anybody have any good hello Kitty ones?
[Android Themes] WormDoes:
Friendly Bump

Hey Carlos, could you make one that says Worm in this same font in white? I have some ps/gimp skills, but not fully there to make this yet. Thanks!
[Android Themes] axman79:
Transparent status bar with carrier logos from this thread
[Android Themes] Blanko6:
Could you tell me where you got the icons from? I been looking for them! Thanks
[Android Themes] carlospr21:
i can try but i dont have those font in the pic if u want tellme what font u want and ill make it for u
[Android Themes] vetvito:
Carlo can you post the bear you have for me? Just the pic
[Android Themes] carlospr21:
here u go
[Android Themes] buzzwyzr:
The Xiaomi M1 logo for their new MIUI powered phone.
[Android Themes] carlospr21:
Looks great
[Android Themes] fourire:
When you told change permission to match to the other one but what is the details of original ? I think it's very important in your explanations because for now I don't have the status bar... I made a change (replacement of one .png) in systemUI.apk but the status bar didn't appear
[Android Themes] jackfrost3821:
Hey you need to share your status bar icons, the battery mod and Abstergo Industries Logo I assume which refers to wifi signal strength(not sure though). Can you please provide link?

And how did you get screen indicators at bottom?

EDIT: Got your .mtz file but still question is how to get those screen indicators?
[Android Themes] XAviierG:
Read write

Read

Read
[Android Themes] XAviierG:
Anybody found a hello Kitty one? Or can make one for me :D
[Android Themes] amf3:
Here mine :D
[Android Themes] WormDoes:
It's ok, thanks anyways. I wanted it in that font.

Does anyone know the name of it by chance?
[Android Themes] fourire:
That's what I got ...so what is the reason I couldn't see my status bar ?
[Android Themes] mrbubba999:
Could you post the image file for the coloured stars?

thanks
[Android Themes] chill145:
yeah absolutely, they are purityfs found here http://xdaforums.com/showthread.php?t=1028010

however i took them from here http://forums.miuiandroid.com/showt...-for-MIUI-1.7.15-Dark-just-got-darker!!-FINAL

should be any version except final because that uses signa but just download and apply just icons in theme manager
[Android Themes] KasiCatastrophe:
That was either Set Fire To The Rain or Blessings Through Raindrops. I can't remember exactly which one.

I have to see if I can find it again. I wasn't satisfied with the way it turned out so I thought I had deleted it, but I'm searching my computer right now for it.

EDIT: Here you go. Found it.