yashsingh1/xdaforums huggingface dataset:
[Android Apps and Games] tolol:
i use sdmaid appcleaner, suddenly my app, 17track lose its data all the tracking code i have input are gone.

i'm using oreo on xperia G8142
[Android Apps and Games] Dark3n:
v4.9.5 is out with a few bugfixes and databases/translation updates.

Working in parallel on improving the duplicates tool which will come in a v4.10.0 release.

Aiming for a more fluid UI that doesn't hang when doing auto selection on thousands of files (new UI architecture via https://github.com/d4rken/ommvplib doing one tool at a time) and a smarter auto selection process.

The autoselection will just run when pressed and there will be a new "autoselection config" screen that will allow to tweak it.

Atm it looks like it will be a list with sortable "criteria" where you can choose what is more important, e.g.:

Priority 1: Remove duplicates from primary storage and keep on secondary storage

Priority 2: Prefer files with older creation dates

Priority 3: Prefer shorter names

etc.

So autoselection will no longer just use one criteria but multiple and the user will be less confused which option to pick, because there will be a smarter default one that's still tweakable.

I'm also adding new criteria such as "prefer duplicate files that are part of the media database" (e.g. shown in galleries).

[MENTION=1666590]tolol[/MENTION] Either add an exclusion or make a ticket on GitHub with details and an argument for/against adressing this via update.
[Android Apps and Games] Fahrilubis:
Dude can u tell me how affect if i turn off boot completed message? Can i still get message? Or?
[Android Apps and Games] pakitos:
I keep wanting to reinstall SD Maid but I don't think my S8 will ever be rooted. ADB would be nice.

Will check later on if there are translations to be done :p
[Android Apps and Games] IronTechmonkey:
Frequent ROM flashing typically has me using SD Maid minimally but I love a nice duplicate finder. Along the way to testing it on a messy media collection there has been this possible bug: FC when dragging autoselection elements.

SD_Maid-v4.10.0(41000)-BETA-7d7a98ee9 installed on top of previous Playstore update to Pro (moving fast I neglected to check if that is OK) on Moto G3 Osprey running LOS 14.1 (N 7.1.1) w/ LOS SU, and where display properties may be a factor Settings > Display > Font size = Largest.

Attached log spans:

- Open SD Maid

- Go to Duplicates

- Overflow (3dot) menu

- Configure Autoselection

- Grab by 2-line icon and drag until covering another item in the list.

- FC

- Can reproduce and log else-wise if need be.

[EDIT] Added to issue tracker: https://github.com/d4rken/sdmaid-public/issues/1483
[Android Apps and Games] ogisha:
Hi [MENTION=608746]Dark3n[/MENTION],

I had never used Duplicates module before, so after your recent changes I decided to give it a try.

I have my download folder from internal storage binded with Apps2SD to external storage. Duplicates show me that I have duplicate files in two download folders, one in internal and one in external storage, but actually I have them in external download folder only.

Is there anything that could be done about it?

I did not found anything about it in settings.

Thank you.
[Android Apps and Games] Dark3n:
The current solution is to add an exclusion for one of the pathes.

The best solution would be for SD Maid to detect that this is the same folder but I've not yet come up with a way to reliably detect this.

You are more than welcome to help out. Come up with a good solution and I'll add it.

See https://github.com/d4rken/sdmaid-public/issues/870
[Android Apps and Games] Dark3n:
v4.10.1 is out.

I've fixed reported crashes (thx [MENTION=5119654]IronTechmonkey[/MENTION] ) and spend time rewriting quick access and other progress related feedback to improve performance. In some case there were multiple dozen callbacks per second which just wasted UI resources. I've limited this to ~70ms update intervals which is about the lower edge of delay at which humans can notice motion.

Using ConstraintLayout I've also made several UI hierarchies flatter which should also improve performance when redrawing elements to display progress updates.

Now that the duplicate criteria screen no longer crashes, I'm looking for some feedback on the texts/wording of each option before they are made translateable.

http://sdmaid.darken.eu/changelog

http://sdmaid.darken.eu/issues﻿

http://sdmaid.darken.eu/download
[Android Apps and Games] viralvacancy:
Love the idea about user filters

Tonight I spent about a half an hour searching the web for any pages where I could find downloadable user filters without any luck. I did however stumble upon this thread and read your posts about the potential addition of some sort of user filter system within the app its self. I think this is a fantastic idea. I also think that features of this type that allow users to become more involved with the app can really help grow your user base as a whole.

Again I would absolutely LOVE to see this feature in an upcoming version of SD Maid.

BTW. After reading a few of your posts on this thread I have to say I am extremely impressed by both your app and how responsive you are to your customers. Most Developers do not make themselves nearly as accessible as you seem to have & I certainly appreciate it. :good:
[Android Apps and Games] Dark3n:
[MENTION=4684338]viralvacancy[/MENTION]

There is no website that I'm aware of where people share their filters. I had some hope someone might do that.

I find the idea of crowd sourced filters enticing.

An external download system would be cool, but it is also stuff that has to be maintained.

Let's assume someone makes this. I can't just integrate an external source as people expect everything to be safe, so I have to review stuff coming from that 3rd party source, at which point I have to ask myself why not skip this inbetween and just add them via update.

A compromise could be a system where people can add a "source" manually into SD Maid (at their own risk), which would remove the expectation for me to review it all.

Before such a site evolves though I would expect there to be more talk and discussion about addition of specific filters. I would expect more involvement. If you look at GitHub, XDA or elsewhere, there are few to none discussion of people sharing their self-made filters. I've seen less than a dozen posts where someone shared a custom filter they made.

I expect this to organically evolve if there is need for this. I imagined the following scenario:

An increased interest in this leads to more discussion and suggestions regarding this topic on GitHub or XDA. I think platforms where you are most likely to find the people most knowledge about filters/code etc. to be the most reasonable choice to discuss them, share them. Especially as most filters I see need some to work safely on all devices, e.g. replacing part of the base path with a "LOCATION" specifier, as not all devices use "/storage/emulated/0" etc. If the suggested/shared filters are not generally useful enough to be added into the app, we could collect them, e.g. in the github repo. If this is repeated enough times that there are a bunch of filter files, it would make much more sense to invest time to somehow make them availble via in-app interface. A dialog with a "paste link here" option would be a good intermediate step.

GitHub might not be the most "noob" friendly environment, but any such filter sharing site definitely needs fixed states for each filter and review systems such as the ones offered by source control platforms (e.g. github).

"Uploading and sharing filters" from in-app screens can be build on top of that but we have to keep in mind that this also leads to a lot garbage. I mean this is an issue in any case. You currently have to sign up to Github to use the in-app clutter report tool and it doesn't keep people from submitting weird stuff, or just bad reports.
[Android Apps and Games] IronTechmonkey:
In case it is not too late for this feedback: The wording of the duplicate criteria categories is IMO quite good, freestanding, and explains them well. One minor suggestion: A way for users to reset the default order of the duplicate criteria. Assuming the default arrangement exists for a reason, users who are experimenting with the arrangement might want to return to the default and may not remember what that was.

Incidentally there were 2 things which occurred during this testing in 4.9.5 and did not occur v4.10.1. These may be known issues that are fixed fixed but in case not:

1) Phantom selected items. While scrolling the list to modify some of the auto selections selections, sometimes 2 mutually exclusive items will appear to be selected but upon attempt to de-select one of them the warning about selecting all of them appears as if the second one.

2) Invoking LMT pie would cause a screen refresh and de-select all items.

As mentioned, these are probably just fixed issues and do not occur in v4.10.1 but if more information is needed I can provide it.

In any event the duplicate finder settings are so much fun and I almost wish my device was dirtier.
[Android Apps and Games] Dark3n:
That what I like so much about developing Android apps, never to late, can always update :). Thanks for the feedback. I'm always a bit unsure about how to word text.

There duplicates settings have a "reset to defaults" option in the menu since v4.10.0 which also resets the criteria. Do you think a "sub setting reset" just for the criteria is necessary? The default arrangement is just what I thought most people would prefer, I could be wrong about that... have not gotten negative feedback on it though.

I was not aware of this. It sounds a bit like the "selected" flag gets set for list items, but when the list is scrolled and elements get reused (the list is a recyclerview), the flag might not be correctly cleared. The duplicates tool is the only one i reworked yet, so all other lists with multi selection might still be affected by this. If this can be consistently reproduced I'd welcome a ticket about this.

Invoking LMT pie is like opening an extra app on top and will trigger SD Maids "onPause" method. The old code had trouble keeping the UI data in sync with the backend data of SD Maid. In some cases I took the cheap way out and finished the ActionMode if an onPause event happens. The new code just handles this better. I think it's okay to just leave this as is and wait till I had time to rework the other tools.

:D
[Android Apps and Games] Freak3672:
Resolved!

ThankYou again. ?✌
[Android Apps and Games] IronTechmonkey:
D'oh! I neglected to try that. IMO no need for a redundant one.

That seems like a reasonable priority for the most commons usage scenarios (and the fact that I would immediately change is an incidental indicator of that).

Having done some more testing, I can reproduce this 100% but, this might almost be called an incomplete feature rather than a bug. It turns out not to have been the act of tap-drag when initiating the next scroll action that caused the duplicate selection, but rather it can be caused by a long press:

- Scan (for purposes of this test - looking for one duplicate pair).

- Autoselect = one of each is item selected.

- Long press the unselected item of a pair = both apparently selected.

- Tap either of the 2 selected items = Error toast "One of each clones has to stay unchecked..."

- Long press either item in test pair = it becomes unselected.

So; should the selection of all items in a group be impossible, or should it be allowed with a warning? I assume the former, but in any event, I'll log and post this to the tracker.

Thanks for the explanation. All "normal" things (eg; not tasker macros with notifications etc) which might be done with Pie can be done from QT which does not cause the same thing in v4.9.5, and there were no issues (not even screen flickers) in v4.10.1 under same conditions.

One additional thing from v4.10.1: In Quick Access, after scanning (CorpseFinder, SystemCleaner, AppCleaner); tapping "Run now" immediately deletes the items without the confirmation prompt. I can reproduce and log this as well.
[Android Apps and Games] Dark3n:
The selection should not be possible, the deletion code will check this against and reject it, but the UI should not have allowed it.

This is less problematic though if this is not triggered by a drag/scroll event because the restricted selection is only used by the duplicates tool.

Not sure what is going on there then...

That's a bug, good catch. :good:
[Android Apps and Games] hilmanRaz:
hello darken, I've been using your app since 2015. but lately there are some applications in my phone that should not be cleaned because it will interfere with the smoothness. can I choose which applications will be deleted cache etc?
[Android Apps and Games] Vagelis1608:
Add them to Exceptions ( the pin icon, I think )
[Android Apps and Games] Dark3n:
How is v4.10.4? Are we ready to retire v4.9.5?

I thought v4.10.3 was ready, but some internal UI changes coupled with a buggy support lib 27.1.0 caused UI issues when switching pages/rotating the device...
[Android Apps and Games] Vagelis1608:
Seems good to me.

Also, I don't know what the main translator to Greek is doing but...

Oh, wait... That's me...

Yeah, the translation is looking great! :p
[Android Apps and Games] Dark3n:
Alright everyone, [MENTION=4849551]Vagelis1608[/MENTION] gave the go ahead, everything except Greek is fine!

SD Maid v4.10.4 is moving out of beta to replace v4.9.5

There have been many changes, large and small, I'll give you a quick TL;DR here, but for all details check the changelog.

The duplicates tool has been overhauled with a new UI and an automatic way of selecting which duplicates to keep. SD Maid will make the decision for you, but you can influence that decision by tweaking/rearranging criteria. Deletion is also "smarter" and will ensure that no "empty images" are left in galleries after deleting duplicates.

Finally an adaptive icon, though the "effect" is subtle ;).

Various small UI improvements, faster layout, improved dialogs and more.

StorageAnalyzer should no longer choke and abort on missing items.

I'm overhauling SD Maids internal UI framework to improve responsiveness and allow me to build complex interfaces more easily. QuickAccess, Exclusions and Duplicates have gotten that overhaul so far, other tools in future updates.

Some internal default exclusions are now part of the normal exclusion manager and can thus be removed if so desired.

Added a workaround for Nokia ROMs to fix permission setup. The new Android 7.0+ way doesn't work and SD Maid will show the manual selection on these Nokia ROMs as fallback.

http://sdmaid.darken.eu/changelog

http://sdmaid.darken.eu/issues﻿

http://sdmaid.darken.eu/download
[Android Apps and Games] Oswald Boelcke:
Haven't certainly not tested every feature yet since I've installed v4.10.4 about 24 hours ago. However, haven't had any issues since then, all working and everything functionable; superb application (as usual and to be expected).:good:

In my opinion, ready for public roll-out and ready to retire v4.9.5!:)
[Android Apps and Games] IronTechmonkey:
Looking good here apart from the minor issue regarding the absence of the confirmation prompt when deleting found results in Quick Access. If that persists in the release I'll enter it into the tracker (I should have done this sooner, sry).

Previously discussed issues with LMT are all on LMT (have seen similar in other apps) and those things don't occur with 4.10.4 anyhow.

Since the unintended and seemingly impossible duplicate selections were related to long press rather than scrolling, and with that no occurring in 4.10.4 I did not bother reporting that to tracker but will watch out for that.
[Android Apps and Games] Dark3n:
v4.10.4 is the release version, the confirmation issue should be fixed. It won't show though if you have the single pass option enabled.
[Android Apps and Games] Dark3n:
I've initiated a discussion about "paid unlocker" vs "IAPs" on G+: https://plus.google.com/b/116634499773478773276/+darken/posts/BxpkyPwQ6Vq

I'd love to hear your thoughts on that either here or on G+.

Examples or experiences from other developers with this are also very welcome.
[Android Apps and Games] Shyam Bairi:
[MENTION=608746]Dark3n[/MENTION] Thanks for this wonderful app.

I'm novice but would like to suggest my thought.

If you really want to change from paid unlocker to in-app purchase system, you must do that as soon as possible. With passing time, more and more users will buy unlocker, leading to more difficulty in transition.

For transition,

1. Update the free app with free app + in-app purchase system + a pop-up notification to paid users to get them know about the transition & a helpline email.

2. Unpublish the paid unlocker.

3. Give promo code to all paid users, so that they would be able to buy only the in-app purchases that unlock the features which are unlocked by the paid unlocker. They'll have to pay additional price for the extra features.

4. Give enough time to all users for transition. Be very active in helpline for that period.

Or you can maintain 2 same apps:

1. Free app with in-app purchase system.

2. Paid full version of app with all features and no in-app purchase + donate extra option for users who want to donate more for your hardwork.

Provide promo code to all paid users to buy this app.

This would solve some problems like:

1. You don't have to maintain 2 totally different apps. You just have to maintain 1 app and tweak a bit for other.

2. Paid full app will help those who don't want to depend on G Apps.

3. Other in-app purchase issues and not much hassle.

Thank you again for your app.:)
[Android Apps and Games] Oswald Boelcke:
I personally don't mind at all; I actually don't really like to make purchases through Google at all. As you probably remember, our devices are all GApps-free and running with microG. The Google Play Store is the one and only exception, and it's the version coming with microG respectively Nanadroid i.e. I'd be able to make purchases through Google; however, as stated above extremely reluctant to do so (also because I want to refrain from spending 30% of the purchases fees to Google).

I'd appreciate and prefer if alternate methods of payment are maid available e.g. as Lord Boeffla does (please refer to his webpage) or by offering a paid apk via XDA Labs.
[Android Apps and Games] carlese:
4.10.5 keeps crashing on startup on my op5 (xXx 8.1 rom)..
[Android Apps and Games] Dark3n:
Don't update to beta v4.10.5.

There is bug that will likely require resetting the exclusions.

I'm working on a hotfix.
[Android Apps and Games] Dark3n:
v4.10.6 is now rolling out to beta testers.

Important: If you opened beta v4.10.5 your exclusions have been reset.

A little post mortem:

Details are also available in this ticket:

https://github.com/d4rken/sdmaid-public/issues/1570

Two days ago I started to rollout v4.10.4 into production. Rollout stage was at 5%.

I'm tracking failures to import exclusions via automatic bug reports.

Reports from ~30 users indicated an issue with exclusion loading, causing me to halt the rollout.

Further investigation showed that some people had older exclusions that included the currently unsupported tag `SEARCHER`.

This tag was removed some time ago because it doesn't make sense to exclude results from the search tool.

The new stricter exclusion code choked on this.

No one in beta testing had any such old exclusions and I didn't have this issue on my radar. So this issue didn't popup in beta testing.

v4.10.5 was supposed to deal with this. I wrote a routine that checked whether an exclusion contains this tag and if so removes it, and if it was the only tag, to remove the whole exclusion. This worked fine in testing, I even wrote unit tests for it. But unit tests don't run with proguard. In the final build, proguard (which reduces APK size), stripped out all fields that were not used during migration. The migration routine then only forwarded the two data fields fields that were accessed by it and lost the rest.

v4.10.6 does another migration which deletes all corrupted exclusions such that this is fixed by just upgrading instead of reinstalling SD Maid. It also contains changes such that in similar cases SD Maid may crash during migration but doesn't overwrite with corrupt data.

The lost exclusions can unfortunately not be recovered.

Crash tracking shows about ~100-200 beta testers were affected.

My mistake, sorry :(.
[Android Apps and Games] Shyam Bairi:
[MENTION=608746]Dark3n[/MENTION]

In SDMaid, we are not able to set multiple exclusions at once in any of the sections: corpse finder, system cleaner, file explorer, etc.

When I select single file, "exclude" option appears in 3 dot menu. But if we select more than one, the option disappears. Why is it so.

I mean, while using corpse finder or system cleaner, if we want multiple files to be excluded from their respective cleaners, we have to select them one by one and tap exclude again and again. Can't that be done easily by multi selecting and excluding them at once.

Is there any concerns in doing so? It is very useful.
[Android Apps and Games] Dark3n:
Because the existing dialog doesn't support more than 1 exclusion.

It can be done, but not easily, UI stuff is always a lot of work. There are no specific concerns. It's just a matter of finding time and motivation to change this part of the UI.

I don't know yet how a good exclusion UI should look that supports multiple entries. Feel free to contribute some ideas:

https://github.com/d4rken/sdmaid-public/issues/688

If you come up with an easy, but none the less nice idea for an UI that supports this, it would certainly increase the chances of me working on such a feature for the next updates.
[Android Apps and Games] Dark3n:
*dup post*

If seen by a mod, feel free to this post.
[Android Apps and Games] radiohead14:
Hi this doesn't work anymore for me on a new Galaxy S9 unlocked. Used to work perfectly on my S8, but now it just keeps crashing. I sent a feedback report.
[Android Apps and Games] Thebear j koss:
Did you root?
[Android Apps and Games] Dark3n:
If you mean a crash report via Google Play then it is impossible to find your specific report.

If you mean SD Maids own automatic reports, then I need your install ID to find it:

https://github.com/d4rken/sdmaid-public/wiki/Reporting-a-bug#crash-report

I don't see how this helps? It should not crash independent of whether a device is rooted or not.
[Android Apps and Games] radiohead14:
Strange. It's working fine now. I wonder if it's because the phone is brand new and things were still getting setup behind the scenes that were conflicting with this app. All good now tho! But to answer those questions: no I'm not rooted and I guess it was Google's crash feedback. I do have the app's bug reporting on tho.
[Android Apps and Games] Dark3n:
There is a bug in Android 8.0, that causes the system to return an empty list of apps, if you have instant apps installed.

This basically breaks any app that uses the list of apps.

I'd love some help with this as I've run out of ideas :(.

My progress on this is collected here:

https://github.com/d4rken/sdmaid-public/issues/1513
[Android Apps and Games] IronTechmonkey:
This may not be worth much from a coding point of view, and I'm only speaking from Android N/LOS 14.1 with Open Gapps Pico but; the way Instant Apps gets onto recently flashed LOS devices is different from anything else I've seen. It behaves like an autoupdating app even if that setting is disabled in Playstore, but does not behave the same as past Google services updates which would occur in the background or direct you to the Playstore page for said service, indicating that said service is required.

[EDIT] Also, the presence and or behaviour of Instant Apps in the same weakly LOS 14/Android N release with same Gapps package on different devices varies.