person who sings is called what
A musician is a person who plays a musical instrument like a guitar or a piano or a person that sings. A musician is also someone who writes music, even if they write it for other people to play. People who write music are called composers. Usually that part is left out if they also play or sing the music they write, but they are still composers because they wrote the music.