Question: who played barney hefner on all in the family
Answer: Allan John Melvin ( February 18 , 1923 -- January 17 , 2008 ) was an American character actor who appeared in several television shows including the recurring roles of Corporal Henshaw on The Phil Silvers Show ; Sergeant Hacker on Gomer Pyle , USMC ; Alice 's boyfriend Sam the Butcher on The Brady Bunch ; and Archie Bunker 's friend Barney Hefner on All in the Family and Archie Bunker 's Place .