Question: how do i get all my pictures to download to my iphone from icloud?
Answer: On your iPhone, go to Settings. Tap on your name -> iCloud.
Select Photos and then iCloud photos (or iCloud Photo Library for older iOS versions). ... 
Now, all you have to do is wait until the iCloud photos are downloaded to the iPhone.