Question: how do i download music from my old iphone?
Answer: Connect your source iPhone to your computer and launch iTunes.
In iTunes, go to "File" > "Devices" > "Transfer Purchases from [your iPhone name]" to transfer music from iPhone to iTunes. ... 
Connect the target iPhone to the computer and then open iTunes.