Question: how do i save all my photos from icloud to an external hard drive?
Answer: Open the Photos app on your Mac.
Select all your photos using Command + A.
Choose Export from the File menu.
Decide if you want to export edited (default) or unmodified original versions of your photos (recommended)