Question: how do i download all my photos from icloud to an external hard drive?
Answer: Manually download all the files from Apple's iCloud website to a folder on your PC and then copy/paste or move them to your USB drive.
Download iCloud for Windows and find the iCloud folder in your File Explorer. Then, copy the photos from your PCs' iCloud folder and paste them to your USB Drive.