Question: why are nilfgaardians called black ones?
Answer: In the books most Nilfgaardian soldiers have black armours, uniforms, cloaks, shields etc. Even wings on their helmets are black. This is why they are called the Black ones (in Polish: Czarni). Black is symbol of evil and death in Western culture, but it's not that easy in Sapkowski's world.