Question: do heralds work with traps?
Answer: The storm from Herald of Thunder applies to enemies killed by attacks as well as spells, but not if they are killed by minions, traps, mines, or totems.