Question: how to transfer data from an old apple id to a new one?
Answer: iCloud Drive. Save data from your iCloud Drive to a computer before turning off this service. You can use the Finder on a Mac or through iCloud.com if you use a PC. Simply move the data to your new Apple ID once it is set up.