Reference Guide: Complete and Merge a Pull Request 
Tags: codenewbie, beginners, webdev, productivity
Published: 2018-12-26 21:38:14

---
cover_image: https://thehypnotherapyteam.files.wordpress.com/2013/02/shutterstock_98569628-decision.jpg
title: Reference Guide: Complete and Merge a Pull Request 
published: true
description: A reference guide series for new web developers. 
tags: #codenewbie #beginners #webdev #productivity
---
In my previous post, [Reference Guide: Conducting a Code Review](https://dev.to/kymiddleton/reference-guide-conducting-a-code-review-k6m), detailed steps were outlined for the code review process. Once the code review is completed it’s time to complete the process and make comments, approve the reviewed changes or request changes to be made before it can be approved.  This is where any identified issues need to be noted. 

**To complete the pull request review:**

![Review Changes](https://thepracticaldev.s3.amazonaws.com/i/ck3flueaigged7c1f1s2.jpeg)

Select green button `Review changes` to finalize the pull request
- A pop-up box will appear with options to `Comment`, `Approve`, or `Request changes`

The code review process is very important.  If something needs to be changed or modified simply provide descriptive comments and select `Request changes`.  This will send a notification back to the contributor.  
- Select the appropriate action: `Comment`, `Approve`, or `Request changes`
- Click `Submit review`

Once submitted, you’ll be taken back to the `Pull request` page.  

**Merging a pull request:**
Provided everything on this page is `green`, the changes are ready to be merged. 

Select `Merge pull request`

![Merge Pull Request](https://thepracticaldev.s3.amazonaws.com/i/i5c9wkfbesnjw3j9og8x.jpeg)

Select `Confirm merge`

![Confirm Merge](https://thepracticaldev.s3.amazonaws.com/i/2gnv7465b18lu2wezzpb.jpeg)

- Once this has been selected the files will be merged and the icon under the pull request will switch from a `green` icon that states `Open` to a `purple` icon that states `Merged`.

![Merged](https://thepracticaldev.s3.amazonaws.com/i/ybvrr3yh098to50q1j3y.jpeg)

**Only a couple more steps!**

Return to the terminal and complete the following:
- `git checkout master`
- `git pull`

These additional steps will pull changes from the master and update the local copy. It’s always best to make sure collaborators are working from current files. 


For the completed Reference Guide Series: 
- [Part One:](https://dev.to/kymiddleton/reference-guide-common-commands-for-terminal-6no) Reference Guide: Common Commands for Terminal. 
- [Part two:](https://dev.to/kymiddleton/reference-guide-create-a-github-repository-30f8) Create a GitHub Repository
- [Part three:](https://dev.to/kymiddleton/reference-guide-committing-changes-43el) Committing Changes
- [Part four:](https://dev.to/kymiddleton/reference-guide-committing-changes-with-branches-2f8d) Committing Changes with Branches
-[Part five:]( https://dev.to/kymiddleton/reference-guide-merge-conflicts-6op) Merge Conflicts
- [Part six:](https://dev.to/kymiddleton/reference-guide-pull-requests-5an9) Pull Requests
- [Part seven:](https://dev.to/kymiddleton/reference-guide-conducting-a-code-review-k6m) Conducting a Code Review
-[Part eight:]( https://dev.to/kymiddleton/reference-guide-complete-and-merge-a-pull-request--12n4) Complete and Merge a Pull Request