Tests won't make your software correct
Tags: testing
Published: 2018-12-19 13:42:14

---
title: Tests won't make your software correct
published: true
tags: ["testing"]
canonical_url: https://codewithoutrules.com/2018/12/12/tests-are-not-enough/
---

Automated tests are immensely useful. Once you’ve started writing tests and seen their value, the idea of writing software without them becomes unimaginable.

But as with any technique, you need to understand its limitations. When it comes to automated testing—unit tests, BDD, end-to-end tests—it’s tempting to think that if your tests pass, your software is correct.

But tests don’t, tests _can’t_ tell you that your software is correct. Let’s see why.

<!-- TEASER_END -->

## How to write correct software

To implement a feature or bugfix, you go through multiple stages; they might be compressed or elided, but they are always necessary:

1. **Identification:** Figure out what the problem is you’re trying to solve.
2. **Solution:** Come up with a solution.
3. **Specification:** Define a specification, the details of how the solution will be implemented.
4. **Implementation:** Implement the specification in code.

Your software might end up incorrect at any of these points:

1. You might identify the wrong problem.
2. You might choose the wrong solution.
3. You might create a specification that doesn’t match the solution.
4. You might write code that doesn’t match the specification.

## Only human judgment can decide correctness

Automated tests are also a form of software, and are just as prone to error. The fact that your automated tests pass doesn’t tell you that your software is correct: you may still have identified the wrong problem, or chosen the wrong solution, and so on.

Even when it comes to ensuring your implementation matches your specification, tests can’t validate correctness on their own.Consider the following test:

```python
def test_addition():
    assert add(2, 2) == 5
```

From the code’s perspective—the perspective of an automaton with no understanding—the correct answer of 4 is the one that will cause it to fail. But merely by reading that you can tell it’s wrong: _you_, the human, are key.

**Correctness is something only a person can decide.**

## The value of testing: the process

While passing tests can’t prove correctness, the _process_ of writing tests and making them pass can help make your software correct. That’s because writing the tests involves applying human judgment: What should this test assert? Does match the specification? Does this actually solve our problem?

When you go through the loop of writing tests, writing code, and checking if tests pass, you continuously apply your judgment: is the code wrong? is the test wrong? did I forget a requirement?

You write the test above, and then reread it, and then say “wait that’s wrong, 2 + 2 = 4”. You fix it, and then maybe you add to your one-off hardcoded tests some additional tests based on core arithmetic principles. **Correctness comes from applying the process, not from the artifacts created by the process.**

This may seem like pedantry: what does it matter whether the source of correctness is the tests themselves or the process of writing the tests? But it does matter. **Understanding that human judgment is the key to correctness can keep you from thinking that passing tests are enough: you also need other forms of applied human judgment, like code review and manual testing.**

(Formal methods _augment_ human judgment with automated means… but that’s [another discussion](https://www.hillelwayne.com/post/augmenting-agile/).)

## The value of tests: stability

So if correctness comes from writing the tests, not the tests themselves, why do we keep the tests around?

**Because tests ensure stability.** once we judge the software is correct, the tests can keep the software from changing, and thus reduce the chances of its becoming incorrect. The tests are never enough, because the world can change even if the software isn’t, but stability has its value.

(Stability also has costs if you make the wrong abstraction layer stable…)

## Tests are useful, but they’re not sufficient

To recap:

1. Write automated tests.
2. Run those tests.
3. Don’t mistake passing tests for correctness: you will likely need additional processes and techniques to achieve that.


* * *

### We all make mistakes, and I’ve got 20 years’ worth: from code that crashed production every night at 4AM, to accepting a preposterously bad job offer.

### Every painful failure taught me a lesson—but only after it was too late.

### You can do better! Join 3300 other programmers, and every week you’ll learn how to [avoid another of my mistakes](https://codewithoutrules.com/softwareclown/?ref=dev.to).