Sheriff 2.0 for release 2.9
Published: 2022-04-10 23:34:27

This week we've circled back to being Sheriff! I really enjoyed my first time being sheriff, however this time I am extremely anxious and nervous. 

#### Why I am anxious?

Last week, as we entered our first week of the release, we had many issues to tackle (as all previous releases). However this is the first time I am seeing there remains 70 issues left open 4 days before the release. This has made me extremely nervous for myself but my peers also. Are we going to be able to deliver 70 issues? We should probably ask if we are going to be able to review 70 issues in 4 days instead... Probably unlikely?

By the time we got to Thursday when I was going to do the Triage, we had it down to about 40 issues without any PRs. This didn't help me at all because at this point we were one day away from the release, and I knew we would have to shift a lot of stuff over. I tried to keep the pressure on, and look past the fact it was one day, I've seen miracles before... 

## Sheriff Duties

#### The plan

Release 2.9 is going to be shipped by Jerry and I. I was really excited to see we would be able to work together again after he helped me learn some Rust last semester. For the triage, he would lead it and our goal provided to us was to "Ship new code, any bugs or documentation should be moved to alpha." We moved some issues in Triage to alpha, which was good to organize. 

#### Reviews

Below is a list of PRs I reviewed this week: 

- [Add .ts and .tsx to prettier script in root package.json](https://github.com/Seneca-CDOT/telescope/pull/3316)

- [Move frontend from `src/web` to `src/web/app`](https://github.com/Seneca-CDOT/telescope/pull/3287)

- [Remove custom healthcheck of status service](https://github.com/Seneca-CDOT/telescope/pull/3280)

- [Add the YouTube banner information for desktop screens](https://github.com/Seneca-CDOT/telescope/pull/3282)

- [Move anon_key to inputs vs secrets in CI/CD](https://github.com/Seneca-CDOT/telescope/pull/3330)

  

#### My contribution

My work on the search bar was not done yet. Since my last post, after I made the updates, I had received more feedback about the search being triggered by every key change. I tried my best, and even tried to implement the `useEffect` to catch when it should be sending the request, however, because of the way the code was written, it became really difficult to successfully implement this. Half way through this week, we also decided not to wait to merge [Move frontend from `src/web` to `src/web/app`](https://github.com/Seneca-CDOT/telescope/pull/3287) which meant I would have to resolve a conflict. When I went to rebase after the merge I made a mistake and forgot to squash again. However for some reason I had many files to go through and I figured to just start a new branch to then merge. 

I also started redoing the UI as was suggested by Dave. So the idea would be to have something that behaves as such:
![Screen Shot 2022-03-24 at 11 20 00 AM](https://user-images.githubusercontent.com/427398/159950364-e8d3a2ab-3689-4d13-bdb7-4e93cacf0ca6.png)

For the UI here, I decided to make the input the same across all and pass it props instead. This would mean all the input boxes would be more uniform. As I discussed last week with my design, they look identical now. 

![](https://i.imgur.com/pyCh8wS.png)



#### Release 2.9

As we usually know, every release there is a problem. For this release, we had some mysteries to uncover. When Jerry and I went to create the release, I accidentally created a patch tag instead. I used `pnpm version patch` to release, forgetting that this was not a patch but a minor. After we reset head and removed the commit, then deleted the remote tag, I created the new version as a minor and pushed. This time we had the pleasure of pushing the local tag again. So we went back and removed that. When we went to view the build, we saw it had failed. There was an error about how the package-lock did not match the current pnpm-lock.yaml. This was a big problem. How did our CI not detect this? After a few hiccups, we put up a new package-lock and were able to successfully build the new release. So although there were some problems, nothing major - because after all this was a minor release. :P