CVE-2023-29510 (published 2023-04-19T00:15Z)

XWiki Platform is a generic wiki platform offering runtime services for applications built on top of it. In XWiki, every user can add translations that are only applied to the current user. This also allows overriding existing translations. Such translations are often included in privileged contexts without any escaping which allows remote code execution for any user who has edit access on at least one document which could be the user's own profile where edit access is enabled by default. A mitigation for this vulnerability is part of XWiki 14.10.2 and XWiki 15.0 RC1: translations with user scope now require script right. This means that regular users cannot exploit this anymore as users don't have script right by default anymore starting with XWiki 14.10. There are no known workarounds apart from upgrading to a patched versions.

CVSS v3 base score: 8.8, HIGH (CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H)

Weakness information:
cwe_id: CWE-74
cwe_name: Improper Neutralization of Special Elements in Output Used by a Downstream Component ('Injection')
description: The product constructs all or part of a command, data structure, or record using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify how it is parsed or interpreted when it is sent to a downstream component.
extended_description: Software or other automated logic has certain assumptions about what constitutes data and control respectively. It is the lack of verification of these assumptions for user-controlled input that leads to injection problems. Injection problems encompass a wide variety of issues -- all mitigated in very different ways and usually attempted in order to alter the control flow of the process. For this reason, the most effective way to discuss these weaknesses is to note the distinct features that classify them as injection weaknesses. The most important issue to note is that all injection problems share one thing in common -- i.e., they allow for the injection of control plane data into the user-controlled data plane. This means that the execution of the process may be altered by sending code in through legitimate data channels, using no other mechanism. While buffer overflows, and many other flaws, involve the use of some further issue to gain execution, injection problems need only for the data to be parsed.
         

Fix information:
repo_url: https://github.com/xwiki/xwiki-platform
commit_details: repo_url: https://github.com/xwiki/xwiki-platform
author: Michael Hamann
author_date: 2022-12-15 17:32:45+01:00
msg: XWIKI-19749: Require script right for translations with user scope

* Add a new configuration option.
* Migrate tests to JUnit 5 and add a new test.
repository: repo_url: https://github.com/xwiki/xwiki-platform
repo_name: xwiki/xwiki-platform
description: The XWiki platform
repo_language: Java
owner: xwiki
file_changes: filename: DefaultWikiTranslationConfiguration.java
change_type: ModificationType.ADD
diff: @@ -0,0 +1,51 @@
+/*
+ * See the NOTICE file distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.xwiki.localization.wiki.internal;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.xwiki.component.annotation.Component;
+import org.xwiki.configuration.ConfigurationSource;
+
+/**
+ * Default implementation of the {@link WikiTranslationConfiguration}.
+ *
+ * @since 14.10.2
+ * @since 15.0RC1
+ * @version $Id$
+ */
+@Singleton
+@Component
+public class DefaultWikiTranslationConfiguration implements WikiTranslationConfiguration
+{
+    private static final String PREFIX = "localization.wiki.";
+
+    @Inject
+    @Named("xwikiproperties")
+    private ConfigurationSource configuration;
+
+    @Override
+    public boolean isRestrictUserTranslations()
+    {
+        return this.configuration.getProperty(PREFIX + "restrictUserTranslations", true);
+    }
+}

programming_language: Java
filename: DocumentTranslationBundleFactory.java
change_type: ModificationType.MODIFY
diff: @@ -143,6 +143,9 @@ public class DocumentTranslationBundleFactory implements TranslationBundleFactor
     @Inject
     private AuthorizationManager authorizationManager;
 
+    @Inject
+    private WikiTranslationConfiguration configuration;
+
     /**
      * Used to cache on demand document bundles (those that are not registered as components).
      */
@@ -447,6 +450,12 @@ private void checkRegistrationAuthorization(XWikiDocument document, Scope scope)
                 this.authorizationManager.checkAccess(Right.ADMIN, document.getAuthorReference(), document
                     .getDocumentReference().getWikiReference());
                 break;
+            case USER:
+                if (this.configuration.isRestrictUserTranslations()) {
+                    this.authorizationManager.checkAccess(Right.SCRIPT, document.getAuthorReference(),
+                        document.getDocumentReference());
+                }
+                break;
             default:
                 break;
         }

programming_language: Java
filename: WikiTranslationConfiguration.java
change_type: ModificationType.ADD
diff: @@ -0,0 +1,38 @@
+/*
+ * See the NOTICE file distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.xwiki.localization.wiki.internal;
+
+import org.xwiki.component.annotation.Role;
+
+/**
+ * Configuration of the wiki translations.
+ *
+ * @since 14.10.2
+ * @since 15.0RC1
+ * @version $Id$
+ */
+@Role
+public interface WikiTranslationConfiguration
+{
+    /**
+     * @return if translations with user scope shall be restricted to users with script right
+     */
+    boolean isRestrictUserTranslations();
+}

programming_language: Java
filename: components.txt
change_type: ModificationType.MODIFY
diff: @@ -1,3 +1,4 @@
+org.xwiki.localization.wiki.internal.DefaultWikiTranslationConfiguration
 org.xwiki.localization.wiki.internal.DocumentTranslationBundleFactory
 org.xwiki.localization.wiki.internal.DocumentTranslationBundleInitializer
 org.xwiki.localization.wiki.internal.TranslationDocumentClassInitializer

programming_language: Lua
filename: DocumentTranslationBundleFactoryTest.java
change_type: ModificationType.MODIFY
diff: @@ -22,95 +22,144 @@
 import java.util.Collections;
 import java.util.Locale;
 
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
+import javax.inject.Inject;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.mockito.Mock;
 import org.mockito.Mockito;
+import org.xwiki.cache.infinispan.internal.InfinispanCacheFactory;
+import org.xwiki.cache.internal.DefaultCacheManager;
+import org.xwiki.cache.internal.DefaultCacheManagerConfiguration;
+import org.xwiki.component.internal.multi.ComponentManagerManager;
 import org.xwiki.component.manager.ComponentLookupException;
-import org.xwiki.configuration.ConfigurationSource;
+import org.xwiki.component.manager.ComponentManager;
 import org.xwiki.localization.LocalizationManager;
 import org.xwiki.localization.Translation;
 import org.xwiki.localization.TranslationBundleDoesNotExistsException;
 import org.xwiki.localization.TranslationBundleFactory;
 import org.xwiki.localization.TranslationBundleFactoryDoesNotExistsException;
+import org.xwiki.localization.internal.DefaultLocalizationManager;
 import org.xwiki.localization.internal.DefaultTranslationBundleContext;
+import org.xwiki.localization.messagetool.internal.MessageToolTranslationMessageParser;
 import org.xwiki.localization.wiki.internal.TranslationDocumentModel.Scope;
+import org.xwiki.model.internal.DefaultModelContext;
 import org.xwiki.model.reference.DocumentReference;
+import org.xwiki.observation.internal.DefaultObservationManager;
 import org.xwiki.query.Query;
 import org.xwiki.query.QueryManager;
+import org.xwiki.rendering.internal.parser.plain.PlainTextBlockParser;
+import org.xwiki.rendering.internal.renderer.plain.PlainTextBlockRenderer;
+import org.xwiki.rendering.internal.renderer.plain.PlainTextRendererFactory;
 import org.xwiki.rendering.syntax.Syntax;
-import org.xwiki.test.annotation.AfterComponent;
-import org.xwiki.test.annotation.AllComponents;
+import org.xwiki.security.authorization.AccessDeniedException;
+import org.xwiki.security.authorization.Right;
+import org.xwiki.test.LogLevel;
+import org.xwiki.test.annotation.ComponentList;
+import org.xwiki.test.junit5.LogCaptureExtension;
+import org.xwiki.test.junit5.mockito.MockComponent;
 import org.xwiki.wiki.descriptor.WikiDescriptorManager;
 
 import com.xpn.xwiki.XWikiContext;
 import com.xpn.xwiki.XWikiException;
 import com.xpn.xwiki.doc.XWikiDocument;
 import com.xpn.xwiki.objects.BaseObject;
-import com.xpn.xwiki.test.MockitoOldcoreRule;
-
+import com.xpn.xwiki.test.MockitoOldcore;
+import com.xpn.xwiki.test.junit5.mockito.InjectMockitoOldcore;
+import com.xpn.xwiki.test.junit5.mockito.OldcoreTest;
+import com.xpn.xwiki.test.reference.ReferenceComponentList;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
-@AllComponents
-public class DocumentTranslationBundleFactoryTest
+/**
+ * Unit tests for {@link DocumentTranslationBundleFactory}.
+ *
+ * @version $Id$
+ */
+@OldcoreTest
+@ComponentList({
+    DocumentTranslationBundleFactory.class,
+    DefaultLocalizationManager.class,
+    DefaultTranslationBundleContext.class,
+    DefaultModelContext.class,
+    PlainTextBlockRenderer.class,
+    PlainTextRendererFactory.class,
+    DefaultObservationManager.class,
+    DefaultCacheManager.class,
+    DefaultCacheManagerConfiguration.class,
+    MessageToolTranslationMessageParser.class,
+    PlainTextBlockParser.class,
+    InfinispanCacheFactory.class })
+@ReferenceComponentList
+class DocumentTranslationBundleFactoryTest
 {
-    @Rule
-    public MockitoOldcoreRule oldcore = new MockitoOldcoreRule();
+    @InjectMockitoOldcore
+    private MockitoOldcore oldcore;
 
+    @MockComponent
+    private WikiTranslationConfiguration translationConfiguration;
+
+    @MockComponent
     private QueryManager mockQueryManager;
 
+    @Mock
     private Query mockQuery;
 
+    @MockComponent
     private WikiDescriptorManager mockWikiDescriptorManager;
 
+    @MockComponent
+    private ComponentManagerManager componentManagerManager;
+
+    @Inject
     private LocalizationManager localization;
 
-    public DocumentTranslationBundleFactoryTest()
+    /**
+     * Capture logs.
+     */
+    @RegisterExtension
+    private LogCaptureExtension logCapture = new LogCaptureExtension(LogLevel.WARN);
+
+    @BeforeEach
+    public void before() throws Exception
     {
         this.oldcore.notifyDocumentCreatedEvent(true);
         this.oldcore.notifyDocumentUpdatedEvent(true);
         this.oldcore.notifyDocumentDeletedEvent(true);
-    }
 
-    @Before
-    public void before() throws Exception
-    {
         this.oldcore.getXWikiContext().setMainXWiki("xwiki");
         this.oldcore.getXWikiContext().setWikiId("xwiki");
 
         doReturn("plain/1.0").when(this.oldcore.getSpyXWiki()).getCurrentContentSyntaxId(Mockito.any(String.class),
             Mockito.any(XWikiContext.class));
 
-        this.mockQuery = mock(Query.class);
-
         when(this.mockQueryManager.createQuery(Mockito.any(String.class), Mockito.any(String.class)))
             .thenReturn(this.mockQuery);
-        when(this.mockQuery.execute()).thenReturn(Collections.EMPTY_LIST);
+        when(this.mockQuery.execute()).thenReturn(Collections.emptyList());
 
         when(this.mockWikiDescriptorManager.getMainWikiId()).thenReturn(this.oldcore.getXWikiContext().getMainXWiki());
         when(this.mockWikiDescriptorManager.getCurrentWikiId()).thenReturn(this.oldcore.getXWikiContext().getWikiId());
 
+        // Return the "context" component manager for the current wiki and the current user but not for another wiki.
+        when(this.componentManagerManager.getComponentManager("wiki:xwiki", true)).thenReturn(this.oldcore.getMocker());
+        when(this.componentManagerManager.getComponentManager("wiki:otherwiki", true))
+            .thenReturn(mock(ComponentManager.class));
+        when(this.componentManagerManager.getComponentManager("user:null", true)).thenReturn(this.oldcore.getMocker());
+
         // Initialize document bundle factory
         this.oldcore.getMocker().getInstance(TranslationBundleFactory.class, DocumentTranslationBundleFactory.ID);
 
-        this.localization = this.oldcore.getMocker().getInstance(LocalizationManager.class);
-
-        this.oldcore.getMocker().registerMockComponent(ConfigurationSource.class);
-
         // We want to be notified about new components registrations
         this.oldcore.notifyComponentDescriptorEvent();
     }
 
-    @AfterComponent
-    public void registerComponents() throws Exception
-    {
-        this.mockQueryManager = this.oldcore.getMocker().registerMockComponent(QueryManager.class);
-        this.mockWikiDescriptorManager = this.oldcore.getMocker().registerMockComponent(WikiDescriptorManager.class);
-    }
-
     private void addTranslation(String key, String message, DocumentReference reference, Locale locale, Scope scope)
         throws XWikiException
     {
@@ -142,14 +191,12 @@ private void addTranslation(String key, String message, DocumentReference refere
 
         document.setSyntax(Syntax.PLAIN_1_0);
 
-        StringBuilder builder = new StringBuilder(document.getContent());
+        String content = document.getContent() + '\n'
+            + key
+            + '='
+            + message;
 
-        builder.append('\n');
-        builder.append(key);
-        builder.append('=');
-        builder.append(message);
-
-        document.setContent(builder.toString());
+        document.setContent(content);
 
         this.oldcore.getSpyXWiki().saveDocument(document, "", this.oldcore.getXWikiContext());
     }
@@ -159,10 +206,10 @@ private void assertTranslation(String key, String message, Locale locale)
         Translation translation = this.localization.getTranslation(key, locale);
 
         if (message != null) {
-            Assert.assertNotNull("No translation could be found for key [" + key + "]", translation);
-            Assert.assertEquals(message, translation.getRawSource());
+            assertNotNull(translation, "No translation could be found for key [" + key + "]");
+            assertEquals(message, translation.getRawSource());
         } else {
-            Assert.assertNull(translation);
+            assertNull(translation);
         }
     }
 
@@ -174,7 +221,7 @@ private void resetContext() throws ComponentLookupException
     // tests
 
     @Test
-    public void getTranslationScopeWiki() throws XWikiException, ComponentLookupException
+    void getTranslationScopeWiki() throws XWikiException, ComponentLookupException
     {
         assertTranslation("wiki.translation", null, Locale.ROOT);
 
@@ -191,7 +238,7 @@ public void getTranslationScopeWiki() throws XWikiException, ComponentLookupExce
     }
 
     @Test
-    public void getTranslationScopeWikiFromOtherWiki() throws XWikiException, ComponentLookupException
+    void getTranslationScopeWikiFromOtherWiki() throws XWikiException, ComponentLookupException
     {
         assertTranslation("wiki.translation", null, Locale.ROOT);
 
@@ -207,7 +254,7 @@ public void getTranslationScopeWikiFromOtherWiki() throws XWikiException, Compon
     }
 
     @Test
-    public void getTranslationScopeONDemand() throws XWikiException, TranslationBundleDoesNotExistsException,
+    void getTranslationScopeONDemand() throws XWikiException, TranslationBundleDoesNotExistsException,
         TranslationBundleFactoryDoesNotExistsException, ComponentLookupException
     {
         assertTranslation("wiki.translation", null, Locale.ROOT);
@@ -224,4 +271,27 @@ public void getTranslationScopeONDemand() throws XWikiException, TranslationBund
 
         assertTranslation("wiki.translation", "Wiki translation", Locale.ROOT);
     }
+
+    @Test
+    void restrictUserTranslations() throws XWikiException, AccessDeniedException
+    {
+        DocumentReference translationDocument =
+            new DocumentReference(this.oldcore.getXWikiContext().getWikiId(), "space", "translation");
+
+        when(this.translationConfiguration.isRestrictUserTranslations()).thenReturn(true);
+
+        addTranslation("user.translation", "User translation", translationDocument, Locale.ROOT, Scope.USER);
+
+        assertTranslation("user.translation", "User translation", Locale.ROOT);
+
+        doThrow(new AccessDeniedException(Right.SCRIPT, null, translationDocument))
+            .when(this.oldcore.getMockAuthorizationManager()).checkAccess(Right.SCRIPT, null, translationDocument);
+
+        addTranslation("user.translation2", "User translation", translationDocument, Locale.ROOT, Scope.USER);
+
+        assertEquals("Failed to register translation bundle from document [xwiki:space.translation]",
+            this.logCapture.getMessage(0));
+
+        assertTranslation("user.translation", null, Locale.ROOT);
+    }
 }

programming_language: Java
filename: xwiki.properties.vm
change_type: ModificationType.MODIFY
diff: @@ -1391,4 +1391,14 @@ edit.defaultEditor.org.xwiki.rendering.block.XDOM#wysiwyg=$xwikiPropertiesDefaul
 #-# The default value is:
 # skinx.jsStrictModeEnabled = false
 
+#-------------------------------------------------------------------------------------
+# Localization
+#-------------------------------------------------------------------------------------
+
+#-# [Since 14.10.2, 15.0RC1]
+#-# Indicate whether translations with user scope that are only applied for the user who created them shall be
+#-# restricted to users with script right. The default value is true. Disable this option only when you absolutely
+#-# trust all users on the wiki.
+# localization.wiki.restrictUserTranslations = true
+
 $!xwikiPropertiesAdditionalProperties

programming_language: Ruby