CVE-2021-25988 (published 2021-12-29T09:15Z)

In “ifme”, versions 1.0.0 to v7.31.4 are vulnerable against stored XSS vulnerability (notifications section) which can be directly triggered by sending an ally request to the admin.

Severity: LOW
CVSS v2 base score: 3.5 (AV:N/AC:M/Au:S/C:N/I:P/A:N)
CVSS v3 base score: 5.4, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/ifmeorg/ifme
commit_details: repo_url: https://github.com/ifmeorg/ifme
author: Julia Nguyen
author_date: 2021-11-18 15:34:40-05:00
msg: [#2052] Fix stored XSS in Notifications
repository: repo_url: https://github.com/ifmeorg/ifme
repo_name: ifmeorg/ifme
description: Free, open source mental health communication web app to share experiences with loved ones
repo_language: Ruby
owner: ifmeorg
file_changes: filename: notifications_controller.rb
change_type: ModificationType.MODIFY
diff: @@ -46,6 +46,7 @@ class NotificationsController < ApplicationController
   def render_notification(notification)
     uniqueid = notification[:uniqueid]
     data = convert_to_hash(notification[:data])
+    data[:email] = User.find(data[:user_id]).email # In case data[:name] is invalid
     case data[:type]
     when /comment/ then comment_link(uniqueid, data)
     when /accepted_ally_request/ then accepted_ally_link(uniqueid, data)

programming_language: Ruby
filename: notifications_helper.rb
change_type: ModificationType.MODIFY
diff: @@ -6,7 +6,7 @@ module NotificationsHelper
     i18n_key = data[:cutoff] ? 'truncated' : 'full'
     notification = t(
       "notifications.comment.#{i18n_key}",
-      name: data[:user],
+      name: name_or_email(data),
       comment: strip_tags(data[:comment]),
       typename: data[:typename]
     )
@@ -16,7 +16,7 @@ module NotificationsHelper
   def accepted_ally_link(uniqueid, data)
     notification = t(
       'notifications.ally.accepted',
-      name: data[:user]
+      name: name_or_email(data)
     )
     link = "/profile?uid=#{data[:uid]}"
     notification_link(uniqueid, link, notification)
@@ -24,7 +24,7 @@ module NotificationsHelper
 
   def new_ally_request_link(uniqueid, data)
     link = "/profile?uid=#{data[:uid]}"
-    link_html = "<a href=\"#{link}\">#{data[:user]}</a>"
+    link_html = "<a href=\"#{link}\">#{name_or_email(data)}</a>"
     # rubocop:disable Layout/LineLength
     "<div id=\"#{uniqueid}\"><div>#{t('notifications.ally.sent_html', link_to_user: link_html)}</div>#{request_actions(data[:user_id])}</div>"
     # rubocop:enable Layout/LineLength
@@ -33,7 +33,7 @@ module NotificationsHelper
   def group_link(uniqueid, data)
     notification = t(
       "notifications.group.#{data[:type]}",
-      name: data[:user],
+      name: name_or_email(data),
       group_name: data[:group]
     )
     link = "/groups/#{data[:group_id]}"
@@ -43,7 +43,7 @@ module NotificationsHelper
   def meeting_link(uniqueid, data)
     notification = t(
       "notifications.meeting.#{data[:type]}",
-      name: data[:user],
+      name: name_or_email(data),
       group_name: data[:group],
       meeting_name: data[:typename]
     )
@@ -97,4 +97,8 @@ module NotificationsHelper
   def notification_link(uniqueid, link, notification)
     "<a id=\"#{uniqueid}\" href=\"#{link}\">#{notification}</a>"
   end
+
+  def name_or_email(data)
+    sanitize(data[:user]).presence || data[:email]
+  end
 end

programming_language: Ruby
filename: notification.rb
change_type: ModificationType.MODIFY
diff: @@ -1,22 +1,17 @@
 # frozen_string_literal: true
-data = {
-  cutoff: false,
-  user: 'Julia Nguyen',
-  comment: 'Hello',
-  typename: 'typename',
-  type: 'type_comment_moment',
-  typeid: 1,
-  commentable_id: 1
-}
 
 FactoryBot.define do
   factory :notification do
+    data = {
+      cutoff: false,
+      user: 'Almond Butters',
+      comment: 'Hello',
+      typename: 'typename',
+      type: 'type_comment_moment',
+      typeid: 1,
+      commentable_id: 1,
+    }
     uniqueid { 'MyString' }
     data { data.to_json }
-    user_id { 1 }
-
-    trait :with_user do
-      association :user, factory: :user
-    end
   end
 end

programming_language: Ruby
filename: notifications_helper_spec.rb
change_type: ModificationType.MODIFY
diff: @@ -4,7 +4,7 @@ describe NotificationsHelper do
   let(:uniqueid) { 'uniqueid' }
 
   describe '#comment_link' do
-    it 'returns correct link' do
+    it 'returns the correct link' do
       data = {
         cutoff: false,
         user: 'Julia Nguyen',
@@ -16,20 +16,43 @@ describe NotificationsHelper do
       }
       expect(comment_link(uniqueid, data)).to eq('<a id="uniqueid" href="/moments/1">Julia Nguyen commented "Hello" on typename</a>')
     end
+
+    it 'sanitizes and returns the correct link' do
+      data = {
+        cutoff: false,
+        user: '<IFRAME SRC="javascript:alert(document.domain);"></IFRAME>',
+        email: 'julia@example.com',
+        comment: 'Hello',
+        typename: 'typename',
+        type: 'type_comment_moment',
+        typeid: 1,
+        commentable_id: 1
+      }
+      expect(comment_link(uniqueid, data)).to eq('<a id="uniqueid" href="/moments/1">julia@example.com commented "Hello" on typename</a>')
+    end
   end
 
   describe '#accepted_ally_link' do
-    it 'returns correct link' do
+    it 'returns the correct link' do
       data = {
         user: 'Julia Nguyen',
         uid: 'uid'
       }
       expect(accepted_ally_link(uniqueid, data)).to eq('<a id="uniqueid" href="/profile?uid=uid">Julia Nguyen accepted your ally request!</a>')
     end
+
+    it 'sanitizes and returns the correct link' do
+      data = {
+        user: '<IFRAME SRC="javascript:alert(document.domain);"></IFRAME>',
+        email: 'julia@example.com',
+        uid: 'uid'
+      }
+      expect(accepted_ally_link(uniqueid, data)).to eq('<a id="uniqueid" href="/profile?uid=uid">julia@example.com accepted your ally request!</a>')
+    end
   end
 
   describe '#new_ally_request_link' do
-    it 'returns correct link' do
+    it 'returns the correct link' do
       data = {
         user: 'Julia Nguyen',
         uid: 'uid',
@@ -37,6 +60,16 @@ describe NotificationsHelper do
       }
       expect(new_ally_request_link(uniqueid, data)).to eq('<div id="uniqueid"><div>&lt;a href=&quot;/profile?uid=uid&quot;&gt;Julia Nguyen&lt;/a&gt; sent an ally request!</div><div><a rel="nofollow" data-method="post" href="/allies/add?ally_id=1">Accept</a> | <a data-confirm="Are you sure?" rel="nofollow" data-method="post" href="/allies/remove?ally_id=1">Reject</a></div></div>')
     end
+
+    it 'sanitizes and returns the correct link' do
+      data = {
+        user: '<IFRAME SRC="javascript:alert(document.domain);"></IFRAME>',
+        email: 'julia@example.com',
+        uid: 'uid',
+        user_id: 1
+      }
+      expect(new_ally_request_link(uniqueid, data)).to eq('<div id="uniqueid"><div>&lt;a href=&quot;/profile?uid=uid&quot;&gt;julia@example.com&lt;/a&gt; sent an ally request!</div><div><a rel="nofollow" data-method="post" href="/allies/add?ally_id=1">Accept</a> | <a data-confirm="Are you sure?" rel="nofollow" data-method="post" href="/allies/remove?ally_id=1">Reject</a></div></div>')
+    end
   end
 
   describe '#group_link' do
@@ -48,32 +81,57 @@ describe NotificationsHelper do
         group_id: 1
       }
     end
+    let(:dirty_data) do
+      {
+        type: type,
+        user: '<IFRAME SRC="javascript:alert(document.domain);"></IFRAME>',
+        email: 'julia@example.com',
+        group: 'Group name',
+        group_id: 1
+      }
+    end
     context 'type is new_group' do
       let(:type) { 'new_group' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(group_link(uniqueid, data)).to eq('<a id="uniqueid" href="/groups/1">Julia Nguyen created a group "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(group_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/groups/1">julia@example.com created a group "Group name"</a>')
+      end
     end
 
     context 'type is new_group_member' do
       let(:type) { 'new_group_member' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(group_link(uniqueid, data)).to eq('<a id="uniqueid" href="/groups/1">Julia Nguyen joined your group "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(group_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/groups/1">julia@example.com joined your group "Group name"</a>')
+      end
     end
 
     context 'type is add_group_leader' do
       let(:type) { 'add_group_leader' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(group_link(uniqueid, data)).to eq('<a id="uniqueid" href="/groups/1">Julia Nguyen became a leader of "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(group_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/groups/1">julia@example.com became a leader of "Group name"</a>')
+      end
     end
 
     context 'type is remove_group_leader' do
       let(:type) { 'remove_group_leader' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(group_link(uniqueid, data)).to eq('<a id="uniqueid" href="/groups/1">Julia Nguyen is no longer a leader of "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(group_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/groups/1">julia@example.com is no longer a leader of "Group name"</a>')
+      end
     end
   end
 
@@ -88,32 +146,59 @@ describe NotificationsHelper do
         typeid: 1
       }
     end
+    let(:dirty_data) do
+      {
+        type: type,
+        user: '<IFRAME SRC="javascript:alert(document.domain);"></IFRAME>',
+        email: 'julia@example.com',
+        group: 'Group name',
+        typename: 'Meeting name',
+        group_id: 1,
+        typeid: 1
+      }
+    end
     context 'type is new_meeting' do
       let(:type) { 'new_meeting' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(meeting_link(uniqueid, data)).to eq('<a id="uniqueid" href="/meetings/1">Julia Nguyen created a new meeting "Meeting name" for "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(meeting_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/meetings/1">julia@example.com created a new meeting "Meeting name" for "Group name"</a>')
+      end
     end
 
     context 'type is remove_meeting' do
       let(:type) { 'remove_meeting' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(meeting_link(uniqueid, data)).to eq('<a id="uniqueid" href="/groups/1">Julia Nguyen has cancelled "Meeting name" for "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(meeting_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/groups/1">julia@example.com has cancelled "Meeting name" for "Group name"</a>')
+      end
     end
 
     context 'type is update_meeting' do
       let(:type) { 'update_meeting' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(meeting_link(uniqueid, data)).to eq('<a id="uniqueid" href="/meetings/1">Julia Nguyen has updated "Meeting name" for "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(meeting_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/meetings/1">julia@example.com has updated "Meeting name" for "Group name"</a>')
+      end
     end
 
     context 'type is join_meeting' do
       let(:type) { 'join_meeting' }
-      it 'returns correct link' do
+      it 'returns the correct link' do
         expect(meeting_link(uniqueid, data)).to eq('<a id="uniqueid" href="/meetings/1">Julia Nguyen has joined "Meeting name" for "Group name"</a>')
       end
+
+      it 'sanitizes and returns the correct link' do
+        expect(meeting_link(uniqueid, dirty_data)).to eq('<a id="uniqueid" href="/meetings/1">julia@example.com has joined "Meeting name" for "Group name"</a>')
+      end
     end
   end
 end

programming_language: Ruby
filename: notification_spec.rb
change_type: ModificationType.MODIFY
diff: @@ -13,6 +13,8 @@
 #
 
 describe Notification do
+  let(:user) { create(:user1) }
+
   context 'with relations' do
     it { is_expected.to belong_to :user }
   end
@@ -24,7 +26,7 @@ describe Notification do
   end
 
   it 'is valid with valid attributes' do
-    notification = build(:notification)
+    notification = build(:notification, user: user)
 
     expect(notification).to be_valid
   end

programming_language: Ruby
filename: notifications_spec.rb
change_type: ModificationType.MODIFY
diff: @@ -195,16 +195,28 @@ describe 'Notification', type: :request do
   describe '#fetch_notifications' do
     let(:user) { create(:user1) }
     let(:other_user) { create(:user2) }
-    let!(:other_user_notification) { create(:notification, user: other_user) }
-
     context 'when the user is signed in' do
-      let!(:notification) { create(:notification, user: user) }
-      let!(:notification_two) { create(:notification, user: user) }
+      let!(:notification) {
+        create(
+          :notification,
+          user: user,
+          data: {
+            cutoff: false,
+            user: 'Almond Butters',
+            comment: 'Hello',
+            typename: 'typename',
+            type: 'type_comment_moment',
+            typeid: 1,
+            commentable_id: 1,
+            user_id: other_user.id
+          }.to_json
+        )
+      }
       let(:notification_link) do
-        '<a id="MyString" href="/moments/1">Julia Nguyen commented "Hello" on typename</a>'
+        '<a id="MyString" href="/moments/1">Almond Butters commented "Hello" on typename</a>'
       end
       let(:expected_result) do
-        { fetch_notifications: [notification_link, notification_link] }.to_json
+        { fetch_notifications: [notification_link] }.to_json
       end
 
       before do

programming_language: Ruby