CVE-2022-31185 (published 2022-08-01T20:15Z)

mprweb is a hosting platform for the makedeb Package Repository. Email addresses were found to not have been hidden, even if a user had clicked the `Hide Email Address` checkbox on their account page, or during signup. This could lead to an account's email being leaked, which may be problematic if your email needs to remain private for any reason. Users hosting their own mprweb instance will need to upgrade to the latest commit to get this fixed. Users on the official instance will already have this issue fixed.

CVSS v3 base score: 5.3, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N)

Weakness information:
cwe_id: CWE-200
cwe_name: Exposure of Sensitive Information to an Unauthorized Actor
description: The product exposes sensitive information to an actor that is not explicitly authorized to have access to that information.
extended_description: 
	   There are many different kinds of mistakes that introduce information exposures. The severity of the error can range widely, depending on the context in which the product operates, the type of sensitive information that is revealed, and the benefits it may provide to an attacker.  Some kinds of sensitive information include:
       
         private, personal information, such as personal messages, financial data, health records, geographic location, or contact details
         system status and environment, such as the operating system and installed packages
		 business secrets and intellectual property
		 network status and configuration
		 the product's own code or internal state
         metadata, e.g. logging of connections or message headers
		 indirect information, such as a discrepancy between two internal operations that can be observed by an outsider
       
	    Information might be sensitive to different parties, each of which may have their own expectations for whether the information should be protected.  These parties include:
               
                  the product's own users
                  people or organizations whose information is created or used by the product, even if they are not direct product users
		  the product's administrators, including the admins of the system(s) and/or networks on which the product operates
                  the developer
               
	    Information exposures can occur in different ways:
               
                  the code explicitly inserts sensitive information into resources or messages that are intentionally made accessible to unauthorized actors, but should not contain the information - i.e., the information should have been "scrubbed" or "sanitized"
                  a different weakness or mistake indirectly inserts the sensitive information into resources, such as a web script error revealing the full system path of the program.
                  the code manages resources that intentionally contain sensitive information, but the resources are unintentionally made accessible to unauthorized actors. In this case, the information exposure is resultant - i.e., a different weakness enabled the access to the information in the first place.
               
	    It is common practice to describe any loss of confidentiality as an "information exposure," but this can lead to overuse of CWE-200 in CWE mapping. From the CWE perspective, loss of confidentiality is a technical impact that can arise from dozens of different weaknesses, such as insecure file permissions or out-of-bounds read.  CWE-200 and its lower-level descendants are intended to cover the mistakes that occur in behaviors that explicitly manage, store, transfer, or cleanse sensitive information.
         
         

Fix information:
repo_url: https://github.com/makedeb/mprweb
commit_details: repo_url: https://github.com/makedeb/mprweb
author: Hunter Wittenborn
author_date: 2022-07-25 01:30:45-05:00
msg: Redis and Hide Email Address fixes

Closes #97.
repository: repo_url: https://github.com/makedeb/mprweb
repo_name: makedeb/mprweb
description: Hosting platform for the makedeb Package Repository (MPR)
repo_language: Python
owner: makedeb
file_changes: filename: accounts.py
change_type: ModificationType.MODIFY
diff: @@ -270,7 +270,7 @@ async def account_register_post(
     request: Request,
     U: str = Form(default=str()),  # Username
     E: str = Form(default=str()),  # Email
-    H: str = Form(default=False),  # Hide Email
+    H: str = Form(default="off"),  # Hide Email
     BE: str = Form(default=None),  # Backup Email
     R: str = Form(default=""),  # Real Name
     HP: str = Form(default=None),  # Homepage
@@ -313,13 +313,19 @@ async def account_register_post(
         models.AccountType, models.AccountType.AccountType == "User"
     ).first()
 
+    # Check if we should turn on HideEmail.
+    if H == "on":
+        hide_email = 1
+    else:
+        hide_email = 0
+
     # Create a user given all parameters available.
     with db.begin():
         user = db.create(
             models.User,
             Username=U,
             Email=E,
-            HideEmail=H,
+            HideEmail=hide_email,
             BackupEmail=BE,
             RealName=R,
             Homepage=HP,

programming_language: Python
filename: redis-entrypoint.sh
change_type: ModificationType.MODIFY
diff: @@ -1,6 +1,6 @@
 #!/bin/bash
 set -eou pipefail
 
-sed -ri 's/^bind .*$/bind 0.0.0.0 -::1/g' /etc/redis/redis.conf
+sed -ri -e 's/^bind .*$/bind 0.0.0.0 -::1/g' -e 's/^protected-mode .*$/protected-mode no/g' /etc/redis/redis.conf
 
 exec "$@"

programming_language: Shell
filename: show.html
change_type: ModificationType.MODIFY
diff: @@ -19,7 +19,11 @@
 		</div>
 		<div class="item">
 		    <p class="caption">{% trans %}Email Address{% endtrans %}:</p>
+                    {% if request.user != user and user.HideEmail == 1 %}
+		    <p class="data">None</a></p>
+                    {% else %}
 		    <p class="data"><a href="mailto:{{ user.Email }}">{{ user.Email }}</a></p>
+                    {% endif %}
 		</div>
 		<div class="item">
 		    <p class="caption">{% trans %}Real Name{% endtrans %}:</p>

programming_language: HTML
filename: account_form.html
change_type: ModificationType.MODIFY
diff: @@ -82,7 +82,7 @@
                     {% trans %}Hide Email Address{% endtrans %}:
                 </label>
 
-                <input class="checkbox" id="id_hide" type="checkbox" name="H" {% if H %}checked="checked"{% endif %}>
+                <input class="checkbox" id="id_hide" type="checkbox" name="H" value="on" {% if H or request.user.HideEmail == 1 %}checked="checked"{% endif %}>
             </div>
             <p class="comment"><em>{{ "If you do not hide your email address, it is "
             "visible to all registered MPR users. If you hide your "

programming_language: HTML