CVE-2023-0046 (published 2023-01-04T12:15Z)

Improper Restriction of Names for Files and Other Resources in GitHub repository lirantal/daloradius prior to master-branch.

CVSS v3 base score: 7.2, HIGH (CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:H/I:H/A:H)

Weakness information:
cwe_id: CWE-641
cwe_name: Improper Restriction of Names for Files and Other Resources
description: The product constructs the name of a file or other resource using input from an upstream component, but it does not restrict or incorrectly restricts the resulting name.
extended_description: This may produce resultant weaknesses. For instance, if the names of these resources contain scripting characters, it is possible that a script may get executed in the client's browser if the application ever displays the name of the resource on a dynamically generated web page. Alternately, if the resources are consumed by some application parser, a specially crafted name can exploit some vulnerability internal to the parser, potentially resulting in execution of arbitrary code on the server machine. The problems will vary based on the context of usage of such malformed resource names and whether vulnerabilities are present in or assumptions are made by the targeted technology that would make code execution possible.
         

Fix information:
repo_url: https://github.com/lirantal/daloradius
commit_details: repo_url: https://github.com/lirantal/daloradius
author: Filippo
author_date: 2023-01-04 11:43:01+01:00
msg: Better validating log filepath (#326)
repository: repo_url: https://github.com/lirantal/daloradius
repo_name: lirantal/daloradius
description: daloRADIUS is an advanced RADIUS web management application for managing hotspots and general-purpose ISP deployments. It features user management, graphical reporting, accounting, a billing engine, and integrates with OpenStreetMap for geolocation. The system is based on FreeRADIUS with which it shares access to the backend database.
repo_language: PHP
owner: lirantal
file_changes: filename: config-backup.php
change_type: ModificationType.MODIFY
diff: @@ -41,18 +41,8 @@
 
     echo '<div id="contentnorightbar">';
     print_title_and_help($title, $help);
-?>
-
-        </div><!-- #contentnorightbar -->
-        
-        <div id="footer">
-<?php
+    
     include('include/config/logging.php');
-    include('page-footer.php');
+    
+    print_footer_and_html_epilogue();
 ?>
-        </div><!-- #footer -->
-    </div>
-</div>
-
-</body>
-</html>

programming_language: PHP
filename: config-logging.php
change_type: ModificationType.MODIFY
diff: @@ -24,10 +24,17 @@
     include ("library/checklogin.php");
     $operator = $_SESSION['operator_user'];
 
+    include('library/check_operator_perm.php');
     include_once('library/config_read.php');
+    
+    // init logging variables
     $log = "visited page: ";
-
+    $logAction = "";
+    $logDebugSQL = "";
+    
     include_once("lang/main.php");
+    include("library/validation.php");
+    include("library/layout.php");
 
     $param_label = array(
                             'CONFIG_LOG_PAGES' => t('all','PagesLogging'),
@@ -37,25 +44,69 @@
                             'CONFIG_DEBUG_SQL_ONPAGE' => t('all','LoggingDebugOnPages')
                         );
 
-    // if the form has been submitted we validate and store the configuration
-    if (array_key_exists('submit', $_POST) && isset($_POST['submit'])) {
-        
-        foreach ($param_label as $param => $label) {
-            if (array_key_exists($param, $_POST) && isset($_POST[$param]) &&
-                in_array(strtolower($_POST[$param]), array("yes", "no"))) {
-                $configValues[$param] = $_POST[$param];
+    if ($_SERVER['REQUEST_METHOD'] === 'POST') {
+        if (array_key_exists('csrf_token', $_POST) && isset($_POST['csrf_token']) && dalo_check_csrf_token($_POST['csrf_token'])) {
+            
+            $isError = false;
+            
+            // validate yes/no params
+            foreach ($param_label as $param => $label) {
+                if (array_key_exists($param, $_POST) && !empty(strtolower(trim($_POST[$param]))) &&
+                    in_array(strtolower(trim($_POST[$param])), array("yes", "no"))) {
+                    $configValues[$param] = $_POST[$param];
+                }
             }
+            
+            // validate path
+            $log_path_prefix = $configValues['CONFIG_PATH_DALO_VARIABLE_DATA'] . "/log";
+            $log_file_suffix = ".log";
+            
+            if (array_key_exists('CONFIG_LOG_FILE', $_POST) && !empty(trim($_POST['CONFIG_LOG_FILE']))) {
+                $candidate_log_file = trim($_POST['CONFIG_LOG_FILE']);
+                
+                if (
+                        // this ensure that the log_path_prefix is a directory
+                        is_dir($log_path_prefix) &&
+
+                        // this ensures that candidate_log_file starts with the log_path_prefix
+                        substr($candidate_log_file, 0, strlen($log_path_prefix)) === $log_path_prefix &&
+                        
+                        // this ensures that candidate_log_file does not contain ".."
+                        strpos($candidate_log_file, "..") === false &&
+                        
+                        // this ensures that candidate_log_file ends with the log_file_suffix
+                        substr($candidate_log_file, -strlen($log_file_suffix)) === $log_file_suffix &&
+                        
+                        // this ensures that candidate_log_file is at a writable location
+                        // or that at least it can be written inside the parent directory
+                        (is_writable($candidate_log_file) || is_writable(dirname($candidate_log_file)))
+                    ) {
+                    
+                    $configValues['CONFIG_LOG_FILE'] = $candidate_log_file;
+                    
+                } else {
+                    $isError = true;
+                }
+            } else {
+                $isError = true;
+            }
+            
+            // we write ONLY IF isError is false
+            if (!$isError) {
+                include("library/config_write.php");
+            } else {
+                $failureMsg = sprintf("Log path not allowed. Ensure that log file name locates a writable %s file contained in %s",
+                                      $log_file_suffix, $log_path_prefix);
+                $logAction .= "$failureMsg on page: ";
+            }
+            
+        } else {
+            // csrf
+            $failureMsg = "CSRF token error";
+            $logAction .= "$failureMsg on page: ";
         }
-
-        if (array_key_exists('CONFIG_LOG_FILE', $_POST) && isset($_POST['CONFIG_LOG_FILE']) &&
-            is_writable($_POST['CONFIG_LOG_FILE'])) {
-            $configValues['CONFIG_LOG_FILE'] = $_POST['CONFIG_LOG_FILE'];
-        }
-
-        include("library/config_write.php");
-    }    
-
-    include("library/layout.php");
+    }
+        
 
     // print HTML prologue
     $title = t('Intro','configlogging.php');
@@ -69,45 +120,58 @@
     print_title_and_help($title, $help);
 
     include_once('include/management/actionMessages.php');
-
-?>
-
-<form name="loggingsettings" method="POST">
-    <fieldset>
-        <h302><?= t('title','Settings'); ?></h302>
-        <br>
-        
-        <ul>
-<?php
+    
+    $fieldset0_descriptor = array(
+                                    "title" => t('title','Settings')
+                                 );
+    
+    
+    $input_descriptors0 = array();
+    
     foreach ($param_label as $name => $label) {
-        print_select_as_list_elem($name, $label, array("no", "yes"), $configValues[$name]);
+        $input_descriptors0[] = array(
+                                        "type" => "select",
+                                        "options" => array( "yes", "no" ),
+                                        "caption" => $label,
+                                        "name" => $name,
+                                        "selected_value" => $configValues[$name]
+                                     );
     }
-?>
-
-            <li class="fieldset">
-                <label for="CONFIG_LOG_FILE" class="form"><?= t('all','FilenameLogging') ?></label>
-                <input value="<?= $configValues['CONFIG_LOG_FILE'] ?>" name="CONFIG_LOG_FILE" id="CONFIG_LOG_FILE">
-            </li>
-
-
-            <li class="fieldset">
-                <br/><hr><br/>
-                <input type="submit" name="submit" value="<?= t('buttons','apply') ?>" class="button">
-            </li>
-        </ul>
-    </fieldset>
-</form>
-
-        </div><!-- #contentnorightbar -->
-        
-        <div id="footer">
-<?php
+    
+    $input_descriptors0[] = array(
+                                        "type" => "text",
+                                        "caption" => t('all','FilenameLogging'),
+                                        "name" => 'CONFIG_LOG_FILE',
+                                        "value" => $configValues['CONFIG_LOG_FILE']
+                                     );
+    
+    $input_descriptors0[] = array(
+                                    "name" => "csrf_token",
+                                    "type" => "hidden",
+                                    "value" => dalo_csrf_token(),
+                                 );
+
+    $input_descriptors0[] = array(
+                                    'type' => 'submit',
+                                    'name' => 'submit',
+                                    'value' => t('buttons','apply')
+                                 );
+    
+    open_form();
+    
+    // open 0-th fieldset
+    open_fieldset($fieldset0_descriptor);
+    
+    foreach ($input_descriptors0 as $input_descriptor) {
+        print_form_component($input_descriptor);
+    }
+    
+    close_fieldset();
+    
+    close_form();
+    
     include('include/config/logging.php');
-    include('page-footer.php');
-?>
-        </div><!-- #footer -->
-    </div>
-</div>
+    
+    print_footer_and_html_epilogue();
 
-</body>
-</html>
+?>

programming_language: PHP