CVE-2023-46722 (published 2023-10-31T16:15Z)

The Pimcore Admin Classic Bundle provides a backend UI for Pimcore. Prior to version 1.2.0, a cross-site scripting vulnerability has the potential to steal a user's cookie and gain unauthorized access to that user's account through the stolen cookie or redirect users to other malicious sites. Users should upgrade to version 1.2.0 to receive a patch or, as a workaround, apply the patch manually.

CVSS v3 base score: 6.1, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/pimcore/pimcore
commit_details: repo_url: https://github.com/pimcore/pimcore
author: robertSt7
author_date: 2023-10-09 10:53:37+02:00
msg: Implement Asset Sanitizer Queue & Preview Check (#16053)

* Improve: add sanitizing pdf

* Improve: add sanitizing pdf

* Review changes - use scan instead of sanitizing

* Review changes - generate a version after scanning

* Review changes

* Update doc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md

* Apply suggestions from code review

Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>

* Update models/Asset/Document.php

Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>

* Review changes

* Update doc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md

Co-authored-by: aryaantony92 <97134765+aryaantony92@users.noreply.github.com>

---------

Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: aryaantony92 <97134765+aryaantony92@users.noreply.github.com>
repository: repo_url: https://github.com/pimcore/pimcore
repo_name: pimcore/pimcore
description: Core Framework for the Open Source Data & Experience Management Platform (PIM, MDM, CDP, DAM, DXP/CMS & Digital Commerce)
repo_language: PHP
owner: pimcore
file_changes: filename: Configuration.php
change_type: ModificationType.MODIFY
diff: @@ -553,6 +553,10 @@ final class Configuration implements ConfigurationInterface
                                 ->defaultTrue()
                                 ->info('Process text for Asset documents (e.g. used by backend search).')
                             ->end()
+                            ->booleanNode('scan_pdf')
+                                ->defaultTrue()
+                                ->info('Scan PDF documents for unsafe JavaScript.')
+                            ->end()
                         ->end()
                     ->end()
                     ->arrayNode('versions')

programming_language: PHP
filename: README.md
change_type: ModificationType.MODIFY
diff: @@ -28,6 +28,7 @@ pimcore:
                 enabled: false #disable generating thumbnail for asset documents
             process_page_count: false #disable processing page count
             process_text: false #disable processing text extraction
+            scan_pdf: false #disable scanning PDF documents for unsafe JavaScript.
 ```
 
 The sub chapters of this chapter provide insight into details for

programming_language: Markdown
filename: README.md
change_type: ModificationType.MODIFY
diff: @@ -20,6 +20,8 @@ pimcore:
                 enabled: false #disable generating thumbnail for asset documents
             process_page_count: false #disable processing page count
             process_text: false #disable processing text extraction
+            scan_pdf: false #disable scanning PDF documents for unsafe JavaScript.
+
 ```
 - [Elements] Properties are now only updated in the database with dirty state (when calling `setProperties` or `setProperty`).
 - `Pimcore\Helper\CsvFormulaFormatter` has been deprecated. Use `League\Csv\EscapeFormula` instead.

programming_language: Markdown
filename: AssetUpdateTasksHandler.php
change_type: ModificationType.MODIFY
diff: @@ -62,6 +62,10 @@ class AssetUpdateTasksHandler
 
     private function processDocument(Asset\Document $asset): void
     {
+        if ($asset->getMimeType() === 'application/pdf' && $asset->checkIfPdfContainsJS()) {
+            $asset->save(['versionNote' => 'PDF scan result']);
+        }
+
         $pageCount = $asset->getCustomSetting('document_page_count');
         if (!$pageCount || $pageCount === 'failed') {
             if ($asset->processPageCount()) {

programming_language: PHP
filename: Document.php
change_type: ModificationType.MODIFY
diff: @@ -26,6 +26,8 @@ use Pimcore\Model;
  */
 class Document extends Model\Asset
 {
+    public const CUSTOM_SETTING_PDF_SCAN_STATUS = 'document_pdf_scan_status';
+
     protected string $type = 'document';
 
     protected function update(array $params = []): void
@@ -163,6 +165,53 @@ class Document extends Model\Asset
         return null;
     }
 
+    public function checkIfPdfContainsJS(): bool
+    {
+        if (!$this->isPdfScanningEnabled()) {
+           return false;
+        }
+
+        $this->setCustomSetting(
+            self::CUSTOM_SETTING_PDF_SCAN_STATUS,
+            Model\Asset\Enum\PdfScanStatus::IN_PROGRESS->value
+        );
+
+        $chunkSize = 1024;
+        $filePointer = $this->getStream();
+
+        $tagLength = strlen('/JS');
+
+        while ($chunk = fread($filePointer, $chunkSize)) {
+            if (strlen($chunk) <= $tagLength) {
+                break;
+            }
+
+            if (str_contains($chunk, '/JS') || str_contains($chunk, '/JavaScript')) {
+                $this->setCustomSetting(
+                    self::CUSTOM_SETTING_PDF_SCAN_STATUS,
+                    Model\Asset\Enum\PdfScanStatus::UNSAFE->value
+                );
+                return true;
+            }
+        }
+
+        $this->setCustomSetting(
+            self::CUSTOM_SETTING_PDF_SCAN_STATUS,
+            Model\Asset\Enum\PdfScanStatus::SAFE->value
+        );
+
+        return true;
+    }
+
+    public function getScanStatus(): ?Model\Asset\Enum\PdfScanStatus
+    {
+        if ($scanStatus = $this->getCustomSetting(self::CUSTOM_SETTING_PDF_SCAN_STATUS)) {
+            return Model\Asset\Enum\PdfScanStatus::tryFrom($scanStatus);
+        }
+
+        return null;
+    }
+
     private function isThumbnailsEnabled(): bool
     {
         return Config::getSystemConfiguration('assets')['document']['thumbnails']['enabled'];
@@ -177,4 +226,9 @@ class Document extends Model\Asset
     {
         return Config::getSystemConfiguration('assets')['document']['process_text'];
     }
+
+    private function isPdfScanningEnabled(): bool
+    {
+        return Config::getSystemConfiguration('assets')['document']['scan_pdf'];
+    }
 }

programming_language: PHP
filename: PdfScanStatus.php
change_type: ModificationType.ADD
diff: @@ -0,0 +1,24 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Pimcore
+ *
+ * This source file is available under two different licenses:
+ * - GNU General Public License version 3 (GPLv3)
+ * - Pimcore Commercial License (PCL)
+ * Full copyright and license information is available in
+ * LICENSE.md which is distributed with this source code.
+ *
+ *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
+ *  @license    http://www.pimcore.org/license     GPLv3 and PCL
+ */
+
+namespace Pimcore\Model\Asset\Enum;
+
+enum PdfScanStatus: string
+{
+    case SAFE = 'safe';
+    case UNSAFE = 'unsafe';
+    case IN_PROGRESS = 'inProgress';
+}

programming_language: PHP
filename: Service.php
change_type: ModificationType.MODIFY
diff: @@ -731,6 +731,10 @@ class Service extends Model\AbstractModel
             return $data;
         }
         if (is_object($data)) {
+            if ($data instanceof \UnitEnum) {
+                return $data;
+            }
+
             if ($data instanceof ElementInterface && !$initial) {
                 return self::getElementById(self::getElementType($data), $data->getId());
             }

programming_language: PHP
repo_url: https://github.com/pimcore/admin-ui-classic-bundle
commit_details: repo_url: https://github.com/pimcore/admin-ui-classic-bundle
author: robertSt7
author_date: 2023-10-09 11:00:29+02:00
msg: [Improvement]: Add sanitizing pdf (#301)

* Improve: add sanitizing pdf

* Review changes - use scan instead of sanitizing

* Review changes

* Update translations/admin.en.yaml

Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>

* Review changes

* Update src/Controller/Admin/Asset/AssetController.php

Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>

* Update src/Controller/Admin/Asset/AssetController.php

Co-authored-by: aryaantony92 <97134765+aryaantony92@users.noreply.github.com>

---------

Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: aryaantony92 <97134765+aryaantony92@users.noreply.github.com>
repository: repo_url: https://github.com/pimcore/admin-ui-classic-bundle
repo_name: pimcore/admin-ui-classic-bundle
repo_language: JavaScript
owner: pimcore
file_changes: filename: AssetController.php
change_type: ModificationType.MODIFY
diff: @@ -33,6 +33,7 @@ use Pimcore\File;
 use Pimcore\Loader\ImplementationLoader\Exception\UnsupportedException;
 use Pimcore\Logger;
 use Pimcore\Messenger\AssetPreviewImageMessage;
+use Pimcore\Messenger\AssetUpdateTasksMessage;
 use Pimcore\Model;
 use Pimcore\Model\Asset;
 use Pimcore\Model\DataObject\ClassDefinition\Data\ManyToManyRelation;
@@ -984,6 +985,13 @@ class AssetController extends ElementControllerBase implements KernelControllerE
             throw $this->createAccessDeniedHttpException('Permission denied, version id [' . $id . ']');
         }
 
+        if ($asset->getMimeType() === 'application/pdf') {
+            $scanResponse = $this->getResponseByScanStatus($asset, false);
+            if ($scanResponse) {
+                return $scanResponse;
+            }
+        }
+
         $loader = \Pimcore::getContainer()->get('pimcore.implementation_loader.asset.metadata.data');
 
         return $this->render(
@@ -1487,12 +1495,11 @@ class AssetController extends ElementControllerBase implements KernelControllerE
 
     /**
      * @Route("/get-preview-document", name="pimcore_admin_asset_getpreviewdocument", methods={"GET"})
-     *
-     * @param Request $request
-     *
-     * @return StreamedResponse
      */
-    public function getPreviewDocumentAction(Request $request): StreamedResponse
+    public function getPreviewDocumentAction(
+        Request $request,
+        TranslatorInterface $translator
+    ): StreamedResponse|Response
     {
         $asset = Asset\Document::getById((int) $request->get('id'));
 
@@ -1501,6 +1508,13 @@ class AssetController extends ElementControllerBase implements KernelControllerE
         }
 
         if ($asset->isAllowed('view')) {
+            if ($asset->getMimeType() === 'application/pdf') {
+                $scanResponse = $this->getResponseByScanStatus($asset);
+                if ($scanResponse) {
+                    return $scanResponse;
+                }
+            }
+
             $stream = $this->getDocumentPreviewPdf($asset);
             if ($stream) {
                 return new StreamedResponse(function () use ($stream) {
@@ -1516,6 +1530,29 @@ class AssetController extends ElementControllerBase implements KernelControllerE
         }
     }
 
+    private function getResponseByScanStatus(Asset\Document $asset, bool $processBackground = true) :?Response
+    {
+        if (!Config::getSystemConfiguration('assets')['document']['scan_pdf']) {
+            return null;
+        }
+
+        $scanStatus = $asset->getScanStatus();
+        if ($scanStatus === null) {
+            $scanStatus = Asset\Enum\PdfScanStatus::IN_PROGRESS;
+            if ($processBackground) {
+                \Pimcore::getContainer()->get('messenger.bus.pimcore-core')->dispatch(
+                    new AssetUpdateTasksMessage($asset->getId())
+                );
+            }
+        }
+
+        return match($scanStatus) {
+            Asset\Enum\PdfScanStatus::IN_PROGRESS => $this->render('@PimcoreAdmin/admin/asset/get_preview_pdf_in_progress.html.twig'),
+            Asset\Enum\PdfScanStatus::UNSAFE => $this->render('@PimcoreAdmin/admin/asset/get_preview_pdf_unsafe.html.twig'),
+            default => null,
+        };
+    }
+
     /**
      * @param Asset\Document $asset
      *
@@ -1529,7 +1566,12 @@ class AssetController extends ElementControllerBase implements KernelControllerE
             $stream = $asset->getStream();
         }
 
-        if (!$stream && $asset->getPageCount() && \Pimcore\Document::isAvailable() && \Pimcore\Document::isFileTypeSupported($asset->getFilename())) {
+        if (
+            !$stream &&
+            $asset->getPageCount() &&
+            \Pimcore\Document::isAvailable() &&
+            \Pimcore\Document::isFileTypeSupported($asset->getFilename())
+        ) {
             try {
                 $document = \Pimcore\Document::getInstance();
                 $stream = $document->getPdf($asset);

programming_language: PHP
filename: get_preview_pdf_in_progress.html.twig
change_type: ModificationType.ADD
diff: @@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta charset="UTF-8">
+
+    <style>
+
+        /* hide from ie on mac \*/
+        html {
+            height: 100%;
+            overflow: hidden;
+        }
+        /* end hide */
+
+        body {
+            height: 100%;
+            margin: 0;
+            padding: 0;
+            background: #EEE;
+        }
+
+        #container {
+            text-align: center;
+            position: absolute;
+            top:50%;
+            margin-top: -200px;
+            width: 100%;
+        }
+
+        #message {
+            margin-left: 8px;
+        }
+
+    </style>
+
+    <script {{ pimcore_csp.getNonceHtmlAttribute()|raw }}>
+        window.setTimeout(() => {
+            window.location.reload();
+        }, 5000)
+    </script>
+</head>
+
+<body>
+
+<div id="container">
+    <span id="message">{{ 'pdf_scan_in_progress'|trans([], 'admin') }}</span>
+</div>
+
+
+</body>
+</html>

programming_language: HTML
filename: get_preview_pdf_unsafe.html.twig
change_type: ModificationType.ADD
diff: @@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta charset="UTF-8">
+
+    <style>
+
+        /* hide from ie on mac \*/
+        html {
+            height: 100%;
+            overflow: hidden;
+        }
+        /* end hide */
+
+        body {
+            height: 100%;
+            margin: 0;
+            padding: 0;
+            background: #EEE;
+        }
+
+        #container {
+            text-align: center;
+            position: absolute;
+            top:50%;
+            margin-top: -200px;
+            width: 100%;
+        }
+
+        #warning {
+            position: relative;
+            width: 40px;
+            height: 40px;
+            top: 13px;
+        }
+
+        #message {
+            margin-left: 8px;
+        }
+
+    </style>
+
+</head>
+
+<body>
+
+<div id="container">
+    <img alt="warning" id="warning" src="/bundles/pimcoreadmin/img/flat-color-icons/overlay-error.svg" />
+    <span id="message">{{ 'pdf_js_unsafe'|trans([], 'admin') }}</span>
+</div>
+
+
+</body>
+</html>

programming_language: HTML
filename: show_version_document.html.twig
change_type: ModificationType.MODIFY
diff: @@ -1,7 +1,7 @@
 {% if asset.getMimeType() == 'application/pdf' %}
     {% set tempFile = asset.getTemporaryFile() %}
     {% set dataUri = pimcore_asset_version_preview(tempFile) %}
-    
+
     <div style="display: flex; width: 100%; height: 100%; flex-direction: column; overflow: hidden;">
         <iframe src="{{ dataUri }}" frameborder="0" style="flex-grow: 1; border: none; margin: 0; padding: 0;"></iframe>
     </div>

programming_language: HTML
filename: admin.en.yaml
change_type: ModificationType.MODIFY
diff: @@ -988,3 +988,5 @@ allow_asset_inline_download: Allow inline download
 system_appearance_settings: 'Appearance & Branding'
 male: Male
 female: Female
+pdf_js_unsafe: This PDF file contains JavaScript. If you want to view it, please download and open it in your local PDF viewer.
+pdf_scan_in_progress: 'Preview not available: PDF is being scanned. This may take a while.'

programming_language: Ruby