CVE-2012-10002 (published 2023-01-03T09:15Z)

A vulnerability was found in ahmyi RivetTracker. It has been declared as problematic. Affected by this vulnerability is the function changeColor of the file css.php. The manipulation of the argument set_css leads to cross site scripting. The attack can be launched remotely. The patch is named 45a0f33876d58cb7e4a0f17da149e58fc893b858. It is recommended to apply a patch to fix this issue. The associated identifier of this vulnerability is VDB-217267.

CVSS v3 base score: 6.1, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/ahmyi/rivettracker
commit_details: repo_url: https://github.com/ahmyi/rivettracker
author: Clarissa Walker
author_date: 2012-03-13 03:50:51-04:00
msg: More security fixes:

css.php
  Unfiltered $_POSTs everywhere!
  Prevent XSS in Create CSS form entry [http://forums.rivetcode.com/viewtopic.php?f=9&t=342&p=1144#p1144]
  Typo in create css file error message.
  Needed to connect to database for cleaning function.

edit_database.php
  One line changed: a simple htmlentities() will take care of this for now.

sanity.php, sanity_no_output.php
  Changed obsolete code, no escape on queries.

statistics.php
  Filtered yet another global array
repository: repo_url: https://github.com/ahmyi/rivettracker
repo_name: ahmyi/rivettracker
repo_language: PHP
owner: ahmyi
file_changes: filename: css.php
change_type: ModificationType.MODIFY
diff: @@ -11,6 +11,14 @@ if (!$_SESSION['admin_logged_in'])
 	header("Location: authenticate.php?status=session");
 	exit();
 }
+
+// Prep database, needed for cleaning function
+if ($GLOBALS["persist"])
+	$db = @mysql_pconnect($dbhost, $dbuser, $dbpass) or showError("Can't connect to database. Contact the webmaster.");
+else
+	$db = @mysql_connect($dbhost, $dbuser, $dbpass) or showError("Can't connect to database. Contact the webmaster.");
+@mysql_select_db($database) or showError("Can't open database. Contact the webmaster");
+
 ?>
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
@@ -44,8 +52,8 @@ if (!$_SESSION['admin_logged_in'])
 if (isset($_POST["set_css"]))
 {
 	//delete style.css file
-	if (copy("./css/" . $_POST["set_css"], "./css/style.css"))
-		echo "<p class=\"success\">style.css file has been replaced with " . $_POST["set_css"] . "</p>";
+	if (copy("./css/" . filterData($_POST["set_css"]), "./css/style.css"))
+		echo "<p class=\"success\">style.css file has been replaced with " . filterData($_POST["set_css"]) . "</p>";
 	else
 	{
 		echo errorMessage() . "Error: Unable to copy over style.css, are the permissions correct?</p>";
@@ -55,11 +63,11 @@ if (isset($_POST["set_css"]))
 elseif (isset($_POST["delete_css"]))
 {
 	//delete css file
-	if (unlink("./css/" . $_POST["delete_css"]))
-		echo "<p class=\"success\">" . $_POST["delete_css"] . " has been deleted</p>";
+	if (unlink("./css/" . filterData($_POST["delete_css"])))
+		echo "<p class=\"success\">" . filterData($_POST["delete_css"]) . " has been deleted</p>";
 	else
 	{
-		echo errorMessage() . "Error: Unable to delete " . $_POST["delete_css"] . ", are you sure the permissions are correct?</p>";
+		echo errorMessage() . "Error: Unable to delete " . filterData($_POST["delete_css"]) . ", are you sure the permissions are correct?</p>";
 		exit();
 	}
 }
@@ -68,19 +76,19 @@ elseif (isset($_POST["create_css"]))
 	//create new css file by copying over style.css into new file
 	if (substr($_POST["create_css"], -4) == ".css")
 	{
-		if (!file_exists("./css/" . $_POST["create_css"]))
+		if (!file_exists("./css/" . filterData($_POST["create_css"])))
 		{
-			if (copy("./css/style.css", "./css/" . $_POST["create_css"]))
-				echo "<p class=\"success\">" . $_POST["create_css"] . ", was created successfuly</p>";
+			if (copy("./css/style.css", "./css/" . filterData($_POST["create_css"])))
+				echo "<p class=\"success\">" . filterData($_POST["create_css"]) . ", was created successfuly</p>";
 			else
 			{
-				echo errorMessage() . "Error: Unabled to create " . $_POST["create_css"] . ", are you sure the permissions are correct?</p>";
+				echo errorMessage() . "Error: Unable to create " . filterData($_POST["create_css"]) . ", are you sure the permissions are correct?</p>";
 				exit();			
 			}
 		}
 		else
 		{
-			echo errorMessage() . "Error: " . $_POST["create_css"] . " already exists, please choose a different name</p>";
+			echo errorMessage() . "Error: " . filterData($_POST["create_css"]) . " already exists, please choose a different name</p>";
 			exit();
 		}
 	}
@@ -130,9 +138,9 @@ if (isset($_POST["create_css"]) || isset($_POST["edit_css"]))
 	<?php
 	
 	if (isset($_POST["create_css"]))
-		$filename = $_POST["create_css"];
+		$filename = filterData($_POST["create_css"]);
 	if (isset($_POST["edit_css"]))
-		$filename = $_POST["edit_css"];
+		$filename = filterData($_POST["edit_css"]);
 	//display text box with css in it
 	?>
 	<h2>Editing File: <?php echo $filename;?></h2>
@@ -153,13 +161,13 @@ if (isset($_POST["create_css"]) || isset($_POST["edit_css"]))
 if (isset($_POST["file_contents"]))
 {
 	//save previously edited text into file
-	if (is_writable("./css/" . $_POST["hidden_filename"]))
+	if (is_writable("./css/" . filterData($_POST["hidden_filename"])))
 	{
 		//open file
-		$stream = fopen("./css/" . $_POST["hidden_filename"], "w");
-		fwrite($stream, $_POST["file_contents"]);
+		$stream = fopen("./css/" . filterData($_POST["hidden_filename"]), "w");
+		fwrite($stream, filterData($_POST["file_contents"]));
 		fclose($stream);
-		echo "<p class=\"success\">" . $_POST["hidden_filename"] . ", was saved successfuly</p>";
+		echo "<p class=\"success\">" . filterData($_POST["hidden_filename"]) . ", was saved successfuly</p>";
 	}
 	else
 	{
@@ -169,8 +177,8 @@ if (isset($_POST["file_contents"]))
 	//if editing the current css file, replace that too
 	if ($_POST["current_css_file"] == $_POST["hidden_filename"])
 	{
-		if (copy("./css/" . $_POST["hidden_filename"], "./css/style.css"))
-			echo "<p class=\"success\">style.css file has been replaced with " . $_POST["hidden_filename"] . "</p>";
+		if (copy("./css/" . filterData($_POST["hidden_filename"]), "./css/style.css"))
+			echo "<p class=\"success\">style.css file has been replaced with " . filterData($_POST["hidden_filename"]) . "</p>";
 		else
 		{
 			echo errorMessage() . "Error: Unable to copy over style.css, are the permissions correct?</p>";

programming_language: PHP
filename: edit_database.php
change_type: ModificationType.MODIFY
diff: @@ -36,7 +36,7 @@ mysql_select_db($database) or die(errorMessage() . "Error selecting database.</p
 
 //get filename from URL string
 if (isset($_GET['filename'])) {
-	$filename = $_GET['filename'];
+	$filename = htmlentities($_GET['filename']);
 }
 
 //if not edit database or filename set, display all torrents as links

programming_language: PHP
filename: sanity.php
change_type: ModificationType.MODIFY
diff: @@ -139,10 +139,10 @@ while ($row = mysql_fetch_row($results))
 		
 		while ($row = mysql_fetch_assoc($query))
 		{
-			$compact = mysql_escape_string(pack('Nn', ip2long($row["ip"]), $row["port"]));
-				$peerid = mysql_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . '7:peer id20:' . hex2bin($row["peer_id"]) . "4:porti{$row["port"]}e");
-			$no_peerid = mysql_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . "4:porti{$row["port"]}e");
-			mysql_query("INSERT INTO ".$prefix."y$hash SET sequence=\"{$row["sequence"]}\", compact=\"$compact\", with_peerid=\"$peerid\", without_peerid=\"$no_peerid\"");
+			$compact = mysql_real_escape_string(pack('Nn', ip2long($row["ip"]), $row["port"]));
+			$peerid = mysql_real_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . '7:peer id20:' . hex2bin($row["peer_id"]) . "4:porti{$row["port"]}e");
+			$no_peerid = mysql_real_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . "4:porti{$row["port"]}e");
+			mysql_query("INSERT INTO ".$prefix."y$hash SET sequence='{$row["sequence"]}', compact='$compact', with_peerid='$peerid', without_peerid='$no_peerid'");
 		}
 	}	
 	else

programming_language: PHP
filename: sanity_no_output.php
change_type: ModificationType.MODIFY
diff: @@ -49,12 +49,12 @@ while ($row = mysql_fetch_row($results))
 	if ($counts["leecher"] == 0)
 	{
 		//If there are no leechers, set the speed to zero
-		quickQuery("UPDATE ".$prefix."summary set speed=0 WHERE info_hash=\"$hash\"");
+		quickQuery("UPDATE ".$prefix."summary set speed=0 WHERE info_hash='$hash'");
 	}
 	
 
 	if ($bytes < 0)
-		quickQuery("UPDATE ".$prefix."summary SET dlbytes=0 WHERE info_hash=\"$hash\"");
+		quickQuery("UPDATE ".$prefix."summary SET dlbytes=0 WHERE info_hash='$hash'");
 
 	myTrashCollector($hash, $report_interval, time(), $writeout);
 
@@ -70,10 +70,10 @@ while ($row = mysql_fetch_row($results))
 		
 		while ($row = mysql_fetch_assoc($query))
 		{
-			$compact = mysql_escape_string(pack('Nn', ip2long($row["ip"]), $row["port"]));
-				$peerid = mysql_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . '7:peer id20:' . hex2bin($row["peer_id"]) . "4:porti{$row["port"]}e");
-			$no_peerid = mysql_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . "4:porti{$row["port"]}e");
-			mysql_query("INSERT INTO ".$prefix."y$hash SET sequence=\"{$row["sequence"]}\", compact=\"$compact\", with_peerid=\"$peerid\", without_peerid=\"$no_peerid\"");
+			$compact = mysql_real_escape_string(pack('Nn', ip2long($row["ip"]), $row["port"]));
+			$peerid = mysql_real_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . '7:peer id20:' . hex2bin($row["peer_id"]) . "4:porti{$row["port"]}e");
+			$no_peerid = mysql_real_escape_string('2:ip' . strlen($row["ip"]) . ':' . $row["ip"] . "4:porti{$row["port"]}e");
+			mysql_query("INSERT INTO ".$prefix."y$hash SET sequence='{$row["sequence"]}', compact='$compact', with_peerid='$peerid', without_peerid='$no_peerid'");
 		}
 	}	
 
@@ -116,11 +116,11 @@ while ($row = mysql_fetch_row($results))
 function myTrashCollector($hash, $timeout, $now, $writeout)
 {
 	require("config.php");
- 	$peers = loadLostPeers($hash, $timeout);
+	$peers = loadLostPeers($hash, $timeout);
 	for ($i=0; $i < $peers["size"]; $i++) {
 	        killPeer($peers[$i]["peer_id"], $hash, $peers[$i]["bytes"], $peers[$i]);
 	}
  	quickQuery("UPDATE ".$prefix."summary SET lastcycle='$now' WHERE info_hash='$hash'");
 }
 
-?>
+?>
\ No newline at end of file

programming_language: PHP
filename: statistics.php
change_type: ModificationType.MODIFY
diff: @@ -24,7 +24,7 @@ if (!$_SESSION['admin_logged_in'])
 <h1>Tracker User Statistics</h1>
 
 <form action="<?php echo htmlentities($_SERVER['PHP_SELF']);?>" method="POST">
-Filename Search:<input type="text" name="filename_search" size="40"<?php if (isset($_POST["filename_search"]))echo " value=\"" . $_POST["filename_search"] . "\"";?>>
+Filename Search:<input type="text" name="filename_search" size="40"<?php if (isset($_POST["filename_search"]))echo " value=\"" . filterData($_POST["filename_search"]) . "\"";?>>
 <input type="submit" value="Search">
 </form>
 <br>

programming_language: PHP