CVE-2021-4265 (published 2022-12-21T19:15Z)

A vulnerability was found in siwapp-ror. It has been rated as problematic. This issue affects some unknown processing. The manipulation leads to cross site scripting. The attack may be initiated remotely. The name of the patch is 924d16008cfcc09356c87db01848e45290cb58ca. It is recommended to apply a patch to fix this issue. The associated identifier of this vulnerability is VDB-216467.

CVSS v3 base score: 6.1, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/siwapp/siwapp-ror
commit_details: repo_url: https://github.com/siwapp/siwapp-ror
author: Johanderson Mogollon
author_date: 2021-10-19 11:07:49+02:00
msg: Fix possible XSS issues (#365)

* some fixes for old migrations, that allows new migrations

* force ssl default true unless env var

* check address no html tags
repository: repo_url: https://github.com/siwapp/siwapp-ror
repo_name: siwapp/siwapp-ror
description: Online Invoice Management in Ruby On Rails.
repo_language: Ruby
owner: siwapp
file_changes: filename: common.rb
change_type: ModificationType.MODIFY
diff: @@ -31,6 +31,10 @@ class Common < ActiveRecord::Base
   validates :email,
     format: {with: /\A([a-zA-Z0-9_\-\.]+)@([a-zA-Z0-9_\-\.]+)\.([a-zA-Z]{2,})\z/i,
              message: "Only valid emails"}, allow_blank: true
+  validates :invoicing_address, format: { without: /<(.*)>.*?|<(.*) \/>/,
+    message: "wrong format" }
+  validates :shipping_address, format: { without: /<(.*)>.*?|<(.*) \/>/,
+    message: "wrong format" }
 
   # Events
   after_save :purge_items

programming_language: Ruby
filename: customer.rb
change_type: ModificationType.MODIFY
diff: @@ -11,6 +11,10 @@ class Customer < ActiveRecord::Base
   # Validation
   validate :valid_customer_identification
   validates_uniqueness_of :name,  scope: :identification
+  validates :invoicing_address, format: { without: /<(.*)>.*?|<(.*) \/>/,
+    message: "Wrong address format" }
+  validates :shipping_address, format: { without: /<(.*)>.*?|<(.*) \/>/,
+    message: "Wrong address format" }
 
   # Behaviors
   acts_as_taggable

programming_language: Ruby
filename: production.rb
change_type: ModificationType.MODIFY
diff: @@ -47,7 +47,7 @@ Rails.application.configure do
   # config.action_cable.allowed_request_origins = [ 'http://example.com', /http:\/\/example.*/ ]
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
-  # config.force_ssl = true
+  config.force_ssl = ENV['NO_FORCE_SSL'].present? ? false : true
 
   # Use the lowest log level to ensure availability of diagnostic information
   # when problems arise.

programming_language: Ruby
filename: 20160907152236_default_for_enabled.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class DefaultForEnabled < ActiveRecord::Migration
+class DefaultForEnabled < ActiveRecord::Migration[4.2]
   def change
     change_column_default(:commons, :enabled, true)
     change_column_default(:commons, :draft, false)

programming_language: Ruby
filename: 20160908093323_add_indexes_on_deleted_column.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddIndexesOnDeletedColumn < ActiveRecord::Migration
+class AddIndexesOnDeletedColumn < ActiveRecord::Migration[4.2]
   def change
     add_index :commons, :deleted_at
     add_index :customers, :deleted_at

programming_language: Ruby
filename: 20160913081503_remove_status_from_commons.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class RemoveStatusFromCommons < ActiveRecord::Migration
+class RemoveStatusFromCommons < ActiveRecord::Migration[4.2]
   def change
     remove_column :commons, :status
   end

programming_language: Ruby
filename: 20160915000824_add_active_to_customer.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddActiveToCustomer < ActiveRecord::Migration
+class AddActiveToCustomer < ActiveRecord::Migration[4.2]
   def up
     add_column :customers, :active, :boolean, default: true
     Customer.update_all ["active = ?", true]

programming_language: Ruby
filename: 20160915094942_add_failed_to_commons.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddFailedToCommons < ActiveRecord::Migration
+class AddFailedToCommons < ActiveRecord::Migration[4.2]
   def change
     add_column :commons, :failed, :boolean, default: false
   end

programming_language: Ruby
filename: 20160923100618_series_first_number.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class SeriesFirstNumber < ActiveRecord::Migration
+class SeriesFirstNumber < ActiveRecord::Migration[4.2]
   def change
   	add_column :series, :first_number, :integer, default: 1
   	remove_column :series, :next_number

programming_language: Ruby
filename: 20160929124104_email_and_print_template_to_common.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class EmailAndPrintTemplateToCommon < ActiveRecord::Migration
+class EmailAndPrintTemplateToCommon < ActiveRecord::Migration[4.2]
   def change
   	rename_column :commons, :template_id, :print_template_id
   	add_column :commons, :email_template_id, :integer

programming_language: Ruby
filename: 20160929133954_email_and_print_default_templates_to_template.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class EmailAndPrintDefaultTemplatesToTemplate < ActiveRecord::Migration
+class EmailAndPrintDefaultTemplatesToTemplate < ActiveRecord::Migration[4.2]
   def change
   	rename_column :templates, :default, :print_default
   	add_column :templates, :email_default, :boolean, default: false

programming_language: Ruby
filename: 20161025134552_change_customer_index.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class ChangeCustomerIndex < ActiveRecord::Migration
+class ChangeCustomerIndex < ActiveRecord::Migration[4.2]
   def change
   	remove_index "customers", name: "cstm_idx"
   	add_index "customers", ["name", "identification"], name: "cstm_idx", unique: true, using: :btree

programming_language: Ruby
filename: 20161026092553_add_template_subject.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddTemplateSubject < ActiveRecord::Migration
+class AddTemplateSubject < ActiveRecord::Migration[4.2]
   def change
   	add_column :templates, :subject, :string, limit: 200
   end

programming_language: Ruby
filename: 20161028103504_add_invoice_number_unique_number.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddInvoiceNumberUniqueNumber < ActiveRecord::Migration
+class AddInvoiceNumberUniqueNumber < ActiveRecord::Migration[4.2]
   def change
   	add_index "commons", ["number", "series_id"], name: "common_unique_number_idx", unique: true, using: :btree
   end

programming_language: Ruby
filename: 20161207184222_remove_tax_amount.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class RemoveTaxAmount < ActiveRecord::Migration
+class RemoveTaxAmount < ActiveRecord::Migration[4.2]
   def change
     remove_column :commons, :tax_amount
   end

programming_language: Ruby
filename: 20161208171651_remove_commons_amounts.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class RemoveCommonsAmounts < ActiveRecord::Migration
+class RemoveCommonsAmounts < ActiveRecord::Migration[4.2]
   def change
     remove_column :commons, :discount_amount
     remove_column :commons, :base_amount

programming_language: Ruby
filename: 20170112115658_remove_invoice_unique_number.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class RemoveInvoiceUniqueNumber < ActiveRecord::Migration
+class RemoveInvoiceUniqueNumber < ActiveRecord::Migration[4.2]
   def change
     remove_index "commons", name: "common_unique_number_idx"
   end

programming_language: Ruby
filename: 20170209101048_remove_customers_unique_name.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class RemoveCustomersUniqueName < ActiveRecord::Migration
+class RemoveCustomersUniqueName < ActiveRecord::Migration[4.2]
   def change
     remove_index "customers", name: "cstm_idx"
   end

programming_language: Ruby
filename: 20170216122053_add_unique_index_to_invoice_series_and_number.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddUniqueIndexToInvoiceSeriesAndNumber < ActiveRecord::Migration
+class AddUniqueIndexToInvoiceSeriesAndNumber < ActiveRecord::Migration[4.2]
   def change
     add_index "commons", ["series_id", "number"], name: "common_unique_number_idx", unique: true, using: :btree
   end

programming_language: Ruby
filename: 20170217120023_add_deleted_number_to_commons.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddDeletedNumberToCommons < ActiveRecord::Migration
+class AddDeletedNumberToCommons < ActiveRecord::Migration[4.2]
   def change
     add_column :commons, :deleted_number, :integer, default: nil
     add_index "commons", ["series_id", "deleted_number"], name: "common_deleted_number_idx", using: :btree

programming_language: Ruby
filename: 20170223101022_add_commons_customer_id_not_null.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddCommonsCustomerIdNotNull < ActiveRecord::Migration
+class AddCommonsCustomerIdNotNull < ActiveRecord::Migration[4.2]
   def change
       change_column :commons, :customer_id, :integer, :null => false
   end

programming_language: Ruby
filename: 20170608155530_add_currency_to_commons.rb
change_type: ModificationType.MODIFY
diff: @@ -1,4 +1,4 @@
-class AddCurrencyToCommons < ActiveRecord::Migration
+class AddCurrencyToCommons < ActiveRecord::Migration[4.2]
   def up
     add_column :commons, :currency, :string, limit: 3
     currency = Settings.currency

programming_language: Ruby