CVE-2023-48292 (published 2023-11-20T18:15Z)

The XWiki Admin Tools Application provides tools to help the administration of XWiki. Starting in version 4.4 and prior to version 4.5.1, a cross site request forgery vulnerability in the admin tool for executing shell commands on the server allows an attacker to execute arbitrary shell commands by tricking an admin into loading the URL with the shell command. A very simple possibility for an attack are comments. When the attacker can leave a comment on any page in the wiki it is sufficient to include an image with an URL like  `/xwiki/bin/view/Admin/RunShellCommand?command=touch%20/tmp/attacked` in the comment. When an admin views the comment, the file `/tmp/attacked` will be created on the server. The output of the command is also vulnerable to XWiki syntax injection which offers a simple way to execute Groovy in the context of the XWiki installation and thus an even easier way to compromise the integrity and confidentiality of the whole XWiki installation. This has been patched by adding a form token check in version 4.5.1 of the admin tools. Some workarounds are available. The patch can be applied manually to the affected wiki pages. Alternatively, the document `Admin.RunShellCommand` can also be deleted if the possibility to run shell commands isn't needed.

CVSS v3 base score: 8.8, HIGH (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H)

Weakness information:
cwe_id: CWE-352
cwe_name: Cross-Site Request Forgery (CSRF)
description: The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.
extended_description: When a web server is designed to receive a request from a client without any mechanism for verifying that it was intentionally sent, then it might be possible for an attacker to trick a client into making an unintentional request to the web server which will be treated as an authentic request. This can be done via a URL, image load, XMLHttpRequest, etc. and can result in exposure of data or unintended code execution.
         

Fix information:
repo_url: https://github.com/xwiki-contrib/application-admintools
commit_details: repo_url: https://github.com/xwiki-contrib/application-admintools
author: Michael Hamann
author_date: 2023-08-03 17:25:07+02:00
msg: ADMINTOOL-91: Add a form token check in RunShellCommand
repository: repo_url: https://github.com/xwiki-contrib/application-admintools
repo_name: xwiki-contrib/application-admintools
description: Advanced administration tools for XWiki
owner: xwiki-contrib
file_changes: filename: RunShellCommand.xml
change_type: ModificationType.MODIFY
diff: @@ -49,6 +49,7 @@ if (services.security.authorization.hasAccess(Right.PROGRAM)) {
   def shellCmd = request.getParameter("command");
   def htmlForm = """
     &lt;form class="form-horizontal" action="" method="POST"&gt;
+      &lt;input type="hidden" name="form_token" value="${services.csrf.token}" /&gt;
       &lt;div class="form-group"&gt;
         &lt;div class="col-sm-10"&gt;
           &lt;input type="text" name="command" value="${shellCmd != null ? escapeTool.xml(shellCmd) : ''}" class="form-control col-md-12" style="width: 100%;" placeholder="${placeHolder}"&gt;
@@ -60,14 +61,19 @@ if (services.security.authorization.hasAccess(Right.PROGRAM)) {
   &lt;/form&gt;""";
   println("{{warning}}${services.localization.render('admintools.server.tools.shellCommand.warning')}{{/warning}}\n\n");
   println("{{html}}${htmlForm}{{/html}}\n\n");
-  if (shellCmd != null ) {
-    String[] cmd = ["sh", "-c", shellCmd];
-    stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
-    println("{{code language=none}}")
-    while ((s = stdout.readLine()) != null) {
-      println(s);
+  def tokenValid = services.csrf.isTokenValid(request.getParameter('form_token'));
+  if (shellCmd != null) {
+    if (!tokenValid) {
+      println("{{error}}${services.localization.render('admintools.server.tools.shellCommand.invalidToken')}{{/error}}\n\n");
+    } else {
+      String[] cmd = ["sh", "-c", shellCmd];
+      stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
+      println("{{code language=none}}")
+      while ((s = stdout.readLine()) != null) {
+        println(s);
+      }
+      println("{{/code}}")
     }
-    println("{{/code}}")
   }
 }
 {{/groovy}}</content>

programming_language: HTML
filename: Translations.xml
change_type: ModificationType.MODIFY
diff: @@ -51,7 +51,8 @@ admintools.server.tools.shellCommand=Run Shell Command
 admintools.server.tools.shellCommand.description=Tool to run shell commands on the server **(Only works on linux servers)**
 admintools.server.tools.shellCommand.run=Run
 admintools.server.tools.shellCommand.placeholder=Enter shell command
-admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.</content>
+admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.
+admintools.server.tools.shellCommand.invalidToken=Invalid form token. Please verify the command and resubmit.</content>
   <object>
     <name>Admin.Translations</name>
     <number>0</number>

programming_language: TypeScript