CVE-2023-45144 (published 2023-10-16T21:15Z)

com.xwiki.identity-oauth:identity-oauth-ui is a package to aid in building identity and service providers based on OAuth authorizations. When a user logs in via the OAuth method, the identityOAuth parameters sent in the GET request is vulnerable to cross site scripting (XSS) and XWiki syntax injection. This allows remote code execution via the groovy macro and thus affects the confidentiality, integrity and availability of the whole XWiki installation. The issue has been fixed in Identity OAuth version 1.6. There are no known workarounds for this vulnerability and users are advised to upgrade.

CVSS v3 base score: 9.6, CRITICAL (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:H/A:H)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/xwikisas/identity-oauth
commit_details: repo_url: https://github.com/xwikisas/identity-oauth
author: Oana-Lavinia Florean
author_date: 2023-04-26 16:17:35+03:00
msg: Improve escaping (#30)

* remove unnecessary empty lines that where displayed when the macro was called
* don't escape links in translations; let the code using the translation to do the right link wrapping after escaping
* refactor some translation macros
* update translations that are used as fallback values in order to use the best practice for having links in translation
repository: repo_url: https://github.com/xwikisas/identity-oauth
repo_name: xwikisas/identity-oauth
description: Basic ingredients to build identity and service providers based on OAuth authorizations
repo_language: Java
owner: xwikisas
file_changes: filename: IdentityOAuthConfigMacros.vm
change_type: ModificationType.MODIFY
diff: @@ -21,42 +21,53 @@
   #macro (initConfigObjects $configDocName $extraObjectClassPropPrefixes $translationPrefixesP)
     #set($formId = "${section.toLowerCase()}_${configDocName1}")
     #set($configDoc = $xwiki.getDocument($configDocName))
-
     #set($classNameIO="IdentityOAuth.IdentityOAuthConfigClass")
     #set($propNamePrefixIO="${configDoc.fullName}_${classNameIO}_0")
     #set($objIO = $configDoc.getObject($classNameIO))
-
+    ## Handle translation prefixes.
     #set($translationPrefixes = [])
     #foreach($p in $translationPrefixesP)
       #set($nuts=$translationPrefixes.add($p))
     #end
     #set($nuts=$translationPrefixes.add('IdentityOAuth.IdentityOAuthConfigClass_'))
-
+    ## Handle extra class properties.
     #foreach($x in $extraObjectClassPropPrefixes)
       #set($shhh = $x.add($x[0]))
       #set($x[0] = $configDoc.getObject($x[0]))
     #end
   #end
 
-
-  ## t: shorthand for translation
+  ##
+  ## Macros used in managing providers translations. t is for translation and tp for translation with parameters.
+  ##
   #macro (alignWithTranslationPrefixes $name)
     #set($tn = [])
     #foreach($p in $translationPrefixes)
       #set($nuts=$tn.add("${p}${name}"))
     #end
   #end
-  #macro (t $name)
+  #macro (getTranslation $name $usage $translation)
     #alignWithTranslationPrefixes($name)
-    $services.localization.render($tn)
+    #if ($usage == 'js')
+      #set ($translation = $escapetool.javascript($services.localization.render($tn)))
+    #else
+      #set ($translation = $escapetool.xml($services.localization.render($tn)))
+    #end
   #end
-
-  ## tp: shorthand for translation with parameters
-  #macro (tp $name $params)##
+  ## Display translation.
+  #macro (t $name $usage)
+    #getTranslation($name $usage $translation)
+    $translation
+  #end
+  ## Get translation with parameters.
+  #macro (tp $name $params $usage $translation)
     #alignWithTranslationPrefixes($name)
-    #set ($msg = $services.localization.render($tn,$params))##
-    ## convert to <a href="link">link-text</a> for the simple wiki syntax of links
-    $stringtool.replacePattern($msg, '\[\[([^>]*)>>([^\]]*)\]\]', '<a href="$2">$1</a>')##
+    #set ($msg = $services.localization.render($tn, $params))##
+    #if ($usage == 'js')
+      #set ($translation = $escapetool.javascript($msg))
+    #else
+      #set ($translation = $escapetool.xml($msg))
+    #end
   #end
 
   ## displayInput: displays the form element of the relevant property of the object having removed the
@@ -93,7 +104,8 @@
       // absUrl: $absUrl
         #set($serverReturn = "${absUrl.substring(0, $absUrl.indexOf('/',8))}${serverReturn}")
       #end
-      window.placeHolderForRedirectUrl = '#tp("redirectUrl.placeHolderMessage", ["${serverReturn}"])';
+      #tp("redirectUrl.placeHolderMessage", ["${serverReturn}"], "js", $translation)
+      window.placeHolderForRedirectUrl = "${translation}";
       var p = window.location.href.indexOf('/admin');
       window.browserReturnUrl = (p === -1 ?
               window.location.href :

programming_language: PowerShell
filename: LoginUIExtension.vm
change_type: ModificationType.MODIFY
diff: @@ -29,7 +29,7 @@
         #set($errorMsg = " ${errorMsg} ${services.localization.render('idoauth.login.domainerror2')} $!{email}.")
         #set($errorMsg = " ${errorMsg} ${services.localization.render('idoauth.login.domainerror3')}")
       #elseif ($result=="ok")
-        #set($successM = ${services.localization.render("idoauth.login.redirectmessage")})
+        #set ($successMsg = ${services.localization.render("idoauth.login.redirectmessage")})
         ## the browser should have been redirected by processOAuthReturn
       #else ## $result is "no user"
         #set($errorMsg = ${services.localization.render('idoauth.login.message')})
@@ -55,7 +55,7 @@
         #end
       #end
     #elseif ($request.identityOAuth)
-      #set($statusMsg = "no such identityOAuth operation '$request.identityOAuth'")
+      #set ($statusMsg = "no such identityOAuth operation '$request.identityOAuth'")
     #else
       #set($statusMsg = "Login page")
       ## assemble the login code from the providers
@@ -90,7 +90,7 @@
       margin-bottom: 5%;
     }
     </style>
-    <!-- ======= ${statusMsg} ====== -->
+    <!-- ======= ${escapetool.xml($statusMsg)} ====== -->
 
     #if ($successMsg || $errorMsg)
     <script type="text/javascript">

programming_language: PHP
filename: Translations.de.properties
change_type: ModificationType.MODIFY
diff: @@ -6,8 +6,10 @@ IdentityOAuth.IdentityOAuthConfigClass_config.explanation=XWiki kann mit externe
 ## Adminstration interface
 IdentityOAuth.IdentityOAuthConfigClass_active=Aktivieren
 IdentityOAuth.IdentityOAuthConfigClass_communicate=Schnittstellen zu dem OAuth Provider
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=Um eine OAuth Integration zu aktivieren, musst du {0}dein Wiki als App für den OAuth Zugang bei dem Provider registrieren{1} und die genannten Client-ID und Clientschlüssel in den folgenden Einstellungen einfügen.
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=Du erhälst mehr Information in den {0}Installationsanweisungen{1}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=Um eine OAuth Integration zu aktivieren, musst du {0} und die genannten Client-ID und Clientschlüssel in den folgenden Einstellungen einfügen.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint.linkLabel=dein Wiki als App für den OAuth Zugang bei dem Provider registrieren
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=Du erhälst mehr Information in den {0}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2.linkLabel=Installationsanweisungen
 
 IdentityOAuth.IdentityOAuthConfigClass_appname=Name
 IdentityOAuth.IdentityOAuthConfigClass_appname.hint=Für deine eigene Organisation

programming_language: TeX
filename: Translations.fr.properties
change_type: ModificationType.MODIFY
diff: @@ -6,8 +6,10 @@ IdentityOAuth.IdentityOAuthConfigClass_config.explanation=XWiki peut être inté
 ## Adminstration interface
 IdentityOAuth.IdentityOAuthConfigClass_active=Activer
 IdentityOAuth.IdentityOAuthConfigClass_communicate=Communication avec les services OAuth
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=Afin d''activer l''intégration OAuth vous devez vous enregistrer pour l''accès à OAuth chez le fournisseur et insérer les informations dans les paramètres suivants.
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=Voir aussi {0}les instructions d''installation{1}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=Afin d''activer l''intégration OAuth vous devez {0} et insérer les informations dans les paramètres suivants.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint.linkLabel=vous enregistrer pour l''accès à OAuth chez le fournisseur
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=Voir aussi {0}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2.linkLabel=les instructions d''installation
 
 IdentityOAuth.IdentityOAuthConfigClass_appname=Nom de l'application
 IdentityOAuth.IdentityOAuthConfigClass_appname.hint=Pour votre propre organisation.

programming_language: TeX
filename: Translations.properties
change_type: ModificationType.MODIFY
diff: @@ -10,8 +10,10 @@ IdentityOAuth.IdentityOAuthConfigClass_config.explanation=XWiki can be integrate
 ## Adminstration interface
 IdentityOAuth.IdentityOAuthConfigClass_active=Activate
 IdentityOAuth.IdentityOAuthConfigClass_communicate=Communication with the OAuth service
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=To activate an OAuth integration you need to {0}register for OAuth access to the provider''s configuration{1} and to insert your Client-Id and secret in the following settings.
-IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=For more information, please see {0}the installation instructions{1}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint=To activate an OAuth integration you need to {0} and to insert your Client-Id and secret in the following settings.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint.linkLabel=register for OAuth access to the provider''s configuration
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2=For more information, please see {0}.
+IdentityOAuth.IdentityOAuthConfigClass_communicate.hint2.linkLabel=the installation instructions
 
 IdentityOAuth.IdentityOAuthConfigClass_appname=Application Name
 IdentityOAuth.IdentityOAuthConfigClass_appname.hint=For your own organisation.
@@ -70,8 +72,8 @@ idoauth.login.oauth.successwithredirect=Successful authentication. You are being
 idoauth.error.noValidLicense=A license for this application is missing. Please visit the License setting (in the Extensions section) to obtain one.
 idoauth.error.extensionDisabled=The IdentityOAuth integration is disabled on this wiki.
 
-idoauth.webHome.1=This is the code for the Identity OAuth extension, allowing to integrate XWiki with external provider's identities.
+idoauth.webHome.1=This is the code for the Identity OAuth extension, allowing to integrate XWiki with external provider identities.
 idoauth.webHome.2=...
 idoauth.webHome.3=...
-idoauth.webHome.4=Go to Provider's section of the XWiki Preferences in order to configure the application.
+idoauth.webHome.4=Go to the administration section of your specific provider in order to configure the application. 
 

programming_language: TeX
filename: WebHome.xml
change_type: ModificationType.MODIFY
diff: @@ -46,13 +46,13 @@
 #if (!$services.licensing.licensor.hasLicensureForEntity($mainReference))
   {{error}}#getMissingLicenseMessage('idoauth.extension.name'){{/error}}
 #else
-	$services.localization.render('idoauth.webHome.1')
-	$services.localization.render('idoauth.webHome.2')
-	$services.localization.render('idoauth.webHome.3')
-  $services.localization.render('idoauth.webHome.4')
+  $escapetool.xml($services.localization.render('idoauth.webHome.1'))
+  $escapetool.xml($services.localization.render('idoauth.webHome.2'))
+  $escapetool.xml($services.localization.render('idoauth.webHome.3'))
+  $escapetool.xml($services.localization.render('idoauth.webHome.4'))
 #end
 
-[[=&gt; More about the IdentityOAuth Application>>https://store.xwiki.com/xwiki/bin/view/Extension/IdentityOAuth]].
+[[=&gt; More about the IdentityOAuth Application&gt;&gt;https://store.xwiki.com/xwiki/bin/view/Extension/IdentityOAuth]].
 {{/velocity}}
 </content>
   <attachment>

programming_language: HTML