CVE-2021-43288 (published 2022-04-14T13:15Z)

An issue was discovered in ThoughtWorks GoCD before 21.3.0. An attacker in control of a GoCD Agent can plant malicious JavaScript into a failed Job Report.

Severity: LOW
CVSS v2 base score: 3.5 (AV:N/AC:M/Au:S/C:N/I:P/A:N)
CVSS v3 base score: 5.4, MEDIUM (CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N)

Weakness information:
cwe_id: CWE-79
cwe_name: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
extended_description: 
            Cross-site scripting (XSS) vulnerabilities occur when:
            
               Untrusted data enters a web application, typically from a web request.
               The web application dynamically generates a web page that contains this untrusted data.
               During page generation, the application does not prevent the data from containing content that is executable by a web browser, such as JavaScript, HTML tags, HTML attributes, mouse events, Flash, ActiveX, etc.
               A victim visits the generated web page through a web browser, which contains malicious script that was injected using the untrusted data.
               Since the script comes from a web page that was sent by the web server, the victim's web browser executes the malicious script in the context of the web server's domain.
               This effectively violates the intention of the web browser's same-origin policy, which states that scripts in one domain should not be able to access resources or run code in a different domain.
            
            There are three main kinds of XSS:
            
               
                  Type 1: Reflected XSS (or Non-Persistent) - 
         			The server reads data directly from the HTTP request and reflects it back in the HTTP response. Reflected XSS exploits occur when an attacker causes a victim to supply dangerous content to a vulnerable web application, which is then reflected back to the victim and executed by the web browser. The most common mechanism for delivering malicious content is to include it as a parameter in a URL that is posted publicly or e-mailed directly to the victim. URLs constructed in this manner constitute the core of many phishing schemes, whereby an attacker convinces a victim to visit a URL that refers to a vulnerable site. After the site reflects the attacker's content back to the victim, the content is executed by the victim's browser.
               
                  Type 2: Stored XSS (or Persistent) - 
               The application stores dangerous data in a database, message forum, visitor log, or other trusted data store. At a later time, the dangerous data is subsequently read back into the application and included in dynamic content. From an attacker's perspective, the optimal place to inject malicious content is in an area that is displayed to either many users or particularly interesting users. Interesting users typically have elevated privileges in the application or interact with sensitive data that is valuable to the attacker. If one of these users executes malicious content, the attacker may be able to perform privileged operations on behalf of the user or gain access to sensitive data belonging to the user. For example, the attacker might inject XSS into a log message, which might not be handled properly when an administrator views the logs.
            
               
                  Type 0: DOM-Based XSS - 
               In DOM-based XSS, the client performs the injection of XSS into the page; in the other types, the server performs the injection. DOM-based XSS generally involves server-controlled, trusted script that is sent to the client, such as Javascript that performs sanity checks on a form before the user submits it. If the server-supplied script processes user-supplied data and then injects it back into the web page (such as with dynamic HTML), then DOM-based XSS is possible.
            
            
            Once the malicious script is injected, the attacker can perform a variety of malicious activities. The attacker could transfer private information, such as cookies that may include session information, from the victim's machine to the attacker. The attacker could send malicious requests to a web site on behalf of the victim, which could be especially dangerous to the site if the victim has administrator privileges to manage that site. Phishing attacks could be used to emulate trusted web sites and trick the victim into entering a password, allowing the attacker to compromise the victim's account on that web site. Finally, the script could exploit a vulnerability in the web browser itself possibly taking over the victim's machine, sometimes referred to as "drive-by hacking."
            In many cases, the attack can be launched without the victim even being aware of it. Even with careful users, attackers frequently use a variety of methods to encode the malicious portion of the attack, such as URL encoding or Unicode, so the request looks less suspicious.
         
         

Fix information:
repo_url: https://github.com/gocd/gocd
commit_details: repo_url: https://github.com/gocd/gocd
author: Aravind SV
author_date: 2021-10-19 10:23:51+01:00
msg: #000 - Escape filenames in artifact tab
repository: repo_url: https://github.com/gocd/gocd
repo_name: gocd/gocd
description: GoCD - Continuous Delivery server main repository
repo_language: Java
owner: gocd
file_changes: filename: build.gradle
change_type: ModificationType.MODIFY
diff: @@ -26,6 +26,7 @@ dependencies {
   api project.deps.dom4j
   api project.deps.apacheHttpMime
   api project.deps.commonsCollections4
+  api project.deps.commonsText
   api project.deps.springTx
   implementation project.deps.jodaTime
   annotationProcessor project.deps.lombok

programming_language: Markdown
filename: DirectoryEntries.java
change_type: ModificationType.MODIFY
diff: @@ -33,7 +33,7 @@ public class DirectoryEntries extends ArrayList<DirectoryEntry> implements HtmlR
     @Override
     public void render(HtmlRenderer renderer) {
         if (isArtifactsDeleted || isEmpty()) {
-            HtmlElement element = p().content("Artifacts for this job instance are unavailable as they may have been <a href='" +
+            HtmlElement element = p().unsafecontent("Artifacts for this job instance are unavailable as they may have been <a href='" +
                     CurrentGoCDVersion.docsUrl("configuration/delete_artifacts.html") +
                     "' target='blank'>purged by Go</a> or deleted externally. "
                     + "Re-run the stage or job to generate them again.");

programming_language: Java
filename: FileDirectoryEntry.java
change_type: ModificationType.MODIFY
diff: @@ -30,7 +30,7 @@ public class FileDirectoryEntry extends DirectoryEntry {
         return HtmlElement.li().content(
             HtmlElement.span(HtmlAttribute.cssClass("artifact")).content(
                 HtmlElement.a(HtmlAttribute.href(getUrl()))
-                        .content(getFileName())
+                        .safecontent(getFileName())
             )
         );
 

programming_language: Java
filename: FolderDirectoryEntry.java
change_type: ModificationType.MODIFY
diff: @@ -41,7 +41,7 @@ public class FolderDirectoryEntry extends DirectoryEntry {
                 HtmlElement.div(cssClass("dir-container")).content(
                     HtmlElement.span(cssClass("directory")).content(
                         HtmlElement.a(onclick("BuildDetail.tree_navigator(this)"))
-                                .content(getFileName())
+                                .safecontent(getFileName())
                     )
                 ),
                 HtmlElement.div(cssClass("subdir-container"), style("display:none"))

programming_language: Java
filename: HtmlElement.java
change_type: ModificationType.MODIFY
diff: @@ -19,6 +19,7 @@ import java.util.ArrayList;
 import java.util.List;
 
 import com.thoughtworks.go.server.presentation.models.HtmlRenderer;
+import org.apache.commons.text.StringEscapeUtils;
 
 public class HtmlElement implements HtmlRenderable {
     public static HtmlElement div(HtmlAttribute... attributes) { return new HtmlElement("div", attributes); }
@@ -37,10 +38,14 @@ public class HtmlElement implements HtmlRenderable {
         this.attributes = attributes;
     }
 
-    public HtmlElement content(String body) {
+    public HtmlElement unsafecontent(String body) {
         return content(new TextElement(body));
     }
 
+    public HtmlElement safecontent(String body) {
+        return content(new TextElement(StringEscapeUtils.escapeHtml4(body)));
+    }
+
     public HtmlElement content(HtmlRenderable... elements) {
         for (HtmlRenderable element : elements) {
             addToBody(element);
@@ -80,5 +85,4 @@ public class HtmlElement implements HtmlRenderable {
             renderer.append("</" + elementName + ">\n");
         }
     }
-
 }

programming_language: Java
filename: FileDirectoryEntryTest.java
change_type: ModificationType.ADD
diff: @@ -0,0 +1,34 @@
+/*
+ * Copyright 2021 ThoughtWorks, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.thoughtworks.go.domain;
+
+import com.thoughtworks.go.server.presentation.models.HtmlRenderer;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class FileDirectoryEntryTest {
+    @Test
+    void shouldEscapeFilename() {
+        FileDirectoryEntry entry = new FileDirectoryEntry("<div>Hello</div>", "https://www.example.com");
+        HtmlRenderer renderer = new HtmlRenderer("");
+        entry.htmlBody().render(renderer);
+
+        assertTrue(renderer.asString().contains("&lt;div&gt;Hello&lt;/div&gt;"));
+        assertFalse(renderer.asString().contains("<div>Hello</div>"));
+    }
+}
\ No newline at end of file

programming_language: Java
filename: FolderDirectoryEntryTest.java
change_type: ModificationType.MODIFY
diff: @@ -15,10 +15,11 @@
  */
 package com.thoughtworks.go.domain;
 
+import com.thoughtworks.go.server.presentation.models.HtmlRenderer;
 import org.junit.jupiter.api.Test;
 
-import static org.hamcrest.Matchers.hasItem;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.*;
 
 public class FolderDirectoryEntryTest {
     @Test
@@ -28,4 +29,16 @@ public class FolderDirectoryEntryTest {
         entry.addFile("file", "path");
         assertThat(subDirectory, hasItem(new FileDirectoryEntry("file", "path")));
     }
+
+    @Test
+    public void shouldEscapeFolderName() throws Exception {
+        DirectoryEntries subDirectory = new DirectoryEntries();
+        FolderDirectoryEntry entry = new FolderDirectoryEntry("<div>Hello</div>", "url", subDirectory);
+
+        HtmlRenderer renderer = new HtmlRenderer("");
+        entry.htmlBody().render(renderer);
+
+        assertThat(renderer.asString(), containsString("&lt;div&gt;Hello&lt;/div&gt;"));
+        assertThat(renderer.asString(), not(containsString("<div>Hello</div>")));
+    }
 }

programming_language: Java
filename: HtmlElementTest.java
change_type: ModificationType.ADD
diff: @@ -0,0 +1,34 @@
+/*
+ * Copyright 2021 ThoughtWorks, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.thoughtworks.go.server.presentation.html;
+
+import com.thoughtworks.go.server.presentation.models.HtmlRenderer;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class HtmlElementTest {
+    @Test
+    void shouldEscapeContent() {
+        HtmlElement element = HtmlElement.span().safecontent("<div>Hello</div>");
+        HtmlRenderer renderer = new HtmlRenderer("");
+
+        element.render(renderer);
+
+        assertEquals("<span>\n&lt;div&gt;Hello&lt;/div&gt;\n</span>\n", renderer.asString());
+    }
+}
\ No newline at end of file

programming_language: Java
filename: dependencies.gradle
change_type: ModificationType.MODIFY
diff: @@ -48,6 +48,7 @@ final Map<String, String> libraries = [
   commonsLang         : 'commons-lang:commons-lang:2.6',
   commonsLang3        : 'org.apache.commons:commons-lang3:3.12.0',
   commonsPool         : 'org.apache.commons:commons-pool2:2.11.1',
+  commonsText         : 'org.apache.commons:commons-text:1.8',
   dbunit              : 'org.dbunit:dbunit:2.7.2',
   dom4j               : 'dom4j:dom4j:1.6.1',
   ehcache             : 'net.sf.ehcache:ehcache:2.10.9.2',
@@ -131,6 +132,7 @@ final Map<String, String> v = [
   commonsLang         : versionOf(libraries.commonsLang),
   commonsLang3        : versionOf(libraries.commonsLang3),
   commonsPool         : versionOf(libraries.commonsPool),
+  commonsText         : versionOf(libraries.commonsText),
   dom4j               : versionOf(libraries.dom4j),
   ehcache             : versionOf(libraries.ehcache),
   felix               : versionOf(libraries.felix),

programming_language: JavaScript
filename: build.gradle
change_type: ModificationType.MODIFY
diff: @@ -817,6 +817,7 @@ task verifyWar(type: VerifyJarTask) {
         "commons-io-${project.versions.commonsIO}.jar",
         "commons-lang-${project.versions.commonsLang}.jar",
         "commons-lang3-${project.versions.commonsLang3}.jar",
+        "commons-text-${project.versions.commonsText}.jar",
         "commons-pool2-${project.versions.commonsPool}.jar",
         "config-api-${project.version}.jar",
         "config-server-${project.version}.jar",

programming_language: Scala