Vulnerability: The jpeg2000_decode_tile function in libavcodec/jpeg2000dec.c in FFmpeg before 2.1 does not consider the component number in certain calculations, which allows remote attackers to cause a denial of service (out-of-bounds array access) or possibly have unspecified other impact via crafted JPEG2000 data.
Vulnerability ID: CVE-2013-7024
CWE: CWE-119
Severity score: 6.4
Project: https://github.com/FFmpeg/FFmpeg
Published: 2013-12-09
File: libavcodec/jpeg2000dec.c
Commit message: avcodec/jpeg2000dec: prevent out of array accesses in pixel addressing

Fixes Ticket2921

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Commit author: Michael Niedermayer

Vulnerable version (before fix):
 static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,               y    = tile->comp[compno].coord[1][0] - s->image_offset_y;             line = picture->data[plane] + y * picture->linesize[plane];             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {                 uint8_t *dst;                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;                 dst = line + x * pixelsize + compno*!planar;                  if (codsty->transform == FF_DWT97) {                     for (; x < w; x += s->cdx[compno]) { static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,                 plane = s->cdef[compno] ? s->cdef[compno]-1 : (s->ncomponents-1);              y     = tile->comp[compno].coord[1][0] - s->image_offset_y;             linel = (uint16_t *)picture->data[plane] + y * (picture->linesize[plane] >> 1);             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {                 uint16_t *dst;                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;                 dst = linel + (x * pixelsize + compno*!planar);                 if (codsty->transform == FF_DWT97) {                     for (; x < w; x += s-> cdx[compno]) {                         int  val = lrintf(*datap) + (1 << (cbps - 1));

Fixed version (after fix):
 static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,               y    = tile->comp[compno].coord[1][0] - s->image_offset_y;             line = picture->data[plane] + y / s->cdy[compno] * picture->linesize[plane];             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {                 uint8_t *dst;                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;                 dst = line + x / s->cdx[compno] * pixelsize + compno*!planar;                  if (codsty->transform == FF_DWT97) {                     for (; x < w; x += s->cdx[compno]) { static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,                 plane = s->cdef[compno] ? s->cdef[compno]-1 : (s->ncomponents-1);              y     = tile->comp[compno].coord[1][0] - s->image_offset_y;             linel = (uint16_t *)picture->data[plane] + y / s->cdy[compno] * (picture->linesize[plane] >> 1);             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {                 uint16_t *dst;                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;                 dst = linel + (x / s->cdx[compno] * pixelsize + compno*!planar);                 if (codsty->transform == FF_DWT97) {                     for (; x < w; x += s-> cdx[compno]) {                         int  val = lrintf(*datap) + (1 << (cbps - 1));

Patch:
patch: @@ -1278,12 +1278,12 @@ static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,
 
 
             y    = tile->comp[compno].coord[1][0] - s->image_offset_y;
-            line = picture->data[plane] + y * picture->linesize[plane];
+            line = picture->data[plane] + y / s->cdy[compno] * picture->linesize[plane];
             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {
                 uint8_t *dst;
 
                 x   = tile->comp[compno].coord[0][0] - s->image_offset_x;
-                dst = line + x * pixelsize + compno*!planar;
+                dst = line + x / s->cdx[compno] * pixelsize + compno*!planar;
 
                 if (codsty->transform == FF_DWT97) {
                     for (; x < w; x += s->cdx[compno]) {
@@ -1324,12 +1324,12 @@ static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,
                 plane = s->cdef[compno] ? s->cdef[compno]-1 : (s->ncomponents-1);
 
             y     = tile->comp[compno].coord[1][0] - s->image_offset_y;
-            linel = (uint16_t *)picture->data[plane] + y * (picture->linesize[plane] >> 1);
+            linel = (uint16_t *)picture->data[plane] + y / s->cdy[compno] * (picture->linesize[plane] >> 1);
             for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {
                 uint16_t *dst;
 
                 x   = tile->comp[compno].coord[0][0] - s->image_offset_x;
-                dst = linel + (x * pixelsize + compno*!planar);
+                dst = linel + (x / s->cdx[compno] * pixelsize + compno*!planar);
                 if (codsty->transform == FF_DWT97) {
                     for (; x < w; x += s-> cdx[compno]) {
                         int  val = lrintf(*datap) + (1 << (cbps - 1));
path: libavcodec/jpeg2000dec.c