Vulnerability: net/nfc/llcp_sock.c in the Linux kernel before 5.12.10 allows local unprivileged users to cause a denial of service (NULL pointer dereference and BUG) by making a getsockname call after a certain type of failure of a bind call.
Vulnerability ID: CVE-2021-38208
CWE: CWE-476
Severity score: 2.9
Project: https://github.com/torvalds/linux
Published: 2021-08-08
File: net/nfc/llcp_sock.c
Commit message: nfc: fix NULL ptr dereference in llcp_sock_getname() after failed connect

It's possible to trigger NULL pointer dereference by local unprivileged
user, when calling getsockname() after failed bind() (e.g. the bind
fails because LLCP_SAP_MAX used as SAP):

  BUG: kernel NULL pointer dereference, address: 0000000000000000
  CPU: 1 PID: 426 Comm: llcp_sock_getna Not tainted 5.13.0-rc2-next-20210521+ #9
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-1 04/01/2014
  Call Trace:
   llcp_sock_getname+0xb1/0xe0
   __sys_getpeername+0x95/0xc0
   ? lockdep_hardirqs_on_prepare+0xd5/0x180
   ? syscall_enter_from_user_mode+0x1c/0x40
   __x64_sys_getpeername+0x11/0x20
   do_syscall_64+0x36/0x70
   entry_SYSCALL_64_after_hwframe+0x44/0xae

This can be reproduced with Syzkaller C repro (bind followed by
getpeername):
https://syzkaller.appspot.com/x/repro.c?x=14def446e00000

Cc: <stable@vger.kernel.org>
Fixes: d646960f7986 ("NFC: Initial LLCP support")
Reported-by: syzbot+80fb126e7f7d8b1a5914@syzkaller.appspotmail.com
Reported-by: butt3rflyh4ck <butterflyhuangxx@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210531072138.5219-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Commit author: Krzysztof Kozlowski

Vulnerable version (before fix):
 static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) 	if (!llcp_sock->service_name) { 		nfc_llcp_local_put(llcp_sock->local); 		llcp_sock->local = NULL; 		ret = -ENOMEM; 		goto put_dev; 	} static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) 		llcp_sock->local = NULL; 		kfree(llcp_sock->service_name); 		llcp_sock->service_name = NULL; 		ret = -EADDRINUSE; 		goto put_dev; 	}

Fixed version (after fix):
 static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) 	if (!llcp_sock->service_name) { 		nfc_llcp_local_put(llcp_sock->local); 		llcp_sock->local = NULL; 		llcp_sock->dev = NULL; 		ret = -ENOMEM; 		goto put_dev; 	} static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) 		llcp_sock->local = NULL; 		kfree(llcp_sock->service_name); 		llcp_sock->service_name = NULL; 		llcp_sock->dev = NULL; 		ret = -EADDRINUSE; 		goto put_dev; 	}

Patch:
patch: @@ -110,6 +110,7 @@ static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
 	if (!llcp_sock->service_name) {
 		nfc_llcp_local_put(llcp_sock->local);
 		llcp_sock->local = NULL;
+		llcp_sock->dev = NULL;
 		ret = -ENOMEM;
 		goto put_dev;
 	}
@@ -119,6 +120,7 @@ static int llcp_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
 		llcp_sock->local = NULL;
 		kfree(llcp_sock->service_name);
 		llcp_sock->service_name = NULL;
+		llcp_sock->dev = NULL;
 		ret = -EADDRINUSE;
 		goto put_dev;
 	}
path: net/nfc/llcp_sock.c