Vulnerability: elFinder unsafe upload filtering leading to remote code execution ### Impact

Before elFinder 2.1.58, the upload filter did not disallow the upload of `.phar` files. As several Linux distributions are now shipping Apache configured in a way it will process these files as PHP scripts, attackers could gain arbitrary code execution on the server hosting the PHP connector (even in minimal configuration).

### Patches

The issue has been addressed with https://github.com/Studio-42/elFinder/commit/75ea92decc16a5daf7f618f85dc621d1b534b5e1, associating `.phar` files to the right MIME type. Unless explicitly allowed in the configuration, such files cannot be uploaded anymore. This patch is part of the last release of elFinder, 2.1.58.

### Workarounds

If you can't update to 2.1.58, make sure your connector is not exposed without authentication.

### Important tips

Server-side scripts can often be created as text files. Currently, elFinder has an appropriate MIME type set for file extensions that are generally runnable on a web server.

However, the server has various settings. In some cases, the executable file may be judged as "text/plain". Therefore, elFinder installers should understand the extensions that can be executed on the web server where elFinder is installed, and check if there are any missing items in the elFinder settings.

The elFinder PHP connector has an option "additionalMimeMap" that specifies the MIME type for each extension. See [#3295(comment)](https://github.com/Studio-42/elFinder/issues/3295#issuecomment-853042139) for more information.

### References

- https://snyk.io/vuln/composer:studio-42%2Felfinder
- https://github.com/Studio-42/elFinder/issues/3295
- Further technical details will be disclosed on https://blog.sonarsource.com/tag/security after some time.

### For more information

If you have any questions or comments about this advisory, you can contact:
- The original reporters, by sending an email to  support [at] snyk.io or vulnerability.research [at] sonarsource.com;
- The maintainers, by opening an issue on this repository.
Vulnerability ID: GHSA-qm58-cvvm-c5qr
CWE: CWE-434
Severity score: 8.1
Project: https://github.com/Studio-42/elFinder
Published: 2021-06-15
File: php/elFinderVolumeDriver.class.php
Commit message: [VD:abstract] add `'phar:*' => 'text/x-php'` into 'staticMineMap'

rel. #3295
Commit author: nao-pon

Vulnerable version (before fix):
 abstract class elFinderVolumeDriver             'php5:*' => 'text/x-php',             'php7:*' => 'text/x-php',             'phtml:*' => 'text/x-php',             'cgi:*' => 'text/x-httpd-cgi',             'pl:*' => 'text/x-perl',             'asp:*' => 'text/x-asap',

Fixed version (after fix):
 abstract class elFinderVolumeDriver             'php5:*' => 'text/x-php',             'php7:*' => 'text/x-php',             'phtml:*' => 'text/x-php',             'phar:*' => 'text/x-php',             'cgi:*' => 'text/x-httpd-cgi',             'pl:*' => 'text/x-perl',             'asp:*' => 'text/x-asap',

Patch:
patch: @@ -281,6 +281,7 @@ abstract class elFinderVolumeDriver
             'php5:*' => 'text/x-php',
             'php7:*' => 'text/x-php',
             'phtml:*' => 'text/x-php',
+            'phar:*' => 'text/x-php',
             'cgi:*' => 'text/x-httpd-cgi',
             'pl:*' => 'text/x-perl',
             'asp:*' => 'text/x-asap',
path: php/elFinderVolumeDriver.class.php