Repository: xbmc/xbmc
File: xbmc/addons/addoninfo/AddonInfoBuilder.h (C/C++)

Code before:
  static bool ParseXML(const AddonInfoPtr& addon,
                       const tinyxml2::XMLElement* element,
                       const std::string& addonPath,
                       const RepositoryDirInfo& repo);
  static bool ParseXMLTypes(CAddonType& addonType,
                            const AddonInfoPtr& info,
                            const tinyxml2::XMLElement* child);
  static bool ParseXMLExtension(CAddonExtensions& addonExt, const tinyxml2::XMLElement* element);
  static bool GetTextList(const tinyxml2::XMLElement* element,
                          const std::string& tag,
                          CLocale::LocalizedStringsMap& translatedValues);
  static const char* GetPlatformLibraryName(const tinyxml2::XMLElement* element);
  static bool PlatformSupportsAddon(const AddonInfoPtr& addon);
};

class CAddonInfoBuilderFromDB
{
public:
  CAddonInfoBuilderFromDB();

  void SetId(std::string id);
  void SetName(std::string name);
  void SetLicense(std::string license);
  void SetSummary(const std::string& summary);
  void SetDescription(const std::string& description);
  void SetDisclaimer(const std::string& disclaimer);
  void SetAuthor(std::string author);
  void SetSource(std::string source);
  void SetWebsite(std::string website);
  void SetForum(std::string forum);
  void SetEMail(std::string email);
  void SetIcon(std::string icon);
  void SetArt(const std::string& type, std::string value);
  void SetArt(KODI::ART::Artwork art);
  void SetScreenshots(std::vector<std::string> screenshots);
  void SetChangelog(const std::string& changelog);
  void SetLifecycleState(AddonLifecycleState state, std::string description);
  void SetPath(std::string path);
  void SetLibName(std::string libname);
  void SetVersion(CAddonVersion version);
  void SetDependencies(std::vector<DependencyInfo> dependencies);
  void SetExtrainfo(InfoMap extrainfo);
  void SetInstallDate(const CDateTime& installDate);
  void SetLastUpdated(const CDateTime& lastUpdated);
  void SetLastUsed(const CDateTime& lastUsed);
  void SetOrigin(std::string origin);
  void SetPackageSize(uint64_t size);
  void SetExtensions(CAddonType addonType);

  const AddonInfoPtr& get() const { return m_addonInfo; }


Review comment (suggestion):
Nope. This is no different from `SetId`, `SetName`, etc., it's just clang-tidys heuristics that are not good enough to see that.

Same with `SetChangelog` below.

Code after:
  static bool ParseXML(const AddonInfoPtr& addon,
                       const tinyxml2::XMLElement* element,
                       const std::string& addonPath,
                       const RepositoryDirInfo& repo);
  static bool ParseXMLTypes(CAddonType& addonType,
                            const AddonInfoPtr& info,
                            const tinyxml2::XMLElement* child);
  static bool ParseXMLExtension(CAddonExtensions& addonExt, const tinyxml2::XMLElement* element);
  static bool GetTextList(const tinyxml2::XMLElement* element,
                          const std::string& tag,
                          CLocale::LocalizedStringsMap& translatedValues);
  static const char* GetPlatformLibraryName(const tinyxml2::XMLElement* element);
  static bool PlatformSupportsAddon(const AddonInfoPtr& addon);
};

class CAddonInfoBuilderFromDB
{
public:
  CAddonInfoBuilderFromDB();

  void SetId(std::string id);
  void SetName(std::string name);
  void SetLicense(std::string license);
  void SetSummary(std::string summary);
  void SetDescription(std::string description);
  void SetDisclaimer(std::string disclaimer);
  void SetAuthor(std::string author);
  void SetSource(std::string source);
  void SetWebsite(std::string website);
  void SetForum(std::string forum);
  void SetEMail(std::string email);
  void SetIcon(std::string icon);
  void SetArt(const std::string& type, std::string value);
  void SetArt(KODI::ART::Artwork art);
  void SetScreenshots(std::vector<std::string> screenshots);
  void SetChangelog(std::string changelog);
  void SetLifecycleState(AddonLifecycleState state, std::string description);
  void SetPath(std::string path);
  void SetLibName(std::string libname);
  void SetVersion(CAddonVersion version);
  void SetDependencies(std::vector<DependencyInfo> dependencies);
  void SetExtrainfo(InfoMap extrainfo);
  void SetInstallDate(const CDateTime& installDate);
  void SetLastUpdated(const CDateTime& lastUpdated);
  void SetLastUsed(const CDateTime& lastUsed);
  void SetOrigin(std::string origin);
  void SetPackageSize(uint64_t size);
  void SetExtensions(CAddonType addonType);

  const AddonInfoPtr& get() const { return m_addonInfo; }