Repository: home-assistant/core
File: tests/components/light/test_trigger.py (Python)

Code before:
        ),
    ],
)
async def test_light_state_trigger_behavior_any(
    hass: HomeAssistant,
    service_calls: list[ServiceCall],
    target_lights: list[str],
    trigger_target_config: dict,
    entity_id: str,
    entities_in_target: int,
    trigger: str,
    states: list[StateDescription],
) -> None:
    """Test that the light state trigger fires when any light state changes to a specific state."""
    other_entity_ids = set(target_lights) - {entity_id}

    # Set all lights, including the tested light, to the initial state
    for eid in target_lights:
        set_or_remove_state(hass, eid, states[0]["included"])
        await hass.async_block_till_done()

    await arm_trigger(hass, trigger, {}, trigger_target_config)

    for state in states[1:]:
        included_state = state["included"]
        set_or_remove_state(hass, entity_id, included_state)
        await hass.async_block_till_done()
        assert len(service_calls) == state["count"]
        for service_call in service_calls:
            assert service_call.data[CONF_ENTITY_ID] == entity_id
        service_calls.clear()

        # Check if changing other lights also triggers
        for other_entity_id in other_entity_ids:
            set_or_remove_state(hass, other_entity_id, included_state)
            await hass.async_block_till_done()
        assert len(service_calls) == (entities_in_target - 1) * state["count"]
        service_calls.clear()


@pytest.mark.usefixtures("enable_experimental_triggers_conditions")
@pytest.mark.parametrize(
    ("trigger_target_config", "entity_id", "entities_in_target"),
    parametrize_target_entities("light"),
)
@pytest.mark.parametrize(
    ("trigger", "states"),
    [
        *parametrize_trigger_states(
            trigger="light.turned_on",
            target_states=[STATE_ON],

Review comment (suggestion):
```suggestion
def parametrize_numeric_change_trigger_states(
```

we should also rename the climate ones

Code after:
def parametrize_light_trigger_states(
    *,
    trigger: str,
    trigger_options: dict | None = None,
    target_states: list[str | None | tuple[str | None, dict]],
    other_states: list[str | None | tuple[str | None, dict]],
    additional_attributes: dict | None = None,
    trigger_from_none: bool = True,
    retrigger_on_target_state: bool = False,
) -> list[tuple[str, dict[str, Any], list[StateDescription]]]:
    """Parametrize states and expected service call counts."""
    trigger_options = trigger_options or {}
    return [
        (s[0], trigger_options, *s[1:])
        for s in parametrize_trigger_states(
            trigger=trigger,
            target_states=target_states,
            other_states=other_states,
            additional_attributes=additional_attributes,
            trigger_from_none=trigger_from_none,
            retrigger_on_target_state=retrigger_on_target_state,
        )
    ]


def parametrize_xxx_changed_trigger_states(
    trigger: str, attribute: str
) -> list[tuple[str, dict[str, Any], list[StateDescription]]]:
    """Parametrize states and expected service call counts for xxx_changed triggers."""
    return [
        *parametrize_light_trigger_states(
            trigger=trigger,
            target_states=[
                (STATE_ON, {attribute: 0}),
                (STATE_ON, {attribute: 50}),
                (STATE_ON, {attribute: 100}),
            ],
            other_states=[(STATE_ON, {attribute: None})],
            retrigger_on_target_state=True,
        ),
        *parametrize_light_trigger_states(
            trigger=trigger,
            trigger_options={CONF_ABOVE: 10},
            target_states=[
                (STATE_ON, {attribute: 50}),
                (STATE_ON, {attribute: 100}),
            ],
            other_states=[
                (STATE_ON, {attribute: None}),
                (STATE_ON, {attribute: 0}),
            ],