Repository: apache/kafka
File: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java (Java)

Code before:

    public String remoteLogMetadataManagerListenerName() {
        return config.getString(REMOTE_LOG_METADATA_MANAGER_LISTENER_NAME_PROP);
    }

    public int remoteLogMetadataCustomMetadataMaxBytes() {
        return config.getInt(REMOTE_LOG_METADATA_CUSTOM_METADATA_MAX_BYTES_PROP);
    }

    public Map<String, Object> remoteStorageManagerProps() {
        return getConfigProps(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP);
    }

    public Map<String, Object> remoteLogMetadataManagerProps() {
        return getConfigProps(REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX_PROP);
    }

    public Map<String, Object> getConfigProps(String configPrefixProp) {
        String prefixProp = config.getString(configPrefixProp);
        return prefixProp == null ? Map.of() : Collections.unmodifiableMap(config.originalsWithPrefix(prefixProp));
    }

    public int remoteLogManagerCopyNumQuotaSamples() {
        return config.getInt(REMOTE_LOG_MANAGER_COPY_QUOTA_WINDOW_NUM_PROP);
    }

    public int remoteLogManagerCopyQuotaWindowSizeSeconds() {
        return config.getInt(REMOTE_LOG_MANAGER_COPY_QUOTA_WINDOW_SIZE_SECONDS_PROP);
    }

    public int remoteLogManagerFetchNumQuotaSamples() {
        return config.getInt(REMOTE_LOG_MANAGER_FETCH_QUOTA_WINDOW_NUM_PROP);
    }

    public int remoteLogManagerFetchQuotaWindowSizeSeconds() {
        return config.getInt(REMOTE_LOG_MANAGER_FETCH_QUOTA_WINDOW_SIZE_SECONDS_PROP);
    }

    public long remoteLogIndexFileCacheTotalSizeBytes() {
        return config.getLong(REMOTE_LOG_INDEX_FILE_CACHE_TOTAL_SIZE_BYTES_PROP);
    }

    public long remoteLogManagerCopyMaxBytesPerSecond() {
        return config.getLong(REMOTE_LOG_MANAGER_COPY_MAX_BYTES_PER_SECOND_PROP);
    }

    public long remoteLogManagerFetchMaxBytesPerSecond() {
        return config.getLong(REMOTE_LOG_MANAGER_FETCH_MAX_BYTES_PER_SECOND_PROP);
    }

    public int remoteFetchMaxWaitMs() {

Review comment (suggestion):
we should not remove the "prefix" configs, they are used by the RemoteStorageManager and RemoteLogMetadataManger plugins.

Code after:

    /**
     * Used by the RemoteStorageManager and RemoteLogMetadataManager plugins.
     */
    @SuppressWarnings("unused")
    public long remoteLogManagerTaskRetryBackoffMaxMs() {
        return config.getLong(REMOTE_LOG_MANAGER_TASK_RETRY_BACK_OFF_MAX_MS_PROP);
    }

    /**
     * Used by the RemoteStorageManager and RemoteLogMetadataManager plugins.
     */
    @SuppressWarnings("unused")
    public double remoteLogManagerTaskRetryJitter() {
        return config.getDouble(REMOTE_LOG_MANAGER_TASK_RETRY_JITTER_PROP);
    }

    public int remoteLogReaderThreads() {
        return config.getInt(REMOTE_LOG_READER_THREADS_PROP);
    }

    public int remoteLogReaderMaxPendingTasks() {
        return config.getInt(REMOTE_LOG_READER_MAX_PENDING_TASKS_PROP);
    }

    public String remoteLogMetadataManagerListenerName() {
        return config.getString(REMOTE_LOG_METADATA_MANAGER_LISTENER_NAME_PROP);
    }

    public int remoteLogMetadataCustomMetadataMaxBytes() {
        return config.getInt(REMOTE_LOG_METADATA_CUSTOM_METADATA_MAX_BYTES_PROP);
    }

    /**
     * Used by the RemoteStorageManager plugin.
     */
    @SuppressWarnings("unused")
    public String remoteStorageManagerPrefix() {
        return config.getString(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP);
    }

    /**
     * Used by the RemoteLogMetadataManager plugin.
     */
    @SuppressWarnings("unused")
    public String remoteLogMetadataManagerPrefix() {
        return config.getString(REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX_PROP);
    }

    public Map<String, Object> remoteStorageManagerProps() {
        return getConfigProps(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP);