Repository: xbmc/xbmc
File: xbmc/cores/VideoPlayer/VideoPlayer.cpp (C++)

Code before:
    m_CurrentSubtitle(StreamType::SUBTITLE, VideoPlayer_SUBTITLE),
    m_CurrentTeletext(StreamType::TELETEXT, VideoPlayer_TELETEXT),
    m_CurrentRadioRDS(StreamType::RADIO_RDS, VideoPlayer_RDS),
    m_CurrentAudioID3(StreamType::AUDIO_ID3, VideoPlayer_ID3),
    m_messenger("player"),
    m_outboundEvents(std::make_unique<CJobQueue>(false, 1, CJob::PRIORITY_NORMAL)),
    m_pInputStream(nullptr),
    m_pDemuxer(nullptr),
    m_pSubtitleDemuxer(nullptr),
    m_pCCDemuxer(nullptr),
    m_renderManager(m_clock, this)
{
  m_players_created = false;

  m_dvd.Clear();
  m_State.Clear();

  m_bAbortRequest = false;
  m_offset_pts = 0.0;
  m_playSpeed = DVD_PLAYSPEED_NORMAL;
  m_streamPlayerSpeed = DVD_PLAYSPEED_NORMAL;
  m_caching = CACHESTATE_DONE;
  m_HasVideo = false;
  m_HasAudio = false;
  m_updateStreamDetails = false;
  m_saveStreamDetails = false;

  const int tenthsSeconds = CServiceBroker::GetSettingsComponent()->GetSettings()->GetInt(
      CSettings::SETTING_VIDEOPLAYER_QUEUETIMESIZE);

  m_messageQueueTimeSize = static_cast<double>(tenthsSeconds) / 10.0;

  m_SkipCommercials = true;

  m_processInfo.reset(CProcessInfo::CreateInstance());
  // if we have a gui, register the cache
  m_processInfo->SetDataCache(&CServiceBroker::GetDataCacheCore());
  m_processInfo->SetSpeed(1.0);
  m_processInfo->SetTempo(1.0);
  m_processInfo->SetFrameAdvance(false);

  CreatePlayers();

  m_displayLost = false;
  m_error = false;
  m_bCloseRequest = false;
  CServiceBroker::GetWinSystem()->Register(this);
}

CVideoPlayer::~CVideoPlayer()
{

Review comment (suggestion):
No need to initialize the two members here because you have defined a default member initializer with exact the value you assign here.

Code after:
    m_CurrentTeletext(StreamType::TELETEXT, VideoPlayer_TELETEXT),
    m_CurrentRadioRDS(StreamType::RADIO_RDS, VideoPlayer_RDS),
    m_CurrentAudioID3(StreamType::AUDIO_ID3, VideoPlayer_ID3),
    m_messenger("player"),
    m_outboundEvents(std::make_unique<CJobQueue>(false, 1, CJob::PRIORITY_NORMAL)),
    m_pInputStream(nullptr),
    m_pDemuxer(nullptr),
    m_pSubtitleDemuxer(nullptr),
    m_pCCDemuxer(nullptr),
    m_renderManager(m_clock, this)
{
  m_players_created = false;

  m_dvd.Clear();
  m_State.Clear();

  m_bAbortRequest = false;
  m_offset_pts = 0.0;
  m_playSpeed = DVD_PLAYSPEED_NORMAL;
  m_streamPlayerSpeed = DVD_PLAYSPEED_NORMAL;
  m_caching = CACHESTATE_DONE;
  m_HasVideo = false;
  m_HasAudio = false;

  const int tenthsSeconds = CServiceBroker::GetSettingsComponent()->GetSettings()->GetInt(
      CSettings::SETTING_VIDEOPLAYER_QUEUETIMESIZE);

  m_messageQueueTimeSize = static_cast<double>(tenthsSeconds) / 10.0;

  m_SkipCommercials = true;

  m_processInfo.reset(CProcessInfo::CreateInstance());
  // if we have a gui, register the cache
  m_processInfo->SetDataCache(&CServiceBroker::GetDataCacheCore());
  m_processInfo->SetSpeed(1.0);
  m_processInfo->SetTempo(1.0);
  m_processInfo->SetFrameAdvance(false);

  CreatePlayers();

  m_displayLost = false;
  m_error = false;
  m_bCloseRequest = false;
  CServiceBroker::GetWinSystem()->Register(this);
}

CVideoPlayer::~CVideoPlayer()
{
  CServiceBroker::GetWinSystem()->Unregister(this);

  CloseFile();