Repository: quantopian/zipline
File: tests/pipeline/test_pipeline_algo.py (Python)

Code before:
            self.assertTrue(context.results.empty)
            count[0] += 1

        self.run_algorithm(
            initialize=initialize,
            handle_data=handle_data,
            before_trading_start=before_trading_start,
            sim_params=SimulationParameters(
                start_session=self.dates[0],
                end_session=current_day,
                data_frequency='daily',
                emission_rate='daily',
                trading_calendar=self.trading_calendar,
            )
        )

        self.assertTrue(count[0] > 0)


class PipelineSequenceTestCase(
    WithSeededRandomPipelineEngine,
    WithMakeAlgo,
    ZiplineTestCase,
):

    @classmethod
    def init_class_fixtures(cls):
        super(PipelineSequenceTestCase, cls).init_class_fixtures()

    def make_algo_kwargs(self, **overrides):
        return self.merge_with_inherited_algo_kwargs(
            PipelineSequenceTestCase,
            suite_overrides=dict(
                get_pipeline_loader=lambda column: self.seeded_random_loader,
            ),
            method_overrides=overrides,
        )

    def test_pipeline_compute_before_bts(self):

        # for storing and keeping track of calls to BTS and TestFactor.compute
        history = []
        counter = [0]

        class TestFactor(CustomFactor, SingleInputMixin):

            inputs = [TestingDataSet.float_col]

            def compute(self, today, assets, out, inputs):
                history.append(
                    "CustomFactor call"

Review comment (suggestion):
There's no reason to override a method if all you're doing is calling `super()`. That's doing the exact same thing as if you didn't override the method at all.

Code after:
        self.run_algorithm(
            initialize=initialize,
            handle_data=handle_data,
            before_trading_start=before_trading_start,
            sim_params=SimulationParameters(
                start_session=self.dates[0],
                end_session=current_day,
                data_frequency='daily',
                emission_rate='daily',
                trading_calendar=self.trading_calendar,
            )
        )

        self.assertTrue(count[0] > 0)


class PipelineSequenceTestCase(WithMakeAlgo, ZiplineTestCase):

    def make_algo_kwargs(self, **overrides):
        # run the algorithm for 3 days
        self.START_DATE = pd.Timestamp('2015-07-13', tz='utc')
        self.END_DATE = pd.Timestamp('2015-07-15', tz='utc')
        return self.merge_with_inherited_algo_kwargs(
            PipelineSequenceTestCase,
            suite_overrides=dict(
                get_pipeline_loader=lambda column: self.fake_pipeline,
            ),
            method_overrides=overrides,
        )

    def fake_pipeline(self):
        raise AssertionError

    def test_pipeline_compute_before_bts(self):

        # for storing and keeping track of calls to BTS and TestFactor.compute
        trace = []

        class TestFactor(CustomFactor):
            inputs = ()

            # window_length doesn't actually matter for this test case
            window_length = 1

            def compute(self, today, assets, out):
                trace.append("CustomFactor call")

        def initialize(context):
            pipeline = attach_pipeline(Pipeline(), 'my_pipeline')
            test_factor = TestFactor()
            pipeline.add(test_factor, 'test_factor')