Repository: matplotlib/matplotlib
File: lib/matplotlib/axis.py (Python)

Code before:
        self._major = major

        name = self.__name__
        major_minor = "major" if major else "minor"
        self._size = mpl._val_or_rc(size, f"{name}.{major_minor}.size")
        self._width = mpl._val_or_rc(width, f"{name}.{major_minor}.width")
        self._base_pad = mpl._val_or_rc(pad, f"{name}.{major_minor}.pad")
        color = mpl._val_or_rc(color, f"{name}.color")
        labelcolor = mpl._val_or_rc(labelcolor, f"{name}.labelcolor")
        if cbook._str_equal(labelcolor, 'inherit'):
            # inherit from tick color
            labelcolor = mpl.rcParams[f"{name}.color"]
        labelsize = mpl._val_or_rc(labelsize, f"{name}.labelsize")

        self._set_labelrotation(labelrotation)

        if zorder is None:
            if major:
                zorder = mlines.Line2D.zorder + 0.01
            else:
                zorder = mlines.Line2D.zorder
        self._zorder = zorder

        grid_color = (
            mpl._val_or_rc(grid_color, "grid.color")
            if mpl.rcParams[f"grid.{major_minor}.color"] == "none"
            else mpl._val_or_rc(grid_color, f"grid.{major_minor}.color")
        )
        grid_linestyle = (
            mpl._val_or_rc(grid_linestyle, "grid.linestyle")
            if mpl.rcParams[f"grid.{major_minor}.linestyle"] == "none"
            else mpl._val_or_rc(grid_linestyle, f"grid.{major_minor}.linestyle")
        )
        grid_linewidth = (
            mpl._val_or_rc(grid_linewidth, "grid.linewidth")
            if mpl.rcParams[f"grid.{major_minor}.linewidth"] is None
            else mpl._val_or_rc(grid_linewidth, f"grid.{major_minor}.linewidth")
        )
        if grid_alpha is None and not mcolors._has_alpha_channel(grid_color):
            # alpha precedence: kwarg > color alpha > rcParams['grid.alpha']
            # Note: only resolve to rcParams if the color does not have alpha
            # otherwise `grid(color=(1, 1, 1, 0.5))` would work like
            #   grid(color=(1, 1, 1, 0.5), alpha=rcParams['grid.alpha'])
            # so the that the rcParams default would override color alpha.
            grid_alpha = (
                mpl.rcParams["grid.alpha"]
                if f"grid.{major_minor}.alpha" not in mpl.rcParams
                else mpl.rcParams[f"grid.{major_minor}.alpha"]
            )
        grid_kw = {k[5:]: v for k, v in kwargs.items()}


Review comment (suggestion):
```suggestion
            if mpl.rcParams[f"grid.{major_minor}.color"] is None
```
see comment on validation

Code after:
        self._major = major

        name = self.__name__
        major_minor = "major" if major else "minor"
        self._size = mpl._val_or_rc(size, f"{name}.{major_minor}.size")
        self._width = mpl._val_or_rc(width, f"{name}.{major_minor}.width")
        self._base_pad = mpl._val_or_rc(pad, f"{name}.{major_minor}.pad")
        color = mpl._val_or_rc(color, f"{name}.color")
        labelcolor = mpl._val_or_rc(labelcolor, f"{name}.labelcolor")
        if cbook._str_equal(labelcolor, 'inherit'):
            # inherit from tick color
            labelcolor = mpl.rcParams[f"{name}.color"]
        labelsize = mpl._val_or_rc(labelsize, f"{name}.labelsize")

        self._set_labelrotation(labelrotation)

        if zorder is None:
            if major:
                zorder = mlines.Line2D.zorder + 0.01
            else:
                zorder = mlines.Line2D.zorder
        self._zorder = zorder

        grid_color = mpl._val_or_rc(
            grid_color,
            f"grid.{major_minor}.color",
            "grid.color",
        )
        grid_linestyle = mpl._val_or_rc(
            grid_linestyle,
            f"grid.{major_minor}.linestyle",
            "grid.linestyle",
        )
        grid_linewidth = mpl._val_or_rc(
            grid_linewidth,
            f"grid.{major_minor}.linewidth",
            "grid.linewidth",
        )
        if grid_alpha is None and not mcolors._has_alpha_channel(grid_color):
            # alpha precedence: kwarg > color alpha > rcParams['grid.alpha']
            # Note: only resolve to rcParams if the color does not have alpha
            # otherwise `grid(color=(1, 1, 1, 0.5))` would work like
            #   grid(color=(1, 1, 1, 0.5), alpha=rcParams['grid.alpha'])
            # so the that the rcParams default would override color alpha.
            grid_alpha = mpl._val_or_rc(
                # grid_alpha is None so we can use the first key
                mpl.rcParams[f"grid.{major_minor}.alpha"],
                "grid.alpha",
            )

        grid_kw = {k[5:]: v for k, v in kwargs.items() if k != "rotation_mode"}