Repository: Rapptz/discord.py
File: discord/primary_guild.py (Python)

Code before:

from .asset import Asset
from .utils import snowflake_time

if TYPE_CHECKING:
    from .state import ConnectionState
    from .types.primary_guild import PrimaryGuild as PrimaryGuildPayload


class PrimaryGuild:
    r"""Represents the primary guild (formally known as a clan) of a :class:`User`"""
    __slots__ = ('_guild_id', 'identity_enabled', '_tag', '_badge', '_state')

    if TYPE_CHECKING:
        _guild_id: int
        identity_enabled: bool
        _tag: str
        _badge: str
        _state: ConnectionState

    def __init__(self, *, state, data: PrimaryGuildPayload) -> None:
        self._state = state
        self._update(data)

    def _update(self, data: PrimaryGuildPayload):
        self._guild_id = data.get('identity_guild_id', None)
        self.identity_enabled = data['identity_enabled']
        self._tag = data.get('tag', None)
        self._badge = data.get('badge')

    @property
    def guild_id(self) -> Optional[int]:
        """:class:`int`: Returns the primary guild's id"""
        if self._guild_id:
            return int(self._guild_id)
        return None

    @property
    def tag(self) -> Optional[str]:
        """:class:`str`: Return's the primary guild's tag"""
        if self._tag:
            return self._tag
        return None

    @property
    def badge(self) -> Optional[Asset]:
        """:class:`Asset`: Returns the primary guild's asset"""
        if self._badge and self.guild_id:
            return Asset._from_primary_guild(self._state, self.guild_id, self._badge)
        return None


Review comment (suggestion):
```suggestion
        self.id = _get_as_snowflake(data, 'identity_guild_id')
```
i feel like `user.primary_guild.guild_id` is a little redundant, and not much point to the property (also make sure to add the utils import :p)

Code after:

from .asset import Asset
from .utils import snowflake_time, _get_as_snowflake

if TYPE_CHECKING:
    from .state import ConnectionState
    from .types.user import PrimaryGuild as PrimaryGuildPayload
    from typing_extensions import Self


class PrimaryGuild:
    """Represents the primary guild identity of a :class:`User`

    .. versionadded:: 2.6

    Attributes
    -----------
    id: Optional[:class:`int`]
        The ID of the user's primary guild, if any.
    tag: Optional[:class:`str`]
        The primary guild's tag.
    identity_enabled: Optional[:class:`bool`]
        Whether the user has their primary guild publicly displayed. If ``None``, the user has a public guild but has not reaffirmed the guild identity after a change

        .. warning::

            Users can have their primary guild publicly displayed while still having an :attr:`id` of ``None``. Be careful when checking this attribute!
    """

    __slots__ = ('id', 'identity_enabled', 'tag', '_badge', '_state')

    def __init__(self, *, state: ConnectionState, data: PrimaryGuildPayload) -> None:
        self._state = state
        self._update(data)

    def _update(self, data: PrimaryGuildPayload):
        self.id = _get_as_snowflake(data, 'identity_guild_id')
        self.identity_enabled = data['identity_enabled']
        self.tag = data.get('tag', None)
        self._badge = data.get('badge')

    @property
    def badge(self) -> Optional[Asset]:
        """Optional[:class:`Asset`]: Returns the primary guild's asset"""
        if self._badge is not None and self.id is not None:
            return Asset._from_primary_guild(self._state, self.id, self._badge)
        return None

    @property
    def created_at(self) -> Optional[datetime]:
        """Optional[:class:`datetime.datetime`]: Returns the primary guild's creation time in UTC."""