Repository: apache/kafka
File: streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java (Java)

Code before:
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.kafka.streams.state;

import org.apache.kafka.streams.DslStoreFormat;

import java.util.Objects;

/**
 * {@code DslKeyValueParams} is a wrapper class for all parameters that function
 * as inputs to {@link DslStoreSuppliers#keyValueStore(DslKeyValueParams)}.
 */
public class DslKeyValueParams {

    private final String name;
    @Deprecated
    private final boolean isTimestamped;
    private final DslStoreFormat dslStoreFormat;

    /**
     * @param name          the name of the store (cannot be {@code null})
     * @param isTimestamped whether the returned stores should be timestamped, see ({@link TimestampedKeyValueStore}
     */
    @Deprecated
    public DslKeyValueParams(final String name, final boolean isTimestamped) {
        Objects.requireNonNull(name);
        this.name = name;
        this.isTimestamped = isTimestamped;
        this.dslStoreFormat = DslStoreFormat.TIMESTAMPED;
    }

    /**
     * @param name           the name of the store (cannot be {@code null})
     * @param dslStoreFormat the format of the state store, see ({@link DslStoreFormat}
     */
    public DslKeyValueParams(final String name, final DslStoreFormat dslStoreFormat) {
        Objects.requireNonNull(name);
        this.name = name;
        this.dslStoreFormat = dslStoreFormat;
        this.isTimestamped = true;
    }

    public String name() {
        return name;
    }

    @Deprecated
    public boolean isTimestamped() {
        return isTimestamped;

Review comment (suggestion):
Update JavaDocs, too.
```
@deprecated Since 4.3. Use {@link #DslKeyValueParams(String, DslStoreFormat)} instead.
```

Code after:
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.kafka.streams.state;

import org.apache.kafka.streams.DslStoreFormat;

import java.util.Objects;

/**
 * {@code DslKeyValueParams} is a wrapper class for all parameters that function
 * as inputs to {@link DslStoreSuppliers#keyValueStore(DslKeyValueParams)}.
 */
public class DslKeyValueParams {

    private final String name;
    private final boolean isTimestamped;
    private final DslStoreFormat dslStoreFormat;

    /**
     * @deprecated Since 4.3. Use {@link #DslKeyValueParams(String, DslStoreFormat)} instead.
     * @param name          the name of the store (cannot be {@code null})
     * @param isTimestamped whether the returned stores should be timestamped, see ({@link TimestampedKeyValueStore}
     */
    @Deprecated
    public DslKeyValueParams(final String name, final boolean isTimestamped) {
        Objects.requireNonNull(name);
        this.name = name;
        this.isTimestamped = isTimestamped;
        // If isTimestamped is false and the user is still calling the old deprecated constructor, we should assume they mean plain.
        this.dslStoreFormat = isTimestamped ? DslStoreFormat.TIMESTAMPED : DslStoreFormat.PLAIN;
    }

    /**
     * @param name           the name of the store (cannot be {@code null})
     * @param dslStoreFormat the format of the state store, see ({@link DslStoreFormat}
     */
    public DslKeyValueParams(final String name, final DslStoreFormat dslStoreFormat) {
        this.name =  Objects.requireNonNull(name);
        this.dslStoreFormat = Objects.requireNonNull(dslStoreFormat);
        this.isTimestamped = dslStoreFormat == DslStoreFormat.TIMESTAMPED;
    }

    public String name() {
        return name;
    }

    /**
     * @deprecated Since 4.3. Use {@link #dslStoreFormat()} instead to check the store format.
     * @return {@code true} if the store format is {@link DslStoreFormat#TIMESTAMPED}, {@code false} otherwise