Repository: apache/airflow
File: airflow-core/src/airflow/ui/src/pages/Connections/Connections.tsx (TypeScript)

Code before:
  return (
    <>
      <VStack alignItems="none">
        <SearchBar
          defaultValue={connectionIdPattern ?? ""}
          onChange={handleSearchChange}
          placeholder={translate("connections.searchPlaceholder")}
        />
        <HStack gap={4} mt={2}>
          <Spacer />
          <AddConnectionButton />
        </HStack>
      </VStack>

      <Box overflow="auto">
        <DataTable
          columns={columns}
          data={data?.connections ?? []}
          errorMessage={<ErrorAlert error={error} />}
          initialState={tableURLState}
          isFetching={isFetching}
          isLoading={isLoading}
          modelName="admin:connections.connection"
          noRowsMessage={<NothingFoundInfo />}
          onStateChange={setTableURLState}
          showRowCountHeading
          total={data?.total_entries ?? 0}
        />
      </Box>
      <ActionBar.Root closeOnInteractOutside={false} open={Boolean(selectedRows.size)}>
        <ActionBar.Content>
          <ActionBar.SelectionTrigger>
            {selectedRows.size} {translate("deleteActions.selected")}
          </ActionBar.SelectionTrigger>
          <ActionBar.Separator />
          <Tooltip content={translate("deleteActions.tooltip")}>
            <DeleteConnectionsButton
              clearSelections={clearSelections}
              deleteKeys={[...selectedRows.keys()]}
            />
          </Tooltip>
          <ActionBar.CloseTrigger onClick={clearSelections} />
        </ActionBar.Content>
      </ActionBar.Root>
    </>
  );
};


Review comment (suggestion):
Here we pass `showRowCountHeading` and sometimes we don't.

I think by default `showRowCountHeading` should be true and displayed all the time, i'm not sure there a lot of places where we don't want this. (even providers, etc.... we want that)

Code after:
  return (
    <>
      <VStack alignItems="none">
        <SearchBar
          defaultValue={connectionIdPattern ?? ""}
          onChange={handleSearchChange}
          placeholder={translate("connections.searchPlaceholder")}
        />
        <HStack gap={4} mt={2}>
          <Spacer />
          <AddConnectionButton />
        </HStack>
      </VStack>

      <Box overflow="auto">
        <DataTable
          columns={columns}
          data={data?.connections ?? []}
          errorMessage={<ErrorAlert error={error} />}
          initialState={tableURLState}
          isFetching={isFetching}
          isLoading={isLoading}
          modelName="admin:connections.connection"
          noRowsMessage={<NothingFoundInfo />}
          onStateChange={setTableURLState}
          total={data?.total_entries ?? 0}
        />
      </Box>
      <ActionBar.Root closeOnInteractOutside={false} open={Boolean(selectedRows.size)}>
        <ActionBar.Content>
          <ActionBar.SelectionTrigger>
            {selectedRows.size} {translate("deleteActions.selected")}
          </ActionBar.SelectionTrigger>
          <ActionBar.Separator />
          <Tooltip content={translate("deleteActions.tooltip")}>
            <DeleteConnectionsButton
              clearSelections={clearSelections}
              deleteKeys={[...selectedRows.keys()]}
            />
          </Tooltip>
          <ActionBar.CloseTrigger onClick={clearSelections} />
        </ActionBar.Content>
      </ActionBar.Root>
    </>
  );
};