Repository: gabime/spdlog
File: include/spdlog/sinks/mongo_sink.h (C/C++)

Code before:
//

#include "spdlog/common.h"
#include "spdlog/details/log_msg.h"
#include "spdlog/sinks/base_sink.h"
#include <spdlog/details/synchronous_factory.h>

#include <bsoncxx/builder/stream/document.hpp>
#include <bsoncxx/types.hpp>
#include <bsoncxx/view_or_value.hpp>

#include <mongocxx/client.hpp>
#include <mongocxx/exception/logic_error.hpp>
#include <mongocxx/instance.hpp>
#include <mongocxx/uri.hpp>

namespace spdlog {
namespace sinks {
template<typename Mutex>
class mongo_sink : public base_sink<Mutex>
{
public:
    mongo_sink(const std::string &db_name, const std::string &collection_name, const std::string &uri = "mongodb://localhost:27017")
        : mongo_sink(std::make_shared<mongocxx::instance>(), db_name, collection_name, uri) {}

    mongo_sink(const std::shared_ptr<mongocxx::instance> &instance, const std::string &db_name, const std::string &collection_name, const std::string &uri = "mongodb://localhost:27017")
        : instance_(instance)
        , db_name_(db_name)
        , coll_name_(collection_name)
    {
        try
        {
            client_ = spdlog::details::make_unique<mongocxx::client>(mongocxx::uri{uri});
        }
        catch (const std::exception&)
        {
            throw spdlog_ex("Error opening database");
        }
    }

    ~mongo_sink()
    {
        flush_();
    }

protected:
    void sink_it_(const details::log_msg &msg) override
    {
        using bsoncxx::builder::stream::document;
        using bsoncxx::builder::stream::finalize;


Review comment (suggestion):
I prefer the shared_ptr instance to be passed by value instead of const ref, and then moved to instsnce_. This is clearer API imo (and let the caller pass a  moved instance  as well if needed).

Code after:
//

#include "spdlog/common.h"
#include "spdlog/details/log_msg.h"
#include "spdlog/sinks/base_sink.h"
#include <spdlog/details/synchronous_factory.h>

#include <bsoncxx/builder/stream/document.hpp>
#include <bsoncxx/types.hpp>
#include <bsoncxx/view_or_value.hpp>

#include <mongocxx/client.hpp>
#include <mongocxx/instance.hpp>
#include <mongocxx/uri.hpp>

namespace spdlog {
namespace sinks {
template<typename Mutex>
class mongo_sink : public base_sink<Mutex>
{
public:
    mongo_sink(const std::string &db_name, const std::string &collection_name, const std::string &uri = "mongodb://localhost:27017")
    try : mongo_sink(std::make_shared<mongocxx::instance>(), db_name, collection_name, uri)
    {}
    catch (const std::exception &e)
    {
        throw_spdlog_ex(fmt_lib::format("Error opening database: {}", e.what()));
    }

    mongo_sink(std::shared_ptr<mongocxx::instance> instance, const std::string &db_name, const std::string &collection_name,
        const std::string &uri = "mongodb://localhost:27017")
        : instance_(std::move(instance))
        , db_name_(db_name)
        , coll_name_(collection_name)
    {
        try
        {
            client_ = spdlog::details::make_unique<mongocxx::client>(mongocxx::uri{uri});
        }
        catch (const std::exception &e)
        {
            throw_spdlog_ex(fmt_lib::format("Error opening database: {}", e.what()));
        }
    }

    ~mongo_sink()
    {
        flush_();
    }

protected: