Repository: syncthing/syncthing
File: gui/default/syncthing/core/syncthingController.js (JavaScript)

Code before:

                prevDate = now;

                try {
                    data.total.inbps = Math.max(0, (data.total.inBytesTotal - $scope.connectionsTotal.inBytesTotal) / td);
                    data.total.outbps = Math.max(0, (data.total.outBytesTotal - $scope.connectionsTotal.outBytesTotal) / td);
                } catch (e) {
                    data.total.inbps = 0;
                    data.total.outbps = 0;
                }
                $scope.connectionsTotal = data.total;

                data = data.connections;
                var currentAddresses = [];
                for (id in data) {
                    if (!data.hasOwnProperty(id)) {
                        continue;
                    }
                    if (Object.keys(data).length != $scope.devices.length) {
                        // Avoid errors when called before first updateLocalConfig()
                        continue;
                    }
                    if (!(id in $scope.idToRemoteGUI)) {
                        $scope.idToRemoteGUI[id] = "";
                    }
                    var port = $scope.findDevice(id).remoteGUIPort;
                    var isNotRelayConnection = !data[id].type.includes("relay");
                    if ($scope.showRemoteGUI && data[id].address != "" && isNotRelayConnection && port > 0) {
                        var newAddress = "http://" + replaceAddressPort(data[id].address, port);
                        currentAddresses.push(newAddress);
                        if (!(newAddress in $scope.remoteGUICache)) {
                            // No cached result, trigger a new port probing asynchronously
                            $scope.probeRemoteGUIAddress(id, newAddress);
                        }
                    }
                    try {
                        data[id].inbps = Math.max(0, (data[id].inBytesTotal - $scope.connections[id].inBytesTotal) / td);
                        data[id].outbps = Math.max(0, (data[id].outBytesTotal - $scope.connections[id].outBytesTotal) / td);
                    } catch (e) {
                        data[id].inbps = 0;
                        data[id].outbps = 0;
                    }
                }
                // Clean out stale addresses from probing results
                for (var address in $scope.remoteGUICache) {
                    console.log("clean test", address);
                    if (!currentAddresses.includes(address)) {
                        delete $scope.remoteGUICache[address];
                    }
                }
                $scope.connections = data;

Review comment (suggestion):
`findDevice()` removed on main branch, as `$scope.devices` is now a map itself:

```suggestion
                    var port = $scope.devices[id].remoteGUIPort;
```

Code after:
                var now = Date.now(),
                    td = (now - prevDate) / 1000,
                    id;

                prevDate = now;

                try {
                    data.total.inbps = Math.max(0, (data.total.inBytesTotal - $scope.connectionsTotal.inBytesTotal) / td);
                    data.total.outbps = Math.max(0, (data.total.outBytesTotal - $scope.connectionsTotal.outBytesTotal) / td);
                } catch (e) {
                    data.total.inbps = 0;
                    data.total.outbps = 0;
                }
                $scope.connectionsTotal = data.total;

                data = data.connections;
                for (id in data) {
                    if (!data.hasOwnProperty(id)) {
                        continue;
                    }
                    try {
                        data[id].inbps = Math.max(0, (data[id].inBytesTotal - $scope.connections[id].inBytesTotal) / td);
                        data[id].outbps = Math.max(0, (data[id].outBytesTotal - $scope.connections[id].outBytesTotal) / td);
                    } catch (e) {
                        data[id].inbps = 0;
                        data[id].outbps = 0;
                    }
                }
                $scope.connections = data;
                console.log("refreshConnections", data);

                refreshRemoteGUI(data);
            }).error($scope.emitHTTPError);
        }

        function refreshRemoteGUI(connections) {
            if (!$scope.showRemoteGUI) {
                $scope.idToRemoteGUI = {}
                return
            }
            var newCache = {};
            for (var id in connections) {
                if (!(id in $scope.devices)) {
                    // Avoid errors when called before first updateLocalConfig()
                    continue;
                }
                var port = $scope.devices[id].remoteGUIPort;
                if (port <= 0
                    || !connections[id].address
                    || connections[id].type.includes("relay")) {
                    // Relay connections never work as desired here, nor incomplete addresses