Repository: yt-dlp/yt-dlp
File: yt_dlp/extractor/softwhiteunderbelly.py (Python)

Code before:
            'info_dict': {
                'id': '3506029',
                'ext': 'mp4',
                'display_id': 'tj-2-final-2160p',
                'title': 'Fentanyl Addict interview-TJ (follow up)',
                'description': 'Soft White Underbelly follow up interview and portrait of TJ, a fentanyl addict on Skid Row.',
                'thumbnail': 'https://vhx.imgix.net/softwhiteunderbelly/assets/c883d531-5da0-4faf-a2e2-8eba97e5adfc.jpg',
                'duration': 817,
                'uploader': 'OTT Videos',
                'uploader_url': 'https://vimeo.com/user80538407',
                'uploader_id': 'user80538407',
            },
            'expected_warnings': ['Failed to parse XML: not well-formed'],
        },
    ]

    def _get_authenticity_token(self, display_id):
        signin_page = self._download_webpage(self._LOGIN_URL, display_id, note='Getting authenticity token')
        return self._html_search_regex(
            r'name=["\']authenticity_token["\'] value=["\'](.+?)["\']', signin_page, 'authenticity_token',
        )

    def _login(self, display_id):
        username, password = self._get_login_info()
        if not username:
            return True

        response = self._download_webpage(
            self._LOGIN_URL,
            display_id,
            note='Logging in',
            fatal=False,
            data=urlencode_postdata({
                'email': username,
                'password': password,
                'authenticity_token': self._get_authenticity_token(display_id),
                'utf8': True,
            }),
        )

        user_has_subscription = self._search_regex(
            r'user_has_subscription:\s*["\'](.+?)["\']', response, 'subscription status', default='none',
        )
        if user_has_subscription.lower() == 'true':
            return
        elif user_has_subscription.lower() == 'false':
            return 'Account is not subscribed'
        else:
            return 'Incorrect username/password'

    def _real_extract(self, url):

Review comment (refactor):
I don't see a reason for this not to be `_perform_login` (which is called by core code before `_real_initialize` or `_real_extract`). Any usage of `display_id` can be changed to `None`
```suggestion
    def _perform_login(self, username, password):
```

Code after:
            'description': 'Soft White Underbelly follow up interview and portrait of TJ, a fentanyl addict on Skid Row.',
            'thumbnail': 'https://vhx.imgix.net/softwhiteunderbelly/assets/c883d531-5da0-4faf-a2e2-8eba97e5adfc.jpg',
            'duration': 817,
            'uploader': 'OTT Videos',
            'uploader_url': 'https://vimeo.com/user80538407',
            'uploader_id': 'user80538407',
        },
        'expected_warnings': ['Failed to parse XML: not well-formed'],
    }]

    def _perform_login(self, username, password):
        signin_page = self._download_webpage(self._LOGIN_URL, None, 'Fetching authenticity token')
        self._download_webpage(
            self._LOGIN_URL, None, 'Logging in',
            data=urlencode_postdata({
                'email': username,
                'password': password,
                'authenticity_token': self._html_search_regex(
                    r'name=["\']authenticity_token["\']\s+value=["\']([^"\']+)', signin_page, 'authenticity_token'),
                'utf8': True,
            }),
        )

    def _real_extract(self, url):
        display_id = self._match_id(url)

        webpage = self._download_webpage(url, display_id)
        if '<div id="watch-unauthorized"' in webpage:
            if self._get_cookies('https://www.softwhiteunderbelly.com').get('_session'):
                raise ExtractorError('This account is not subscribed to this content', expected=True)
            self.raise_login_required()

        embed_url, embed_id = self._html_search_regex(
            r'embed_url:\s*["\'](?P<url>https?://embed\.vhx\.tv/videos/(?P<id>\d+)[^"\']*)',
            webpage, 'embed url', group=('url', 'id'))

        return {
            '_type': 'url_transparent',
            'ie_key': VHXEmbedIE.ie_key(),
            'url': VHXEmbedIE._smuggle_referrer(embed_url, 'https://www.softwhiteunderbelly.com'),
            'id': embed_id,
            'display_id': display_id,
            'title': traverse_obj(webpage, ({find_element(id='watch-info')}, {find_element(cls='video-title')}, {clean_html})),
            'description': self._html_search_meta('description', webpage, default=None),
            'thumbnail': update_url(self._og_search_thumbnail(webpage) or '', query=None) or None,
        }