Repository: paritytech/substrate
File: frame/election-provider-multi-phase/src/migrations.rs (Rust)

Code before:
// See the License for the specific language governing permissions and
// limitations under the License.

pub mod v1 {
	use frame_support::{
		storage::unhashed,
		traits::{Defensive, GetStorageVersion, OnRuntimeUpgrade},
		BoundedVec,
	};
	use sp_std::collections::btree_map::BTreeMap;

	use crate::*;
	pub struct MigrateToV1<T>(sp_std::marker::PhantomData<T>);
	impl<T: Config> OnRuntimeUpgrade for MigrateToV1<T> {
		fn on_runtime_upgrade() -> Weight {
			let current = Pallet::<T>::current_storage_version();
			let onchain = Pallet::<T>::on_chain_storage_version();

			log!(
				info,
				"Running migration with current storage version {:?} / onchain {:?}",
				current,
				onchain
			);

			if current == 1 && onchain == 0 {
				if SignedSubmissionIndices::<T>::exists() {
					// This needs to be tested at a both a block height where this value exists, and
					// when it doesn't.
					let now = frame_system::Pallet::<T>::block_number();
					let map = unhashed::get::<BTreeMap<ElectionScore, u32>>(
						&SignedSubmissionIndices::<T>::hashed_key(),
					)
					.defensive_unwrap_or_default();
					let vector = map
						.into_iter()
						.map(|(score, index)| (score, now, index))
						.collect::<Vec<_>>();
					// defensive-only
					let bounded = BoundedVec::<_, _>::truncate_from(vector);
					SignedSubmissionIndices::<T>::put(bounded);
					log!(info, "SignedSubmissionIndices existed and got migrated");
				} else {
					log!(info, "SignedSubmissionIndices did NOT exist.");
				}

				current.put::<Pallet<T>>();
				T::DbWeight::get().reads_writes(2, 1)
			} else {
				log!(info, "Migration did not executed. This probably should be removed");
				T::DbWeight::get().reads(1)

Review comment (suggestion):
Probably the condition could just be `if onchain == 0`. Pallet version is in a way implicit since its v1 migrations.

Code after:
// See the License for the specific language governing permissions and
// limitations under the License.

pub mod v1 {
	use frame_support::{
		storage::unhashed,
		traits::{Defensive, GetStorageVersion, OnRuntimeUpgrade},
		BoundedVec,
	};
	use sp_std::collections::btree_map::BTreeMap;

	use crate::*;
	pub struct MigrateToV1<T>(sp_std::marker::PhantomData<T>);
	impl<T: Config> OnRuntimeUpgrade for MigrateToV1<T> {
		fn on_runtime_upgrade() -> Weight {
			let current = Pallet::<T>::current_storage_version();
			let onchain = Pallet::<T>::on_chain_storage_version();

			log!(
				info,
				"Running migration with current storage version {:?} / onchain {:?}",
				current,
				onchain
			);

			if current == 1 && onchain == 0 {
				if SignedSubmissionIndices::<T>::exists() {
					// This needs to be tested at a both a block height where this value exists, and
					// when it doesn't.
					let now = frame_system::Pallet::<T>::block_number();
					let map = unhashed::get::<BTreeMap<ElectionScore, u32>>(
						&SignedSubmissionIndices::<T>::hashed_key(),
					)
					.defensive_unwrap_or_default();
					let vector = map
						.into_iter()
						.map(|(score, index)| (score, now, index))
						.collect::<Vec<_>>();

					log!(
						debug,
						"{:?} SignedSubmissionIndices read from storage (max: {:?})",
						vector.len(),
						T::SignedMaxSubmissions::get()
					);

					// defensive-only, assuming a constant `SignedMaxSubmissions`.
					let bounded = BoundedVec::<_, _>::truncate_from(vector);
					SignedSubmissionIndices::<T>::put(bounded);

					log!(info, "SignedSubmissionIndices existed and got migrated");