Repository: home-assistant/core
File: tests/components/light/test_trigger.py (Python)

Code before:
)
@pytest.mark.parametrize(
    ("trigger", "states"),
    [
        *parametrize_trigger_states(
            trigger="light.turned_on",
            target_states=[STATE_ON],
            other_states=[STATE_OFF],
        ),
        *parametrize_trigger_states(
            trigger="light.turned_off",
            target_states=[STATE_OFF],
            other_states=[STATE_ON],
        ),
    ],
)
async def test_light_state_trigger_behavior_first(
    hass: HomeAssistant,
    service_calls: list[ServiceCall],
    target_lights: list[str],
    trigger_target_config: dict,
    entity_id: str,
    entities_in_target: int,
    trigger: str,
    states: list[StateDescription],
) -> None:
    """Test that the light state trigger fires when the first light changes to a specific state."""
    other_entity_ids = set(target_lights) - {entity_id}

    # Set all lights, including the tested light, to the initial state
    for eid in target_lights:
        set_or_remove_state(hass, eid, states[0]["included"])
        await hass.async_block_till_done()

    await arm_trigger(hass, trigger, {"behavior": "first"}, trigger_target_config)

    for state in states[1:]:
        included_state = state["included"]
        set_or_remove_state(hass, entity_id, included_state)
        await hass.async_block_till_done()
        assert len(service_calls) == state["count"]
        for service_call in service_calls:
            assert service_call.data[CONF_ENTITY_ID] == entity_id
        service_calls.clear()

        # Triggering other lights should not cause the trigger to fire again
        for other_entity_id in other_entity_ids:
            set_or_remove_state(hass, other_entity_id, included_state)
            await hass.async_block_till_done()
        assert len(service_calls) == 0


Review comment (suggestion):
```suggestion
def parametrize_numeric_cross_threshold_trigger_states(
```

Code after:
                (STATE_ON, {attribute: 50}),
                (STATE_ON, {attribute: 100}),
            ],
            other_states=[
                (STATE_ON, {attribute: None}),
                (STATE_ON, {attribute: 0}),
            ],
            retrigger_on_target_state=True,
        ),
        *parametrize_light_trigger_states(
            trigger=trigger,
            trigger_options={CONF_BELOW: 90},
            target_states=[
                (STATE_ON, {attribute: 0}),
                (STATE_ON, {attribute: 50}),
            ],
            other_states=[
                (STATE_ON, {attribute: None}),
                (STATE_ON, {attribute: 100}),
            ],
            retrigger_on_target_state=True,
        ),
    ]


def parametrize_xxx_crossed_threshold_trigger_states(
    trigger: str, attribute: str
) -> list[tuple[str, dict[str, Any], list[StateDescription]]]:
    """Parametrize states and expected service call counts for xxx_crossed_threshold triggers."""
    return [
        *parametrize_light_trigger_states(
            trigger=trigger,
            trigger_options={
                CONF_THRESHOLD_TYPE: ThresholdType.BETWEEN,
                CONF_LOWER_LIMIT: 10,
                CONF_UPPER_LIMIT: 90,
            },
            target_states=[
                (STATE_ON, {attribute: 50}),
                (STATE_ON, {attribute: 60}),
            ],
            other_states=[
                (STATE_ON, {attribute: None}),
                (STATE_ON, {attribute: 0}),
                (STATE_ON, {attribute: 100}),
            ],
        ),
        *parametrize_light_trigger_states(
            trigger=trigger,
            trigger_options={
                CONF_THRESHOLD_TYPE: ThresholdType.OUTSIDE,