Repository: xbmc/xbmc
File: xbmc/pvr/recordings/PVRRecording.h (C/C++)

Code before:

  int m_iClientId; /*!< ID of the backend */
  std::string m_strRecordingId; /*!< unique ID of the recording on the client */
  std::string m_strChannelName; /*!< name of the channel this was recorded from */
  int m_iPriority; /*!< priority of this recording */
  int m_iLifetime; /*!< lifetime of this recording */
  std::string m_strDirectory; /*!< directory of this recording on the client */
  unsigned int m_iRecordingId; /*!< id that won't change while xbmc is running */

  CPVRCachedImage m_iconPath; /*!< icon path */
  CPVRCachedImage m_thumbnailPath; /*!< thumbnail path */
  CPVRCachedImage m_fanartPath; /*!< fanart path */
  CDateTime m_recordingTime; /*!< start time of the recording */
  bool m_bGotMetaData;
  bool m_bIsDeleted; /*!< set if entry is a deleted recording which can be undelete */
  mutable bool m_bInProgress; /*!< set if recording might be in progress */
  unsigned int m_iEpgEventId; /*!< epg broadcast id associated with this recording */
  int m_iChannelUid; /*!< channel uid associated with this recording */
  bool m_bRadio; /*!< radio or tv recording */
  int m_iGenreType = 0; /*!< genre type */
  int m_iGenreSubType = 0; /*!< genre subtype */
  mutable XbmcThreads::EndTime<> m_resumePointRefetchTimeout;
  unsigned int m_iFlags = 0; /*!< the flags applicable to this recording */
  mutable XbmcThreads::EndTime<> m_recordingSizeRefetchTimeout;
  int64_t m_sizeInBytes = 0; /*!< the size of the recording in bytes */
  bool m_bDirty = false;
  std::string m_strProviderName; /*!< name of the provider this recording is from */
  int m_iClientProviderUniqueId =
      PVR_PROVIDER_INVALID_UID; /*!< provider uid associated with this recording on the client */
  unsigned int m_parentalRating{0}; /*!< parental rating */
  std::string m_parentalRatingCode; /*!< Parental rating code */
  std::string m_parentalRatingIcon; /*!< parental rating icon path */
  std::string m_parentalRatingSource; /*!< parental rating source */
  int m_episodePartNumber{PVR_RECORDING_INVALID_SERIES_EPISODE}; /*!< episode part number */
  mutable CCriticalSection m_critSection;
};
} // namespace PVR


Review comment (suggestion):
Please do not delete the line which works as a logical separator between the different member types. Keep an empty line before `mutable CCriticalSection m_critSection;`, please.

Code after:
  int m_iClientId; /*!< ID of the backend */
  std::string m_strRecordingId; /*!< unique ID of the recording on the client */
  std::string m_strChannelName; /*!< name of the channel this was recorded from */
  int m_iPriority; /*!< priority of this recording */
  int m_iLifetime; /*!< lifetime of this recording */
  std::string m_strDirectory; /*!< directory of this recording on the client */
  unsigned int m_iRecordingId; /*!< id that won't change while xbmc is running */

  CPVRCachedImage m_iconPath; /*!< icon path */
  CPVRCachedImage m_thumbnailPath; /*!< thumbnail path */
  CPVRCachedImage m_fanartPath; /*!< fanart path */
  CDateTime m_recordingTime; /*!< start time of the recording */
  bool m_bGotMetaData;
  bool m_bIsDeleted; /*!< set if entry is a deleted recording which can be undelete */
  mutable bool m_bInProgress; /*!< set if recording might be in progress */
  unsigned int m_iEpgEventId; /*!< epg broadcast id associated with this recording */
  int m_iChannelUid; /*!< channel uid associated with this recording */
  bool m_bRadio; /*!< radio or tv recording */
  int m_iGenreType = 0; /*!< genre type */
  int m_iGenreSubType = 0; /*!< genre subtype */
  mutable XbmcThreads::EndTime<> m_resumePointRefetchTimeout;
  unsigned int m_iFlags = 0; /*!< the flags applicable to this recording */
  mutable XbmcThreads::EndTime<> m_recordingSizeRefetchTimeout;
  int64_t m_sizeInBytes = 0; /*!< the size of the recording in bytes */
  bool m_bDirty = false;
  std::string m_strProviderName; /*!< name of the provider this recording is from */
  int m_iClientProviderUniqueId =
      PVR_PROVIDER_INVALID_UID; /*!< provider uid associated with this recording on the client */
  unsigned int m_parentalRating{0}; /*!< parental rating */
  std::string m_parentalRatingCode; /*!< Parental rating code */
  std::string m_parentalRatingIcon; /*!< parental rating icon path */
  std::string m_parentalRatingSource; /*!< parental rating source */
  int m_episodePartNumber{PVR_RECORDING_INVALID_SERIES_EPISODE}; /*!< episode part number */

  mutable CCriticalSection m_critSection;
};
} // namespace PVR