Repository: apache/airflow
File: providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_spark_kubernetes.py (Python)

Code before:
        mock_create_pod,
        mock_await_pod_completion,
        mock_fetch_requested_container_logs,
        data_file,
    ):
        """
        Verifies that find_spark_job picks a Running Spark driver pod over a non-Running pod.
        """

        task_name = "test_find_spark_job_prefers_running_pod"
        job_spec = yaml.safe_load(data_file("spark/application_template.yaml").read_text())

        mock_create_job_name.return_value = task_name
        op = SparkKubernetesOperator(
            template_spec=job_spec,
            kubernetes_conn_id="kubernetes_default_kube_config",
            task_id=task_name,
            get_logs=True,
            reattach_on_restart=True,
        )
        context = create_context(op)

        # Pending pod should be selected.
        pending_pod = mock.MagicMock()
        pending_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        pending_pod.metadata.name = "spark-driver-running"
        pending_pod.metadata.labels = {"try_number": "1"}
        pending_pod.status.phase = "Pending"

        # Terminating pod should not be selected.
        terminating_pod = mock.MagicMock()
        terminating_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        terminating_pod.metadata.deletion_timestamp = timezone.datetime(2025, 1, 2, tzinfo=timezone.utc)
        terminating_pod.metadata.name = "spark-driver-pending"
        terminating_pod.metadata.labels = {"try_number": "1"}
        terminating_pod.status.phase = "Running"

        mock_get_kube_client.list_namespaced_pod.return_value.items = [
            pending_pod,
            terminating_pod,
        ]

        returned_pod = op.find_spark_job(context)

        assert returned_pod is pending_pod

    def test_find_spark_job_picks_succeeded(
        self,
        mock_is_in_cluster,
        mock_parent_execute,
        mock_create_namespaced_crd,

Review comment (suggestion):
I would advise changing this to: `"spark-driver"`. This is because the name is being used as a tie-breaker in the selection logic. Also, rename `pending_pod` to `non_terminating_pod`.

Code after:
        mock_create_pod,
        mock_await_pod_completion,
        mock_fetch_requested_container_logs,
        data_file,
    ):
        """
        Verifies that find_spark_job picks a Pending Spark driver pod over a Terminating.
        """

        task_name = "test_find_spark_job_prefers_pending_pod"
        job_spec = yaml.safe_load(data_file("spark/application_template.yaml").read_text())

        mock_create_job_name.return_value = task_name
        op = SparkKubernetesOperator(
            template_spec=job_spec,
            kubernetes_conn_id="kubernetes_default_kube_config",
            task_id=task_name,
            get_logs=True,
            reattach_on_restart=True,
        )
        context = create_context(op)

        # Pending pod should be selected.
        pending_pod = mock.MagicMock()
        pending_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        pending_pod.metadata.name = "spark-driver"
        pending_pod.metadata.labels = {"try_number": "1"}
        pending_pod.status.phase = "Pending"

        # Terminating pod should not be selected.
        terminating_pod = mock.MagicMock()
        terminating_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        terminating_pod.metadata.deletion_timestamp = timezone.datetime(2025, 1, 2, tzinfo=timezone.utc)
        terminating_pod.metadata.name = "spark-driver"
        terminating_pod.metadata.labels = {"try_number": "1"}
        terminating_pod.status.phase = "Running"

        mock_get_kube_client.list_namespaced_pod.return_value.items = [
            terminating_pod,  # comes first but should be ignored, as it is terminating
            pending_pod,
        ]

        returned_pod = op.find_spark_job(context)

        assert returned_pod is pending_pod

    def test_find_spark_job_picks_succeeded(
        self,
        mock_is_in_cluster,
        mock_parent_execute,
        mock_create_namespaced_crd,