Repository: apache/airflow
File: providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_spark_kubernetes.py (Python)

Code before:
        # Terminating pod should not be selected.
        terminating_pod = mock.MagicMock()
        terminating_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        terminating_pod.metadata.deletion_timestamp = timezone.datetime(2025, 1, 2, tzinfo=timezone.utc)
        terminating_pod.metadata.name = "spark-driver-pending"
        terminating_pod.metadata.labels = {"try_number": "1"}
        terminating_pod.status.phase = "Running"

        # Failed pod should not be selected.
        failed_pod = mock.MagicMock()
        failed_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        failed_pod.metadata.deletion_timestamp = timezone.datetime(2025, 1, 2, tzinfo=timezone.utc)
        failed_pod.metadata.name = "spark-driver-pending"
        failed_pod.metadata.labels = {"try_number": "1"}
        failed_pod.status.phase = "Failed"

        mock_get_kube_client.list_namespaced_pod.return_value.items = [
            succeeded_pod,
            terminating_pod,
            failed_pod,
        ]

        returned_pod = op.find_spark_job(context)

        assert returned_pod is succeeded_pod

    def test_find_spark_job_picks_latest_pod(
        self,
        mock_is_in_cluster,
        mock_parent_execute,
        mock_create_namespaced_crd,
        mock_get_namespaced_custom_object_status,
        mock_cleanup,
        mock_create_job_name,
        mock_get_kube_client,
        mock_create_pod,
        mock_await_pod_completion,
        mock_fetch_requested_container_logs,
        data_file,
    ):
        """
        Verifies that find_spark_job selects the most recently created Spark driver pod
        when multiple candidate driver pods are present and status does not disambiguate.
        """

        task_name = "test_find_spark_job_picks_latest_pod"
        job_spec = yaml.safe_load(data_file("spark/application_template.yaml").read_text())

        mock_create_job_name.return_value = task_name
        op = SparkKubernetesOperator(
            template_spec=job_spec,

Review comment (suggestion):
This test needs to be made more clear and explicit. I do not think there is a need to mock more than 2 pods. The emphasis should be on picking the pod with a newer vs older `creation_timestamp`. Please keep the other things I pointed out above in mind whilst refining this test as well.

Code after:
        # Running pod should be selected.
        running_pod = mock.MagicMock()
        running_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        running_pod.metadata.name = "spark-driver"
        running_pod.metadata.labels = {"try_number": "1"}
        running_pod.status.phase = "Running"

        # Terminating pod should not be selected.
        terminating_pod = mock.MagicMock()
        terminating_pod.metadata.creation_timestamp = timezone.datetime(2025, 1, 1, tzinfo=timezone.utc)
        terminating_pod.metadata.deletion_timestamp = timezone.datetime(2025, 1, 2, tzinfo=timezone.utc)
        terminating_pod.metadata.name = "spark-driver"
        terminating_pod.metadata.labels = {"try_number": "1"}
        terminating_pod.status.phase = "Running"

        mock_get_kube_client.list_namespaced_pod.return_value.items = [
            terminating_pod,
            running_pod,
            succeeded_pod,
        ]

        returned_pod = op.find_spark_job(context)

        assert returned_pod is succeeded_pod

    def test_find_spark_job_picks_latest_pod(
        self,
        mock_is_in_cluster,
        mock_parent_execute,
        mock_create_namespaced_crd,
        mock_get_namespaced_custom_object_status,
        mock_cleanup,
        mock_create_job_name,
        mock_get_kube_client,
        mock_create_pod,
        mock_await_pod_completion,
        mock_fetch_requested_container_logs,
        data_file,
    ):
        """
        Verifies that find_spark_job selects the most recently created Spark driver pod
        when multiple candidate driver pods are present and status does not disambiguate.
        """

        task_name = "test_find_spark_job_picks_latest_pod"
        job_spec = yaml.safe_load(data_file("spark/application_template.yaml").read_text())

        mock_create_job_name.return_value = task_name
        op = SparkKubernetesOperator(
            template_spec=job_spec,
            kubernetes_conn_id="kubernetes_default_kube_config",