Repository: apache/dubbo
File: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/ServerStreamServerCallListener.java (Java)

Code before:
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.dubbo.rpc.protocol.tri.h12;

import org.apache.dubbo.common.stream.StreamObserver;
import org.apache.dubbo.remoting.http12.exception.HttpStatusException;
import org.apache.dubbo.rpc.Invoker;
import org.apache.dubbo.rpc.RpcInvocation;

public class ServerStreamServerCallListener extends AbstractServerCallListener {

    public ServerStreamServerCallListener(
            RpcInvocation invocation, Invoker<?> invoker, StreamObserver<Object> responseObserver) {
        super(invocation, invoker, responseObserver);
    }

    @Override
    public void onReturn(Object value) {}

    @Override
    public void onMessage(Object message) {
        Class<?>[] params = invocation.getParameterTypes();
        if (params.length == 1) {
            if (params[0].isInstance(responseObserver)) {
                invocation.setArguments(new Object[] {responseObserver});
                return;
            }
        }
        if (message instanceof Object[]) {
            message = ((Object[]) message)[0];
        }
        invocation.setArguments(new Object[] {message, responseObserver});
    }

    @Override
    public void onCancel(long code) {
        responseObserver.onError(new HttpStatusException((int) code));
    }

    @Override
    public void onComplete() {
        invoke();
    }
}

Review comment (suggestion):
The override only handles HttpResult values and omits delegating to the default behavior for other return types, which will swallow non-HttpResult returns. Consider calling super.onReturn(value) when value is not an instance of HttpResult.

Code after:
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.dubbo.rpc.protocol.tri.h12;

import org.apache.dubbo.common.stream.StreamObserver;
import org.apache.dubbo.remoting.http12.HttpResult;
import org.apache.dubbo.remoting.http12.exception.HttpStatusException;
import org.apache.dubbo.rpc.Invoker;
import org.apache.dubbo.rpc.RpcInvocation;

public class ServerStreamServerCallListener extends AbstractServerCallListener {

    public ServerStreamServerCallListener(
            RpcInvocation invocation, Invoker<?> invoker, StreamObserver<Object> responseObserver) {
        super(invocation, invoker, responseObserver);
    }

    @Override
    public void onReturn(Object value) {
        if (value instanceof HttpResult) {
            responseObserver.onNext(value);
            responseObserver.onCompleted();
        }
    }

    @Override
    public void onMessage(Object message) {
        Class<?>[] params = invocation.getParameterTypes();
        if (params.length == 1) {
            if (params[0].isInstance(responseObserver)) {
                invocation.setArguments(new Object[] {responseObserver});
                return;
            }
        }
        if (message instanceof Object[]) {
            message = ((Object[]) message)[0];
        }
        invocation.setArguments(new Object[] {message, responseObserver});
    }

    @Override
    public void onCancel(long code) {
        responseObserver.onError(new HttpStatusException((int) code));
    }