Repository: apache/kafka
File: metadata/src/main/java/org/apache/kafka/metadata/publisher/DynamicTopicClusterQuotaPublisher.java (Java)

Code before:
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.kafka.metadata.publisher;

import org.apache.kafka.common.Cluster;
import org.apache.kafka.image.MetadataDelta;
import org.apache.kafka.image.MetadataImage;
import org.apache.kafka.image.loader.LoaderManifest;
import org.apache.kafka.image.publisher.MetadataPublisher;
import org.apache.kafka.metadata.MetadataCache;
import org.apache.kafka.server.fault.FaultHandler;

public class DynamicTopicClusterQuotaPublisher implements MetadataPublisher {
    private final String clusterId;
    private final int nodeId;
    private final FaultHandler faultHandler;
    private final String nodeType;
    private final QuotaManagersProvider quotaManagersProvider;

    public DynamicTopicClusterQuotaPublisher(
        String clusterId,
        int nodeId,
        FaultHandler faultHandler,
        String nodeType,
        QuotaManagersProvider quotaManagers
    ) {
        this.clusterId = clusterId;
        this.nodeId = nodeId;
        this.faultHandler = faultHandler;
        this.nodeType = nodeType;
        this.quotaManagersProvider = quotaManagers;
    }

    @Override
    public String name() {
        return "DynamicTopicClusterQuotaPublisher " + nodeType + " id=" + nodeId;
    }

    @Override
    public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) {
        try {
            quotaManagersProvider.clientQuotaCallbackPlugin().ifPresent(plugin -> {
                if (delta.topicsDelta() != null || delta.clusterDelta() != null) {
                    Cluster cluster = MetadataCache.toCluster(clusterId, newImage);
                    if (plugin.get().updateClusterMetadata(cluster)) {
                        quotaManagersProvider.fetch().updateQuotaMetricConfigs();
                        quotaManagersProvider.produce().updateQuotaMetricConfigs();
                        quotaManagersProvider.request().updateQuotaMetricConfigs();
                        quotaManagersProvider.controllerMutation().updateQuotaMetricConfigs();
                    }

Review comment (performance):
Could you consider de-coupling those components by using lambda function? for example:
```java
    public DynamicTopicClusterQuotaPublisher(
        String clusterId,
        int nodeId,
        FaultHandler faultHandler,
        String nodeType,
        Plugin<ClientQuotaCallback> clientQuotaCallbackPlugin,
        Runnable updateQuotaMetricConfigs
    ) {
        this.clusterId = clusterId;
        this.nodeId = nodeId;
        this.faultHandler = faultHandler;
        this.nodeType = nodeType;
        this.clientQuotaCallbackPlugin = clientQuotaCallbackPlugin;
        this.updateQuotaMetricConfigs = updateQuotaMetricConfigs;
    }

    @Override
    public String name() {
        return "DynamicTopicClusterQuotaPublisher " + nodeType + " id=" + nodeId;
    }

    @Override
    public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) {
        try {
            if (delta.topicsDelta() != null || delta.clusterDelta() != null) {
                Cluster cluster = MetadataCache.toCluster(clusterId, newImage);
                if (clientQuotaCallbackPlugin.get().updateClusterMetadata(cluster)) {
                    updateQuotaMetricConfigs.run();
                }
            }
        } catch (Exception e) {
            String deltaName = "MetadataDelta up to " + newImage.highestOffsetAndEpoch().offset();
            faultHandler.handleFault("Uncaught exception while publishing dynamic topic or cluster changes from " + deltaName, e);
        }
    }
```
1. we could create `DynamicTopicClusterQuotaPublisher` only if the `clientQuotaCallbackPlugin` is existent
2. we wrap all callbacks in a single runnable object to avoid move many classes into `server-common` module

@JimmyWang6 WDYT?

Code after:
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.kafka.metadata.publisher;

import org.apache.kafka.common.Cluster;
import org.apache.kafka.common.internals.Plugin;
import org.apache.kafka.image.MetadataDelta;
import org.apache.kafka.image.MetadataImage;
import org.apache.kafka.image.loader.LoaderManifest;
import org.apache.kafka.image.publisher.MetadataPublisher;
import org.apache.kafka.metadata.MetadataCache;
import org.apache.kafka.server.fault.FaultHandler;
import org.apache.kafka.server.quota.ClientQuotaCallback;

import java.util.Optional;

public class DynamicTopicClusterQuotaPublisher implements MetadataPublisher {
    private final String clusterId;
    private final int nodeId;
    private final FaultHandler faultHandler;
    private final String nodeType;
    private final Optional<Plugin<ClientQuotaCallback>> clientQuotaCallbackPlugin;
    private final QuotaConfigChangeListener quotaConfigChangeListener;

    public DynamicTopicClusterQuotaPublisher(
        String clusterId,
        int nodeId,
        FaultHandler faultHandler,
        String nodeType,
        Optional<Plugin<ClientQuotaCallback>> clientQuotaCallbackPlugin,
        QuotaConfigChangeListener quotaConfigChangeListener
    ) {
        this.clusterId = clusterId;
        this.nodeId = nodeId;
        this.faultHandler = faultHandler;
        this.nodeType = nodeType;
        this.clientQuotaCallbackPlugin = clientQuotaCallbackPlugin;
        this.quotaConfigChangeListener = quotaConfigChangeListener;
    }

    @Override
    public String name() {
        return "DynamicTopicClusterQuotaPublisher " + nodeType + " id=" + nodeId;
    }

    @Override
    public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) {
        try {
            clientQuotaCallbackPlugin.ifPresent(plugin -> {
                if (delta.topicsDelta() != null || delta.clusterDelta() != null) {