Repository: yt-dlp/yt-dlp
File: yt_dlp/extractor/adobepass.py (Python)

Code before:
                            'Content-Type': 'application/json',
                            'Accept': 'application/json',
                        })
                    self._download_webpage(
                        saml_response_json['SAMLRedirectUri'], video_id,
                        'Confirming Login', data=urlencode_postdata({
                            'SAMLResponse': saml_response_json['SAMLResponse'],
                            'RelayState': relay_state,
                        }), headers={
                            'Content-Type': 'application/x-www-form-urlencoded'
                        })
                elif mso_id == 'slingtv':
                    # sling authentication requires several steps
                    #
                    # firstbookend - The first redirect is to a bookend page, which
                    # is just an HTTP get that runs some JS to look at
                    # window history (?) and count how many times
                    # the browser has been on a page. To stop back buttons?
                    # After resubmitting, we are redirected to the login form
                    #
                    # after the login form, there is a meta-refresh (bypassing some JS)
                    # that redirects to another bookend page that once again
                    # looks at the browser window history... It seems to increment
                    # by two during the process, so do that here.
                    #
                    # after the last bookend, a manual form to finish the login

                    first_bookend_page, urlh = provider_redirect_page_res

                    # extract the form data from the first bookend and re-send via GET
                    hidden_data = self._hidden_inputs(first_bookend_page)
                    hidden_data['history'] = 1

                    provider_login_page_res = self._download_webpage_handle(
                        urlh.geturl(), video_id, 'Sending first bookend.', query=hidden_data)

                    # log in after being redirected
                    provider_redirect_post_login_res = post_form(provider_login_page_res, 'Logging in', {
                        mso_info.get('username_field', 'username'): username,
                        mso_info.get('password_field', 'password'): password,
                    })

                    provider_association_redirect, urlh = provider_redirect_post_login_res

                    # extract the redirect URL (executes with JS in the browser)
                    provider_refresh_redirect_url = extract_redirect_url(
                        provider_association_redirect, url=urlh.geturl())

                    # the redirected URL sends us to the final bookend page
                    last_bookend_page_res = self._download_webpage_handle(
                        provider_refresh_redirect_url, video_id,

Review comment (security):
```suggestion
                    # SlingTV  has a meta-refresh based authentication, but also
                    # looks at the tab history to count the number of times the
                    # browser has been on a page
```

Also, remove the other comments. Comments in general should explain "why" and the code self-documents the "what"

Code after:
                            'Content-Type': 'application/json',
                            'Accept': 'application/json',
                        })
                    self._download_webpage(
                        saml_response_json['SAMLRedirectUri'], video_id,
                        'Confirming Login', data=urlencode_postdata({
                            'SAMLResponse': saml_response_json['SAMLResponse'],
                            'RelayState': relay_state,
                        }), headers={
                            'Content-Type': 'application/x-www-form-urlencoded'
                        })
                elif mso_id == 'slingtv':
                    # SlingTV has a meta-refresh based authentication, but also
                    # looks at the tab history to count the number of times the
                    # browser has been on a page

                    first_bookend_page, urlh = provider_redirect_page_res

                    hidden_data = self._hidden_inputs(first_bookend_page)
                    hidden_data['history'] = 1

                    provider_login_page_res = self._download_webpage_handle(
                        urlh.geturl(), video_id, 'Sending first bookend.',
                        query=hidden_data)

                    provider_association_redirect, urlh = post_form(
                        provider_login_page_res, 'Logging in', {
                            mso_info['username_field']: username,
                            mso_info['password_field']: password
                        })

                    provider_refresh_redirect_url = extract_redirect_url(
                        provider_association_redirect, url=urlh.geturl())

                    last_bookend_page, urlh = self._download_webpage_handle(
                        provider_refresh_redirect_url, video_id,
                        'Downloading Auth Association Redirect Page')
                    hidden_data = self._hidden_inputs(last_bookend_page)
                    hidden_data['history'] = 3

                    mvpd_confirm_page_res = self._download_webpage_handle(
                        urlh.geturl(), video_id, 'Sending final bookend.',
                        query=hidden_data)

                    post_form(mvpd_confirm_page_res, 'Confirming Login')
                else:
                    # Some providers (e.g. DIRECTV NOW) have another meta refresh
                    # based redirect that should be followed.
                    provider_redirect_page, urlh = provider_redirect_page_res
                    provider_refresh_redirect_url = extract_redirect_url(
                        provider_redirect_page, url=urlh.geturl())