Repository: typst/typst
File: crates/typst-layout/src/math/accent.rs (Rust)

Code before:
    let cramped = style_cramped();
    let mut base = ctx.layout_into_fragment(elem.base(), styles.chain(&cramped))?;

    // Try replace a glyph with its dotless variant.
    if let MathFragment::Glyph(ref mut glyph) = &mut base {
        glyph.make_dotless_form(ctx)
    }

    // Preserve class to preserve automatic spacing.
    let base_class = base.class();
    let base_attach = base.accent_attach();

    let width = elem
        .size(styles)
        .unwrap_or(Rel::one())
        .at(scaled_font_size(ctx, styles))
        .relative_to(base.width());

    let Accent(c) = elem.accent();
    let mut glyph = GlyphFragment::new(ctx, styles, *c, elem.span());

    // Try replace accent glyph with flattened variant.
    let flattened_base_height = scaled!(ctx, styles, flattened_accent_base_height);
    if base.height() > flattened_base_height {
        glyph.make_flattened_accent_form(ctx)
    }

    // Forcing the accent to be at least as large as the base makes it too
    // wide in many case.
    let short_fall = ACCENT_SHORT_FALL.at(glyph.font_size);
    let variant = glyph.stretch_horizontal(ctx, width, short_fall);
    let accent = variant.frame;
    let accent_attach = variant.accent_attach;

    // Descent is negative because the accent's ink bottom is above the
    // baseline. Therefore, the default gap is the accent's negated descent
    // minus the accent base height. Only if the base is very small, we need
    // a larger gap so that the accent doesn't move too low.
    let accent_base_height = scaled!(ctx, styles, accent_base_height);
    let gap = -accent.descent() - base.height().min(accent_base_height);
    let size = Size::new(base.width(), accent.height() + gap + base.height());
    let accent_pos = Point::with_x(base_attach - accent_attach);
    let base_pos = Point::with_y(accent.height() + gap);
    let baseline = base_pos.y + base.ascent();
    let base_italics_correction = base.italics_correction();
    let base_text_like = base.is_text_like();

    let base_ascent = match &base {
        MathFragment::Frame(frame) => frame.base_ascent,
        _ => base.ascent(),
    };

Review comment (suggestion):
```suggestion
    // Try to replace accent glyph with flattened variant.
    let flattened_base_height = scaled!(ctx, styles, flattened_accent_base_height);
    if base.height() > flattened_base_height {
        glyph.make_flattened_accent_form(ctx);
    }
```

Code after:
    let cramped = style_cramped();
    let mut base = ctx.layout_into_fragment(elem.base(), styles.chain(&cramped))?;

    // Try to replace a glyph with its dotless variant.
    if let MathFragment::Glyph(glyph) = &mut base {
        glyph.make_dotless_form(ctx);
    }

    // Preserve class to preserve automatic spacing.
    let base_class = base.class();
    let base_attach = base.accent_attach();

    let width = elem
        .size(styles)
        .unwrap_or(Rel::one())
        .at(scaled_font_size(ctx, styles))
        .relative_to(base.width());

    let Accent(c) = elem.accent();
    let mut glyph = GlyphFragment::new(ctx, styles, *c, elem.span());

    // Try to replace accent glyph with flattened variant.
    let flattened_base_height = scaled!(ctx, styles, flattened_accent_base_height);
    if base.height() > flattened_base_height {
        glyph.make_flattened_accent_form(ctx);
    }

    // Forcing the accent to be at least as large as the base makes it too
    // wide in many case.
    let short_fall = ACCENT_SHORT_FALL.at(glyph.font_size);
    let variant = glyph.stretch_horizontal(ctx, width, short_fall);
    let accent = variant.frame;
    let accent_attach = variant.accent_attach;

    // Descent is negative because the accent's ink bottom is above the
    // baseline. Therefore, the default gap is the accent's negated descent
    // minus the accent base height. Only if the base is very small, we need
    // a larger gap so that the accent doesn't move too low.
    let accent_base_height = scaled!(ctx, styles, accent_base_height);
    let gap = -accent.descent() - base.height().min(accent_base_height);
    let size = Size::new(base.width(), accent.height() + gap + base.height());
    let accent_pos = Point::with_x(base_attach - accent_attach);
    let base_pos = Point::with_y(accent.height() + gap);
    let baseline = base_pos.y + base.ascent();
    let base_italics_correction = base.italics_correction();
    let base_text_like = base.is_text_like();

    let base_ascent = match &base {
        MathFragment::Frame(frame) => frame.base_ascent,
        _ => base.ascent(),
    };