Repository: sympy/sympy
File: sympy/logic/algorithms/z3_wrapper.py (Python)

Code before:

    for pred, enc in enc_cnf.encoding.items():
        if not is_supported_predicate(pred):
            continue

        symbol_table = {}
        for sym in pred.free_symbols:
            symbol_table[sym] = float

        # Add uninterpreted functions from predicate, specify their argument and return types as real numbers
        pred_ufs = find_uninterpreted_functions(pred)
        for name, arity in pred_ufs.items():
            if arity is None or arity == 0:
                symbol_table[Function(name)] = float
            elif arity == 1:
                symbol_table[Function(name)] = Callable[[float], float]
            elif arity == 2:
                symbol_table[Function(name)] = Callable[[float, float], float]
            else:
                symbol_table[Function(name)] = Callable[..., float]

        pred_str = smtlib_code(pred, auto_declare=False, auto_assert=False, known_functions=known_functions, symbol_table=symbol_table)

        clause = f"(implies d{enc} {pred_str})"
        assertion = f"(assert {clause})"
        assertions.append(assertion)

    declarations = "\n".join(declarations)
    assertions = "\n".join(assertions)
    s.from_string(declarations)
    s.from_string(assertions)

    return s


known_functions = {
            Add: '+',
            Mul: '*',

            Equality: '=',
            LessThan: '<=',
            GreaterThan: '>=',
            StrictLessThan: '<',
            StrictGreaterThan: '>',

            EqualityPredicate(): '=',
            LessThanPredicate(): '<=',
            GreaterThanPredicate(): '>=',
            StrictLessThanPredicate(): '<',
            StrictGreaterThanPredicate(): '>',


Review comment (suggestion):
You could do this in one line: `assertions.append(f"(assert (implies d{enc} {pred_str}))")`

Code after:
from sympy.printing.smtlib import smtlib_code
from sympy.assumptions.assume import AppliedPredicate
from sympy.assumptions.cnf import EncodedCNF
from sympy.assumptions.ask import Q

from sympy.core import Add, Mul
from sympy.core.relational import Equality, LessThan, GreaterThan, StrictLessThan, StrictGreaterThan
from sympy.core.function import AppliedUndef
from sympy.functions.elementary.complexes import Abs
from sympy.functions.elementary.exponential import Pow
from sympy.functions.elementary.miscellaneous import Min, Max
from sympy.logic.boolalg import And, Or, Xor, Implies
from sympy.logic.boolalg import Not, ITE
from sympy.assumptions.relation.equality import StrictGreaterThanPredicate, StrictLessThanPredicate, GreaterThanPredicate, LessThanPredicate, EqualityPredicate
from sympy.external import import_module
from typing import Callable

supported_predicates = {
    Q.gt, Q.lt, Q.ge, Q.le, Q.ne, Q.eq, Q.positive, Q.negative,
    Q.extended_negative, Q.extended_positive, Q.zero, Q.nonzero,
    Q.nonnegative, Q.nonpositive, Q.extended_nonzero,
    Q.extended_nonnegative, Q.extended_nonpositive
}


def z3_satisfiable(expr, all_models=False):
    """
    Check satisfiability of a Boolean expression using the Z3 theorem prover.
    """
    if not isinstance(expr, EncodedCNF):
        exprs = EncodedCNF()
        exprs.add_prop(expr)
        expr = exprs

    z3 = import_module("z3")
    if z3 is None:
        raise ImportError("z3 is not installed")

    s = encoded_cnf_to_z3_solver(expr, z3)

    res = str(s.check())
    if res == "unsat":
        return False
    elif res == "sat":
        return z3_model_to_sympy_model(s.model(), expr)
    else:
        return None


def z3_model_to_sympy_model(z3_model, enc_cnf):
    rev_enc = {value: key for key, value in enc_cnf.encoding.items()}
    result = {}
    for var in z3_model:
        var_name = var.name()
        # Only process variables that start with 'd' followed by digits
        if var_name.startswith('d') and var_name[1:].isdigit():
            var_id = int(var_name[1:])
            if var_id in rev_enc:
                result[rev_enc[var_id]] = bool(z3_model[var])
    return result


def clause_to_assertion(clause):
    """Converts a single CNF clause to SMT-LIB assertion format."""
    clause_strings = [f"d{abs(lit)}" if lit > 0 else f"(not d{abs(lit)})" for lit in clause]
    return "(assert (or " + " ".join(clause_strings) + "))"


def encoded_cnf_to_z3_solver(enc_cnf, z3):
    s = z3.Solver()

    declarations = [f"(declare-const d{var} Bool)" for var in enc_cnf.variables]
    assertions = [clause_to_assertion(clause) for clause in enc_cnf.data]

    uninterpreted_functions_to_arity = {}
    for pred, enc in enc_cnf.encoding.items():
        uninterpreted_functions_to_arity.update({uf.func : len(uf.args) for uf in pred.atoms(AppliedUndef)})

    # symbol_table must be provided for smtlib_code, even though
    # it's unused when auto_declare is set to False
    symbol_table = dict.fromkeys(uninterpreted_functions_to_arity,Callable[..., float] )

    symbols = set()
    for pred, enc in enc_cnf.encoding.items():
        if not isinstance(pred, AppliedPredicate):
            continue
        if pred.function not in supported_predicates:
            continue

        pred_str = smtlib_code(pred, auto_declare=False, auto_assert=False, known_functions=known_functions,
                               symbol_table=symbol_table)

        symbols |= pred.free_symbols
        pred = pred_str
        assertion = f"(assert  (implies d{enc} {pred}))"
        assertions.append(assertion)

    for sym in symbols:
        declarations.append(f"(declare-const {sym} Real)")

    for f, arity in uninterpreted_functions_to_arity.items():
        # Rather than defining new types for the domain and range
        # we assume they are real to avoid unnecesary complexity.
        arg_types = " ".join(["Real"] * arity)
        declarations.append(f"(declare-fun {f} ({arg_types}) Real)")

    declarations = "\n".join(declarations)
    assertions = "\n".join(assertions)
    s.from_string(declarations)
    s.from_string(assertions)

    return s


known_functions = {
            Add: '+',
            Mul: '*',

            Equality: '=',
            LessThan: '<=',
            GreaterThan: '>=',
            StrictLessThan: '<',
            StrictGreaterThan: '>',

            EqualityPredicate(): '=',
            LessThanPredicate(): '<=',
            GreaterThanPredicate(): '>=',
            StrictLessThanPredicate(): '<',
            StrictGreaterThanPredicate(): '>',

            Abs: 'abs',
            Min: 'min',
            Max: 'max',
            Pow: '^',

            And: 'and',
            Or: 'or',
            Xor: 'xor',
            Not: 'not',
            ITE: 'ite',
            Implies: '=>',
        }