Repository: yt-dlp/yt-dlp
File: yt_dlp/extractor/funker530.py (Python)

Code before:
        }
    }]

    def _real_extract(self, url):
        display_id = self._match_id(url)
        webpage = self._download_webpage(url, display_id)
        rumble = RumbleEmbedIE(downloader=self._downloader)
        youtube = YoutubeIE(downloader=self._downloader)
        found_rumble_videos = rumble._extract_embed_urls(url, webpage)
        found_yt_videos = list(youtube._extract_embed_urls(url, webpage))  # TODO: is converting it to a list OK if there's only one video?
        if len(list(found_yt_videos)):
            embedded_video = youtube.extract(found_yt_videos[0])  # TODO: do I need to do all found videos or is [0] ok?
        elif len(found_rumble_videos):
            embedded_video = rumble.extract(found_rumble_videos[0])  # TODO: see above
            desc_regex = re.compile(r'(?s)<div class="row video-desc-paragraph">.*?<p>(.*?)(About the Author|<\/div>\n?<\/div>\n?<\/div>)')
            # _html_search_regex is not cleaning <style> tags so we'll do it ourselves.
            # description = self._html_search_regex(desc_regex, webpage, 'description', fatal=False)
            description = re.search(desc_regex, webpage).group(1)
            if description:
                description = clean_html(re.sub(r'<style>(.|\s)*?<\/style>', '', description))

            embedded_video['description'] = description
        else:
            # TODO: is this correct if nothing is found?
            return
        return embedded_video


Review comment (security):
If we're going to return a url result, then we want `'_type': 'url_transparent'` in the return so that we're not extracting the description for no reason.

We can use some `utils` like `get_element_by_class` and `strip_or_none` to reduce the regex load.
And use `_search_regex` with `default=None` to make it non-fatal
```suggestion

        return {
            **info,
            '_type': 'url_transparent',
            'description': strip_or_none(self._search_regex(
                r'(?s)(.+)About the Author', clean_html(get_element_by_class('video-desc-paragraph', webpage)),
                'description', default=None))
        }
```

Code after:
            'uploader': 'Civ Div',
            'categories': ['People & Blogs'],
            'title': 'My “Friends” joined the Russians.',
            'availability': 'public',
            'upload_date': '20230608',
            'playable_in_embed': True,
            'heatmap': 'count:100',
        }
    }]

    def _real_extract(self, url):
        display_id = self._match_id(url)
        webpage = self._download_webpage(url, display_id)
        rumble_url = list(RumbleEmbedIE._extract_embed_urls(url, webpage))
        if rumble_url:
            info = {'url': rumble_url[0], 'ie_key': RumbleEmbedIE.ie_key()}
        else:
            youtube_url = list(YoutubeIE._extract_embed_urls(url, webpage))
            if youtube_url:
                info = {'url': youtube_url[0], 'ie_key': YoutubeIE.ie_key()}
        if not info:
            raise ExtractorError('No videos found on webpage', expected=True)

        return {
            **info,
            '_type': 'url_transparent',
            'description': strip_or_none(self._search_regex(
                r'(?s)(.+)About the Author', clean_html(get_element_by_class('video-desc-paragraph', webpage)),
                'description', default=None))
        }