Repository: matplotlib/matplotlib
File: lib/matplotlib/backends/backend_qt.py (Python)

Code before:
    def paint(self, painter, rect, mode, state):
        """Paint the icon at the requested size and state."""
        pixmap = self.pixmap(rect.size(), mode, state)
        if not pixmap.isNull():
            painter.drawPixmap(rect, pixmap)

    def pixmap(self, size, mode, state):
        """Generate a pixmap for the requested size, mode, and state."""
        if size.width() <= 0 or size.height() <= 0:
            return QtGui.QPixmap()

        # Get the current device pixel ratio
        dpr = (self.toolbar.devicePixelRatioF() or 1) if self.toolbar else 1

        # Try SVG first, then fall back to PNG
        svg_path = self.image_path.with_suffix('.svg')
        if svg_path.exists():
            return self._create_pixmap_from_svg(svg_path, size, dpr)
        else:
            large_path = self.image_path.with_name(self.image_path.stem + '_large.png')
            path = large_path if large_path.exists() else self.image_path
            scaled_size = QtCore.QSize(
                int(size.width() * dpr),
                int(size.height() * dpr)
            )
            return self._create_pixmap_from_png(path, scaled_size, dpr)

    def _create_pixmap_from_svg(self, svg_path, size, dpr):
        """Create a pixmap from SVG with proper scaling and dark mode support."""
        QSvgRenderer = getattr(QtSvg, "QSvgRenderer", None)
        if QSvgRenderer is None:
            return QtGui.QPixmap()

        svg_content = svg_path.read_bytes()

        if self._is_dark_mode():
            svg_content = svg_content.replace(b'fill:black;', b'fill:white;')
            svg_content = svg_content.replace(b'stroke:black;', b'stroke:white;')

        renderer = QSvgRenderer(QtCore.QByteArray(svg_content))
        if not renderer.isValid():
            return QtGui.QPixmap()

        scaled_size = QtCore.QSize(int(size.width() * dpr), int(size.height() * dpr))
        pixmap = QtGui.QPixmap(scaled_size)
        pixmap.setDevicePixelRatio(dpr)
        pixmap.fill(QtCore.Qt.GlobalColor.transparent)

        painter = QtGui.QPainter()
        try:
            painter.begin(pixmap)

Review comment (suggestion):
Interpret `size` as logical display size for the scope of this function and hide the calculation of the physical size fully inside the `_create_pixmap_from_*` functions, using `self._devicePixelRatio()` in there.

This reduces here to
```suggestion
            return self._create_pixmap_from_svg(svg_path, size)
        else:
            return self._create_pixmap_from_png(self.image_path, size)
```
All the type-dependent implementation details (dpi handling, using a possibly available `_large` PNG image) are then hidden in the respective function.

Code after:
    def paint(self, painter, rect, mode, state):
        """Paint the icon at the requested size and state."""
        pixmap = self.pixmap(rect.size(), mode, state)
        if not pixmap.isNull():
            painter.drawPixmap(rect, pixmap)

    def pixmap(self, size, mode, state):
        """Generate a pixmap for the requested size, mode, and state."""
        if size.width() <= 0 or size.height() <= 0:
            return QtGui.QPixmap()

        # Try SVG first, then fall back to PNG
        svg_path = self.image_path.with_suffix('.svg')
        if svg_path.exists():
            pixmap = self._create_pixmap_from_svg(svg_path, size)
            if not pixmap.isNull():
                return pixmap
        return self._create_pixmap_from_png(self.image_path, size)

    def _devicePixelRatio(self):
        """Return the current device pixel ratio for the toolbar, defaulting to 1."""
        return (self.toolbar.devicePixelRatioF() or 1) if self.toolbar else 1

    def _create_pixmap_from_svg(self, svg_path, size):
        """Create a pixmap from SVG with proper scaling and dark mode support."""
        QSvgRenderer = getattr(QtSvg, "QSvgRenderer", None)
        if QSvgRenderer is None:
            return QtGui.QPixmap()

        svg_content = svg_path.read_bytes()

        if self._is_dark_mode():
            svg_content = svg_content.replace(b'fill:black;', b'fill:white;')
            svg_content = svg_content.replace(b'stroke:black;', b'stroke:white;')

        renderer = QSvgRenderer(QtCore.QByteArray(svg_content))
        if not renderer.isValid():
            return QtGui.QPixmap()

        dpr = self._devicePixelRatio()
        scaled_size = QtCore.QSize(int(size.width() * dpr), int(size.height() * dpr))
        pixmap = QtGui.QPixmap(scaled_size)
        pixmap.setDevicePixelRatio(dpr)
        pixmap.fill(QtCore.Qt.GlobalColor.transparent)

        painter = QtGui.QPainter()
        try:
            painter.begin(pixmap)
            renderer.render(painter, QtCore.QRectF(0, 0, size.width(), size.height()))
        finally:
            if painter.isActive():