Repository: yt-dlp/yt-dlp
File: yt_dlp/extractor/servus.py (Python)

Code before:
            'episode': episode,
            'episode_number': episode_number,
            'formats': formats,
            'subtitles': subtitles,
        }

    def _get_description(self, video_id):
        info = self._download_json(
            f'https://backend.servustv.com/wp-json/rbmh/v2/media_asset/aa_id/{video_id}?fieldset=page',
            video_id, fatal=False)
        return traverse_obj(info, 'stv_long_description', 'stv_short_description')

    def _report_errors(self, video):
        if 'playabilityErrors' not in video:
            raise ExtractorError('No videoUrl, and also no information about errors')
        for error in video.get('playabilityErrors'):
            if error == 'FSK_BLOCKED':
                details = video['playabilityErrorDetails']['FSK_BLOCKED']
                if 'minEveningHour' in details:
                    raise ExtractorError(
                        f'Only playable from {details["minEveningHour"]}:00 to {details["maxMorningHour"]}:00',
                        expected=True)
            elif error == 'NOT_YET_AVAILABLE':
                raise ExtractorError('Only available after ' + video.get('currentSunrise'), expected=True)
            else:
                raise ExtractorError(f'Not playable: {error}')


Review comment (refactor):
I actually disagree with this for loop. Instead the logic should be check for if something is in a set. But I am not quite sure how to do it in python, because I am a stupid java developer (and I am used to static typing) 😛 

```suggestion
        playability_errors = video.get('playabilityErrors')

        if 'FSK_BLOCKED' in playability_errors:
            details = video['playabilityErrorDetails']['FSK_BLOCKED']
            if 'minEveningHour' in details:
                raise ExtractorError(
                    f'Only playable from {details["minEveningHour"]}:00 to {details["maxMorningHour"]}:00',
                    expected=True)

        if 'NOT_YET_AVAILABLE' in playability_errors:
            raise ExtractorError('Only available after ' + video.get('currentSunrise'), expected=True)

        raise ExtractorError(f'Not playable: {playability_errors}')
```



Code after:
        if not video.get('videoUrl'):
            self._report_errors(video)
        formats, subtitles = self._extract_m3u8_formats_and_subtitles(
            video['videoUrl'], video_id, 'mp4', m3u8_id='hls')

        season = video.get('season')
        season_number = int_or_none(self._search_regex(
            r'Season (\d+)', season or '', 'season number', default=None))
        episode = video.get('chapter')
        episode_number = int_or_none(self._search_regex(
            r'Episode (\d+)', episode or '', 'episode number', default=None))

        return {
            'id': video_id,
            'title': video.get('title'),
            'description': self._get_description(video_id) or video.get('description'),
            'thumbnail': video.get('poster'),
            'duration': float_or_none(video.get('duration')),
            'timestamp': unified_timestamp(video.get('currentSunrise')),
            'series': video.get('label'),
            'season': season,
            'season_number': season_number,
            'episode': episode,
            'episode_number': episode_number,
            'formats': formats,
            'subtitles': subtitles,
        }

    def _get_description(self, video_id):
        info = self._download_json(
            f'https://backend.servustv.com/wp-json/rbmh/v2/media_asset/aa_id/{video_id}?fieldset=page',
            video_id, fatal=False)

        return join_nonempty(*traverse_obj(info, (
            ('stv_short_description', 'stv_long_description'),
            {lambda x: unescapeHTML(x.replace('\n\n', '\n'))})), delim='\n\n')

    def _report_errors(self, video):
        playability_errors = traverse_obj(video, ('playabilityErrors', ...))
        if not playability_errors:
            raise ExtractorError('No videoUrl and no information about errors')

        elif 'FSK_BLOCKED' in playability_errors:
            details = traverse_obj(video, ('playabilityErrorDetails', 'FSK_BLOCKED'), expected_type=dict)
            message = format_field(''.join((
                format_field(details, 'minEveningHour', ' from %02d:00'),
                format_field(details, 'maxMorningHour', ' to %02d:00'),
                format_field(details, 'minAge', ' (Minimum age %d)'),
            )), None, 'Only available%s') or 'Blocked by FSK with unknown availability'

        elif 'NOT_YET_AVAILABLE' in playability_errors: