Repository: symfony/symfony
File: src/Symfony/Component/Form/EnumFormTypeGuesser.php (PHP)

Code before:

        return new TypeGuess(FormEnumType::class, ['class' => $propertyType->getName()], Guess::HIGH_CONFIDENCE);
    }

    public function guessRequired(string $class, string $property): ?ValueGuess
    {
        if (null === $propertyType = $this->getPropertyType($class, $property)) {
            return null;
        }

        return new ValueGuess(!$propertyType->allowsNull(), Guess::HIGH_CONFIDENCE);
    }

    public function guessMaxLength(string $class, string $property): ?ValueGuess
    {
        return null;
    }

    public function guessPattern(string $class, string $property): ?ValueGuess
    {
        return null;
    }

    private function getPropertyType(string $class, string $property): ?\ReflectionNamedType
    {
        if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) {
            return $this->cache[$class][$property];
        }

        if (!isset($this->cache[$class])) {
            $this->cache[$class] = [];
        }

        try {
            $classReflection = new \ReflectionClass($class);
            $propertyReflection = $classReflection->getProperty($property);
        } catch (\ReflectionException) {
            return $this->cache[$class][$property] = null;
        }

        if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) {
            return $this->cache[$class][$property] = null;
        }

        return $this->cache[$class][$property] = $propertyReflection->getType();
    }
}


Review comment (performance):
```suggestion
        if (isset($this->cache[$class][$property])) {
```

Code after:
        if (!($enum = $this->getPropertyType($class, $property))) {
            return null;
        }

        return new TypeGuess(EnumType::class, ['class' => ltrim($enum, '?')], Guess::HIGH_CONFIDENCE);
    }

    public function guessRequired(string $class, string $property): ?ValueGuess
    {
        if (!($enum = $this->getPropertyType($class, $property))) {
            return null;
        }

        return new ValueGuess('?' !== $enum[0], Guess::HIGH_CONFIDENCE);
    }

    public function guessMaxLength(string $class, string $property): ?ValueGuess
    {
        return null;
    }

    public function guessPattern(string $class, string $property): ?ValueGuess
    {
        return null;
    }

    private function getPropertyType(string $class, string $property): string|false
    {
        if (isset($this->cache[$class][$property])) {
            return $this->cache[$class][$property];
        }

        try {
            $propertyReflection = new \ReflectionProperty($class, $property);
        } catch (\ReflectionException) {
            return $this->cache[$class][$property] = false;
        }

        $type = $propertyReflection->getType();
        if (!$type instanceof \ReflectionNamedType || !enum_exists($type->getName())) {
            $enum = false;
        } else {
            $enum = $type->getName();
            if ($type->allowsNull()) {
                $enum = '?'.$enum;
            }
        }

        return $this->cache[$class][$property] = $enum;
    }
}