Repository: paritytech/substrate
File: frame/support/procedural/src/construct_runtime/mod.rs (Rust)

Code before:
	let names_without_system_reverse =
		names_without_system.clone().into_iter().rev().collect::<Vec<_>>();
	let names_reversed_with_system_first = std::iter::once(system_pallet)
		.chain(names_without_system_reverse.clone().into_iter())
		.collect::<Vec<_>>();

	quote!(
		#types

		/// All pallets included in the runtime as a nested tuple of types.
		#[deprecated(note = "The type definition has changed from representing all pallets \
			excluding system, in reversed order to become the representation of all pallets \
			including system pallet in regular order. For this reason it is encouraged to use \
			explicitly one of `AllPalletsWithSystem`, `AllPalletsWithoutSystem`, \
			`AllPalletsWithSystemReversed`, `AllPalletsWithoutSystemReversed`. \
			Note that the type `frame_executive::Executive` expects one of `AllPalletsWithSystem` \
			, `AllPalletsWithSystemReversed`, `AllPalletsReversedWithSystemFirst`. More details in \
			https://github.com/paritytech/substrate/pull/10043")]
		pub type AllPallets = AllPalletsWithSystem;

		/// All pallets included in the runtime as a nested tuple of types.
		pub type AllPalletsWithSystem = ( #(#names),* );

		/// All pallets included in the runtime as a nested tuple of types.
		/// Excludes the System pallet.
		pub type AllPalletsWithoutSystem = ( #(#names_without_system),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		/// Excludes the System pallet.
		pub type AllPalletsWithoutSystemReversed =( #(#names_without_system_reverse),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		pub type AllPalletsWithSystemReversed = ( #(#names_reversed),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		/// With the system pallet first.
		pub type AllPalletsReversedWithSystemFirst = ( #(#names_reversed_with_system_first),* );
	)
}

fn decl_pallet_runtime_setup(
	runtime: &Ident,
	pallet_declarations: &[Pallet],
	scrate: &TokenStream2,
) -> TokenStream2 {
	let names = pallet_declarations.iter().map(|d| &d.name).collect::<Vec<_>>();
	let name_strings = pallet_declarations.iter().map(|d| d.name.to_string());
	let module_names = pallet_declarations.iter().map(|d| d.path.module_name());
	let indices = pallet_declarations.iter().map(|pallet| pallet.index as usize);
	let pallet_structs = pallet_declarations
		.iter()

Review comment (suggestion):
```suggestion
		pub type AllPalletsWithoutSystem = ( #(#all_pallets_without_system),* );
```

Code after:
	let names_without_system_reverse =
		names_without_system.clone().into_iter().rev().collect::<Vec<_>>();
	let names_reversed_with_system_first = std::iter::once(system_pallet)
		.chain(names_without_system_reverse.clone().into_iter())
		.collect::<Vec<_>>();

	quote!(
		#types

		/// All pallets included in the runtime as a nested tuple of types.
		#[deprecated(note = "The type definition has changed from representing all pallets \
			excluding system, in reversed order to become the representation of all pallets \
			including system pallet in regular order. For this reason it is encouraged to use \
			explicitly one of `AllPalletsWithSystem`, `AllPalletsWithoutSystem`, \
			`AllPalletsWithSystemReversed`, `AllPalletsWithoutSystemReversed`. \
			Note that the type `frame_executive::Executive` expects one of `AllPalletsWithSystem` \
			, `AllPalletsWithSystemReversed`, `AllPalletsReversedWithSystemFirst`. More details in \
			https://github.com/paritytech/substrate/pull/10043")]
		pub type AllPallets = AllPalletsWithSystem;

		/// All pallets included in the runtime as a nested tuple of types.
		pub type AllPalletsWithSystem = ( #(#names),* );

		/// All pallets included in the runtime as a nested tuple of types.
		/// Excludes the System pallet.
		pub type AllPalletsWithoutSystem = ( #(#names_without_system),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		/// Excludes the System pallet.
		#[deprecated(note = "Using reverse pallet orders is deprecated. use only \
		`AllPalletWithSystem or AllPalletsWithoutSystem`")]
		pub type AllPalletsWithoutSystemReversed =( #(#names_without_system_reverse),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		#[deprecated(note = "Using reverse pallet orders is deprecated. use only \
		`AllPalletWithSystem or AllPalletsWithoutSystem`")]
		pub type AllPalletsWithSystemReversed = ( #(#names_reversed),* );

		/// All pallets included in the runtime as a nested tuple of types in reversed order.
		/// With the system pallet first.
		#[deprecated(note = "Using reverse pallet orders is deprecated. use only \
		`AllPalletWithSystem or AllPalletsWithoutSystem`")]
		pub type AllPalletsReversedWithSystemFirst = ( #(#names_reversed_with_system_first),* );
	)
}

fn decl_pallet_runtime_setup(
	runtime: &Ident,
	pallet_declarations: &[Pallet],
	scrate: &TokenStream2,
) -> TokenStream2 {