Repository: jerryscript-project/jerryscript
File: jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-helpers.c (C)

Code before:
#include "ecma-function-object.h"
#include "jcontext.h"

#define ECMA_BUILTINS_INTERNAL
#include "ecma-builtins-internal.h"

/**
 * Common implementation of the [[Construct]] call of TypedArrays.
 *
 * @return ecma value of the new TypedArray object
 *         Returned value must be freed with ecma_free_value
 */
ecma_value_t
ecma_typedarray_helper_dispatch_construct (const ecma_value_t *arguments_list_p, /**< arguments list */
                                           uint32_t arguments_list_len, /**< number of arguments */
                                           ecma_typedarray_type_t typedarray_id) /**< id of the typedarray */
{
  JERRY_ASSERT (arguments_list_len == 0 || arguments_list_p != NULL);
  ecma_builtin_id_t proto_id = ecma_typedarray_helper_get_prototype_id (typedarray_id);
  ecma_object_t *current_new_target_p = JERRY_CONTEXT (current_new_target);
  ecma_object_t *prototype_obj_p;

  if (current_new_target_p != NULL)
  {
    prototype_obj_p = ecma_op_get_prototype_from_constructor (current_new_target_p, proto_id);
    if (jcontext_has_pending_exception ())
    {
      return ECMA_VALUE_ERROR;
    }

    if (prototype_obj_p == NULL)
    {
      return ecma_raise_type_error (ECMA_ERR_MSG ("TypedArray constructor should have prototype"));
    }
  }
  else
  {
    prototype_obj_p = ecma_builtin_get (proto_id);
  }

  ecma_value_t val = ecma_op_create_typedarray (arguments_list_p,
                                                arguments_list_len,
                                                prototype_obj_p,
                                                ecma_typedarray_helper_get_shift_size (typedarray_id),
                                                typedarray_id);

  if (current_new_target_p != NULL)
  {
    ecma_deref_object (prototype_obj_p);
  }


Review comment (suggestion):
This if is unneccessary. If ecma_op_get_prototype_from_constructor return NULL it means there is already a raised exception on the context.

Code after:
#include "jcontext.h"

#define ECMA_BUILTINS_INTERNAL
#include "ecma-builtins-internal.h"

/**
 * Common implementation of the [[Construct]] call of TypedArrays.
 *
 * @return ecma value of the new TypedArray object
 *         Returned value must be freed with ecma_free_value
 */
ecma_value_t
ecma_typedarray_helper_dispatch_construct (const ecma_value_t *arguments_list_p, /**< arguments list */
                                           uint32_t arguments_list_len, /**< number of arguments */
                                           ecma_typedarray_type_t typedarray_id) /**< id of the typedarray */
{
  JERRY_ASSERT (arguments_list_len == 0 || arguments_list_p != NULL);
  ecma_builtin_id_t proto_id = ecma_typedarray_helper_get_prototype_id (typedarray_id);
  ecma_object_t *prototype_obj_p = NULL;
  ecma_object_t *current_new_target_p = JERRY_CONTEXT (current_new_target_p);

  if (current_new_target_p != NULL)
  {
    prototype_obj_p = ecma_op_get_prototype_from_constructor (current_new_target_p, proto_id);
    if (prototype_obj_p == NULL)
    {
      return ECMA_VALUE_ERROR;
    }
  }
  else
  {
    prototype_obj_p = ecma_builtin_get (proto_id);
  }

  ecma_value_t val = ecma_op_create_typedarray (arguments_list_p,
                                                arguments_list_len,
                                                prototype_obj_p,
                                                ecma_typedarray_helper_get_shift_size (typedarray_id),
                                                typedarray_id);

  if (current_new_target_p != NULL)
  {
    ecma_deref_object (prototype_obj_p);
  }

  return val;
} /* ecma_typedarray_helper_dispatch_construct */

#endif /* ENABLED (JERRY_BUILTIN_TYPEDARRAY) */