Repository: grpc/grpc-go
File: health/server_internal_test.go (Go)

Code before:
	if status != healthpb.HealthCheckResponse_SERVING {
		t.Fatalf("status for %s is %v, want %v", testService, status, healthpb.HealthCheckResponse_SERVING)
	}

	s.SetServingStatus(testService, healthpb.HealthCheckResponse_NOT_SERVING)
	status = s.statusMap[testService]
	if status != healthpb.HealthCheckResponse_NOT_SERVING {
		t.Fatalf("status for %s is %v, want %v", testService, status, healthpb.HealthCheckResponse_NOT_SERVING)
	}
}

// TestList verifies successful listing of all service health statuses.
func (s) TestList(t *testing.T) {
	// Setup
	s := NewServer()
	s.mu.Lock()
	// Remove the zero value
	delete(s.statusMap, "")
	// Fill out status map with information
	for i := 1; i <= 3; i++ {
		s.statusMap[fmt.Sprintf("%d", i)] = healthpb.HealthCheckResponse_SERVING
	}
	s.mu.Unlock()

	// Execution
	ctx := context.TODO()
	var in healthpb.HealthListRequest
	out, err := s.List(ctx, &in)

	// Assertions
	if err != nil {
		t.Fatalf("List should not have failed, got %s, len %d", err, len(s.statusMap))
	}
	if len(out.GetStatuses()) != len(s.statusMap) {
		t.Fatal("List should have return the same number of elements as the inner status map")
	}
	for key := range out.GetStatuses() {
		v, ok := s.statusMap[key]
		if !ok {
			t.Fatalf("List should have returned all resources, wanted %s, but it did not exist in the inner status map", key)
		}
		if v != healthpb.HealthCheckResponse_SERVING {
			t.Fatalf("%s returned the wrong status, wanted %d, got %d", key, healthpb.HealthCheckResponse_SERVING, v)
		}
	}
}

// TestListResourceExhausted verifies that the service status list returns an error when it exceeds
// maxServiceStatusListLength.
func (s) TestListResourceExhausted(t *testing.T) {
	// Setup

Review comment (suggestion):
Please cancelable context either `WithCancel` or `WIthTimout`

```
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
```

Code after:

	s.Resume()
	status = s.statusMap[testService]
	if status != healthpb.HealthCheckResponse_SERVING {
		t.Fatalf("status for %s is %v, want %v", testService, status, healthpb.HealthCheckResponse_SERVING)
	}

	s.SetServingStatus(testService, healthpb.HealthCheckResponse_NOT_SERVING)
	status = s.statusMap[testService]
	if status != healthpb.HealthCheckResponse_NOT_SERVING {
		t.Fatalf("status for %s is %v, want %v", testService, status, healthpb.HealthCheckResponse_NOT_SERVING)
	}
}

// TestList verifies that List() returns the health status of all the services if no. of services are within
// maxAllowedLimits.
func (s) TestList(t *testing.T) {
	s := NewServer()

	// Fill out status map with information
	const length = 3
	for i := 0; i < length; i++ {
		s.SetServingStatus(fmt.Sprintf("%d", i),
			healthpb.HealthCheckResponse_ServingStatus(i))
	}

	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
	defer cancel()
	var in healthpb.HealthListRequest
	got, err := s.List(ctx, &in)

	if err != nil {
		t.Fatalf("s.List(ctx, &in) returned err %v, want nil", err)
	}
	if len(got.GetStatuses()) != length+1 {
		t.Fatalf("len(out.GetStatuses()) = %d, want %d",
			len(got.GetStatuses()), length+1)
	}
	want := &healthpb.HealthListResponse{
		Statuses: map[string]*healthpb.HealthCheckResponse{
			"":  {Status: healthpb.HealthCheckResponse_SERVING},
			"0": {Status: healthpb.HealthCheckResponse_UNKNOWN},
			"1": {Status: healthpb.HealthCheckResponse_SERVING},
			"2": {Status: healthpb.HealthCheckResponse_NOT_SERVING},
		},
	}
	if diff := cmp.Diff(got, want, protocmp.Transform()); diff != "" {
		t.Fatalf("Health response did not match expectation.  Diff (-got, +want): %s", diff)
	}
}