Repository: godotengine/godot
File: editor/editor_settings_dialog.h (C/C++)

Code before:

	void _settings_changed();
	void _settings_property_edited(const String &p_name);
	void _settings_save();

	virtual void shortcut_input(const Ref<InputEvent> &p_event) override;
	void _notification(int p_what);
	void _update_icons();

	void _event_config_confirmed();

	void _create_shortcut_treeitem(TreeItem *p_parent, const String &p_shortcut_identifier, const String &p_display, Array &p_events, bool p_allow_revert, bool p_is_common, bool p_is_collapsed);
	Array _event_list_to_array_helper(const List<Ref<InputEvent>> &p_events);
	void _update_builtin_action(const String &p_name, const Array &p_events);
	void _update_shortcut_events(const String &p_path, const Array &p_events);

	Variant get_drag_data_fw(const Point2 &p_point, Control *p_from);
	bool can_drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) const;
	void drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from);

	void _tabs_tab_changed(int p_tab);
	void _focus_current_search_box();

	void _filter_shortcuts(const String &p_filter);
	void _filter_shortcuts_by_event(const Ref<InputEvent> &p_event);
	bool _should_display_shortcut(const String &p_name, const Array &p_events) const;

	void _update_shortcuts();
	void _shortcut_button_pressed(Object *p_item, int p_column, int p_idx, MouseButton p_button = MouseButton::LEFT);
	void _shortcut_cell_double_clicked();

	static void _undo_redo_callback(void *p_self, const String &p_name);

	Label *restart_label = nullptr;
	TextureRect *restart_icon = nullptr;
	PanelContainer *restart_container = nullptr;
	Button *restart_close_button = nullptr;

	void _editor_restart_request();
	void _editor_restart();
	void _editor_restart_close();

protected:
	static void _bind_methods();

public:
	void popup_edit_settings();

	EditorSettingsDialog();
	~EditorSettingsDialog();
};

Review comment (suggestion):
```suggestion
	String _get_shortcut_button_string(const String &p_shortcut_name);
```

Code after:

	void _settings_changed();
	void _settings_property_edited(const String &p_name);
	void _settings_save();

	virtual void shortcut_input(const Ref<InputEvent> &p_event) override;
	void _notification(int p_what);
	void _update_icons();

	void _event_config_confirmed();

	void _create_shortcut_treeitem(TreeItem *p_parent, const String &p_shortcut_identifier, const String &p_display, Array &p_events, bool p_allow_revert, bool p_is_common, bool p_is_collapsed);
	Array _event_list_to_array_helper(const List<Ref<InputEvent>> &p_events);
	void _update_builtin_action(const String &p_name, const Array &p_events);
	void _update_shortcut_events(const String &p_path, const Array &p_events);

	Variant get_drag_data_fw(const Point2 &p_point, Control *p_from);
	bool can_drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) const;
	void drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from);

	void _tabs_tab_changed(int p_tab);
	void _focus_current_search_box();

	void _update_dynamic_property_hints();
	PropertyInfo _create_mouse_shortcut_property_info(const String &p_property_name, const String &p_shortcut_1_name, const String &p_shortcut_2_name);
	String _get_shortcut_button_string(const String &p_shortcut_name);

	void _filter_shortcuts(const String &p_filter);
	void _filter_shortcuts_by_event(const Ref<InputEvent> &p_event);
	bool _should_display_shortcut(const String &p_name, const Array &p_events) const;

	void _update_shortcuts();
	void _shortcut_button_pressed(Object *p_item, int p_column, int p_idx, MouseButton p_button = MouseButton::LEFT);
	void _shortcut_cell_double_clicked();
	static void _set_shortcut_input(const String &p_name, Ref<InputEventKey> &p_event);

	static void _undo_redo_callback(void *p_self, const String &p_name);

	Label *restart_label = nullptr;
	TextureRect *restart_icon = nullptr;
	PanelContainer *restart_container = nullptr;
	Button *restart_close_button = nullptr;

	void _editor_restart_request();
	void _editor_restart();
	void _editor_restart_close();

protected:
	static void _bind_methods();

public: