Repository: apache/kafka
File: streams/src/main/java/org/apache/kafka/streams/state/DslKeyValueParams.java (Java)

Code before:
    @Deprecated
    public DslKeyValueParams(final String name, final boolean isTimestamped) {
        Objects.requireNonNull(name);
        this.name = name;
        this.isTimestamped = isTimestamped;
        this.dslStoreFormat = DslStoreFormat.TIMESTAMPED;
    }

    /**
     * @param name           the name of the store (cannot be {@code null})
     * @param dslStoreFormat the format of the state store, see ({@link DslStoreFormat}
     */
    public DslKeyValueParams(final String name, final DslStoreFormat dslStoreFormat) {
        Objects.requireNonNull(name);
        this.name = name;
        this.dslStoreFormat = dslStoreFormat;
        this.isTimestamped = true;
    }

    public String name() {
        return name;
    }

    @Deprecated
    public boolean isTimestamped() {
        return isTimestamped;
    }

    public DslStoreFormat dslStoreFormat() {
        return dslStoreFormat;
    }

    @Override
    public boolean equals(final Object o) {
        if (this == o) {
            return true;
        }
        if (o == null || getClass() != o.getClass()) {
            return false;
        }
        final DslKeyValueParams that = (DslKeyValueParams) o;
        return isTimestamped == that.isTimestamped
                && Objects.equals(dslStoreFormat, that.dslStoreFormat)
                && Objects.equals(name, that.name);
    }

    @Override
    public int hashCode() {
        return Objects.hash(name, isTimestamped, dslStoreFormat);
    }


Review comment (suggestion):
```suggestion
        return dslStoreFormat == DslStoreFormat.TIMESTAMPED;
```

Code after:
    @Deprecated
    public DslKeyValueParams(final String name, final boolean isTimestamped) {
        Objects.requireNonNull(name);
        this.name = name;
        this.isTimestamped = isTimestamped;
        // If isTimestamped is false and the user is still calling the old deprecated constructor, we should assume they mean plain.
        this.dslStoreFormat = isTimestamped ? DslStoreFormat.TIMESTAMPED : DslStoreFormat.PLAIN;
    }

    /**
     * @param name           the name of the store (cannot be {@code null})
     * @param dslStoreFormat the format of the state store, see ({@link DslStoreFormat}
     */
    public DslKeyValueParams(final String name, final DslStoreFormat dslStoreFormat) {
        this.name =  Objects.requireNonNull(name);
        this.dslStoreFormat = Objects.requireNonNull(dslStoreFormat);
        this.isTimestamped = dslStoreFormat == DslStoreFormat.TIMESTAMPED;
    }

    public String name() {
        return name;
    }

    /**
     * @deprecated Since 4.3. Use {@link #dslStoreFormat()} instead to check the store format.
     * @return {@code true} if the store format is {@link DslStoreFormat#TIMESTAMPED}, {@code false} otherwise
     */
    @Deprecated
    public boolean isTimestamped() {
        return dslStoreFormat == DslStoreFormat.TIMESTAMPED;
    }

    /**
     * Returns the store format for this key-value store.
     *
     * @return the {@link DslStoreFormat} specifying whether to use plain, timestamped, or headers-aware stores
     */
    public DslStoreFormat dslStoreFormat() {
        return dslStoreFormat;
    }

    @Override
    public boolean equals(final Object o) {
        if (this == o) {
            return true;
        }
        if (o == null || getClass() != o.getClass()) {
            return false;
        }
        final DslKeyValueParams that = (DslKeyValueParams) o;
        return isTimestamped == that.isTimestamped