Repository: oppia/oppia
File: assets/constants.ts (TypeScript)

Code before:
    {
      "language_code": "yo",
      "explanation": "For learners in Nigeria."
    }],

  "LIST_OF_DEFAULT_TAGS_FOR_BLOG_POST": [
    "News", "International", "Educators", "Learners", "Community",
    "Partnerships", "Volunteer", "Stories", "Languages", "New features",
    "New lessons", "Software development", "Content", "Teacher story"],

  "ALL_CATEGORIES": ["Algebra", "Algorithms", "Architecture", "Arithmetic",
    "Art", "Astronomy", "Biology", "Business", "Calculus", "Chemistry",
    "Combinatorics", "Computing", "Economics", "Education", "Engineering",
    "English", "Environment", "Finance", "Gaulish", "Geography", "Geometry", "Government",
    "Graph Theory", "History", "Languages", "Latin", "Law", "Logic",
    "Mathematics", "Medicine", "Music", "Philosophy", "Physics", "Poetry",
    "Probability", "Programming", "Puzzles", "Reading", "Science", "Spanish", "Sport",
    "Statistics", "Trigonometry", "Welcome"],
  "ACTIVITY_TYPE_EXPLORATION": "exploration",
  "ACTIVITY_TYPE_EXPLORATION_TRANSLATIONS": "exp_translations",
  "ACTIVITY_TYPE_COLLECTION": "collection",
  "ACTIVITY_TYPE_STORY": "story",
  "ACTIVITY_TYPE_SKILL": "skill",
  "ACTIVITY_TYPE_SUBTOPIC": "subtopic",
  "ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE_OLD": "subtopic_with_study_guide_old",
  "ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE_NEW": "subtopic_with_study_guide_new",
  "ACTIVITY_TYPE_LEARN_TOPIC": "learntopic",
  "ACTIVITY_TYPE_CLASSROOM": "classroom",
  "DISABLED_EXPLORATION_IDS": ["5"],
  "TESTING_CONSTANT": "test",
  "LIBRARY_TILE_WIDTH_PX": 208,
  "LIBRARY_MOBILE_TILE_WIDTH_PX": 350,
  "DASHBOARD_TYPE_CREATOR": "creator",
  "DASHBOARD_TYPE_LEARNER": "learner",
  "DASHBOARD_TYPE_CONTRIBUTOR": "contributor",
  "DEFAULT_COLOR": "#a33f40",
  "DEFAULT_THUMBNAIL_ICON": "Lightbulb",
  "DEFAULT_CATEGORY_ICON": "Lightbulb",

  "ACTION_ACCEPT_SUGGESTION": "accept",
  "ACTION_REJECT_SUGGESTION": "reject",

  "SKILL_STATUS_OPTIONS": {
    "ALL": "All",
    "ASSIGNED": "Assigned",
    "UNASSIGNED": "Unassigned"
  },
  "TOPIC_MINIMUM_QUESTIONS_TO_PRACTICE": 10,
  "TOPIC_SKILL_DASHBOARD_SORT_OPTIONS": {
    "IncreasingCreatedOn": "Newly Created",
    "DecreasingCreatedOn": "Oldest Created",

Review comment (suggestion):
'old' and 'new' are a bit confusing, and I actually misunderstood this the first time I reviewed it. Perhaps something like these might be clearer as to what's happening:
- `ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE_MIGRATION`
- `ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE`

This solves a few problems:
1. The long-term activity type is just 'with study guide' so we should use that, no need for 'new' here.
2. The 'old' version is really a migration pathway. We _could_ name this even more clearly, but it's probably not necessary here since it'll be specific to Android and can be removed once Android updates to using the new pathway.

That all being said, what's the thought behind introducing the migration pathway versus updating the existing subtopic type to perform the migration there (and allow us to remove the migration)? In fact, I would expect us to update the existing subtopic pathway to use the subtopic pages conditioned on the feature flag (or else fallback), that way when it's time to finalize the feature we can remove all old subtopic code but the Android frontend (i.e. the lesson download script) can remain unchanged, then migrate over to the new activity type one a best-effort basis.

Code after:
    {
      "language_code": "yo",
      "explanation": "For learners in Nigeria."
    }],

  "LIST_OF_DEFAULT_TAGS_FOR_BLOG_POST": [
    "News", "International", "Educators", "Learners", "Community",
    "Partnerships", "Volunteer", "Stories", "Languages", "New features",
    "New lessons", "Software development", "Content", "Teacher story"],

  "ALL_CATEGORIES": ["Algebra", "Algorithms", "Architecture", "Arithmetic",
    "Art", "Astronomy", "Biology", "Business", "Calculus", "Chemistry",
    "Combinatorics", "Computing", "Economics", "Education", "Engineering",
    "English", "Environment", "Finance", "Gaulish", "Geography", "Geometry", "Government",
    "Graph Theory", "History", "Languages", "Latin", "Law", "Logic",
    "Mathematics", "Medicine", "Music", "Philosophy", "Physics", "Poetry",
    "Probability", "Programming", "Puzzles", "Reading", "Science", "Spanish", "Sport",
    "Statistics", "Trigonometry", "Welcome"],
  "ACTIVITY_TYPE_EXPLORATION": "exploration",
  "ACTIVITY_TYPE_EXPLORATION_TRANSLATIONS": "exp_translations",
  "ACTIVITY_TYPE_COLLECTION": "collection",
  "ACTIVITY_TYPE_STORY": "story",
  "ACTIVITY_TYPE_SKILL": "skill",
  "ACTIVITY_TYPE_SUBTOPIC": "subtopic",
  "ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE_MIGRATION": "subtopic_with_study_guide_migration",
  "ACTIVITY_TYPE_SUBTOPIC_WITH_STUDY_GUIDE": "subtopic_with_study_guide",
  "ACTIVITY_TYPE_LEARN_TOPIC": "learntopic",
  "ACTIVITY_TYPE_CLASSROOM": "classroom",
  "DISABLED_EXPLORATION_IDS": ["5"],
  "TESTING_CONSTANT": "test",
  "LIBRARY_TILE_WIDTH_PX": 208,
  "LIBRARY_MOBILE_TILE_WIDTH_PX": 350,
  "DASHBOARD_TYPE_CREATOR": "creator",
  "DASHBOARD_TYPE_LEARNER": "learner",
  "DASHBOARD_TYPE_CONTRIBUTOR": "contributor",
  "DEFAULT_COLOR": "#a33f40",
  "DEFAULT_THUMBNAIL_ICON": "Lightbulb",
  "DEFAULT_CATEGORY_ICON": "Lightbulb",

  "ACTION_ACCEPT_SUGGESTION": "accept",
  "ACTION_REJECT_SUGGESTION": "reject",

  "SKILL_STATUS_OPTIONS": {
    "ALL": "All",
    "ASSIGNED": "Assigned",
    "UNASSIGNED": "Unassigned"
  },
  "TOPIC_MINIMUM_QUESTIONS_TO_PRACTICE": 10,
  "TOPIC_SKILL_DASHBOARD_SORT_OPTIONS": {
    "IncreasingCreatedOn": "Newly Created",
    "DecreasingCreatedOn": "Oldest Created",