Repository: carbon-language/carbon-lang
File: toolchain/check/node_stack.cpp (C++)

Code before:
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

#include "toolchain/check/node_stack.h"

#include "llvm/ADT/STLExtras.h"

namespace Carbon::Check {

auto NodeStack::PrintForStackDump(int indent, llvm::raw_ostream& output) const
    -> void {
  auto print_id = [&]<Id::Kind Kind>(Id id) {
    if constexpr (Kind == Id::Kind::None) {
      output << "no value";
    } else if constexpr (Kind == Id::Kind::Invalid) {
      CARBON_FATAL("Should not be in node stack");
    } else {
      output << id.As<Kind>();
    }
  };

  output.indent(indent);
  output << "NodeStack:\n";
  for (auto [i, entry] : llvm::enumerate(stack_)) {
    auto node_kind = parse_tree_->node_kind(entry.node_id);
    output.indent(indent + 2);
    output << i << ". " << node_kind << ": ";
    switch (node_kind) {
#define CARBON_PARSE_NODE_KIND(Kind)                                        \
  case Parse::NodeKind::Kind:                                               \
    print_id.operator()<NodeKindToIdKind(Parse::NodeKind::Kind)>(entry.id); \
    break;
#include "toolchain/parse/node_kind.def"
    }
    output << "\n";
  }
}

}  // namespace Carbon::Check


Review comment (suggestion):
FWIW `!!from_category != !!to_category` would check that only one exists in a single assertion, but then you don't have two descriptive errors, dunno if you'd prefer that.

Code after:
  output.indent(indent);
  output << "NodeStack:\n";
  for (auto [i, entry] : llvm::enumerate(stack_)) {
    auto node_kind = parse_tree_->node_kind(entry.node_id);
    output.indent(indent + 2);
    output << i << ". " << node_kind << ": ";
    switch (node_kind) {
#define CARBON_PARSE_NODE_KIND(Kind)                                        \
  case Parse::NodeKind::Kind:                                               \
    print_id.operator()<NodeKindToIdKind(Parse::NodeKind::Kind)>(entry.id); \
    break;
#include "toolchain/parse/node_kind.def"
    }
    output << "\n";
  }
}

// NOLINTNEXTLINE(readability-function-size)
auto NodeStack::CheckIdKindTable() -> void {
#define CARBON_PARSE_NODE_KIND(Name)                                     \
  {                                                                      \
    constexpr auto from_category =                                       \
        NodeCategoryToIdKind(Parse::Name::Kind.category(), true);        \
    constexpr auto from_kind =                                           \
        NodeKindToIdKindSpecialCases(Parse::Name::Kind);                 \
    static_assert(from_category || from_kind,                            \
                  "Id::Kind not specified for " #Name                    \
                  "; add to NodeStack::NodeKindToIdKindSpecialCases or " \
                  "specify a node category in typed_nodes.h");           \
    static_assert(!from_category || !from_kind,                          \
                  "Special case Id::Kind specified for " #Name           \
                  ", but node category has an Id::Kind; remove from "    \
                  "NodeStack::NodeKindToIdKindSpecialCases");            \
  }
#include "toolchain/parse/node_kind.def"
}

}  // namespace Carbon::Check