Repository: nuttyartist/notes
File: src/aboutwindow.cpp (C++)

Code before:
#include "aboutwindow.h"
#include "ui_aboutwindow.h"

#include <QDebug>

/**
 * Initializes the window components and configures the AboutWindow
 */
AboutWindow::AboutWindow(QWidget *parent) : QWidget(parent), m_ui(new Ui::AboutWindow)
{
    m_ui->setupUi(this);
    this->setWindowFlags(Qt::SplashScreen | Qt::WindowStaysOnTopHint);
    setWindowTitle(tr("About") + " " + qApp->applicationName());

    m_ui->aboutText->setText(
            "<p>Notes was founded by <a href='https://rubymamistvalove.com'>Ruby Mamistvalove</a>, "
            "to create an elegant yet powerful cross-platform and open-source note-taking "
            "app.</p><a href='https://github.com/nuttyartist/notes'>Source code on "
            "Github</a>.<br/><br/><strong>Acknowledgments</strong><br/>This project couldn't have "
            "come this far without the help of these amazing "
            "people:<br/><br/><strong>Programmers:</strong><br/>Alex Spataru<br/>Ali Diouri"
            "<br/>David Planella<br/>Diep Ngoc<br/>Guilherme "
            "Silva<br/>Thorbjørn Lindeijer<br/>Tuur Vanhoutte<br/>Waqar "
            "Ahmed<br/><br/><strong>Designers:</strong><br/>Kevin Doyle<br/><br/>And to the "
            "many of our beloved users who keep sending us feedback, you are an essential force in "
            "helping us improve, thank you!<br/><br/><strong>Notes makes use of the following "
            "third-party "
            "libraries:</strong><br/><br/>QMarkdownTextEdit<br/>QSimpleUpdater<br/>QAutostart<br/"
            ">QXT<br/><br/><strong>Notes makes use of the following open source "
            "fonts:</strong><br/><br/>Roboto<br/>Source Sans Pro<br/>Trykker<br/>Mate<br/>iA "
            "Writer Mono<br/>iA Writer Duo<br/>iA Writer Quattro<br/>");
    m_ui->aboutText->setTextColor(QColor(26, 26, 26));

#ifdef __APPLE__
    QFont fontToUse = QFont(QStringLiteral("SF Pro Text")).exactMatch()
            ? QStringLiteral("SF Pro Text")
            : QStringLiteral("Roboto");

Review comment (suggestion):
It seems to me that the `AboutWindow` should really derive from `QDialog` instead. I don't see the point of `Qt::WindowStaysOnTopHint`. `Qt::SplashScreen` (which is just the same as `ToolTip | Dialog`) seems a little out of place (on Xfce, this creates a window without frame that can't be closed).

Btw, while you're changing this anyway, please remove the superfluous `this->`. :-)

Code after:
#include "aboutwindow.h"
#include "ui_aboutwindow.h"

#include <QDebug>

/**
 * Initializes the window components and configures the AboutWindow
 */
AboutWindow::AboutWindow(QWidget *parent) : QDialog(parent), m_ui(new Ui::AboutWindow)
{
    m_ui->setupUi(this);
    setWindowTitle(tr("About") + " " + qApp->applicationName());

    m_ui->aboutText->setText(
            "<p>Notes was founded by <a href='https://rubymamistvalove.com'>Ruby Mamistvalove</a>, "
            "to create an elegant yet powerful cross-platform and open-source note-taking "
            "app.</p><a href='https://github.com/nuttyartist/notes'>Source code on "
            "Github</a>.<br/><br/><strong>Acknowledgments</strong><br/>This project couldn't have "
            "come this far without the help of these amazing "
            "people:<br/><br/><strong>Programmers:</strong><br/>Alex Spataru<br/>Ali Diouri"
            "<br/>David Planella<br/>Diep Ngoc<br/>Guilherme "
            "Silva<br/>Thorbjørn Lindeijer<br/>Tuur Vanhoutte<br/>Waqar "
            "Ahmed<br/><br/><strong>Designers:</strong><br/>Kevin Doyle<br/><br/>And to the "
            "many of our beloved users who keep sending us feedback, you are an essential force in "
            "helping us improve, thank you!<br/><br/><strong>Notes makes use of the following "
            "third-party "
            "libraries:</strong><br/><br/>QMarkdownTextEdit<br/>QSimpleUpdater<br/>QAutostart<br/"
            ">QXT<br/><br/><strong>Notes makes use of the following open source "
            "fonts:</strong><br/><br/>Roboto<br/>Source Sans Pro<br/>Trykker<br/>Mate<br/>iA "
            "Writer Mono<br/>iA Writer Duo<br/>iA Writer Quattro<br/>");
    m_ui->aboutText->setTextColor(QColor(26, 26, 26));

#ifdef __APPLE__
    QFont fontToUse = QFont(QStringLiteral("SF Pro Text")).exactMatch()
            ? QStringLiteral("SF Pro Text")
            : QStringLiteral("Roboto");
    m_ui->aboutText->setFont(fontToUse);