Repository: nuttyartist/notes
File: src/aboutwindow.cpp (C++)

Code before:
#include "aboutwindow.h"
#include "ui_aboutwindow.h"

#include <QDebug>

/**
 * Initializes the window components and configures the AboutWindow
 */
AboutWindow::AboutWindow(QWidget *parent) : QDialog(parent), m_ui(new Ui::AboutWindow)
{
    m_ui->setupUi(this);
    setWindowTitle(tr("About") + " " + qApp->applicationName());

    m_ui->aboutText->setText(
            "<strong>Version:</strong> " + qApp->applicationVersion()
            + "<p>Notes was founded by <a href='https://rubymamistvalove.com'>Ruby "
              "Mamistvalove</a>, "
              "to create an elegant yet powerful cross-platform and open-source note-taking "
              "app.</p><a href='https://github.com/nuttyartist/notes'>Source code on "
              "Github</a>.<br/><br/><strong>Acknowledgments</strong><br/>This project couldn't "
              "have "
              "come this far without the help of these amazing "
              "people:<br/><br/><strong>Programmers:</strong><br/>Alex Spataru<br/>Ali Diouri"
              "<br/>David Planella<br/>Diep Ngoc<br/>Guilherme "
              "Silva<br/>Thorbjørn Lindeijer<br/>Tuur Vanhoutte<br/>Waqar "
              "Ahmed<br/><br/><strong>Designers:</strong><br/>Kevin Doyle<br/><br/>And to the "
              "many of our beloved users who keep sending us feedback, you are an essential force "
              "in "
              "helping us improve, thank you!<br/><br/><strong>Notes makes use of the following "
              "third-party libraries:</strong><br/><br/>QMarkdownTextEdit<br/>"
#if defined(UPDATE_CHECKER)
              "QSimpleUpdater<br/>"
#endif
              "QAutostart<br/>QXT<br/><br/><strong>Notes makes use of the following open source "
              "fonts:</strong><br/><br/>Roboto<br/>Source Sans Pro<br/>Trykker<br/>Mate<br/>iA "
              "Writer Mono<br/>iA Writer Duo<br/>iA Writer "
              "Quattro<br/><br/><strong>Qt version:</strong> "
            + qVersion() + " (built with " + QT_VERSION_STR + ")");
    m_ui->aboutText->setTextColor(QColor(26, 26, 26));


Review comment (suggestion):
I would suggest to write `QCoreApplication::applicationVersion()` (also for the name above), since these functions are static so I think it's a bit confusing to call them like member functions.

Code after:
#include "aboutwindow.h"
#include "ui_aboutwindow.h"

#include <QDebug>

/**
 * Initializes the window components and configures the AboutWindow
 */
AboutWindow::AboutWindow(QWidget *parent) : QDialog(parent), m_ui(new Ui::AboutWindow)
{
    m_ui->setupUi(this);
    setWindowTitle(tr("About") + " " + QCoreApplication::applicationName());

    m_ui->aboutText->setText(
            "<strong>Version:</strong> " + QCoreApplication::applicationVersion()
            + "<p>Notes was founded by <a href='https://rubymamistvalove.com'>Ruby "
              "Mamistvalove</a>, "
              "to create an elegant yet powerful cross-platform and open-source note-taking "
              "app.</p><a href='https://github.com/nuttyartist/notes'>Source code on "
              "Github</a>.<br/><br/><strong>Acknowledgments</strong><br/>This project couldn't "
              "have "
              "come this far without the help of these amazing "
              "people:<br/><br/><strong>Programmers:</strong><br/>Alex Spataru<br/>Ali Diouri"
              "<br/>David Planella<br/>Diep Ngoc<br/>Guilherme "
              "Silva<br/>Thorbjørn Lindeijer<br/>Tuur Vanhoutte<br/>Waqar "
              "Ahmed<br/><br/><strong>Designers:</strong><br/>Kevin Doyle<br/><br/>And to the "
              "many of our beloved users who keep sending us feedback, you are an essential force "
              "in "
              "helping us improve, thank you!<br/><br/><strong>Notes makes use of the following "
              "third-party libraries:</strong><br/><br/>QMarkdownTextEdit<br/>"
#if defined(UPDATE_CHECKER)
              "QSimpleUpdater<br/>"
#endif
              "QAutostart<br/>QXT<br/><br/><strong>Notes makes use of the following open source "
              "fonts:</strong><br/><br/>Roboto<br/>Source Sans Pro<br/>Trykker<br/>Mate<br/>iA "
              "Writer Mono<br/>iA Writer Duo<br/>iA Writer "
              "Quattro<br/><br/><strong>Qt version:</strong> "
            + qVersion() + " (built with " + QT_VERSION_STR + ")");
    m_ui->aboutText->setTextColor(QColor(26, 26, 26));