renwei2024/nemo-github-issues huggingface dataset:
Change default beam size
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

Fix default beam size of model config

**Collection**: [ASR]

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
Performance data mistakes in LLAMA inference
State: closed | Pull request: no
Labels: name: bug

name: stale

[Inference Performance of LLAMA-2 posted by Nvidia 1](https://docs.nvidia.com/nemo-framework/user-guide/latest/performance/llama.html)

According to the link above, the inference lantecy of LLAMA-2-13B with A100 80GB SXM4 at batch size=1 and tp=1, is less than latency of LLAMA-2-7B under the same condition.

How can we get this performance data? It’s unbelievable and ridiculous.

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been inactive for 7 days since being marked as stale.
Sequence Parallel for LoRA
State: closed | Pull request: yes
Labels: name: NLP

name: CI

# What does this PR do ?

Allow sequence parallel for lora training. Supports all linear modules as in #7988

**Collection**: NLP

# Changelog 
- Set sequence_parallel flags to False in LoRA layers to allow gathering output in LoRA `linear_in`
- For attention_qkv and mlp_fc1, do a manual all_gather (reduce_scatter during backward) along the sequence dimension before each lora module since the previous layer (layernorm) is affected by SP
- For attention_dense and mlp_fc2, do a manually scatter (gather during backward) along the sequence dimension after each lora module since the next layer (layernorm) is affected by SP

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # 7988


jenkins

jenkins

jenkins

jenkins

Known issue: `model.ub_tp_comm_overlap=True` is not supported for LoRA + SP

jenkins
adding jenkins test for speech_to_text_aed model
State: closed | Pull request: yes
Labels: name: ASR

name: CI

…_to_text_aed model

# What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

jenkins

jenkins
Add change_vocabulary and save_tokenizers() support to Multitask ASR models
State: closed | Pull request: yes
Labels: name: cherry-pick

name: ASR

# What does this PR do ?

Adds support to change vocabulary of multi task models. 
Adds support to save the tokenizer directory of all ASR models that implement `ASRBPEMixin`.

**Collection**: [ASR]

# Changelog 
- Adds utility method `save_tokenizers()` that extracts all the internal tokenizers of a model into the specified directory.
- Adds support method to change tokenizers of a multi task model.

# Usage

```python
from nemo.collections.asr.models import EncDecMultiTaskModel
asr_model = EncDecMultiTaskModel.from_pretrained("xyz")

# Save tokenizers - this creates a new directory at pwd called `all_tokenizers`
# Then it populates it with all the tokenizer objects stored in the model.
asr_model.save_tokenizers('./all_tokenizers/') 

# Change model vocabulary
tokenizer_cfg = OmegaConf.create(asr_model.cfg.tokenizer)
with open_dict(tokenizer_cfg):
    tokenizer_cfg.pop('langs', None) # remove old `langs` part of config from aggregate tokenizer

    # create new langs config
    tokenizer_cfg.langs = OmegaConf.create(dict(
        spl_tokens=dict(
            dir='all_tokenizers/spl_tokens/',
            type='bpe',
        ),
        en=dict(
            dir='all_tokenizers/en/',
            type='bpe',
        ),
        de=dict(
            dir='all_tokenizers/de/',
            type='bpe',
        ),
    ))

# Change the Multi task models tokenizers and vocabulary
asr_model.change_vocabulary(tokenizer_cfg, new_tokenizer_type='agg')
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

jenkins

jenkins

jenkins

jenkins
R1.22.0 hiddnens fix
State: closed | Pull request: yes
Labels: name: stale

name: NLP

# What does this PR do ?

This PR fixes issues with using hiddens module at inference time.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

jenkins

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR was closed because it has been inactive for 7 days since being marked as stale.
Hidden module fixes
State: closed | Pull request: yes
Labels: name: cherry-pick

name: NLP

# What does this PR do ?

Fixing hiddens module support.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)
TTS SpeechLLM models
State: closed | Pull request: yes
Labels: name: TTS

name: stale

name: NLP

name: common

# What does this PR do ?

Adds TTS models based on megatron T5 and megatron GPT

**Collection**: tts, nlp

# Changelog 
- TODO

# Usage
```python
# TODO
```

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.


This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.
Canary refactor for Riva
State: closed | Pull request: yes
Labels: name: ASR

name: common

# What does this PR do ?
- Refactors Canary code for Riva training


**Collection**: [ASR]

# Changelog 
- Expands canary coverage for more languages. (Just keep list of iso and bcp tags updated in `language_code.py`
-  Introduces bleu metric for in-training monitoring of performance. This replaces the sacrebleu code in validation pass.
- Updates wer metric to be compatible with Multitask decoding
- ToDo: The WER and BLEU metrics can be combined in a single metric but involves moving all WER calls to dictionary outputs. Separate PR.
- ToDo: Have to expand BLEU metric to switch between tokenizers while decoding.  Separate PR.
- Edits Canary dataloader for multiple paired translations. Now paired text just needs text input to be a nested dict of `text: {lang1: {text:....spl_tokens:...}, lang2 {text:...spl_tokens....}...`. 
- Changes Canary tokenizer to create `spl_tokens` class by default. 
- General refactoring of multitask model. Validation and Test steps pass off to ASR model and are more consistent in design with CTC models. 
- Changed multitask_decoding in submodules to strip tokens by default. (Avoided extra flag in metrics logic)

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [Y ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ N] Did you write any new necessary tests?
- [ N] Did you add or update any necessary documentation? TODO.
- [ N] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ Y] New Feature
- [Y ] Bugfix
- [Y ] Documentation TODO




jenkins

jenkins

@pzelasko @krishnacpuvvada Revisited tokenizer and think we can meet both needs:

There's no reason for the tokenizer to enforce what is being done in the canary prompt format. So let's just generalize task token behavior. We can pass all task tokens through the build method, then search for only formatted prompted tokens in the instantiation phase. This allows the easy lookup while also allowing easy customization for novel setups.

Meanwhile, anything regarding canary prompts in of themselves can just be maged by the lhotse prompt setup y'all have going on. Come time to expand for more wild prompts, you can just edit that setup while the tokenizer can stay as is.




jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins
Reintroduce dictionaries for data prefixes in GPT
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins
Hidden module fixes
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?

Fixing hiddens module support.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)
Add Neva template 
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?

Add template for DPO model training in NeVA 

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins
Add change_vocabulary and save_tokenizers() support to Multitask ASR models
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

Adds support to change vocabulary of multi task models. 
Adds support to save the tokenizer directory of all ASR models that implement `ASRBPEMixin`.

**Collection**: [ASR]

# Changelog 
- Adds utility method `save_tokenizers()` that extracts all the internal tokenizers of a model into the specified directory.
- Adds support method to change tokenizers of a multi task model.

# Usage

```python
from nemo.collections.asr.models import EncDecMultiTaskModel
asr_model = EncDecMultiTaskModel.from_pretrained("xyz")

# Save tokenizers - this creates a new directory at pwd called `all_tokenizers`
# Then it populates it with all the tokenizer objects stored in the model.
asr_model.save_tokenizers('./all_tokenizers/') 

# Change model vocabulary
tokenizer_cfg = OmegaConf.create(asr_model.cfg.tokenizer)
with open_dict(tokenizer_cfg):
    tokenizer_cfg.pop('langs', None) # remove old `langs` part of config from aggregate tokenizer

    # create new langs config
    tokenizer_cfg.langs = OmegaConf.create(dict(
        spl_tokens=dict(
            dir='all_tokenizers/spl_tokens/',
            type='bpe',
        ),
        en=dict(
            dir='all_tokenizers/en/',
            type='bpe',
        ),
        de=dict(
            dir='all_tokenizers/de/',
            type='bpe',
        ),
    ))

# Change the Multi task models tokenizers and vocabulary
asr_model.change_vocabulary(tokenizer_cfg, new_tokenizer_type='agg')
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

jenkins
Add Finetuning tutorial with HF Datasets
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

Add Finetuning of Parakeet model with HF Datasets

**Collection**: ASR

# Changelog 
- Add tutorial

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins
Enable megatron core loggers for GPT pretraining
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?

Enables use of megatron timers in NeMo GPT pretraining and megatron_base based models.

Collection: collections/nlp/models/language_modeling

Usage
 model.enable_megatron_timers=True
 model.megatron_timer_kwargs.log_every_n_steps= 10
 model.megatron_timer_kwargs.log_mode=minmax
 model.megatron_timer_kwargs.barrier= False 
torchrun --nnodes=1 --nproc-per-node=8 \
    /gsw/code/NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py  \
    --config-path=/gsw/code/NeMo/examples/nlp/language_modeling/conf \
    --config-name=megatron_gpt_config \
    trainer.devices=8 \
    trainer.num_nodes=1 \
    model.enable_megatron_timers=True \
    ++model.megatron_timer_kwargs.log_option=max \

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

@ericharper @ashbhandare what do you think about if we move the mcore logger params to the exp manager section in config?

> @ericharper @ashbhandare what do you think about if we move the mcore logger params to the exp manager section in config?

It's kind of difficult to do now since we have models that don't use mcore outside of LLM and multimodal domains


jenkins

jenkins

jenkins
Akoumparouli/mistral bugfix
State: closed | Pull request: yes

# What does this PR do ?

Fixes conversion script for NeMo to HF for mistral-7B.
**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins
remove _target_ at model level in aed model config [ASR]
State: closed | Pull request: yes
Labels: name: cherry-pick

name: ASR

# What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)
remove _target_ at model level in aed model config [ASR]
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)
fixed typo in GPT training explanation
State: closed | Pull request: yes
Labels: name: stale

name: NLP

# What does this PR do ?

Fixed a small typo in the GPT model training documentation. 

**Collection**: docs

# Changelog 
- Fixed spelling mistake on line 38.  

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
  
**PR Type**:
- Documentation

## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 


This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

bla.

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR was closed because it has been inactive for 7 days since being marked as stale.
Update HF hub
State: closed | Pull request: yes

# What does this PR do ?

Update huggingface hub

**Collection**: [Core]

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation


jenkins
Remove asr webapp
State: closed | Pull request: yes
Labels: name: cherry-pick

# What does this PR do ?

Remove ASR Webapp

**Collection**: [ASR]

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
Remove asr webapp
State: closed | Pull request: yes

# What does this PR do ?

Remove ASR Webapp

**Collection**: [ASR]

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
Keep max_seqlen and cu_seqlens_argmin for later micro-batches when PP>1
State: closed | Pull request: yes
Labels: name: cherry-pick

name: NLP

# What does this PR do ?

Instead of popping max_seqlen and cu_seqlens_argmin from a batch, we just read the dict to preserve the data for later micro-batches when PP > 1.

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins
The loss of `MegatronGPTModel` is incorrect for `micro_batch_size` > 1
State: closed | Pull request: no
Labels: name: bug

name: stale

**Describe the bug**

The loss implemented [here](https://github.com/NVIDIA/NeMo/blob/13c1db4ffdaa3b2125ce6e66c93509a39d55b2cf/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py#L1169) is incorrect for `micro_batch_size` > 1 because it computes the average over all tokens in the micro-batch, instead of computing a per-sample loss then averaging it. This leads to inconsistent results when varying `micro_batch_size`.

**Steps/Code to reproduce bug**

Compare results with different values of `micro_batch_size` and notice they are very different.

**Expected behavior**

Varying `micro_batch_size` shouldn't affect results.

**Additional context**

I am creating this issue for visibility (in case someone else runs into the same problem), and will be submitting a PR to fix it.

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been inactive for 7 days since being marked as stale.
Converter script fixes for mixtral/mistral
State: closed | Pull request: yes
Labels: name: cherry-pick

name: NLP

# What does this PR do ?

Fixes mistral & mixtral conversion scripts(renamed variable `num_experts` to `num_moe_experts` in mixtral converter).

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

There is also an undefined variable `head_num` in this script https://github.com/NVIDIA/NeMo/blob/0bb9e66a6d29b28e8831d1d1dd8a30310173ce46/scripts/nlp_language_modeling/convert_nemo_mixtral_to_hf.py#L124.

jenkins

bumping, if everything looks ok can we merge? @ericharper @janekl @akoumpa
Add fastconformer model for decoder timestamp
State: closed | Pull request: yes
Labels: name: core

name: TTS

name: ASR

name: NLP

name: CI

name: common

# What does this PR do ?

Add fastconformer model for decoder timestamp.
- Fastconformer model shoud have stride in 0.08 secs
- You can use fastconformer model for diarization in offline_diar_with_asr_infer.py 

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to #2857


Let us run on our test samples and make sure the timestamps are working smoothly.
Thank you for uploading this PR.


@biscayan pls follow steps listed at https://github.com/NVIDIA/NeMo/pull/8341/checks?check_run_id=21297714430 to sign off your commit
Huvu/mcore retro
State: closed | Pull request: yes
Labels: name: TTS

name: ASR

name: NLP

name: CI

# What does this PR do ?
Merging Mcore RETRO from huvu/mcore_retro to r1.23.0

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


Did you discuss with @yidong72 about deleting old retro stuff? Usually we'd want to deprecate at least for a release before deleting.

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

Jenkins

Jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins
Multimodal r1.23.0 bug fix 
State: closed | Pull request: yes
Labels: name: cherry-pick

name: CI

# What does this PR do ?

Multimodal r1.23.0 bug fix 

**Collection**: [Multimodal, CI]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

jenkins
Add Canary support for decoding with return_hypotheses=True
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

- Add Canary support for decoding with return_hypotheses=True and to return top-k hypotheses


**Collection**: [asr]


jenkins

Uh I'm adding support for this in my ASR transcribe refactor 

Actually let's keep this PR open, we'll get it rebased on the transcribe pr

jenkins

jenkins
Add support for Qwen
State: closed | Pull request: no
Labels: name: stale

Qwen 1.5 was released today and it is the best open LLM, adding support for it would be very helpful.

Blog: https://qwenlm.github.io/blog/qwen1.5/
HF: https://huggingface.co/collections/Qwen/qwen15-65c0a2f577b1ecb76d786524


This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been inactive for 7 days since being marked as stale.

+1
Fixing mcore bert for TP, PP and SP
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?
Adds bug fixes to support TP, PP =and SP
Add a one line overview of what this PR aims to accomplish.

**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins

jenkins
Fixing bug in tutorials.
State: closed | Pull request: yes
Labels: name: ASR

# What does this PR do ?

- Fix WER bug in ASR_with_subword_tokenization tutorial

**Collection**: [ASR]

# Changelog 
- Added missing parameter to above tutorial



# Before your PR is "Ready for review"
**Pre checks**:
- [Y] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N] Did you write any new necessary tests?
- [N] Did you add or update any necessary documentation?
- [N] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [Y ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins
Keep max_seqlen and cu_seqlens_argmin for later micro-batches when PP>1
State: closed | Pull request: yes
Labels: name: NLP

# What does this PR do ?

Instead of popping max_seqlen and cu_seqlens_argmin from a batch, we just read the dict to preserve the data for later micro-batches when PP > 1.

# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


jenkins
add dependencies to the install snippet
State: closed | Pull request: yes
Labels: name: stale

name: ASR

Packages omegaconf and hydra-core are required and should be installed with the other dependencies.


This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR was closed because it has been inactive for 7 days since being marked as stale.