fix: properly use enhanced_count_thres and max_num_speakers in diariz…
State: closed | Pull request: yes
Labels: name: stale

name: ASR

…ation

# What does this PR do ?
Fixes diarization so that it properly uses enhanced_count_thres and max_num_speakers from the config.

**Collection**: [Note which collection this PR will affect]
ASR

# Changelog 
Bug fix to properly read configs

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X ] Did you write any new necessary tests?
- [ X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

Can someone help me remove the stale label from this PR?  

@titu1994  @redoctopus, @jbalam-nv @okuchaiev please review

<!-- pylint-output-strict-mode-false -->

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

---

Your code was analyzed with PyLint. The following annotations have been identified:

```
************* Module nemo.collections.asr.parts.utils.offline_clustering
nemo/collections/asr/parts/utils/offline_clustering.py:716:0: C0301: Line too long (156/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:716:0: C0301: Line too long (156/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1206:0: C0301: Line too long (158/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1215:0: C0301: Line too long (148/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1265:0: C0301: Line too long (154/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1349:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1350:0: C0301: Line too long (152/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1354:0: C0301: Line too long (158/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1360:0: C0301: Line too long (148/119) (line-too-long)
nemo/collections/asr/parts/utils/offline_clustering.py:1134:0: C0115: Missing class docstring (missing-class-docstring)
************* Module nemo.collections.asr.parts.utils.speaker_utils
nemo/collections/asr/parts/utils/speaker_utils.py:84:0: C0301: Line too long (138/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:87:0: C0301: Line too long (130/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:117:0: C0301: Line too long (131/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:250:0: C0301: Line too long (136/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:447:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:618:0: C0301: Line too long (131/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:890:0: C0301: Line too long (136/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:942:0: C0301: Line too long (145/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1294:0: C0301: Line too long (124/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1302:0: C0301: Line too long (124/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1324:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1325:0: C0301: Line too long (131/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1326:0: C0301: Line too long (127/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1333:0: C0301: Line too long (136/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1335:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1351:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1352:0: C0301: Line too long (132/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1353:0: C0301: Line too long (129/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1364:0: C0301: Line too long (129/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1367:0: C0301: Line too long (128/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1377:0: C0301: Line too long (126/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1434:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1463:0: C0301: Line too long (127/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:1467:0: C0301: Line too long (131/119) (line-too-long)
nemo/collections/asr/parts/utils/speaker_utils.py:32:0: W0611: Unused SpeakerClustering imported from nemo.collections.asr.parts.utils.offline_clustering (unused-import)

-----------------------------------
Your code has been rated at 9.66/10
```

---

Thank you for improving NeMo's documentation!

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@titu1994 @redoctopus, @jbalam-nv @okuchaiev please let me know if I am missing something here or doing something wrong.   Apologies if so - this is my first contribution.     I also opened issue for this here:    https://github.com/NVIDIA/NeMo/issues/11440 but no response.

Thank you.

@titu1994 @redoctopus, @jbalam-nv @okuchaiev please let me know if I am missing something here or doing something wrong. Apologies if so - this is my first contribution. I also opened issue for this here: https://github.com/NVIDIA/NeMo/issues/11440 but no response yet.

Thank you.

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR was closed because it has been inactive for 7 days since being marked as stale.

How can I reopen this PR?