NeMo-UX: make llm api ingest nn module
State: closed | Pull request: yes
Labels: name: stale

# What does this PR do ?

The goal of this PR is to extend the type of `model` argument of `llm.api` from `LightningModule` to `Union[LightningModule, nn.Module, fdl.Config]`, therefore allowing users to pass either instantiated models (nn.Module) or a config to be instantiated. 

This change enables further flexibility on the user side and allows the NeMo framework to avoid duplicating code by not having to wrap users' modules in LightningModule (and instead do so internally).



**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


<!-- pylint-output-strict-mode-true -->

beep boop 🤖: 🚨 The following files must be fixed before merge!

---

Your code was analyzed with PyLint. The following annotations have been identified:

```
************* Module nemo.collections.llm.lit_wrapper
nemo/collections/llm/lit_wrapper.py:24:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/lit_wrapper.py:32:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/lit_wrapper.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/lit_wrapper.py:42:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/lit_wrapper.py:53:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/lit_wrapper.py:62:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 8.50/10
```

---

Thank you for improving NeMo's documentation!

<!-- pylint-output-strict-mode-false -->

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

---

Your code was analyzed with PyLint. The following annotations have been identified:

```
************* Module hf
examples/llm/peft/hf.py:28:0: C0301: Line too long (184/119) (line-too-long)
examples/llm/peft/hf.py:80:0: C0301: Line too long (162/119) (line-too-long)
examples/llm/peft/hf.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.llm.api
nemo/collections/llm/api.py:600:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.llm.gpt.data.hf_dataset
nemo/collections/llm/gpt/data/hf_dataset.py:21:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:51:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:83:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:93:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.67/10
```

---

Thank you for improving NeMo's documentation!

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

This PR was closed because it has been inactive for 7 days since being marked as stale.