fix: regular torch optims (e.g., sgd) no longer error with closure spec
State: closed | Pull request: yes
Labels: name: core

name: Run CICD

# What does this PR do ?

Mcore distributed optimizers now require us to specify the `closure` kwarg. Example:
https://github.com/NVIDIA/NeMo-Aligner/blob/ac97fe334eff9ad3177edf274c011e74d14a4d60/nemo_aligner/algorithms/dpo.py#L202

This means that if the application also specifies `None` for `closure`, we'll error b/c closure is passed twice. This change pops off closure and ensures it is `None` to be compliant.


**Collection**: [Note which collection this PR will affect]

# Changelog 
- Add specific line by line info of high level changes in this PR.

# Usage
* You can potentially add a usage example below

```python
# Add a code snippet demonstrating how to use this 
```

# GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  - [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
  
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.


## Who can review?

Anyone in the community is free to review the PR once the checks have passed. 
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.

# Additional Information
* Related to # (issue)


This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

<!-- pylint-output-strict-mode-false -->

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

---

Your code was analyzed with PyLint. The following annotations have been identified:

```
************* Module nemo.core.optim.optimizer_with_main_params
nemo/core/optim/optimizer_with_main_params.py:91:0: C0301: Line too long (140/119) (line-too-long)
nemo/core/optim/optimizer_with_main_params.py:96:0: C0301: Line too long (149/119) (line-too-long)
nemo/core/optim/optimizer_with_main_params.py:195:0: C0301: Line too long (140/119) (line-too-long)
nemo/core/optim/optimizer_with_main_params.py:200:0: C0301: Line too long (149/119) (line-too-long)
nemo/core/optim/optimizer_with_main_params.py:149:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:153:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:403:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:446:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:450:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:471:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:477:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:497:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:513:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:517:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/optim/optimizer_with_main_params.py:520:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.50/10
```

---

Thank you for improving NeMo's documentation!

[🤖]: Hi @terrykong 👋,

We wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12190011070) for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g