Update TTS Collection for 1.0
State: closed | Pull request: yes

 - Deprecates use of torch_stft and associated parameters: stft_conv,  stft_exact_pad for the FilterbankFeatures and AudioToMelSpectrogramPreprocessor classes
- stft_exact_pad has been replaced with exact_pad
- Update AudioToMelSpectrogramPreprocessor's calculation of seq_len
- Remove yaml anchors from TTS yamls in favour of Omegaconf/Hydra anchors
- Remove add_misc and load_audio from AudioTextDataset and child classes
- Update tts models to adhere to fmax=8000 for LJSpeech and all other associated hyper parameters
- Change GlowVocoder's denoise to use torch's stft and istft

This pull request **introduces 2 alerts** and **fixes 2** when merging b07c408dc655861e9fbfee59e04050c384b155ae into cd194c88d7581e684a5ad6a0d2031a6b68300969 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-693d8acbfaccfaceca6d6d47d3c4d90daddf0595)

**new alerts:**

* 2 for Unused import

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging d8c01c8e9d1f658331625ece3546ed378f437f65 into c51685e03f52d3428d19b7edccc1bbd0da5d8edb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-444fa37ca1051604057b75abe005d9d56912b647)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 3a743b27a22859df175db4cd5fe4081cbf7991b8 into c51685e03f52d3428d19b7edccc1bbd0da5d8edb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c31f6a43a14ad9264be6e8499ceba3e4bcb3ff8e)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

@titu1994 Can you take a look at the asr datalayer and feature preprocessor changes?

This pull request **fixes 2 alerts** when merging ba98c826cef0ba3474ac754616eb5994d5ebfb90 into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f388eb5a7bd2d246c9eedd416da4c8e4468952de)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **introduces 1 alert** and **fixes 2** when merging 15f23537a2f9d69dea4c0bd060dc0b6fb6d37d67 into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-84f03f38d93d8787c91791ba0164c3ec7ca234a2)

**new alerts:**

* 1 for Unnecessary pass

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 9cfc863397b2bf76b1ad052ff63897050746cabe into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-68b75ca060b278581e25fcaf74cd8cb507986d26)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging c1a21e52e25b204692e2e8cd7ce0f8563105c9ac into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-8ffa4f91de1621c29e7b0d0a3097cff7e5d6b28e)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 808f91b3a43a4a9efee94b9e43f0d0c5241d41ed into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2131f1b6061885f4d7304bba58cd30706fde73e1)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 47da2edc561674eebe9674c41c72ee363b33b981 into d79d5d3ed06d86d24b82214363755174313d6d9d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b86e4ec6b3afdcb630b644aff86991255154209d)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 38d7546e4462b458fbee19bb2056a99dc22c2ca1 into 16e0f1a4f486510ca4e50464d5bb5ee94cb766f2 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-3e0d4148e38fb84aec471195e240c7f5657bd959)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging c750b741b5fe64e99f0538991b74cae08e2b595b into 02dc1af77c3c1edca766c95c30985deea5a7ca58 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-775cb9cb1a1cc43796be4450d2deccc20441c8f9)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

This pull request **fixes 2 alerts** when merging 91596604d52f2fed3e8dba293709c07eeddf93ee into 02dc1af77c3c1edca766c95c30985deea5a7ca58 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2c08ecaaee888d774a24778d54e5b865214b2051)

**fixed alerts:**

* 2 for Mismatch in multiple assignment

@blisc I use misc as ability to match sample from dataloader and file name from manifest.

also TalkNet uses load_audio=False flag. 

I suggest to discuss before removing it.

> @blisc I use misc as ability to match sample from dataloader and file name from manifest.
> 
> also TalkNet uses load_audio=False flag.
> 
> I suggest to discuss before removing it.

Seeing as how only TalkNet seems to use it and TalkNet already has it's own datalayer at https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/asr/data/audio_to_text.py#L291. I will continue to remove these from the base class. Feel free to add such functionality to the derived class instead.

@blisc 

It is not a problem to implement it in derived class, but why do you necessary want to remove it from base class? Maybe will be another case for using load_audio=False.