Title: Fix check_library_imports
Author: lhoestq (MEMBER)
State: closed
Created: 2024-07-04T14:18:38Z

move it to after the `trust_remote_code` check

Note that it only affects local datasets that already exist on disk, not datasets loaded from HF directly

Comments:
The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_7026). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

<details>
<summary>Show benchmarks</summary>

PyArrow==8.0.0

<details>
<summary>Show updated benchmarks!</summary>

### Benchmark: benchmark_array_xd.json

| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_as_numpy after write_nested_sequence | read_batch_unformated after write_array2d | read_batch_unformated after write_flattened_sequence | read_batch_unformated after write_nested_sequence | read_col_formatted_as_numpy after write_array2d | read_col_formatted_as_numpy after write_flattened_sequence | read_col_formatted_as_numpy after write_nested_sequence | read_col_unformated after write_array2d | read_col_unformated after write_flattened_sequence | read_col_unformated after write_nested_sequence | read_formatted_as_numpy after write_array2d | read_formatted_as_numpy after write_flattened_sequence | read_formatted_as_numpy after write_nested_sequence | read_unformated after write_array2d | read_unformated after write_flattened_sequence | read_unformated after write_nested_sequence | write_array2d | write_flattened_sequence | write_nested_sequence |
|--------|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 0.005637 / 0.011353 (-0.005716) | 0.003967 / 0.011008 (-0.007041) | 0.064187 / 0.038508 (0.025679) | 0.031356 / 0.023109 (0.008246) | 0.239203 / 0.275898 (-0.036695) | 0.261033 / 0.323480 (-0.062447) | 0.003256 / 0.007986 (-0.004730) | 0.003416 / 0.004328 (-0.000913) | 0.049673 / 0.004250 (0.045423) | 0.047021 / 0.037052 (0.009969) | 0.252146 / 0.258489 (-0.006343) | 0.283663 / 0.293841 (-0.010178) | 0.030223 / 0.128546 (-0.098324) | 0.012342 / 0.075646 (-0.063304) | 0.213061 / 0.419271 (-0.206211) | 0.036867 / 0.043533 (-0.006665) | 0.242589 / 0.255139 (-0.012550) | 0.265584 / 0.283200 (-0.017616) | 0.019149 / 0.141683 (-0.122533) | 1.108909 / 1.452155 (-0.343246) | 1.148484 / 1.492716 (-0.344232) |

### Benchmark: benchmark_getitem\_100B.json

| metric | get_batch_of\_1024\_random_rows | get_batch_of\_1024\_rows | get_first_row | get_last_row |
|--------|---|---|---|---|
| new / old (diff) | 0.096815 / 0.018006 (0.078809) | 0.299633 / 0.000490 (0.299143) | 0.000212 / 0.000200 (0.000013) | 0.000043 / 0.000054 (-0.000011) |

### Benchmark: benchmark_indices_mapping.json

| metric | select | shard | shuffle | sort | train_test_split |
|--------|---|---|---|---|---|
| new / old (diff) | 0.018947 / 0.037411 (-0.018464) | 0.061640 / 0.014526 (0.047114) | 0.074621 / 0.176557 (-0.101935) | 0.120830 / 0.737135 (-0.616305) | 0.075472 / 0.296338 (-0.220866) |

### Benchmark: benchmark_iterating.json

| metric | read 5000 | read 50000 | read_batch 50000 10 | read_batch 50000 100 | read_batch 50000 1000 | read_formatted numpy 5000 | read_formatted pandas 5000 | read_formatted tensorflow 5000 | read_formatted torch 5000 | read_formatted_batch numpy 5000 10 | read_formatted_batch numpy 5000 1000 | shuffled read 5000 | shuffled read 50000 | shuffled read_batch 50000 10 | shuffled read_batch 50000 100 | shuffled read_batch 50000 1000 | shuffled read_formatted numpy 5000 | shuffled read_formatted_batch numpy 5000 10 | shuffled read_formatted_batch numpy 5000 1000 |
|--------|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 0.284626 / 0.215209 (0.069417) | 2.805299 / 2.077655 (0.727644) | 1.469879 / 1.504120 (-0.034241) | 1.355524 / 1.541195 (-0.185671) | 1.388246 / 1.468490 (-0.080244) | 0.726740 / 4.584777 (-3.858037) | 2.387461 / 3.745712 (-1.358251) | 2.834137 / 5.269862 (-2.435724) | 1.915750 / 4.565676 (-2.649927) | 0.079223 / 0.424275 (-0.345052) | 0.005489 / 0.007607 (-0.002118) | 0.335517 / 0.226044 (0.109473) | 3.299332 / 2.268929 (1.030403) | 1.817726 / 55.444624 (-53.626898) | 1.520834 / 6.876477 (-5.355642) | 1.696285 / 2.142072 (-0.445788) | 0.815147 / 4.805227 (-3.990080) | 0.136566 / 6.500664 (-6.364098) | 0.043482 / 0.075469 (-0.031987) |

### Benchmark: benchmark_map_filter.json

| metric | filter | map fast-tokenizer batched | map identity | map identity batched | map no-op batched | map no-op batched numpy | map no-op batched pandas | map no-op batched pytorch | map no-op batched tensorflow |
|--------|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 0.981382 / 1.841788 (-0.860406) | 11.472890 / 8.074308 (3.398582) | 9.274181 / 10.191392 (-0.917211) | 0.133051 / 0.680424 (-0.547373) | 0.015417 / 0.534201 (-0.518784) | 0.306098 / 0.579283 (-0.273185) | 0.261424 / 0.434364 (-0.172940) | 0.338946 / 0.540337 (-0.201391) | 0.460776 / 1.386936 (-0.926160) |

</details>
PyArrow==latest

<details>
<summary>Show updated benchmarks!</summary>

### Benchmark: benchmark_array_xd.json

| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_as_numpy after write_nested_sequence | read_batch_unformated after write_array2d | read_batch_unformated after write_flattened_sequence | read_batch_unformated after write_nested_sequence | read_col_formatted_as_numpy after write_array2d | read_col_formatted_as_numpy after write_flattened_sequence | read_col_formatted_as_numpy after write_nested_sequence | read_col_unformated after write_array2d | read_col_unformated after write_flattened_sequence | read_col_unformated after write_nested_sequence | read_formatted_as_numpy after write_array2d | read_formatted_as_numpy after write_flattened_sequence | read_formatted_as_numpy after write_nested_sequence | read_unformated after write_array2d | read_unformated after write_flattened_sequence | read_unformated after write_nested_sequence | write_array2d | write_flattened_sequence | write_nested_sequence |
|--------|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 0.005806 / 0.011353 (-0.005547) | 0.004274 / 0.011008 (-0.006734) | 0.050831 / 0.038508 (0.012323) | 0.033717 / 0.023109 (0.010607) | 0.280561 / 0.275898 (0.004663) | 0.302437 / 0.323480 (-0.021043) | 0.004543 / 0.007986 (-0.003442) | 0.002905 / 0.004328 (-0.001424) | 0.048897 / 0.004250 (0.044646) | 0.041089 / 0.037052 (0.004037) | 0.291439 / 0.258489 (0.032950) | 0.319762 / 0.293841 (0.025921) | 0.033178 / 0.128546 (-0.095368) | 0.012336 / 0.075646 (-0.063311) | 0.061033 / 0.419271 (-0.358238) | 0.034018 / 0.043533 (-0.009515) | 0.278514 / 0.255139 (0.023375) | 0.295648 / 0.283200 (0.012448) | 0.018621 / 0.141683 (-0.123062) | 1.160250 / 1.452155 (-0.291905) | 1.183867 / 1.492716 (-0.308850) |

### Benchmark: benchmark_getitem\_100B.json

| metric | get_batch_of\_1024\_random_rows | get_batch_of\_1024\_rows | get_first_row | get_last_row |
|--------|---|---|---|---|
| new / old (diff) | 0.096354 / 0.018006 (0.078348) | 0.301907 / 0.000490 (0.301417) | 0.000205 / 0.000200 (0.000006) | 0.000044 / 0.000054 (-0.000011) |

### Benchmark: benchmark_indices_mapping.json

| metric | select | shard | shuffle | sort | train_test_split |
|--------|---|---|---|---|---|
| new / old (diff) | 0.022357 / 0.037411 (-0.015054) | 0.076218 / 0.014526 (0.061692) | 0.088172 / 0.176557 (-0.088385) | 0.128621 / 0.737135 (-0.608515) | 0.089250 / 0.296338 (-0.207089) |

### Benchmark: benchmark_iterating.json

| metric | read 5000 | read 50000 | read_batch 50000 10 | read_batch 50000 100 | read_batch 50000 1000 | read_formatted numpy 5000 | read_formatted pandas 5000 | read_formatted tensorflow 5000 | read_formatted torch 5000 | read_formatted_batch numpy 5000 10 | read_formatted_batch numpy 5000 1000 | shuffled read 5000 | shuffled read 50000 | shuffled read_batch 50000 10 | shuffled read_batch 50000 100 | shuffled read_batch 50000 1000 | shuffled read_formatted numpy 5000 | shuffled read_formatted_batch numpy 5000 10 | shuffled read_formatted_batch numpy 5000 1000 |
|--------|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 0.292633 / 0.215209 (0.077424) | 2.862456 / 2.077655 (0.784801) | 1.581967 / 1.504120 (0.077847) | 1.459822 / 1.541195 (-0.081373) | 1.475896 / 1.468490 (0.007406) | 0.728550 / 4.584777 (-3.856226) | 0.958819 / 3.745712 (-2.786893) | 3.011074 / 5.269862 (-2.258788) | 1.934393 / 4.565676 (-2.631283) | 0.079831 / 0.424275 (-0.344444) | 0.005249 / 0.007607 (-0.002358) | 0.346334 / 0.226044 (0.120290) | 3.438979 / 2.268929 (1.170051) | 1.935567 / 55.444624 (-53.509057) | 1.648723 / 6.876477 (-5.227754) | 1.685489 / 2.142072 (-0.456583) | 0.800992 / 4.805227 (-4.004236) | 0.139388 / 6.500664 (-6.361276) | 0.042518 / 0.075469 (-0.032951) |

### Benchmark: benchmark_map_filter.json

| metric | filter | map fast-tokenizer batched | map identity | map identity batched | map no-op batched | map no-op batched numpy | map no-op batched pandas | map no-op batched pytorch | map no-op batched tensorflow |
|--------|---|---|---|---|---|---|---|---|---|
| new / old (diff) | 1.031715 / 1.841788 (-0.810072) | 12.486711 / 8.074308 (4.412403) | 10.430191 / 10.191392 (0.238799) | 0.146884 / 0.680424 (-0.533540) | 0.015735 / 0.534201 (-0.518466) | 0.303938 / 0.579283 (-0.275346) | 0.140374 / 0.434364 (-0.293989) | 0.338508 / 0.540337 (-0.201830) | 0.429551 / 1.386936 (-0.957385) |

</details>
</details>

![](https://cml.dev/watermark.png#e32336195f3ea69988148df5f129f9f59d3ab595 "CML watermark")