Title: Imppres
Author: aclifton314 (CONTRIBUTOR)
State: closed
Created: 2020-12-09T22:14:12Z

2nd PR ever! Hopefully I'm starting to get the hang of this. This is for the IMPPRES dataset. Please let me know of any corrections or changes that need to be made.

Comments:
Feel free to ping me once you're ready for another review :) 

For sure! Gonna work on this now!

I incorporated all the changes but when I go to rebase I get the following error:
```python
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash
Saved working directory and index state WIP on imppres: 51736236 Incorporated secondary sets as configurations instead of splits.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/wiki_movies.py
Auto-merging datasets/wiki_movies/wiki_movies.py
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/dataset_infos.json
Auto-merging datasets/wiki_movies/dataset_infos.json
CONFLICT (add/add): Merge conflict in datasets/wiki_movies/README.md
Auto-merging datasets/wiki_movies/README.md
error: could not apply 04d08587... Created wiki_movies dataset.
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 04d08587... Created wiki_movies dataset.
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git branch
* (no branch, rebasing imppres)
  imppres
  logiqa_en
  master
  wiki_movies
  wiki_movies_htl
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout imppres 
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
error: you need to resolve your current index first
aclifton@pop-os:~/hf_datasets_sprint/datasets$ 
```

I think it's because the current branch includes changes about wiki_movies.

Can you create a new branch from `master` and create another PR please ?

I get this response when I try to switch to master:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout master
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
error: you need to resolve your current index first
```

Maybe you have to remove the changes in wiki_movies before checkout to master
```
git stash
```

should do the job

Here is what I get:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash
datasets/wiki_movies/README.md: needs merge
datasets/wiki_movies/dataset_infos.json: needs merge
datasets/wiki_movies/wiki_movies.py: needs merge
```

Ok I see
Looks like you're in a `merge` process.
You can abort it with `git reset --merge`

Then `git checkout master` should work

So close! I got the new branch made and went through all the tests. When I went to push, I got the following:
```
aclifton@pop-os:~/hf_datasets_sprint/datasets$ git push -u origin imppres
Username for 'https://github.com': aclifton314
Password for 'https://aclifton314@github.com': 
To https://github.com/aclifton314/datasets
 ! [rejected]          imppres -> imppres (non-fast-forward)
error: failed to push some refs to 'https://github.com/aclifton314/datasets'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
```

after a rebase you need to `git push --force`

Done!