As Mo notes the significance here is that all earlier attempts to calculate were based on practical measurement whereas the work by Zhang was based on a theoretical calculation

Add punctuation
As Mo notes, the significance here is that all earlier attempts to calculate were based on practical measurement, whereas the work by Zhang was based on a theoretical calculation.