Repository: gnome-pomodoro/gnome-pomodoro

Issue #369: Fails to build with vala 0.42.0
Created: 2018-09-04T01:59:58Z
With the new versions of vala 0.42.0, gnome-pomodoro fails to build with the following error message:
/usr/lib/x86_64-linux-gnu/glib-2.0/glib-compile-schemas --strict
--dry-run  --schema-file=org.gnome.pomodoro.plugins.sounds.gschema.xml
&& mkdir -p . && touch org.gnome.pomodoro.plugins.sounds.gschema.valid
sound-player.vala:130.9-130.33: error: Property
`SoundsPlugin.GStreamerPlayer.volume_fade' with custom `get' accessor
and/or `set' mutator cannot have `default' value
        public double volume_fade {
        ^^^^^^^^^^^^^^^^^^^^^^^^^
sound-player.vala:120.9-120.28: error: Property
`SoundsPlugin.GStreamerPlayer.volume' with custom `get' accessor and/or
`set' mutator cannot have `default' value
        public double volume {
        ^^^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:176.3-176.19: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void pause ();
		^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:177.3-177.18: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void quit ();
		^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:178.3-178.19: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void reset ();
		^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:179.3-179.20: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void resume ();
		^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:180.3-180.23: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void set_state (string name, double timestamp);
		^^^^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:181.3-181.30: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void show_main_window (uint32 timestamp);
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:182.3-182.30: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void show_preferences (uint32 timestamp);
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:183.3-183.18: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void skip ();
		^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:184.3-184.19: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void start ();
		^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:185.3-185.18: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public void stop ();
		^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:192.3-192.36: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public virtual signal void destroy ();
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../lib/gnome-pomodoro.vapi:311.3-311.39: warning: DBus methods are
recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
		public abstract void get_capabilities (out string[] capabilities)
throws GLib.IOError;
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 12 warning(s)

Debian bug reference: https://bugs.debian.org/907897
It is due to a new restriction brought with commit It seems the issue is related to the vala upgrade to 0.42.0 which was released yesterday in Debian and brings this commit in: GNOME/vala@0d396f7
I'll work on a fix for that today or tomorrow and push a PR with the fix.

Duplicate issue #377: Installation failed on Arch Linux
Created: 2018-10-05T10:02:58Z
No matter how I try to install it (gnome-shell-pomodoro via yaourt or manual tar & makepkg) I'm gettings the same compilation error:
sound-player.vala:130.9-130.33: error: Property `SoundsPlugin.GStreamerPlayer.volume_fade' with custom `get' accessor and/or `set' mutator cannot have `default' value
        public double volume_fade {
        ^^^^^^^^^^^^^^^^^^^^^^^^^
sound-player.vala:120.9-120.28: error: Property `SoundsPlugin.GStreamerPlayer.volume' with custom `get' accessor and/or `set' mutator cannot have `default' value
        public double volume {
        ^^^^^^^^^^^^^^^^^^^^

Could be related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907897

Closing comment (2018-10-10T15:30:59Z): I think this is a duplicate of #369, and would be fixed for the gnome-shell-pomodoro AUR package by tagging a new release of this package.  Unfortunately the gnome-shell-pomodoro-git package tracks an old branch so it doesn't include the fix (#370) but if you change the PKGBUILD to use master it's okay.