Repository: DataDog/dd-agent

Issue #805: [dogstasd] dogstatsd_normalize value and dogstatsd_interval are never picked up from config
Created: 2014-01-22T22:05:51Z
Unsure if this is a conscious choice or not.
Ref:

  
    
      dd-agent/config.py
    
    
        Lines 318 to 338
      in
      f122e1c
    
  
  
    

        
          
           # Dogstatsd config 
        

        
          
           dogstatsd_defaults = { 
        

        
          
               'dogstatsd_port': 8125, 
        

        
          
               'dogstatsd_target': 'http://localhost:17123', 
        

        
          
               'dogstatsd_interval': dogstatsd_interval, 
        

        
          
               'dogstatsd_normalize': 'yes', 
        

        
          
           } 
        

        
          
           for key, value in dogstatsd_defaults.iteritems(): 
        

        
          
               if config.has_option('Main', key): 
        

        
          
                   agentConfig[key] = config.get('Main', key) 
        

        
          
               else: 
        

        
          
                   agentConfig[key] = value 
        

        
          
            
        

        
          
           #Forwarding to external statsd server 
        

        
          
           if config.has_option('Main', 'statsd_forward_host'): 
        

        
          
               agentConfig['statsd_forward_host'] = config.get('Main', 'statsd_forward_host') 
        

        
          
               if config.has_option('Main', 'statsd_forward_port'): 
        

        
          
                   agentConfig['statsd_forward_port'] = int(config.get('Main', 'statsd_forward_port')) 
        

        
          
            
        

        
          
           # normalize 'yes'/'no' to boolean 
        

        
          
           dogstatsd_defaults['dogstatsd_normalize'] = _is_affirmative(dogstatsd_defaults['dogstatsd_normalize']) 
        
    
  


Also set here: 
  
    
      dd-agent/config.py
    
    
         Line 194
      in
      f122e1c
    
  
  
    

        
          
           'dogstatsd_normalize': 'yes', 
        
    
  


However, setting the conf directive to no or false will have no impact, since at no point to re read this value from the `agentConfig object.
This was added in #252 with a default value of "no".
Another commit referencing the conf change: daaa448
@clutchski, @alq666 - do you recall this case, and what we need to do about this?

Duplicate issue #1328: dogstatsd_interval and dogstatsd_normalize options are dead
Created: 2015-01-29T16:45:19Z
While still present in the example configuration files, dogstatsd_interval and dogstatsd_normalize are no longer used in the code.
This disappearance seems to be related to a logic change in the aggregator.
While we could just remove them, it could make sense to bring them back.
I am not sure about dogstatsd_normalize (it would just multiply the values with a constant that don't have a real meaning), but dogstatsd_interval is still important.
I checked the code, the flush interval and the aggregator interval are 2 important attributes that we should be able to configure. But we only use their default values DOGSTATSD_FLUSH_INTERVAL and DOGSTATSD_AGGREGATOR_BUCKET_SIZE.
It should be deadly simple to make them configurable.

Closing comment (2015-02-27T16:38:04Z): Duplicate of #805