Repository: ceph/ceph-csi

Issue #1379: Make use of Volumecapability in Expand request to avoid NodeExpansion when its of type block volumemode.
Created: 2020-08-13T16:30:32Z
Describe the bug
	// volumePath is targetPath for block PVC and stagingPath for filesystem.
	// check the path is mountpoint or not, if it is
	// mountpoint treat this as block PVC or else it is filesystem PVC
	// TODO remove this once ceph-csi supports CSI v1.2.0 spec
	notMnt, err := mount.IsNotMountPoint(ns.mounter, volumePath)
	if err != nil {
		if os.IsNotExist(err) {
			return nil, status.Error(codes.NotFound, err.Error())
		}
		return nil, status.Error(codes.Internal, err.Error())
	}
	if !notMnt {
		return &csi.NodeExpandVolumeResponse{}, nil
	}

As we are already on SPEC 1.2 we could get rid of this TODO.

Duplicate issue #1384: Block PVC are marked as FileSystemResizeRequired 
Created: 2020-08-17T06:45:39Z
Describe the bug
Block PVC are marked as FileSystemResizeRequired
Environment details

Image/version of Ceph CSI driver : v1.2.1
Helm chart version :
Kernel version :
Mounter used for mounting PVC (for cephfs its fuse or kernel. for rbd its
krbd or rbd-nbd) :
Kubernetes cluster version :
Ceph cluster version :

Steps to reproduce
Steps to reproduce the behavior:

create a block pvc
update pvc size
See error

Actual results
Name:          block-pvc
Namespace:     default
StorageClass:  rook-ceph-block
Status:        Bound
Volume:        pvc-20e0a018-ff8f-4068-9fbf-8a714b17b656
Labels:        username.infra.genos.io=kubernetes-admin
Annotations:   kubectl.kubernetes.io/last-applied-configuration:
                 {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"block-pvc","namespace":"default"},"spec":{"accessMo...
               pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: rook-ceph.rbd.csi.ceph.com
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      1Gi
Access Modes:  RWO
VolumeMode:    Block
Mounted By:    <none>
Conditions:
  Type                      Status  LastProbeTime                     LastTransitionTime                Reason  Message
  ----                      ------  -----------------                 ------------------                ------  -------
  FileSystemResizePending   True    Mon, 01 Jan 0001 00:00:00 +0000   Wed, 03 Jun 2020 17:48:51 +0800           Waiting for user to (re-)start a pod to finish file system resize of volume on node.
Events:                     <none>

Expected behavior
Block PVC successfully resized with no FileSystemResizeRequired events.
Logs
If the issue is in PVC creation, deletion, cloning please attach complete logs
of below containers.

csi-provisioner and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in PVC resize please attach complete logs of below containers.

csi-resizer and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in snapshot creation and deletion please attach complete logs
of below containers.

csi-snapshotter and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

If the issue is in PVC mounting please attach complete logs of below containers.


csi-rbdplugin/csi-cephfsplugin and driver-registrar container logs from
plugin pod from the node where the mount is failing.


if required attach dmesg logs.


Note:- If its a rbd issue please provide only rbd related logs, if its a
cephfs issue please provide cephfs logs.
Additional context
Add any other context about the problem here.
For example:
Any existing bug report which describe about the similar issue/behavior

Closing comment (2020-08-18T12:37:21Z): @humblec please close this as duplicate of #1379 if that is the case. Or add Fixes: #1384 to the description of PR #1386.