primordic/IssueDupesLite huggingface dataset:
Repository: ssllabs/ssllabs-scan

Issue #465: Please Show ServerKeyExchange signed_params Hash Function
Created: 2017-02-22T22:39:02Z
The ServerKeyExchange message for Forward Secret, non-anonymous ciphers contains a signed_params hash: https://tools.ietf.org/html/rfc5246#section-7.4.3
The options are a combination of algorithm {RSA, DSA, ECDSA} and digest {SHA1, SHA256, SHA384, SHA512}. Note: the hash and signature algorithms MUST be compatible with the key in the server's end-entity certificate (e.g. ECDSA certificate, must have an ECDSA+SHA* signature).
Why is this relevant? Chrome 56 recently dropped support for ECDSA+SHA1 and ECDSA+SHA512. Plus, it's helpful to know that your system is configured to return SHA1-strength hashes; maybe then we'll be able to improve the situation before Chrome drops support for a production website.
Thank you for your consideration.

Duplicate issue #740: Check for weak signature algorithms
Created: 2019-08-14T20:51:46Z
Some servers use SHA1 based signature algorithms when the client didn't offer them. See for instance openssl/openssl#7126
Can a check be added for such servers, and stop marking them as A+?

Closing comment (2020-03-25T12:15:32Z): Yes, this issue is a duplicate of #465 (comment).
Repository: ssllabs/ssllabs-scan

Issue #704: Client result vs server result "rating" coloring 
Created: 2019-04-16T18:11:56Z
It would be nice to see AEAD ciphers in green (good)  and "TLS 1.1" in yellow (weak)
also on client test https://www.ssllabs.com/ssltest/viewMyClient.html
and user Agent capabilities (Details) e.g
https://www.ssllabs.com/ssltest/viewClient.html?name=Chrome&version=70&platform=Win%2010&key=153
so that they have same color "Rating" like at Server result
Thanks

Duplicate issue #758: feature request: use Cipher Suite colors in Handshake Simulation section
Created: 2019-11-12T19:02:05Z
It would be very useful to see at a glance if a cipher suite in the Handshake Simulation section is strong (green), OK (black), or weak (orange).
As initially discussed here.

Closing comment (2020-06-09T23:37:10Z): Closing as duplicate of #704 / #717
Repository: ssllabs/ssllabs-scan

Issue #636: TLS 1.3 Cipher Strength 90%?
Created: 2018-07-10T13:19:07Z
Hey there,
I tested my site -> nginx 1.15.1 using Openssl 1.1.1 pre release 8 on

https://dev.ssllabs.com/

with the following cipher list:
TLS13-CHACHA20-POLY1305-SHA256:TLS13-AES-256-GCM-SHA384:TLS13-AES-128-GCM-SHA256
and I only got 90% Cipher Strength.
Am I doing something wrong?

https://www.openssl.org/blog/blog/2017/05/04/tlsv1.3/

There are only 5 TLS 1.3 Ciphers supported by openssl yet.

Duplicate issue #684: Perfect scan impossible with TLSv1.3
Created: 2019-02-01T15:01:51Z
If a server supports TLSv1.3, it's impossible for it to get a perfect scan result. The problem is due to the TLS_AES_128_GCM_SHA256 cipher suite. If it is enabled, your cipher strength score will be capped at 90% (see also #648). If it is not enabled, you'll get this in a red box:

This server does not support the mandatory cipher suite TLS_AES_128_GCM_SHA256 for TLS 1.3. See RFC 8446 for details.

Closing comment (2019-02-01T16:39:58Z): Duplicate of #636.
Repository: ssllabs/ssllabs-scan

Issue #745: 404 Errors - Links to more info on your website
Created: 2019-09-13T21:47:10Z
Just to inform you the links that give more information on known vulnerabilities upon completing a certificate scan are all going to 404 page not found, I tried to email  you at the email address given with the 404 but it came back to me with unknown  domain (dhnylf.com). Thought you might be unaware of the issue.

Duplicate issue #746: News section at www.ssllabs.com has reset itself to 2014
Created: 2019-09-14T07:44:47Z
And links do not work.  Something happened?

Closing comment (2019-09-15T16:44:05Z): To give an update we are in the process of fixing it - https://discussions.qualys.com/thread/20109-problems-with-renegotiation-testing-on-ssl-labs-reports#comment-48649
Duplicate of #745
Repository: ssllabs/ssllabs-scan

Issue #118: Please add a check for DNSSEC [pass/fail]
Created: 2015-04-24T07:28:40Z
Similar to the dig command
test@test-VirtualBox ~ $ dig +sigchase +short +trusted-key=./root.keys www.asio.gov.au. A |grep validation
;; RRSIG is missing for continue validation: FAILED
test@test-VirtualBox ~ $ dig +sigchase +trusted-key=./root.keys www.eurid.eu. A |grep validation
;; Ok this DNSKEY is a Trusted Key, DNSSEC validation is ok: SUCCESS
<

Duplicate issue #261: TLSA Support
Created: 2015-11-17T19:01:36Z
How about support for checking TLSA-Records?

Closing comment (2015-11-17T22:10:48Z): Dupe. #118
Repository: ssllabs/ssllabs-scan

Issue #636: TLS 1.3 Cipher Strength 90%?
Created: 2018-07-10T13:19:07Z
Hey there,
I tested my site -> nginx 1.15.1 using Openssl 1.1.1 pre release 8 on

https://dev.ssllabs.com/

with the following cipher list:
TLS13-CHACHA20-POLY1305-SHA256:TLS13-AES-256-GCM-SHA384:TLS13-AES-128-GCM-SHA256
and I only got 90% Cipher Strength.
Am I doing something wrong?

https://www.openssl.org/blog/blog/2017/05/04/tlsv1.3/

There are only 5 TLS 1.3 Ciphers supported by openssl yet.

Duplicate issue #777: Score penalty of 10% when using the mandatory TLS_AES_256_GCM_SHA384 cipher
Created: 2020-02-11T00:30:22Z
When configuring a TLS 1.3 only web server compliant with the RFC 8446 you currently get a score penalty because the TLS_AES_256_GCM_SHA384 cipher is allowed.
This should be changed.

Closing comment (2020-02-11T09:36:39Z): Duplicate of #636, #684, #668.
Repository: ssllabs/ssllabs-scan

Issue #895: Website showing two SSL
Created: 2022-07-09T07:35:56Z
Hello Sir,
Why a domain nxp.futurewiz.co.in showing there are two SSL after SSL Server Test. I check at our end and with domain/hosting server team and got only one SSL certificate is marked for that particular domain.
I am requested, Please help us for the same issue.
Regards
Nagendra

Duplicate issue #896: Hello Sir,
Created: 2022-07-11T12:43:22Z
Hello Sir,
Why a domain nxp.futurewiz.co.in showing there are two SSL after SSL Server Test. I check at our end and with domain/hosting server team and got only one SSL certificate is marked for that particular domain.
I am requested, Please help us for the same issue.
Regards
Nagendra
Originally posted by @nagendraserver in #895

Closing comment (2022-07-12T06:58:36Z): Closing as duplicate #895
Repository: steemit/steem

Issue #33: adjust_witness_votes recursion issue
Created: 2016-04-26T23:15:19Z
Test case:
Assume that STEEMIT_MAX_PROXY_RECURSION_DEPTH is 2.
Assume there are 5 accounts a1~a5, all have 1 VESTS.
Assume there is a witness w.

a1 vote for w, delta = 1

depth = 0: w.votes = 1


a2 set proxy a1, delta = 1

depth = 0: a1.proxied_vsf_votes = 0+1 = 1
depth = 1: w.votes = 1+1 = 2


a3 set proxy a2, delta = 1

depth = 0: a2.proxied_vsf_votes = 0+1 = 1
depth = 1: a1.proxied_vsf_votes = 1+1 = 2
depth = 2: w.votes = 2+1 = 3


a4 set proxy a3, delta = 1

depth = 0: a3.proxied_vsf_votes = 0+1 = 1
depth = 1: a2.proxied_vsf_votes = 1+1 = 2
depth = 2: a1.proxied_vsf_votes  = 2+1 = 3
depth = 3: w.votes = 3+1 = 4


a5 set proxy a4, delta = 1

depth = 0: a4.proxied_vsf_votes = 0+1 = 1
depth = 1: a3.proxied_vsf_votes = 1+1 = 2
depth = 2: a2.proxied_vsf_votes  = 2+1 = 3
depth = 3: a1.proxied_vsf_votes  = 3+1 = 4
recursion end. w.votes remains 4


a1 vote for nobody, delta = -(4+1) = -5

depth = 0: w.votes = 4 + (-5) = -1



Huh?

Duplicate issue #399: Bug in v0.14.1 process_decline_voting_rights
Created: 2016-09-14T01:12:42Z
When an account declining voting rights, all its direct witness votes and proxied witness votes should be removed. Current code removes direct votes but not proxied votes.
Code in process_decline_voting_rights
+      adjust_proxied_witness_votes( account, -account.witness_vote_weight() );
+      clear_witness_votes( account );
+
+      modify( itr->account(*this), [&]( account_object& a )
+      {
+         a.can_vote = false;
+         a.proxy = a.name;
+      });

Should be similar to code in account_witness_proxy_evaluator::do_apply
   /// remove all current votes
   std::array<share_type, STEEMIT_MAX_PROXY_RECURSION_DEPTH+1> delta;
   delta[0] = -account.vesting_shares.amount;
   for( int i = 0; i < STEEMIT_MAX_PROXY_RECURSION_DEPTH; ++i )
      delta[i+1] = -account.proxied_vsf_votes[i];
   db().adjust_proxied_witness_votes( account, delta );
   ...
      /// clear all individual vote records
      db().clear_witness_votes( account );
   ...
      /// update proxy
      a.proxy = STEEMIT_PROXY_TO_SELF_ACCOUNT;

Closing comment (2016-09-14T13:41:22Z): @mvandeberg this issue is similar to #33.

Calling adjust_proxied_witness_votes( account, -account.witness_vote_weight() ); is the same as saying "power down all Steem Power immediately"

When there is a proxy chain, you can't treat it like all weight belongs to the account itself. Otherwise invariants will be inconsistent after executed the code.
Repository: steemit/steem

Issue #130: Sanitize witness hardfork versions
Created: 2016-06-29T19:26:03Z
A witness can submit any value they wish for the hardfork version and time. Particularly, they can submit a hardfork version whose first 16-bits (release number) is not zero, which gets stored in the witness object anyway. This then causes problems with the cli_wallet when it tries to get_witness of a witness that has such an improper hardfork version.
I suggest that steemd first sanitize the witness-submitted hardfork version beforing saving it to the database such that its release number is always 0. That process would occur here: https://github.com/steemit/steem/blob/v0.8.2/libraries/chain/database.cpp#L2534
We could also have stricter checks on the user submitted hardfork version and time, and if those checks fail, the witness object wouldn't be modified at all.

Duplicate issue #134: Internal error: static_variant tag is invalid.
Created: 2016-07-02T13:24:59Z
Sent a SIGINT to steemd when it was processing some RPC endpoint get_block requests, got
1734246ms th_a       database.cpp:608              _push_block          ] Failed to push new block:
10 assert_exception: Assert Exception
Internal error: static_variant tag is invalid.
    {}
    th_a  static_variant.hpp:134 apply

The process than hung without crashing, establishing a new WebSocket connection and sending additional commands lead to no reply.
steemd version 0.8.4

Closing comment (2016-07-04T20:02:01Z): Possible related to #130 and 1479788
Repository: steemit/steem

Issue #288: Merge btscube Visual Studio fixes
Created: 2016-08-16T20:02:04Z
#138 has bit-rotted enough that I'm going to rebase it onto staging.

Duplicate issue #311: Compiled code is compatible with windows
Created: 2016-08-21T13:33:08Z
Compiled code is compatible with windows Visual Studio 2013:
witness.cpp[409]:
old:void witness_plugin::on_applied_block( const chain::signed_block& b )
new:void witness_plugin::on_applied_block(const steemit::chain::signed_block& b)
market_history_plugin.cpp[24]:
old:flat_set<uint32_t>     _tracked_buckets = { 15, 60, 300, 3600, 86400 };
new:flat_set<uint32_t>     _tracked_buckets = flat_set<uint32_t>{ 15, 60, 300, 3600, 86400 };
authority.cpp[82]:
old:
for( auto item : account_auths ) FC_ASSERT( is_valid_account_name( item.first ) );
new:
for (auto item : account_auths){ FC_ASSERT(is_valid_account_name(item.first)); }
database.cpp[2013]:
old:if( shares == 0 ) return;
new:if (shares == fc::uint128(0)) return;
The above modification in vs2013 compile "steemd.exe"

Closing comment (2016-08-26T17:13:23Z): Duplicate of #288 -- these issues were reported by @btscube in prehistoric times, and have been merged to develop for a while.
Repository: steemit/steem

Issue #216: Allow string ID for JSONRPC messages
Created: 2016-07-27T19:06:18Z
Continuing discussion of the second issue raised in #213:  Namely, FC's JSON-RPC implementation is not spec-compliant as it doesn't allow string ID's.
I think the problem is here -- basically we do internal bookkeeping with _awaiting which is declared as a map using uint64_t as its key.  I'm not sure variant (the FC type representing a JSON object) has the right interface to be used as a key in a map, and I'm sure that changing it to anything other than a uint64 will have negative performance implications.
I'm tempted to tag this wontfix, but we should strive to be spec-compliant.

Duplicate issue #868: steemd violates json rpc spec in responses
Created: 2017-02-14T20:58:18Z
When POSTing the following to steemd:
{
    "method": "get_config",
    "params": [],
    "jsonrpc": "2.0",
    "id": "4b274d37b85742d9876036d19279b345"
}

steemd returns:
4 parse_error_exception: Parse Error
Couldn't parse uint64_t
    {}
    th_a  string.cpp:113 to_uint64

    {"i":"4b274d37b85742d9876036d19279b345"}
    th_a  string.cpp:116 to_uint64

    {"*this":"4b274d37b85742d9876036d19279b345"}
    th_a  variant.cpp:405 as_uint64


This is a valid json-rpc 2.0 request, so it should be returning a valid json-rpc error (it's not - the response is not json).
A correct response would be:
{
    "jsonrpc": "2.0",
    "id": "4b274d37b85742d9876036d19279b345",  //or null, as it wasn't parseable
    "error": {
        "message": "<error message as above>",
        "id": -32603
    }
}

per http://www.jsonrpc.org/specification#error_object
Note that this is unrelated to the fact that steemd is expecting a uint64 in the "id" field - regardless of what the client sends, steemd should ALWAYS return a valid json response.
The fact that steemd is expecting a uint64 is a separate issue:
From the spec:

id


An identifier established by the Client that MUST contain a String, Number, or NULL value if included. If it is not included it is assumed to be a notification. The value SHOULD normally not be Null [1] and Numbers SHOULD NOT contain fractional parts [2]

Closing comment (2017-02-14T21:42:22Z): dupe of #216
Repository: steemit/steem

Issue #3351: suspect RC error message
Created: 2019-06-06T11:36:33Z
Some users report seeing the following:

"5097234098 RC, needs 2959082668 RC." and "6810631387 RC, needs 2959715915 RC." are Chrome or Steem's error messages using language calculated using math?
What kind of calculator should I use or is that a bug?

Ref: 
  
    
      steem/libraries/plugins/rc/rc_plugin.cpp
    
    
         Line 269
      in
      dc983c5
    
  
  
    

        
          
           bool has_mana = rc_account.rc_manabar.has_mana( rc ); 
        
    
  


Since 5,097,234,098 is well above 2,959,082,668, the message is confusing. Is there an error in how it's generated?

Duplicate issue #3404: RC API sometimes incorrectly reports user doesn't have enough RC
Created: 2019-07-15T15:50:52Z
Issue
Some nodes show an incorrect RC amount for users when trying to transact. In certain situations, this results in an error preventing the transaction when the user does, in fact, have enough RC.
Quick Fix
The issue appears to be happening on some nodes some of the time. Switching to a different node seems to fix the issue, both allowing the transaction to go through and removing the issue from the original, affected node.
Steps to Reproduce
*WARNING: Very hard to reproduce reliably.

Try to perform some transaction on SteemIt.com
Get an error "plugin exception:Account: netuoso has 1123844 RC, needs 728922 RC. Please wait to transact, or power up STEEM.rethrow"
Observe the error saying user has 1,123,844 RC and needs 728,922 RC. The current RC amount is higher than the required RC amount.
Send the same transaction to a different node this time
If transaction goes through, observe that user can perform actions on the original node

More Information

Error tells user they need more RC when they have enough
Issue is present on the Mainnet
Issue is fixed by using a different node
Has been reported by several users in the past few weeks

More Information - User reports
Hi, I'm trying to make a costly op: resteem
RPCError: plugin exception:Account: USER has 5523170590 RC, needs 431011452 RC. Please wait to transact, or power up STEEM.
5523170590 is bigger than 
431011452
I don't understand...

RPCError: plugin exception:Account: USER has 309612403135 RC, needs 76426276 RC. Please wait to transact, or power up STEEM.rethrow

Closing comment (2019-07-24T16:40:29Z): Dupe of #3351?
Repository: steemit/steem

Issue #2628: rc_plugin should take feedback from consensus state for discount account pool size
Created: 2018-07-12T14:38:08Z
The consensus code implements its own pool for discounted account creation.  The non-consensus pool used by the RC plugin for discount account creation should be copied from this consensus pool every block, so as the consensus pool depletes, the non-consensus RC price signal reflects the true remaining amount of discounted account creations which would be allowed by consensus.
The effect is to ensure that, as long as sufficient numbers of p2p nodes / witnesses are running the RC plugin, high RC requirements will apply a continuous soft limit to discount account creation, before the consensus hard-limit starts rejecting discount account creations.

Duplicate issue #2600: RC parameter feedback
Created: 2018-07-06T17:02:27Z

Closing comment (2018-07-17T17:27:24Z): Duplicate #2628
Repository: steemit/steem

Issue #2731: As a contributor to a failed ICO, I want to be able to recall my contribution.
Created: 2018-08-06T21:33:03Z
As a contributor to a failed ICO, or perceived failed ICO, I want to recall my contribution.
Entails:
smt_refund_operation
post_contribution_pause
struct smt_refund_operation
{
   account_name_type executor;
   asset_symbol_type symbol;
   extensions_type   extensions;
};
struct smt_refund_action
{
   account_name_type  contributor;
   asset_symbol_type  symbol;
   uint32_t           contribution_id;
   asset              contribution;
   extensions_type    extensions;
};
AC:

After an SMT's announced launch time if all hidden caps have been revealed and the ICO has failed anyone can submit an smt_refund_operation.
After an SMT's announced launch time plus 24 hours (known as the post contribution pause) regardless of whether hidden caps have not been revealed anyone can submit an smt_refund_operation.
The smt_refund_operation begins a series of cascading automated actions that refund contributions to an ICO.
This moves the SMT in to the failed state.
The cascading smt_refund_actions can be of O(n). However, it corresponds 1:1 with contributions. smt_contribution_operation should cover the cost of the refund.

Tasks:
-[ ] Validation/testing of smt_refund_operation
-[ ] Evaluation/testing of smt_refund_operation
-[ ] Evaluation/testing of smt_refund_action
-[ ] Update smt_contribution_operation RC cost to include costs of refunds.
-[ ] Update SMT Whitepaper
Related #2251, #2056

Duplicate issue #2736: ICO Failed Launch
Created: 2018-08-06T21:47:07Z
Handle the case of a failed ICO launch.

Closing comment (2019-06-24T17:28:33Z): Potential duplicate of #2731?
Repository: steemit/steem

Issue #66: Invalid JSON-RPC response
Created: 2016-05-24T19:01:15Z
I am calling the RPC endpoint from Go and I am getting bad response error from the client library since steemd seems not to return any jsonrpc field in the response, even though the field MUST be set to 2.0 according to the spec.

Duplicate issue #1801: "Invalid Request" when using curl with https://api.steemit.com
Created: 2017-11-24T17:48:12Z
Getting Invalid Request when using curl with https://api.steemit.com.
Normal behavior:
$ curl --silent https://steemd.steemit.com --data '{"id":0,"method":"get_account_count","params":[]}' | python3 -m json.tool
{
    "id": 0,
    "result": 461836
}

Buggy behavior:
$ curl --silent https://api.steemit.com --data '{"id":0,"method":"get_account_count","params":[]}' | python3 -m json.tool       
{
    "jsonrpc": "2.0",
    "error": {
        "code": -32600,
        "message": "Invalid Request",
        "data": {
            "error_id": "f7377eea-c619-4781-9b3a-304948fbdccf",
            "request": {
                "method": "POST",
                "path": "/",
                "body": {
                    "body": {
                        "id": 0,
                        "method": "get_account_count",
                        "params": []
                    },
                    "is_batch": false,
                    "batch_request_count": null
                },
                "amzn_trace_id": "Root=1-5a1859d4-3f10426f29e71c741ba637a2",
                "amzn_request_id": null,
                "jussi_request_id": "s83318d93-f3e0-48c6-a8ff-138e239cf77a"
            }
        }

Closing comment (2017-11-27T15:54:42Z): Your request does not contain the field "jsonrpc":"2.0" which is required by the JSON-RPC Specification. Production steemd is using outdated jsonrpc code and allows this when it should not. Many of the rough edges surrounding jsonrpc are being fixed in appbase, which is nearing a release.
This was first reported in #66. Closing at this is not a problem with steemd, and the problem it indirectly references is fixed in develop.
Repository: stellargraph/stellargraph

Issue #996: Error in `test_normalize_adj`
Created: 2020-03-03T01:39:26Z
Describe the bug
The test_normalize_adj test asserts that the sum of a symmetrically normalised matrix is equal to the number of non-isolated nodes. This is not correct, but due to a large tolerance this test will only occasionally fail.
Similar to #542
To Reproduce
Steps to reproduce the behavior:
Run multiple times:
pythom -m pytest tests/core/test_utils.py
Observed behavior
E       assert 5 == 4.5255656242370605 ± 4.5e-01
E        +  where 4.5255656242370605 ± 4.5e-01 = <function approx at 0x1056019d8>(4.5255656, 0.1)
E        +    where <function approx at 0x1056019d8> = pytest.approx
E        +    and   4.5255656 = <bound method matrix.sum of matrix([[0.49999997, 0.31622776, 0.        , 0.        , 0.        ,\n         0.        ],....        ],\n        [0.        , 0.        , 0.        , 0.        , 0.        ,\n         0.        ]], dtype=float32)>()
E        +      where <bound method matrix.sum of matrix([[0.49999997, 0.31622776, 0.        , 0.        , 0.        ,\n         0.        ],....        ],\n        [0.        , 0.        , 0.        , 0.        , 0.        ,\n         0.        ]], dtype=float32)> = matrix([[0.49999997, 0.31622776, 0.        , 0.        , 0.        ,\n         0.        ],\n        [0.31622776, 0.1999...0.        ],\n        [0.        , 0.        , 0.        , 0.        , 0.        ,\n         0.        ]], dtype=float32).sum

Expected behavior
The test passes.
Environment
Operating system: macOS
Python version: 3.6
Package versions: stellargraph develop

Duplicate issue #837: Flaky test: test_normalize_adj in tests.core.test_utils sometimes fails
Created: 2020-02-10T21:31:05Z
Describe the bug
In https://buildkite.com/stellar/stellargraph-public/builds/1203, the test_normalize_adj test failed due to an assertion failing.
To Reproduce
Steps to reproduce the behavior:

Run the test many times?

Observed behavior
example_graph = 

    def test_normalize_adj(example_graph):
        node_list = list(example_graph.nodes())
        Aadj = example_graph.to_adjacency_matrix()
        csr = normalize_adj(Aadj)
        dense = csr.todense()
>       assert 5 == pytest.approx(dense.sum(), 0.1)
E       assert 5 == 3.982050657272339 ± 4.0e-01
E        +  where 3.982050657272339 ± 4.0e-01 = (3.9820507, 0.1)
E        +    where  = pytest.approx
E        +    and   3.9820507 = ()
E        +      where  = matrix([[0.25      , 0.25      , 0.25      , 0.        , 0.28867513,\n         0.        ],\n        [0.25      , 0.25  ...0.        ],\n        [0.        , 0.        , 0.        , 0.        , 0.        ,\n         0.        ]], dtype=float32).sum

tests/core/test_utils.py:39: AssertionError

Expected behavior
The test should never fail.
Environment
CI
Additional context
N/A

Closing comment (2020-03-06T04:03:40Z): I think this is a duplicate of #996, which was fixed in #997.
Repository: stellargraph/stellargraph

Issue #410: Add build() method to GCN and GAT
Created: 2019-05-29T04:19:40Z
Description
Change node_model() method of GCN and GAT classes into build() method, which automatically determines the model's purpose (node or link prediction) from the generator used to construct the model, and returns a corresponding tuple x_inp, x_out with the correct format.
Done Checklist (Development)

 build method added

 GCN.build()
 GAT.build()


 Deprecation warning added for node_model method
 tests updated
 Demos updated
 Branch and Pull Request build on CI
 Branch and Pull Request pass unit tests on CI
 Peer Code Review Performed
 Code well commented

Duplicate issue #439: Add build() method to GCN and GAT classes
Created: 2019-07-01T02:13:14Z
Description
This is a continuation of ticket #339, the aim is to add build() method to GCN and GAT classes.
User Story
As a: user of the library
I want: consistent interface to all model classes
so that: I can easily switch models with minimum code change
Done Checklist (Development)

 build method added

 GCN.build()
 GAT.build()


 tests updated
 Demos updated
 Branch and Pull Request build on CI
 Branch and Pull Request pass unit tests on CI
 Peer Code Review Performed
 Code well commented
 CHANGELOG updated

Closing comment (2019-07-17T01:13:36Z): Duplicate of #410
Repository: stellargraph/stellargraph

Issue #693: Generating embeddings for entire graphs
Created: 2020-01-19T16:32:38Z
Is there a way to generate embeddings for subgraphs/full-graphs ?

Duplicate issue #987: Representation of a graph in an unsupervised manner using GCN/RGCN
Created: 2020-02-28T11:27:08Z
Given a networkx graph G(it can be both directed and undirected), and a subgraph in it called SG, I want to find an embedding for the subgraph SG, using a RGCN(for directed)/GCN. My aim is to preserve the structural information  and get an embedding for SG.  Is there any way that could be done with this library?
Thank you very much.

Closing comment (2020-03-04T22:23:24Z): Hi @sbhttchryy, similar to #693, we don't explicitly have support for graph/subgraph embeddings, but a technique like computing unsupervised embeddings for nodes and combining them (e.g. mean) would be a way to get started.
We have an example of computing unsupervised embeddings for nodes with GraphSAGE in https://github.com/stellargraph/stellargraph/blob/v0.10.0/demos/embeddings/embeddings-unsupervised-graphsage-cora.ipynb . I suspect a similar technique should work for GCN if you replace GraphSAGELinkGenerator → FullBatchLinkGenerator, and GraphSAGE → GCN.
We don't currently have support for RGCN link prediction (link prediction is how the unsupervised tasks work), but heterogeneous link prediction can be performed with HinSAGE, via HinSAGELinkGenerator and the HinSAGE model, and so the notebook above could be adapted to use those too.
If you're interested in RGCN, another algorithm that may work is ComplEx, designed for "knowledge graphs"/triple-stores (https://stellargraph.readthedocs.io/en/v0.10.0/api.html#module-stellargraph.mapper.knowledge_graph). It's currently experimental because we don't have an example for it, but the tests do show a bit about how it can be used https://github.com/stellargraph/stellargraph/blob/v0.10.0/tests/layer/test_knowledge_graph.py . This algorithm is unsupervised, in a sense, because it only works with the triples that exist in the graph.
If your subgraph is small, another technique might be something based on optimal transport, such as the algorithms implemented in https://github.com/rflamary/POT .
Repository: stellargraph/stellargraph

Issue #945: Make `edge_splitter.py` compatible with directed graphs
Created: 2020-02-25T05:07:50Z
Description
Currently edge splitter only works with undirected graphs. This issue is to add support for directed graphs.
User Story
As a data scientist I want to generate batches of directed edges so that I can predict directed edges.
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation in repo
 CHANGELOG.md updated

Duplicate issue #1861: Edge Splitter for directed graphs
Created: 2021-02-03T15:45:28Z
Description
I'm training a link classification algorithm for a directed graph. However, when I try to use the stellargraph.data.EdgeSplitter.train_test_split module, I'm getting an error:
NetworkXNotImplemented: not implemented for directed type
This shouldn't be something too hard to solve since an edge splitter shouldn't be very different for a directed or an undirected graph.
User Story
As an ML engineer
I want to be able to use an edge splitter with an undirected graph
So that I can train link classification algorithms for undirected graphs.
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation on Google Docs  (if applicable)
 Documentation in repo
 Version number reflects new status
 CHANGELOG.md updated
 Team demo

Closing comment (2021-02-07T22:24:27Z): Thanks for filing an issue @rmant. This is a duplicate of #945 and so I'm going to close it in favour of that. That issue was filed as a result of experiments with directed edge-splitting in #879, which were removed as it wasn't clear how well they were working at all (#879 (comment)).  The changes made in that PR were fully reverted in 1a3af2b , but could be revived and tested explicitly.
Repository: stellargraph/stellargraph

Issue #1202: Improve documentation for how to download and run demos
Created: 2020-04-06T01:38:17Z
Description
Raised in #1171, our documentation does not clearly explain that demos are not installed via Conda or Pip and must be downloaded separately:


You can start working with the examples immediately in Google Colab or Binder by clicking the  and  badges within each Jupyter notebook. You can also run them locally, after installing StellarGraph. One of the following might be appropriate:


We need clear instructions on downloading the demos (as opposed to just installing demo dependencies).
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation on Google Docs  (if applicable)
 Documentation in repo
 Version number reflects new status
 CHANGELOG.md updated
 Team demo

Duplicate issue #1333: Opening a demo notebook locally can be tricky
Created: 2020-04-23T23:22:04Z
Describe the bug
When looking at an individual notebook on GitHub (or similar) it's usually not obvious how to open it in a local instance of jupyter. Opening it locally is a nice way to run and explore it, and may be easier to use as starting point for future work than running it in the cloud (which can require creating accounts, uploading data etc.).
(StellarGraph 1.0.0rc1 dogfooding.)

Closing comment (2020-04-24T03:59:02Z): Duplicate of #1202
Repository: stellargraph/stellargraph

Issue #1532: Add adjacency list grouped in a useful way for hinSAGE in the stellargraph class
Created: 2020-05-07T00:50:53Z
Description
Currently hinsage sampler creates its own adjancency cache but it would be good to have this feature be available as part of the StellarGraph class. Related to some of the other work that's proposed/underway for metapath2vec and optimising the format of the adjancency lists #522

Duplicate issue #679: Consider replacing the usage of `StellarGraph.adjacency_types` by extending other existing neighbourhood methods in `StellarGraph`
Created: 2020-01-15T00:46:33Z
Description
Currently, StellarGraph.adjacency_types is being used to do heterogeneous graph exploration, but we currently have this comment # XXX This has not yet been standardised in the interface. for this method and its functionality could probably just be achieved by extending the existing methods neighbors, in_nodes and out_nodes.
User Story
As a engineer / data scientist
I want to have one consistent set of methods to use for neighbourhood queries
So that it's easier to use, extend, maintain
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation on Google Docs  (if applicable)
 Documentation in repo
 Version number reflects new status
 CHANGELOG.md updated
 Team demo

Closing comment (2020-05-18T03:13:29Z): I think this relates to/is a duplicate of #1532.
Repository: stellargraph/stellargraph

Issue #627: Simplify and automate the release procedure
Created: 2020-01-08T23:48:20Z
#624 brought the release procedure inside the git repository.  Now we can streamline the procedure, and look at automating some parts with Buildkite.  (note this may overlap with #607)
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation on Google Docs  (if applicable)
 Documentation in repo
 Version number reflects new status
 CHANGELOG.md updated
 Team demo

Duplicate issue #660: Automate release procedure
Created: 2020-01-12T23:59:18Z
Description
This is an epic to capture tasks that automate the release procedure - moving them from manual steps to Buildkite.
Done Checklist

 Produced code for required functionality
 Tests written and coverage checked
 Code review performed
 Documentation on Google Docs  (if applicable)
 Documentation in repo
 Version number reflects new status
 CHANGELOG.md updated
 Team demo

Closing comment (2020-01-13T02:36:15Z): duplicate of #627
Repository: stephane/libmodbus

Issue #379: Only writing commands must be allowed in broadcast mode
Created: 2017-04-28T08:29:29Z
By reading again, https://github.com/stephane/libmodbus/blob/master/tests/unit-test-client.c#L497
I see the test isn't good because only write operations are allowed in broadcast mode
Extract from http://www.modbus.org/docs/Modbus_over_serial_line_V1_02.pdf page 7/44:
No response is returned to broadcast requests sent by the master. The broadcast requests are necessarily writing commands. All devices must accept the broadcast for writing function. The address 0 is reserved to identify a broadcast exchange.

Duplicate issue #676: Broadcasting when RTU master...
Created: 2023-01-02T22:05:47Z
When one is targeting slaves with MODBUS_BROADCAST_ADDRESS and say you issue modbus_write_registers,
the code after sending a frame still goes through
if (rc > 0) {
uint8_t rsp[MAX_MESSAGE_LENGTH];
    rc = _modbus_receive_msg(ctx, rsp, MSG_CONFIRMATION);
    if (rc == -1)
        return -1;

    rc = check_confirmation(ctx, req, rsp, rc);
}

Shouldn't one bypass waiting for response as one isn't expected?
Regards
Dean

Closing comment (2023-07-30T09:42:56Z): This is actually dupe of #379 which has a PR #467 to fix this!
Repository: stephane/libmodbus

Issue #133: Socket brutally closed by peer not correctly detected
Created: 2013-06-28T12:10:07Z
libmodbus v3.0.3 on windows
scenario:
A client is configured with MODBUS_ERROR_RECOVERY_LINK  and MODBUS_ERROR_RECOVERY_PROTOCOL as recovery mode.
The client opens a tcp connection with a server and sends modbus request in a while loop. Unexpectedly the server crashes. As documented the client should tries to close and re-open the connection. Unfortunately it is not the case. it simply sleep and flush.
The reason is the errno code sent back is 0.
PS:
Is the
if ((errno == EBADF || errno == ECONNRESET || errno == EPIPE)) {...} in modbus.c really necessarry ?

Duplicate issue #349: errno not reliable on Windows
Created: 2016-08-08T14:54:22Z
libmodbus 3.1.4, OS Windows 7, mingw 4.9.2.
Errors in Windows socket functions do not set errno - instead you must call WSAGetLastError() to find what error occurred.
There are no calls to WSAGetLastError() in code except in _connect(). So Windows user can't check errors by errno (some errors can, other can't).

Closing comment (2017-06-21T05:07:09Z): Related to #133
Repository: stephane/libmodbus

Issue #349: errno not reliable on Windows
Created: 2016-08-08T14:54:22Z
libmodbus 3.1.4, OS Windows 7, mingw 4.9.2.
Errors in Windows socket functions do not set errno - instead you must call WSAGetLastError() to find what error occurred.
There are no calls to WSAGetLastError() in code except in _connect(). So Windows user can't check errors by errno (some errors can, other can't).

Duplicate issue #571: Error codes on Windows
Created: 2020-12-23T17:41:37Z
Error codes are not consistent on Windows implementation, when compared to other platforms.
Some of functions are setting errno, some are setting Windows-specific error codes that can be used with GetLastError().
The user needs to be familiar with internal workings of APIs in order to know which error code is returned in which case.
This then results in kludges like this:
int ret = some API call that may fail
unsigned int err;
if(ret < 0)
{
if(errno)
err = (unsigned int)errno;
else
err = GetLastError();
}
There are two possbile fixes - either only use errno and forget Windows error codes, or do a mapping of Windows error codes so that modbus_strerror() will return something usable when an error happens.

Closing comment (2022-09-27T22:23:59Z): Duplicate #349
Repository: stephane/libmodbus

Issue #211: OSX linking problem
Created: 2014-03-27T22:53:03Z
It seems I 'did the dance' and installed the source files properly onto OSX 10.8 (MLion). But whenever I try to compile a very small program I made (named modbus1.c) I get the following complaint from the linker:
cc -Wall -g     modbus1.c   -o modbus1
Undefined symbols for architecture x86_64:
"_modbus_close", referenced from:
_main in modbus1-248490.o
"_modbus_connect", referenced from:
_main in modbus1-248490.o
"_modbus_free", referenced from:
_main in modbus1-248490.o
"_modbus_new_tcp_pi", referenced from:
_main in modbus1-248490.o
"_modbus_read_bits", referenced from:
_main in modbus1-248490.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [modbus1] Error 1
Sooo, where should I be looking to try and resolve this issue? Thanks!
Niko

Duplicate issue #212: cross compile for ARM?
Created: 2014-04-04T18:25:17Z
Hi,
I am having trouble cross-compiling (using arm-linux-gcc) the libmodbus library for an ARM based machine. I am using pkg-config... and getting: "cannot find -lmodbus"  and "collect2: ld returned 1 exit status".
details could be found here:
http://stackoverflow.com/questions/22851209/arm-linux-gcc-compiler-linking-file-could-not-be-found
Any guidance would be appreciated!
Niko

Closing comment (2014-04-19T22:41:59Z): It isn't an issue with libmodbus but your dev environment (related to #211)
Repository: stephane/libmodbus

Issue #573: Libmodbus supports RTU host, slave and modbustcp. If they are used in RTOS at the same time, are they mutually exclusive?
Created: 2021-01-05T09:57:51Z
Libmodbus supports RTU host, slave and modbustcp. If they are used in RTOS at the same time, are they mutually exclusive?
I'm at RT_ Thread is used at the same time, but the system will crash after running for a long time. The prompt position is "RT thread / SRC / IPC. C: 929, RT_ mutex_ release；/packages/libmodbus-latest/examples/modbus_ tcp_ test.c:224 ，FD_ SET(server_ fd, &readset);“
I wonder if it is because they are not mutually exclusive, and there is a conflict between modbustcp and RTU?

Duplicate issue #574: Libmodbus supports RTU host, slave and modbustcp. If they are used in RTOS at the same time, are they mutually exclusive?
Created: 2021-01-05T09:59:24Z
Libmodbus supports RTU host, slave and modbustcp. If they are used in RTOS at the same time, are they mutually exclusive?
I'm at RT_ Thread is used at the same time, but the system will crash after running for a long time. The prompt position is "RT thread / SRC / IPC. C: 929, RT_ mutex_ release；/packages/libmodbus-latest/examples/modbus_ tcp_ test.c:224 ，FD_ SET(server_ fd, &readset);“
I wonder if it is because they are not mutually exclusive, and there is a conflict between modbustcp and RTU?

Closing comment (2022-02-21T23:27:24Z): Duplicate of #573
Repository: stephenmcd/mezzanine

Issue #193: ifinstalled template tag
Created: 2012-04-11T01:57:49Z
I don't think this new template tag works properly. It appears to suppress {% include %} tags, but it doesn't do anything about other stuff placed between {% ifinstalled app %} and {% endifinstalled %}.

Duplicate issue #194: New {% ifinstalled %} doesn't work with compressor
Created: 2012-04-11T05:59:45Z
{% compress css %}
    {{ block.super }}

    <link rel="stylesheet" href="{{ STATIC_URL }}css/mezzanine.css">

    {% ifinstalled cartridge.shop %}
    <link rel="stylesheet" href="{{ STATIC_URL }}css/cartridge.css">
    {% ifinstalled %}
{% endcompress %}

FYI, the old is_installed works. Maybe is_installed, shouldn't be depreciated ?

Closing comment (2012-04-11T06:02:36Z): Yep it's broken - reported in #193 a few hours ago.
Should have a fix by tomorrow.
Repository: stephenmcd/mezzanine

Issue #705: TinyMCE 4
Created: 2013-06-21T12:47:28Z
TinyMCE 4 was released at 13 june 2013.
It's a project to switch to it or to choice between version 3 and 4 (on settings.py for example)?

Duplicate issue #1341: With tinymce4 the filebrowser lacks the "insert button" column
Created: 2015-07-02T19:14:57Z
tinymce3:

tinymce4:

project environment:
Mezzanine master (July 2, 2015)
Django 1.8.2

Closing comment (2015-07-05T13:56:09Z): Should be resolved by both 1844176 and stephenmcd/filebrowser-safe@a5e6f12 as also reported in #705
Repository: stephenmcd/mezzanine

Issue #1058: Automatic image thumbnailing fails for images outside MEDIA_ROOT
Created: 2014-06-25T04:26:57Z
I have a site where I include an image in a Rich Text Field from a file system location outside MEDIA_ROOT (because said image lives in a Django app, and I need to keep it in version control). The new automatic thumbnailing tries to create a thumbnail in the image's container folder, but fails because it lacks the permissions. This will result in an error and completely prevent the page from rendering.
Additionally, if a user tries to embed an image from a third-party site, the page will load normally, but the image src will have been prepended with /static/media, resulting in something like src="/static/media/http://foo.bar/image.jpg", which of course is not a valid file path, and no image is displayed.

Duplicate issue #1060: thumbnail tag generate an error
Created: 2014-06-27T14:36:12Z
When I follow the link to the RSS feed for my mezzanine blog on my site, the page generate a server error. Permission denied when the thmubnail tag is trying to create a subfolder inside media.
thumb_dir = os.path.join(settings.MEDIA_ROOT, image_dir,
                         settings.THUMBNAILS_DIR_NAME, image_name)

https://github.com/stephenmcd/mezzanine/blob/master/mezzanine/core/templatetags/mezzanine_tags.py#L275
This happens when the URL passed to the thumbnail() tag is a full URL.
This is because the image_dir contains all the URL up to the filename. For instance, if image_URL = http://www.site.com/path/image.gif the function will try to create a folder http://www.site.com/path/ under media.

Closing comment (2014-06-27T21:08:50Z): Probably a duplicate of #1058
Repository: stephenmcd/mezzanine

Issue #603: Images uploaded to custom folder are not displayed in gallery
Created: 2013-03-19T22:25:36Z
Images uploaded to custom folder are not displayed in gallery. There's missing slash between custom gallery folder and filename:
static/media/galleries/folderimage.png

Duplicate issue #612: Blog posts Featured Image wrong path
Created: 2013-03-24T18:54:20Z
Hi guys, this is my first time here, in fact using mezzanine, i notice that "blog posts featured images" don't save the correct path of the images, well the correct path is there, just need a "/" after the final directory and the images name.
Right now this is how is saving:

Thanks Guys

Closing comment (2013-03-25T03:07:54Z): Ok thank you. Not sure what the fix is yet, but this is a duplicate of #603 so I'll close this for now.
Repository: stephenmcd/mezzanine

Issue #268: Thumbnail tag broken for jpgs (not libjpg related)
Created: 2012-06-10T16:17:36Z
In mezzanine.core.templatetags.mezzanine_tags, the thumbnail function saves its result with:
image = image.save(thumb_path, filetype, quality=quality, **image_info)
This works for PNGs. With a JPG, a size 0 output file is created. Removing the image_info argument seems to fix it, but I don't know enough about PIL to say why this is the case.
Here's the info dict for my test image:
{'jfif': 258, 'jfif_unit': 0, 'adobe': 100, 'progression': 1, 'progressive': 1, 'jfif_version': (1, 2), 'adobe_transform': 100, 'jfif_density': (100, 100)}

Duplicate issue #295: BLOG_USE_FEATURED_IMAGE issue
Created: 2012-07-03T16:28:24Z
Hello,
I am experiencing a problem with the thumb created for a .jpg file as a blog post featured image.
In the blog admin, I add an image named L1006771.jpg as the featured image and then save.
The I go the blog.
By default, Mezzanine adds a micro thumb at the right of the message summary. This works fine.
When I navigate to the blog message, I see the image displayed in a bigger version at the begining of the message.
This works the first time I visit the page.
The link to the image is
/media/uploads/gallery/L1006771.jpg
On any subsequent visit, the image is broken, the link has become
/media/uploads/gallery/.thumbnails/L1006771-600x0.jpg
I have noticed the x0 , I suppose there shoulb be a figure there. The file exists and is empty.
Could this be a PIL/PILLOW issue?
I have experienced the problem under freeBSD 9 and Ubuntu precise, both with PIL 1.1.7
Thanks for your feedback,
Diego

Closing comment (2012-07-03T20:53:08Z): Ok, txs very much. When you got the chance, could you tell me the file and
line where the thumb creation is done? Cheers
On Jul 3, 2012 10:44 PM, "Stephen McDonald" <
reply@reply.github.com>
wrote:

This is a duplicate of #268 which we should have a fix for soon.

Reply to this email directly or view it on GitHub:
#295 (comment)
Repository: stephenmcd/mezzanine

Issue #372: RichTextField TinyMCE not editable after order change in DyanmicTabularInline
Created: 2012-08-12T07:19:06Z
Another one :)
Django: 1.4.1
Mezzanine: 1.2.2
Browsers: Chrome 21, Firefox 14, Safari 5.1.7
Have two or more DyanmicTabularInlines with content, reorder, and the editor .mceIframeContainer is blank.  Content can still be edited by clicking fullscreen button.  But is un-editable otherwise.
Normal: td.mceIframeContainer > body.mceContentBody
Problem: td.mceIframeContainer > body (is blank)
Suspect executing tinyMCE.init via a "post order" event may fix issue.  Issue may also have something to do with http://www.tinymce.com/wiki.php/Configuration:add_form_submit_trigger

Duplicate issue #1046: RichtextField does't work correct in TabularDynamicInlineAdmin
Created: 2014-06-11T09:02:29Z
If inline Orderable model contains mezzanine.core.fields.RichTextField:

last field in inlines is not editable
after drag-drop text in RichText field lost and fields not editable
animation is not correct

Tesded in Firefox 29
Example app:
class Book(Orderable, AdminThumbMixin):
    title = models.CharField(max_length=128)
    cover = models.ImageField("Book Cover", upload_to="book/photo")

    admin_thumb_field = "cover"


class Review(Orderable):
    text = RichTextField()
    book = models.ForeignKey(Book)

class ReviewInline(TabularDynamicInlineAdmin):
    model = Review
    limit = 2

class BookAdmin(admin.ModelAdmin):
    inlines = [ReviewInline]

Closing comment (2014-06-11T11:42:05Z): Duplicate of #372
Repository: stephenmcd/mezzanine

Issue #592: Django 1.5 custom user model not supported
Created: 2013-03-07T19:34:43Z
I am running Django 1.5, Mezzanine 1.4.3, and I am using a custom user model defined in my settings.py. The South migration core:0004_set_site_permissions fails in this situation because it requires the auth.User model.

Duplicate issue #626: migrating to 1.4.5 breaks with django 1.5 and auth_user_model
Created: 2013-04-06T17:01:09Z
When using the AUTH_USER_MODEL feature of django 1.5, migrating to mezzanine 1.4.5 results in the error when south tries to complete migration 0014_auto__add_field_rating_user.
The latest version of South properly creates the migration with the auth user model that is specified in by the application.

Closing comment (2013-04-07T00:05:23Z): Duplicate of #592