Repository: prettier/plugin-php

Issue #273: Comments in nested array definitions move and drop commas
Created: 2018-03-30T17:05:36Z
You guys are going to murder me for my nested arrays :)
Input:
<?php
$array = [
    'type'      => [],
    'config'    => [
        // comments in nested arrays break things
        'key' => 1,
    ],
    'accepted'  => [],
];
Output:
<?php
$array = [
    'type' => [],
    'config' => ['key' => 1]
    // comments in nested arrays break things,
    'accepted' => []
];
Expected Output (probably?):
<?php
$array = [
    'type' => [],
    'config' => [
        // comments in nested arrays break things
        'key' => 1
    ],
    'accepted' => []
];
Notice two problems: the comment moved, and also a separating comma moved to the end of the comment.  The latter of course causes a syntax error.

Duplicate issue #279: Parser errors when running prettier with `--debug-check`
Created: 2018-03-31T14:59:50Z
I've been testing our plugin on the symfony codebase. The output looks fine when I don't include --debug-check, but when I do I get many errors like this one:
[error] ../symfony/src/Symfony/Component/BrowserKit/Client.php: SyntaxError: Parse Error : syntax error, unexpected '}', expecting ';' on line 222
[error]     at parser.raiseError (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser.js:290:17)
[error]     at parser.error (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser.js:335:15)
[error]     at parser.expectEndOfStatement (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser.js:360:10)
[error]     at parser.read_statement (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:387:14)
[error]     at parser.read_inner_statement (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:186:21)
[error]     at parser.read_inner_statements (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:86:30)
[error]     at parser.read_code_block (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:401:14)
[error]     at parser.read_statement (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:196:21)
[error]     at parser.read_if (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/if.js:42:19)
[error]     at parser.read_statement (/home/christian/dev/plugin-php/node_modules/php-parser/src/parser/statement.js:199:21)

Source code:
<?php
/*
 * This file is part of the Symfony package.
 *
 * (c) Fabien Potencier <fabien@symfony.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Symfony\Component\BrowserKit;
/**
 * @author Fabien Potencier <fabien@symfony.com>
 */
class Response
{
    protected $content;
    protected $status;
    protected $headers;
    /**
     * The headers array is a set of key/value pairs. If a header is present multiple times
     * then the value is an array of all the values.
     *
     * @param string $content The content of the response
     * @param int    $status  The response status code
     * @param array  $headers An array of headers
     */
    public function __construct(string $content = '', int $status = 200, array $headers = array())
    {
        $this->content = $content;
        $this->status = $status;
        $this->headers = $headers;
    }
    /**
     * Converts the response object to string containing all headers and the response content.
     *
     * @return string The response with headers and content
     */
    public function __toString()
    {
        $headers = '';
        foreach ($this->headers as $name => $value) {
            if (is_string($value)) {
                $headers .= $this->buildHeader($name, $value);
            } else {
                foreach ($value as $headerValue) {
                    $headers .= $this->buildHeader($name, $headerValue);
                }
            }
        }
        return $headers."\n".$this->content;
    }
    /**
     * Returns the build header line.
     *
     * @param string $name  The header name
     * @param string $value The header value
     *
     * @return string The built header line
     */
    protected function buildHeader($name, $value)
    {
        return sprintf("%s: %s\n", $name, $value);
    }
    /**
     * Gets the response content.
     *
     * @return string The response content
     */
    public function getContent()
    {
        return $this->content;
    }
    /**
     * Gets the response status code.
     *
     * @return int The response status code
     */
    public function getStatus()
    {
        return $this->status;
    }
    /**
     * Gets the response headers.
     *
     * @return array The response headers
     */
    public function getHeaders()
    {
        return $this->headers;
    }
    /**
     * Gets a response header.
     *
     * @param string $header The header name
     * @param bool   $first  Whether to return the first value or all header values
     *
     * @return string|array The first header value if $first is true, an array of values otherwise
     */
    public function getHeader($header, $first = true)
    {
        $normalizedHeader = str_replace('-', '_', strtolower($header));
        foreach ($this->headers as $key => $value) {
            if (str_replace('-', '_', strtolower($key)) === $normalizedHeader) {
                if ($first) {
                    return is_array($value) ? (count($value) ? $value[0] : '') : $value;
                }
                return is_array($value) ? $value : array($value);
            }
        }
        return $first ? null : array();
    }
}
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/BrowserKit/Response.php

Closing comment (2018-03-31T20:42:48Z): Ah ya maybe it was similar to #273, which would have caused an error when parsing the 2nd time