primordic/IssueDupesLite huggingface dataset:
Repository: avahi/avahi

Issue #546: Initial probe queries with type ANY should use QU and not QM flag
Created: 2024-01-05T19:53:10Z
v0.8 sends initial probe queries with QM (multicast reply expected) instead of QU (unicast reply expected).
To avoid unnecessary responses, Multicast DNS defines the top bit in the class field of a DNS question as the unicast-response bit.
When this bit is set in a question, it indicates that the querier is willing to accept unicast replies in response to this specific query.
See RFC6762 section 5.4 and 8.1.
Section 8.1 (Probing) states: "... Because of the mDNS multicast rate-limiting rules, the probes SHOULD be sent as "QU" questions with the unicast-response bit set, to allow a defending host to respond immediately via unicast, instead of potentially having to wait before replying via multicast."
Therefore, to be compliant with RFC6762 section 8.1, initial probes with type ANY should have the unicast-response bit set to 1.
Maybe, there is a strong reason to not follow the advice to reduce the number of responses when doing probes?
Anyone here, who can shed some light on it?

Duplicate issue #131: Response bit
Created: 2017-07-11T15:49:48Z
Does anyone know how to set the response bit?
I need Avahi to reply to both QU and QM questions.

Closing comment (2024-02-29T21:17:25Z): Does anyone know how to set the response bit?

It depends on what is used to send queries. dns-sd provides https://developer.apple.com/documentation/dnssd/1823436-anonymous/kdnsserviceflagsunicastresponse but it's a no-op nowadays as far as I can tell and the first query is always a "QU" query there.
avahi doesn't send "QU" queries. It's possible to build a packet with the "QU" bit set using avahi_dns_packet_append_key though.

I need Avahi to reply to both QU and QM questions.

avahi can reply to those queries as long as the bit is set or unset.
"QU" queries are kind of tracked in #546 so I'll go ahead and close this issue.
Repository: avahi/avahi

Issue #315: avahi fails if avahi-daemon.conf file has any line that exceeds 255 characters
Created: 2020-12-22T13:56:12Z
avahi daemon fails with an error if any line in the conf file exceeds 255 characters, including comment lines.  I traced the problem to ini-file-parser.c where 256 bytes is allocated on the stack to hold each line.  As a quick fix I bumped it up to 1024 and that solved my problem.
The reason I exceeded 255 characters is because I use reflect-filters and with that it is quite easy to have a long line length if you have several different types of devices you want to reflect across LAN subnets.
Thanks
DAK.

Duplicate issue #433: avahi stops working with reflect-filters=..
Created: 2023-01-09T15:16:07Z
Hi, i using avahi and when i set the following filters:
reflect-filters=_airplay._tcp,_hap._tcp,_home-assistant._tcp,_hue._tcp,_ipp._tcp,_ipps._tcp,_mieleathome._tcp,_pdl-datastream._tcp,_print-caps._tcp,_printer._tcp,_raop._tcp,_rdlink._tcp,_scanner._tcp,_sleep-proxy._udp,_spotify-connect._tcp,_uscan._tcp,_companion-link._tcp it stops working while when i set
reflect-filters=_airplay._tcp,_hap._tcp,_home-assistant._tcp,_hue._tcp,_ipp._tcp,_ipps._tcp,_mieleathome._tcp,_pdl-datastream._tcp,_print-caps._tcp,_printer._tcp,_raop._tcp,_rdlink._tcp,_scanner._tcp,_sleep-proxy._udp,_spotify-connect._tcp,_uscan._tcp
it works just fine.
I can exchange the last entry if i want, so i guess there is a number of character limitation somehow (256Chars)? Can this be extended or can a blacklist instead of a whitelist been added ? thanks !

Closing comment (2023-06-04T19:16:01Z): Looks like it's a duplicate of #315.
Repository: avahi/avahi

Issue #2: Bonjour Conformance Test does not pass
Created: 2015-04-01T03:29:53Z
Balaji X. Srinivas bxsrinivas@... writes:
I figured out why avahi-0.6.31 package fails the apple bonjour conformance
test(v1.3.0) for test case SRV PROBING/ANNOUNCEMENTS.
The Bonjour conformance test requires that the hostname and service name on
the device be resolved at the same time during one point.However avahi
package waits until the hostname is resolved before resolving the service
names.
And also noticed one thing that when device in the state of resolving the
hostname,device could not probe service with new name though it logged info
message as service name conflict.
And so the bonjour test logs following,
"SRV Probing: Device didn't send a new probe after test issued a probe
denial in response to device's previous query".
And also verified on more case like, when device gets locked to hostname
and then device should be able to probe SRV successfully.
I am yet to figure out the actual requirement of this with RFC document.
ref also: https://bugs.launchpad.net/ubuntu/+source/avahi/+bug/1409872

Duplicate issue #89: avahi-autoipd not fast enough to pass BCT tests
Created: 2016-11-16T17:26:20Z
Running avahi 0.6.32 for Bonjour Conformance tests and getting failures for Cable Change Handling test.
The operator disconnects and reconnects the device.  The test tool verifies that the device repeats its address probing to verify that its address is still unique.  The test tool denies the first probe and verifies that the device picks a new address and probes/announces again.
So once we reassociate the device with network, avahi-autoipd goes to starting state very late, it claims the ip address only after the BCT test ends, So it could never catch this conflicting IP and try to pick a new one.
Note that if i run it as a daemon in the background, it never catches the conflict.
I had to manually kill the autoipd daemon and start it manually before the test started. In that case it passes the test.
Same problem occurs in initial probing too, autoipd does not go to probing state unless i reboot the device or reconnect it to the network.
Do you have any suggestions or a fix for short term in order to fully support BCT? Is there any successful combination of avai and autoipd configuration to make it pass all tests?

Closing comment (2018-09-11T09:09:45Z): This is not really a duplicate of #2 although it is another issue related to Bonjour Conformance tests.
I have found with the latest BTCs, and avahi 0.7, that this test is passed.
Do you leave avahi-autoipd running while the network is disconnected? In my case it is stopped, and restarted when the network link comes back up, after first trying DHCP. This is all within any tester timeouts.
Repository: avajs/ava

Issue #798: Profile script not working
Created: 2016-04-28T19:32:41Z
When running devtool node_modules/ava/profile.js test.js it's throwing:
Uncaught TypeError: 
/Users/sindresorhus/dev/ava/profile.js
(intermediate value).generateHashForFile is not a function(anonymous function) @ profile.js:71Module._compile @ module.js:425devtoolCompileModule @ /usr/local/lib/node_modules/devtool/lib/require-hook.js:30Module.load @ module.js:356Module._load @ module.js:313Module.require @ module.js:366require @ module.js:385(anonymous function) @ /usr/local/lib/node_modules/devtool/lib/preload.js:76emitOne @ events.js:77emit @ events.js:169

// @jamestalmage

Duplicate issue #803: How to use with iron-node?
Created: 2016-05-02T11:33:12Z
Is there any support for using ava together with tools like iron-node or would jasmine/mocha/tap be a better fit then?

Closing comment (2016-05-06T02:31:26Z): Closing as a duplicate of #798.
Fix is in #812
Repository: avajs/ava

Issue #974: ava overrides `source-map-support` of `babel-register`
Created: 2016-07-20T14:47:38Z
If I transpile imported modules with babel-register, stack traces of the imported modules are not correctly reported becauseava overrides source-map-support of babel-register.
This is due to the dependency mismatch between ava and babel-register. babel-register depends on source-map-support 0.2.10 and ava depends on the version 0.4.0, making the both use the different source-map-supports so one overriding Error.prepareStackTrace.
When I bump source-map-support in babel-register (babel/babel#3571), the issue goes away.
Config
{
  "ava": {
    "require": [
      "babel-register"
    ],
    "babel": "inherit"
  ...
  }
}

Duplicate issue #1805: Source map issue
Created: 2018-05-17T17:49:09Z
I use babel to compile a file - and then in my tests I require it.
e.g. const myLibrary = require('../lib'); and lib/index.js is compiled from src/index.js
my babel config:
{
  "presets": [
    ["@babel/env", {
      "targets": {
        "node": "6.4.0"
      }
    }]
  ],
  "plugins": [ "@babel/transform-runtime", "@babel/plugin-proposal-object-rest-spread" ],
  "sourceMaps": "inline"
}

curious why the stack traces from ava are showing from lib/index.js versus src/index.js?
I looked at bottom of lib/index.js and I see the inline source map comments

Closing comment (2018-05-18T17:06:15Z): this is a duplicate of #974 - the issue has existed for quite some time (but most likely because of istanbul/nyc source mapping)
Repository: avajs/ava

Issue #1584: Stack trace / source map issues
Created: 2017-11-12T16:37:38Z
I think this is due to using Babel.  If you're writing a pure JS function/class to write tests with Ava against, then the stack traces/source mapping is off.  For example, a bug occurs on 166 of my file index.js, however the stack trace output shows line 4.
  TypeError: Cannot set property 'log' of undefined
      at Object.keys.forEach.key (/Users/user/Projects/cabin/index.js:4:666)
      at Array.forEach (<anonymous>)
      at Cabin.middleware (/Users/user/Projects/cabin/index.js:4:582)
      at dispatch (/Users/user/Projects/cabin/node_modules/koa-compose/index.js:42:32)
      at /Users/user/Projects/cabin/node_modules/koa-compose/index.js:34:12
      at Application.handleRequest (/Users/user/Projects/cabin/node_modules/koa/lib/application.js:150:12)
      at Server.handleRequest (/Users/user/Projects/cabin/node_modules/koa/lib/application.js:132:19)
      at emitTwo (events.js:126:13)
      at Server.emit (events.js:214:7)
      at parserOnIncoming (_http_server.js:602:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)

Duplicate issue #974: ava overrides `source-map-support` of `babel-register`
Created: 2016-07-20T14:47:38Z
If I transpile imported modules with babel-register, stack traces of the imported modules are not correctly reported becauseava overrides source-map-support of babel-register.
This is due to the dependency mismatch between ava and babel-register. babel-register depends on source-map-support 0.2.10 and ava depends on the version 0.4.0, making the both use the different source-map-supports so one overriding Error.prepareStackTrace.
When I bump source-map-support in babel-register (babel/babel#3571), the issue goes away.
Config
{
  "ava": {
    "require": [
      "babel-register"
    ],
    "babel": "inherit"
  ...
  }
}

Closing comment (2018-05-17T18:10:23Z): Probably related to #1584 and #1805
Repository: avajs/ava

Issue #2217: Consolidate mini and verbose reporters
Created: 2019-08-18T12:44:18Z
Currently we have two different reporter implementations. Code is duplicated across them which leads to various bugs. I once tried to consolidate them but that work stalled.
The idea is that we would have only one reporter. By default it provides minimal output. We show a spinner and the status of the last test, so you get a sense of activity, and once an entire test file completes do we print failures. In verbose mode, we'd print the results of all tests & hooks, including logs. Various counts for passing and failing tests are always shown at the end of the output.
If a TTY is not available, we wouldn't print a spinner and only write the appropriate output for a test file once it completes.
We'd use ink to construct the output.

Duplicate issue #1917: Horizontal rule between successful runs with logs
Created: 2018-08-24T18:48:34Z
In watch mode, if you log something in your code while working on tests, it will look like this:
# ... previous failures ...
─────────────────────────────────────
'logged value'

  1 passed [11:44:22]
On the next run it will look like this:
# ... previous failures ...
─────────────────────────────────────
'logged value'
'logged value'

  1 passed [11:44:32]
This is okay for small values like 'logged value', but when you are logging lots of things including large objects it would be nice for some visual separation.
What if AVA added another horizontal rule in between sets of logs?
# ... previous failures ...
─────────────────────────────────────
'logged value'
─────────────────────────────────────
'logged value'

  1 passed [11:44:32]
This would make it much more clear what run the logs were from.


There is a $40.00 open bounty on this issue. Add more on Issuehunt.

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on Issuehunt to raise funds.

Closing comment (2020-05-12T09:35:30Z): @novemberborn You referenced this issue in #2217, but it seems like this enhancement isn't related to #2217, isn't it? I feel like this issue should be marked as blocked, since we cannot work on this issue, as long we haven't closed #2217.
Repository: avajs/ava

Issue #2252: trying to install ava for contributing to the 100% coverage
Created: 2019-09-18T15:34:14Z
I forked the repo and then cloned my version to my computer.
I then update it to get up to date with your version.
When I try to run npm install I get the following error:
Error: EACCES: permission denied, open '/Users/danhuang/.npm/_cacache/index-v5/24/8a/b67c8c7ae732e85fdb0b589b0f4936e49e40b919175e011731b0021c0ece'

using node version
10.16.3
I have read through the contribution guide and haven't seen any other instructions related to getting this project setup.
Can we get a guide on setting up the environment for contributing?
I checked the readme and we only have one for getting the repo setup for testing purposes in other projects.
Thanks!

Duplicate issue #2254: still experiencing issue with this repo and a permission issue related to npm
Created: 2019-09-19T18:47:09Z
Hi,
I opened an issue yesterday about trying to get this project installed on my local machine for contributing.
The error I am getting is related to npm and when I researched into it, the responses were related to having installed an npm package via sudo which I haven't done.
I am also not experiencing any issues with getting other npm packages installed for other projects so I don't think this is an issue on my end.
Thanks

Closing comment (2019-09-19T19:06:56Z): Duplicate of #2252
Repository: avajs/ava

Issue #324: Include assertions in TAP output
Created: 2015-12-11T21:22:38Z
While I was working on TAP support, I realized reporters want to know the assertions for each test. At the moment, test title just duplicated as an assertion.

As you see on the screenshot, it results in a double test title.
It happens in tap-spec, tap-difflet & tap-min reporters at least. Other reporters are ok.
So what we need now, is to collect information about each test's assertions (in Test class), so that we output meaningful results for TAP reporters. Plus, it would probably benefit future integrations (e.g. with text editors).

Duplicate issue #679: TAP report prints test titles above not ok message
Created: 2016-03-23T15:01:18Z
Description
The TAP report prints the failing assertion rather than the title of the test after the not ok message. If I have a test file test.js that reads:
import { test } from 'ava';

test('one should equal two', t => {
  t.is(1, 2);
});

and I run ava --tap, the resulting TAP report looks like this:
TAP version 13
# one should equal two
not ok 1 - 1 === 2
  ---
    operator: ===
    expected: 2
    actual: 1
    at: _callee$ (test.js:4:4)
  ...

1..1
# tests 1
# pass 0
# fail 1

This is an issue because I am using a Jenkins TAP Plugin that reports the titles of the tests incorrectly, as it interprets 1 - 1 === 2 as the name of the test. I would expect the TAP report to look like this:
TAP version 13
# one should equal two
not ok 1 - one should equal two
  ---
    operator: ===
    expected: 2
    actual: 1
    at: _callee$ (test.js:4:4)
  ...

1..1
# tests 1
# pass 0
# fail 1

If this is an issue with a dependency of ava and not with ava itself, please direct me to that project instead and I'll be happy to file an issue there.
Thanks in advance!
Environment
Node.js v5.9.0
darwin 14.5.0

Closing comment (2016-04-05T17:46:15Z): Yeah - This is a legit issue. Related to #324, but not identical. I have tap-emitter in the works.
help wanted!
Repository: avajs/ava

Issue #520: Adding support for a dedicated configuration file
Created: 2016-02-07T02:45:46Z
I'm not sure how viable this is currently due to the way pkg-conf is walking up until it finds a package.json file, but it would be nice to be able to set ava config in an .avarc file in the root of the project.
I'm not a huge fan of keeping config in my package.json or of overly verbose cli commands in scripts config. This is also pretty common practice with other tooling frameworks so I don't think it's too crazy of an idea.
I think an initial approach could be to check the current working directory for a .avarc file and if not found fall back to pkgConf.sync.
I would be more than willing to put together a PR if this seems like something you find appealing.

Duplicate issue #1626: [PROPOSAL] Support a "ava.config.js" file to make config portable
Created: 2018-01-03T22:03:32Z
Description
I propose that ava support a configuration file (e.g. ava.config.js) which is similar to the package.json configuration. This file would make it more obvious where configuration lives as well as making it more portable since the ava.config.jsfile could just be copied over to a new project; no editing of package.json needed. Plus, it's a bit of good marketing since people looking at the source of a project would notice the config file. Win-win-win.
There is a great package, cosmiconfig, which allows for both package.json config, ava.config.js and a .avarc file depending on the user's preferences. Prettier just added it and it makes adoption a lot easier for the end user.
Relevant Links

cosmiconfig

Closing comment (2018-01-03T22:32:59Z): Duplicate of #520
Repository: avajs/ava

Issue #1047: Simplify t.throws()
Created: 2016-09-23T13:53:07Z
This is my proposal for resolving #661. In short I want to stop deferring to https://nodejs.org/api/assert.html#assert_assert_throws_block_error_message and remove various parameter overloads that are currently supported by the assertion.
Here's what I'd like to support:
t.throws(fn) // Throws an Error (or subclass thereof)
t.throws(fn, SyntaxError) // Throws a SyntaxError (or subclass thereof)
t.throws(fn, 'string') // Throws an Error (or subclass thereof), whose .message === 'string'
t.throws(fn, /regexp/) // Throws an Error (or subclass thereof), whose /regexp/.test(err.message) === true
If you need to test the errors class and message you should use the t.throws return value:
const err = t.throws(fn, SyntaxError)
t.true(err.message === 'expecting integer')
Passing anything other than undefined, functions, strings or regular expressions as the second argument results in an TypeError from t.throws() itself.
The first argument is allowed to be a promise or observable, as is any return value from the fn call. Of course this makes t.throws asynchronous, so users may need to do:
const err = await t.throws(fn)

Questions:


Does t.throws(fn, Constructor) require the thrown value to be an Error? For example:
t.throws(() => { throw 'foo' }, String) // Is this allowed?


Should t.throws(fn, 'string') and t.throws(fn, /regexp/) be supported at all, or would it be preferable to dereference the error and then use another assertion?
const err = t.throws(fn)
t.true(err.message === 'expecting integer')


Is there a need for t.throws(fn, SyntaxError, 'string') and t.throws(fn, SyntaxError, /regexp/)


Does anybody have experience with / examples of asserting Error instances across contexts?

Duplicate issue #1362: Provide a convenience API for testing error constructor and message
Created: 2017-04-18T19:57:03Z
Description
The current API:
.throws(function|promise, [error, [message]])
only allows to define constructor of the error and requires to test message separately, e.g.
const error = await t.throws(createReservation(undefined, parameters, context), UserError);

t.true(error.message === 'Ticket selection cannot be empty.');

By the way, .throws(function|promise, [error, [message]]) is slightly misleading.
At first I thought the third parameter is the error message, i.e.
t.throws(createReservation(undefined, parameters, context), 'Ticket selection cannot be empty.');.

It would be convenient to be able to construct the error as such:
await t.throws(createReservation(undefined, parameters, context), new UserError(Ticket selection cannot be empty.));
In such case, ava would need to check that the constructor of the object and the message match.

Closing comment (2017-04-19T05:19:24Z): Duplicate of #1047. I agree it's currently sub-optimal. You should be able to assert the different specifics of an error in one assertion. See my proposal #1047 (comment) and add your thoughts there.
Repository: aws-amplify/amplify-flutter

Issue #3407: Login throws UserNot Confirmed even password is wrong
Created: 2023-07-12T13:00:30Z
Description
I have mandatory that every user needs to verified through their Email Address.
When anyone logs in, i need to detect if they are not verified and need to show the verification page (where they can type verification code), I am doing this by just Amplify.auth.login and catching UserNotConfirmed Exception. But the problem is it is throwing UserNotConfirmedException even the password is wrong, isnt the NotAuthorizedException needs to be thrown ?
Categories

 Analytics
 API (REST)
 API (GraphQL)
 Auth
 Authenticator
 DataStore
 Notifications (Push)
 Storage

Steps to Reproduce
No response
Screenshots
No response
Platforms

 iOS
 Android
 Web
 macOS
 Windows
 Linux

Flutter Version
3.7.12
Amplify Flutter Version
0.6.10
Deployment Method
Amplify CLI
Schema
No response

Duplicate issue #4170: AWS amplify wrong password while user is not verified
Created: 2023-11-21T17:29:16Z
Description
Here is the scenario, when user register with a given email address and password, then onto the verification process, but just at that step, when user leave that screen without verification of OTP. Next time user come again to register themself, error message occur that user is already registered, so user have to login and in this case, user next step is confirm sign up, but user can go ahead with login process with any password and next step will be a verification screen. In such scenarios, we need to reLogin user when user is verified from OTP screen which is kind of bad UX that is extra step in such case.
Kindly if someone can confirm this, and if there is any better alternative.
Categories

 Analytics
 API (REST)
 API (GraphQL)
 Auth
 Authenticator
 DataStore
 Notifications (Push)
 Storage

Steps to Reproduce
No response
Screenshots
No response
Platforms

 iOS
 Android
 Web
 macOS
 Windows
 Linux

Flutter Version
3.10.1
Amplify Flutter Version
1.6.0
Deployment Method
Amplify CLI
Schema
No response

Closing comment (2023-11-21T19:58:43Z): Hi @MuhammadMusa22, This issue looks like a duplicate of #3407. Please take a look at that issue and let me know if you have additional questions.
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #1471: Karpenter event_rules clash
Created: 2023-03-01T11:37:38Z
This new code has a static event_rules name.

  
    
      terraform-aws-eks-blueprints/modules/kubernetes-addons/karpenter/locals.tf
    
    
         Line 59
      in
      351b763
    
  
  
    

        
          
           name        = "HealthEvent" 
        
    
  


https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/351b763e/modules/kubernetes-addons/karpenter/main.tf#L52
so when more than one cluster is created, they will share the event_rule
if you look into the eks module, they use name_prefix which avoids this issue
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/c7565e26/modules/karpenter/main.tf#L270

Duplicate issue #1482: [Karpenter] Rule with the name already exists on this event bus.
Created: 2023-03-07T10:54:09Z
Description
We cannot create Event bridge rules when we deploy more than one cluster in the same region with this option. karpenter_enable_spot_termination_handling = true
Versions

Module version [Required]:
v4.25.0
Terraform version:
v1.3.9



Provider version(s):

+ provider registry.terraform.io/gavinbunney/kubectl v1.14.0
+ provider registry.terraform.io/hashicorp/aws v4.53.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.8.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.17.0
+ provider registry.terraform.io/hashicorp/local v2.3.0
+ provider registry.terraform.io/hashicorp/null v3.2.1
+ provider registry.terraform.io/hashicorp/tls v4.0.4
+ provider registry.terraform.io/terraform-aws-modules/http v2.4.1


Reproduction Code [Required]

  
    
      terraform-aws-eks-blueprints/modules/kubernetes-addons/karpenter/main.tf
    
    
         Line 40
      in
      e0e9aeb
    
  
  
    

        
          
           name          = each.value.name 
        
    
  



Steps to reproduce the behavior:



Expected behavior
should be able to create more than one cluster in the same region without conflict with the resources naming

Actual behavior
Rule with the name already exists on this event bus.

Closing comment (2023-03-14T23:04:34Z): As mentioned, this is dupe of #1471
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #452: [ADDON] - Istio Service Mesh
Created: 2022-04-21T09:12:07Z
Add support for Istio Service Mesh as an add-on.

Duplicate issue #488: [Addon] Istio
Created: 2022-04-29T17:16:20Z
Add support for Istio as an add-on for mTLS, telemetry, traffic management and Blue green deployment.
https://istio.io/latest/docs/

Closing comment (2022-04-29T17:29:01Z): Dup of #452 ?
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #1630: Started getting this error subdir "modules/kubernetes-addons/helm-addon" not found
Created: 2023-06-05T14:58:36Z
Everything was ok this morning but now started seeing this error
subdir "modules/kubernetes-addons/helm-addon" not found

Duplicate issue #1715: Error: subdir "modules/kubernetes-addons/helm-addon" not found
Created: 2023-08-03T04:04:02Z
I use v4.28.0.
I ran terraform init today.
It gave an error.
Please help me
Message: Error: subdir "modules/kubernetes-addons/helm-addon" not found

Closing comment (2023-08-04T20:39:49Z): @bryantbiggs could this issue be pinned and could this message be documented in the README.md ? A lot of people currently use the blue prints for the helm addons and people may not be ready to migrate just yet so this error may catch people off guard
Related issue (for visibility to link "from" rather than "to") #1421
Edit: Looks like this issue is a duplicate of #1630
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #493: [BLUEPRINT]Replace `gitlab-ci-cd` with an example that shows self-hosted GitLab on EKS
Created: 2022-05-01T14:51:41Z
Describe the solution you'd like

Replace https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/ci-cd/gitlab-ci-cd with an example that shows how to run self-hosted GitLab runners on EKS

Both EKS managed node groups and Fargate profiles since there are distinct differences in either route



The current example is not useful from a blueprint perspective - it currently appears to show how to use Terraform with GitLab as the backend which is more of a Terraform/GitLab concern than EKS/Blueprint concern. Instead, it would be more useful for users to see how they can use EKS Blueprints to run self-hosted GitLab runners on EKS using either an EC2 based route (EKS Managed node groups) or serverless route (Fargate profiles)

Duplicate issue #1272: Add the GitLab Runner Kubernetes addon
Created: 2022-12-21T12:05:50Z
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment


What is the outcome that you are trying to reach?
Deploy a GitLab Runner on the EKS cluster
Describe the solution you would like
Add the GitLab Runner Helm chart to the Kubernetes addons
Describe alternatives you have considered
Installing manually.
Additional context

Closing comment (2022-12-21T12:39:24Z): duplicate of #493
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #1394: Publish modules to terraform registry
Created: 2023-02-01T22:04:06Z
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment


What is the outcome that you are trying to reach?
I would like to use blueprints using traditional module import syntax like
module "eks-blueprints" {
  source  = "terraform-aws-modules/eks/blueprints"
  version = "19.6.0"
}

Today, I have to use git path source which is not as intuitive and harder to version. This option also has multiple options which are confusing to use and hard to get right.
module "eks-blueprints" {
  source = "github.com/aws-ia/terraform-aws-eks-blueprints//modules//kubernetes-addons?ref=v4.19.0"
}

Alternatively, I could use git::https://, git@github, or ssh:// syntax for the source which have different options and configuration (e.g. authentication) that add confusion. Because modules are in subfolders I also have to make sure I have // for folders and ?ref= needs to come at the end of the string. These strings become difficult to parse and update.
All of the examples are not portable because they use path based source and require me to locally clone the repo to use.
module "eks-blueprints" {
  source = "../.."
}

Describe the solution you would like
The modules should be published to a terraform module registry so they can be more easily discovered, consumed, and versioned.
Describe alternatives you have considered
All of the alternative options are described above
Additional context
Please

Duplicate issue #1408: Pin a version from Terraform source
Created: 2023-02-03T17:31:29Z
[ x] ✋ I have searched the open/closed issues and my issue is not listed.

Hi is there are was to pin to a version of a release?
I'd like to do something like the following
module "example {
    source = "github.com/aws-ia/terraform-aws-eks-blueprints"
    version = "4.22.0"
   .
   .
   ....
}  

Thank you,
Virath

Closing comment (2023-02-03T17:58:51Z): Duplicate of #1394
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #1477: Private Repository
Created: 2023-03-03T21:22:58Z
✋ I have searched the open/closed issues and my issue is not listed.

Please describe your question here
Hello,
When I fork these repos into a private repository:
https://github.com/aws-ia/terraform-aws-eks-blueprints
https://github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.25.0
https://github.com/aws-samples/eks-blueprints-add-ons.git
https://github.com/aws-samples/eks-blueprints-workloads.git
│ Error: Failed to download module
│
│ Could not download module "eks_blueprints" (main.tf:23) source code from "https://chielvis01:xxxxx@github.com:/chielvis01/blueprint-replica": error downloading
│ 'https://chielvis01xxxxx@github.com:/chielvis01/blueprint-replica': bad response code: 404
Q: how do I pass in the password or the secret_string to authenticate my private repos.
Note that when I fork the repos and leave them private, everything works fine.
Provide a link to the example/module related to the question

Duplicate issue #1476: Private Repository
Created: 2023-03-03T21:21:21Z
✋ I have searched the open/closed issues and my issue is not listed.

Please describe your question here
When I fork these repos into a private repository:
https://github.com/aws-ia/terraform-aws-eks-blueprints
https://github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.25.0
https://github.com/aws-samples/eks-blueprints-add-ons.git
https://github.com/aws-samples/eks-blueprints-workloads.git
│ Error: Failed to download module
│
│ Could not download module "eks_blueprints" (main.tf:23) source code from "https://echi01:xxxxx@github.com:/chielvis01/blueprint-replica": error downloading
│ 'https://echi01:xxxxx@github.com:/chielvis01/blueprint-replica': bad response code: 404
Q: how do I pass in the password or the secret_string to authenticate my private repos.
Note that when I fork the repos and leave them private, everything works fine.
Provide a link to the example/module related to the question

Closing comment (2023-03-14T23:03:17Z): Duplicate of #1477
Repository: aws-ia/terraform-aws-eks-blueprints

Issue #620: [FEATURE] [ADDON] Add Kyverno Addon
Created: 2022-06-10T10:40:22Z
Is your feature request related to a problem? Please describe
Kyverno can be used as admission controller to improve cluster security.
Describe the solution you'd like
I would like it to be easilly installed with a blueprint Add-On.

Duplicate issue #830: [FEATURE] Kyverno Add on
Created: 2022-08-09T00:13:11Z
Is your feature request related to a problem? Please describe
Please add support for the Kyverno admission controller https://github.com/kyverno/kyverno
Describe the solution you'd like
Enable out of the box policy compliance in EKS clusters.
Describe alternatives you've considered
I think of other open source or k8 native way of doing this.

Closing comment (2022-08-09T11:54:21Z): duplicate #620
Repository: aws/aws-sdk-pandas

Issue #1714: Remove upper bound on python_requires
Created: 2022-10-25T21:20:28Z
Describe the bug
Propose removing the upper bound on python requires to allow users to test with python 3.11 in their projects. The python requires upper bound ideally shouldn't be set unless there's a very specific reason to do so, this just happened to be the default poetry chose at some point, so many project seem to have adopted it.
Some interesting articles on why this might not be ideal:

https://iscinumpy.dev/post/bound-version-constraints/#Pinning%20the%20Python%20version%20is%20special
https://discuss.python.org/t/requires-python-upper-limits/12663

diff --git a/pyproject.toml b/pyproject.toml
index a36f685..3be566d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -25,7 +25,7 @@ classifiers = [
 ]

 [tool.poetry.dependencies]
-python = ">=3.7.1, <3.11"
+python = ">=3.7.1"

 boto3 = "^1.24.11"
 botocore = "^1.27.11"
p.s. I have attempted install on python 3.11 with the edited pyproject, some of the deps don't have wheels yet, so it might not be possible to test this in ci. That's seems fine though, just add the classifier once it is tested. At least users will be able to upgrade at their own pace without wrangler being a hard block for an odd choice by poetry once the wheels are released.
How to Reproduce
Include awswrangler as a dep and use python 3.11.
Expected behavior
To be able to run the test suites of our ~10 projects including awswrangler on python 3.11 to see what c extension dependencies may need wheels released still. Right now, wrangler causes a hard fail for not such a great reason IMO.
Your project
No response
Screenshots
No response
OS
windows/linux
Python version
3.11
AWS SDK for pandas version
installed from main
Additional context
No response

Duplicate issue #1802: Add support for Python 3.11
Created: 2022-11-28T08:41:42Z
Currently when using pip or poetry to install awswrangler, I am getting:

awswrangler (2.17.0) requires Python >=3.7.1,<3.11

Describe the solution you'd like
I would like teo able to install awswrangler on Python 3.11

Closing comment (2022-11-28T09:28:45Z): Duplicate of #1714
Repository: aws/aws-sdk-pandas

Issue #1197: s3.read_parquet() handling NA value differently from Pandas
Created: 2022-03-01T21:02:49Z
Describe the bug
When reading a parquet file containing Null values, awswrangler convert these values into pd.NA instead of None, which is the Pandas behavior.
How to Reproduce
Find a parquet file that contains null values and compare the loaded DataFrame using the following functions:

wr.s3.read_parquet()
pd.read_parquet()

For my case, the column with all string data was inferred to "string[python]" as dtype , with null values represented using pd.NA when using awswrangler. When the DF is loaded using pandas, the same column was inferred to "dtype('O')", with null values represented using None.
While i actually prefers the awswrangler behavior in this case, I wonder if this is intended as when migrating from using Pandas to WR this might be a unexpected surprise for some developers.
Expected behavior
No response
Your project
No response
Screenshots
No response
OS
Amazon Linux 2012
Python version
Python 3.9.5
AWS DataWrangler version
2.14.0
Additional context
No response

Duplicate issue #1198: s3.read_parquet() uses more memory than the pandas read_parquet()
Created: 2022-03-01T23:47:15Z
Describe the bug
the s3.read_parquet() method can consume a lot more memory than the vanilla pandas read_parquet()
How to Reproduce

Prepare a dataframe in parquet format of various datatypes, mine is about 55mb on disk and contains 3 diff data types: timestamp, string and int64
Load the df using awswrangler's read_parquet() and compare it against Pandas native method

Expected behavior
Awswrangler should consume similar amount of memory as pandas after loading, or at least close. Right now i'm seeing roughly double.
Your project
No response
Screenshots


I tried to make a silly script to profile the memory usage. Top plot is with pandas and bottom is with awswrangler. X axis is time in 1/10 second and Y axis is system memory usage in GB. In this comparison, the pandas library is loading from local parquet file while awswrangler is loading from s3. So naturally awswrangler is slower, but the file that was loaded was the same. (I cannot use pandas to load from s3 today due to authentication issue so this is my best attempt. From previous experiment i know when pandas is also loading from s3 the mem usage is similar to what's show in this top plot.)
As can be seen after loading the same df, the awswrangler is using more than double the memory than pandas.
OS
Amazon Linux 2012
Python version
3.9.5
AWS DataWrangler version
2.14.0
Additional context
No response

Closing comment (2022-03-01T23:52:20Z): Actually I've been wondering if this is related to #1197
I have noticed that pandas by default load my string based columns and infer dtype as Object. Whereas awswrangler load the same columns and infer them as string. Maybe that's where the difference coming from?
While it is possible pd.NA have a larger memory footprint than native python None. The difference shouldn't be this large tho. My DF doesn't contains that many NA values.
Repository: aws/aws-sdk-pandas

Issue #617: parquet dataset file name
Created: 2021-03-25T10:40:46Z
@jaidisido
that isnt the case, even you specify full path it gives random name to the file
awswrangler.s3.to_parquet(
...         df=dataframe,
...         path="s3://temp-dds-slack-alpha-userid-us-east-1/pre_fix/file.pq",
...         dataset=True,
...         s3_additional_kwargs={"ACL": "bucket-owner-full-control"},
...     )

{'paths': ['s3://bucket/pre_fix/file.pq/b7f44eddf8d24911b5855b2eb21bf781.snappy.parquet'], 'partitions_values': {}}


Originally posted by @adarsh-chauhan in #616 (comment)

Duplicate issue #988: Custom parquet name
Created: 2021-11-04T22:46:02Z
https://github.com/awslabs/aws-data-wrangler/blob/main/awswrangler/s3/_write_parquet.py#L508
It would be nice to have a flag that we can pass in so that we can just use our filename without the hex added while calling wr.s3.to_parquet()

Closing comment (2021-11-05T09:33:06Z): This is a duplicate of #617
If you are writing a single file you can specify the full name. But when dataset=True, more than a single file could be written and a random hex is added (see issue)
Repository: aws/serverless-application-model

Issue #1327: Add VpcEndpointIds to EndpointConfiguration Parameter
Created: 2019-12-13T20:02:18Z
Description:
Currently Cloudformation supports both Types and VpcEndpointIds as parameters on EndpointConfiguration. For endpoints types of PRIVATE a VPC endpoint is required to generate Route53 Aliases from which you can use to direct to specific APIs on apigateway. Without the Aliases the API id must be supplied in the header on every request (x-apigw-api-id). As a workaround the Api and VPCe can be linked through the console/sdks but every time SAM is deployed it overwrites the previous configuration.
Adding a VpcEndpointIds as a list of strings parameter on the EndpointConfiguration would enable the association of Apis on apigateway and vpce's

Duplicate issue #1600: Secrets manager resolve for VPC endpoint ids in Rest API
Created: 2020-05-26T20:25:19Z
Description:
We want to be able to configure API Gateway's private endpoint to create a private API. The VPC endpoint IDs are resolved through secrets manager. With CloudFormation, API Gateway supports two properties in the EndpointConfiguration object: Type and an array of VpcEndpointIds. With SAM, the EndpointConfiguration property is a string and only supports the equivalent of the Type property in CloudFormation. Further, the template fails validation with SAM when we use the {{resolve:ssm:...}} syntax for the EndpointConfiguration.
Steps to reproduce the issue:
EndpointConfiguration:
  Types: PRIVATE
  VpcEndpointIds=["{{resolve:ssm:vpcprivatelink-api_gateway-private_vpc_endpoint_id:1}}"]
Observed result:
Expected result:

Closing comment (2020-05-28T14:56:09Z): @sriram-mv
Is this a duplicate of #1327
Appears this PR will address it. #1524
Repository: aws/serverless-application-model

Issue #48: Encrypt Variables
Created: 2016-12-28T02:13:09Z
Hey! Awesome job by the way. I really love using this. There are a TON of things that this can give us that I don't have to build.
But I have a feature request (if it isn't already done)
With the cloudformation, can you specify encrypted? That way, when we use 'aws cloudformation deploy' it will go through, and encrypt with the KMS key you specify?
Something like this maybe
Environment:
  KmsKeyId: 1234-1234-1234-1234
  Variables:
    NON_SECRET: blah
    SECRET: !Encrypt this_gets_encrypted

Then we can just do the regular boto.kms.decrypt when we need to decrypt it in the lambda.

Duplicate issue #116: Setting KMS key for Lambda function
Created: 2017-03-30T20:12:30Z
CloudFormation lets you specify a KMS key via the KmsKeyArn attribute. However, this does not seem to be supported by SAM.
Template snippet
Resources:
  MyFunction:
    Type: AWS::Serverless::Function
    Properties:
      Handler: index.handler
      Runtime: nodejs6.10
      CodeUri: ./src
      KmsKeyArn: !Sub "${MyKmsKey}"

Error when calling aws cloudformation deploy:
Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [MyFunction] is invalid. property KmsKeyArn not defined for resource of type AWS::Serverless::Function

Is there another way of setting this or is this feature missing at the moment?

Closing comment (2017-04-06T23:34:11Z): This might be a duplicate of #48
Repository: aws/serverless-application-model

Issue #90: Nested stack issue
Created: 2017-02-11T12:50:57Z
I am trying to make stack with nested stacks, but when i have Transform in nested stack, i get an error:
CreateStack cannot be used with templates containing Transforms. If this error is expected, this should be added somewhere to docs, that only parent stack should have Transforms.
In case i delete Transforms from nested stacks, i get 	Circular dependency between resources: [ApiGatewayApi, InviteUserFunction, LambdaInvokePermission], which i do not have if i create this stack separately.
Here is part of nested stack template
AWSTemplateFormatVersion: 2010-09-09
Resources:
  ApiGatewayApi:
    Type: AWS::Serverless::Api
    Properties:
      DefinitionUri: ./../target/swagger.yaml
      StageName: Prod
      Variables:
        InviteUserFunctionName: !Ref InviteUserFunction
  InviteUserFunction:
    Type: AWS::Serverless::Function
    Properties:
      Timeout: 30
      Role: !GetAtt LambdaFunctionIAMRole.Arn
      Handler: com.MyHandler
      Runtime: java8
      CodeUri: ./../target/some.jar
      Events:
        GetRequest:
          Type: Api
          Properties:
            RestApiId: !Ref ApiGatewayApi
            Path: /invite
            Method: POST
  LambdaInvokePermission:
    Type: AWS::Lambda::Permission
    Properties:
      Action: lambda:InvokeFunction
      FunctionName:
        !GetAtt InviteUserFunction.Arn
      Principal: apigateway.amazonaws.com
      SourceArn:
        Fn::Join:
        - ''
        - - 'arn:aws:execute-api:'
          - Ref: AWS::Region
          - ":"
          - Ref: AWS::AccountId
          - ":"
          - Ref: ApiGatewayApi
          - "/*"

Duplicate issue #151: SAM-Templates >50KB not possible?
Created: 2017-06-14T09:41:01Z
So we finally hit the problem, that our SAM CloudFormation templates are larger than 50KB.
As 50KB is the limit for CloudFormation if you specify a local template, we needed to look for other solutions than using aws cloudformation deploy --template-file ....
We looked into:

Using a template URL for aws cloudformation deploy - not possible, because deploy has no such option (aws/aws-cli#2461)
Using nested stacks - not possible, because transformations in child templates aren't possible (#90)

Are there any other options? Using create-change-set and execute-change-set instead of deploy comes to mind, but that sounds like more or less giving up all the benefits deploy offers.

Closing comment (2017-06-28T06:33:43Z): Nested stack transformation bug is tracked in #90. I am using this as a feature request for the AWS CLI feature where deploy supports S3 template URL
Repository: aws/serverless-application-model

Issue #931: RFC: Allow customizations on AWS::Serverless::Function API event types
Created: 2019-05-22T21:33:36Z
Swagger seems to be an all-or-nothing approach to AWS::Serverless::Api resources.  If the swagger definition is provided in the API then the entire API needs to defined in swagger.  I often have a single AWS::Serverless::Function that needs some customization in how it should be defined in the API, but in order to accomplish that I would need to provide boilderplate swagger for the entire API plus my customization.
It would be much more convenient and simple if I could just add my customizations to the Lambda API event and the translator would apply these to the API definition for that specific function.

Duplicate issue #1207: Use detailed error message when enable API GW request body validation
Created: 2019-10-16T01:10:06Z
Description:
When using API GW's request validation feature to validate request body, by default the error message is Invalid request body without any details on where it is invalid in request body.  To get detailed error message, customers have to set the following in their swagger:
x-amazon-apigateway-gateway-responses:
  # Provide more detailed error message for bad request body errors. See doc: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions-gateway-responses.html
  BAD_REQUEST_BODY:
    responseTemplates:
      application/json: '{"message": "$context.error.validationErrorString"}'

It would be nice if SAM can add this to swagger automatically if request body validation is enabled.

Closing comment (2019-10-18T17:22:28Z): Thanks for creating the issue, Lu! We don't support adding request-validators in SAM today, but this is on our roadmap. Once that support is added it totally makes sense to add gateway responses for BAD_REQUEST_BODY. It's being tracked in #931