primordic/IssueDupesLite huggingface dataset:
Repository: mbenford/ngTagsInput

Issue #470: Adding tags with Enter key doesn't work properly for new tags with autocomplete
Created: 2015-05-30T10:28:56Z
I'm using tags-input with auto-complete directive.
<tags-input ng-model="selectedTags"
    display-property="name"
    on-tag-adding="onBeforeTagAdd($tag)"
    on-tag-added="onTagAdd($tag)"
    on-tag-removed="onTagRemove($tag)"
    placeholder="Digita tags"
    replace-spaces-with-dashes="false"
    add-on-space="false"
    add-on-blur="false"
    add-from-autocomplete-only="false">

<auto-complete source="autocompleteTags($query)" selectFirstMatch="false" debounce-delay="500"></auto-complete>
Steps to reproduce:

Have your source callback to return ["Tag1", "Tag2"]
Type "ag1" in the input field. The expected behaviour would be adding a new "ag1" tag
Hit Enter

You'll see that "Tag1" is selected instead. Is this a bug, or a configuration problem of mine?

Duplicate issue #630: findInObjectArray is not returning the expected result
Created: 2016-02-21T18:33:47Z
Hi guys,
first, thank you very much for this plugin.
As I try to add more than one tag, I get the second being invalid; after a research, I found out that this the line
!tiUtil.findInObjectArray(self.items, tag, options.keyProperty || options.displayProperty)
in the following code return false and this is why the tag is not added
return tagText && tagText.length >= options.minLength && tagText.length <= options.maxLength && options.allowedTagsPattern.test(tagText) && !tiUtil.findInObjectArray(self.items, tag, options.keyProperty || options.displayProperty) && onTagAdding({ $tag: tag });

Closing comment (2016-03-21T13:26:28Z): @silvanaacc Isn't that a duplicate of #470 ?
Repository: mbenford/ngTagsInput

Issue #599: autocomplete issue in ngtagsinput
Created: 2015-12-31T09:10:05Z
hi mbenford.github.io/ngTagsInput is the ngtagsinput directive we are using in our angularjs app. As ngtagsinput autocomplete does not filter any results, i want to get the filtered results from my api through service call and return promise to the autocomplete of tagsinput on every key stroke. In my angularjs app i am getting the filtered results from the api on every keystroke but they are not appearing in view i.e., the auto complete results displayed are not updating on keystroke even though i am getting the results from api. Can anyone help me in achieving this.

Duplicate issue #564: ngtags input  autocomplete not working correctly
Created: 2015-11-13T00:01:58Z
Hi
I have used ng tags input, i am facing an issue with its auto complete, i have binded it from server and it is fetching the data from database using service, so when the user types first three characters it fetches the data from database and displays it in autocomplete, but some time it doesn't  work correctly as if i type first three characters as "abc" and it will return the records "abcd, abcde" and if i add one more character which would be i and the new characters of string is "abci" it still returns "abcd"  only and it seems the call doesn't go to the server as well in this case  and some times it return the correct record "abci", i am unable to figure out the issue may, please help me  with this one, thanks in advance.
Regards

Closing comment (2016-03-29T12:39:55Z): Possible duplicate of #599 ?
Repository: mbenford/ngTagsInput

Issue #77: Visual feedback for invalid tags
Created: 2014-02-18T04:26:58Z
Currently when a tag is invalid (i.e, some validation rule is violated) the directive doesn't display any visual feedback so the user can understand what's going on. It would be nice if there was some feedback for invalid tags.

Duplicate issue #49: Visual feedback for duplicate tags
Created: 2013-12-16T03:49:40Z
Currently when one tries to add a duplicate tag, ngTagsInput simply doesn't allow it, without any feedback whatsoever. It would be nice if there were some kind of visual feedback so the user could understand what had just happened.

Closing comment (2014-03-20T05:52:50Z): Closing this issue since it's the same as #77.
Repository: mbenford/ngTagsInput

Issue #749: Possible to prevent autofocus when removing tag?
Created: 2016-11-02T14:09:49Z
Hi,
I am trying to find a way to prevent the autofocus from occurring on the input box when I remove a tag. The reason being is that we have cases where the tag list could be very large (over 200+) so we don't want users to lose their scroll position.
I couldn't find anything from the documentation, is it possible?
Thanks

Duplicate issue #759: Prevent focus on tag removed
Created: 2016-12-01T13:43:11Z
When I click on a tag to remove it, the click event will propagate to host div which results in focusing the input box.
Is there a way or any attribute that will prevent the input box from getting focused on removing a tag ?

Closing comment (2016-12-01T13:46:01Z): duplicate #749
Repository: mbenford/ngTagsInput

Issue #99: Custom template support for autocomplete
Created: 2014-03-16T16:38:44Z
The autocomplete directive should have support for custom templates so additional information could be displayed instead of just a list of strings.

Duplicate issue #61: Support grouping in autocomplete
Created: 2014-01-29T12:04:23Z
Hi, is there a way to support group inside the autocomplete?

Closing comment (2014-08-16T17:34:44Z): Seems related to #99 IMHO
Repository: mbenford/ngTagsInput

Issue #241: input is readonly
Created: 2014-09-11T14:41:54Z
hey,
is it possible to add the attribute readonly to the directive ?
i have the need here that the user chooses the tags from a fixed list without taping them directly ...
thanks

Duplicate issue #601: Readonly mode
Created: 2016-01-04T16:54:44Z
Question, does ngTagsInput support/has readonly mode ?
What I'm looking for is having it disabled for human input, I just want my controller to insert items to the tags-input on some user events, but I do want the user to be able to remove them (x to close)

I tried using html to disable the input but that didn't work, just changed the style.
My question on SO
http://stackoverflow.com/questions/34509624/ng-tags-input-how-to-disable-user-input

Closing comment (2016-01-06T16:18:10Z): Duplicate: #241
It is not explicitly stated in the documentation, but you can do <tags-input disabled="true"></tags-input> which will work.
Repository: mbenford/ngTagsInput

Issue #569: Promise support for onBeforeTagAdd
Created: 2015-11-19T11:46:52Z
I've recently seen that i can't use promises as return type from a onBeforeTagAdd handler (result is always assumed to be true).
I think this would be a nice addon since i might need to check items match custom constraints before adding them.
What do you think?

Duplicate issue #648: on-tag-adding does not work with promises
Created: 2016-03-24T01:23:56Z
I want to add a tag but before I do I want to check with the server to make sure it's okay I am returning a promise with true or false, but it always evaluates as true and the tag always gets added even on error. I can't figure out how to fix this.
var deferred = $q.defer();

someFunction(tag).then(function(result){
deferred.resolve(true);
}, function(error){
deferred.resolve(false);
});
return deferred.promise;

<tags-input on-tag-adding="someFunction($tag)" ... >

Closing comment (2016-05-23T11:39:25Z): Duplicate of #569
Repository: mbenford/ngTagsInput

Issue #512: Cannot type using mobile/touchscreen
Created: 2015-08-06T18:11:06Z
On mobile Chrome on Android, when trying to focus the ngTagsInput directive to type in a tag, the keyboard appears and then immediately disappears. The field focuses and then immediately blurs.
You're able to focus the textbox only if you tap on the border on mobile.

Duplicate issue #524: Does not work as expected on mobile with angular-touch
Created: 2015-08-21T23:42:04Z
Visit this plunkr, which is just the "simple tags input" demo with ngTouch added, in a mobile browser or with Chrome's mobile browser emulation enabled. Note that tapping/clicking the input does not keep it focused; only holding down ("dwelling") does so.

Closing comment (2015-08-21T23:45:15Z): Oops, this is a duplicate of #512
Repository: mbleigh/acts-as-taggable-on

Issue #257: *_list attribute not getting dirtied when updated has nested attribute
Created: 2012-05-18T17:50:26Z
When you call update_attrbutes on a model which have nested attributes for a model where the only attribute that changes is a *_list, it doesn't work as the nested record doesn't get dirty.

Duplicate issue #786: update_attributes not saving tag_list in belongs_to association)
Created: 2016-10-26T03:54:29Z
related to #547
Any solution to this yet? I got the same problem in the following context:
class User 
  belongs_to :login 
  ...
end

class Login
   # tags
    acts_as_ordered_taggable_on :udfs
end

user = User.find(1)
user.update_attributes(login_attributes: { id: user.login.id, udf_list: "a, b, c", first_name: "Aldo" })

problem: model.login.name is updated but model.logins.udf_list is not updated ([])
Using version 4.0.0

Closing comment (2017-02-24T06:48:15Z): Might be similar to  #257
Repository: mbleigh/acts-as-taggable-on

Issue #807: Rails 5.1.0.beta1 Passing a class to the `class_name` is deprecated 
Created: 2017-02-27T13:10:18Z
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tag_taggings, class_name: 'ActsAsTaggableOn::Tagging'`
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tags, class_name: 'ActsAsTaggableOn::Tag'`
rails (5.1.0.beta1)
acts-as-taggable-on (4.0.0)

Duplicate issue #814: Rails 5.2: Passing a class to the class_name
Created: 2017-03-10T20:31:24Z
DEPRECATION WARNING: Passing a class to the class_name is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: has_many :tag_taggings, class_name: 'ActsAsTaggableOn::Tagging' (called from class:User at c:/Users/Jonas/gitapps/slooob/app/models/user.rb:16)
DEPRECATION WARNING: Passing a class to the class_name is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: has_many :tags, class_name: 'ActsAsTaggableOn::Tag' (called from class:User at c:/Users/Jonas/gitapps/slooob/app/models/user.rb:16)

Closing comment (2017-03-12T17:33:12Z): Duplicate of #807
Repository: mbleigh/acts-as-taggable-on

Issue #113: Renaming columns and table
Created: 2010-10-04T21:28:29Z
Is it possible to rename the columns and the table generated by acts-as-taggable-on?

Duplicate issue #114: Renaming columns and table
Created: 2010-10-04T21:28:29Z
Is it possible to rename the columns and the table generated by acts-as-taggable-on?

Closing comment (2011-12-18T13:19:25Z): dup of #113
Repository: mbleigh/acts-as-taggable-on

Issue #914: Doesn't save tags passed as associations after upgrading to 6.0.0
Created: 2018-08-10T10:24:44Z
Hello,
in our project we assign tags the following way:
tag = ActsAsTaggableOn::Tag.create! name: 'people'

Article.create! title: 'Title', content: 'Text', tags: [tag]
#or
Article.create! title: 'Title', content: 'Text', tags_ids: [tag.id]
Especially we have many pieces like this in our tests.
After upgrade  from AATO 5.0.0 to 6.0.0 it started to fail with
ActiveRecord::RecordInvalid:
  Validation failed: Tag taggings is invalid

Seems like that tagging cannot be saved because context is blank.
Should it save tags passed to tags association with DEFAULT_CONTEXT = 'tags' by default?
If it should could you please confirm and fix it,
otherwise I need to change the way we assign tags in our code
Thank you!

Duplicate issue #1120: Adding tags using #tag_ids= breaks when migrating from v5 to v6
Created: 2023-12-10T19:22:29Z
When updating from v5 to v6, I noticed that setting tags using #tag_ids= has stopped working. The commit that broke this functionality is #887.
Repro:
class User < ActiveRecord::Base
  acts_as_taggable_on :tags
end
require "rails_helper"

RSpec.describe "these tests pass on v5 but fail after 887" do
  let!(:existing_tags) { FactoryBot.create_list(:tag, 3) }
  
  describe "create" do
    let(:create) do
      FactoryBot.create(:user, tag_ids: existing_tags.map(&:id))
    end

    it do
      expect { create }.to change { ActsAsTaggableOn::Tagging.count }.by(3)
    end

    it do
      user = create
      expect(user.reload.tag_list).to match_array(existing_tags.map(&:name))
    end
  end
  
  describe "update" do
    let!(:user) { FactoryBot.create(:user) }
    let(:update) do
      user.update(tag_ids: existing_tags.map(&:id))
    end
    
    it do
      expect { update }.to change { ActsAsTaggableOn::Tagging.count }.by(3)
    end

    it do
      update
      expect(user.reload.tag_list).to match_array(existing_tags.map(&:name))
    end
  end
end

Closing comment (2023-12-10T22:04:20Z): duplicate of #914
Repository: mbleigh/acts-as-taggable-on

Issue #145: Recent rails change causes sql error in a_new_record.tag_list
Created: 2011-04-25T22:31:43Z
Normally, you can run
TaggableModel.new.tag_list #=> []
and have it just return an empty array.
Ever since rails/rails@9f5ab9a you get an sql error along the lines of :
Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND (`taggings`.taggable_type = 'TaggableModel')) AND (taggings.context = 'tag' at line 1: SELECT `tags`.* FROM `tags` INNER JOIN `taggings` ON `tags`.id = `taggings`.tag_id WHERE ((`taggings`.taggable_id = ) AND (`taggings`.taggable_type = 'TaggableModel')) AND (taggings.context = 'tags' AND taggings.tagger_id IS NULL)

(the pertinent part is "WHERE (taggings.taggable_id = )" )
One possible fix is to return an empty array from tags_on when it's a new record (https://gist.github.com/941398), which seemed to work fine.   However, I've been trying to figure out whether it's really a bug in acts-as-taggable-on, or whether it's actually Rails' fault ... but it's pretty late and my brain is failing, so I thought I'd toss it out to the crowd and see what other people thought.

Duplicate issue #158: Exception with Rails 3.0.8rc2
Created: 2011-05-29T08:28:07Z
Not sure if thats a rails bug or that gem but i get an SQL exception
on my create form at the line :tag_list.
Problem seems to be that in former version it would ask something like when ... = NULL). Now its when ....= )
ActionView::Template::Error (Mysql2::Error: You have an error in your SQL syntax; check the manual that corresponds to
your MySQL server version for the right syntax to use near ‘) AND (`taggings`.taggable_type = ‘Run’)) AND 
(taggings.context = ‘tags’ AND tag’ at line 1: SELECT `tags`.* FROM `tags` INNER JOIN `taggings` ON `tags`.id = 
`taggings`.tag_id WHERE ((`taggings`.taggable_id = ) AND (`taggings`.taggable_type = ‘Run’)) AND (taggings.context = 
‘tags’ AND taggings.tagger_id IS NULL)):
 2: <%= f.inputs do %> 
3: <%= f.input :number %> 
4: <%= f.input :name %> 
5: <%= f.input :tag_list, :label => ‘Tags’, :hint => t(‘form.seperate’) %>

Closing comment (2011-05-29T11:10:05Z): duplicate of #145
Repository: mbleigh/acts-as-taggable-on

Issue #405: Count on tagged_with / group_by query
Created: 2013-09-18T11:21:54Z
This query works perfectly
Criterion.tagged_with(["java"], on: :skills).count
But adding a group_by clause breaks everything :
Criterion.tagged_with(["java"], on: :skills).group(:minimum_salary).count
ActiveRecord::StatementInvalid: PG::Error: ERROR:  syntax error at or near "AS"
SELECT COUNT(*) AS count_all,  AS , minimum_salary AS minimum_salary FROM "criterions" JOIN ...

Duplicate issue #530: multiple tagged_with calls break size()
Created: 2014-05-09T15:18:39Z
Say you execute the following (from the README):
out = User.tagged_with(['awesome', 'cool'], :on => :tags, :any => true).tagged_with(['smart', 'shy'], :on => :skills, :any => true)
If you do out.size() the following exception will be raised:
ActiveRecord::StatementInvalid (PG::UndefinedFunction: ERROR:  function count(users, users) does not exist
LINE 1: SELECT DISTINCT COUNT(DISTINCT  users.,  users.)
If you load the relation before executing size(), obviously it will work as it doesn't run the count query.  It looks like the count query is malformed for multiple tagged_with calls.  If you edit the query manually and remove one of the users.* from the COUNT, the query executes successfully.

Closing comment (2014-05-09T15:22:39Z): not sure, but perhaps this is related to #405 ?
Repository: mbleigh/acts-as-taggable-on

Issue #74: Support for Nesting, like Categories?
Created: 2010-05-17T01:24:25Z
I have been building a basic blogging system and am implementing Tagging and Categories.  ActsAsTaggableOn is by far the most evolved of any of the tag/category gems out there, and Tags are almost like categories.
The only difference between tags and categories, from a consumer/user's perspective, is categories are:

more structured
nestable

From a programmer's perspective, Category is almost a sub-class of Tag.
Looking at Wordpress' Database Schema, they take this same approach:
http://codex.wordpress.org/Database_Description
http://codex.wordpress.org/images/8/83/WP_27_dbsERD.png
They have a Term and TermRelationship, which are basically Tag and Tagging.  They just have included a parent property on the Term, so they can use Term for Tags and Categories.
What about including this nesting capability in the gem?
The benefit is: 'we' would never again have to mess with building category models, and the 900+ watchers would immediately have a lot of very useful functionaliy.
Any thoughts?
Best,
Lance

Duplicate issue #683: Tree Structure support for taggings
Created: 2015-09-11T16:35:25Z
Hi, do you have any plans for parent-child relation in taggings? Thanks

Closing comment (2017-08-16T18:45:04Z): Duplicate of #74.
Repository: mbleigh/acts-as-taggable-on

Issue #1137: Changelog / Release for 12.0.0
Created: 2024-11-12T08:37:45Z
Hi, would it be possible to have a changelog and/or a release for 12.0.0?
According to Copilot, a full changelog would be:
Changelog for v12.0.0


Workflow Updates

Updated GitHub Actions workflow to support Ruby 3.3 and remove support for Ruby 3.1.
Updated gemfile to include activerecord_8.0.gemfile and removed activerecord_7.0.gemfile.



Appraisals

Removed appraisal for activerecord-7.0.
Added appraisal for activerecord-8.0.



README

Updated compatibility information:

Versions >= 12.x are compatible with Ruby 3.2.0 and Rails 7.1, 7.2, and 8.0.





Gemspec

Changed required Ruby version to >= 3.2.0.
Updated runtime dependency for activerecord to >= 7.1 and < 8.1.



Gemfiles

Renamed activerecord_7.0.gemfile to activerecord_8.0.gemfile and updated dependencies accordingly.
Updated activerecord_7.2.gemfile to use sqlite3 version ~> 2.1.



Code Changes

Removed force_encoding('BINARY') from named_any method in tag.rb.
Updated version in version.rb to 12.0.0.



For more details, you can view the full comparison here.

Duplicate issue #1141: Changelog entry for 12.0
Created: 2024-12-11T20:24:13Z
Hello, is it possible to have a changelog entry for 12.0?

Closing comment (2024-12-12T22:55:52Z): There's only a limited number of commits since the last release. You can probably figure it out yourself, or, even better, contribute it !
Edit: This is actually a duplicate of #1137
Repository: mdn/yari

Issue #5180: Some pages have related topics in main content
Created: 2022-01-18T10:12:58Z
For some pages like https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze the related topic sidebar is missing, and instead, the list is added to the main content area.

Duplicate issue #5185: Issue with "Array": Formatting broken.
Created: 2022-01-19T02:59:17Z
MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
What information was incorrect, unhelpful, or incomplete?
The formatting of the English JavaScript reference pages seems to have broken some time today.
Specific section or headline?
All English JS reference pages.
What did you expect to see?
Formatted similar to the current German JS reference pages.
Did you test this? If so, how?


MDN Content page report details

Folder: en-us/web/javascript/reference/global_objects/array
MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/array/index.md
Last commit: mdn/content@5690353
Document last modified: 2021-12-27T21:20:17.000Z

Closing comment (2022-01-19T10:23:42Z): Thank you for filing @umrigar. This is a duplicate of #5180 and has been addressed. It might take ~24 hours for the change to be on production.
Repository: mdn/yari

Issue #6079: 502 on "Try it" at RegExp -> toString()
Created: 2022-04-26T21:45:47Z
MDN URL
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/toString
What specific section or headline is this issue about?
"Try it"
What information was incorrect, unhelpful, or incomplete?
502 ERROR
The request could not be satisfied.
The Lambda function result failed validation: The body is not a string, is not an object, or exceeds the maximum size. See Limits in the Amazon CloudFront Developer Guide. We can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.
If you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent this error by reviewing the CloudFront documentation.
Generated by cloudfront (CloudFront)
Request ID: 2RtqRyVQ_NEr_iHOyiU6taWMHUkc-mgNUKCz2KRSK74Wvo3aEj2zfg==

What did you expect to see?
The usual content for "Try it" section
Do you have any supporting links, references, or citations?
No response
Do you have anything more you want to share?
No response
MDN metadata


Page report details

Folder: en-us/web/javascript/reference/global_objects/regexp/tostring
MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/toString
GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/javascript/reference/global_objects/regexp/tostring/index.md
Last commit: mdn/content@cf607d6
Document last modified: 2021-07-20T18:47:57.000Z

Duplicate issue #6081: handler.construct() Try it Error
Created: 2022-04-26T19:30:40Z
MDN URL
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/construct
What specific section or headline is this issue about?
Try It
What information was incorrect, unhelpful, or incomplete?
502 Error
What did you expect to see?
Try it container
Do you have any supporting links, references, or citations?

Do you have anything more you want to share?
No response

Closing comment (2022-04-26T22:03:51Z): Closing as a duplicate of #6079. Thank you for reporting @cohenerickson
Repository: mdn/yari

Issue #1547: Inject js polyfills conditionally
Created: 2020-10-27T20:51:12Z
In Kuma we inject this:
<script>
  window.fetch || document.write('<script src="/static/build/js/fetch-polyfill.63fdc379c7eb.js"><\/script>');
</script>
<script>
  // Only include the fat polyfill for browsers that seem to not have
  // certain JS features. E.g. Firefox 38.
  Array.prototype.includes || document.write('<script src="/static/build/js/js-polyfill.6f2e22100487.js"><\/script>');
</script>
They might be bloated but they only get injected for clients that don't have window.fetch or Array.prototype.includes.

Duplicate issue #2353: Some pages on MDN Web Docs are not displayed correctly (blank page) in Firefox v56
Created: 2021-01-06T09:28:05Z
@Lumox100 commented on Wed Jan 06 2021
Summary
What is the problem?
I was looking for information on the property currentSrc for images but when I open the page
https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/currentSrc
it flashes up and then goes to a blank page.
But other MDN docs display correctly
https://developer.mozilla.org/en-US/docs/Web/API/Web_Animations_API
The web page displays correctly in the latest version of Firefox but I use Firefox v56 still because it has legacy add-ons that do not work in the latest version of Firefox. But why do some web pages work correctly but others do not?
Steps To Reproduce (STR)
How can we reproduce the problem?

Open Firefox v56
Go to page https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/currentSrc


Actual behavior
What actually happened?
Blank page
Expected behavior
What did you expect to happen?
Web page should be diaplayed correctly.
Additional context
Is there anything else we should know?

Closing comment (2021-01-06T13:32:09Z): This is happening because we don't inject the polyfills for really old browsers.
Dupe of #1547 but I prefer this issue since it contains links and a mention of a specific browser version number.
Repository: mdn/yari

Issue #2163: Compat tables aren't rendering prefixes
Created: 2020-12-16T16:42:08Z
Compat tables aren't rendering BCD's "prefix" data. Take api.Notification.Notification as an example, from https://developer.mozilla.org/en-US/docs/Web/API/Notification/Notification:

Here it just says "prefix" rather than showing moz from the source data:
https://github.com/mdn/browser-compat-data/blob/38e374f70a845393317a0e3d295d2f75437a8b05/api/Notification.json#L69-L135

Duplicate issue #2444: Legends section not shown, sometimes, in BCD tables
Created: 2021-01-11T15:11:19Z
See http://localhost:3000/en-US/docs/Web/API/Notification/Notification#browser_compatibility for example.
Renders like this:

In the Wiki, it would always show the legends section.

Closing comment (2021-01-11T15:25:09Z): Maybe I go too far but that legend should be removed in my opinion in favor of th.

Let's worry about that later. Right now, this issue describes a regression from how BCD tables were designed to work in MDN. Similar to #2163
Once this is settled, the likes of @ddbeck can push for modernized changes.
Repository: mdn/yari

Issue #5421: Make sidebar collapsible on medium-sized screens
Created: 2022-03-02T15:38:05Z
Summary
I have a monitor in portrait (vertical) orientation, which is very useful for reading documentation websites such as MDN. However, this means horizontal space is at a premium. With the new MDN design about a third of the horizontal space is taken up by the navigation sidebar + padding:

Contrast with the old design (from archive.org):

Many documentation websites & themes provide the ability to collapse the navigation sidebar for this reason. It would be nice if MDN did the same.
Where did you spot the bug?
All MDN documentation pages, for example https://developer.mozilla.org/en-US/docs/WebAssembly
What is the problem?
Lack of horizontal space caused by navigation sidebar makes website unusable on portrait (vertical) monitors.
What did you expect to happen?
I expected to be able to collapse the navigation sidebar so the content takes up the full horizontal space.
Steps to reproduce the issue

Select your monitor orientation as portrait
Visit a MDN page such as https://developer.mozilla.org/en-US/docs/WebAssembly

Environment
Firefox on Windows 10
Device

 Desktop
 Mobile: ...
 Tablet: ...
 Other: ...

Browser

 Chrome: (what version?)
 Firefox: 97.0.1
 Safari: (what version?)
 Other: (what browser / version?)

Operating system

 Windows: 10
 Mac OS: (what version?)
 Linux: (what distribution / version?)

Screenshots

Duplicate issue #5975: Feature request: Always enable the ability to collapse the sidebar
Created: 2022-04-13T20:41:09Z
While working on the readability project, I received feedback from several people who said that having the ability to collapse the sidebar would be a welcome feature. This refers to the functionality available on mobile.

Perhaps not for large desktop viewports but perhaps from tablet devices in landscape orientation and smaller. Perhaps even from 1366px and smaller even.

Closing comment (2022-09-14T16:44:04Z): Duplicate of #5421.
Repository: mdn/yari

Issue #6488: Add "Last modified" metadata timestamp to BCD tables
Created: 2022-06-07T15:48:14Z
Yari updates BCD tables with some delay relative to mdn/browser-compat-data, so when I see incorrect BCD tables on MDN I have to check the update timestamp in BCD repo.
It would be nice if Yari could insert BCD metadata into the final output. It does not have to be visible by default or at all, it can be just dropped somewhere in HTML.

Duplicate issue #11366: web-features baseline status is not sync'd with BCD
Created: 2024-06-26T05:52:35Z
Summary
On https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/difference#browser_compatibility, compare the BCD table and baseline status:


The method became available in Firefox 127, therefore making it "baseline low".
However, Yari uses 0.8.6 of web-features, which is 2 weeks old and which, indeed, shows Firefox as missing.
This is not Yari's fault because there hasn't been a new release of web-features since then, but I'm opening the issue here because this is where it manifests for users. We should discuss about the release cadence for web-features, and the strategy for yari to bump the version it depends on.
Pinging @ddbeck on this.
URL
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/difference
Reproduction steps

Open the page
Look at the Baseline banner
Look at the BCD table

Expected behavior
The banner, and BCD table, should always match.
Actual behavior
They differ.
Device
Desktop
Browser
Firefox
Browser version
Stable
Operating system
Mac OS
Screenshot
No response
Anything else?
No response
Validations

 I have read the Community Participation Guidelines.
 I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
 I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.

Closing comment (2024-07-02T10:43:07Z): This is somewhat related to #6488.
Repository: mdn/yari

Issue #2089: Previous, Next and Overview buttons are misaligned one over the other and with no space in-between on non-English pages
Created: 2020-12-11T17:28:10Z
Steps to reproduce:

Go to https://developer.allizom.org/en-US/docs/Learn/Getting_started_with_the_web/JavaScript_basics and view buttons positioning.
Change language to non-English, for example https://developer.allizom.org/fr/docs/Apprendre/Commencer_avec_le_web/Les_bases_JavaScript
Compare the buttons position.

Actual result:

Expected result:

This also occurs on mobile, but there the default position for the buttons on english articles is one under the other so the only issue is the lack of space/ padding between them

Duplicate issue #1957: Next and Prev anchors layout
Created: 2020-12-05T13:33:01Z
5 things:

These 3 a should be inline
These 3 a should be 2, just Prev and Next inline
I'm expecting that the a in centre is the current page, what is It?
I don't know where to put the a in the center
I think that if in at the beginning of the page i want to first of all read and then go to the Next Page

Closing comment (2020-12-12T15:21:20Z): Duplicate of #2089
Repository: mdn/yari

Issue #9159: Gap between Top Navigation Header and broswer frame.
Created: 2023-06-26T09:11:28Z
Summary
This is not a big issue that can cause the site to go down, but it is a good UPGRADE.
So, the top navigation, when scrolled down, has a little space left between the browser frame and header. Texts and images are visible from the gap which it has.
URL
https://developer.mozilla.org/en-US/
Reproduction steps
Changing the CSS file of the top navigation UI element will work.
Actual behavior {ZOOM on the link address bar to see}

Device
Desktop
Browser
Chrome
Browser version
Stable
Operating system
Android
Screenshot
No response
Anything else?
No response
Validations

 I have read the Community Participation Guidelines.
 I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
 I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.

Duplicate issue #9040: Gap between page's start and header.
Created: 2023-06-08T08:26:29Z
Summary
There's a gap between the start of the page and the header, so the content under header is seen through this gap
URL
Basically most (or any) mdn page
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_scripts
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
Reproduction steps

Open https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
Scroll down a bit so the content is under the top of the page



Expected behavior
There should be no gap

Actual behavior
There is a gap


Device
Laptop
Browser
Chrome
Browser version
Stable
Operating system
Windows
Screenshot


Anything else?
I think I've found the way to fix it but I'm not sure if it is good enough.
Validations

 I have read the Community Participation Guidelines.
 I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
 I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.

Closing comment (2023-10-02T11:14:26Z): Duplicate of #9159.
Repository: mdn/yari

Issue #2065: 'Page not yet created' links do not reflect that
Created: 2020-12-10T20:36:37Z
Steps to reproduce:

Go to https://developer.allizom.org/en-US/docs/Web/JavaScript/Reference/Global_Objects#Control_abstraction_objects.
View all code examples.
Hover over the AsyncGenerator and AsyncGeneratorFunction links and see that pages for this have not yet been created.

Actual results:
Unwritten pages links are indistunguashable from written ones.

Expected result:
Visual warning through red colour that pages have not been written yet.

Duplicate issue #2237: <a class=new> is not standing out
Created: 2020-12-20T21:12:19Z
https://developer.mozilla.org/en-US/docs/Web/API/HTMLDetailsElement

Closing comment (2021-01-11T15:21:50Z): Duplicate of #2065
Repository: mdn/yari

Issue #2299: Download blanks file visually
Created: 2020-12-31T20:22:07Z
When visiting a site on MDN, downloading it (via Ctrl-S) and opening it via file:// protocol or on localhost (e.g. via `python3 -m http.server), the content is visible shortly and then blanks out.
I'm assuming, JavaScript kicks in to show loading animation or something.
Would it be possible to strip JavaScript on save? Or ship pre-rendered HTML?
Use case: Save MDN for offline usage (e.g. during travels with German train, since the WiFi is laughable …). Or think on countries with unaffordable Internet).

Duplicate issue #3647: PDF printing looks weird now
Created: 2021-04-27T19:34:33Z
Somewhere along the timeline when we changed the DOM and its CSS (I'm thinking; when we rearrange so the breadcrumb appears above the title) it probably broke our print CSS.
In Firefox when I load https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video and click to download to PDF I get this:

Closing comment (2021-04-28T16:18:10Z): Related to #2299 ?
Where do you „click to download”? Native print dialog via Ctrl-P? Or do we have a button (like Wikipedia's export) somewhere?

No. Not related.
Repository: meetecho/janus-gateway

Issue #210: Deadlock in janus_check_sessions
Created: 2015-04-15T01:20:26Z
Hi,
I experienced a very predictable deadlock in janus_check_sessions: 337
The problem is quite obvious as this is a double lock on sessions_mutex. You end up with the following backtrace (and lock):
Thread 16 (Thread 0x7fc1c7fff700 (LWP 99981)):
#0  0x00007fc2118d3f2c in __lll_lock_wait () from /lib/x86_64-linux-gnu/libpthread.so.0
#1  0x00007fc2118cf657 in _L_lock_909 () from /lib/x86_64-linux-gnu/libpthread.so.0
#2  0x00007fc2118cf480 in pthread_mutex_lock () from /lib/x86_64-linux-gnu/libpthread.so.0
#3  0x000000000042a376 in janus_session_notify_event (session_id=3946447357, event=0x7fc1bc001b80) at janus.c:414
---Type  to continue, or q  to quit---
#4  0x0000000000429a87 in janus_check_sessions (user_data=0xaed1e0) at janus.c:337
#5  0x00007fc2133b9703 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6  0x00007fc2133b8ce5 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7  0x00007fc2133b9048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8  0x00007fc2133b930a in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9  0x0000000000429d39 in janus_sessions_watchdog (user_data=0xaed2d0) at janus.c:367
#10 0x00007fc2133ddf05 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007fc2118cd182 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#12 0x00007fc2115fa47d in clone () from /lib/x86_64-linux-gnu/libc.so.6
I believe the culprit is the following commit:
8a7df51

Duplicate issue #211: Timeout expired for session XXX and "Ending watchdog mainloop" never ends
Created: 2015-04-15T12:05:02Z
After I get this timeout, I'm unable to stop Janus.
I get:
[WARN] [1751251754] Didn't receive audio for more than a second...
[WARN] [1751251754] Didn't receive video for more than a second...
Timeout expired for session 403831024...
^CStopping gateway, please wait...
Ending watchdog mainloop...
And it never stops.
Possible deadlock somewhere?
Laurent

Closing comment (2015-04-15T12:51:39Z): Most likely related to #210
Repository: meetecho/janus-gateway

Issue #2188: Segfault in SIP plugin
Created: 2020-05-31T20:37:59Z
We're running into a use after free bug in the SIP plugin that seems to randomly happen when a user has multiple incoming calls and abruptly closes their browser window destroying the session.
GDB backtrace: https://pastebin.com/UTG2FbJe
AddressSanitizer output: https://pastebin.com/4D4ADzmT
These were produced on the latest master, commit 7514b78. Let me know if there's any more info I can provide.
Thanks!

Duplicate issue #2191: Segfault in SIP
Created: 2020-06-01T21:15:54Z
We're also running into a use bug in the SIP plugin that randomly crash but we cannot identified what is causing this failure yet
AddressSanitizer output: https://pastebin.com/mBWKgtFN
These were produced on the commit 4f171c2.
Let me know if there's any more info I can provide

Closing comment (2020-06-09T12:44:02Z): I see a notification about a message from @ayty-adrianomartins saying it's a duplicate of #2188, but I can't see it here: not sure if it's Github acting weird, or if the comment was since removed. Anyway, I'll close this issue then and mark it as a duplicate. Please refer to the other issue for updates.
Repository: meetecho/janus-gateway

Issue #2099: Massive disconnect of publishing stream causes heap-use-after-free crash
Created: 2020-04-24T00:31:43Z
We've seen at least one heap-use-after-free crash occur in janus_videoroom_hangup_subscriber, seemingly at the very beginning on the existence check of "if (!s->feed)". We're running the latest master including the changes from PR #2093.

  
    
      janus-gateway/plugins/janus_videoroom.c
    
    
         Line 5161
      in
      4fb459e
    
  
  
    

        
          
           if (!s->feed) { 
        
    
  


Logs with asan output is here: https://pastebin.com/HHp8Qv5Z

Duplicate issue #2110: Janus crashes randomly when one of the participant leaves
Created: 2020-04-27T11:43:27Z
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000446710 in janus_plugin_relay_rtp (plugin_session=0x2273756e616a227b, packet=0x7ff11e3d2130) 
2058		if((plugin_session < (janus_plugin_session *)0x1000) || g_atomic_int_get(&plugin_session->stopped) ||
[Current thread is 1 (Thread 0x7ff11e3e3700 (LWP 22193))]
Missing separate debuginfos, use: dnf debuginfo-install brotli-1.0.6-1.el8.x86_64 cyrus-sasl-lib-2.1.27-0.3rc7.el8.x86_64 glib2-2.56.4-7.el8.x86_64 glibc-2.28-72.el8_1.1.x86_64 gmp-6.1.2-10.el8.x86_64 gnutls-3.6.8-8.el8.x86_64 gupnp-1.0.3-2.el8.x86_64 gupnp-igd-0.2.5-4.el8.x86_64 jansson-2.11-3.el8.x86_64 keyutils-libs-1.5.10-6.el8.x86_64 krb5-libs-1.16.1-22.el8.x86_64 libblkid-2.32.1-17.el8.x86_64 libcom_err-1.44.3-2.el8.x86_64 libconfig-1.5-9.el8.x86_64 libcurl-7.61.1-11.el8.x86_64 libffi-3.1-18.el8.x86_64 libgcc-8.3.1-4.5.el8.x86_64 libidn2-2.0.5-1.el8.x86_64 libmicrohttpd-0.9.59-2.el8.x86_64 libmount-2.32.1-17.el8.x86_64 libnghttp2-1.33.0-1.el8.x86_64 libnice-0.1.14-7.20180504git34d6044.el8.x86_64 libogg-1.3.2-10.el8.x86_64 libpsl-0.20.2-5.el8.x86_64 libselinux-2.8-6.el8.x86_64 libsoup-2.62.3-1.el8.x86_64 libssh-0.8.5-2.el8.x86_64 libtasn1-4.13-3.el8.x86_64 libunistring-0.9.9-3.el8.x86_64 libxml2-2.9.7-5.el8.x86_64 nettle-3.4.1-1.el8.x86_64 openldap-2.4.46-9.el8.x86_64 openssl-libs-1.1.1-8.el8.x86_64 opus-1.3-0.4.beta.el8.x86_64 p11-kit-0.23.14-5.el8_0.x86_64 pcre-8.42-4.el8.x86_64 pcre2-10.32-1.el8.x86_64 xz-libs-5.2.4-3.el8.x86_64 zlib-1.2.11-10.el8.x86_64
(gdb) bt
#0  0x0000000000446710 in janus_plugin_relay_rtp (plugin_session=0x2273756e616a227b, packet=0x7ff11e3d2130)
#1  0x00007ff1517bf813 in janus_videoroom_relay_rtp_packet (data=0x7ff138004600, user_data=0x7ff11e3d23b0)
#2  0x00007ff161533695 in g_slist_foreach () at /lib64/libglib-2.0.so.0

Closing comment (2020-04-27T12:53:21Z): Duplicate of #2099 for which there's a pending fix already. Check existing issues before opening a new one.
Repository: meetecho/janus-gateway

Issue #3460: [1.x] Is there any way to do live streaming of video being recorded by a remote user on Janus
Created: 2024-10-23T04:55:32Z
What version of Janus is this happening on?
1.2.2
Have you tested a more recent version of Janus too?
No
Was this working before?
Not tried.
Is there a gdb or libasan trace of the issue?
No
Additional context
There is a scenario, where a user on a remote machine is recording his video using Janus. I want to run gstreamer to broadcast the live recording to another users sitting in another machines so that they can see the live recording in their browser or any such player.
Can we do it using gstreamer. Can gstreamer broadcast live recording i.e. MJR files.?

Duplicate issue #3461: [1.x] Is there any way to do live streaming of video being recorded by a remote user on Janus
Created: 2024-10-23T04:55:38Z
What version of Janus is this happening on?
1.2.2
Have you tested a more recent version of Janus too?
No
Was this working before?
Not tried.
Is there a gdb or libasan trace of the issue?
No
Additional context
There is a scenario, where a user on a remote machine is recording his video using Janus. I want to run gstreamer to broadcast the live recording to another users sitting in another machines so that they can see the live recording in their browser or any such player.
Can we do it using gstreamer. Can gstreamer broadcast live recording i.e. MJR files.?

Closing comment (2024-10-23T09:08:59Z): Duplicate of #3460.
Repository: meetecho/janus-gateway

Issue #2062: Crash in HTTP transport
Created: 2020-04-10T08:32:19Z
Hello.
I use Janus to broadcast video to other servers using rtp_forwarding.
I do not have accurate statistics of the crashes, but this happens after a few hours of work with a small load (about 5-7 videorooms, 1 participiant = 1 videoroom).
libmicrohttpd12: 0.9.59-1
logs: https://pastebin.com/raw/U53v9cT0

Duplicate issue #2071: Heap Use After Free in HTTP Transport
Created: 2020-04-15T14:31:08Z
Janus crashes intermittently with ~25 feeds in the VideoRoom with a use after free. Took a while to get this to happen intentionally, but I finally got an asan output - https://pastebin.com/KhhqmnnB
Running compiled from git at tag 0.9.2. Doesn't appear to be fixed in master.

Closing comment (2020-04-15T14:37:27Z): We already have two issues open on HTTP, of which this is very likely a duplicate: #2062 #2066. Please don't open issues that are already open next time.
Repository: meetecho/janus-gateway

Issue #1473: Check if transport wide CC is supported
Created: 2018-12-14T16:08:08Z
I'm testing janus/videocalltest.html with my local build.
commit 175eea78b2592382261190569ca3ff4d9b1608c1
Date:   Tue Nov 27 11:26:41 2018 +0100

I've discovered that videocalltest.htm and videoroomtest.html behave different.
In case of videoroomtest.htm I get less number of NACKs in my test environment.
In case of videocalltest.html
handle->stream->do_transport_wide_cc are different (0 and 1) for the connected peers,
but both local and remote SDP contain extmap:5 and "transport-cc" lines.
Remote SDP:
a=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=rtcp-fb:101 transport-cc

Local SDP:
a=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=rtcp-fb:107 transport-cc

I suspect do_transport_wide_cc is not set properly in case of answer. See janus.c:
				if(!offer) {
...
				} else {
					/* Check if transport wide CC is supported */
					int transport_wide_cc_ext_id = janus_rtp_header_extension_get_id(jsep_sdp, JANUS_RTP_EXTMAP_TRANSPORT_WIDE_CC);
					handle->stream->do_transport_wide_cc = transport_wide_cc_ext_id > 0 ? TRUE : FALSE;
					handle->stream->transport_wide_cc_ext_id = transport_wide_cc_ext_id;
				}

Duplicate issue #1893: Bitrate dropping on the caller side
Created: 2019-12-09T17:37:55Z
I'm experiencing a strange issue for about 2-3 weeks on Google Chrome 78 during video calls. The bitrate suddenly drops to 30kbits/s on the caller side few seconds after the beginning of the call and never gets higher again then.
I was thinking of an issue on my janus instance, but I've found the same problem on the demo website.

Closing comment (2019-12-09T17:40:42Z): Why are you folks not using the Search feature?
Duplicate of #1473, #1861 and #1890, see #1889.
Repository: meliorence/react-native-render-html

Issue #193: textSelectable does not work when texts are not in a tag and there are other tags
Created: 2018-11-10T20:52:17Z
Is this a bug report or a feature request?
This is a bug report.

Have you read the guidelines regarding bug report?
yes
Have you read the documentation in its entirety?
yes
Have you made sure that your issue hasn't already been reported/solved?
yes
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Android (dont have an iPhone to test)
Is the bug reproductible in a production environment (not a debug one)?
yes
Have you been able to reproduce the bug in the provided example?
yes

Environment

React: 16.5.0
React native: 0.57.1
react-native-render-html: 3.10.0

React: 16.3.1
React native: 0.56
react-native-render-html: 3.10.0

Steps to Reproduce

Please refer to this snack.
https://snack.expo.io/H16whhV6Q
Expected Behavior

If textSelectable is provided, all texts should be selectable.

Reproducible Demo

https://snack.expo.io/H16whhV6Q

Duplicate issue #362: textSelectable not working
Created: 2020-05-02T11:50:04Z
textSelectable prop does not work on Android or React Native Web.  My HTML component is part of a FlatList item, which may have something to do with the problem.
"react-native-render-html": "^4.2.0",
<HTML 
	            key={key}
	            html={body}
	            textSelectable={true} 
	            baseFontStyle={getStyle('bodyText', theme, largeText)}
	            onLinkPress={(event, href)=>{
	              //console.log('clicked: ', href)
	              WebBrowser.openBrowserAsync(href)
	            }}
	            tagsStyles={getTagsStyles(theme)}
	            classesStyles={getClassesStyles(theme)}
	            ignoredTags={['inline-block']}
	            alterData={(node) =>{
	              let { parent, data } = node
	              if(parent && parent.name === 'a' && /[^\u0000-\u00ff]/.test(data)){
	                return " "
	              }
	            }} 
	        />

Closing comment (2020-07-05T12:18:08Z): Possible duplicate of #193.
I'm closing because this issue does not follow our contribution guidelines. We need a full reproduction to help you out. Feel free to post a new compliant issue.