Repository: celestiaorg/celestia-app

Issue:
Remove `OVERRIDE_MAX_SQUARE_SIZE` and `OVERRIDE_UPGRADE_HEIGHT_DELAY`
## Context

`OVERRIDE_MAX_SQUARE_SIZE` and `OVERRIDE_UPGRADE_HEIGHT_DELAY` are unused

## Problem

They appear in multiple places

https://github.com/celestiaorg/celestia-app/blob/a34f56f0f83cd448f19b937d7639e26761a39dc1/docker/multiplexer.Dockerfile#L67-L68

https://github.com/celestiaorg/celestia-app/blob/a34f56f0f83cd448f19b937d7639e26761a39dc1/docker/Dockerfile#L44-L45

https://github.com/celestiaorg/celestia-app/blob/a34f56f0f83cd448f19b937d7639e26761a39dc1/Makefile#L12-L13

## Proposal

- Remove all usage of `OVERRIDE_MAX_SQUARE_SIZE`
- Remove all usage of `OVERRIDE_UPGRADE_HEIGHT_DELAY`

Hints from issue comments:

Solution patch:
diff --git a/.github/workflows/docker-build-publish.yml b/.github/workflows/docker-build-publish.yml
index 68a54af7..7a64c189 100644
--- a/.github/workflows/docker-build-publish.yml
+++ b/.github/workflows/docker-build-publish.yml
@@ -37,7 +37,6 @@ jobs:
       dockerfile: docker/multiplexer.Dockerfile
       checkout_ref: ${{ github.event.inputs.ref }}
       packageName: celestia-app
-      buildArgs: "TARGETOS=linux TARGETARCH=amd64"
     secrets: inherit
 
   docker-txsim-build:
diff --git a/Makefile b/Makefile
index efcfd4d9..90d7b285 100644
--- a/Makefile
+++ b/Makefile
@@ -9,8 +9,6 @@ PACKAGE_NAME          := github.com/celestiaorg/celestia-app/v4
 # Before upgrading the GOLANG_CROSS_VERSION, please verify that a Docker image exists with the new tag.
 # See https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross
 GOLANG_CROSS_VERSION  ?= v1.23.6
-# Set this to override the max square size of the binary
-OVERRIDE_MAX_SQUARE_SIZE ?=
 # Set this to override v2 upgrade height for the v3 embedded binaries
 V2_UPGRADE_HEIGHT ?= 0
 
diff --git a/docker/Dockerfile b/docker/Dockerfile
index ce6fb8da..39528fb2 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -41,8 +41,6 @@ COPY . .
 
 RUN uname -a &&\
     CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
-    OVERRIDE_MAX_SQUARE_SIZE=${MAX_SQUARE_SIZE} \
-    OVERRIDE_UPGRADE_HEIGHT_DELAY=${UPGRADE_HEIGHT_DELAY} \
     make build-standalone
 
 # Stage 2: Create a minimal image to run the celestia-appd binary
diff --git a/docker/multiplexer.Dockerfile b/docker/multiplexer.Dockerfile
index 795df893..863136e3 100644
--- a/docker/multiplexer.Dockerfile
+++ b/docker/multiplexer.Dockerfile
@@ -64,8 +64,6 @@ RUN tar -cvzf internal/embedding/celestia-app_${TARGETOS}_v3_${TARGETARCH}.tar.g
 
 RUN uname -a &&\
     CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
-    OVERRIDE_MAX_SQUARE_SIZE=${MAX_SQUARE_SIZE} \
-    OVERRIDE_UPGRADE_HEIGHT_DELAY=${UPGRADE_HEIGHT_DELAY} \
     make build DOWNLOAD=false
 
 # Stage 3: Create a minimal image to run the celestia-appd binary
diff --git a/go.mod b/go.mod
index 0c26a232..3c49954d 100644
--- a/go.mod
+++ b/go.mod
@@ -306,5 +306,5 @@ replace (
 	// goleveldb: canonical version
 	github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
 	// celestia-core(v0.34.x): used for multiplexing abci v1 requests
-	github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.45.0-tm-v0.34.35
+	github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.52.0-tm-v0.34.35
 )
diff --git a/go.sum b/go.sum
index 44f40346..9aa1bb1a 100644
--- a/go.sum
+++ b/go.sum
@@ -352,8 +352,8 @@ github.com/bytedance/sonic/loader v0.2.4/go.mod h1:N8A3vUdtUebEY2/VQC0MyhYeKUFos
 github.com/casbin/casbin/v2 v2.1.2/go.mod h1:YcPU1XXisHhLzuxH9coDNf2FbKpjGlbCg3n9yuLkIJQ=
 github.com/celestiaorg/bittwister v0.0.0-20231213180407-65cdbaf5b8c7 h1:nxplQi8wrLMjhu260RuigXylC3pWoDu4OVumPHeojnk=
 github.com/celestiaorg/bittwister v0.0.0-20231213180407-65cdbaf5b8c7/go.mod h1:1EF5MfOxVf0WC51Gb7pJ6bcZxnXKNAf9pqWtjgPBAYc=
-github.com/celestiaorg/celestia-core v1.45.0-tm-v0.34.35 h1:T21AhezjcByAlWDHmiVbpg743Uqk/dqBzJkQsAnbQf8=
-github.com/celestiaorg/celestia-core v1.45.0-tm-v0.34.35/go.mod h1:fQ46s1hYFTGFBsHsuGsbxDZ720ZPQow5Iyqw+yErZSo=
+github.com/celestiaorg/celestia-core v1.52.0-tm-v0.34.35 h1:iU2igosCxYKzEUi85u3YqNslIO+rCXtx4GKAHUzxrDQ=
+github.com/celestiaorg/celestia-core v1.52.0-tm-v0.34.35/go.mod h1:SI38xqZZ4ccoAxszUJqsJ/a5rOkzQRijzHQQlLKkyUc=
 github.com/celestiaorg/celestia-core v1.53.0-tm-v0.38.17 h1:AHjnWwPoOFH5zr+aPqdWkF1CutP1ynVEOGOuW1/8iq8=
 github.com/celestiaorg/celestia-core v1.53.0-tm-v0.38.17/go.mod h1:PiU80T/t0z8FPlz7DRZgvrBux0jJiqxFi9lNBFdGUps=
 github.com/celestiaorg/cosmos-sdk v1.29.1-sdk-v0.50.12 h1:EWJIBTMB9H2KFMqmNB22KvgqvAObqcToJbAdPCM+LBw=



Test patch:
diff --git a/test/docker-e2e/go.mod b/test/docker-e2e/go.mod
index 9fd96eda..195b66ac 100644
--- a/test/docker-e2e/go.mod
+++ b/test/docker-e2e/go.mod
@@ -272,12 +272,12 @@ replace (
 	github.com/celestiaorg/celestia-app/v4 => ../..
 	// celestia-core: v1.53.0-tm-v0.38.17
 	github.com/cometbft/cometbft => github.com/celestiaorg/celestia-core v1.53.0-tm-v0.38.17
-	// cosmos-sdk: v1.29.0-sdk-v0.50.12
+	// cosmos-sdk: v1.29.1-sdk-v0.50.12
 	github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.29.1-sdk-v0.50.12
 
 	github.com/gogo/protobuf => github.com/gogo/protobuf v1.3.2
 	// goleveldb: canonical version
 	github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
 	// celestia-core(v0.34.x): used for multiplexing abci v1 requests
-	github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.45.0-tm-v0.34.35
+	github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.52.0-tm-v0.34.35
 )