# Bug #51856 for DBD-Pg: [Patch] POD nits

This queue is for tickets about the DBD-Pg CPAN distribution

Report information

The Basics | Id: | 51856  
---|---  
Status: | resolved  
Priority: | 0/   
Queue: | DBD-Pg  
  
People

Owner: | greg [...] turnstep.com   
---|---  
Requestors: |  FWIE [...] cpan.org   
  
Cc:  
AdminCc:  
  
Bug Information | Severity: |  _(no value)_  
---|---  
Broken in: |  2.15.1   
Fixed in: |  2.16.0   
  
Attachments

pod.patch  
  
  
  


History

# Mon Nov 23 07:33:09 2009 FWIE [...] cpan.org - Ticket created

Subject: |  [Patch] POD nits  
---|---  
  
  
text/plain 84b

The attached patch fixes some POD, which renders wrong, at least at search.cpan.org. 

Subject: |  pod.patch  
---|---  
  
  
text/x-diff 3.4k

diff --git a/Pg.pm b/Pg.pm index 1753b87..3e34c0f 100644 \--- a/Pg.pm +++ b/Pg.pm @@ -1841,7 +1841,7 @@ host, like this: {AutoCommit => 0, RaiseError => 1}); The attribute hash can also contain a key named C<dbd_verbose>, which -simply calls C<$dbh->trace('DBD')> after the handle is created. This attribute +simply calls C<< $dbh->trace('DBD') >> after the handle is created. This attribute is not recommended, as it is clearer to simply explicitly call C<trace> explicitly in your script. @@ -1888,7 +1888,7 @@ indicates no error (CONNECTION_OK), while any other number indicates a failed co only other number commonly seen is 1 (CONNECTION_BAD). See the libpq documentation for the complete list of return codes. -In all other non-connect methods C<$h->err> returns the C<PQresultStatus> of the current +In all other non-connect methods C<< $h->err >> returns the C<PQresultStatus> of the current handle. This is a number used by libpq and is one of: 0 Empty query string @@ -1915,8 +1915,8 @@ Returns a five-character "SQLSTATE" code. Success is indicated by a C<00000> cod gets mapped to an empty string by DBI. A code of C<S8006> indicates a connection failure, usually because the connection to the Postgres server has been lost. -While this method can be called as either C<$sth->state> or C<$dbh->state>, it -is usually clearer to always use C<$dbh->state>. +While this method can be called as either C<< $sth->state >> or C<< $dbh->state >>, it +is usually clearer to always use C<< $dbh->state >>. The list of codes used by PostgreSQL can be found at: L<http://www.postgresql.org/docs/current/static/errcodes-appendix.html> @@ -1992,7 +1992,7 @@ Outputs all SQL statements. Note that the output provided will not necessarily be in a form suitable to passing directly to Postgres, as server-side prepared statements are used extensively by DBD::Pg. For maximum portability of output (but with a potential performance -hit), use with C<$dbh->{pg_server_prepare} = 0> +hit), use with C<< $dbh->{pg_server_prepare} = 0 >>. =item DBD @@ -2580,7 +2580,7 @@ constraint, and which uses a sequence as a default value. If more than one colum meets these conditions, the primary key will be used. This involves some looking up of things in the system table, so DBD::Pg will cache the sequence name for subsequent calls. If you need to disable this caching for some reason, -(such as the sequence name changing), you can control it by adding C<pg_cache => 0> +(such as the sequence name changing), you can control it by adding C<< pg_cache => 0 >> to the final (hashref) argument for last_insert_id. Please keep in mind that this method is far from foolproof, so make your diff --git a/t/lib/App/Info.pm b/t/lib/App/Info.pm index e3df872..3112597 100644 \--- a/t/lib/App/Info.pm +++ b/t/lib/App/Info.pm @@ -1184,7 +1184,7 @@ handling arguments to set up the event handlers, so that when we call C<confirm()> or C<unknown()> the event will be handled as the client expects. If we needed our subclass constructor to take its own parameter argumente, the -approach is to specify the same C<key => $arg> syntax as is used by +approach is to specify the same C<< key => $arg >> syntax as is used by App::Info's C<new()> method. Say we wanted to allow clients of our App::Info subclass to pass in a list of alternate executable locations for us to search. Such an argument would most make sense as an array reference. So we specify 

# Fri Dec 11 18:34:32 2009 greg [...] turnstep.com - Taken

# Fri Dec 11 18:36:02 2009 greg [...] turnstep.com - Correspondence added

  
text/plain 98b

Thank you! Applied in svn (r13584), will be in the next release (which will be 2.15.2 or 2.16.0) 

# Fri Dec 11 18:36:03 2009 The RT System itself - Status changed from 'new' to 'open'

# Fri Dec 11 18:36:04 2009 greg [...] turnstep.com - Status changed from 'open' to 'patched'

# Fri Dec 18 12:50:00 2009 greg [...] turnstep.com - Fixed in 2.16.0 added

# Fri Dec 18 12:50:00 2009 greg [...] turnstep.com - Status changed from 'patched' to 'resolved'