liferay/liferay-portal — pull request #657 by javeedchida (2014-12-31 17:18:52+00:00)
Title: LPS-52186 Added a basic confirmation dialog to satisfy feature request

My changes in sitemap.jsp started out as a modification of the existing tag whereby I set its href to a javascript invocation. My tests revealed Firefox doesn't play well with that. So I went with the more proper approach of pining the href attribute to "#" and adding an onclick event to the tag. But then I ran into a problem with not respecting my "return false" to prevent the default behavior of the link. So I used a straight html anchor tag and augmented it to do what was doing for me, namely: added a span to address the "opens in a new window" icon and a title attribute for accessibility.

If there is a way to still use , I'll be glad to improve this solution.