dnnsoftware/Dnn.Platform — pull request #251 by janjonas (2014-12-31 15:53:22+00:00)
Title: Fixed DotNetNuke.UI.Skins.ControlsLanguageTokenReplace.NewUrl() to not remove query string parameters

Please see https://dnntracker.atlassian.net/browse/DNN-6310 for more information.

This pull request removes a logic that was introduced with this pull request https://github.com/sachatrauwaen/Dnn.Platform/commit/f98b4a3e5e05bc67200d1a6572c43f0c5bfd00dd created by @sachatrauwaen

if (DotNetNuke.Entities.Host.Host.UseFriendlyUrls && !islocalized ) {
[...]
}

I do not see a reason for not adding the query string when creating the "change language"-links, because query parameters that are "encoded" in the path (like the "Id" parameter in http://.../Home/Id/1?category=2) are not removed when creating links to the same page in other languages.

In other words: I would either remove all parameters (from query string and paths) or none of them when creating "change language links". IMHO, the current logic is confusing, because only query string parameters are removed.