Rise-Vision/storage-server — pull request #87 by tejohnso (2014-12-31 22:53:12+00:00)
Title: Reduce complexity of batchrequestgenerator

The BatchRequestGenerator was doing filtering on the items it was passed. It was doing this by calling a potentially overridden method. Instead, the BatchRequestGenerator expects to receive valid items. The filtering can be done before the parameter is passed in since that filtering will be specific to the calling class. This simplifies the dependency chain and removes the anonymous subclassing of BatchRequestGenerator with the overridden method.

The BatchRequestGenerator was also expecting a possibly overridden iteration request but this was unused. And it could probably be implemented by supplying a different class than the current StorageRequestIterator if necessary rather than doing some overriding in a subclassed BatchRequestGenerator.

@fjvallarino please review