rockpoollabs/env — pull request #6 by wayneeseguin (2014-12-31 20:35:45+00:00)
Title: Cleaned up shell code.

I came across your repository and was browsing it, when I got to this file I couldn't resist sending a few suggestions your way:

* $PWD is automatically available when using BASH, so there is no need for PWD=`pwd`
* If you were to use a subshell be sure to use $() instead of ``.
* it DRY's things up a bit to have a single export line for the variables if you are exporting multiple variables
* Technically exporting PATH is redundant since it is exported by default, but being explicit doesn't hurt.
* Quoting the variable assignments ensures that you are never caught by spaces and perhaps other special characters in your path name which would break the script otherwise.
* Best to reserve all uppercase variable names for exported variables only, script local variables use lower case variable names with naming conventions similar to go style.