misd-service-development/guzzle-bundle — pull request #78 by billydavies (2014-12-29 13:57:19+00:00)
Title: Change param converter guzzle client registration 'skipping' logic.

Hi,

First up great work on this bundle, it's been really useful, so thanks for sharing.

I was finding that the GuzzleParamConverter wasn't finding my tagged Guzzle client service and I debugged it back to a line in the ClientCompilerPass.php file. I was using the default 'Guzzle\Service\Client' client class via the %guzzle.client.class% parameter mentioned in the docs. As you can't instantiate interface classes I've changed a piece of the logic in the ClientCompilerPass.php file that controls whether a client will be registered or not with the ParamConverter. I initially though about changing it to test whether the class is 'Guzzle\Service\Client' but as this class implements 'Guzzle\Service\ClientInterface' then this didn't seem to add value.

If I've done something wrong in my usage of the bundle feel free to correct me.

Many thanks,

Billy