LMMS/lmms — pull request #1524 by badosu (2014-12-29 03:02:40+00:00)
Title: Collect effects errors to show on summary window

Instead of showing serial warning messages when loading a project and having problems with effects, collect them for posterior summarization.

This is similar to #55 but for errors when loading LADSPA effects.

Please note the removed `Engine::setSuppressMessages` calls due to the fact that these messages will already not be shown until `mainWindow()->showErrors` is called. This should not affect the errors for other songs as the list of errors is cleared on the beggining of the song opening function.

There are other places where we can already replace those message boxes with collect errors, for example [here)(https://github.com/badosu/lmms/blob/collect-effects-errors/plugins/MidiImport/MidiImport.cpp#L98-L122). The main advantage is that we can abstract on `showErrors` if we are on GUI or CLI and then put the errors on standard out or the message box. We then can get rid of many `hasGUI` calls and probably enable visualizations of errors on the CLI export (I guess they are hidden today?). But for now I am going to fix just the simple case.

Since this is an improvement over a feature that has broken CLI export feature, please merge #1513 before so that I can rebase this PR over on master, it is a very simple and straightforward bugfix.

Before (3 messages like this):

![2014-12-28-061002_534x171_scrot](https://cloud.githubusercontent.com/assets/347552/5565878/5050ac8e-8ef5-11e4-84ea-b5eb0e987c58.png)

After:

![2014-12-29-005242_592x347_scrot](https://cloud.githubusercontent.com/assets/347552/5565883/78e62322-8ef5-11e4-9920-4d78247025fa.png)