WhisperSystems/Signal-iOS — pull request #248 by corbett (2014-12-29 04:07:30+00:00)
Title: Groups bugfixes

1,2,5,7,8,9,10,11 fixed/wontfix/notes
bugfixes for groups-bugfixes (remaining: synchronicity issues 3,4,6)
FIXED 1) Resign first responder in new group view when tapping camera icon. Otherwise, keyboard hides action sheet choices.
FIXED 2) Have a list of participants UI
3) Non-blocking UI on group create with attachment
4) I created a group on iOS, name doesn't show up on Android, neither does the avatar.
-will be fixed by proper treatment of 3)
FIXED 5) I shouldn't be able to remove myself from the participants list.
6) Sending is terribly laggy
-will be fixed by 3)
WONTFIX 7) Message should be Group Created and not Group updated if new group.
-this is not the case on android! I am punting this for now and we can fix when we do the localized strings.
FIXED 8) Leaving group doesn't appear to be working (tried with android group)
FIXED (with caveats) 9) Receiving messages in deleted group causes weird messageviewcontroller to show up
-ignore messages from a group you have left according to your understanding? what should the correct behavior be here? doing that for now.
-tableViewCellTappedDelete (the fact that the group model lives in a thread the group model goes away when the thread does!) this will cause a major refactoring, unfortunately to be changed. for now this causes a group leave event and then deletes the thread, which makes sense to the user. not sure what android does here. message leave received.
-seems like we should actually store the groups separately (forever)! and then we will no if a user leaves, but is later readded! otherwise a group update message is sent... not a new group message. and without a group to compare to what should we do.
WONTFIX 10) Avatar Image doesn't have reference-counting and will never be deleted, even if group is.
I am punting this for now. we should open an issue. generically this issue should also make sure the group avatar is small.
FIXED 11) Android user leaving group is causing a "Name changed" info message