skylot/jadx — pull request #35 by YASME-Tim (2014-12-19 22:45:14+00:00)
Title: Removed some warnings about collections without type specifiers, see appendix.

--more--
Please generate the serialVersionUIDs with eclipse or serialver.
I removed the warnings by adding type specifiers without testing the framework (gui), so please check again, if these changes are valid and don't destroy jadx.

Reference links:
http://stackoverflow.com/questions/197986/what-causes-javac-to-issue-the-uses-unchecked-or-unsafe-operations-warning
http://stackoverflow.com/questions/7823140/warning-rawtypes-found-raw-type-defaultlistmodel
http://docs.oracle.com/javase/7/docs/api/javax/swing/JList.html
http://stackoverflow.com/questions/7823477/warning-serial-serializable-class-someclass-has-no-definition-of-serialversio
http://www.mkyong.com/java-best-practices/understand-the-serialversionuid/
http://stackoverflow.com/questions/2770321/what-is-a-raw-type-and-why-shouldnt-we-use-it

--appendix--
warning: [options] bootstrap class path not set in conjunction with -source 1.6
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/treemodel/JNode.java:12: warning: [serial] serializable class JNode has no definition of serialVersionUID
public abstract class JNode extends DefaultMutableTreeNode {
^
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/treemodel/JRoot.java:127: warning: [rawtypes] found raw type: Enumeration
Enumeration en = this.breadthFirstEnumeration();
^
missing type arguments for generic class Enumeration
where E is a type-variable:
E extends Object declared in interface Enumeration
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/utils/Link.java:20: warning: [serial] serializable class Link has no definition of serialVersionUID
public class Link extends JLabel implements MouseListener {
^
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:74: warning: [rawtypes] found raw type: JList
private JList resultsList;
^
missing type arguments for generic class JList
where E is a type-variable:
E extends Object declared in class JList
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:174: warning: [rawtypes] found raw type: DefaultListModel
private static class ResultsModel extends DefaultListModel {
^
missing type arguments for generic class DefaultListModel
where E is a type-variable:
E extends Object declared in class DefaultListModel
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:184: warning: [unchecked] unchecked call to addElement(E) as a member of the raw type DefaultListModel
addElement(JNode.makeFrom(results.get(i)));
^
where E is a type-variable:
E extends Object declared in class DefaultListModel
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:189: warning: [rawtypes] found raw type: ListCellRenderer
private static class ResultsCellRenderer implements ListCellRenderer {
^
missing type arguments for generic class ListCellRenderer
where E is a type-variable:
E extends Object declared in interface ListCellRenderer
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:200: warning: [rawtypes] found raw type: JList
public Component getListCellRendererComponent(JList list,
^
missing type arguments for generic class JList
where E is a type-variable:
E extends Object declared in class JList
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:247: warning: [rawtypes] found raw type: JList
resultsList = new JList(resultsModel);
^
missing type arguments for generic class JList
where E is a type-variable:
E extends Object declared in class JList
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:247: warning: [unchecked] unchecked call to JList(ListModel) as a member of the raw type JList
resultsList = new JList(resultsModel);
^
where E is a type-variable:
E extends Object declared in class JList
/Users/pol/git/jadx/jadx-gui/src/main/java/jadx/gui/ui/SearchDialog.java:248: warning: [unchecked] unchecked call to setCellRenderer(ListCellRenderer) as a member of the raw type JList
resultsList.setCellRenderer(new ResultsCellRenderer());
^
where E is a type-variable:
E extends Object declared in class JList
12 warnings