ding2tal/ding_redirect — pull request #1 by vibjerg (2014-12-18 13:10:40+00:00)
Title: Initial review

I have made a review of the module, and I have a few remarks

1. The js seems to be dependent on a version of jquery that does not ship with drupal, and there is no dependencies to a module that includes a newer version.
2. The two js files seems to overlab a lot with functionality, and could be combined to one. I think the removal of double code outweighs, the extra foodprint that is added to the two different scenarios the two files covers.
3. the css attacks specific ID's. There should be a reason for doing this, and it should be documented.