CodyReichert/shakespeare-mode — pull request #1 by purcell (2014-12-14 11:41:21+00:00)
Title: Remove redundant code already generated by define-derived-mode

(In connection with https://github.com/milkypostman/melpa/pull/2276)

`define-derived-mode` already does things like run the mode hooks and set the mode name. This commit removes the unnecessary code, and also removes the redundant marking of `font-lock-defaults` as a local variable: it's local by default.

Untested, so please give it a whirl.

In general, the munging of the local mode map to use `shakespeare-mode-map` seems wrong to me. I think you should define a minor mode `shakespeare-mode` with its own map & hooks etc., and then just enable it automatically in the various template major modes: you can make the modeline `:lighter` empty to keep it invisible.

Oh, and *please* don't override `C-j`. I can't see any reason for this other than personal preferences.

Hope that helps! :-)