troessner/reek — pull request #350 by troessner (2014-12-13 11:28:05+00:00)
Title: Get rid of all smell parameter constants.

This PR gets rid of all parameter constants in our smell detectors, fixes #332 but leaves the parameters itself there since they are used in our spec matcher and our yaml output.

This PR also makes the "parameters" names consistent. For instance, take a look at "UncommunicativeMethodName" which contained:

>> METHOD_NAME_KEY = 'method_name'

"method_name" is in fact a knowledge duplication - "name" is speaking enough since it is absolutely clear given the context. Most of the parameter names duplicated knowledge regarding the SmellDetector somehow.

So I replaced most of them with consistent naming:

- 90% of all parameter are now just "name" and / or "count"
- there are a couple of exceptions where it made sense to deviate from this schema, mostly "DataClump" and "NestedIterators".