mapbox/mapbox-ios-sdk — pull request #554 by tylrtrmbl (2014-12-09 06:52:47+00:00)
Title: Use localized NSLocationWhenInUseUsageDescription key for assert

From Apple’s Bundle Programming Guide:

> The `NSBundle` class provides the `objectForInfoDictionaryKey:` and `infoDictionary` methods for retrieving information from the `Info.plist` file. The `objectForInfoDictionaryKey:` method returns the localized value for a key and is the preferred method to call. The `infoDictionary` method returns an `NSDictionary` with all of the keys from the property list; however, it does not return any localized values for these keys. For more information, see the *NSBundle Class Reference*.

This was an issue I ran into first hand.

##### Tests Run

1. Have localized `NSLocationWhenInUseUsageDescription` only (in `InfoPlist.strings`)
2. Have unlocalized `NSLocationWhenInUseUsageDescription` only (in standard Info.plist)
3. Have both
4. Missing both

Expected behavior in all cases; 1-3 do not assert, 4 does assert.
Before this PR, 1 unexpectedly asserts.

Closes #548.