dCache/dcache — pull request #1159 by gbehrmann (2014-12-06 13:03:51+00:00)
Title: admin: Fix error reporting

admin shell erroneously logs remote RuntimeExceptions as bugs. This is
a regression introduced in version 2.9 due to UserAdminShell rethrowing
remote errors.

CellCommandInterpreter already does a local classification of runtime
exceptions into bugs and non-bugs (depending on the throws clause of
the message handler). RuntimeExceptions are propagated and logged
by CellNucleus as uncaught exceptions.

This patch changes the CommandInterpreter to propagate bugs as
CommandPanicException. The admin service is updated to properly
report these as bugs. Likewise, CommandThrowableExceptions are
no longer treated as fatal as these simply represent an regular
error reported by a command. The dispatch code is update to wrap
non-bug remote errors in CommandThrowableException.

Finally, the wording of the bug reporting code in the admin shell
is adjusted for grammar and precision.

Target: trunk
Request: 2.11
Request: 2.10
Request: 2.9
Require-notes: yes
Require-book: no
Acked-by: Tigran Mkrtchyan
Acked-by: Karsten Schwank
Patch: https://rb.dcache.org/r/7556/
(cherry picked from commit b2861a63e8051b34b7f5a21e92955a8387ce5a84)

Conflicts:
modules/dcache/src/main/java/diskCacheV111/admin/UserAdminShell.java
modules/dcache/src/main/java/org/dcache/services/ssh2/ConsoleReaderCommand.java