ThePacielloGroup/WebAccessibilityToolbar — pull request #45 by matatk (2014-12-06 13:06:41+00:00)
Title: Improving UI consistency

Currently there are three types of button/menus on the toolbar, as follows:

- **Buttons**
- CCA
- aViewer
- **Menus**
- Check
- CSS
- Images
- Structure
- Tables
- Frames
- Doc Info
- Dev
- Refs
- Browsers
- **Button+Menus**
- About
- IE

The button+menus have both an action when clicking on the button and a drop-down menu. Whilst it makes it quick to get to the button’s action, it does present the following problems:

- It is hard to see the differentiation between the button and the menu, so some users may think it’s only a button and others may think it’s only a menu, and when it acts otherwise, it can be confusing.
- It is hard to click on the drop-down menu because the click target is small.
- It is not clear what the button’s action actually would do.

**This PR changes the buttons+menus into menus**, moving the action of the button to the first menu item instead, **thus simplifying the UI into only buttons and menus.** It has the following advantages:

- The UI is simpler; we have only buttons, or menus.
- Click targets are bigger; visual cues are more striking.

The PR also (and I should've done this separately, d'oh) tidies up `wat/Translation.ini` a bit more and updates the setup filenames to make them more readable.

Please note the following:

- The buttons for CCA and aViewer are still buttons, so it’s still very quick to get to those tools specifically.
- The IE Settings dialog window (presumably provided by `WAT_IESet.exe` and `x64/WAT_IESet.exe`) duplicates some of what’s in the IE Settings menu (presumably for quicker access); this PR would remove those dialogs, instead just using the menu. One of two things should happen:
- Either we ask Jun to remove the ‘iesttings’ code that launches the dialogs (this code appears to be in `Accessibility_Toolbar.dll` for both 32- and 64-bit.
- Or we decide to go with the dialog over the menu (I’d not recommend this due to the extra security warnings it causes Windows to emit) and ask Jun to put the things that are currently only in the menu into the dialog.
- There seems to be a feature/bug in the toolbar shell code whereby the whole toolbar is shifted vertically upwards a few seconds after it’s first drawn. Removing the dropdown buttons seems to have made this more pronounced — presumably it was done to enable the dropdown buttons to be drawn correctly in the first place. I think we’ll need Jun’s help to address this. It is usable in the meantime, but does not look quite as good as it used to.