excon/excon — pull request #448 by mathias (2014-12-05 00:22:12+00:00)
Title: Deprecate omit_default_port option, add include_default_port option

- Port being added to URL can be forced by using include_default_port option
- Simplifies some of the port addition code
- Break out logic to determine if a default port is logic into its own method
- Tests basic cases of scheme+port combinations

This is a **big change** in terms of default functionality, and I suspect it will affect the gem users enough that it is worth considering what kind of version bump it'd require.

Additionally, I'd like to have deprecation warnings when the `omit_default_port` option is used with Excon, but I am not sure which method to add the detection and warning output to. Thoughts?

Fixes #357. Per discussion in #357, this should only add the port to the URL when `include_default_port` is specified or the port was included in the original URL.