joomla/joomla-cms — pull request #5300 by big-wave-tim (2014-12-03 12:48:58+00:00)
Title: Fix for issue #5286 "UX Issue: Error message should display in Red color instead of green text"

This is a fix for Issue #5286 "Fix for UX Issue: Error message should display in Red color instead of green text"

Call to enqueueMessage didn't have a message type passed to it. As a result enqueueMessage was defaulting to type 'message' (green message box) irrespective of the installation outcome.

Fix - introduced $msgType variable which is set according to installation outcome just after the $msg is initialised.

Recreated error on local joomla installation. Removed files from a Joomla components zip file, installed Joomla component via "Upload Package File" method, installation failed with green message box.

Tested installing via "Upload Package File" with both correct and broken zip files, all functioned as expected.

**First pull request ever so please forgive any mistakes!!**