cloudfoundry/java-buildpack — pull request #117 by jghiloni (2014-12-04 03:36:39+00:00)
Title: Fix buildpack_version to work natively in windows

The packaged output of the java buildpack has the git hash of the most recent baseline appended to the filename. The code that does this makes some unix-centric assumptions that break things when built natively in windows. Specifically:

* Ruby Pathname objects require the correct path separator, so appending "../../.git" results in a non-existent directory. Using the Pathname.join method resolves the issue
* To find the git executable, the class calls the native "which" command, and that does not exist in windows. As of Windows 2003, the "where" command exists and is comparable, so use that when on Windows environments.

I've tested this on Windows 8.1 and Ubuntu 14.04 LTS to ensure it didn't break things, with no ill effects noted. Note that the tests didn't complete successfully on Windows, but I think that's more an issue of the tests on Windows rather than the code change itself.