mozilla/treeherder-ui — pull request #286 by tojonmz (2014-12-03 17:41:53+00:00)
Title: Bug 1030686 - Add keyboard shortcut for save job classification

This work fixes 'part 3' of Bugzilla bug [1030686](https://bugzilla.mozilla.org/show_bug.cgi?id=1030686) requested by philor in [comments 8 and 11](https://bugzilla.mozilla.org/show_bug.cgi?id=1030686#c11).

This feature saves a job classification in its entirety, on a ctrl + enter.

I've only run it locally without a vagrant, so I can't confirm the actual save is occurring, but it is functionally doing the same as the save() when pressing the equivalent menu entry. I've tried it in workflows using the new 'r' for pin plus enter a related bug, regular pinning, and you can do everything including save without taking your hands off the keyboard.

Here's a screen grab of an attempted save (not logged in). An expected save() and result:

![saveclassificationshortcut](https://cloud.githubusercontent.com/assets/3660661/5284747/7e66c0a6-7ae4-11e4-8adc-ed5bf88ac573.jpg)

I updated the help as usual with the new entry 2nd from the bottom. I tweaked the wording of select to pin also while I was there, for more clarity.

![saveclassificationshortcuth](https://cloud.githubusercontent.com/assets/3660661/5284777/a8e52ba6-7ae4-11e4-9c26-7dff8cecb747.jpg)

This all very much mimics the previous work in PR https://github.com/mozilla/treeherder-ui/pull/281, and will be similar to the shortcut to enter a classification, still tbd.

I am also testing against the Alt modifier to ensure it is not also depressed at the same time. Otherwise I could depress Alt+Ctrl+Enter and issue the save(). I am not sure why the bulk of the other shortcuts don't test for Alt but it seems reasonable in this case. Let me know if I should exclude it.

We also test to make sure the pinboard is visible, per the thread with philor in [comment 18](https://bugzilla.mozilla.org/show_bug.cgi?id=1030686#c18).

Tested on Windows:
FF Release **33.1.1**
Chrome Latest Release **39.0.2171.71 m**

Adding @camd and/or @maurodoglio for review, and @edmorley for visibility.