jasonlanderson/graf — pull request #45 by jackfengibm (2014-12-03 17:24:25+00:00)
Title: preserve null values at time of rendering the API data

The three data tables on the dashboard page shows aggregations of metrics such as PRs or commits by certain attributes, such as company names and user names. Unfortunately, there are such cases where company name and user names are missing. While there is only one company without a name, there were 140 github accounts without user names at one point in time. The missing user names manifest themselves as null values in our underlying database, mysql, and they seem to interfere with the aggregation. The 'Contribution by engineers' module on the dashboard bears the direct impact of this problem. One solution considered was to exclude those github accounts without user names, but that led to a concern of distorting the grand total count of metric and hence the percentage of aggregation. An alternative approach was to backfill the missing user names with github login ids. Since the login id is a mandatory entry when creating a github account, this approach eliminates all the problem associated with empty user names and hence makes the mechanism of filtering out empty user names obsolete. This PR is remove the filtering logic.