openstreetmap/iD — pull request #2467 by bhousel (2014-12-03 03:32:58+00:00)
Title: Don't pass extra arguments from map to Entity initializer

fixes #2465

Map passes extra arguments to the callback, including the contents of the original array. The array was getting passed down to the initializer function and imported as properties into each Entity.

I still think there is a potential issue with the history restoring code... on line 240 where it rebases these originals back into the base graph -- isn't it possible that newer versioned entities are already loaded and this rebase call will do nothing (say if the user was is looking at that tile and the API fetched them before the user chose to restore their history)?

I think rebase needs something like a `--force` option for when restoring from localstorage.

Thoughts, @jfirebaugh?