edengci/eden — pull request #8 by eeshangarg (2014-12-03 04:52:14+00:00)
Title: Find a todo in the code and do it[For GCI]

If you notice the todos in the files that I modified, they are about moving the "datetime" code to eden.modules.tests.web2unittest.py. Well, this has already been done. There are some staticmethods in the web2unittest.Web2UnitTest class that do the job that the datetime code below does. And all of the test classes in these files that I modified inherit from web2unittest.Web2UnitTest, so it was just a matter to call the today(), now(), now_1_day() and now_1_week methods. :)

Here:

You cannot test these changes because the tests for this section are not working due to a testing bug that @ptressel and I are working on. But I think I am sure I did it right, the static methods i am talking about do the same job as the datetime code below does. Not to mention that fixing the testing bug could take days. I won't be able to move on to the next task.

If you go here: . You'll see the today() and now*() methods in action doing exactly the same thing the datetime code I removed and replaced with method calls below does.

My commit below has laready been reviewed by @Nostraa and he says that it can be merged. Thanks to @ptressel and @Nostraa for their amazing guidance. :)

Please let me know if something needs to be improved in order to get this merged, I would love to work on it.

Thanks & regards,
Eeshan Garg