openshift/openshift-extras — pull request #507 by Miciah (2014-12-02 23:57:29+00:00)
Title: Bugs 1169996, 1169997, 1128275, 1125069, 1165286, and 1158781

##### `openshift.ks`: Fix `display_passwords` output

Fix the initialization of the `matchingvar` variable to initialize the correct variable.

This commit fixes bug 1169996.

##### `openshift.ks`: only backup fw conf if it exists

`configure_firewall`: Only try to read and backup `/etc/sysconfig/system-config-firewall` if it exists.

This commit fixes bug 1169997.

##### `openshift.ks`: Avoid using `eval`

Where possible, avoid using `eval` by making the following changes:

• Use `printf -v` for indirect assignment.

• Use `${!foo}` for indirect expansion.

• Remove unnecessary use of `eval` for indirect function invocation.

• Remove unnecessary use of `eval` for regular parameter expansion and word splitting.

It is still necessary to use `eval` to define functions in several places, as far as I can tell.

This commit fixes bug 1128275.

##### `openshift.ks`/`oo-install`: Get rsync key post-deploy

Move the invocation of `install_rsync_pub_key` from the `configure_openshift` function to the `post_deploy` function so that the `wget` command in `install_rsync_pub_key` will run after httpd is fully configured and restarted.

Modify `oo-install` to run the `post_deploy` step on each node host in addition to running it on the first broker host.

This commit fixes bugs 1125069 and 1165286.

##### `openshift.ks`: Fix default routing plug-in password

Change the default value for `CONF_ROUTING_PLUGIN_PASS` from 'routinginfopassword' to 'routinginfopasswd' so that the default password that `openshift.ks`/`openshift.sh` sets in `/etc/activemq/activemq.xml` will match the default password that the rubygem-openshift-origin-routing-daemon package ships in `/etc/openshift/routing-daemon.conf`.

This commit fixes bug 1158781.