Themekraft/_tk — pull request #39 by greg-raven (2014-12-02 14:54:46+00:00)
Title: Suggestions for formatting changes

Maybe I use Bootstrap differently than others, but these two changes seem to me to be more in line with the way Bootstrap is meant to be used.

For the first suggestion, I don't like having an h4 immediately after an h1 for semantic reasons, so changing this to a p tag with the built-in Bootstrap class of lead seems more correct.

For the second suggestion, my understanding is that the top of a "normal" Bootstrap page has two alternatives: jumbotron and page-header. I suppose you can use either farther down the page in the live area, but there are other alternatives for the live area, whereas the header appears just once per page. Therefore, using the page-header class for sub-headings on the page seems wrong to me. Eliminating this class from the below-the-header headers seems more correct, although perhaps there's another class that could be substituted. Or, perhaps there should not be a header tag in the live area in the first place, as this is where I would typically use the article or section tags.

This is my first time doing the whole fork/change/pull request thing, so I hope I'm doing it correctly. Any advice is welcome. Thanks.