joomla/joomla-cms — pull request #5276 by Hackwar (2014-12-01 20:31:25+00:00)
Title: ContentHelperRoute::getArticleRoute needs to be called with catid and language

While working on #5140, I noticed that we never use the language value of the article when calculating the URL for it. Basically it means that we don't care if an english article is assigned to a french menu item, etc. Long story short: If you want to get the right URL, you need to provide the article ID, the category ID and the language.

Testing instructions: See that Joomla now creates the same and right URLs everywhere. Except for the TOS in the user plugin... Can't fix that one...
This testing instructions actually mean, that this needs a code review rather than a test.

For those looking for numbers: We have 35 files where ContentHelperRoute::getArticleRoute is called. Only in 3 of those files we are using the right language parameter.