d-torrance/dockapps — pull request #2 by rnjacobs (2014-12-02 04:25:41+00:00)
Title: Keep mute state from getting out of sync with reality

My hardware doesn't have a mute toggle on all its channels, so AlsaMixer really oughtn't indicate that it's muted something it can't.

Additionally, there is (was, before this patch) racey behavior between AlsaMixer polling the mixer device and the mVolumeMute copy of the mute state; by telling it to toggle the status and then setting the value according to what it reads back we avoid that.

Unrelatedly, my own local build does away with the status light on bottom altogether, but that requires losing middle-click-to-execute support, so may not be worth sharing.