brianchandotcom/liferay-portal — pull request #22551 by shuyangzhou (2014-11-29 18:43:25+00:00)
Title: LPS-51894 Broken DB generation with too small initial counter value

Brian, I found this while I am optimizing CI server build.

Since I am change the test execution order, by a random chance ListTypePersistenceTest got move to the first running test in a batch. Exposed this issue.

Just see portal-data-common.sql the last line, we are already using up to 12020 for ListType pk, but portal-data-counter.sql were still using initial value of 10000.

We did not see this, because, when you run other tests ahead, they use counter (for other tables), even we technically are generating duplicate pk values, but they are for different tables. When the tests reach ListTypePersistenceTest, it already passed over 12020, therefore we got lucky to pass them all the time.