leethomason/tinyxml2 — pull request #234 by Dmitry-Me (2014-11-28 09:12:05+00:00)
Title: Error checking never actually checked anything

This likely causes https://github.com/leethomason/tinyxml2/issues/233

Look at what `XMLDocument::Clear()` does. It first sets `_errorID = XML_NO_ERROR;` and then later calls `Error()` which compares `_errorID` against `XML_NO_ERROR`. So `Error()` is always *false* at that point and the check doesn't relly check anything and the *if* inner code is being run at all times.