Metaswitch/cpp-common — pull request #202 by bossmc (2014-11-27 19:35:19+00:00)
Title: Reviewer Mike - Handle DNS errors sensibly

If this is the first time we've requested a domain from DNS, we don't fully populate the cache record (in particular we don't set the expiry), if we then fail to contact the DNS server we jump over a load of processing then store the (empty) cache record for the time specified in the expiry (which is normally massive).

This fix ensures we'll continue to use the last seen value for a record for 30 more seconds if the DNS server fails to respond. Note that `NXDOMAIN` counts as a successful response so doesn't trigger this branch, errors indicate incorrect DNS configuration or death of the DNS server.