HabitRPG/habitrpg-shared — pull request #372 by ShilohT (2014-11-27 04:53:39+00:00)
Title: Standardization of locales/en/gear.json

This is the same as pull request #366 . New pull request from new branch, because my develop branch got really messy. (and this fixes the merge conflict issue)

>A few days ago, Sulfirh mentioned in the Aspiring Legends guild that many of the Mystery Items were lacking Month and "Confers no benefit." notes. I went to take a look at gear.json and saw a lot more things that were inconsistent. I welcome feedback and I hope I'm not stepping on any toes by doing this!

>**Changelog in the commit notes.**

>**Some thoughts for discussion:**
>Placement of "Confers no benefit." in the middle vs the end: I think of 'Confers no benefit.' as a stat effect tag, so it should be in the same place as that would be. I can sort of see how one might want it at the end instead though. Thoughts?
>A few of the holiday accessories were using "Confers no stat bonus." instead. I kind of like this phrasing better than "Confers no benefit.". This is just a find/replace to change anytime.

>Currently, all Mystery Items are 'Items' and all seasonal equipment is 'Gear'. Is it okay to have both 'Items' and 'Gear'? If so, what makes something 'Gear'? If it is that 'Gear' has a stat bonus, the seasonal accessories would then be 'Items'. Or is 'Gear' default and only Mystery Items are 'Items'? (I might have answered my own question there.)
>If we're using both 'Item' and 'Gear': I changed the Convention accessories to say "Special Edition Convention Item" (instead of 'Armor'); perhaps they should be 'Gear' instead?

>The Absurd Party outfit (175, 279) has no event tag right now. Should it also be labelled 'Limited Edition 2013 Winter Gear'? (Limited Edition 2014 New Year's Item/Gear?)
Should the special equipment in lines 65-74, 159-164, 271-276, 356-359 be tagged Quest, Contributor, etc?
The Rainbow Warrior outfit (178, 317) has a completely different description than anything else, so I wasn't comfortable with messing with it.

>**And the beginnings of a style sheet:**
>1. Description. 2. Stat Effect. 3. Event/Origin(if needed)
>
>.2. Stat Effect:
>No bonus:
>Confers no benefit.
>Single or all stat bonus:
>Increases (Strength/Intelligence/Constitution/Perception/all attributes) by (<%= str %>/<%= int %>/<%= con %>/<%= per %>/<%= attrs %>).
>Two stats, same bonus:
>Increases (Strength/Intelligence/Constitution) and (Intelligence/Constitution/Perception) by <%= attrs %> each.
>Two stats, different bonus
>Increases (Strength/Intelligence/Constitution) by (<%= str %>/<%= int %>/<%= con %>) and (Intelligence/Constitution/Perception) by (<%= int %>/<%= con %>/<%= per %>)].

>Long form:
>Confers no benefit. / Increases (Strength/Intelligence/Constitution/Perception/all attributes) [and (Intelligence/Constitution/Perception)] by (<%= str %>/<%= int %>/<%= con %>/<%= per %>/<%= attrs %>) [each/and (Intelligence/Constitution/Perception) by (<%= int %>/<%= con %>/<%= per %>)].

>.3. Event/Origin:
>(Month) (Year) Subscriber Item.
>Limited Edition (Year) (Season) Gear.