dreamerslab/node.inflection — pull request #33 by overlookmotel (2014-11-27 03:16:47+00:00)
Title: Remove invalid uncountable words

Hi.

I encountered another word that I think is incorrectly identified as uncountable - "permission". Here's an example of it being used in the plural: "Do you have all the necessary permissions?"

While looking through the list of uncountable words in the node.inflection source, I came across quite a few others that I feel are also pluralizable. This PR removes them from the list. I've commented the lines out rather than remove them as this is how you seem to have dealt with other words like "business" that you've decided to remove from the list.

Some of the ones I've removed are arguable either way if they should be considered uncountable or not. I've tended to consider them countable if I can think of any valid sentence which uses the word in the plural. I suspect that there are more words on that list that shouldn't be, but my English is perhaps not as good as it should be as a native English-speaker!

I'm happy to give an explanation on why any of the words I've changed should be considered countable, but I'm pretty confident on them all.

More broadly speaking, I think (if you had the time and energy) it'd be good to update the list according to a known dictionary source e.g. wiktionary.org . It should be possible to automate that process, screen-scraping every word in the dictionary and then testing them against node.inflection's behaviour. That'd solve the problem for once and for all, I think. But that'd be a big job obviously!

I hope that this PR goes some way to moving node.inflection a bit closer to what I think is in line with general English usage anyway...

Please feel free to come back with any comments / disagreements!