mozilla/socorro — pull request #2497 by twobraids (2014-11-25 16:26:14+00:00)
Title: moved dump file deletion to the transform function

In the processor, the 'transform' method creates the file system copies of the dumps to feed to the stackwalker. The Breakpad stackwalker rule deletes the files when it it uses the dumps. This is not a good idea, for two reasons:

1) the system that creates something temporary should take the responsibility to make sure that it deleted properly.

2) if the stalkwalker deletes the temporary dump files, those files are not available for any further rules that may want to examine them. For example, the upcoming 'dumplookup' rule will need to process the dump file, too.

This PR moves the deletion of the tempfiles from the stackwalker rule into the finally clause of the processor_app transform method.