pioneerspacesim/pioneer — pull request #3261 by impaktor (2014-11-25 16:37:48+00:00)
Title: Make love to cargo code

Closes #3168 ("Cargo body collisions has code that needs some love")

This replaces code that was plain wrong with code that is correct.

However, I suspect this "correct" code is also redundant code. The idea for it being there in the first place was to have cargo containers be fragile, and be destroyed when falling to a plannet, thus even very small collisions should count for cargo. So I tried dropping a container from 8 km altidude at Earth, and when it hit the ground, like humpty dumpty's great fall off the wall, the `m_hitpoint` went from 1.0 to 1.0 - 7e-6. So pretty negligeble, and no kings men nor any of the kings horses were needed to put humpty dumpty back again.

The whole if statement for cargo could be removed. Opinions on that?

We could of course have `m_hitpoints` be 0.1 or 0.001 if we wanted. But then the question is of how hard should be be able to fly into cargo with out it begin destroyed (for ships with out cargo scoop). Right now, I can ram it pretty hard twice, and only then is it destoryed.